You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/26 10:45:31 UTC

[GitHub] [camel-kafka-connector] oscerd opened a new issue #746: Possibly moving Integration tests in a separated repository?

oscerd opened a new issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746


   At some point we may end up having a lot of IT tests that may slow down the build. We may maintain just a subset of IT Tests in that case in main repo and moving the other in a different repo. What's your thought on this @valdar @orpiske ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734226238


   I agree that at this point they are already taking far too long to run. 
   
   However,  I'd possibly keep them in this repo. I think we need to start filtering some slow tests in such a way that they can be enabled at will. 
   
   With junit 5 we can annotate the tests with
   
   ```
   @EnabledIfSystemProperty(named = "enable.tests.slow", matches = "true")
   ```
   
   Then, we can enable those tests when needed by using `mvn -Denable.tests.slow=true ...` 
   
   Keeping them separate makes it a bit hard for writing, debugging and test automation IMHO. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734226238


   I agree that at this point they are already taking far too long to run. 
   
   However,  I'd possibly keep them in this repo. I think we need to start filtering some slow tests in such a way that they can be enabled at will. 
   
   With junit 5 we can annotate the tests with
   
   ```
   @EnabledIfSystemProperty(named = "enable.tests.slow", matches = "true"
   ```
   
   Then, we can enable those tests when needed by using `mvn -Denable.tests.slow=true ...` 
   
   Keeping them separate makes it a bit hard for writing, debugging and test automation IMHO. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] oscerd commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-742284768


   I think this is ok through #749 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] oscerd closed issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
oscerd closed issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] orpiske commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734715667


   ![Screenshot_2020-11-27 camel-kafka-connector #246 Test Results  Jenkins (1)](https://user-images.githubusercontent.com/1851560/100428324-11642180-3094-11eb-9d24-5d92111f784c.png)
   
   This is the duration report from a personal CI I have, which runs the tests in multiple configurations (JDKs, w/ Strimzi, Salesforce tests, etc). AWS ones seems to be very big offenders in terms of test duration. 
   
   IMHO, we could probably leave them for running only on Apache CI. My vote would be for a explicit opt-in (via -Denable.tests.slow=true) and I can send a proposal PR later today if you all agree @valdar, @oscerd and anyone else that would like to step in and comment. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] oscerd commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734268748


   Sounds good, but we need to track down the slow ones.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] valdar commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
valdar commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734341062


   +1 on leaving the tests on the same repo and have a way to enable them. I am not sure if a opt in or opt out approach is better though...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] oscerd commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734758566


   +1 for this approach


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] orpiske commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734923661


   Thanks!
   
   Let's see how it goes: https://github.com/apache/camel-kafka-connector/pull/749


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] orpiske commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734226238


   I agree that at this point, they are already taking far too long to run. 
   
   However,  I'd possibly keep them in this repo. I think we need to start filtering some slow tests in such a way that they can be enabled at will. 
   
   With junit 5 we can annotate the tests with
   
   ```
   @EnabledIfSystemProperty(named = "enable.tests.slow", matches = "true"
   ```
   
   Then, we can enable those tests when needed by using `mvn -Denable.tests.slow=true ...` 
   
   Keeping them separate makes it a bit hard for writing, debugging and test automation IMHO. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kafka-connector] orpiske commented on issue #746: Possibly moving Integration tests in a separated repository?

Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #746:
URL: https://github.com/apache/camel-kafka-connector/issues/746#issuecomment-734303436


   Agreed. I think I have some data about these. I'll try to share today or tomorrow. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org