You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/29 18:40:48 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #12890: [Issue 12885]Fix unordered consuming case in Key_Shared subscription.

merlimat commented on a change in pull request #12890:
URL: https://github.com/apache/pulsar/pull/12890#discussion_r758638108



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
##########
@@ -170,6 +170,37 @@ protected void sendMessagesToConsumers(ReadType readType, List<Entry> entries) {
             return;
         }
 
+        // A conner case that we have to retry a readMoreEntries in order to preserver order delivery.

Review comment:
       ```suggestion
           // A corner case that we have to retry a readMoreEntries in order to preserver order delivery.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org