[GitHub] [netbeans] JaroslavTulach commented on pull request #2000: Adding full support for Wildfly 17, 18

[GitBox <gi...@apache.org>]

JaroslavTulach commented on pull request #2000:
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-675890873


   Hello Emmanuel, I have troubles building *wildfly* support behind corporate proxy. Probably the goal of "Removing external downloads and updating schemas" wasn't fully fulfilled. My proxy says that http://java.sun.com/xml/ns/javaee/javaee_6.xsd doesn't exists. When I replace:
   ```diff
   --- a/enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0_1.xsd
   +++ b/enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0_1.xsd
   @@ -61,7 +61,7 @@
             consistency with the Servlet API. </xsd:documentation>
       </xsd:annotation>
    
   -   <xsd:import namespace="http://java.sun.com/xml/ns/javaee" schemaLocation="http://java.sun.com/xml/ns/javaee/javaee_6.xsd"/>
   +   <xsd:import namespace="http://java.sun.com/xml/ns/javaee" schemaLocation="javaee_6.xsd"/>
    
       <xsd:group name="descriptionGroup">
          <xsd:sequence>
   ```
   Then my build succeeds. Btw. I did a grep and there are more places that would deserve replacement:
   ```bash
   netbeans$ grep -r xsd.import.*namespace enterprise/javaee.wildfly/src/
   enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/javaee_6.xsd:  <xsd:import namespace="http://www.w3.org/XML/1998/namespace"
   enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd:    <xsd:import namespace="http://xmlns.jcp.org/xml/ns/javaee" schemaLocation="http://www.jboss.org/schema/jbossas/web-app_4_0.xsd"/>
   enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0_1.xsd:   <xsd:import namespace="http://java.sun.com/xml/ns/javaee" schemaLocation="javaee_6.xsd"/>
   enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_8_1.xsd:   <xsd:import namespace="http://xmlns.jcp.org/xml/ns/javaee" schemaLocation="http://www.jboss.org/schema/jbossas/javaee_8.xsd"/>
   enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/javaee_8.xsd:  <xsd:import namespace="http://www.w3.org/XML/1998/namespace"
   enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3_1.xsd:   <xsd:import namespace="http://java.sun.com/xml/ns/javaee" schemaLocation="http://www.jboss.org/schema/jbossas/web-app_3_0.xsd"/>
   ```
   however when I tried to replace the other, I got missing file errors like `FileNotFoundException: netbeans/enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/web-common_4_0.xsd` - I guess there are additional transitive dependencies that need to be fixed. As such I decided to leave a note here rather than fixing just the one xsd file.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists