[GitHub] [ozone] GeorgeJahad commented on a diff in pull request #4695: HDDS-8489. Refactor GET request to POST for OM DB snapshot

["GeorgeJahad (via GitHub)" <gi...@apache.org>]

GeorgeJahad commented on code in PR #4695:
URL: https://github.com/apache/ozone/pull/4695#discussion_r1190455452


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis_snapshot/OmRatisSnapshotProvider.java:
##########
@@ -76,7 +81,7 @@ public class OmRatisSnapshotProvider extends RDBSnapshotProvider {
   private final Map<String, OMNodeDetails> peerNodesMap;
   private final HttpConfig.Policy httpPolicy;
   private final boolean spnegoEnabled;
-  private final URLConnectionFactory connectionFactory;
+  private URLConnectionFactory connectionFactory;

Review Comment:
   When possible, I prefer not to remove the final modifier just to make tests work.  Could we change the setConnectionFactory() to a getConnectionFactory() method, and mock that method in the test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org