[GitHub] merlimat commented on a change in pull request #717: Reader API for C++ client

[gi...@git.apache.org]

merlimat commented on a change in pull request #717: Reader API for C++ client
URL: https://github.com/apache/incubator-pulsar/pull/717#discussion_r135419101
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -23,8 +23,8 @@ option java_package = "org.apache.pulsar.common.api.proto";
 option optimize_for = LITE_RUNTIME;
 
 message MessageIdData {
-	required uint64 ledgerId = 1;
-	required uint64 entryId  = 2;
+	required int64 ledgerId = 1;
+	required int64 entryId  = 2;
 
 Review comment:
   This change is safe as it doesn't change the encoding on the wire, just the type used in C++. In Java it would anyway be a `long` with no difference. 
   This is required to pass `-1` as special values.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services