You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/29 09:17:48 UTC

[GitHub] [flink] zentol opened a new pull request, #21418: [FLINK-30237][coordination] Only bundle single ZK client

zentol opened a new pull request, #21418:
URL: https://github.com/apache/flink/pull/21418

   Reverts FLINK-13417 and FLINK-16350 since it's no longer required to bundle 2 different clients.
   
   We'll upgrade to 3.7 in FLINK-29420.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #21418: [FLINK-30237][coordination] Only bundle single ZK client

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21418:
URL: https://github.com/apache/flink/pull/21418#discussion_r1034742561


##########
flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh:
##########
@@ -113,7 +113,6 @@ function run_ha_test() {
     # jm killing loop
     set_config_key "env.pid.dir" "${TEST_DATA_DIR}"
 
-    setup_flink_shaded_zookeeper ${ZOOKEEPER_VERSION}

Review Comment:
   No I just missed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21418: [FLINK-30237][coordination] Only bundle single ZK client

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21418:
URL: https://github.com/apache/flink/pull/21418#issuecomment-1330324897

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "914511a382988333dfd9d0dfcc28158d197660ed",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "914511a382988333dfd9d0dfcc28158d197660ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 914511a382988333dfd9d0dfcc28158d197660ed UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on a diff in pull request #21418: [FLINK-30237][coordination] Only bundle single ZK client

Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #21418:
URL: https://github.com/apache/flink/pull/21418#discussion_r1034696632


##########
flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh:
##########
@@ -113,7 +113,6 @@ function run_ha_test() {
     # jm killing loop
     set_config_key "env.pid.dir" "${TEST_DATA_DIR}"
 
-    setup_flink_shaded_zookeeper ${ZOOKEEPER_VERSION}

Review Comment:
   Is there a reason to keep `${ZOOKEEPER_VERSION}` as a parameter in this method? It's not really needed anymore analogously to the other files where we reverted mentioning the ZK version in the log output.



##########
flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh:
##########
@@ -113,7 +113,6 @@ function run_ha_test() {
     # jm killing loop
     set_config_key "env.pid.dir" "${TEST_DATA_DIR}"
 
-    setup_flink_shaded_zookeeper ${ZOOKEEPER_VERSION}

Review Comment:
   We're even removing the ZK version in `run-nightly-tests.sh` as a parameter of `test_ha_per_job_cluster_datastream.sh`. So, I guess, we can clean it up entirely here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #21418: [FLINK-30237][coordination] Only bundle single ZK client

Posted by GitBox <gi...@apache.org>.
zentol merged PR #21418:
URL: https://github.com/apache/flink/pull/21418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org