You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/10 21:54:46 UTC
[GitHub] [airflow] pingzh opened a new pull request #21504: Set larger limit get_partitions_by_filter in HiveMetastoreHook
pingzh opened a new pull request #21504:
URL: https://github.com/apache/airflow/pull/21504
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
With the large size of the hive metastore, setting limit to 1 will create a scan query that is too heavy to handle. Setting the limit to HiveMetastoreHook.MAX_PART_COUNT will generate a query using index and scan much less rows( not guaranteed, depending on the table, some table may still got a scan query but we are limited by thrift lib as the limit is a short int).
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21504: Set larger limit get_partitions_by_filter in HiveMetastoreHook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21504:
URL: https://github.com/apache/airflow/pull/21504#issuecomment-1035571400
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21504: Set larger limit get_partitions_by_filter in HiveMetastoreHook
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21504:
URL: https://github.com/apache/airflow/pull/21504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #21504: Set larger limit get_partitions_by_filter in HiveMetastoreHook
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #21504:
URL: https://github.com/apache/airflow/pull/21504#discussion_r804247073
##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -556,7 +556,9 @@ def check_for_partition(self, schema: str, table: str, partition: str) -> bool:
True
"""
with self.metastore as client:
- partitions = client.get_partitions_by_filter(schema, table, partition, 1)
+ partitions = client.get_partitions_by_filter(
+ schema, table, partition, HiveMetastoreHook.MAX_PART_COUNT
Review comment:
Is this a breaking change?
is 1 is not desirable in all cases? (if there are valid use cases for 1 then maybe we should make the 4th parameter (limit) configurable thus allowing each user to set whatever value he wishes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on a change in pull request #21504: Set larger limit get_partitions_by_filter in HiveMetastoreHook
Posted by GitBox <gi...@apache.org>.
pingzh commented on a change in pull request #21504:
URL: https://github.com/apache/airflow/pull/21504#discussion_r804257340
##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -556,7 +556,9 @@ def check_for_partition(self, schema: str, table: str, partition: str) -> bool:
True
"""
with self.metastore as client:
- partitions = client.get_partitions_by_filter(schema, table, partition, 1)
+ partitions = client.get_partitions_by_filter(
+ schema, table, partition, HiveMetastoreHook.MAX_PART_COUNT
Review comment:
good call. it isn't a breaking change since it is invoked inside `check_for_partition`, which returns `bool`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21504: Set larger limit get_partitions_by_filter in HiveMetastoreHook
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21504:
URL: https://github.com/apache/airflow/pull/21504#discussion_r804432910
##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -556,7 +556,9 @@ def check_for_partition(self, schema: str, table: str, partition: str) -> bool:
True
"""
with self.metastore as client:
- partitions = client.get_partitions_by_filter(schema, table, partition, 1)
+ partitions = client.get_partitions_by_filter(
+ schema, table, partition, HiveMetastoreHook.MAX_PART_COUNT
Review comment:
Correct! Nice one :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org