You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Jonathan Valliere (Jira)" <ji...@apache.org> on 2020/09/01 00:27:00 UTC
[jira] [Commented] (DIRMINA-1130) NIO socket acceptor should not
set send buffer size on ServerSocket/Channel.
[ https://issues.apache.org/jira/browse/DIRMINA-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188059#comment-17188059 ]
Jonathan Valliere commented on DIRMINA-1130:
--------------------------------------------
That patch does not work on the current 2.1.X or 2.0.X branches
See https://gitbox.apache.org/repos/asf?p=mina.git;a=tree;f=mina-core/src/test/java/org/apache/mina/transport/socket/nio;h=3bc73e75c7130ab5e719bc58bee69d390b07d9a7;hb=refs/heads/2.1.X
> NIO socket acceptor should not set send buffer size on ServerSocket/Channel.
> ----------------------------------------------------------------------------
>
> Key: DIRMINA-1130
> URL: https://issues.apache.org/jira/browse/DIRMINA-1130
> Project: MINA
> Issue Type: Bug
> Components: Transport
> Affects Versions: 2.1.4
> Reporter: Marcin L
> Assignee: Jonathan Valliere
> Priority: Major
> Attachments: nio_socket_acceptor_test.patch
>
>
> NIO socket acceptor should not set *send buffer size* on ServerSocket/Channel.
> Setting *SO_SNDBUF* in NioSocketAcceptor as part of https://issues.apache.org/jira/projects/DIRMINA/issues/DIRMINA-1123 was unecessary.
> *SO_SNDBUF* can be set after socket listen() and connect() system calls. Setting send buffer size will most likely throw Exception in *NioSocketAcceptor* (hotspot JVM).
> See
> sun.nio.ch.ServerSocketChannelImpl#supportedOptions ->
> sun.nio.ch.ServerSocketChannelImpl.DefaultOptionsHolder#defaultOptions
> [http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> [https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> Seems like only these options are supported and should be set before socket connection.
> SO_RCVBUF
> SO_REUSEADDR
> SO_REUSEPORT
> IP_TOS
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org