[GitHub] [spark] wangyum commented on a change in pull request #31646: [SPARK-34538][SQL] Hive Metastore support filter by not-in

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #31646:
URL: https://github.com/apache/spark/pull/31646#discussion_r582821409



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -748,6 +748,10 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
       values.map(value => s"$name = $value").mkString("(", " or ", ")")
     }
 
+    def convertNotInToAnd(name: String, values: Seq[String]): String = {
+      values.map(value => s"$name != $value").mkString("(", " and ", ")")

Review comment:
       More than 10,000 values will cause the Hive Metastore stack overflow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org