[GitHub] [incubator-pinot] icefury71 edited a comment on issue #4778: Decoupling Server instance name from physical host and port

[GitBox <gi...@apache.org>]

icefury71 edited a comment on issue #4778: Decoupling Server instance name from physical host and port
URL: https://github.com/apache/incubator-pinot/pull/4778#issuecomment-549568916
 
 
   > I thought we could modify the existing routing table listener/handler. Let me check the code.
   
   Yes we could (modify HelixExternalViewBasedRouting). I did not in my first draft since I needed to make too many changes (create a singleton so that its easy to access in different places and have to move it to pinot-common). 
   
   We could keep the HelixInstanceConfigCache as a separate class inside pinot-common but populate the cache using HelixExternalViewBasedRouting (instead of yet another ClusterChangeHandler). 
   
   @kishoreg thoughts ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org