[GitHub] [pinot] walterddr commented on pull request #10315: [multistage] properly support query hint

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on PR #10315:
URL: https://github.com/apache/pinot/pull/10315#issuecomment-1438836279

   > @walterddr I have not looked at the code changes here (will look in some time). But I do have a PR out that adds supports for SQL Hints in Pinot - #10248. Can you please take a look? We can discuss about how to converge the changes.
   
   ah. I haven't taken a look at #10248 will try to get to it today. 
   The goal of this PR is simply setting up a framework for hints. we can add hint strategies later. 
   
   As of the test i added. I am not actually suggesting we use the aggFinalStage as the hint to indicate --> the AGG_FINAL_STAGE is suppose to be only used by internal pinot rules. 
   
   we can discuss what to add later, but could you please take a look at the overall framework and see if the HintStrategyTable aligns with your proposed PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org