[GitHub] [druid] LakshSingla commented on pull request #13138: Fix the Injector creation in HadoopTask

[GitBox <gi...@apache.org>]

LakshSingla commented on PR #13138:
URL: https://github.com/apache/druid/pull/13138#issuecomment-1255315310

   Regarding:
   > About testing: how did test your fix here
   
   Manual testing has been done to identify the cause of the original problem: submitted ingestion jobs weren't picking up the location of the custom location where druid deps were present. Testing on a local setup revealed that the `ExtensionsConfig` wasn't getting populated correctly irrespective of whatever was supplied in the config file. After discussion with @paul-rogers, it seemed like that the injector was at fault, and didn't contain the properties passed in the config to properly instantiate the `ExtensionsConfig`.
   Important note, the fix has been verified through manual logs/debug points, and the fix hasn't been verified on the original failing ingestion job yet. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org