[jira] [Commented] (IMPALA-12730) Avoid Weverything for Clang Tidy

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824562#comment-17824562 ] 

ASF subversion and git services commented on IMPALA-12730:
----------------------------------------------------------

Commit befa93ffa6b0fa50c614b6e24faf25443ec50d90 in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=befa93ffa ]

IMPALA-12730: Don't use -Weverything for clang-tidy

For current clang-tidy builds, we enable -Weverything and then
explicitly disable a couple verbose warnings. Clang-tidy uses
these warnings to produce its clang-diagnostic-* issues.
This gives clang-tidy the maximum flexibility to enforce any
warning the Clang can produce, but in practice, we disable
them via the .clang-tidy file's Checks: section.

The output from a -Weverything build is enormous and hard to
navigate. When there is a compilation issue, digging through
the logs is arduous. Clang discourages the use of -Weverything,
as it contains many noisy warnings.

This changes the clang-tidy build to use -Wextra instead and
shrinks the list of disabled clang-diagnostic-* issues
accordingly.

Testing:
 - Verified that bin/run_clang_tidy.sh passes

Change-Id: Ib4f4cc9a6d040b90495496b2396a26f3c5189231
Reviewed-on: http://gerrit.cloudera.org:8080/21112
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Avoid Weverything for Clang Tidy
> --------------------------------
>
>                 Key: IMPALA-12730
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12730
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.4.0
>            Reporter: Joe McDonnell
>            Priority: Major
>
> When building Impala for Clang Tidy, we turn on -Weverything
> {noformat}
> SET(CXX_FLAGS_TIDY "${CXX_FLAGS_TIDY} -Wall -W -Weverything -Wno-c++98-compat -Wno-padded"){noformat}
> Clang Tidy uses these warnings to implement the "clang-diagnostic" Clang Tidy issues. The other Clang Tidy checkers don't need Weverything to function. Since we now use -Werror for our Clang builds, I think anything we would want to find with this could also be found by adding extra warnings to the regular Clang build.
> Weverything is super verbose and makes build failures much harder to find in the logs. It changes across Clang versions. In general, I think it is not worth it anymore. We could remove it and clean up .clang-tidy.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org