You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dimas-b (via GitHub)" <gi...@apache.org> on 2023/05/31 16:15:05 UTC
[GitHub] [iceberg] dimas-b commented on a diff in pull request #7702: Nessie: exercise tests against Nessie's new storage model
dimas-b commented on code in PR #7702:
URL: https://github.com/apache/iceberg/pull/7702#discussion_r1211976041
##########
build.gradle:
##########
@@ -824,8 +824,19 @@ project(':iceberg-pig') {
}
project(':iceberg-nessie') {
- test {
- useJUnitPlatform()
+ if (JavaVersion.current().isJava11Compatible()) {
+ test {
+ useJUnitPlatform()
+ }
+ } else {
+ // Do not test Nessie against Java 8, because in-JVM testing requires Nessie server components,
+ // which require Java 11+.
+ test {
+ enabled = false
+ }
+ compileTestJava {
+ enabled = false
Review Comment:
Maybe still compile tests to detect accidental syntax errors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org