Re: [PR] [SPARK-46052][CORE] Remove function TaskScheduler.killAllTaskAttempts [spark]

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #43954:
URL: https://github.com/apache/spark/pull/43954#discussion_r1411502671


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2603,4 +2603,13 @@ package object config {
       .stringConf
       .toSequence
       .createWithDefault("org.apache.spark.sql.connect.client" :: Nil)
+
+  private[spark] val LEGACY_ABORT_STAGE_AFTER_CANCEL_TASKS =
+    ConfigBuilder("spark.legacy.scheduler.stage.abortAfterCancelTasks")

Review Comment:
   Namespace it below `scheduler` ? Something like `spark.scheduler.stage.legacyAbortAfterCancelTasks` ...
   Also, mark it as `internal` ?
   
   Btw, we should flip this switch on and off in the relevant tests to check if the behavior is preserved.



##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2603,4 +2603,13 @@ package object config {
       .stringConf
       .toSequence
       .createWithDefault("org.apache.spark.sql.connect.client" :: Nil)
+
+  private[spark] val LEGACY_ABORT_STAGE_AFTER_CANCEL_TASKS =
+    ConfigBuilder("spark.legacy.scheduler.stage.abortAfterCancelTasks")
+      .doc("Whether to abort a stage after TaskScheduler.cancelTasks(). This is used to restore " +
+        "the original behavior in case there are any regressions after abort stage is removed " +
+        "from TaskScheduler.cancelTasks()")
+      .version("4.0.0")
+      .booleanConf
+      .createWithDefault(false)

Review Comment:
   Do we want to default to `true` and switch to `false` in a later ver ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org