You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by szheng79 <gi...@git.apache.org> on 2015/04/28 21:46:14 UTC
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
GitHub user szheng79 opened a pull request:
https://github.com/apache/spark/pull/5754
[SPARK-6994]Add helper methods to access by field
This is a trial change, is useful in java (because java developer can't benefit from getAs[T] method).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/szheng79/spark patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5754.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5754
----
commit 9c774f619e9820e2a01ead272f5ab339e938f8af
Author: szheng79 <sz...@gmail.com>
Date: 2015-04-28T19:45:53Z
[SPARK-6994]Add helper methods to access by field
This is a trial change, is useful in java (because java developer can't benefit from getAs[T] method).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-164880698
ping @szheng79 can you rebase to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by szheng79 <gi...@git.apache.org>.
Github user szheng79 commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-97477450
I just think it is best for a java developer has more specific way to control the return type. Like current there is these version of methods to access row by index.
Because I move my code base from getString(int) like method, so it is a bit lazy for me to change everywhere. So I think if I need to have these helper method, I just add them to the code, so make it consistent with current method style.
But I have no preference on whether we must have this. If here people think we better don't have these, I will delete the pull request :).
And to me, if we don't have these, I will say we better only keep getAs[T](int) and getAs[T](String), instead of only have getString(int index) like method without similar getString(String fieldName)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-168112784
I'm going to close this pull request. If this is still relevant and you are interested in pushing it forward, please open a new pull request. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-97183870
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-97477150
@szheng79 this has nothing to do with SPARK-6994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by szheng79 <gi...@git.apache.org>.
Github user szheng79 commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-97485938
@srowen I say it is with SPARK-6994, because the implementation must based on SPARK-6994 change. And because this is a very minor change, I don't want to hijack other people's credit. So I just put it under 6994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-97320918
Why can't Java user use getAs[T]?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5754
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6994]Add helper methods to access by fi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5754#issuecomment-97497063
That's my fault. I typed the wrong JIRA. Yes it is related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org