[GitHub] [spark] viirya commented on a change in pull request #24039: [SPARK-27117][SQL] current_date/current_timestamp should not refer to columns with ansi parser mode

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24039: [SPARK-27117][SQL] current_date/current_timestamp should not refer to columns with ansi parser mode
URL: https://github.com/apache/spark/pull/24039#discussion_r264001792
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##########
 @@ -1212,6 +1212,21 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
     }
   }
 
+  override def visitCurrentDatetime(ctx: CurrentDatetimeContext): AnyRef = {
 
 Review comment:
   Shouldn't it be?
   
   ```scala
   override def visitCurrentDatetime(ctx: CurrentDatetimeContext): Expression = withOrigin(ctx) {
     ...
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org