You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2009/03/07 23:42:36 UTC
Re: svn commit: r36401 - trunk/subversion/libsvn_wc
Oh yeah...
Summary of test results:
1037 tests PASSED
24 tests SKIPPED
24 tests XFAILED
64 tests FAILED
2 tests XPASSED
On Sat, Mar 7, 2009 at 23:41, Greg Stein <gs...@gmail.com> wrote:
> Author: gstein
> Date: Sat Mar 7 14:41:58 2009
> New Revision: 36401
>
> Log:
> Small tweak in the ADD vs COPY detection. If original_repos_relpath is
> non-NULL, then this is definitely a copy, regardless of cmt_rev.
>
> * subversion/libsvn_wc/entries.c:
> (read_entries): correct the ADD vs COPY detection
>
> Modified:
> trunk/subversion/libsvn_wc/entries.c
>
> Modified: trunk/subversion/libsvn_wc/entries.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/entries.c?pathrev=36401&r1=36400&r2=36401
> ==============================================================================
> --- trunk/subversion/libsvn_wc/entries.c Sat Mar 7 14:39:14 2009 (r36400)
> +++ trunk/subversion/libsvn_wc/entries.c Sat Mar 7 14:41:58 2009 (r36401)
> @@ -1080,7 +1080,8 @@ read_entries(svn_wc_adm_access_t *adm_ac
> result_pool,
> iterpool));
>
> - if (!SVN_IS_VALID_REVNUM(entry->cmt_rev))
> + if (!SVN_IS_VALID_REVNUM(entry->cmt_rev)
> + && original_repos_relpath == NULL)
> {
> /* There is NOT a last-changed revision (last-changed date and
> author may be unknown, but we can always check the rev).
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1285465
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1285738
Re: svn commit: r36401 - trunk/subversion/libsvn_wc
Posted by Greg Stein <gs...@gmail.com>.
On Sun, Mar 8, 2009 at 02:15, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> On Mar 7, 2009, at 5:56 PM, Branko Cibej wrote:
>
>> Greg Stein wrote:
>>> Oh yeah...
>>>
>>> Summary of test results:
>>> 1037 tests PASSED
>>> 24 tests SKIPPED
>>> 24 tests XFAILED
>>> 64 tests FAILED
>>> 2 tests XPASSED
>>>
>>
>> Out of interest, are the two XPASSes a genuine fix of currently broken
>> behaviour, or are they just a fluke?
>
> I suspect these tests test a failure condition that isn't yet
> implemented (that is, they expect a failure to pass, but because there
> is no failure detected, they fail, and are marked as XFAIL). My guess
> is that wc-ng currently causes failures in these scenarios, though not
> for the intended reason. That leads to the XPASS.
Huh?
Too many unreferenced pronouns and double negatives.
In short: no, we've done nothing to fix broken behavior. We're trying
to precisely mirror the prior behavior of the various wc_entry related
functionality.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1286384
Re: svn commit: r36401 - trunk/subversion/libsvn_wc
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Mar 7, 2009, at 5:56 PM, Branko Cibej wrote:
> Greg Stein wrote:
>> Oh yeah...
>>
>> Summary of test results:
>> 1037 tests PASSED
>> 24 tests SKIPPED
>> 24 tests XFAILED
>> 64 tests FAILED
>> 2 tests XPASSED
>>
>
> Out of interest, are the two XPASSes a genuine fix of currently broken
> behaviour, or are they just a fluke?
I suspect these tests test a failure condition that isn't yet
implemented (that is, they expect a failure to pass, but because there
is no failure detected, they fail, and are marked as XFAIL). My guess
is that wc-ng currently causes failures in these scenarios, though not
for the intended reason. That leads to the XPASS.
-Hyrum
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1286141
Re: svn commit: r36401 - trunk/subversion/libsvn_wc
Posted by Branko Cibej <br...@xbc.nu>.
Greg Stein wrote:
> Oh yeah...
>
> Summary of test results:
> 1037 tests PASSED
> 24 tests SKIPPED
> 24 tests XFAILED
> 64 tests FAILED
> 2 tests XPASSED
>
Out of interest, are the two XPASSes a genuine fix of currently broken
behaviour, or are they just a fluke?
-- Brane
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1285794