You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "David Li (Jira)" <ji...@apache.org> on 2021/12/22 20:16:00 UTC

[jira] [Resolved] (ARROW-15143) [C++] Remove incorrect comment on API of Transform for StringBinaryTransformExecBase

     [ https://issues.apache.org/jira/browse/ARROW-15143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Li resolved ARROW-15143.
------------------------------
    Resolution: Fixed

Issue resolved by pull request 12029
[https://github.com/apache/arrow/pull/12029]

> [C++] Remove incorrect comment on API of Transform for StringBinaryTransformExecBase
> ------------------------------------------------------------------------------------
>
>                 Key: ARROW-15143
>                 URL: https://issues.apache.org/jira/browse/ARROW-15143
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Eduardo Ponce
>            Assignee: Eduardo Ponce
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 7.0.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The [comment describing the API of Transform method for classes that inherit from StringBinaryTransformExecBase|https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/scalar_string.cc#L626] incorrectly states there is a last parameter for returning error status. Instead the Transform method indicates an error by returning a negative value.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)