You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "Olaf Flebbe (JIRA)" <ji...@apache.org> on 2015/01/07 15:51:35 UTC
[jira] [Comment Edited] (BIGTOP-1579) Improve Bigtop Toolchain :
Create diff files
[ https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267692#comment-14267692 ]
Olaf Flebbe edited comment on BIGTOP-1579 at 1/7/15 2:50 PM:
-------------------------------------------------------------
Basically the idea is to use automatic patching already provided by dpkg_source and rpmbuild
Debian Patches are patch -p1 files in debian/patches/xxx and a debian/patches/series file stating the order of how to apply patches. This is conceptually very similar to the RPM spec file approach naming indiviual patches
RPMbuild Patches can be applied with %patch -p1 (and declared with patch<number>: filename).
I propose to use a naming convention patch0_foo.diff ... patch1_bar.diff files (of patch -p1 format) in bigtop-packages/src/common . This would be automagically moved to debian/patches/ and the series file generated in the debian way. In RPM these files will be moved to SOURCES directory and have to be integrated into the SPEC file (that's tricky) .
was (Author: oflebbe):
Basically the idea is to use automatic patching already provided by dpkg_source and rpmbuild
Debian Patches are patch -p1 files in debian/patches/xxx and a debian/patches/series file stating the order of how to apply patches. This is conceptually very similar to the RPM spec file approach naming indiviual patches
RPMbuild Patches can be applied with %patch -p1 (and declared with patch<number>: filename).
I propose to use a naming convention patch0_foo.diff ... patch1_bar.diff files (of patch -p1 format) in bigtop-packages/src/common . This would be automagically moved to debian/patches/ and the series file generated in the debian way. In RPM these files will be moved to SOURCES directory and has to be integrated into the SPEC file (that's tricky) .
> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
> Key: BIGTOP-1579
> URL: https://issues.apache.org/jira/browse/BIGTOP-1579
> Project: Bigtop
> Issue Type: Bug
> Components: build
> Reporter: Olaf Flebbe
> Fix For: 0.9.0
>
>
> Right now, we apply changes/patches in the do-build-component script in the bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild / debuild to apply patches. But right now the gradle script is not flexible enough. Since make is now obsolete we can improve this situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)