You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2017/01/18 17:17:40 UTC

[GitHub] flink pull request #3164: [FLINK-5556] [checkpointing] Report correct buffer...

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/3164

    [FLINK-5556] [checkpointing] Report correct buffered bytes during alignment

    During stream alignment via the `BarrierTracker`, we were reporting the wrong number of spilled bytes, because the `bytesWritten` in `BufferSpiller` were reset before the checkpoint notification happens.
    
    Instead of `bufferSpiller.getBytesWritten()` I use `SpilledBufferOrEventSequence.size()` if `currentBuffered != null`.
    
    I adjusted one `BarrierBufferTest` to check the expected number of buffered bytes. Before the check was only for `>= 0`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 5556-reset_bytes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3164
    
----
commit 591fa4c600ef70432e8162584ab89dd5c0508da6
Author: Ufuk Celebi <uc...@apache.org>
Date:   2017-01-18T17:14:16Z

    [FLINK-5556] [checkpointing] Report correct buffered bytes during alignment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3164: [FLINK-5556] [checkpointing] Report correct buffer...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3164


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3164: [FLINK-5556] [checkpointing] Report correct buffered byte...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3164
  
    Very good, +1 to merge this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---