You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/14 06:45:25 UTC
[GitHub] [incubator-nuttx-apps] zhhyu7 opened a new pull request #1064: [DRAFT]feature: wapi add encode parse when scan
zhhyu7 opened a new pull request #1064:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1064
wapi add encode parse when scan
fix: ap socket can not accept twice
rpmsg: pointer of netdev ioctl support cross-core access via clean dcache
fix: iperf can not exit when stop
Signed-off-by: zhanghongyu <zh...@xiaomi.com>
Change-Id: Ic9959a7426091ee2f35b68cb41c14a9e343468ac
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1064: feature: wapi add encode parse when scan
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1064:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1064#discussion_r825814903
##########
File path: netutils/usrsock_rpmsg/usrsock_rpmsg_client.c
##########
@@ -155,6 +161,41 @@ static int usrsock_rpmsg_ept_cb(struct rpmsg_endpoint *ept, void *data,
return ret;
}
+#ifdef CONFIG_NETDEV_WIRELESS_IOCTL
+
+static void usersock_coherent_cache(FAR void *buf,
+ enum usrsock_cache_action_e action)
+{
+ FAR struct usrsock_request_ioctl_s *req = buf;
+ FAR struct iwreq *wlreq;
+
+ if (req->head.reqid == USRSOCK_REQUEST_IOCTL)
+ {
+ if (WL_IS80211POINTERCMD(req->cmd))
+ {
+ wlreq = (FAR struct iwreq *)(req + 1);
+ if (action == USRSOCK_COHERENT_BEFORE)
+ {
+ metal_cache_flush(wlreq->u.data.pointer,
Review comment:
usrsock rpmag is built on the top of openamp/libmetal, it's reasonable to call meta_ API instead of NuttX specific API to improve the portability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1064: feature: wapi add encode parse when scan
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1064:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1064#discussion_r825825813
##########
File path: netutils/usrsock_rpmsg/usrsock_rpmsg.h
##########
@@ -27,6 +27,11 @@
#include <nuttx/net/usrsock.h>
+#ifdef CONFIG_NETDEV_WIRELESS_IOCTL
+# include <nuttx/wireless/wireless.h>
+# include <metal/cache.h>
Review comment:
Ok. Some time ago I worked with SiFive RISC-V metal SDK, so was a bit confused. Thank you for explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1064: [DRAFT]feature: wapi add encode parse when scan
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1064:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1064#discussion_r825656290
##########
File path: netutils/usrsock_rpmsg/usrsock_rpmsg.h
##########
@@ -27,6 +27,11 @@
#include <nuttx/net/usrsock.h>
+#ifdef CONFIG_NETDEV_WIRELESS_IOCTL
+# include <nuttx/wireless/wireless.h>
+# include <metal/cache.h>
Review comment:
Where this file is located?
##########
File path: netutils/usrsock_rpmsg/usrsock_rpmsg_client.c
##########
@@ -155,6 +161,41 @@ static int usrsock_rpmsg_ept_cb(struct rpmsg_endpoint *ept, void *data,
return ret;
}
+#ifdef CONFIG_NETDEV_WIRELESS_IOCTL
+
+static void usersock_coherent_cache(FAR void *buf,
+ enum usrsock_cache_action_e action)
+{
+ FAR struct usrsock_request_ioctl_s *req = buf;
+ FAR struct iwreq *wlreq;
+
+ if (req->head.reqid == USRSOCK_REQUEST_IOCTL)
+ {
+ if (WL_IS80211POINTERCMD(req->cmd))
+ {
+ wlreq = (FAR struct iwreq *)(req + 1);
+ if (action == USRSOCK_COHERENT_BEFORE)
+ {
+ metal_cache_flush(wlreq->u.data.pointer,
Review comment:
Is `metal_` some arch specific API. Maybe we can use `up_invalidate_dcache`/`up_flush_dcache` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] zhhyu7 closed pull request #1064: feature: wapi add encode parse when scan
Posted by GitBox <gi...@apache.org>.
zhhyu7 closed pull request #1064:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1064: feature: wapi add encode parse when scan
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1064:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1064#discussion_r825813946
##########
File path: netutils/usrsock_rpmsg/usrsock_rpmsg.h
##########
@@ -27,6 +27,11 @@
#include <nuttx/net/usrsock.h>
+#ifdef CONFIG_NETDEV_WIRELESS_IOCTL
+# include <nuttx/wireless/wireless.h>
+# include <metal/cache.h>
Review comment:
libmetal is part of OpenAMP framework:
https://github.com/OpenAMP/libmetal/blob/main/lib/cache.h#L33-L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org