You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by sa...@apache.org on 2021/09/21 13:35:32 UTC
[incubator-nuttx] 01/02: boards/esp32: Remove "return ret" from
bringup function
This is an automated email from the ASF dual-hosted git repository.
sara pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7edb39f880aa3ad529b2009bf6c7edae9c4b78a9
Author: Alan C. Assis <ac...@gmail.com>
AuthorDate: Wed Sep 15 15:22:51 2021 -0300
boards/esp32: Remove "return ret" from bringup function
During the lcd1602 tests on our internal CI we noticed that the
lcd1602 was failing because there is not a I2C display in the
emulated board on QEMU. It is better to remove the "return ret"
from the bringup because the user will see the error anyway.
---
boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c | 13 -------------
boards/xtensa/esp32/esp32-ethernet-kit/src/esp32_bringup.c | 8 --------
boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c | 13 -------------
3 files changed, 34 deletions(-)
diff --git a/boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c b/boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c
index c1c79bf..9778b67 100644
--- a/boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c
+++ b/boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c
@@ -174,7 +174,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize SD slot: %d\n", ret);
- return ret;
}
#endif
@@ -188,7 +187,6 @@ int esp32_bringup(void)
if (ret)
{
syslog(LOG_ERR, "ERROR: Failed to initialize SPI Flash\n");
- return ret;
}
#endif
@@ -198,7 +196,6 @@ int esp32_bringup(void)
{
syslog(LOG_ERR, "ERROR: Failed to initialize partition error=%d\n",
ret);
- return ret;
}
#endif
@@ -216,7 +213,6 @@ int esp32_bringup(void)
{
syslog(LOG_ERR, "ERROR: Failed to initialize wireless subsystem=%d\n",
ret);
- return ret;
}
#endif
@@ -233,7 +229,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -244,7 +239,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -255,7 +249,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -266,7 +259,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -321,7 +313,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize GPIO Driver: %d\n", ret);
- return ret;
}
#endif
@@ -333,7 +324,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize I2C Driver for I2C0: %d\n", ret);
- return ret;
}
#endif
@@ -343,7 +333,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize I2C Driver for I2C1: %d\n", ret);
- return ret;
}
#endif
@@ -357,7 +346,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize BMP180 driver: %d\n", ret);
- return ret;
}
#endif
@@ -369,7 +357,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize HT16K33 driver: %d\n", ret);
- return ret;
}
#endif
diff --git a/boards/xtensa/esp32/esp32-ethernet-kit/src/esp32_bringup.c b/boards/xtensa/esp32/esp32-ethernet-kit/src/esp32_bringup.c
index a830c3c..7285d87 100644
--- a/boards/xtensa/esp32/esp32-ethernet-kit/src/esp32_bringup.c
+++ b/boards/xtensa/esp32/esp32-ethernet-kit/src/esp32_bringup.c
@@ -133,7 +133,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize SD slot: %d\n", ret);
- return ret;
}
#endif
@@ -147,7 +146,6 @@ int esp32_bringup(void)
if (ret)
{
syslog(LOG_ERR, "ERROR: Failed to initialize SPI Flash\n");
- return ret;
}
#endif
@@ -157,7 +155,6 @@ int esp32_bringup(void)
{
syslog(LOG_ERR, "ERROR: Failed to initialize partition error=%d\n",
ret);
- return ret;
}
#endif
@@ -175,7 +172,6 @@ int esp32_bringup(void)
{
syslog(LOG_ERR, "ERROR: Failed to initialize wireless subsystem=%d\n",
ret);
- return ret;
}
#endif
@@ -192,7 +188,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -203,7 +198,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -214,7 +208,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -225,7 +218,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
diff --git a/boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c b/boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c
index 2a6152b..52a3991 100644
--- a/boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c
+++ b/boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c
@@ -159,7 +159,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize PCF8574 LCD, error %d\n", ret);
- return ret;
}
#endif
@@ -168,7 +167,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize SD slot: %d\n", ret);
- return ret;
}
#endif
@@ -182,7 +180,6 @@ int esp32_bringup(void)
if (ret)
{
syslog(LOG_ERR, "ERROR: Failed to initialize SPI Flash\n");
- return ret;
}
#endif
@@ -192,7 +189,6 @@ int esp32_bringup(void)
{
syslog(LOG_ERR, "ERROR: Failed to initialize partition error=%d\n",
ret);
- return ret;
}
#endif
@@ -210,7 +206,6 @@ int esp32_bringup(void)
{
syslog(LOG_ERR, "ERROR: Failed to initialize wireless subsystem=%d\n",
ret);
- return ret;
}
#endif
@@ -227,7 +222,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -238,7 +232,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -249,7 +242,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -260,7 +252,6 @@ int esp32_bringup(void)
syslog(LOG_ERR,
"ERROR: Failed to initialize timer driver: %d\n",
ret);
- return ret;
}
#endif
@@ -305,7 +296,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize GPIO Driver: %d\n", ret);
- return ret;
}
#endif
@@ -317,7 +307,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize I2C Driver for I2C0: %d\n", ret);
- return ret;
}
#endif
@@ -327,7 +316,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize I2C Driver for I2C1: %d\n", ret);
- return ret;
}
#endif
@@ -341,7 +329,6 @@ int esp32_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "Failed to initialize BMP180 driver: %d\n", ret);
- return ret;
}
#endif