You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Shwetha GS <ss...@hortonworks.com> on 2016/04/27 14:44:28 UTC
Review Request 46731: ATLAS-716 Entity update/delete notifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-716
https://issues.apache.org/jira/browse/ATLAS-716
Repository: atlas
Description
-------
1. Update/delete entity APIs return list of entities created, updated and deleted
2. Listeners are called for all the affected entities
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java a28b4ac
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 749294f
addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
client/src/main/java/org/apache/atlas/AtlasClient.java 22a1726
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
pom.xml 2ccabc3
repository/pom.xml 533e48b
repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceState.java 6b39970
webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
Diff: https://reviews.apache.org/r/46731/diff/
Testing
-------
UTs
Thanks,
Shwetha GS
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134619
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On May 24, 2016, 7:34 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 7:34 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java 7e32cc2
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 7cd83f8
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java c8c1067
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/
-----------------------------------------------------------
(Updated May 24, 2016, 7:34 a.m.)
Review request for atlas.
Changes
-------
Re-based, addressed review comments
Bugs: ATLAS-716
https://issues.apache.org/jira/browse/ATLAS-716
Repository: atlas
Description
-------
1. Update/delete entity APIs return list of entities created, updated and deleted
2. Listeners are called for all the affected entities
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
client/src/main/java/org/apache/atlas/AtlasClient.java 7e32cc2
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 7cd83f8
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
server-api/src/main/java/org/apache/atlas/services/MetadataService.java c8c1067
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
Diff: https://reviews.apache.org/r/46731/diff/
Testing
-------
UTs
Thanks,
Shwetha GS
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 23, 2016, 5:02 a.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java, line 318
> > <https://reviews.apache.org/r/46731/diff/3/?file=1387706#file1387706line318>
> >
> > why is the check for isComposite removed? Can you pls explain?
>
> Shwetha GS wrote:
> For example, in case of soft delete, if the column is deleted, we don't update the table's columns attribute. So, table definition returns the list of columns that includes deleted columns as well.
>
> For hive_process, when table is deleted, the reference is not removed. To be consistent, for hive_table, when column is deleted, reference is not removed as well
>
> Suma Shivaprasad wrote:
> Wouldnt this be an issue in case of hard deletes?
the iscomposite condition is used to update the reverse reference
like removing column reference from table columns
currently, it uses just shouldUpdateReverseAttribute check
shouldUpdateReverseAttribute is set to true for hard delete
shouldUpdateReverseAttribute is false for soft delete
after updating the reference, it calls deleteEdge(edge, false);
which takes care of actually deleting the column and its edge
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134305
-----------------------------------------------------------
On May 24, 2016, 7:34 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 7:34 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java 7e32cc2
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 7cd83f8
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java c8c1067
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
> On May 23, 2016, 5:02 a.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java, line 318
> > <https://reviews.apache.org/r/46731/diff/3/?file=1387706#file1387706line318>
> >
> > why is the check for isComposite removed? Can you pls explain?
>
> Shwetha GS wrote:
> For example, in case of soft delete, if the column is deleted, we don't update the table's columns attribute. So, table definition returns the list of columns that includes deleted columns as well.
>
> For hive_process, when table is deleted, the reference is not removed. To be consistent, for hive_table, when column is deleted, reference is not removed as well
Wouldnt this be an issue in case of hard deletes?
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134305
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 23, 2016, 5:02 a.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java, line 318
> > <https://reviews.apache.org/r/46731/diff/3/?file=1387706#file1387706line318>
> >
> > why is the check for isComposite removed? Can you pls explain?
For example, in case of soft delete, if the column is deleted, we don't update the table's columns attribute. So, table definition returns the list of columns that includes deleted columns as well.
For hive_process, when table is deleted, the reference is not removed. To be consistent, for hive_table, when column is deleted, reference is not removed as well
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134305
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134305
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java (line 312)
<https://reviews.apache.org/r/46731/#comment199116>
why is the check for isComposite removed? Can you pls explain?
- Suma Shivaprasad
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134307
-----------------------------------------------------------
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java (line 74)
<https://reviews.apache.org/r/46731/#comment199118>
pls add asserts for update test cases as well for updated entities
- Suma Shivaprasad
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 23, 2016, 4:57 a.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, line 429
> > <https://reviews.apache.org/r/46731/diff/3/?file=1387714#file1387714line429>
> >
> > if this needs to be fixed, pls raise a jira
AtlasClient.EntityResult is used in the REST API response. For a deleted entity, just the guid makes sense. But NotificationEntityChangeListener on the server requires type name as well as the message contains entity always. Ideally, there should be different message formats for different notifications - entity create/delete etc. This is just small code cleanup. Will remove TODO, change to NOTE
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134304
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134304
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 427)
<https://reviews.apache.org/r/46731/#comment199115>
if this needs to be fixed, pls raise a jira
- Suma Shivaprasad
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/
-----------------------------------------------------------
(Updated May 19, 2016, 5:41 a.m.)
Review request for atlas.
Changes
-------
Re-based to trunk. This also has changes for ATLAS-710 - the UTs were conflicting, so merged both the patches. Here are the changes:
1. Create/update/delete APIs return all the entities created/updated/deleted
2. In case of update API, and soft delete, if a struct/trait needs to be deleted, it will be hard deleted - audit will have more details
3. In case of update API, and soft delete, if an entity needs to be deleted, its just marked as deleted, and the parent entity will still have a reference to the deleted entity. For example, in case of hive model, if column has to be deleted, column will be marked as deleted and table will still have reference to this deleted column
4. In case of delete API, and soft delete, all the references(struct, trait, class) of the deleted entity are still maintained
Bugs: ATLAS-716
https://issues.apache.org/jira/browse/ATLAS-716
Repository: atlas
Description
-------
1. Update/delete entity APIs return list of entities created, updated and deleted
2. Listeners are called for all the affected entities
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
Diff: https://reviews.apache.org/r/46731/diff/
Testing
-------
UTs
Thanks,
Shwetha GS
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 9, 2016, 9:41 p.m., Suma Shivaprasad wrote:
> > repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java, line 40
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363332#file1363332line40>
> >
> > why is this removed?
Not in the new patch
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review132336
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review132336
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java (line 40)
<https://reviews.apache.org/r/46731/#comment196514>
why is this removed?
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 5, 2016, 10:02 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/AtlasClient.java, line 602
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363301#file1363301line602>
> >
> > This will cause some users an UI to break rt?. would be better to send a mail out to atlas-dev
AtlasClient changes will cause compilation issues in consumers. But will send an email regarding API response changes
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131955
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131955
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasClient.java (line 597)
<https://reviews.apache.org/r/46731/#comment195992>
This will cause some users an UI to break rt?. would be better to send a mail out to atlas-dev
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 5, 2016, 10:09 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java, line 95
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363305#file1363305line95>
> >
> > traits null check is missing . Could lead to NPE ? Also would be better to split to make it more readable
Not in the new patch
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131957
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131957
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java (line 95)
<https://reviews.apache.org/r/46731/#comment195996>
traits null check is missing . Could lead to NPE ? Also would be better to split to make it more readable
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363301#file1363301line579>
> >
> > would be better to keep the result consistent for all CRUD operations and standardize as EntityResult
The reason I thought its better is we could add optional attributes the json after this and this is more flexible than changing the API later on. Makes sense?
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131952
-----------------------------------------------------------
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363301#file1363301line579>
> >
> > would be better to keep the result consistent for all CRUD operations and standardize as EntityResult
>
> Suma Shivaprasad wrote:
> The reason I thought its better is we could add optional attributes the json after this and this is more flexible than changing the API later on. Makes sense?
Create API returns EntityResult json. Its just the AtlasClient method that returns list<String>. Returning list<string> makes the interface clear
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131952
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131952
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasClient.java (line 577)
<https://reviews.apache.org/r/46731/#comment195990>
would be better to keep the result consistent for all CRUD operations and standardize as EntityResult
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
> On May 5, 2016, 10:05 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 66
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363302#file1363302line66>
> >
> > why do we need String comparision here and not direct quals which would be faster?
any reason to still keep this as toString comparision instead of direct ones? Can you pls explain?
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131956
-----------------------------------------------------------
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
> On May 5, 2016, 10:05 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 66
> > <https://reviews.apache.org/r/46731/diff/2/?file=1363302#file1363302line66>
> >
> > why do we need String comparision here and not direct quals which would be faster?
>
> Suma Shivaprasad wrote:
> any reason to still keep this as toString comparision instead of direct ones? Can you pls explain?
I have fixed it
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131956
-----------------------------------------------------------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated May 19, 2016, 5:41 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 254e150
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1
> client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 3f16a9a
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 384f383
> notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java 290be59
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java e8b55ef
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java a9e4f39
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 3604277
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java df28ab3
> repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java f8bbf73
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java aa78582
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a017536
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3fb128c
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 1aeedb5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java d2109d3
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java d9e3ec9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 709fec5
> webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 0f8bcb1
> webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 6985152
> webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java aa92bc0
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review131956
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/EntityAuditEvent.java (line 64)
<https://reviews.apache.org/r/46731/#comment195994>
why do we need String comparision here and not direct quals which would be faster?
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46731/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 1:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-716
> https://issues.apache.org/jira/browse/ATLAS-716
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Update/delete entity APIs return list of entities created, updated and deleted
> 2. Listeners are called for all the affected entities
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
> client/src/main/java/org/apache/atlas/AtlasClient.java be34802
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
> client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
> client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
> client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
> client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
> notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
> notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
> notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
> notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
> pom.xml 729b178
> repository/pom.xml 533e48b
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
> server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
> webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
> webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
> webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
>
> Diff: https://reviews.apache.org/r/46731/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 46731: ATLAS-716 Entity update/delete notifications
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/
-----------------------------------------------------------
(Updated April 27, 2016, 1:05 p.m.)
Review request for atlas.
Changes
-------
re-based patch
Bugs: ATLAS-716
https://issues.apache.org/jira/browse/ATLAS-716
Repository: atlas
Description
-------
1. Update/delete entity APIs return list of entities created, updated and deleted
2. Listeners are called for all the affected entities
Diffs (updated)
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f
addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee
client/src/main/java/org/apache/atlas/AtlasClient.java be34802
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708
client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION
client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION
client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION
client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION
client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5
client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION
client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f
notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988
notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99
notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e
notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5
notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa
notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION
notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f
notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea
pom.xml 729b178
repository/pom.xml 533e48b
repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5
repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed
server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e
webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80
webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79
webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0
Diff: https://reviews.apache.org/r/46731/diff/
Testing
-------
UTs
Thanks,
Shwetha GS