You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Alexander Schwartz (JIRA)" <ji...@codehaus.org> on 2007/05/09 18:29:12 UTC
[jira] Created: (MCHANGES-79) Allow for overriding the announcement
email from address
Allow for overriding the announcement email from address
--------------------------------------------------------
Key: MCHANGES-79
URL: http://jira.codehaus.org/browse/MCHANGES-79
Project: Maven 2.x Changes Plugin
Issue Type: New Feature
Reporter: Alexander Schwartz
Currently the goal {{changes:announcement-mail}} uses the email address of the first developer found in the pom as the from address of the announcement email. Very often a project is released by a developer that is not the first on in the list of developers in the pom -- which results is an announcement email with awron, confusing from address. (Of course one can change the list of developers for each release, or add a dummy developer "buildmaster" as the first one in the developer list, but this is not my preferred option).
The maven1 announcement plugin has a parameter {{from}} which allows to specify a different from address.
I suggest to add an optional parameter {{fromAdress}} to the goal {{changes:announcement-mail}} of the {{maven-changes-plugin}} such that one
can specify the sender as follows:
{noformat}
<project>
...
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-changes-plugin</artifactId>
<configuration>
<fromAddress>
buildmaster@mycoolproject.org
</fromAddress>
</configuration>
</plugin>
</plugins>
</build>
...
</project>
{noformat}
If the paremter {{fromAdress}} is given its content is taken as the the sender address of the announcement mail. If the option is not specified, the fallback is the email address of the first developer in the POM.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-79) Allow for overriding the announcement
email from address
Posted by "Alexander Schwartz (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Schwartz updated MCHANGES-79:
---------------------------------------
Attachment: MCHANGES-79-patch.txt
Created patch following the idea of Dennis.
The patch adds an optional property {{fromDeveloperId}} to {{AnnouncementMailMojo}}.
This property should match the id of one of the developers in the pom. If a matching developer is found it will be used as the sending developer of the announcement mail. If there is no such developer the mojo fails with an exception.
If the property {{fromDeveloperId}} is not given the first developer in the list is chosen.
No other files than {{AnnouncementMailMojo.java}} are effected by the patch.
> Allow for overriding the announcement email from address
> --------------------------------------------------------
>
> Key: MCHANGES-79
> URL: http://jira.codehaus.org/browse/MCHANGES-79
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Reporter: Alexander Schwartz
> Attachments: MCHANGES-79-patch.txt
>
>
> Currently the goal {{changes:announcement-mail}} uses the email address of the first developer found in the pom as the from address of the announcement email. Very often a project is released by a developer that is not the first on in the list of developers in the pom -- which results is an announcement email with awron, confusing from address. (Of course one can change the list of developers for each release, or add a dummy developer "buildmaster" as the first one in the developer list, but this is not my preferred option).
> The maven1 announcement plugin has a parameter {{from}} which allows to specify a different from address.
> I suggest to add an optional parameter {{fromAdress}} to the goal {{changes:announcement-mail}} of the {{maven-changes-plugin}} such that one
> can specify the sender as follows:
> {noformat}
> <project>
> ...
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-changes-plugin</artifactId>
> <configuration>
> <fromAddress>
> buildmaster@mycoolproject.org
> </fromAddress>
> </configuration>
> </plugin>
> </plugins>
> </build>
> ...
> </project>
> {noformat}
> If the paremter {{fromAdress}} is given its content is taken as the the sender address of the announcement mail. If the option is not specified, the fallback is the email address of the first developer in the POM.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHANGES-79) Allow for overriding the announcement
email from address
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MCHANGES-79.
-----------------------------------
Assignee: Dennis Lundberg
Resolution: Fixed
Fix Version/s: 2.0-beta-3
Patch applied, with modifications.
Thanks!
> Allow for overriding the announcement email from address
> --------------------------------------------------------
>
> Key: MCHANGES-79
> URL: http://jira.codehaus.org/browse/MCHANGES-79
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Reporter: Alexander Schwartz
> Assignee: Dennis Lundberg
> Fix For: 2.0-beta-3
>
> Attachments: MCHANGES-79-patch.txt
>
>
> Currently the goal {{changes:announcement-mail}} uses the email address of the first developer found in the pom as the from address of the announcement email. Very often a project is released by a developer that is not the first on in the list of developers in the pom -- which results is an announcement email with awron, confusing from address. (Of course one can change the list of developers for each release, or add a dummy developer "buildmaster" as the first one in the developer list, but this is not my preferred option).
> The maven1 announcement plugin has a parameter {{from}} which allows to specify a different from address.
> I suggest to add an optional parameter {{fromAdress}} to the goal {{changes:announcement-mail}} of the {{maven-changes-plugin}} such that one
> can specify the sender as follows:
> {noformat}
> <project>
> ...
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-changes-plugin</artifactId>
> <configuration>
> <fromAddress>
> buildmaster@mycoolproject.org
> </fromAddress>
> </configuration>
> </plugin>
> </plugins>
> </build>
> ...
> </project>
> {noformat}
> If the paremter {{fromAdress}} is given its content is taken as the the sender address of the announcement mail. If the option is not specified, the fallback is the email address of the first developer in the POM.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-79) Allow for overriding the
announcement email from address
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101604 ]
Dennis Lundberg commented on MCHANGES-79:
-----------------------------------------
I would like to propose a different approach to this. How about adding a {{fromDeveloperId}} parameter. This should match the {{id}} of one of the {{developers}} in the pom. If a matching developer is found it will be used instead of the first developer in the list.
> Allow for overriding the announcement email from address
> --------------------------------------------------------
>
> Key: MCHANGES-79
> URL: http://jira.codehaus.org/browse/MCHANGES-79
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Reporter: Alexander Schwartz
>
> Currently the goal {{changes:announcement-mail}} uses the email address of the first developer found in the pom as the from address of the announcement email. Very often a project is released by a developer that is not the first on in the list of developers in the pom -- which results is an announcement email with awron, confusing from address. (Of course one can change the list of developers for each release, or add a dummy developer "buildmaster" as the first one in the developer list, but this is not my preferred option).
> The maven1 announcement plugin has a parameter {{from}} which allows to specify a different from address.
> I suggest to add an optional parameter {{fromAdress}} to the goal {{changes:announcement-mail}} of the {{maven-changes-plugin}} such that one
> can specify the sender as follows:
> {noformat}
> <project>
> ...
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-changes-plugin</artifactId>
> <configuration>
> <fromAddress>
> buildmaster@mycoolproject.org
> </fromAddress>
> </configuration>
> </plugin>
> </plugins>
> </build>
> ...
> </project>
> {noformat}
> If the paremter {{fromAdress}} is given its content is taken as the the sender address of the announcement mail. If the option is not specified, the fallback is the email address of the first developer in the POM.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-79) Allow for overriding the
announcement email from address
Posted by "Alexander Schwartz (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103627 ]
Alexander Schwartz commented on MCHANGES-79:
--------------------------------------------
I am agree, the approach suggest by Dennis has several advantages.
> Allow for overriding the announcement email from address
> --------------------------------------------------------
>
> Key: MCHANGES-79
> URL: http://jira.codehaus.org/browse/MCHANGES-79
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Reporter: Alexander Schwartz
>
> Currently the goal {{changes:announcement-mail}} uses the email address of the first developer found in the pom as the from address of the announcement email. Very often a project is released by a developer that is not the first on in the list of developers in the pom -- which results is an announcement email with awron, confusing from address. (Of course one can change the list of developers for each release, or add a dummy developer "buildmaster" as the first one in the developer list, but this is not my preferred option).
> The maven1 announcement plugin has a parameter {{from}} which allows to specify a different from address.
> I suggest to add an optional parameter {{fromAdress}} to the goal {{changes:announcement-mail}} of the {{maven-changes-plugin}} such that one
> can specify the sender as follows:
> {noformat}
> <project>
> ...
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-changes-plugin</artifactId>
> <configuration>
> <fromAddress>
> buildmaster@mycoolproject.org
> </fromAddress>
> </configuration>
> </plugin>
> </plugins>
> </build>
> ...
> </project>
> {noformat}
> If the paremter {{fromAdress}} is given its content is taken as the the sender address of the announcement mail. If the option is not specified, the fallback is the email address of the first developer in the POM.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-79) Allow for overriding the announcement
email from address
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MCHANGES-79:
------------------------------------
Component/s: announcement
> Allow for overriding the announcement email from address
> --------------------------------------------------------
>
> Key: MCHANGES-79
> URL: http://jira.codehaus.org/browse/MCHANGES-79
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Reporter: Alexander Schwartz
>
> Currently the goal {{changes:announcement-mail}} uses the email address of the first developer found in the pom as the from address of the announcement email. Very often a project is released by a developer that is not the first on in the list of developers in the pom -- which results is an announcement email with awron, confusing from address. (Of course one can change the list of developers for each release, or add a dummy developer "buildmaster" as the first one in the developer list, but this is not my preferred option).
> The maven1 announcement plugin has a parameter {{from}} which allows to specify a different from address.
> I suggest to add an optional parameter {{fromAdress}} to the goal {{changes:announcement-mail}} of the {{maven-changes-plugin}} such that one
> can specify the sender as follows:
> {noformat}
> <project>
> ...
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-changes-plugin</artifactId>
> <configuration>
> <fromAddress>
> buildmaster@mycoolproject.org
> </fromAddress>
> </configuration>
> </plugin>
> </plugins>
> </build>
> ...
> </project>
> {noformat}
> If the paremter {{fromAdress}} is given its content is taken as the the sender address of the announcement mail. If the option is not specified, the fallback is the email address of the first developer in the POM.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira