You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ch...@apache.org on 2015/07/28 07:15:49 UTC
[01/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Repository: incubator-reef
Updated Branches:
refs/heads/master e5aef1616 -> 141c7fa08
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java
index 06936fd..e2eacc9 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteTest.java
@@ -66,18 +66,18 @@ public class RemoteTest {
public void testRemoteEventCodec() throws UnknownHostException {
System.out.println(LOG_PREFIX + name.getMethodName());
- ObjectSerializableCodec<TestEvent> codec = new ObjectSerializableCodec<TestEvent>();
+ final ObjectSerializableCodec<TestEvent> codec = new ObjectSerializableCodec<TestEvent>();
- RemoteEventCodec<TestEvent> reCodec = new RemoteEventCodec<TestEvent>(codec);
- SocketAddress localAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 8000);
- SocketAddress remoteAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 9000);
+ final RemoteEventCodec<TestEvent> reCodec = new RemoteEventCodec<TestEvent>(codec);
+ final SocketAddress localAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 8000);
+ final SocketAddress remoteAddr = new InetSocketAddress(this.localAddressProvider.getLocalAddress(), 9000);
- RemoteEvent<TestEvent> e1 = new RemoteEvent<TestEvent>(
+ final RemoteEvent<TestEvent> e1 = new RemoteEvent<TestEvent>(
localAddr, remoteAddr, "stage1", "stage2", 1, new TestEvent("hello", 0.0));
System.out.println(e1);
- byte[] data = reCodec.encode(e1);
- RemoteEvent<TestEvent> e2 = reCodec.decode(data);
+ final byte[] data = reCodec.encode(e1);
+ final RemoteEvent<TestEvent> e2 = reCodec.decode(data);
System.out.println(e2);
Assert.assertEquals(e1.getSink(), e2.getSink());
@@ -95,11 +95,11 @@ public class RemoteTest {
final String hostAddress = this.localAddressProvider.getLocalAddress();
// transport
- Transport transport1 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000);
- int port1 = transport1.getListeningPort();
+ final Transport transport1 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000);
+ final int port1 = transport1.getListeningPort();
- Transport transport2 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000);
- int port2 = transport2.getListeningPort();
+ final Transport transport2 = tpFactory.newInstance(hostAddress, 0, reRecvStage, reRecvStage, 1, 10000);
+ final int port2 = transport2.getListeningPort();
transport1.close();
transport2.close();
@@ -112,26 +112,26 @@ public class RemoteTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.FINEST);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000);
// port
- int port = 9101;
+ final int port = 9101;
// receiver stage
// decoder map
- Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>();
+ final Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>();
clazzToDecoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>());
clazzToDecoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>());
- Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap);
+ final Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap);
// receive handlers
- int finalSize = 6; // 6 events will be sent
- Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>();
- Set<Object> set = Collections.synchronizedSet(new HashSet<Object>());
+ final int finalSize = 6; // 6 events will be sent
+ final Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>();
+ final Set<Object> set = Collections.synchronizedSet(new HashSet<Object>());
clazzToHandlerMap.put(TestEvent.class, new ConsoleEventHandler<TestEvent>("recvEH1", set, finalSize, monitor));
clazzToHandlerMap.put(TestEvent2.class, new ConsoleEventHandler<TestEvent2>("recvEH2", set, finalSize, monitor));
- EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap);
+ final EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap);
// receiver stage
final RemoteReceiverStage reRecvStage = new RemoteReceiverStage(
@@ -140,34 +140,34 @@ public class RemoteTest {
final String hostAddress = this.localAddressProvider.getLocalAddress();
// transport
- Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000);
+ final Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000);
// mux encoder with encoder map
- Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>();
+ final Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>();
clazzToEncoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>());
clazzToEncoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>());
- Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap);
+ final Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap);
// sender stage
final RemoteSenderStage reSendStage = new RemoteSenderStage(encoder, transport, 10);
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000);
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000);
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port);
- RemoteSeqNumGenerator seqGen = new RemoteSeqNumGenerator();
+ final RemoteSeqNumGenerator seqGen = new RemoteSeqNumGenerator();
// proxy handler for a remotely running handler
- ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>(
+ final ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>(
myId, remoteId, "recvEH1", reSendStage.<TestEvent>getHandler(), seqGen);
proxyHandler1.onNext(new TestEvent("hello1", 0.0));
proxyHandler1.onNext(new TestEvent("hello2", 0.0));
- ProxyEventHandler<TestEvent2> proxyHandler2 = new ProxyEventHandler<TestEvent2>(
+ final ProxyEventHandler<TestEvent2> proxyHandler2 = new ProxyEventHandler<TestEvent2>(
myId, remoteId, "recvEH2", reSendStage.<TestEvent2>getHandler(), seqGen);
proxyHandler2.onNext(new TestEvent2("hello1", 1.0));
proxyHandler2.onNext(new TestEvent2("hello2", 1.0));
- ProxyEventHandler<TestEvent> proxyHandler3 = new ProxyEventHandler<TestEvent>(
+ final ProxyEventHandler<TestEvent> proxyHandler3 = new ProxyEventHandler<TestEvent>(
myId, remoteId, "recvEH3", reSendStage.<TestEvent>getHandler(), seqGen);
proxyHandler3.onNext(new TestEvent("hello1", 1.0));
proxyHandler3.onNext(new TestEvent("hello2", 1.0));
@@ -191,13 +191,13 @@ public class RemoteTest {
private final Decoder<Object> decoder;
private final EventHandler<Object> handler;
- RemoteEventHandler(Decoder<Object> decoder, EventHandler<Object> handler) {
+ RemoteEventHandler(final Decoder<Object> decoder, final EventHandler<Object> handler) {
this.decoder = decoder;
this.handler = handler;
}
@Override
- public void onNext(RemoteEvent<byte[]> value) {
+ public void onNext(final RemoteEvent<byte[]> value) {
handler.onNext(decoder.decode(value.getEvent()));
}
}
@@ -209,7 +209,7 @@ public class RemoteTest {
private final int finalSize;
private final Monitor monitor;
- ConsoleEventHandler(String name, Set<Object> set, int finalSize, Monitor monitor) {
+ ConsoleEventHandler(final String name, final Set<Object> set, final int finalSize, final Monitor monitor) {
this.name = name;
this.set = set;
this.finalSize = finalSize;
@@ -217,7 +217,7 @@ public class RemoteTest {
}
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
System.out.println(name + " " + value);
set.add(value);
if (set.size() == finalSize) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java
index fcaf182..461308f 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/SmallMessagesTest.java
@@ -63,27 +63,27 @@ public class SmallMessagesTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.FINEST);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 60000, 60000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 60000, 60000);
// port
- int port = 9101;
+ final int port = 9101;
// receiver stage
// decoder map
- Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>();
+ final Map<Class<?>, Decoder<?>> clazzToDecoderMap = new HashMap<Class<?>, Decoder<?>>();
clazzToDecoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>());
clazzToDecoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>());
- Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap);
+ final Decoder<Object> decoder = new MultiDecoder<Object>(clazzToDecoderMap);
// receive handlers
- int finalSize = 6; // 6 events will be sent
+ final int finalSize = 6; // 6 events will be sent
//int finalSize = 200000; // 6 events will be sent
- Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>();
- Set<Object> set = Collections.synchronizedSet(new HashSet<Object>());
+ final Map<Class<?>, EventHandler<?>> clazzToHandlerMap = new HashMap<Class<?>, EventHandler<?>>();
+ final Set<Object> set = Collections.synchronizedSet(new HashSet<Object>());
clazzToHandlerMap.put(TestEvent.class, new ConsoleEventHandler<TestEvent>("recvEH1", set, finalSize, monitor));
clazzToHandlerMap.put(TestEvent2.class, new ConsoleEventHandler<TestEvent2>("recvEH2", set, finalSize, monitor));
- EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap);
+ final EventHandler<Object> handler = new MultiEventHandler<Object>(clazzToHandlerMap);
// receiver stage
final RemoteReceiverStage reRecvStage = new RemoteReceiverStage(
@@ -92,34 +92,34 @@ public class SmallMessagesTest {
final String hostAddress = this.localAddressProvider.getLocalAddress();
// transport
- Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000);
+ final Transport transport = tpFactory.newInstance(hostAddress, port, reRecvStage, reRecvStage, 1, 10000);
// mux encoder with encoder map
- Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>();
+ final Map<Class<?>, Encoder<?>> clazzToEncoderMap = new HashMap<Class<?>, Encoder<?>>();
clazzToEncoderMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>());
clazzToEncoderMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>());
- Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap);
+ final Encoder<Object> encoder = new MultiEncoder<Object>(clazzToEncoderMap);
// sender stage
final RemoteSenderStage reSendStage = new RemoteSenderStage(encoder, transport, 10);
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000);
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier myId = factory.getNewInstance("socket://" + hostAddress + ":" + 8000);
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port);
// proxy handler for a remotely running handler
- ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>(
+ final ProxyEventHandler<TestEvent> proxyHandler1 = new ProxyEventHandler<TestEvent>(
myId, remoteId, "recvEH1", reSendStage.<TestEvent>getHandler(), new RemoteSeqNumGenerator());
- long start = System.nanoTime();
+ final long start = System.nanoTime();
for (int i = 0; i < finalSize; i++) {
proxyHandler1.onNext(new TestEvent("0", i));
}
monitor.mwait();
- long end = System.nanoTime();
- long runtimeNs = end - start;
- double runtimeS = ((double) runtimeNs) / (1000 * 1000 * 1000);
+ final long end = System.nanoTime();
+ final long runtimeNs = end - start;
+ final double runtimeS = ((double) runtimeNs) / (1000 * 1000 * 1000);
System.out.println("msgs/s: " + finalSize / runtimeS);
// most time is spent in netty.channel.socket.nio.SelectorUtil.select()
@@ -140,13 +140,13 @@ public class SmallMessagesTest {
private final Decoder<Object> decoder;
private final EventHandler<Object> handler;
- RemoteEventHandler(Decoder<Object> decoder, EventHandler<Object> handler) {
+ RemoteEventHandler(final Decoder<Object> decoder, final EventHandler<Object> handler) {
this.decoder = decoder;
this.handler = handler;
}
@Override
- public void onNext(RemoteEvent<byte[]> value) {
+ public void onNext(final RemoteEvent<byte[]> value) {
handler.onNext(decoder.decode(value.getEvent()));
}
}
@@ -158,7 +158,7 @@ public class SmallMessagesTest {
private final int finalSize;
private final Monitor monitor;
- ConsoleEventHandler(String name, Set<Object> set, int finalSize, Monitor monitor) {
+ ConsoleEventHandler(final String name, final Set<Object> set, final int finalSize, final Monitor monitor) {
this.name = name;
this.set = set;
this.finalSize = finalSize;
@@ -166,7 +166,7 @@ public class SmallMessagesTest {
}
@Override
- public void onNext(T event) {
+ public void onNext(final T event) {
//System.out.println(name + " " + event);
set.add(event);
if (set.size() == finalSize) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java
index 6731108..101590a 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent.java
@@ -27,7 +27,7 @@ public class TestEvent implements Serializable {
private double load;
- public TestEvent(String message, double load) {
+ public TestEvent(final String message, final double load) {
this.message = message;
this.load = load;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java
index e51242f..522bcf8 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent1.java
@@ -22,7 +22,7 @@ public class TestEvent1 extends TestEvent {
private static final long serialVersionUID = 1L;
- public TestEvent1(String message, double load) {
+ public TestEvent1(final String message, final double load) {
super(message, load);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java
index 1ec2a95..b2ffb77 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEvent2.java
@@ -22,7 +22,7 @@ public class TestEvent2 extends TestEvent {
private static final long serialVersionUID = 1L;
- public TestEvent2(String message, double load) {
+ public TestEvent2(final String message, final double load) {
super(message, load);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java
index 6541c3f..f362a9e 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestEventCodec.java
@@ -29,19 +29,19 @@ import org.apache.reef.wake.test.proto.TestProtos.TestEventPBuf;
public class TestEventCodec implements Codec<TestEvent> {
@Override
- public byte[] encode(TestEvent obj) {
- TestEventPBuf.Builder builder = TestEventPBuf.newBuilder();
+ public byte[] encode(final TestEvent obj) {
+ final TestEventPBuf.Builder builder = TestEventPBuf.newBuilder();
builder.setMessage(obj.getMessage());
builder.setLoad(obj.getLoad());
return builder.build().toByteArray();
}
@Override
- public TestEvent decode(byte[] data) {
- TestEventPBuf pbuf;
+ public TestEvent decode(final byte[] data) {
+ final TestEventPBuf pbuf;
try {
pbuf = TestEventPBuf.parseFrom(data);
- } catch (InvalidProtocolBufferException e) {
+ } catch (final InvalidProtocolBufferException e) {
e.printStackTrace();
throw new RemoteRuntimeException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
index 3b97dc5..086a408 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
@@ -43,28 +43,28 @@ public class TestRemote implements Runnable {
@Override
public void run() {
final String hostAddress = localAddressProvider.getLocalAddress();
- int myPort = 10011;
- int remotePort = 10001;
- Codec<TestEvent> codec = new TestEventCodec();
+ final int myPort = 10011;
+ final int remotePort = 10001;
+ final Codec<TestEvent> codec = new TestEventCodec();
try (RemoteManager rm =
remoteManagerFactory.getInstance("name", myPort, codec, new LoggingEventHandler<Throwable>())) {
// proxy handler
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + remotePort);
- EventHandler<TestEvent> proxyHandler = rm.getHandler(remoteId, TestEvent.class);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + remotePort);
+ final EventHandler<TestEvent> proxyHandler = rm.getHandler(remoteId, TestEvent.class);
proxyHandler.onNext(new TestEvent("hello", 1.0));
// register a handler
rm.registerHandler(TestEvent.class, new TestEventHandler(proxyHandler));
- } catch (UnknownHostException e) {
+ } catch (final UnknownHostException e) {
e.printStackTrace();
- } catch (Exception e) {
+ } catch (final Exception e) {
e.printStackTrace();
}
}
- public static void main(String[] args) throws InjectionException {
+ public static void main(final String[] args) throws InjectionException {
Tang.Factory.getTang().newInjector().getInstance(TestRemote.class).run();
}
}
@@ -73,12 +73,12 @@ class TestEventHandler implements EventHandler<RemoteMessage<TestEvent>> {
private final EventHandler<TestEvent> proxy;
- public TestEventHandler(EventHandler<TestEvent> proxy) {
+ public TestEventHandler(final EventHandler<TestEvent> proxy) {
this.proxy = proxy;
}
@Override
- public void onNext(RemoteMessage<TestEvent> value) {
+ public void onNext(final RemoteMessage<TestEvent> value) {
System.out.println(value.getMessage().getMessage() + " " + value.getMessage().getLoad());
proxy.onNext(value.getMessage());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java
index 2b28997..bece0df 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemoteIdentifier.java
@@ -23,7 +23,7 @@ import org.apache.reef.wake.remote.RemoteIdentifier;
public class TestRemoteIdentifier implements RemoteIdentifier {
private final String str;
- public TestRemoteIdentifier(String str) {
+ public TestRemoteIdentifier(final String str) {
this.str = str;
}
@@ -31,7 +31,7 @@ public class TestRemoteIdentifier implements RemoteIdentifier {
return str;
}
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
return str.equals(((TestRemoteIdentifier) o).getString());
}
@@ -40,7 +40,7 @@ public class TestRemoteIdentifier implements RemoteIdentifier {
}
public String toString() {
- StringBuilder builder = new StringBuilder();
+ final StringBuilder builder = new StringBuilder();
builder.append("test://");
builder.append(str);
return builder.toString();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java
index 5a84cff..c8daf12 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportRaceTest.java
@@ -55,21 +55,21 @@ public class TransportRaceTest {
@Test
public void testRace() throws Exception {
LoggingUtils.setLoggingLevel(Level.FINE);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000);
- EStage<TransportEvent> clientStage = new ThreadPoolStage<>("client1",
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000);
+ final EStage<TransportEvent> clientStage = new ThreadPoolStage<>("client1",
new LoggingEventHandler<TransportEvent>(), 1, new LoggingEventHandler<Throwable>());
- int msgsSent = 100;
+ final int msgsSent = 100;
final ServerHandler serverHandler = new ServerHandler(monitor, msgsSent);
- EStage<TransportEvent> serverStage = new ThreadPoolStage<>("server@7001",
+ final EStage<TransportEvent> serverStage = new ThreadPoolStage<>("server@7001",
serverHandler, 1, new LoggingEventHandler<Throwable>());
final String hostAddress = this.localAddressProvider.getLocalAddress();
- int port = 7001;
- Transport transport = tpFactory.newInstance(
+ final int port = 7001;
+ final Transport transport = tpFactory.newInstance(
hostAddress, port, clientStage, serverStage, 1, 10000);
- String value = "Test Race";
+ final String value = "Test Race";
for (int i = 0; i < msgsSent; i++) {
final Link<byte[]> link = transport.open(new InetSocketAddress(
@@ -78,7 +78,7 @@ public class TransportRaceTest {
}
monitor.mwait();
- int msgsRcvd = serverHandler.getAccSize();
+ final int msgsRcvd = serverHandler.getAccSize();
if (msgsRcvd != msgsSent) {
Assert.assertEquals("Num Msgs transmitted==Num Msgs received", msgsSent, msgsRcvd);
}
@@ -94,7 +94,7 @@ public class TransportRaceTest {
private final int expectedSize;
private int accSize;
- ServerHandler(Monitor monitor, int expectedSize) {
+ ServerHandler(final Monitor monitor, final int expectedSize) {
this.monitor = monitor;
this.expectedSize = expectedSize;
this.accSize = 0;
@@ -105,7 +105,7 @@ public class TransportRaceTest {
}
@Override
- public void onNext(TransportEvent value) {
+ public void onNext(final TransportEvent value) {
++accSize;
if (accSize == expectedSize) {
monitor.mnotify();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java
index d3ae9b3..f62d3c9 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TransportTest.java
@@ -63,19 +63,20 @@ public class TransportTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.INFO);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
final int expected = 2;
final String hostAddress = this.localAddressProvider.getLocalAddress();
final int port = 9100;
// Codec<String>
- ReceiverStage<String> stage = new ReceiverStage<String>(new ObjectSerializableCodec<String>(), monitor, expected);
- Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000);
+ final ReceiverStage<String> stage =
+ new ReceiverStage<String>(new ObjectSerializableCodec<String>(), monitor, expected);
+ final Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000);
// sending side
- Link<String> link = transport.open(
+ final Link<String> link = transport.open(
new InetSocketAddress(hostAddress, port),
new ObjectSerializableCodec<String>(),
new LoggingLinkListener<String>());
@@ -94,20 +95,20 @@ public class TransportTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.INFO);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
final int expected = 2;
final String hostAddress = this.localAddressProvider.getLocalAddress();
final int port = 9100;
// Codec<TestEvent>
- ReceiverStage<TestEvent> stage =
+ final ReceiverStage<TestEvent> stage =
new ReceiverStage<TestEvent>(new ObjectSerializableCodec<TestEvent>(), monitor, expected);
- Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000);
+ final Transport transport = tpFactory.newInstance(hostAddress, port, stage, stage, 1, 10000);
// sending side
- Link<TestEvent> link = transport.open(
+ final Link<TestEvent> link = transport.open(
new InetSocketAddress(hostAddress, port),
new ObjectSerializableCodec<TestEvent>(),
new LoggingLinkListener<TestEvent>());
@@ -128,7 +129,7 @@ public class TransportTest {
private final int expected;
private AtomicInteger count = new AtomicInteger(0);
- ReceiverStage(Codec<T> codec, Monitor monitor, int expected) {
+ ReceiverStage(final Codec<T> codec, final Monitor monitor, final int expected) {
this.codec = codec;
this.monitor = monitor;
this.expected = expected;
@@ -139,7 +140,7 @@ public class TransportTest {
}
@Override
- public void onNext(TransportEvent value) {
+ public void onNext(final TransportEvent value) {
codec.decode(value.getData());
//System.out.println(value + " " + obj);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java
index bb3d112..79ca91c 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxTest.java
@@ -35,7 +35,7 @@ public class RxTest {
public void testRx() throws Exception {
System.out.println(name.getMethodName());
- RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(new TestObserver("o1"), 1);
+ final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(new TestObserver("o1"), 1);
int i = 0;
try {
@@ -43,7 +43,7 @@ public class RxTest {
stage.onNext(new TestEvent(i));
}
stage.onCompleted();
- } catch (Exception e) {
+ } catch (final Exception e) {
stage.onError(e);
}
@@ -53,7 +53,7 @@ public class RxTest {
class TestEvent {
private int n;
- TestEvent(int n) {
+ TestEvent(final int n) {
this.n = n;
}
@@ -66,17 +66,17 @@ public class RxTest {
private final String name;
- TestObserver(String name) {
+ TestObserver(final String name) {
this.name = name;
}
@Override
- public void onNext(TestEvent value) {
+ public void onNext(final TestEvent value) {
System.out.println(name + " Value: " + value + " " + value.get());
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
System.out.println(name + " Error: " + error);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java
index 5c8adbc..ca5b165 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/RxThreadPoolStageTest.java
@@ -41,8 +41,8 @@ public class RxThreadPoolStageTest {
public void testOne() throws Exception {
System.out.println(name.getMethodName());
- TestObserver to = new TestObserver("o1");
- RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 1);
+ final TestObserver to = new TestObserver("o1");
+ final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 1);
int i = 0;
int sum = 0;
@@ -52,7 +52,7 @@ public class RxThreadPoolStageTest {
sum += i;
}
stage.onCompleted();
- } catch (Exception e) {
+ } catch (final Exception e) {
stage.onError(e);
}
@@ -67,8 +67,8 @@ public class RxThreadPoolStageTest {
public void testMultipleThreads() throws Exception {
System.out.println(name.getMethodName());
- TestObserver to = new TestObserver("o1");
- RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 11);
+ final TestObserver to = new TestObserver("o1");
+ final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 11);
int i = 0;
int sum = 0;
@@ -78,7 +78,7 @@ public class RxThreadPoolStageTest {
sum += i;
}
stage.onCompleted();
- } catch (Exception e) {
+ } catch (final Exception e) {
stage.onError(e);
}
@@ -93,12 +93,12 @@ public class RxThreadPoolStageTest {
public void testMultipleCallers() throws Exception {
System.out.println(name.getMethodName());
- TestObserver to = new TestObserver("o1");
+ final TestObserver to = new TestObserver("o1");
final RxStage<TestEvent> stage = new RxThreadPoolStage<TestEvent>(to, 11);
final int tn = 7;
- ExecutorService taskmaster = Executors.newFixedThreadPool(tn);
- List<Future<Integer>> handles = new ArrayList<>();
+ final ExecutorService taskmaster = Executors.newFixedThreadPool(tn);
+ final List<Future<Integer>> handles = new ArrayList<>();
for (int t = 0; t < tn; t++) {
handles.add(taskmaster.submit(new Callable<Integer>() {
@Override
@@ -113,7 +113,7 @@ public class RxThreadPoolStageTest {
}));
}
int sum = 0;
- for (Future<Integer> h : handles) {
+ for (final Future<Integer> h : handles) {
try {
sum += h.get();
} catch (InterruptedException | ExecutionException e1) {
@@ -124,7 +124,7 @@ public class RxThreadPoolStageTest {
try {
stage.onCompleted();
- } catch (Exception e) {
+ } catch (final Exception e) {
stage.onError(e);
}
@@ -138,7 +138,7 @@ public class RxThreadPoolStageTest {
class TestEvent {
private int n;
- TestEvent(int n) {
+ TestEvent(final int n) {
this.n = n;
}
@@ -154,7 +154,7 @@ public class RxThreadPoolStageTest {
private final AtomicInteger completes = new AtomicInteger(0);
private final String name;
- TestObserver(String name) {
+ TestObserver(final String name) {
this.name = name;
}
@@ -171,13 +171,13 @@ public class RxThreadPoolStageTest {
}
@Override
- public void onNext(TestEvent value) {
+ public void onNext(final TestEvent value) {
System.out.println(name + " Value: " + value + " " + value.get());
events.addAndGet(value.get());
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
System.out.println(name + " Error: " + error);
errors.incrementAndGet();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java
index 5cc6c71..0fc0b0d 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/rx/TimeoutSubjectTest.java
@@ -38,15 +38,15 @@ public class TimeoutSubjectTest {
final AtomicInteger nexts = new AtomicInteger(0);
final AtomicInteger completes = new AtomicInteger(0);
final int delta = 400;
- Subject<Integer, Integer> dut = new TimeoutSubject<>(10000, new Observer<Integer>() {
+ final Subject<Integer, Integer> dut = new TimeoutSubject<>(10000, new Observer<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
nexts.addAndGet(delta);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
fail(error.toString());
}
@@ -70,12 +70,12 @@ public class TimeoutSubjectTest {
final Subject<Integer, Integer> dut = new TimeoutSubject<>(10000, new Observer<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
nexts.addAndGet(delta);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
fail(error.toString());
}
@@ -86,7 +86,7 @@ public class TimeoutSubjectTest {
}
});
- ExecutorService e = Executors.newSingleThreadExecutor();
+ final ExecutorService e = Executors.newSingleThreadExecutor();
e.submit(new Runnable() {
@Override
public void run() {
@@ -97,7 +97,7 @@ public class TimeoutSubjectTest {
e.shutdown();
try {
e.awaitTermination(11000, TimeUnit.MILLISECONDS);
- } catch (InterruptedException e1) {
+ } catch (final InterruptedException e1) {
e1.printStackTrace();
fail(e1.toString());
}
@@ -111,15 +111,15 @@ public class TimeoutSubjectTest {
final int timeout = 1;
final int sleep = 500;
final AtomicInteger errors = new AtomicInteger(0);
- Subject<Integer, Integer> dut = new TimeoutSubject<>(timeout, new Observer<Integer>() {
+ final Subject<Integer, Integer> dut = new TimeoutSubject<>(timeout, new Observer<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
fail("Should not get called");
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
assertTrue(error instanceof TimeoutException);
errors.incrementAndGet();
}
@@ -132,7 +132,7 @@ public class TimeoutSubjectTest {
try {
Thread.sleep(sleep);
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
fail(e.toString());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
index eb80884..f08f16b 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
@@ -180,7 +180,7 @@ public class ClockTest {
final EventRecorder alarmRecorder = new EventRecorder(eventCountLatch);
try {
- long[] expected = new long[numAlarms];
+ final long[] expected = new long[numAlarms];
for (int i = 0; i < numAlarms; ++i) {
clock.scheduleAlarm(i * 100, alarmRecorder);
expected[i] = i * 100;
@@ -188,9 +188,9 @@ public class ClockTest {
eventCountLatch.await(10, TimeUnit.SECONDS);
- Long[] actualLong = new Long[numAlarms];
+ final Long[] actualLong = new Long[numAlarms];
alarmRecorder.getTimestamps().toArray(actualLong);
- long[] actual = new long[numAlarms];
+ final long[] actual = new long[numAlarms];
for (int i = 0; i < numAlarms; ++i) {
actual[i] = actualLong[i];
}
@@ -217,7 +217,7 @@ public class ClockTest {
this(null);
}
- public EventRecorder(CountDownLatch latch) {
+ public EventRecorder(final CountDownLatch latch) {
eventCountLatch = latch;
}
@@ -245,7 +245,7 @@ public class ClockTest {
private final CountDownLatch eventCountLatch;
private final Random rand;
- public RandomAlarmProducer(RuntimeClock clock, CountDownLatch latch) {
+ public RandomAlarmProducer(final RuntimeClock clock, final CountDownLatch latch) {
this.clock = clock;
this.eventCountLatch = latch;
this.rand = new Random();
@@ -253,7 +253,7 @@ public class ClockTest {
@Override
public void onNext(final Alarm value) {
- int duration = rand.nextInt(100) + 1;
+ final int duration = rand.nextInt(100) + 1;
clock.scheduleAlarm(duration, this);
eventCountLatch.countDown();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java
index 390e3c9..ae47b3e 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/PassThroughEncoder.java
@@ -29,7 +29,7 @@ public class PassThroughEncoder implements Encoder<byte[]> {
* @see org.apache.reef.wake.remote.Encoder#encode(java.lang.Object)
*/
@Override
- public byte[] encode(byte[] obj) {
+ public byte[] encode(final byte[] obj) {
return obj;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java
index ad3da25..4864192 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/util/TimeoutHandler.java
@@ -25,12 +25,12 @@ public class TimeoutHandler implements EventHandler<PeriodicEvent> {
private final Monitor monitor;
- public TimeoutHandler(Monitor monitor) {
+ public TimeoutHandler(final Monitor monitor) {
this.monitor = monitor;
}
@Override
- public void onNext(PeriodicEvent event) {
+ public void onNext(final PeriodicEvent event) {
monitor.mnotify();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java
index 1d0e35e..df654a2 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerReefEventHandler.java
@@ -178,7 +178,7 @@ public final class HttpServerReefEventHandler implements HttpHandler {
try {
final byte[] outputBody = readFile((String) names.get(0)).getBytes(Charset.forName("UTF-8"));
response.getOutputStream().write(outputBody);
- } catch(IOException e) {
+ } catch(final IOException e) {
response.getWriter().println(String.format("Cannot find the log file: [%s].", fileName));
}
break;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java
index 6143bc2..5ea15a0 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ReefEventStateManager.java
@@ -148,7 +148,7 @@ public final class ReefEventStateManager {
return this.serviceInfoList;
}
- public void registerServiceInfo(AvroReefServiceInfo serviceInfo) {
+ public void registerServiceInfo(final AvroReefServiceInfo serviceInfo) {
synchronized (this.serviceInfoList) {
serviceInfoList.add(serviceInfo);
LOG.log(Level.INFO, "Registered Service [{0}] with Info [{1}]",
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java
index ac69ca1..4c57133 100644
--- a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java
+++ b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestAvroHttpSerializer.java
@@ -40,7 +40,7 @@ public final class TestAvroHttpSerializer {
private AvroHttpRequest avroRequest;
private AvroHttpSerializer avroHttpSerializer;
- public static String readStream(InputStream is) {
+ public static String readStream(final InputStream is) {
final StringBuilder sb = new StringBuilder(512);
try {
final Reader r = new InputStreamReader(is, "UTF-8");
@@ -48,7 +48,7 @@ public final class TestAvroHttpSerializer {
while ((c = r.read()) != -1) {
sb.append((char) c);
}
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
return sb.toString();
[04/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
index 1c65a00..de9b631 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
@@ -44,7 +44,7 @@ final class UnitClass {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -52,7 +52,7 @@ final class UnitClass {
return false;
}
- UnitClass unitClass = (UnitClass) o;
+ final UnitClass unitClass = (UnitClass) o;
if (intValue != unitClass.intValue) {
return false;
@@ -80,7 +80,7 @@ final class UnitClass {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -88,7 +88,7 @@ final class UnitClass {
return false;
}
- IntegerHandler that = (IntegerHandler) o;
+ final IntegerHandler that = (IntegerHandler) o;
if (foo != that.foo) {
return false;
@@ -112,7 +112,7 @@ final class UnitClass {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -120,7 +120,7 @@ final class UnitClass {
return false;
}
- StringHandler that = (StringHandler) o;
+ final StringHandler that = (StringHandler) o;
if (bar != that.bar) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
index 9991125..5c70bfe 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
@@ -103,7 +103,7 @@ final class EvaluatorReuseTestDriver {
try {
eb.submitContext(ContextConfiguration.CONF
.set(ContextConfiguration.IDENTIFIER, "EvaluatorReuse").build());
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
index d5fc72c..69652f9 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
@@ -106,7 +106,7 @@ public final class NoopTask implements Task, TaskMessageSource {
public class DriverMessageHandler implements EventHandler<DriverMessage> {
@Override
- public void onNext(DriverMessage driverMessage) {
+ public void onNext(final DriverMessage driverMessage) {
final byte[] msg = driverMessage.get().get();
LOG.log(Level.INFO, "NoopTask.DriverMessageHandler.send() invoked: {0}", CODEC.decode(msg));
synchronized (NoopTask.this) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
index 5fe85f7..165da57 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
@@ -33,7 +33,7 @@ public final class OnDriverStartedAllocateOne implements EventHandler<StartTime>
private final EvaluatorRequestor requestor;
@Inject
- OnDriverStartedAllocateOne(EvaluatorRequestor requestor) {
+ OnDriverStartedAllocateOne(final EvaluatorRequestor requestor) {
this.requestor = requestor;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
index c64869e..7648ebf 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
@@ -25,19 +25,19 @@ public final class ExpectedTaskException extends RuntimeException {
public ExpectedTaskException() {
}
- public ExpectedTaskException(String s) {
+ public ExpectedTaskException(final String s) {
super(s);
}
- public ExpectedTaskException(String s, Throwable throwable) {
+ public ExpectedTaskException(final String s, final Throwable throwable) {
super(s, throwable);
}
- public ExpectedTaskException(Throwable throwable) {
+ public ExpectedTaskException(final Throwable throwable) {
super(throwable);
}
- public ExpectedTaskException(String s, Throwable throwable, boolean b, boolean b2) {
+ public ExpectedTaskException(final String s, final Throwable throwable, final boolean b, final boolean b2) {
super(s, throwable, b, b2);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
index 9c11ebb..4db35f8 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
@@ -32,7 +32,7 @@ public final class EchoTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
return memento;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
index 9565a09..ac14697 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
@@ -32,7 +32,7 @@ public final class NoopTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
return null;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
index 3e31330..3895c97 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
@@ -74,7 +74,7 @@ public final class TaskMessagingTask implements Task, TaskMessageSource {
public class DriverMessageHandler implements EventHandler<DriverMessage> {
@Override
- public void onNext(DriverMessage driverMessage) {
+ public void onNext(final DriverMessage driverMessage) {
final byte[] driverMsg = driverMessage.get().get();
LOG.log(Level.INFO, "TaskMsg.send() invoked: {0}", CODEC.decode(driverMsg));
TaskMessagingTask.this.message = Optional.of(TaskMessage.from(this.toString(), driverMsg));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
index 1d7ad8d..b46bea7 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
@@ -43,7 +43,7 @@ public class StatePassingTask implements Task {
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
this.c.increment();
return makeArray(this.c.getValue(), (byte) 1);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
index ed51ca7..c6f750a 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
@@ -52,9 +52,10 @@ public final class TestUtils {
* @param clazz class inherited from type Throwable.
* @return True if ex or any other exception in its cause chain is instance of class clazz.
*/
- public static boolean hasCause(Throwable ex, final Class<? extends Throwable> clazz) {
- for (; ex != null; ex = ex.getCause()) {
- if (clazz.isInstance(ex)) {
+ public static boolean hasCause(final Throwable ex, final Class<? extends Throwable> clazz) {
+ Throwable exception = ex;
+ for (; exception != null; exception = exception.getCause()) {
+ if (clazz.isInstance(exception)) {
return true;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
index 8dda422..7cf74be 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
@@ -40,7 +40,7 @@ final class ConfigurationProviderTestDriver {
private final Injector injector;
@Inject
- private ConfigurationProviderTestDriver(EvaluatorRequestor evaluatorRequestor, Injector injector) {
+ private ConfigurationProviderTestDriver(final EvaluatorRequestor evaluatorRequestor, final Injector injector) {
this.evaluatorRequestor = evaluatorRequestor;
this.injector = injector;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
index 2c765de..11ca760 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
@@ -48,7 +48,7 @@ final class EvaluatorFailureDuringAlarmDriver {
final class EvaluatorAllocatedHandler implements EventHandler<AllocatedEvaluator> {
@Override
- public void onNext(AllocatedEvaluator allocatedEvaluator) {
+ public void onNext(final AllocatedEvaluator allocatedEvaluator) {
final Configuration contextConfiguration = ContextConfiguration.CONF
.set(ContextConfiguration.IDENTIFIER, "FailingEvaluator")
.set(ContextConfiguration.ON_CONTEXT_STARTED, FailureSchedulingContextStartHandler.class)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
index f60cb2d..ffa6cdd 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
@@ -43,7 +43,7 @@ final class FailureSchedulingContextStartHandler implements EventHandler<Context
public void onNext(final ContextStart contextStart) {
this.clock.scheduleAlarm(0, new EventHandler<Alarm>() {
@Override
- public void onNext(Alarm alarm) {
+ public void onNext(final Alarm alarm) {
LOG.log(Level.INFO, "Invoked for {0}, throwing an Exception now.", alarm);
throw new ExpectedException();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
index a8e0fc1..c8ee6ba 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
@@ -50,7 +50,7 @@ final class FileResourceTestTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
for (final String fileName : expectedFileNames) {
final File file = new File(localFolder, fileName);
LOG.log(Level.INFO, "Testing file: " + file.getAbsolutePath());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
index 06ab37a..4cf733b 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
@@ -47,15 +47,15 @@ public final class ActiveContextHandler implements EventHandler<ActiveContext> {
}
@Override
- public void onNext(ActiveContext activeContext) {
+ public void onNext(final ActiveContext activeContext) {
LOG.log(Level.FINEST, "ActiveContext received. Submitting empty task to it");
- Configuration taskConfiguration;
+ final Configuration taskConfiguration;
try {
taskConfiguration = TaskConfiguration.CONF
.set(TaskConfiguration.IDENTIFIER, "EmptyREEFTask")
.set(TaskConfiguration.TASK, EmptyTask.class)
.build();
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new RuntimeException("Unable to setup Task configuration", e);
}
activeContext.submitTask(taskConfiguration);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
index 73b2051..0c3b6fd 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
@@ -44,7 +44,7 @@ public class ClosedContextHandler implements EventHandler<ClosedContext> {
}
@Override
- public void onNext(ClosedContext closedContext) {
+ public void onNext(final ClosedContext closedContext) {
LOG.log(Level.FINEST, "Received a closed context");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
index ab0ab13..be9625a 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
@@ -45,7 +45,7 @@ public class CompletedEvaluatorHandler implements
}
@Override
- public void onNext(CompletedEvaluator completedEvaluator) {
+ public void onNext(final CompletedEvaluator completedEvaluator) {
LOG.log(Level.FINEST, "Received a completed evaluator");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
index 2b8c0fe..96498fc 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
@@ -44,7 +44,7 @@ public class CompletedTaskHandler implements EventHandler<CompletedTask> {
}
@Override
- public void onNext(CompletedTask completedTask) {
+ public void onNext(final CompletedTask completedTask) {
LOG.log(Level.FINEST, "Received a completed task");
completedTask.getActiveContext().close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
index b47faad..29ad0e2 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
@@ -32,7 +32,7 @@ public class EmptyTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
index 733bc04..fd419b3 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
@@ -44,7 +44,7 @@ public class RunningTaskHandler implements EventHandler<RunningTask> {
}
@Override
- public void onNext(RunningTask runningTask) {
+ public void onNext(final RunningTask runningTask) {
LOG.log(Level.FINEST, "Received a running task");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
index 0d1cc7c..cb5e61d 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
@@ -52,7 +52,7 @@ public final class StartHandler implements EventHandler<StartTime> {
}
@Override
- public void onNext(StartTime startTime) {
+ public void onNext(final StartTime startTime) {
LOG.log(Level.INFO, "StartTime: ", startTime);
StartHandler.this.requestor.submit(EvaluatorRequest.newBuilder()
.setNumber(5)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
index 8a3dbf7..ea19843 100644
--- a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
+++ b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
@@ -66,7 +66,7 @@ final class WrappedValue<V> {
public synchronized V loadAndGet() throws ExecutionException {
try {
value = Optional.ofNullable(valueFetcher.call());
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new ExecutionException(e);
} finally {
writeTime = Optional.of(currentTime.now());
@@ -83,7 +83,7 @@ final class WrappedValue<V> {
while (!value.isPresent()) {
try {
this.wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
// Ignore, as while loop will be re-entered
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
index 64e55e9..7c634d6 100644
--- a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
+++ b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
@@ -66,7 +66,7 @@ public final class CacheImplConcurrentTest {
// Assert that firstValue is returned, even when other gets are called during the Callable execution
getFirstValue1 = cache.get(key, new SleepingInteger(firstValue, computationMillis));
assertEquals(firstValue, getFirstValue1);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -83,7 +83,7 @@ public final class CacheImplConcurrentTest {
// The original cached value should be retrieved
final int getFirstValue2 = cache.get(key, new ImmediateInteger(secondValue));
assertEquals(firstValue, getFirstValue2);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -120,7 +120,7 @@ public final class CacheImplConcurrentTest {
public void run() {
try {
getValues[index] = cache.get(key, new ImmediateInteger(values[index]));
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -157,7 +157,7 @@ public final class CacheImplConcurrentTest {
// Assert that firstValue is returned, even when it is invalidated during the Callable execution
getFirstValue1 = cache.get(key, new SleepingInteger(firstValue, computationMillis));
assertEquals(firstValue, getFirstValue1);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -178,7 +178,7 @@ public final class CacheImplConcurrentTest {
// The original cached value should be retrieved, even when it is invalidated during the Callable execution
final int getFirstValue2 = cache.get(key, new ImmediateInteger(secondValue));
assertEquals(firstValue, getFirstValue2);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
} else {
@@ -186,7 +186,7 @@ public final class CacheImplConcurrentTest {
// The second value should be retrieved, because the cache has been invalidated
final int getFirstValue2 = cache.get(key, new ImmediateInteger(secondValue));
assertEquals(secondValue, getFirstValue2);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
index 374fcdd..f244083 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
@@ -43,7 +43,7 @@ public abstract class AbstractEStage<T> implements EStage<T> {
*
* @parm stageName the stage name
*/
- public AbstractEStage(String stageName) {
+ public AbstractEStage(final String stageName) {
this.closed = new AtomicBoolean(false);
this.name = stageName;
this.inMeter = new Meter(stageName + "_in");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
index 437dd9a..7f8ccf1 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
@@ -32,7 +32,7 @@ public class IdentifierParser implements ExternalConstructor<Identifier> {
// TODO: Modify tang to allow this to use a factory pattern.
static {
- Map<String, Class<? extends Identifier>> map = new ConcurrentHashMap<>();
+ final Map<String, Class<? extends Identifier>> map = new ConcurrentHashMap<>();
map.put("socket", SocketRemoteIdentifier.class);
map.put("file", FileIdentifier.class);
@@ -43,7 +43,7 @@ public class IdentifierParser implements ExternalConstructor<Identifier> {
final Identifier id;
@Inject
- IdentifierParser(String s) {
+ IdentifierParser(final String s) {
id = FACTORY.getNewInstance(s);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
index 57d817a..3c8d787 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
@@ -44,13 +44,13 @@ public final class WakeConfiguration {
if (confFileName.equals("")) {
LOG.log(Level.WARNING, "The Wake configuration file is not specified.");
} else {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = t.newConfigurationBuilder();
try {
ConfigurationFile.addConfiguration(cb, new File(confFileName));
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new WakeRuntimeException(e);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new WakeRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
index 6741d35..da0b04c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
@@ -33,7 +33,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
private final ConcurrentSkipListMap<K, V> register = new ConcurrentSkipListMap<>();
private volatile boolean done = false;
- public CombinerStage(Combiner<K, V> c, Observer<Map.Entry<K, V>> o) {
+ public CombinerStage(final Combiner<K, V> c, final Observer<Map.Entry<K, V>> o) {
this.c = c;
this.o = o;
worker.start();
@@ -42,10 +42,10 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
public Observer<Map.Entry<K, V>> wireIn() {
return new Observer<Map.Entry<K, V>>() {
@Override
- public void onNext(Map.Entry<K, V> pair) {
+ public void onNext(final Map.Entry<K, V> pair) {
V old;
V newVal;
- boolean wasEmpty = register.isEmpty();
+ final boolean wasEmpty = register.isEmpty();
boolean succ = false;
while (!succ) {
@@ -66,7 +66,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
o.onError(error);
}
@@ -95,13 +95,13 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
private final K k;
private final V v;
- public Pair(K k, V v) {
+ public Pair(final K k, final V v) {
this.k = k;
this.v = v;
}
@Override
- public int compareTo(Map.Entry<K, V> arg0) {
+ public int compareTo(final Map.Entry<K, V> arg0) {
return k.compareTo(arg0.getKey());
}
@@ -116,7 +116,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
}
@Override
- public V setValue(V value) {
+ public V setValue(final V value) {
throw new UnsupportedOperationException();
}
}
@@ -134,7 +134,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
while (register.isEmpty() && !done) {
try {
register.wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
throw new IllegalStateException(e);
}
}
@@ -146,7 +146,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
Map.Entry<K, V> cursor = register.pollFirstEntry();
while (cursor != null) {
o.onNext(cursor);
- K nextKey = register.higherKey(cursor.getKey());
+ final K nextKey = register.higherKey(cursor.getKey());
/* If there is more than one OutputThread worker then the remove() -> null case
* must be handled
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
index 72c6ea6..b70e9df 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
@@ -29,7 +29,7 @@ public class BlockingJoin implements StaticObservable {
private final ConcurrentSkipListSet<TupleEvent> left = new ConcurrentSkipListSet<>();
boolean leftDone = false;
- public BlockingJoin(Observer<TupleEvent> out) {
+ public BlockingJoin(final Observer<TupleEvent> out) {
this.out = out;
}
@@ -42,7 +42,7 @@ public class BlockingJoin implements StaticObservable {
while (!leftDone) {
try {
wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
throw new IllegalStateException(
"No support for interrupted threads here!", e);
}
@@ -53,12 +53,12 @@ public class BlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
left.add(value);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
}
@@ -74,7 +74,7 @@ public class BlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
if (!leftDone) {
waitUntilLeftIsDone();
}
@@ -84,7 +84,7 @@ public class BlockingJoin implements StaticObservable {
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
index cf8be97..26e0685 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
@@ -23,12 +23,12 @@ import org.apache.reef.wake.rx.Observer;
public class EventPrinter<T> implements Observer<T> {
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
System.out.println(this + ": " + value);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
System.err.println(this + ": " + error);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
index bb922d3..2f864d3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
@@ -35,7 +35,7 @@ public class NonBlockingJoin implements StaticObservable {
private final ConcurrentSkipListSet<TupleEvent> leftTable = new ConcurrentSkipListSet<TupleEvent>();
private final ConcurrentSkipListSet<TupleEvent> rightTable = new ConcurrentSkipListSet<TupleEvent>();
- public NonBlockingJoin(Observer<TupleEvent> out) {
+ public NonBlockingJoin(final Observer<TupleEvent> out) {
this.out = out;
}
@@ -69,12 +69,12 @@ public class NonBlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
leftTable.add(value);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
leftTable.clear();
rightTable.clear();
out.onError(error);
@@ -93,7 +93,7 @@ public class NonBlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
if (leftTable.contains(value)) {
out.onNext(value);
} else if (!leftDone.get()) {
@@ -103,7 +103,7 @@ public class NonBlockingJoin implements StaticObservable {
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
leftTable.clear();
rightTable.clear();
out.onError(error);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
index 57dd6f2..4084730 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
@@ -23,14 +23,14 @@ public class TupleEvent implements Comparable<TupleEvent> {
private final int key;
private final String val;
- public TupleEvent(int key, String val) {
+ public TupleEvent(final int key, final String val) {
this.key = key;
this.val = val;
}
@Override
- public int compareTo(TupleEvent o) {
- int keycmp = Integer.compare(key, o.key);
+ public int compareTo(final TupleEvent o) {
+ final int keycmp = Integer.compare(key, o.key);
if (keycmp != 0) {
return keycmp;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
index 16590a9..22ed659 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
@@ -50,7 +50,7 @@ public class TupleSource implements StaticObservable, Stage {
@Override
public void close() throws Exception {
- for (Thread t : threads) {
+ for (final Thread t : threads) {
t.join();
}
out.onCompleted();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
index d27b719..60604d3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
@@ -53,7 +53,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> {
@Override
public void onNext(final T event) {
this.events.add(event);
- int newCursor = this.cursor.incrementAndGet();
+ final int newCursor = this.cursor.incrementAndGet();
if (newCursor % expectedSize == 0) {
// FIXME: There is a race here where the person draining the events might
@@ -61,7 +61,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> {
// matter, since all events will still be drained exactly once by someone in
// the proper order
- ArrayList<T> nonConcurrent = new ArrayList<>(expectedSize);
+ final ArrayList<T> nonConcurrent = new ArrayList<>(expectedSize);
synchronized (events) {
// drainTo(maxElements) does not suffice because it has undefined behavior for
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
index 7b582bb..5c1869c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
@@ -47,7 +47,7 @@ public final class BlockingSignalEventHandler<T> implements EventHandler<T> {
@Override
public void onNext(final T event) {
- int newSize = this.cursor.incrementAndGet();
+ final int newSize = this.cursor.incrementAndGet();
if (newSize % expectedSize == 0) {
this.destination.onNext(event);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
index 05cc7ef..231262f 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
@@ -56,7 +56,7 @@ public class DefaultIdentifierFactory implements IdentifierFactory {
*
* @param typeToClazzMap the map of type strings to classes of remote identifiers
*/
- public DefaultIdentifierFactory(Map<String, Class<? extends Identifier>> typeToClazzMap) {
+ public DefaultIdentifierFactory(final Map<String, Class<? extends Identifier>> typeToClazzMap) {
this.typeToClazzMap = typeToClazzMap;
}
@@ -68,18 +68,18 @@ public class DefaultIdentifierFactory implements IdentifierFactory {
* @throws RemoteRuntimeException
*/
@Override
- public Identifier getNewInstance(String str) {
- int index = str.indexOf("://");
+ public Identifier getNewInstance(final String str) {
+ final int index = str.indexOf("://");
if (index < 0) {
throw new RemoteRuntimeException("Invalid name " + str);
}
- String type = str.substring(0, index);
- Class<? extends Identifier> clazz = typeToClazzMap.get(type);
- Class<?>[] argTypes = {String.class};
- Constructor<? extends Identifier> constructor;
+ final String type = str.substring(0, index);
+ final Class<? extends Identifier> clazz = typeToClazzMap.get(type);
+ final Class<?>[] argTypes = {String.class};
+ final Constructor<? extends Identifier> constructor;
try {
constructor = clazz.getDeclaredConstructor(argTypes);
- Object[] args = new Object[1];
+ final Object[] args = new Object[1];
args[0] = str.substring(index + 3);
return constructor.newInstance(args);
} catch (NoSuchMethodException | SecurityException | InstantiationException | IllegalAccessException |
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
index 839a13f..53c6efb 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
@@ -36,8 +36,8 @@ public final class DefaultThreadFactory implements ThreadFactory {
*
* @param prefix the name prefix of the created thread
*/
- public DefaultThreadFactory(String prefix) {
- SecurityManager s = System.getSecurityManager();
+ public DefaultThreadFactory(final String prefix) {
+ final SecurityManager s = System.getSecurityManager();
this.group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
this.prefix = prefix + "-pool-" + POOL_NUMBER.getAndIncrement() + "-thread-";
this.uncaughtExceptionHandler = null;
@@ -49,8 +49,8 @@ public final class DefaultThreadFactory implements ThreadFactory {
* @param prefix the name prefix of the created thread
* @param uncaughtExceptionHandler the uncaught exception handler of the created thread
*/
- public DefaultThreadFactory(String prefix, Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
- SecurityManager s = System.getSecurityManager();
+ public DefaultThreadFactory(final String prefix, final Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
+ final SecurityManager s = System.getSecurityManager();
this.group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
this.prefix = prefix + "-pool-" + POOL_NUMBER.getAndIncrement() + "-thread-";
this.uncaughtExceptionHandler = uncaughtExceptionHandler;
@@ -61,7 +61,7 @@ public final class DefaultThreadFactory implements ThreadFactory {
*
* @param uncaughtExceptionHandler the uncaught exception handler
*/
- public void setUncaughtExceptionHandler(Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
+ public void setUncaughtExceptionHandler(final Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
this.uncaughtExceptionHandler = uncaughtExceptionHandler;
}
@@ -71,8 +71,8 @@ public final class DefaultThreadFactory implements ThreadFactory {
* @param r the runnable
*/
@Override
- public Thread newThread(Runnable r) {
- Thread t = new Thread(group, r, prefix + threadNumber.getAndIncrement(), 0);
+ public Thread newThread(final Runnable r) {
+ final Thread t = new Thread(group, r, prefix + threadNumber.getAndIncrement(), 0);
if (t.isDaemon()) {
t.setDaemon(false);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
index e08a31b..9018e1d 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
@@ -50,9 +50,9 @@ public class ForkPoolStage<T> extends AbstractEStage<T> {
private final WakeSharedPool pool;
@Inject
- public ForkPoolStage(@Parameter(StageConfiguration.StageName.class) String stageName,
- @Parameter(StageConfiguration.StageHandler.class) EventHandler<T> handler,
- WakeSharedPool sharedPool
+ public ForkPoolStage(@Parameter(StageConfiguration.StageName.class) final String stageName,
+ @Parameter(StageConfiguration.StageHandler.class) final EventHandler<T> handler,
+ final WakeSharedPool sharedPool
) {
super(stageName);
this.pool = sharedPool;
@@ -63,8 +63,8 @@ public class ForkPoolStage<T> extends AbstractEStage<T> {
}
@Inject
- public ForkPoolStage(@Parameter(StageConfiguration.StageHandler.class) EventHandler<T> handler,
- WakeSharedPool sharedPool) {
+ public ForkPoolStage(@Parameter(StageConfiguration.StageHandler.class) final EventHandler<T> handler,
+ final WakeSharedPool sharedPool) {
this(ForkPoolStage.class.getName(), handler, sharedPool);
}
@@ -80,7 +80,7 @@ public class ForkPoolStage<T> extends AbstractEStage<T> {
}
@Override
- protected void setRawResult(T value) {
+ protected void setRawResult(final T value) {
// tasks have no results because they are events
// this may be used for extensions
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
index 11048fc..91a2352 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
@@ -42,7 +42,8 @@ public class IndependentIterationsThreadPoolStage<T> extends AbstractEStage<List
private EventHandler<T> handler;
private ExecutorService executor;
- public IndependentIterationsThreadPoolStage(EventHandler<T> handler, int numThreads, int granularity) {
+ public IndependentIterationsThreadPoolStage(
+ final EventHandler<T> handler, final int numThreads, final int granularity) {
super(handler.getClass().getName());
this.handler = handler;
this.executor = Executors.newFixedThreadPool(numThreads);
@@ -53,7 +54,7 @@ public class IndependentIterationsThreadPoolStage<T> extends AbstractEStage<List
return new Runnable() {
@Override
public void run() {
- for (T e : iterations) {
+ for (final T e : iterations) {
handler.onNext(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
index 3a4da62..8dab064 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
@@ -42,7 +42,7 @@ public class LoggingEventHandler<T> implements EventHandler<T> {
* @param value an event
*/
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
LOG.log(Level.FINE, "{0}", value);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
index 597861b..c3ba8d6 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
@@ -33,10 +33,10 @@ public final class LoggingUtils {
*
* @param level the logging level
*/
- public static void setLoggingLevel(Level level) {
- Handler[] handlers = Logger.getLogger("").getHandlers();
+ public static void setLoggingLevel(final Level level) {
+ final Handler[] handlers = Logger.getLogger("").getHandlers();
ConsoleHandler ch = null;
- for (Handler h : handlers) {
+ for (final Handler h : handlers) {
if (h instanceof ConsoleHandler) {
ch = (ConsoleHandler) h;
break;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
index 8d91e86..2681d19 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
@@ -40,7 +40,7 @@ public class LoggingVoidEventHandler implements EventHandler<Void> {
* @param value an event
*/
@Override
- public void onNext(Void value) {
+ public void onNext(final Void value) {
LOG.log(Level.FINE, "Logging void event handler");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
index 8a99311..07771a0 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
@@ -64,7 +64,7 @@ public final class MergingEventHandler<L, R> {
public final S1 first;
public final S2 second;
- private Pair(S1 s1, S2 s2) {
+ private Pair(final S1 s1, final S2 s2) {
this.first = s1;
this.second = s2;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
index e2f9923..9d8de3d 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
@@ -37,7 +37,7 @@ public class MultiEventHandler<T> implements EventHandler<T> {
*
* @param map a map of class types to event handlers
*/
- public MultiEventHandler(Map<Class<? extends T>, EventHandler<? extends T>> map) {
+ public MultiEventHandler(final Map<Class<? extends T>, EventHandler<? extends T>> map) {
this.map = map;
}
@@ -48,8 +48,8 @@ public class MultiEventHandler<T> implements EventHandler<T> {
* @throws WakeRuntimeException
*/
@Override
- public void onNext(T event) {
- EventHandler<T> handler = (EventHandler<T>) map.get(event.getClass());
+ public void onNext(final T event) {
+ final EventHandler<T> handler = (EventHandler<T>) map.get(event.getClass());
if (handler == null) {
throw new WakeRuntimeException("No event " + event.getClass() + " handler");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
index c3b5ba9..5667eb5 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
@@ -53,7 +53,7 @@ public class PubSubEventHandler<T> implements EventHandler<T> {
*
* @param map a map of event class types to lists of event handlers
*/
- public PubSubEventHandler(Map<Class<? extends T>, List<EventHandler<? extends T>>> clazzToListOfHandlersMap) {
+ public PubSubEventHandler(final Map<Class<? extends T>, List<EventHandler<? extends T>>> clazzToListOfHandlersMap) {
this.clazzToListOfHandlersMap = clazzToListOfHandlersMap;
}
@@ -63,7 +63,7 @@ public class PubSubEventHandler<T> implements EventHandler<T> {
* @param clazz an event class
* @param handler an event handler
*/
- public void subscribe(Class<? extends T> clazz, EventHandler<? extends T> handler) {
+ public void subscribe(final Class<? extends T> clazz, final EventHandler<? extends T> handler) {
lock.writeLock().lock();
try {
List<EventHandler<? extends T>> list = clazzToListOfHandlersMap.get(clazz);
@@ -84,10 +84,10 @@ public class PubSubEventHandler<T> implements EventHandler<T> {
* @throws WakeRuntimeException
*/
@Override
- public void onNext(T event) {
+ public void onNext(final T event) {
LOG.log(Level.FINEST, "Invoked for event: {0}", event);
lock.readLock().lock();
- List<EventHandler<? extends T>> list;
+ final List<EventHandler<? extends T>> list;
try {
list = clazzToListOfHandlersMap.get(event.getClass());
if (list == null) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
index 6bd0455..033a1cb 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
@@ -84,7 +84,7 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> {
* @throws IllegalStateException
*/
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
beforeOnNext();
queue.add(value);
}
@@ -113,7 +113,8 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> {
private final EventHandler<U> handler;
private final AtomicBoolean interrupted;
- Producer(String name, BlockingQueue<U> queue, EventHandler<U> handler, AtomicBoolean interrupted) {
+ Producer(final String name, final BlockingQueue<U> queue, final EventHandler<U> handler,
+ final AtomicBoolean interrupted) {
this.name = name;
this.queue = queue;
this.handler = handler;
@@ -124,15 +125,15 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> {
public void run() {
while (true) {
try {
- U value = queue.take();
+ final U value = queue.take();
handler.onNext(value);
SingleThreadStage.this.afterOnNext();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
if (interrupted.get()) {
LOG.log(Level.FINEST, name + " Closing Producer due to interruption");
break;
}
- } catch (Throwable t) {
+ } catch (final Throwable t) {
LOG.log(Level.SEVERE, name + " Exception from event handler", t);
throw t;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
index 547ab7d..806428e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
@@ -90,7 +90,7 @@ public final class SyncStage<T> extends AbstractEStage<T> {
beforeOnNext();
try {
handler.onNext(value);
- } catch (Throwable t) {
+ } catch (final Throwable t) {
if (errorHandler != null) {
errorHandler.onNext(t);
} else {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
index 483a7e4..451e6cd 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
@@ -180,7 +180,7 @@ public final class ThreadPoolStage<T> extends AbstractEStage<T> {
try {
handler.onNext(value);
afterOnNext();
- } catch (Throwable t) {
+ } catch (final Throwable t) {
if (errorHandler != null) {
errorHandler.onNext(t);
} else {
@@ -205,7 +205,7 @@ public final class ThreadPoolStage<T> extends AbstractEStage<T> {
executor.shutdown();
if (!executor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = executor.shutdownNow();
+ final List<Runnable> droppedRunnables = executor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
index 191110c..7b055b3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
@@ -127,7 +127,7 @@ public final class TimerStage implements Stage {
executor.shutdown();
if (!executor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = executor.shutdownNow();
+ final List<Runnable> droppedRunnables = executor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
index 546747e..3a43925 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
@@ -55,11 +55,11 @@ public class WakeSharedPool implements Stage {
private AtomicBoolean closed = new AtomicBoolean(false);
@Inject
- public WakeSharedPool(@Parameter(Parallelism.class) int parallelism) {
+ public WakeSharedPool(@Parameter(Parallelism.class) final int parallelism) {
this.pool = new ForkJoinPool(parallelism, ForkJoinPool.defaultForkJoinWorkerThreadFactory,
new Thread.UncaughtExceptionHandler() {
@Override
- public void uncaughtException(Thread t, Throwable e) {
+ public void uncaughtException(final Thread t, final Throwable e) {
// TODO: need to pass this upwards to REEF can grab it
}
},
@@ -82,7 +82,7 @@ public class WakeSharedPool implements Stage {
this(DEFAULT_PARALLELISM);
}
- public void submit(ForkJoinTask<?> t) {
+ public void submit(final ForkJoinTask<?> t) {
if (ForkJoinTask.inForkJoinPool()) {
ForkJoinTask.invokeAll(t);
// alternatively just pool().pool.execute(t), which simply forces it to be this pool
@@ -99,7 +99,7 @@ public class WakeSharedPool implements Stage {
pool.shutdown();
if (!pool.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = pool.shutdownNow();
+ final List<Runnable> droppedRunnables = pool.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
index f729fbe..b081cee 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
@@ -33,12 +33,12 @@ public final class WakeUncaughtExceptionHandler implements Thread.UncaughtExcept
this.errorHandler = errorHandler;
}
- public void setErrorHandler(EventHandler<Throwable> errorHandler) {
+ public void setErrorHandler(final EventHandler<Throwable> errorHandler) {
this.errorHandler = errorHandler;
}
@Override
- public void uncaughtException(Thread t, Throwable e) {
+ public void uncaughtException(final Thread t, final Throwable e) {
final String msg = "Thread " + t.getName() + " threw an uncaught exception.";
if (errorHandler != null) {
errorHandler.onNext(new Exception(msg, e));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
index 35c35fb..b10b215 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
@@ -39,7 +39,7 @@ public class EWMA {
* @param interval
* @param intervalUnit
*/
- public EWMA(double alpha, long interval, TimeUnit intervalUnit) {
+ public EWMA(final double alpha, final long interval, final TimeUnit intervalUnit) {
this.interval = intervalUnit.toNanos(interval);
this.alpha = alpha;
}
@@ -49,7 +49,7 @@ public class EWMA {
*
* @param n the new value
*/
- public void update(long n) {
+ public void update(final long n) {
uncounted.addAndGet(n);
}
@@ -73,7 +73,7 @@ public class EWMA {
* @param rateUnit the unit of the rate
* @return the rate
*/
- public double getRate(TimeUnit rateUnit) {
+ public double getRate(final TimeUnit rateUnit) {
return rate * (double) rateUnit.toNanos(1);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
index 588fd4d..8bf1022 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
@@ -43,7 +43,7 @@ public class Meter {
*
* @param name the name of the meter
*/
- public Meter(String name) {
+ public Meter(final String name) {
this.name = name;
this.m1Thp = new EWMA(EWMAParameters.M1_ALPHA, EWMAParameters.INTERVAL, TimeUnit.SECONDS);
this.m5Thp = new EWMA(EWMAParameters.M5_ALPHA, EWMAParameters.INTERVAL, TimeUnit.SECONDS);
@@ -66,7 +66,7 @@ public class Meter {
*
* @param n the number of events
*/
- public void mark(long n) {
+ public void mark(final long n) {
tickIfNecessary();
count.addAndGet(n);
m1Thp.update(n);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
index c2869ae..39e08b4 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
@@ -36,7 +36,7 @@ public class UniformHistogram implements Histogram {
* @param binWidth the width of each bin
* @param numBins the number of bins
*/
- public UniformHistogram(long binWidth, int numBins) {
+ public UniformHistogram(final long binWidth, final int numBins) {
this.count = new AtomicLong(0);
this.values = new AtomicLongArray(numBins);
this.binWidth = binWidth;
@@ -49,7 +49,7 @@ public class UniformHistogram implements Histogram {
* @param value
*/
@Override
- public void update(long value) {
+ public void update(final long value) {
count.incrementAndGet();
int index = (int) (value / binWidth);
if (index >= numBins) {
@@ -75,7 +75,7 @@ public class UniformHistogram implements Histogram {
* @return the value of the index
*/
@Override
- public long getValue(int index) {
+ public long getValue(final int index) {
return values.get(index);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
index 0ea7d28..593a219 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
@@ -32,7 +32,8 @@ public class Vertex<T> {
private final Vertex<?>[] constructorArguments;
// private final Set<Object> referencesToThisObject = new MonotonicHashSet<>();
- public Vertex(T object, String name, ConstructorDef<T> constructorDef, Vertex<?>[] constructorArguments) {
+ public Vertex(final T object, final String name, final ConstructorDef<T> constructorDef,
+ final Vertex<?>[] constructorArguments) {
this.object = object;
if (object == null) {
throw new NullPointerException();
@@ -40,14 +41,14 @@ public class Vertex<T> {
this.name = name;
this.constructorDef = constructorDef;
this.constructorArguments = constructorArguments;
- for (Vertex<?> v : constructorArguments) {
+ for (final Vertex<?> v : constructorArguments) {
if (v == null) {
throw new NullPointerException();
}
}
}
- public Vertex(T object, ConstructorDef<T> constructorDef, Vertex<?>[] constructorArguments) {
+ public Vertex(final T object, final ConstructorDef<T> constructorDef, final Vertex<?>[] constructorArguments) {
this.object = object;
if (object == null) {
throw new NullPointerException();
@@ -55,14 +56,14 @@ public class Vertex<T> {
this.name = null;
this.constructorDef = constructorDef;
this.constructorArguments = constructorArguments;
- for (Vertex<?> v : constructorArguments) {
+ for (final Vertex<?> v : constructorArguments) {
if (v == null) {
throw new NullPointerException();
}
}
}
- public Vertex(Object object) {
+ public Vertex(final Object object) {
this.object = object;
if (object == null) {
throw new NullPointerException();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
index 927815a..72714d6 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
@@ -47,7 +47,7 @@ public class WakeProfiler implements Aspect {
}
@SuppressWarnings("unchecked")
- private <T> Vertex<T> getVertex(T t) {
+ private <T> Vertex<T> getVertex(final T t) {
if (t instanceof Set) {
return (Vertex<T>) newSetVertex((Set<?>) t);
} else {
@@ -62,30 +62,30 @@ public class WakeProfiler implements Aspect {
}
@SuppressWarnings("unchecked")
- private <T> Vertex<T> getFuture(InjectionFuture<T> future) {
+ private <T> Vertex<T> getFuture(final InjectionFuture<T> future) {
return getVertex((T) futures.get(future));
}
@SuppressWarnings("unchecked")
- private <T> Vertex<?> newSetVertex(Set<T> s) {
+ private <T> Vertex<?> newSetVertex(final Set<T> s) {
if (vertexObject.containsKey(s)) {
return (Vertex<Set<T>>) vertexObject.get(s);
}
if (s.size() > -1) {
LOG.fine("new set of size " + s.size());
- Vertex<?>[] sArgs = new Vertex[s.size()];
+ final Vertex<?>[] sArgs = new Vertex[s.size()];
int k = 0;
- for (Object p : s) {
+ for (final Object p : s) {
sArgs[k] = getVertex(p);
k++;
}
- Vertex<Set<T>> sv = new Vertex<>(s, null, sArgs);
+ final Vertex<Set<T>> sv = new Vertex<>(s, null, sArgs);
vertexObject.put(s, sv);
return sv;
// } else if(s.size() == 1) {
} else {
- Object p = s.iterator().next();
- Vertex<?> w = getVertex(p);
+ final Object p = s.iterator().next();
+ final Vertex<?> w = getVertex(p);
// alias the singleton set to its member
vertexObject.put(s, w);
return w;
@@ -97,13 +97,13 @@ public class WakeProfiler implements Aspect {
@SuppressWarnings("unchecked")
@Override
- public <T> T inject(ConstructorDef<T> constructorDef, Constructor<T> constructor, Object[] args)
+ public <T> T inject(final ConstructorDef<T> constructorDef, final Constructor<T> constructor, final Object[] args)
throws InvocationTargetException, IllegalAccessException, IllegalArgumentException, InstantiationException {
// LOG.info("inject" + constructor + "->" + args.length);
- Vertex<?>[] vArgs = new Vertex[args.length];
+ final Vertex<?>[] vArgs = new Vertex[args.length];
for (int i = 0; i < args.length; i++) {
- Object o = args[i];
- Vertex<?> v = getVertex(o);
+ final Object o = args[i];
+ final Vertex<?> v = getVertex(o);
if (o instanceof Set) {
LOG.fine("Got a set arg for " + constructorDef + " length " + ((Set<?>) o).size());
}
@@ -113,7 +113,7 @@ public class WakeProfiler implements Aspect {
T ret;
final Class<T> clazz = constructor.getDeclaringClass();
boolean isEventHandler = false;
- for (Method m : clazz.getDeclaredMethods()) {
+ for (final Method m : clazz.getDeclaredMethods()) {
if (m.getName().equals("onNext")) { // XXX hack: Interpose on "event handler in spirit"
isEventHandler = true;
}
@@ -124,19 +124,19 @@ public class WakeProfiler implements Aspect {
throw new Exception(ReflectionUtilities.getFullName(clazz) + ".onNext() is final; cannot intercept it");
}
final Stats s = new Stats();
- Enhancer e = new Enhancer();
+ final Enhancer e = new Enhancer();
e.setSuperclass(clazz);
e.setCallback(new MethodInterceptor() {
@Override
- public Object intercept(Object object, Method method, Object[] args,
- MethodProxy methodProxy) throws Throwable {
+ public Object intercept(final Object object, final Method method, final Object[] args,
+ final MethodProxy methodProxy) throws Throwable {
if (method.getName().equals("onNext")) {
- long start = System.nanoTime();
+ final long start = System.nanoTime();
// LOG.info(object + "." + method.getName() + " called");
- Object o = methodProxy.invokeSuper(object, args);
- long stop = System.nanoTime();
+ final Object o = methodProxy.invokeSuper(object, args);
+ final long stop = System.nanoTime();
s.messageCount.incrementAndGet();
s.sumLatency.addAndGet(stop - start);
@@ -150,20 +150,20 @@ public class WakeProfiler implements Aspect {
});
ret = (T) e.create(constructor.getParameterTypes(), args);
stats.put(ret, s);
- } catch (Exception e) {
+ } catch (final Exception e) {
LOG.warning("Wake profiler could not intercept event handler: " + e.getMessage());
ret = constructor.newInstance(args);
}
} else {
ret = constructor.newInstance(args);
}
- Vertex<T> v = new Vertex<T>(ret, constructorDef, vArgs);
+ final Vertex<T> v = new Vertex<T>(ret, constructorDef, vArgs);
vertexObject.put(ret, v);
return ret;
}
@Override
- public <T> void injectionFutureInstantiated(InjectionFuture<T> arg0, T arg1) {
+ public <T> void injectionFutureInstantiated(final InjectionFuture<T> arg0, final T arg1) {
if (!futures.containsKey(arg0)) {
LOG.warning("adding future " + arg0 + " instance " + arg1);
futures.put(arg0, arg1);
@@ -171,7 +171,7 @@ public class WakeProfiler implements Aspect {
}
}
- private String jsonEscape(String s) {
+ private String jsonEscape(final String s) {
return s
.replaceAll("\\\\", "\\\\\\\\")
.replaceAll("\\\"", "\\\\\"")
@@ -184,44 +184,44 @@ public class WakeProfiler implements Aspect {
}
- private String join(String sep, List<String> tok) {
+ private String join(final String sep, final List<String> tok) {
if (tok.size() == 0) {
return "";
}
- StringBuffer sb = new StringBuffer(tok.get(0));
+ final StringBuffer sb = new StringBuffer(tok.get(0));
for (int i = 1; i < tok.size(); i++) {
sb.append(sep + tok.get(i));
}
return sb.toString();
}
- private boolean whitelist(Object o) {
+ private boolean whitelist(final Object o) {
return true;
}
public String objectGraphToString() {
- List<Vertex<?>> vertices = new ArrayList<>();
- Map<Vertex<?>, Integer> offVertex = new MonotonicHashMap<>();
+ final List<Vertex<?>> vertices = new ArrayList<>();
+ final Map<Vertex<?>, Integer> offVertex = new MonotonicHashMap<>();
- StringBuffer sb = new StringBuffer("{\"nodes\":[\n");
+ final StringBuffer sb = new StringBuffer("{\"nodes\":[\n");
- List<String> nodes = new ArrayList<String>();
- LinkedList<Vertex<?>> workQueue = new LinkedList<>();
- for (Object o : vertexObject.keySet()) {
+ final List<String> nodes = new ArrayList<String>();
+ final LinkedList<Vertex<?>> workQueue = new LinkedList<>();
+ for (final Object o : vertexObject.keySet()) {
if (whitelist(o)) {
workQueue.add(getVertex(o));
}
}
- for (Object o : futures.values()) {
+ for (final Object o : futures.values()) {
if ((!vertexObject.containsKey(o)) && whitelist(o)) {
workQueue.add(getVertex(o));
}
}
while (!workQueue.isEmpty()) {
- Vertex<?> v = workQueue.removeFirst();
+ final Vertex<?> v = workQueue.removeFirst();
LOG.warning("Work queue " + v);
- Object o = v.getObject();
+ final Object o = v.getObject();
final String s;
final String tooltip;
if (o instanceof InjectionFuture) {
@@ -240,10 +240,10 @@ public class WakeProfiler implements Aspect {
//// } else if(false && (o instanceof EventHandler || o instanceof Stage)) {
//// s = jsonEscape(v.getObject().toString());
} else {
- Stats stat = stats.get(o);
+ final Stats stat = stats.get(o);
if (stat != null) {
- long cnt = stat.messageCount.get();
- long lat = stat.sumLatency.get();
+ final long cnt = stat.messageCount.get();
+ final long lat = stat.sumLatency.get();
tooltip = ",\"count\":" + cnt + ",\"latency\":\"" + (((double) lat) / (((double) cnt) * 1000000.0) + "\"");
// quote the latency, since it might be nan
} else {
@@ -264,23 +264,23 @@ public class WakeProfiler implements Aspect {
}
sb.append(join(",\n", nodes));
sb.append("],\n\"links\":[");
- List<String> links = new ArrayList<>();
- for (Vertex<?> v : vertices) {
- for (Vertex<?> w : v.getOutEdges()) {
+ final List<String> links = new ArrayList<>();
+ for (final Vertex<?> v : vertices) {
+ for (final Vertex<?> w : v.getOutEdges()) {
LOG.fine("pointing object" + v.getObject());
LOG.fine("pointed to object " + w.getObject());
if (w.getObject() instanceof InjectionFuture) {
- Vertex<?> futureTarget = getFuture((InjectionFuture<?>) w.getObject()); //futures.get(w.getObject());
- Integer off = offVertex.get(futureTarget);
+ final Vertex<?> futureTarget = getFuture((InjectionFuture<?>) w.getObject()); //futures.get(w.getObject());
+ final Integer off = offVertex.get(futureTarget);
LOG.fine("future target " + futureTarget + " off = " + off);
if (off != null) {
links.add("{\"target\":" + offVertex.get(v) + ",\"source\":" + off + ",\"value\":" + 1.0 +
",\"back\":true}");
}
} else {
- Integer off = offVertex.get(w);
+ final Integer off = offVertex.get(w);
if (off != null) {
- Stats s = stats.get(w.getObject());
+ final Stats s = stats.get(w.getObject());
if (s != null) {
links.add("{\"source\":" + offVertex.get(v) + ",\"target\":" + off + ",\"value\":" +
(s.messageCount.get() + 3.0) + "}");
@@ -297,7 +297,7 @@ public class WakeProfiler implements Aspect {
return sb.toString();
}
- private String removeEnhancements(String simpleName) {
+ private String removeEnhancements(final String simpleName) {
return simpleName.replaceAll("\\$\\$.+$", "");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
index c4c4460..476cc75 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
@@ -32,7 +32,7 @@ final class DefaultErrorHandler implements EventHandler<Throwable> {
}
@Override
- public void onNext(Throwable value) {
+ public void onNext(final Throwable value) {
throw new RuntimeException("No error handler bound for RemoteManager.", value);
}
}
[05/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
index 0503aff..dfdebc9 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
@@ -94,7 +94,7 @@ public class TestTang {
@Test
public void testSingleton() throws InjectionException {
- Injector injector = tang.newInjector();
+ final Injector injector = tang.newInjector();
Assert.assertNotNull(injector.getInstance(TwoSingletons.class));
Assert.assertNotNull(injector.getInstance(TwoSingletons.class));
}
@@ -110,16 +110,16 @@ public class TestTang {
// TODO: Delete this? (It is handled in TestClassHierarchy!)
@Test(expected = ClassHierarchyException.class)
public void testRepeatedAmbiguousArgs() throws BindException, NameResolutionException {
- JavaConfigurationBuilder t = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder t = tang.newConfigurationBuilder();
t.getClassHierarchy().getNode(ReflectionUtilities.getFullName(RepeatedAmbiguousArgs.class));
}
@Test
public void testRepeatedOKArgs() throws BindException, InjectionException {
- JavaConfigurationBuilder t = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder t = tang.newConfigurationBuilder();
t.bindNamedParameter(RepeatedNamedArgs.A.class, "1");
t.bindNamedParameter(RepeatedNamedArgs.B.class, "2");
- Injector injector = tang.newInjector(t.build());
+ final Injector injector = tang.newInjector(t.build());
injector.getInstance(RepeatedNamedArgs.class);
}
@@ -172,7 +172,7 @@ public class TestTang {
@Test
public void testRepeatedNamedArgs() throws BindException,
InjectionException {
- Injector i = tang.newInjector();
+ final Injector i = tang.newInjector();
i.bindVolatileParameter(RepeatedNamedSingletonArgs.A.class,
i.getInstance(MustBeSingleton.class));
i.bindVolatileParameter(RepeatedNamedSingletonArgs.B.class,
@@ -183,7 +183,7 @@ public class TestTang {
@Test
public void testStraightforwardBuild() throws BindException,
InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.bind(Interf.class, Impl.class);
tang.newInjector(cb.build()).getInstance(Interf.class);
}
@@ -194,12 +194,12 @@ public class TestTang {
thrown.expect(BindException.class);
thrown.expectMessage("Attempt to re-bind named parameter org.apache.reef.tang.OneNamedStringArg$A. " +
" Old value was [not default] new value is [volatile]");
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
- OneNamedStringArg a = tang.newInjector(cb.build()).getInstance(
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final OneNamedStringArg a = tang.newInjector(cb.build()).getInstance(
OneNamedStringArg.class);
Assert.assertEquals("default", a.s);
cb.bindNamedParameter(OneNamedStringArg.A.class, "not default");
- Injector i = tang.newInjector(cb.build());
+ final Injector i = tang.newInjector(cb.build());
Assert
.assertEquals("not default", i.getInstance(OneNamedStringArg.class).s);
i.bindVolatileParameter(OneNamedStringArg.A.class, "volatile");
@@ -209,12 +209,12 @@ public class TestTang {
@Test
public void testOneNamedStringArgBind() throws BindException,
InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
- OneNamedStringArg a = tang.newInjector(cb.build()).getInstance(
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final OneNamedStringArg a = tang.newInjector(cb.build()).getInstance(
OneNamedStringArg.class);
Assert.assertEquals("default", a.s);
cb.bindNamedParameter(OneNamedStringArg.A.class, "not default");
- Injector i = tang.newInjector(cb.build());
+ final Injector i = tang.newInjector(cb.build());
Assert
.assertEquals("not default", i.getInstance(OneNamedStringArg.class).s);
}
@@ -222,10 +222,10 @@ public class TestTang {
@Test
public void testOneNamedStringArgVolatile() throws BindException,
InjectionException {
- OneNamedStringArg a = tang.newInjector().getInstance(
+ final OneNamedStringArg a = tang.newInjector().getInstance(
OneNamedStringArg.class);
Assert.assertEquals("default", a.s);
- Injector i = tang.newInjector();
+ final Injector i = tang.newInjector();
i.bindVolatileParameter(OneNamedStringArg.A.class, "volatile");
Assert.assertEquals("volatile", i.getInstance(OneNamedStringArg.class).s);
}
@@ -233,14 +233,14 @@ public class TestTang {
@Test
public void testTwoNamedStringArgsBind() throws BindException,
InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
- TwoNamedStringArgs a = tang.newInjector(cb.build()).getInstance(
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final TwoNamedStringArgs a = tang.newInjector(cb.build()).getInstance(
TwoNamedStringArgs.class);
Assert.assertEquals("defaultA", a.a);
Assert.assertEquals("defaultB", a.b);
cb.bindNamedParameter(TwoNamedStringArgs.A.class, "not defaultA");
cb.bindNamedParameter(TwoNamedStringArgs.B.class, "not defaultB");
- Injector i = tang.newInjector(cb.build());
+ final Injector i = tang.newInjector(cb.build());
Assert.assertEquals("not defaultA",
i.getInstance(TwoNamedStringArgs.class).a);
Assert.assertEquals("not defaultB",
@@ -250,8 +250,8 @@ public class TestTang {
@Test
public void testTwoNamedStringArgsBindVolatile() throws BindException,
InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
- TwoNamedStringArgs a = tang.newInjector(cb.build()).getInstance(
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final TwoNamedStringArgs a = tang.newInjector(cb.build()).getInstance(
TwoNamedStringArgs.class);
Assert.assertEquals("defaultA", a.a);
Assert.assertEquals("defaultB", a.b);
@@ -271,21 +271,21 @@ public class TestTang {
thrown.expect(BindException.class);
thrown.expectMessage("Attempt to re-bind named parameter org.apache.reef.tang.TwoNamedStringArgs$A. " +
" Old value was [not defaultA] new value is [not defaultA]");
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
- TwoNamedStringArgs a = tang.newInjector(cb.build()).getInstance(
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final TwoNamedStringArgs a = tang.newInjector(cb.build()).getInstance(
TwoNamedStringArgs.class);
Assert.assertEquals("defaultA", a.a);
Assert.assertEquals("defaultB", a.b);
cb.bindNamedParameter(TwoNamedStringArgs.A.class, "not defaultA");
cb.bindNamedParameter(TwoNamedStringArgs.B.class, "not defaultB");
- Injector i = tang.newInjector(cb.build());
+ final Injector i = tang.newInjector(cb.build());
i.bindVolatileParameter(TwoNamedStringArgs.A.class, "not defaultA");
i.bindVolatileParameter(TwoNamedStringArgs.B.class, "not defaultB");
}
@Test
public void testBextendsAinjectA() throws BindException, InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.bind(BextendsAinjectA.A.class, BextendsAinjectA.A.class);
tang.newInjector(cb.build()).getInstance(BextendsAinjectA.A.class);
}
@@ -293,13 +293,13 @@ public class TestTang {
@Test
public void testExternalConstructor() throws BindException,
InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.bindConstructor(ExternalConstructorExample.Legacy.class,
ExternalConstructorExample.LegacyWrapper.class);
- Injector i = tang.newInjector(cb.build());
+ final Injector i = tang.newInjector(cb.build());
i.bindVolatileInstance(Integer.class, 42);
i.bindVolatileInstance(String.class, "The meaning of life is ");
- ExternalConstructorExample.Legacy l = i
+ final ExternalConstructorExample.Legacy l = i
.getInstance(ExternalConstructorExample.Legacy.class);
Assert.assertEquals(new Integer(42), l.x);
Assert.assertEquals("The meaning of life is ", l.y);
@@ -308,20 +308,20 @@ public class TestTang {
@Test
public void testLegacyConstructor() throws BindException, InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.registerLegacyConstructor(
ReflectionUtilities.getFullName(LegacyConstructor.class),
ReflectionUtilities.getFullName(Integer.class),
ReflectionUtilities.getFullName(String.class));
cb.bind(LegacyConstructor.class, LegacyConstructor.class);
- String confString = ConfigurationFile.toConfigurationString(cb.build());
- JavaConfigurationBuilder cb2 = tang.newConfigurationBuilder();
+ final String confString = ConfigurationFile.toConfigurationString(cb.build());
+ final JavaConfigurationBuilder cb2 = tang.newConfigurationBuilder();
// System.err.println(confString);
ConfigurationFile.addConfiguration(cb2, confString);
- Injector i = tang.newInjector(cb2.build());
+ final Injector i = tang.newInjector(cb2.build());
i.bindVolatileInstance(Integer.class, 42);
i.bindVolatileInstance(String.class, "The meaning of life is ");
- LegacyConstructor l = i.getInstance(LegacyConstructor.class);
+ final LegacyConstructor l = i.getInstance(LegacyConstructor.class);
Assert.assertEquals(new Integer(42), l.x);
Assert.assertEquals("The meaning of life is ", l.y);
@@ -329,17 +329,17 @@ public class TestTang {
@Test
public void testNamedImpl() throws BindException, InjectionException {
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.bindNamedParameter(NamedImpl.AImplName.class, NamedImpl.Aimpl.class);
cb.bindNamedParameter(NamedImpl.BImplName.class, NamedImpl.Bimpl.class);
- Injector i = tang.newInjector(cb.build());
- NamedImpl.Aimpl a1 = (NamedImpl.Aimpl) i
+ final Injector i = tang.newInjector(cb.build());
+ final NamedImpl.Aimpl a1 = (NamedImpl.Aimpl) i
.getNamedInstance(NamedImpl.AImplName.class);
- NamedImpl.Aimpl a2 = (NamedImpl.Aimpl) i
+ final NamedImpl.Aimpl a2 = (NamedImpl.Aimpl) i
.getNamedInstance(NamedImpl.AImplName.class);
- NamedImpl.Bimpl b1 = (NamedImpl.Bimpl) i
+ final NamedImpl.Bimpl b1 = (NamedImpl.Bimpl) i
.getNamedInstance(NamedImpl.BImplName.class);
- NamedImpl.Bimpl b2 = (NamedImpl.Bimpl) i
+ final NamedImpl.Bimpl b2 = (NamedImpl.Bimpl) i
.getNamedInstance(NamedImpl.BImplName.class);
Assert.assertSame(a1, a2);
Assert.assertSame(b1, b2);
@@ -351,15 +351,15 @@ public class TestTang {
thrown.expect(BindException.class);
thrown.expectMessage("Name<org.apache.reef.tang.NamedImpl$A> " +
"org.apache.reef.tang.NamedImpl$AImplName cannot take non-subclass org.apache.reef.tang.NamedImpl$Cimpl");
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.bindNamedParameter((Class) NamedImpl.AImplName.class, (Class) NamedImpl.Cimpl.class);
}
@Test
public void testUnit() throws BindException, InjectionException {
- Injector inj = tang.newInjector();
- OuterUnit.InA a = inj.getInstance(OuterUnit.InA.class);
- OuterUnit.InB b = inj.getInstance(OuterUnit.InB.class);
+ final Injector inj = tang.newInjector();
+ final OuterUnit.InA a = inj.getInstance(OuterUnit.InA.class);
+ final OuterUnit.InB b = inj.getInstance(OuterUnit.InB.class);
Assert.assertEquals(a.slf, b.slf);
}
@@ -368,8 +368,8 @@ public class TestTang {
thrown.expect(InjectionException.class);
thrown.expectMessage("Cannot inject org.apache.reef.tang.MissOuterUnit$InA: " +
"No known implementations / injectable constructors for org.apache.reef.tang.MissOuterUnit$InA");
- Injector inj = tang.newInjector();
- MissOuterUnit.InA a = inj.getInstance(MissOuterUnit.InA.class);
+ final Injector inj = tang.newInjector();
+ final MissOuterUnit.InA a = inj.getInstance(MissOuterUnit.InA.class);
}
@Test
@@ -377,8 +377,8 @@ public class TestTang {
thrown.expect(ClassHierarchyException.class);
thrown.expectMessage("Cannot @Inject non-static member class unless the enclosing class an @Unit. " +
" Nested class is:org.apache.reef.tang.MissOuterUnit$InB");
- Injector inj = tang.newInjector();
- MissOuterUnit.InB b = inj.getInstance(MissOuterUnit.InB.class);
+ final Injector inj = tang.newInjector();
+ final MissOuterUnit.InB b = inj.getInstance(MissOuterUnit.InB.class);
}
@Test
@@ -439,10 +439,9 @@ public class TestTang {
@Test
public void testDefaultImplementation() throws BindException, ClassHierarchyException, InjectionException {
- ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- @SuppressWarnings("unused")
- IfaceWithDefault iwd = i.getNamedInstance(IfaceWithDefaultName.class);
+ final ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ @SuppressWarnings("unused") final IfaceWithDefault iwd = i.getNamedInstance(IfaceWithDefaultName.class);
}
@Test
@@ -450,10 +449,9 @@ public class TestTang {
thrown.expect(InjectionException.class);
thrown.expectMessage("getInstance() called on Name org.apache.reef.tang.IfaceWithDefaultName " +
"Did you mean to call getNamedInstance() instead?");
- ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- @SuppressWarnings("unused")
- IfaceWithDefaultName iwd = i.getInstance(IfaceWithDefaultName.class);
+ final ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ @SuppressWarnings("unused") final IfaceWithDefaultName iwd = i.getInstance(IfaceWithDefaultName.class);
}
@Test
@@ -463,7 +461,7 @@ public class TestTang {
@Test
public void testCanOverrideDefaultedInterface() throws BindException, InjectionException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindImplementation(HaveDefaultImpl.class, OverrideDefaultImpl.class);
Assert.assertTrue(Tang.Factory.getTang().newInjector(cb.build())
.getInstance(HaveDefaultImpl.class) instanceof OverrideDefaultImpl);
@@ -476,7 +474,7 @@ public class TestTang {
@Test
public void testCanOverrideStringDefaultedInterface() throws BindException, InjectionException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindImplementation(HaveDefaultStringImpl.class, OverrideDefaultStringImpl.class);
Assert.assertTrue(Tang.Factory.getTang().newInjector(cb.build())
.getInstance(HaveDefaultStringImpl.class) instanceof OverrideDefaultStringImpl);
@@ -484,23 +482,23 @@ public class TestTang {
@Test
public void testSingletonWithMultipleConstructors() throws BindException, InjectionException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindImplementation(SMC.class, SingletonMultiConst.class);
cb.bindNamedParameter(SingletonMultiConst.A.class, "foo");
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
i.getInstance(SMC.class);
}
@Test
public void testInjectInjector() throws InjectionException, BindException {
- Injector i = Tang.Factory.getTang().newInjector();
- InjectInjector ii = i.getInstance(InjectInjector.class);
+ final Injector i = Tang.Factory.getTang().newInjector();
+ final InjectInjector ii = i.getInstance(InjectInjector.class);
Assert.assertSame(i, ii.i);
}
@Test
public void testProactiveFutures() throws InjectionException, BindException {
- Injector i = Tang.Factory.getTang().newInjector();
+ final Injector i = Tang.Factory.getTang().newInjector();
IsFuture.instantiated = false;
i.getInstance(NeedsFuture.class);
Assert.assertTrue(IsFuture.instantiated);
@@ -509,24 +507,24 @@ public class TestTang {
@SuppressWarnings({"unchecked", "rawtypes"})
@Test
public void testGenericEventHandlers() throws BindException, InjectionException {
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
cba.bindNamedParameter(XName.class, (Class) XAA.class);
Tang.Factory.getTang().newInjector(cba.build()).getNamedInstance(XName.class);
- JavaConfigurationBuilder cbb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cbb = Tang.Factory.getTang().newConfigurationBuilder();
cbb.bindNamedParameter(XName.class, XBB.class);
Tang.Factory.getTang().newInjector(cbb.build()).getNamedInstance(XName.class);
- JavaConfigurationBuilder cbc = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cbc = Tang.Factory.getTang().newConfigurationBuilder();
cbc.bindNamedParameter(XName.class, (Class) XCC.class);
Tang.Factory.getTang().newInjector(cbc.build()).getNamedInstance(XName.class);
}
@Test
public void testGenericEventHandlerDefaults() throws BindException, InjectionException {
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cba.build()).getNamedInstance(XNameDA.class);
- JavaConfigurationBuilder cbb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cbb = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cbb.build()).getNamedInstance(XNameDB.class);
- JavaConfigurationBuilder cbc = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cbc = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cbc.build()).getNamedInstance(XNameDC.class);
}
@@ -536,13 +534,13 @@ public class TestTang {
thrown.expectMessage("class org.apache.reef.tang.XNameDAA defines a default class org.apache.reef.tang.XCC " +
"with a raw type that does not extend of its target's raw type class org.apache.reef.tang.XBB");
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cba.build()).getNamedInstance(XNameDAA.class);
}
@Test
public void testGenericEventHandlerDefaultsGoodTreeIndirection() throws BindException, InjectionException {
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cba.build()).getNamedInstance(XNameDDAA.class);
}
@@ -553,19 +551,19 @@ public class TestTang {
"org.apache.reef.tang.GasCan with a type that does not extend its target's type " +
"org.apache.reef.tang.Bottle<org.apache.reef.tang.Water");
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cba.build()).getNamedInstance(WaterBottleName.class);
}
@Test
public void testGenericInterfaceUnboundTypeParametersName() throws BindException, InjectionException {
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cba.build()).getNamedInstance(FooEventHandler.class);
}
@Test
public void testGenericInterfaceUnboundTypeParametersNameIface() throws BindException, InjectionException {
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cba.build()).getNamedInstance(IfaceEventHandler.class);
}
@@ -575,7 +573,7 @@ public class TestTang {
thrown.expectMessage("interface org.apache.reef.tang.MyEventHandlerIface declares its default implementation " +
"to be non-subclass class org.apache.reef.tang.MyEventHandler");
- JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cba = Tang.Factory.getTang().newConfigurationBuilder();
Tang.Factory.getTang().newInjector(cba.build()).isInjectable(MyEventHandlerIface.class);
}
@@ -586,7 +584,7 @@ public class TestTang {
@Test
public void testWantSomeHandlersBadOrder() throws BindException, InjectionException {
- Injector i = Tang.Factory.getTang().newInjector();
+ final Injector i = Tang.Factory.getTang().newInjector();
i.getInstance(AHandler.class);
i.getInstance(BHandler.class);
i.getInstance(WantSomeFutureHandlers.class);
@@ -594,7 +592,7 @@ public class TestTang {
@Test
public void testWantSomeFutureHandlersAlreadyBoundVolatile() throws BindException, InjectionException {
- Injector i = Tang.Factory.getTang().newInjector();
+ final Injector i = Tang.Factory.getTang().newInjector();
i.bindVolatileInstance(AHandler.class, new AHandlerImpl());
i.bindVolatileInstance(BHandler.class, new BHandlerImpl());
i.getInstance(WantSomeFutureHandlers.class);
@@ -618,8 +616,8 @@ public class TestTang {
@Test
public void testUnitMixedCanInject() throws BindException, InjectionException {
//testing that you should be able to have @Unit and also static inner classes not included
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
i.getInstance(OuterUnitWithStatic.InnerStaticClass2.class);
}
@@ -631,39 +629,39 @@ public class TestTang {
"implementations / injectable constructors for org.apache.reef.tang.OuterUnitWithStatic$InnerStaticClass");
//testing that you should be able to have @Unit and also static inner classes not included
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
i.getInstance(OuterUnitWithStatic.InnerStaticClass.class);
}
@Test
public void testForkWorks() throws BindException, InjectionException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bind(CheckChildIface.class, CheckChildImpl.class);
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- Injector i1 = i.forkInjector();
- CheckChildIface c1 = i1.getInstance(CheckChildIface.class);
- Injector i2 = i.forkInjector();
- CheckChildIface c2 = i2.getInstance(CheckChildIface.class);
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final Injector i1 = i.forkInjector();
+ final CheckChildIface c1 = i1.getInstance(CheckChildIface.class);
+ final Injector i2 = i.forkInjector();
+ final CheckChildIface c2 = i2.getInstance(CheckChildIface.class);
Assert.assertTrue(c1 != c2);
}
@Test
public void testReuseFailedInjector() throws BindException, InjectionException {
- Injector i = Tang.Factory.getTang().newInjector();
+ final Injector i = Tang.Factory.getTang().newInjector();
try {
i.getInstance(Fail.class);
Assert.fail("Injecting Fail should not have worked!");
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
i.getInstance(Pass.class);
}
}
@Test
public void testForksInjectorInConstructor() throws BindException, InjectionException {
- Injector i = Tang.Factory.getTang().newInjector();
+ final Injector i = Tang.Factory.getTang().newInjector();
i.getInstance(ForksInjectorInConstructor.class);
}
@@ -734,14 +732,14 @@ class IsFuture {
static boolean instantiated;
@Inject
- IsFuture(NeedsFuture nf) {
+ IsFuture(final NeedsFuture nf) {
instantiated = true;
}
}
class NeedsFuture {
@Inject
- NeedsFuture(InjectionFuture<IsFuture> isFut) {
+ NeedsFuture(final InjectionFuture<IsFuture> isFut) {
}
}
@@ -749,18 +747,18 @@ class InjectInjector {
public final Injector i;
@Inject
- InjectInjector(Injector i) {
+ InjectInjector(final Injector i) {
this.i = i;
}
}
class SingletonMultiConst implements SMC {
@Inject
- public SingletonMultiConst(@Parameter(A.class) String a) {
+ public SingletonMultiConst(@Parameter(A.class) final String a) {
}
@Inject
- public SingletonMultiConst(@Parameter(A.class) String a, @Parameter(B.class) String b) {
+ public SingletonMultiConst(@Parameter(A.class) final String a, @Parameter(B.class) final String b) {
}
@NamedParameter
@@ -802,7 +800,7 @@ class Param implements Name<Integer> {
class Impl implements Interf {
@Inject
- Impl(@Parameter(Param.class) int p) {
+ Impl(@Parameter(Param.class) final int p) {
}
}
@@ -821,26 +819,26 @@ class MustBeSingleton {
class SubSingleton {
@Inject
- SubSingleton(MustBeSingleton a) {
+ SubSingleton(final MustBeSingleton a) {
// Does not call super
}
}
class TwoSingletons {
@Inject
- TwoSingletons(SubSingleton a, MustBeSingleton b) {
+ TwoSingletons(final SubSingleton a, final MustBeSingleton b) {
}
}
class RepeatedAmbiguousArgs {
@Inject
- RepeatedAmbiguousArgs(int x, int y) {
+ RepeatedAmbiguousArgs(final int x, final int y) {
}
}
class RepeatedNamedArgs {
@Inject
- RepeatedNamedArgs(@Parameter(A.class) int x, @Parameter(B.class) int y) {
+ RepeatedNamedArgs(@Parameter(A.class) final int x, @Parameter(B.class) final int y) {
}
@NamedParameter()
@@ -854,8 +852,8 @@ class RepeatedNamedArgs {
class RepeatedNamedSingletonArgs {
@Inject
- RepeatedNamedSingletonArgs(@Parameter(A.class) MustBeSingleton a,
- @Parameter(B.class) MustBeSingleton b) {
+ RepeatedNamedSingletonArgs(@Parameter(A.class) final MustBeSingleton a,
+ @Parameter(B.class) final MustBeSingleton b) {
}
@NamedParameter()
@@ -869,7 +867,7 @@ class RepeatedNamedSingletonArgs {
class OneNamedSingletonArgs {
@Inject
- OneNamedSingletonArgs(@Parameter(A.class) MustBeSingleton a) {
+ OneNamedSingletonArgs(@Parameter(A.class) final MustBeSingleton a) {
}
@NamedParameter()
@@ -885,7 +883,7 @@ class OneNamedStringArg {
public final String s;
@Inject
- OneNamedStringArg(@Parameter(A.class) String s) {
+ OneNamedStringArg(@Parameter(A.class) final String s) {
this.s = s;
}
@@ -899,7 +897,7 @@ class TwoNamedStringArgs {
public final String b;
@Inject
- TwoNamedStringArgs(@Parameter(A.class) String a, @Parameter(B.class) String b) {
+ TwoNamedStringArgs(@Parameter(A.class) final String a, @Parameter(B.class) final String b) {
this.a = a;
this.b = b;
}
@@ -930,7 +928,7 @@ class ExternalConstructorExample {
final String y;
@Inject
- LegacyWrapper(Integer x, String y) {
+ LegacyWrapper(final Integer x, final String y) {
this.x = x;
this.y = y;
}
@@ -946,7 +944,7 @@ class ExternalConstructorExample {
final Integer x;
final String y;
- public Legacy(Integer x, String y) {
+ public Legacy(final Integer x, final String y) {
this.x = x;
this.y = y;
}
@@ -957,7 +955,7 @@ class LegacyConstructor {
final Integer x;
final String y;
- public LegacyConstructor(Integer x, String y) {
+ public LegacyConstructor(final Integer x, final String y) {
this.x = x;
this.y = y;
}
@@ -1003,7 +1001,7 @@ class NamedImpl {
static class ABtaker {
@Inject
- ABtaker(@Parameter(AImplName.class) A a, @Parameter(BImplName.class) A b) {
+ ABtaker(@Parameter(AImplName.class) final A a, @Parameter(BImplName.class) final A b) {
Assert.assertTrue("AImplName must be instance of Aimpl",
a instanceof Aimpl);
Assert.assertTrue("BImplName must be instance of Bimpl",
@@ -1060,24 +1058,24 @@ class ThreeConstructors {
final Float f;
@Inject
- ThreeConstructors(@Parameter(TCInt.class) int i, @Parameter(TCString.class) String s) {
+ ThreeConstructors(@Parameter(TCInt.class) final int i, @Parameter(TCString.class) final String s) {
this.i = i;
this.s = s;
this.f = -1.0f;
}
@Inject
- ThreeConstructors(@Parameter(TCString.class) String s) {
+ ThreeConstructors(@Parameter(TCString.class) final String s) {
this(-1, s);
}
@Inject
- ThreeConstructors(@Parameter(TCInt.class) int i) {
+ ThreeConstructors(@Parameter(TCInt.class) final int i) {
this(i, "default");
}
@Inject
- ThreeConstructors(@Parameter(TCFloat.class) float f) {
+ ThreeConstructors(@Parameter(TCFloat.class) final float f) {
this.i = -1;
this.s = "default";
this.f = f;
@@ -1102,13 +1100,13 @@ class TwoConstructors {
final String s;
@Inject
- TwoConstructors(@Parameter(TCInt.class) int i, @Parameter(TCString.class) String s) {
+ TwoConstructors(@Parameter(TCInt.class) final int i, @Parameter(TCString.class) final String s) {
this.i = i;
this.s = s;
}
@Inject
- TwoConstructors(@Parameter(TCString.class) String s, @Parameter(TCInt.class) int i) {
+ TwoConstructors(@Parameter(TCString.class) final String s, @Parameter(TCInt.class) final int i) {
this.i = i;
this.s = s;
}
@@ -1179,27 +1177,27 @@ class CC extends BB {
class XAA implements X<AA> {
@Inject
- XAA(AA aa) {
+ XAA(final AA aa) {
}
}
@DefaultImplementation(XBB.class)
class XBB implements X<BB> {
@Inject
- XBB(BB aa) {
+ XBB(final BB aa) {
}
}
class XXBB extends XBB {
@Inject
- XXBB(BB aa) {
+ XXBB(final BB aa) {
super(aa);
}
}
class XCC implements X<CC> {
@Inject
- XCC(CC aa) {
+ XCC(final CC aa) {
}
}
@@ -1286,20 +1284,20 @@ class DefaultHandlerUnit {
class WantSomeHandlers {
@Inject
- WantSomeHandlers(AHandler a, BHandler b) {
+ WantSomeHandlers(final AHandler a, final BHandler b) {
}
}
class WantSomeFutureHandlers {
@Inject
- WantSomeFutureHandlers(InjectionFuture<AHandler> a, InjectionFuture<BHandler> b) {
+ WantSomeFutureHandlers(final InjectionFuture<AHandler> a, final InjectionFuture<BHandler> b) {
}
}
class WantSomeFutureHandlersUnit {
@Inject
- WantSomeFutureHandlersUnit(InjectionFuture<DefaultHandlerUnit.AHandler> a,
- InjectionFuture<DefaultHandlerUnit.BHandler> b) {
+ WantSomeFutureHandlersUnit(final InjectionFuture<DefaultHandlerUnit.AHandler> a,
+ final InjectionFuture<DefaultHandlerUnit.BHandler> b) {
}
}
@@ -1314,8 +1312,8 @@ class BHandlerName implements Name<EventHandler<BH>> {
class WantSomeFutureHandlersName {
@Inject
WantSomeFutureHandlersName(
- @Parameter(AHandlerName.class) InjectionFuture<EventHandler<AH>> a,
- @Parameter(BHandlerName.class) InjectionFuture<EventHandler<BH>> b) {
+ @Parameter(AHandlerName.class) final InjectionFuture<EventHandler<AH>> a,
+ @Parameter(BHandlerName.class) final InjectionFuture<EventHandler<BH>> b) {
}
}
@@ -1367,8 +1365,8 @@ class CheckChildImplImpl extends CheckChildImpl {
class ForksInjectorInConstructor {
@Inject
- ForksInjectorInConstructor(Injector i) throws BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ ForksInjectorInConstructor(final Injector i) throws BindException {
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindImplementation(Number.class, Integer.class);
i.forkInjector(cb.build());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
index a378702..3c80e70 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
@@ -50,7 +50,7 @@ public class TestTweetExample {
@Test
public void test() throws Exception {
- Tweeter tw = (Tweeter) tang.newInjector(TweetConfig.CONF.set(TweetConfig.PHONE_NUMBER,
+ final Tweeter tw = (Tweeter) tang.newInjector(TweetConfig.CONF.set(TweetConfig.PHONE_NUMBER,
new Long(867 - 5309)).build()).getInstance(Tweeter.class);
tw.sendMessage();
}
@@ -80,7 +80,7 @@ public class TestTweetExample {
}
@Override
- public void sendSMS(String msg, long phoneNumber) {
+ public void sendSMS(final String msg, final long phoneNumber) {
if (phoneNumber != 867 - 5309) {
throw new IllegalArgumentException("Unknown recipient");
}
@@ -94,8 +94,8 @@ public class TestTweetExample {
private final long phoneNumber;
@Inject
- public Tweeter(TweetFactory tw, SMS sms,
- @Parameter(PhoneNumber.class) long phoneNumber) {
+ public Tweeter(final TweetFactory tw, final SMS sms,
+ @Parameter(PhoneNumber.class) final long phoneNumber) {
this.tw = tw;
this.sms = sms;
this.phoneNumber = phoneNumber;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerByteArrayRoundtripTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerByteArrayRoundtripTest.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerByteArrayRoundtripTest.java
index 496e71c..425ab10 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerByteArrayRoundtripTest.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerByteArrayRoundtripTest.java
@@ -27,14 +27,15 @@ import org.apache.reef.tang.test.RoundTripTest;
*/
public final class AvroConfigurationSerializerByteArrayRoundtripTest extends RoundTripTest {
@Override
- public Configuration roundTrip(Configuration configuration) throws Exception {
+ public Configuration roundTrip(final Configuration configuration) throws Exception {
final AvroConfigurationSerializer serializer = new AvroConfigurationSerializer();
final byte[] theBytes = serializer.toByteArray(configuration);
return serializer.fromByteArray(theBytes);
}
@Override
- public Configuration roundTrip(Configuration configuration, final ClassHierarchy classHierarchy) throws Exception {
+ public Configuration roundTrip(final Configuration configuration, final ClassHierarchy classHierarchy)
+ throws Exception {
final AvroConfigurationSerializer serializer = new AvroConfigurationSerializer();
final byte[] theBytes = serializer.toByteArray(configuration);
return serializer.fromByteArray(theBytes, classHierarchy);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerFileRoundtripTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerFileRoundtripTest.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerFileRoundtripTest.java
index 0c4d6c4..3458175 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerFileRoundtripTest.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerFileRoundtripTest.java
@@ -29,7 +29,7 @@ import java.io.File;
*/
public final class AvroConfigurationSerializerFileRoundtripTest extends RoundTripTest {
@Override
- public Configuration roundTrip(Configuration configuration) throws Exception {
+ public Configuration roundTrip(final Configuration configuration) throws Exception {
final File tempFile = java.io.File.createTempFile("TangTest", "avroconf");
final AvroConfigurationSerializer serializer = new AvroConfigurationSerializer();
serializer.toFile(configuration, tempFile);
@@ -39,7 +39,8 @@ public final class AvroConfigurationSerializerFileRoundtripTest extends RoundTri
}
@Override
- public Configuration roundTrip(Configuration configuration, final ClassHierarchy classHierarchy) throws Exception {
+ public Configuration roundTrip(final Configuration configuration, final ClassHierarchy classHierarchy)
+ throws Exception {
final File tempFile = java.io.File.createTempFile("TangTest", "avroconf");
final AvroConfigurationSerializer serializer = new AvroConfigurationSerializer();
serializer.toFile(configuration, tempFile);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerTextFileRoundtripTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerTextFileRoundtripTest.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerTextFileRoundtripTest.java
index 962c076..3d52662 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerTextFileRoundtripTest.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/AvroConfigurationSerializerTextFileRoundtripTest.java
@@ -29,7 +29,7 @@ import java.io.File;
*/
public final class AvroConfigurationSerializerTextFileRoundtripTest extends RoundTripTest {
@Override
- public Configuration roundTrip(Configuration configuration) throws Exception {
+ public Configuration roundTrip(final Configuration configuration) throws Exception {
final File tempFile = File.createTempFile("TangTest", "avroconf");
final AvroConfigurationSerializer serializer = new AvroConfigurationSerializer();
serializer.toTextFile(configuration, tempFile);
@@ -39,7 +39,8 @@ public final class AvroConfigurationSerializerTextFileRoundtripTest extends Roun
}
@Override
- public Configuration roundTrip(Configuration configuration, final ClassHierarchy classHierarchy) throws Exception {
+ public Configuration roundTrip(final Configuration configuration, final ClassHierarchy classHierarchy)
+ throws Exception {
final File tempFile = File.createTempFile("TangTest", "avroconf");
final AvroConfigurationSerializer serializer = new AvroConfigurationSerializer();
serializer.toTextFile(configuration, tempFile);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
index 3e432fd..32226a7 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
@@ -128,11 +128,11 @@ public class TestConfigurationModule {
// Here we set some configuration values. In true tang style,
// you won't be able to set them more than once ConfigurationModule's
// implementation is complete.
- Configuration c = MyConfigurationModule.CONF
+ final Configuration c = MyConfigurationModule.CONF
.set(MyConfigurationModule.THE_FOO, FooImpl.class)
.set(MyConfigurationModule.FOO_NESS, "" + 12)
.build();
- Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
+ final Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
Assert.assertEquals(f.getFooness(), 12);
}
@@ -141,11 +141,11 @@ public class TestConfigurationModule {
// Here we set some configuration values. In true tang style,
// you won't be able to set them more than once ConfigurationModule's
// implementation is complete.
- Configuration c = MyConfigurationModule.CONF
+ final Configuration c = MyConfigurationModule.CONF
.set(MyConfigurationModule.THE_FOO, FooImpl.class)
.set(MyConfigurationModule.FOO_NESS, "" + 12)
.build();
- Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
+ final Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
Assert.assertEquals(f.getFooness(), 12);
final File tempFile = File.createTempFile("TangTest", ".avroconf");
@@ -158,10 +158,10 @@ public class TestConfigurationModule {
@Test
public void omitOptionalTest() throws BindException, InjectionException {
// Optional is optional.
- Configuration c = MyConfigurationModule.CONF
+ final Configuration c = MyConfigurationModule.CONF
.set(MyConfigurationModule.THE_FOO, FooImpl.class)
.build();
- Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
+ final Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
Assert.assertEquals(f.getFooness(), 42);
}
@@ -173,7 +173,7 @@ public class TestConfigurationModule {
MyConfigurationModule.CONF
.set(MyConfigurationModule.FOO_NESS, "" + 12)
.build();
- } catch (ExceptionInInitializerError e) {
+ } catch (final ExceptionInInitializerError e) {
throw e.getCause();
}
}
@@ -185,9 +185,8 @@ public class TestConfigurationModule {
try {
// Java's classloader semantics cause it to load a class when executing the
// first line that references the class in question.
- @SuppressWarnings("unused")
- Object o = MyMissingBindConfigurationModule.BAD_CONF;
- } catch (ExceptionInInitializerError e) {
+ @SuppressWarnings("unused") final Object o = MyMissingBindConfigurationModule.BAD_CONF;
+ } catch (final ExceptionInInitializerError e) {
throw e.getCause();
}
}
@@ -210,12 +209,12 @@ public class TestConfigurationModule {
// Here we set some configuration values. In true tang style,
// you won't be able to set them more than once ConfigurationModule's
// implementation is complete.
- Configuration c = MultiBindConfigurationModule.CONF
+ final Configuration c = MultiBindConfigurationModule.CONF
.set(MultiBindConfigurationModule.THE_FOO, FooImpl.class)
.set(MultiBindConfigurationModule.FOO_NESS, "" + 12)
.build();
- Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
- Foo g = (Foo) Tang.Factory.getTang().newInjector(c).getInstance(Object.class);
+ final Foo f = Tang.Factory.getTang().newInjector(c).getInstance(Foo.class);
+ final Foo g = (Foo) Tang.Factory.getTang().newInjector(c).getInstance(Object.class);
Assert.assertEquals(f.getFooness(), 12);
Assert.assertEquals(g.getFooness(), 12);
Assert.assertFalse(f == g);
@@ -229,7 +228,7 @@ public class TestConfigurationModule {
try {
// Pass in something from the wrong module, watch it fail.
MultiBindConfigurationModule.CONF.set(MyConfigurationModule.THE_FOO, FooImpl.class);
- } catch (ExceptionInInitializerError e) {
+ } catch (final ExceptionInInitializerError e) {
throw e.getCause();
}
}
@@ -242,50 +241,50 @@ public class TestConfigurationModule {
try {
// Pass in something from the wrong module, watch it fail.
new MyConfigurationModule().bindImplementation(Object.class, MultiBindConfigurationModule.THE_FOO);
- } catch (ExceptionInInitializerError e) {
+ } catch (final ExceptionInInitializerError e) {
throw e.getCause();
}
}
@Test
public void singletonTest() throws BindException, InjectionException {
- Configuration c = new MyConfigurationModule()
+ final Configuration c = new MyConfigurationModule()
.bindImplementation(Foo.class, MyConfigurationModule.THE_FOO)
.bindNamedParameter(Fooness.class, MyConfigurationModule.FOO_NESS)
.build()
.set(MyConfigurationModule.THE_FOO, FooImpl.class)
.build();
- Injector i = Tang.Factory.getTang().newInjector(c);
+ final Injector i = Tang.Factory.getTang().newInjector(c);
Assert.assertTrue(i.getInstance(Foo.class) == i.getInstance(Foo.class));
}
@Test
public void immutablilityTest() throws BindException, InjectionException {
// builder methods return copies; the original module is immutable
- ConfigurationModule builder1 = MyConfigurationModule.CONF
+ final ConfigurationModule builder1 = MyConfigurationModule.CONF
.set(MyConfigurationModule.THE_FOO, FooImpl.class);
Assert.assertFalse(builder1 == MyConfigurationModule.CONF);
- Configuration config1 = builder1.build();
+ final Configuration config1 = builder1.build();
// reusable
- Configuration config2 = MyConfigurationModule.CONF
+ final Configuration config2 = MyConfigurationModule.CONF
.set(MyConfigurationModule.THE_FOO, FooAltImpl.class)
.build();
// instantiation of each just to be sure everything is fine in this situation
- Injector i1 = Tang.Factory.getTang().newInjector(config1);
- Injector i2 = Tang.Factory.getTang().newInjector(config2);
+ final Injector i1 = Tang.Factory.getTang().newInjector(config1);
+ final Injector i2 = Tang.Factory.getTang().newInjector(config2);
Assert.assertEquals(42, i1.getInstance(Foo.class).getFooness());
Assert.assertEquals(7, i2.getInstance(Foo.class).getFooness());
}
@Test
public void setParamTest() throws BindException, InjectionException {
- Configuration c = SetConfigurationModule.CONF
+ final Configuration c = SetConfigurationModule.CONF
.set(SetConfigurationModule.P, "a")
.set(SetConfigurationModule.P, "b")
.build();
- Set<String> s = Tang.Factory.getTang().newInjector(c).getNamedInstance(SetName.class);
+ final Set<String> s = Tang.Factory.getTang().newInjector(c).getNamedInstance(SetName.class);
Assert.assertEquals(s.size(), 2);
Assert.assertTrue(s.contains("a"));
Assert.assertTrue(s.contains("b"));
@@ -293,14 +292,14 @@ public class TestConfigurationModule {
@Test
public void setClassTest() throws BindException, InjectionException {
- Configuration c = SetClassConfigurationModule.CONF
+ final Configuration c = SetClassConfigurationModule.CONF
.set(SetClassConfigurationModule.P, SubA.class)
.set(SetClassConfigurationModule.P, SubB.class)
.build();
- Set<Super> s = Tang.Factory.getTang().newInjector(c).getNamedInstance(SetClass.class);
+ final Set<Super> s = Tang.Factory.getTang().newInjector(c).getNamedInstance(SetClass.class);
Assert.assertEquals(2, s.size());
boolean sawA = false, sawB = false;
- for (Super sup : s) {
+ for (final Super sup : s) {
if (sup instanceof SubA) {
sawA = true;
} else if (sup instanceof SubB) {
@@ -314,16 +313,16 @@ public class TestConfigurationModule {
@Test
public void setClassRoundTripTest() throws BindException, InjectionException {
- Configuration c = SetClassConfigurationModule.CONF
+ final Configuration c = SetClassConfigurationModule.CONF
.set(SetClassConfigurationModule.P, SubA.class)
.set(SetClassConfigurationModule.P, SubB.class)
.build();
- ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
ConfigurationFile.addConfiguration(cb, ConfigurationFile.toConfigurationString(c));
- Set<Super> s = Tang.Factory.getTang().newInjector(cb.build()).getNamedInstance(SetClass.class);
+ final Set<Super> s = Tang.Factory.getTang().newInjector(cb.build()).getNamedInstance(SetClass.class);
Assert.assertEquals(2, s.size());
boolean sawA = false, sawB = false;
- for (Super sup : s) {
+ for (final Super sup : s) {
if (sup instanceof SubA) {
sawA = true;
} else if (sup instanceof SubB) {
@@ -342,7 +341,7 @@ public class TestConfigurationModule {
@Test(expected = ClassHierarchyException.class)
public void errorOnSetMerge() throws BindException, InjectionException {
- ConfigurationModuleBuilder b = new ConfigurationModuleBuilder() {
+ final ConfigurationModuleBuilder b = new ConfigurationModuleBuilder() {
};
b.merge(StaticTimeSet.CONF);
}
@@ -356,7 +355,7 @@ public class TestConfigurationModule {
private final int fooness;
@Inject
- FooImpl(@Parameter(Fooness.class) int fooness) {
+ FooImpl(@Parameter(Fooness.class) final int fooness) {
this.fooness = fooness;
}
@@ -370,7 +369,7 @@ public class TestConfigurationModule {
private final int fooness;
@Inject
- FooAltImpl(@Parameter(Fooness.class) int fooness) {
+ FooAltImpl(@Parameter(Fooness.class) final int fooness) {
this.fooness = fooness;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
index ed859a5..8df60ca 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
@@ -61,7 +61,7 @@ public class TestClassHierarchy {
serializer = Tang.Factory.getTang().newInjector().getInstance(ClassHierarchySerializer.class);
}
- public String s(Class<?> c) {
+ public String s(final Class<?> c) {
return ReflectionUtilities.getFullName(c);
}
@@ -71,28 +71,28 @@ public class TestClassHierarchy {
Node n = null;
try {
n = ns.getNode("java");
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
}
Assert.assertNull(n);
try {
n = ns.getNode("java.lang");
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
}
Assert.assertNull(n);
Assert.assertNotNull(ns.getNode("java.lang.String"));
try {
ns.getNode("com.microsoft");
Assert.fail("Didn't get expected exception");
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
}
}
@Test
public void testSimpleConstructors() throws NameResolutionException {
- ClassNode<?> cls = (ClassNode<?>) ns.getNode(s(SimpleConstructors.class));
+ final ClassNode<?> cls = (ClassNode<?>) ns.getNode(s(SimpleConstructors.class));
Assert.assertTrue(cls.getChildren().size() == 0);
- ConstructorDef<?>[] def = cls.getInjectableConstructors();
+ final ConstructorDef<?>[] def = cls.getInjectableConstructors();
Assert.assertEquals(3, def.length);
}
@@ -304,23 +304,23 @@ public class TestClassHierarchy {
@Test
public void testRoundTripInnerClassNames() throws ClassNotFoundException, NameResolutionException {
- Node n = ns.getNode(s(Nested.Inner.class));
+ final Node n = ns.getNode(s(Nested.Inner.class));
Class.forName(n.getFullName());
}
@Test
public void testRoundTripAnonInnerClassNames() throws ClassNotFoundException, NameResolutionException {
- Node n = ns.getNode(s(AnonNested.x.getClass()));
- Node m = ns.getNode(s(AnonNested.y.getClass()));
+ final Node n = ns.getNode(s(AnonNested.x.getClass()));
+ final Node m = ns.getNode(s(AnonNested.y.getClass()));
Assert.assertNotSame(n.getFullName(), m.getFullName());
- Class<?> c = Class.forName(n.getFullName());
- Class<?> d = Class.forName(m.getFullName());
+ final Class<?> c = Class.forName(n.getFullName());
+ final Class<?> d = Class.forName(m.getFullName());
Assert.assertNotSame(c, d);
}
@Test
public void testUnitIsInjectable() throws InjectionException, NameResolutionException {
- ClassNode<?> n = (ClassNode<?>) ns.getNode(s(OuterUnitTH.class));
+ final ClassNode<?> n = (ClassNode<?>) ns.getNode(s(OuterUnitTH.class));
Assert.assertTrue(n.isUnit());
Assert.assertTrue(n.isInjectionCandidate());
}
@@ -394,21 +394,21 @@ class SimpleConstructors {
}
@Inject
- public SimpleConstructors(int x) {
+ public SimpleConstructors(final int x) {
}
- public SimpleConstructors(String x) {
+ public SimpleConstructors(final String x) {
}
@Inject
- public SimpleConstructors(int x, String y) {
+ public SimpleConstructors(final int x, final String y) {
}
}
class NamedParameterConstructors {
@Inject
- public NamedParameterConstructors(String x, @Parameter(X.class) String y) {
+ public NamedParameterConstructors(final String x, @Parameter(X.class) final String y) {
}
@NamedParameter()
@@ -418,7 +418,7 @@ class NamedParameterConstructors {
class RepeatConstructorArg {
@Inject
- public RepeatConstructorArg(int x, int y) {
+ public RepeatConstructorArg(final int x, final int y) {
}
}
@@ -427,7 +427,7 @@ class A {
class RepeatConstructorArgClasses {
@Inject
- public RepeatConstructorArgClasses(A x, A y) {
+ public RepeatConstructorArgClasses(final A x, final A y) {
}
}
@@ -445,7 +445,7 @@ class LeafRepeatedConstructorArgClasses {
static class C {
@Inject
- C(A.AA a, B.AA b) {
+ C(final A.AA a, final B.AA b) {
}
}
}
@@ -460,15 +460,15 @@ class BB implements Name<A> {
class NamedRepeatConstructorArgClasses {
@Inject
- public NamedRepeatConstructorArgClasses(@Parameter(AA.class) A x,
- @Parameter(BB.class) A y) {
+ public NamedRepeatConstructorArgClasses(@Parameter(AA.class) final A x,
+ @Parameter(BB.class) final A y) {
}
}
class DocumentedLocalNamedParameter {
@Inject
- public DocumentedLocalNamedParameter(@Parameter(Foo.class) String s) {
+ public DocumentedLocalNamedParameter(@Parameter(Foo.class) final String s) {
}
@NamedParameter(doc = "doc stuff", default_value = "some value")
@@ -479,7 +479,7 @@ class DocumentedLocalNamedParameter {
class NamedParameterTypeMismatch {
@Inject
- public NamedParameterTypeMismatch(@Parameter(Foo.class) String s) {
+ public NamedParameterTypeMismatch(@Parameter(Foo.class) final String s) {
}
@NamedParameter(doc = "doc.stuff", default_value = "1")
@@ -512,7 +512,7 @@ class AnnotatedNameMultipleInterfaces implements Name<Object>, I1 {
@NamedParameter()
final class NameWithConstructor implements Name<Object> {
- private NameWithConstructor(int i) {
+ private NameWithConstructor(final int i) {
}
}
@@ -577,7 +577,7 @@ class GenericTorture12 implements Name<List<List<String>>> {
class InjectNonStaticLocalArgClass {
@Inject
- InjectNonStaticLocalArgClass(NonStaticLocal x) {
+ InjectNonStaticLocalArgClass(final NonStaticLocal x) {
}
class NonStaticLocal {
@@ -587,7 +587,7 @@ class InjectNonStaticLocalArgClass {
class InjectNonStaticLocalType {
class NonStaticLocal {
@Inject
- NonStaticLocal(NonStaticLocal x) {
+ NonStaticLocal(final NonStaticLocal x) {
}
}
}
@@ -655,6 +655,6 @@ class SomeName implements Name<Integer> {
}
class NonInjectableParam {
- public NonInjectableParam(@Parameter(SomeName.class) int i) {
+ public NonInjectableParam(@Parameter(SomeName.class) final int i) {
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/TestClassHierarchyRoundTrip.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/TestClassHierarchyRoundTrip.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/TestClassHierarchyRoundTrip.java
index 3b340f1..376d066 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/TestClassHierarchyRoundTrip.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/avro/TestClassHierarchyRoundTrip.java
@@ -44,7 +44,7 @@ public class TestClassHierarchyRoundTrip extends TestClassHierarchy {
serializer.toFile(ns, file);
ns = serializer.fromFile(file);
file.delete();
- } catch (IOException e) {
+ } catch (final IOException e) {
Assert.fail(String.format("IOException when serialize/deserialize the ClassHierarchy", e));
}
}
@@ -57,7 +57,7 @@ public class TestClassHierarchyRoundTrip extends TestClassHierarchy {
serializer.toTextFile(ns, textFile);
ns = serializer.fromTextFile(textFile);
textFile.delete();
- } catch (IOException e) {
+ } catch (final IOException e) {
Assert.fail(String.format("IOException when serialize/deserialize the ClassHierarchy", e));
}
}
@@ -67,7 +67,7 @@ public class TestClassHierarchyRoundTrip extends TestClassHierarchy {
TangImpl.reset();
try {
ns = serializer.fromByteArray(serializer.toByteArray(ns));
- } catch (IOException e) {
+ } catch (final IOException e) {
Assert.fail(String.format("IOException when serialize/deserialize the ClassHierarchy", e));
}
}
@@ -77,7 +77,7 @@ public class TestClassHierarchyRoundTrip extends TestClassHierarchy {
TangImpl.reset();
try {
ns = serializer.fromString(serializer.toString(ns));
- } catch (IOException e) {
+ } catch (final IOException e) {
Assert.fail(String.format("IOException when serialize/deserialize the ClassHierarchy", e));
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java
index e644ebb..30ca285 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestConfigurationBuilder.java
@@ -50,7 +50,7 @@ public class TestConfigurationBuilder {
private final String str;
@Inject
- NamedParamterNoDefault(@Parameter(NamedString.class) String str) {
+ NamedParamterNoDefault(@Parameter(NamedString.class) final String str) {
this.str = str;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
index a521f47..5c97ab4 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
@@ -42,9 +42,9 @@ public class TestParameterParser {
@Test
public void testParameterParser() throws BindException {
- ParameterParser p = new ParameterParser();
+ final ParameterParser p = new ParameterParser();
p.addParser(FooParser.class);
- Foo f = p.parse(Foo.class, "woot");
+ final Foo f = p.parse(Foo.class, "woot");
Assert.assertEquals(f.s, "woot");
}
@@ -52,35 +52,35 @@ public class TestParameterParser {
public void testUnregisteredParameterParser() throws BindException {
thrown.expect(UnsupportedOperationException.class);
thrown.expectMessage("Don't know how to parse a org.apache.reef.tang.implementation.java.TestParameterParser$Foo");
- ParameterParser p = new ParameterParser();
+ final ParameterParser p = new ParameterParser();
//p.addParser(FooParser.class);
- Foo f = p.parse(Foo.class, "woot");
+ final Foo f = p.parse(Foo.class, "woot");
Assert.assertEquals(f.s, "woot");
}
@Test
public void testReturnSubclass() throws BindException {
- ParameterParser p = new ParameterParser();
+ final ParameterParser p = new ParameterParser();
p.addParser(BarParser.class);
- Bar f = (Bar) p.parse(Foo.class, "woot");
+ final Bar f = (Bar) p.parse(Foo.class, "woot");
Assert.assertEquals(f.s, "woot");
}
@Test
public void testGoodMerge() throws BindException {
- ParameterParser old = new ParameterParser();
+ final ParameterParser old = new ParameterParser();
old.addParser(BarParser.class);
- ParameterParser nw = new ParameterParser();
+ final ParameterParser nw = new ParameterParser();
nw.mergeIn(old);
nw.parse(Foo.class, "woot");
}
@Test
public void testGoodMerge2() throws BindException {
- ParameterParser old = new ParameterParser();
+ final ParameterParser old = new ParameterParser();
old.addParser(BarParser.class);
- ParameterParser nw = new ParameterParser();
+ final ParameterParser nw = new ParameterParser();
nw.addParser(BarParser.class);
nw.mergeIn(old);
nw.parse(Foo.class, "woot");
@@ -93,9 +93,9 @@ public class TestParameterParser {
"org.apache.reef.tang.implementation.java.TestParameterParser$Foo I have a: " +
"org.apache.reef.tang.implementation.java.TestParameterParser$FooParser the other instance has a: " +
"org.apache.reef.tang.implementation.java.TestParameterParser$BarParser");
- ParameterParser old = new ParameterParser();
+ final ParameterParser old = new ParameterParser();
old.addParser(BarParser.class);
- ParameterParser nw = new ParameterParser();
+ final ParameterParser nw = new ParameterParser();
nw.addParser(FooParser.class);
nw.mergeIn(old);
}
@@ -103,24 +103,24 @@ public class TestParameterParser {
@SuppressWarnings("unchecked")
@Test
public void testEndToEnd() throws BindException, InjectionException {
- Tang tang = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder(BarParser.class);
+ final Tang tang = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder(BarParser.class);
cb.bindNamedParameter(SomeNamedFoo.class, "hdfs://woot");
- ILikeBars ilb = tang.newInjector(cb.build()).getInstance(ILikeBars.class);
+ final ILikeBars ilb = tang.newInjector(cb.build()).getInstance(ILikeBars.class);
Assert.assertNotNull(ilb);
}
@SuppressWarnings("unchecked")
@Test
public void testDelegatingParser() throws BindException, InjectionException, ClassNotFoundException {
- Tang tang = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder(TypeParser.class);
+ final Tang tang = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder(TypeParser.class);
JavaConfigurationBuilder cb2 = tang.newConfigurationBuilder(cb.build());
cb2.bind(ReflectionUtilities.getFullName(ParseName.class), "a");
- ParseableType t = tang.newInjector(cb2.build()).getNamedInstance(ParseName.class);
+ final ParseableType t = tang.newInjector(cb2.build()).getNamedInstance(ParseName.class);
Assert.assertTrue(t instanceof ParseTypeA);
cb2 = tang.newConfigurationBuilder(cb.build());
@@ -136,7 +136,7 @@ public class TestParameterParser {
private final Foo foo;
@Inject
- public FooParser(String s) {
+ public FooParser(final String s) {
this.foo = new Foo(s);
}
@@ -150,7 +150,7 @@ public class TestParameterParser {
private final Bar bar;
@Inject
- public BarParser(String s) {
+ public BarParser(final String s) {
this.bar = new Bar(s);
}
@@ -163,13 +163,13 @@ public class TestParameterParser {
private static class Foo {
public final String s;
- public Foo(String s) {
+ public Foo(final String s) {
this.s = s;
}
}
private static class Bar extends Foo {
- public Bar(String s) {
+ public Bar(final String s) {
super(s);
}
}
@@ -180,8 +180,8 @@ public class TestParameterParser {
private static class ILikeBars {
@Inject
- ILikeBars(@Parameter(SomeNamedFoo.class) Foo bar) {
- Bar b = (Bar) bar;
+ ILikeBars(@Parameter(SomeNamedFoo.class) final Foo bar) {
+ final Bar b = (Bar) bar;
Assert.assertEquals(b.s, "hdfs://woot");
}
}
@@ -201,7 +201,7 @@ public class TestParameterParser {
ParseableType instance;
@Inject
- public TypeParser(String s) {
+ public TypeParser(final String s) {
if (s.equals("a")) {
instance = new ParseTypeA();
}
@@ -234,14 +234,14 @@ public class TestParameterParser {
private static class NeedsA {
@Inject
- public NeedsA(@Parameter(ParseNameA.class) ParseableType a) {
+ public NeedsA(@Parameter(ParseNameA.class) final ParseableType a) {
Assert.assertTrue(a instanceof ParseTypeA);
}
}
private static class NeedsB {
@Inject
- public NeedsB(@Parameter(ParseNameB.class) ParseTypeB b) {
+ public NeedsB(@Parameter(ParseNameB.class) final ParseTypeB b) {
Assert.assertTrue(b instanceof ParseTypeB);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/AnInterfaceImplementation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/AnInterfaceImplementation.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/AnInterfaceImplementation.java
index 18b6e86..d3f83b4 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/AnInterfaceImplementation.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/AnInterfaceImplementation.java
@@ -34,7 +34,7 @@ final class AnInterfaceImplementation implements AnInterface {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -42,7 +42,7 @@ final class AnInterfaceImplementation implements AnInterface {
return false;
}
- AnInterfaceImplementation that = (AnInterfaceImplementation) o;
+ final AnInterfaceImplementation that = (AnInterfaceImplementation) o;
if (aMagicNumber != that.aMagicNumber) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependency.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependency.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependency.java
index 4e2789a..a19c7e3 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependency.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependency.java
@@ -35,7 +35,7 @@ final class CyclicDependency {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -43,7 +43,7 @@ final class CyclicDependency {
return false;
}
- CyclicDependency that = (CyclicDependency) o;
+ final CyclicDependency that = (CyclicDependency) o;
if (!one.equals(that.one)) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassOne.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassOne.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassOne.java
index 1c56a6e..370efde 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassOne.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassOne.java
@@ -32,7 +32,7 @@ final class CyclicDependencyClassOne {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -40,7 +40,7 @@ final class CyclicDependencyClassOne {
return false;
}
- CyclicDependencyClassOne that = (CyclicDependencyClassOne) o;
+ final CyclicDependencyClassOne that = (CyclicDependencyClassOne) o;
if (!other.equals(that.other)) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassTwo.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassTwo.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassTwo.java
index 8823f97..b7f6e5f 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassTwo.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/CyclicDependencyClassTwo.java
@@ -29,12 +29,12 @@ final class CyclicDependencyClassTwo {
private final InjectionFuture<CyclicDependencyClassOne> other;
@Inject
- CyclicDependencyClassTwo(InjectionFuture<CyclicDependencyClassOne> other) {
+ CyclicDependencyClassTwo(final InjectionFuture<CyclicDependencyClassOne> other) {
this.other = other;
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/InjectableClass.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/InjectableClass.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/InjectableClass.java
index c0e9392..d4f863f 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/InjectableClass.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/InjectableClass.java
@@ -29,7 +29,7 @@ final class InjectableClass {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -37,7 +37,7 @@ final class InjectableClass {
return false;
}
- InjectableClass that = (InjectableClass) o;
+ final InjectableClass that = (InjectableClass) o;
if (magicNumber != that.magicNumber) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplOne.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplOne.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplOne.java
index e494aef..5a71538 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplOne.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplOne.java
@@ -34,13 +34,13 @@ public class ListInterfaceImplOne implements ListInterface {
}
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (this == obj) {
return true;
} else if (obj == null || obj.getClass() != getClass()) {
return false;
} else {
- ListInterfaceImplOne one = (ListInterfaceImplOne) obj;
+ final ListInterfaceImplOne one = (ListInterfaceImplOne) obj;
if (one.magicNumber != magicNumber) {
return false;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplTwo.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplTwo.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplTwo.java
index 0024c1b..2781a4c 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplTwo.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListInterfaceImplTwo.java
@@ -33,13 +33,13 @@ public class ListInterfaceImplTwo implements ListInterface {
}
@Override
- public boolean equals(Object obj) {
+ public boolean equals(final Object obj) {
if (this == obj) {
return true;
} else if (obj == null || obj.getClass() != getClass()) {
return false;
} else {
- ListInterfaceImplTwo two = (ListInterfaceImplTwo) obj;
+ final ListInterfaceImplTwo two = (ListInterfaceImplTwo) obj;
if (Double.compare(two.magicNumber, magicNumber) != 0) {
return false;
}
@@ -49,7 +49,7 @@ public class ListInterfaceImplTwo implements ListInterface {
@Override
public int hashCode() {
- long temp = Double.doubleToLongBits(magicNumber);
+ final long temp = Double.doubleToLongBits(magicNumber);
return (int) (temp ^ (temp >>> 32));
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfBaseTypes.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfBaseTypes.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfBaseTypes.java
index b93ead5..dedc3d9 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfBaseTypes.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfBaseTypes.java
@@ -43,7 +43,7 @@ final class ListOfBaseTypes {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -51,7 +51,7 @@ final class ListOfBaseTypes {
return false;
}
- ListOfBaseTypes that = (ListOfBaseTypes) o;
+ final ListOfBaseTypes that = (ListOfBaseTypes) o;
if (!doubles.equals(that.doubles)) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfImplementations.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfImplementations.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfImplementations.java
index fb8e826..651f12f 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfImplementations.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/ListOfImplementations.java
@@ -33,7 +33,7 @@ public class ListOfImplementations {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -41,7 +41,7 @@ public class ListOfImplementations {
return false;
}
- ListOfImplementations that = (ListOfImplementations) o;
+ final ListOfImplementations that = (ListOfImplementations) o;
if (!theInstances.equals(that.theInstances)) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
index efd4c07..72d14ba 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
@@ -49,7 +49,7 @@ final class RootImplementation implements RootInterface {
@Parameter(TestConfiguration.StringHandler.class) final Handler<String> stringHandler,
@Parameter(TestConfiguration.IntegerHandler.class) final Handler<Integer> integerHandler,
@Parameter(TestConfiguration.NamedParameterInteger.class) final int anInt,
- @Parameter(TestConfiguration.NamedParameterDouble.class) double aDouble,
+ @Parameter(TestConfiguration.NamedParameterDouble.class) final double aDouble,
final UnitClass unit,
final AnInterface anInterface,
final InjectableClass injectableClass,
@@ -57,7 +57,7 @@ final class RootImplementation implements RootInterface {
final SetOfBaseTypes setOfBaseTypes,
final ListOfImplementations listOfImplementations,
final ListOfBaseTypes listOfBaseTypes,
- CyclicDependency cyclicDependency) {
+ final CyclicDependency cyclicDependency) {
this.requiredString = requiredString;
this.optionalString = optionalString;
this.unit = unit;
@@ -114,7 +114,7 @@ final class RootImplementation implements RootInterface {
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -122,7 +122,7 @@ final class RootImplementation implements RootInterface {
return false;
}
- RootImplementation that = (RootImplementation) o;
+ final RootImplementation that = (RootImplementation) o;
if (Double.compare(that.aDouble, aDouble) != 0) {
return false;
@@ -175,7 +175,7 @@ final class RootImplementation implements RootInterface {
@Override
public int hashCode() {
int result;
- long temp;
+ final long temp;
result = requiredString != null ? requiredString.hashCode() : 0;
result = 31 * result + (optionalString != null ? optionalString.hashCode() : 0);
result = 31 * result + (unit != null ? unit.hashCode() : 0);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementationWithoutList.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementationWithoutList.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementationWithoutList.java
index cc2a474..1f38947 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementationWithoutList.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementationWithoutList.java
@@ -49,13 +49,13 @@ public class RootImplementationWithoutList implements RootInterface {
@Parameter(TestConfigurationWithoutList.StringHandler.class) final Handler<String> stringHandler,
@Parameter(TestConfigurationWithoutList.IntegerHandler.class) final Handler<Integer> integerHandler,
@Parameter(TestConfigurationWithoutList.NamedParameterInteger.class) final int anInt,
- @Parameter(TestConfigurationWithoutList.NamedParameterDouble.class) double aDouble,
+ @Parameter(TestConfigurationWithoutList.NamedParameterDouble.class) final double aDouble,
final UnitClass unit,
final AnInterface anInterface,
final InjectableClass injectableClass,
final SetOfImplementations setOfImplementations,
final SetOfBaseTypes setOfBaseTypes,
- CyclicDependency cyclicDependency) {
+ final CyclicDependency cyclicDependency) {
this.requiredString = requiredString;
this.optionalString = optionalString;
@@ -108,7 +108,7 @@ public class RootImplementationWithoutList implements RootInterface {
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -116,7 +116,7 @@ public class RootImplementationWithoutList implements RootInterface {
return false;
}
- RootImplementationWithoutList that = (RootImplementationWithoutList) o;
+ final RootImplementationWithoutList that = (RootImplementationWithoutList) o;
if (Double.compare(that.aDouble, aDouble) != 0) {
return false;
@@ -162,7 +162,7 @@ public class RootImplementationWithoutList implements RootInterface {
@Override
public int hashCode() {
int result;
- long temp;
+ final long temp;
result = requiredString != null ? requiredString.hashCode() : 0;
result = 31 * result + (optionalString != null ? optionalString.hashCode() : 0);
result = 31 * result + (unit != null ? unit.hashCode() : 0);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
index 8bef85c..067b50d 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
@@ -38,7 +38,7 @@ final class SetInterfaceImplOne implements SetInterface {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -46,7 +46,7 @@ final class SetInterfaceImplOne implements SetInterface {
return false;
}
- SetInterfaceImplOne that = (SetInterfaceImplOne) o;
+ final SetInterfaceImplOne that = (SetInterfaceImplOne) o;
if (magicNumber != that.magicNumber) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplTwo.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplTwo.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplTwo.java
index fb0c14e..2174a50 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplTwo.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplTwo.java
@@ -35,7 +35,7 @@ final class SetInterfaceImplTwo implements SetInterface {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -43,7 +43,7 @@ final class SetInterfaceImplTwo implements SetInterface {
return false;
}
- SetInterfaceImplTwo that = (SetInterfaceImplTwo) o;
+ final SetInterfaceImplTwo that = (SetInterfaceImplTwo) o;
if (Double.compare(that.magicNumber, magicNumber) != 0) {
return false;
@@ -54,7 +54,7 @@ final class SetInterfaceImplTwo implements SetInterface {
@Override
public int hashCode() {
- long temp = Double.doubleToLongBits(magicNumber);
+ final long temp = Double.doubleToLongBits(magicNumber);
return (int) (temp ^ (temp >>> 32));
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfBaseTypes.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfBaseTypes.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfBaseTypes.java
index fa405c0..5b3c93e 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfBaseTypes.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfBaseTypes.java
@@ -46,7 +46,7 @@ final class SetOfBaseTypes {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -54,7 +54,7 @@ final class SetOfBaseTypes {
return false;
}
- SetOfBaseTypes that = (SetOfBaseTypes) o;
+ final SetOfBaseTypes that = (SetOfBaseTypes) o;
if (!doubles.equals(that.doubles)) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfImplementations.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfImplementations.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfImplementations.java
index 75b067f..034d1e3 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfImplementations.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetOfImplementations.java
@@ -33,7 +33,7 @@ final class SetOfImplementations {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -41,7 +41,7 @@ final class SetOfImplementations {
return false;
}
- SetOfImplementations that = (SetOfImplementations) o;
+ final SetOfImplementations that = (SetOfImplementations) o;
if (!theInstances.equals(that.theInstances)) {
return false;
[08/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ParameterParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ParameterParser.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ParameterParser.java
index 32555c4..3d0f28b 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ParameterParser.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ParameterParser.java
@@ -50,19 +50,19 @@ public class ParameterParser {
MonotonicTreeMap<String, Constructor<? extends ExternalConstructor<?>>> parsers = new MonotonicTreeMap<>();
@SuppressWarnings({"unchecked", "rawtypes"})
- public void addParser(Class<? extends ExternalConstructor<?>> ec) throws BindException {
- Class<?> tc = (Class<?>) ReflectionUtilities.getInterfaceTarget(
+ public void addParser(final Class<? extends ExternalConstructor<?>> ec) throws BindException {
+ final Class<?> tc = (Class<?>) ReflectionUtilities.getInterfaceTarget(
ExternalConstructor.class, ec);
addParser((Class) tc, (Class) ec);
}
- public <T, U extends T> void addParser(Class<U> clazz, Class<? extends ExternalConstructor<T>> ec)
+ public <T, U extends T> void addParser(final Class<U> clazz, final Class<? extends ExternalConstructor<T>> ec)
throws BindException {
- Constructor<? extends ExternalConstructor<T>> c;
+ final Constructor<? extends ExternalConstructor<T>> c;
try {
c = ec.getDeclaredConstructor(String.class);
c.setAccessible(true);
- } catch (NoSuchMethodException e) {
+ } catch (final NoSuchMethodException e) {
throw new BindException("Constructor "
+ ReflectionUtilities.getFullName(ec) + "(String) does not exist!", e);
}
@@ -70,8 +70,8 @@ public class ParameterParser {
parsers.put(ReflectionUtilities.getFullName(clazz), c);
}
- public void mergeIn(ParameterParser p) {
- for (String s : p.parsers.keySet()) {
+ public void mergeIn(final ParameterParser p) {
+ for (final String s : p.parsers.keySet()) {
if (!parsers.containsKey(s)) {
parsers.put(s, p.parsers.get(s));
} else {
@@ -86,12 +86,12 @@ public class ParameterParser {
}
}
- public <T> T parse(Class<T> c, String s) {
- Class<?> d = ReflectionUtilities.boxClass(c);
- for (Type e : ReflectionUtilities.classAndAncestors(d)) {
- String name = ReflectionUtilities.getFullName(e);
+ public <T> T parse(final Class<T> c, final String s) {
+ final Class<?> d = ReflectionUtilities.boxClass(c);
+ for (final Type e : ReflectionUtilities.classAndAncestors(d)) {
+ final String name = ReflectionUtilities.getFullName(e);
if (parsers.containsKey(name)) {
- T ret = parse(name, s);
+ final T ret = parse(name, s);
if (c.isAssignableFrom(ret.getClass())) {
return ret;
} else {
@@ -103,11 +103,11 @@ public class ParameterParser {
}
@SuppressWarnings("unchecked")
- public <T> T parse(String name, String value) {
+ public <T> T parse(final String name, final String value) {
if (parsers.containsKey(name)) {
try {
return (T) (parsers.get(name).newInstance(value).newInstance());
- } catch (ReflectiveOperationException e) {
+ } catch (final ReflectiveOperationException e) {
throw new IllegalArgumentException("Error invoking constructor for "
+ name, e);
}
@@ -146,7 +146,7 @@ public class ParameterParser {
}
}
- public boolean canParse(String name) {
+ public boolean canParse(final String name) {
return parsers.containsKey(name) || BUILTIN_NAMES.contains(name);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java
index e080748..ce70b37 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java
@@ -54,47 +54,47 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
this.namespace = Tang.Factory.getTang().getDefaultClassHierarchy();
}
- protected ConfigurationBuilderImpl(ClassHierarchy namespace) {
+ protected ConfigurationBuilderImpl(final ClassHierarchy namespace) {
this.namespace = namespace;
}
- protected ConfigurationBuilderImpl(URL[] jars,
- Configuration[] confs,
- Class<? extends ExternalConstructor<?>>[] parsers)
+ protected ConfigurationBuilderImpl(final URL[] jars,
+ final Configuration[] confs,
+ final Class<? extends ExternalConstructor<?>>[] parsers)
throws BindException {
this.namespace = Tang.Factory.getTang().getDefaultClassHierarchy(jars, parsers);
- for (Configuration tc : confs) {
+ for (final Configuration tc : confs) {
addConfiguration(((ConfigurationImpl) tc));
}
}
- protected ConfigurationBuilderImpl(ConfigurationBuilderImpl t) {
+ protected ConfigurationBuilderImpl(final ConfigurationBuilderImpl t) {
this.namespace = t.getClassHierarchy();
try {
addConfiguration(t.getClassHierarchy(), t);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException("Could not copy builder", e);
}
}
@SuppressWarnings("unchecked")
- protected ConfigurationBuilderImpl(URL... jars) throws BindException {
+ protected ConfigurationBuilderImpl(final URL... jars) throws BindException {
this(jars, new Configuration[0], new Class[0]);
}
@SuppressWarnings("unchecked")
- protected ConfigurationBuilderImpl(Configuration... confs) throws BindException {
+ protected ConfigurationBuilderImpl(final Configuration... confs) throws BindException {
this(new URL[0], confs, new Class[0]);
}
@Override
- public void addConfiguration(Configuration conf) throws BindException {
+ public void addConfiguration(final Configuration conf) throws BindException {
// XXX remove cast!
addConfiguration(conf.getClassHierarchy(), ((ConfigurationImpl) conf).builder);
}
@SuppressWarnings("unchecked")
- private <T> void addConfiguration(ClassHierarchy ns, ConfigurationBuilderImpl builder)
+ private <T> void addConfiguration(final ClassHierarchy ns, final ConfigurationBuilderImpl builder)
throws BindException {
namespace = namespace.merge(ns);
if ((namespace instanceof ClassHierarchyImpl || builder.namespace instanceof ClassHierarchyImpl)) {
@@ -106,24 +106,24 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
}
- for (ClassNode<?> cn : builder.boundImpls.keySet()) {
+ for (final ClassNode<?> cn : builder.boundImpls.keySet()) {
bind(cn.getFullName(), builder.boundImpls.get(cn).getFullName());
}
- for (ClassNode<?> cn : builder.boundConstructors.keySet()) {
+ for (final ClassNode<?> cn : builder.boundConstructors.keySet()) {
bind(cn.getFullName(), builder.boundConstructors.get(cn).getFullName());
}
// The namedParameters set contains the strings that can be used to
// instantiate new
// named parameter instances. Create new ones where we can.
- for (NamedParameterNode<?> np : builder.namedParameters.keySet()) {
+ for (final NamedParameterNode<?> np : builder.namedParameters.keySet()) {
bind(np.getFullName(), builder.namedParameters.get(np));
}
- for (ClassNode<?> cn : builder.legacyConstructors.keySet()) {
+ for (final ClassNode<?> cn : builder.legacyConstructors.keySet()) {
registerLegacyConstructor(cn, builder.legacyConstructors.get(cn)
.getArgs());
}
- for (Entry<NamedParameterNode<Set<?>>, Object> e : builder.boundSetEntries) {
- String name = ((NamedParameterNode<Set<T>>) (NamedParameterNode<?>) e.getKey()).getFullName();
+ for (final Entry<NamedParameterNode<Set<?>>, Object> e : builder.boundSetEntries) {
+ final String name = ((NamedParameterNode<Set<T>>) (NamedParameterNode<?>) e.getKey()).getFullName();
if (e.getValue() instanceof Node) {
bindSetEntry(name, (Node) e.getValue());
} else if (e.getValue() instanceof String) {
@@ -133,7 +133,7 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
}
// The boundLists set contains bound lists with their target NamedParameters
- for (NamedParameterNode<List<?>> np : builder.boundLists.keySet()) {
+ for (final NamedParameterNode<List<?>> np : builder.boundLists.keySet()) {
bindList(np.getFullName(), builder.boundLists.get(np));
}
}
@@ -144,9 +144,9 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@Override
- public void registerLegacyConstructor(ClassNode<?> c,
+ public void registerLegacyConstructor(final ClassNode<?> c,
final ConstructorArg... args) throws BindException {
- String[] cn = new String[args.length];
+ final String[] cn = new String[args.length];
for (int i = 0; i < args.length; i++) {
cn[i] = args[i].getType();
}
@@ -154,10 +154,10 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@Override
- public void registerLegacyConstructor(String s, final String... args)
+ public void registerLegacyConstructor(final String s, final String... args)
throws BindException {
- ClassNode<?> cn = (ClassNode<?>) namespace.getNode(s);
- ClassNode<?>[] cnArgs = new ClassNode[args.length];
+ final ClassNode<?> cn = (ClassNode<?>) namespace.getNode(s);
+ final ClassNode<?>[] cnArgs = new ClassNode[args.length];
for (int i = 0; i < args.length; i++) {
cnArgs[i] = (ClassNode<?>) namespace.getNode(args[i]);
}
@@ -165,18 +165,18 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@Override
- public void registerLegacyConstructor(ClassNode<?> cn,
+ public void registerLegacyConstructor(final ClassNode<?> cn,
final ClassNode<?>... args) throws BindException {
legacyConstructors.put(cn, cn.getConstructorDef(args));
}
@Override
- public <T> void bind(String key, String value) throws BindException {
- Node n = namespace.getNode(key);
+ public <T> void bind(final String key, final String value) throws BindException {
+ final Node n = namespace.getNode(key);
if (n instanceof NamedParameterNode) {
bindParameter((NamedParameterNode<?>) n, value);
} else if (n instanceof ClassNode) {
- Node m = namespace.getNode(value);
+ final Node m = namespace.getNode(value);
bind((ClassNode<?>) n, (ClassNode<?>) m);
} else {
throw new IllegalStateException("getNode() returned " + n +
@@ -185,13 +185,13 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@SuppressWarnings({"unchecked", "rawtypes"})
- public void bind(Node key, Node value) throws BindException {
+ public void bind(final Node key, final Node value) throws BindException {
if (key instanceof NamedParameterNode) {
bindParameter((NamedParameterNode<?>) key, value.getFullName());
} else if (key instanceof ClassNode) {
- ClassNode<?> k = (ClassNode<?>) key;
+ final ClassNode<?> k = (ClassNode<?>) key;
if (value instanceof ClassNode) {
- ClassNode<?> val = (ClassNode<?>) value;
+ final ClassNode<?> val = (ClassNode<?>) value;
if (val.isExternalConstructor() && !k.isExternalConstructor()) {
bindConstructor(k, (ClassNode) val);
} else {
@@ -201,7 +201,7 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
}
- public <T> void bindImplementation(ClassNode<T> n, ClassNode<? extends T> m)
+ public <T> void bindImplementation(final ClassNode<T> n, final ClassNode<? extends T> m)
throws BindException {
if (namespace.isImplementation(n, m)) {
boundImpls.put(n, m);
@@ -211,7 +211,7 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@SuppressWarnings({"unchecked", "rawtypes"})
- public <T> void bindParameter(NamedParameterNode<T> name, String value)
+ public <T> void bindParameter(final NamedParameterNode<T> name, final String value)
throws BindException {
/* Parse and discard value; this is just for type checking */
if (namespace instanceof JavaClassHierarchy) {
@@ -226,27 +226,27 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
@SuppressWarnings("unchecked")
@Override
- public void bindSetEntry(String iface, String impl)
+ public void bindSetEntry(final String iface, final String impl)
throws BindException {
boundSetEntries.put((NamedParameterNode<Set<?>>) namespace.getNode(iface), impl);
}
@SuppressWarnings("unchecked")
@Override
- public void bindSetEntry(String iface, Node impl)
+ public void bindSetEntry(final String iface, final Node impl)
throws BindException {
boundSetEntries.put((NamedParameterNode<Set<?>>) namespace.getNode(iface), impl);
}
@SuppressWarnings("unchecked")
@Override
- public <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, String impl)
+ public <T> void bindSetEntry(final NamedParameterNode<Set<T>> iface, final String impl)
throws BindException {
if (namespace instanceof ClassHierarchyImpl) {
- JavaClassHierarchy javanamespace = (ClassHierarchyImpl) namespace;
+ final JavaClassHierarchy javanamespace = (ClassHierarchyImpl) namespace;
try {
javanamespace.parse(iface, impl);
- } catch (ParseException e) {
+ } catch (final ParseException e) {
throw new IllegalStateException("Could not parse " + impl + " which was passed to " + iface);
}
}
@@ -255,22 +255,22 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
@SuppressWarnings("unchecked")
@Override
- public <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, Node impl)
+ public <T> void bindSetEntry(final NamedParameterNode<Set<T>> iface, final Node impl)
throws BindException {
boundSetEntries.put((NamedParameterNode<Set<?>>) (NamedParameterNode<?>) iface, impl);
}
@SuppressWarnings("unchecked")
@Override
- public <T> void bindList(NamedParameterNode<List<T>> iface, List implList) {
+ public <T> void bindList(final NamedParameterNode<List<T>> iface, final List implList) {
// Check parsability of list items
- for (Object item : implList) {
+ for (final Object item : implList) {
if (item instanceof String) {
- JavaClassHierarchy javanamespace = (ClassHierarchyImpl) namespace;
+ final JavaClassHierarchy javanamespace = (ClassHierarchyImpl) namespace;
try {
// Just for parsability checking.
javanamespace.parse(iface, (String) item);
- } catch (ParseException e) {
+ } catch (final ParseException e) {
throw new IllegalStateException("Could not parse " + item + " which was passed to " + iface);
}
}
@@ -280,16 +280,16 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
@SuppressWarnings("unchecked")
@Override
- public void bindList(String iface, List implList) {
- NamedParameterNode<List<?>> ifaceNode = (NamedParameterNode<List<?>>) namespace.getNode(iface);
+ public void bindList(final String iface, final List implList) {
+ final NamedParameterNode<List<?>> ifaceNode = (NamedParameterNode<List<?>>) namespace.getNode(iface);
// Check parsability of list items
- for (Object item : implList) {
+ for (final Object item : implList) {
if (item instanceof String) {
- JavaClassHierarchy javanamespace = (ClassHierarchyImpl) namespace;
+ final JavaClassHierarchy javanamespace = (ClassHierarchyImpl) namespace;
try {
// Just for parsability checking.
javanamespace.parse(ifaceNode, (String) item);
- } catch (ParseException e) {
+ } catch (final ParseException e) {
throw new IllegalStateException("Could not parse " + item + " which was passed to " + iface);
}
}
@@ -298,8 +298,8 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@Override
- public <T> void bindConstructor(ClassNode<T> k,
- ClassNode<? extends ExternalConstructor<? extends T>> v) {
+ public <T> void bindConstructor(final ClassNode<T> k,
+ final ClassNode<? extends ExternalConstructor<? extends T>> v) {
boundConstructors.put(k, v);
}
@@ -309,17 +309,17 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@Override
- public String classPrettyDefaultString(String longName) throws NameResolutionException {
+ public String classPrettyDefaultString(final String longName) throws NameResolutionException {
final NamedParameterNode<?> param = (NamedParameterNode<?>) namespace
.getNode(longName);
return param.getSimpleArgName() + "=" + join(",", param.getDefaultInstanceAsStrings());
}
- private String join(String sep, String[] s) {
+ private String join(final String sep, final String[] s) {
if (s.length == 0) {
return null;
} else {
- StringBuilder sb = new StringBuilder(s[0]);
+ final StringBuilder sb = new StringBuilder(s[0]);
for (int i = 1; i < s.length; i++) {
sb.append(sep);
sb.append(s[i]);
@@ -329,7 +329,7 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
}
@Override
- public String classPrettyDescriptionString(String fullName)
+ public String classPrettyDescriptionString(final String fullName)
throws NameResolutionException {
final NamedParameterNode<?> param = (NamedParameterNode<?>) namespace
.getNode(fullName);
@@ -345,7 +345,7 @@ public class ConfigurationBuilderImpl implements ConfigurationBuilder {
return false;
}
- ConfigurationBuilderImpl that = (ConfigurationBuilderImpl) o;
+ final ConfigurationBuilderImpl that = (ConfigurationBuilderImpl) o;
if (boundConstructors != null ?
!boundConstructors.equals(that.boundConstructors) : that.boundConstructors != null) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationImpl.java
index 2467c09..42ab78b 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationImpl.java
@@ -93,12 +93,12 @@ public class ConfigurationImpl implements Configuration {
}
@Override
- public Set<Object> getBoundSet(NamedParameterNode<Set<?>> np) {
+ public Set<Object> getBoundSet(final NamedParameterNode<Set<?>> np) {
return this.builder.boundSetEntries.getValuesForKey(np);
}
@Override
- public List<Object> getBoundList(NamedParameterNode<List<?>> np) {
+ public List<Object> getBoundList(final NamedParameterNode<List<?>> np) {
return this.builder.boundLists.get(np);
}
@@ -119,7 +119,7 @@ public class ConfigurationImpl implements Configuration {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionFuturePlan.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionFuturePlan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionFuturePlan.java
index 6b55adb..4e3d8f2 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionFuturePlan.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionFuturePlan.java
@@ -22,7 +22,7 @@ import org.apache.reef.tang.types.Node;
public class InjectionFuturePlan<T> extends InjectionPlan<T> {
- public InjectionFuturePlan(Node name) {
+ public InjectionFuturePlan(final Node name) {
super(name);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java
index d13750a..19803d7 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java
@@ -32,7 +32,7 @@ public abstract class InjectionPlan<T> implements Traversable<InjectionPlan<?>>
this.node = node;
}
- private static void newline(StringBuffer pretty, int indent) {
+ private static void newline(final StringBuffer pretty, final int indent) {
pretty.append('\n');
for (int j = 0; j < indent * 2; j++) {
pretty.append(' ');
@@ -65,18 +65,18 @@ public abstract class InjectionPlan<T> implements Traversable<InjectionPlan<?>>
public abstract boolean isInjectable();
- protected void pad(StringBuffer sb, int n) {
+ protected void pad(final StringBuffer sb, final int n) {
for (int i = 0; i < n; i++) {
sb.append(" ");
}
}
public String toPrettyString() {
- String ugly = node.getFullName() + ":\n" + toString();
- StringBuffer pretty = new StringBuffer();
+ final String ugly = node.getFullName() + ":\n" + toString();
+ final StringBuffer pretty = new StringBuffer();
int currentIndent = 1;
for (int i = 0; i < ugly.length(); i++) {
- char c = ugly.charAt(i);
+ final char c = ugly.charAt(i);
if (c == '(') {
if (ugly.charAt(i + 1) == ')') {
pretty.append("()");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ListInjectionPlan.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ListInjectionPlan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ListInjectionPlan.java
index 18e7056..e759b52 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ListInjectionPlan.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ListInjectionPlan.java
@@ -29,13 +29,13 @@ public class ListInjectionPlan<T> extends InjectionPlan<T> {
private final boolean isAmbiguous;
private final boolean isInjectable;
- public ListInjectionPlan(Node name, List<InjectionPlan<T>> entries) {
+ public ListInjectionPlan(final Node name, final List<InjectionPlan<T>> entries) {
super(name);
this.entries.addAll(entries);
int numAlternativesAccumulator = 1;
boolean isAmbiguousAccumulator = false;
boolean isInjectableAccumulator = true;
- for (InjectionPlan<T> ip : entries) {
+ for (final InjectionPlan<T> ip : entries) {
numAlternativesAccumulator *= ip.getNumAlternatives();
isAmbiguousAccumulator |= ip.isAmbiguous();
isInjectableAccumulator &= ip.isInjectable();
@@ -66,8 +66,8 @@ public class ListInjectionPlan<T> extends InjectionPlan<T> {
@Override
protected String toAmbiguousInjectString() {
- StringBuilder sb = new StringBuilder(getNode().getFullName() + "(list) includes ambiguous plans [");
- for (InjectionPlan<T> ip : entries) {
+ final StringBuilder sb = new StringBuilder(getNode().getFullName() + "(list) includes ambiguous plans [");
+ for (final InjectionPlan<T> ip : entries) {
if (ip.isAmbiguous()) {
sb.append("\n" + ip.toAmbiguousInjectString());
}
@@ -78,8 +78,8 @@ public class ListInjectionPlan<T> extends InjectionPlan<T> {
@Override
protected String toInfeasibleInjectString() {
- StringBuilder sb = new StringBuilder(getNode().getFullName() + "(list) includes infeasible plans [");
- for (InjectionPlan<T> ip : entries) {
+ final StringBuilder sb = new StringBuilder(getNode().getFullName() + "(list) includes infeasible plans [");
+ for (final InjectionPlan<T> ip : entries) {
if (!ip.isFeasible()) {
sb.append("\n" + ip.toInfeasibleInjectString());
}
@@ -95,8 +95,8 @@ public class ListInjectionPlan<T> extends InjectionPlan<T> {
@Override
public String toShallowString() {
- StringBuilder sb = new StringBuilder("list { ");
- for (InjectionPlan<T> ip : entries) {
+ final StringBuilder sb = new StringBuilder("list { ");
+ for (final InjectionPlan<T> ip : entries) {
sb.append("\n" + ip.toShallowString());
}
sb.append("\n } ");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/SetInjectionPlan.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/SetInjectionPlan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/SetInjectionPlan.java
index 8b65ad4..5fd333a 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/SetInjectionPlan.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/SetInjectionPlan.java
@@ -29,13 +29,13 @@ public class SetInjectionPlan<T> extends InjectionPlan<T> {
private final boolean isAmbiguous;
private final boolean isInjectable;
- public SetInjectionPlan(Node name, Set<InjectionPlan<T>> entries) {
+ public SetInjectionPlan(final Node name, final Set<InjectionPlan<T>> entries) {
super(name);
this.entries.addAll(entries);
int numAlternativesAccumulator = 1;
boolean isAmbiguousAccumulator = false;
boolean isInjectableAccumulator = true;
- for (InjectionPlan<T> ip : entries) {
+ for (final InjectionPlan<T> ip : entries) {
numAlternativesAccumulator *= ip.getNumAlternatives();
isAmbiguousAccumulator |= ip.isAmbiguous();
isInjectableAccumulator &= ip.isInjectable();
@@ -66,8 +66,8 @@ public class SetInjectionPlan<T> extends InjectionPlan<T> {
@Override
protected String toAmbiguousInjectString() {
- StringBuilder sb = new StringBuilder(getNode().getFullName() + "(set) includes ambiguous plans [");
- for (InjectionPlan<T> ip : entries) {
+ final StringBuilder sb = new StringBuilder(getNode().getFullName() + "(set) includes ambiguous plans [");
+ for (final InjectionPlan<T> ip : entries) {
if (ip.isAmbiguous()) {
sb.append("\n" + ip.toAmbiguousInjectString());
}
@@ -78,8 +78,8 @@ public class SetInjectionPlan<T> extends InjectionPlan<T> {
@Override
protected String toInfeasibleInjectString() {
- StringBuilder sb = new StringBuilder(getNode().getFullName() + "(set) includes infeasible plans [");
- for (InjectionPlan<T> ip : entries) {
+ final StringBuilder sb = new StringBuilder(getNode().getFullName() + "(set) includes infeasible plans [");
+ for (final InjectionPlan<T> ip : entries) {
if (!ip.isFeasible()) {
sb.append("\n" + ip.toInfeasibleInjectString());
}
@@ -95,8 +95,8 @@ public class SetInjectionPlan<T> extends InjectionPlan<T> {
@Override
public String toShallowString() {
- StringBuilder sb = new StringBuilder("set { ");
- for (InjectionPlan<T> ip : entries) {
+ final StringBuilder sb = new StringBuilder("set { ");
+ for (final InjectionPlan<T> ip : entries) {
sb.append("\n" + ip.toShallowString());
}
sb.append("\n } ");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/StackBindLocation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/StackBindLocation.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/StackBindLocation.java
index 063ecd6..55f9bec 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/StackBindLocation.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/StackBindLocation.java
@@ -26,7 +26,7 @@ public class StackBindLocation implements BindLocation {
final StackTraceElement[] stack;
public StackBindLocation() {
- StackTraceElement[] stackTrace = new Throwable().getStackTrace();
+ final StackTraceElement[] stackTrace = new Throwable().getStackTrace();
if (stackTrace.length != 0) {
this.stack = Arrays.copyOfRange(stackTrace, 1, stackTrace.length);
} else {
@@ -36,8 +36,8 @@ public class StackBindLocation implements BindLocation {
@Override
public String toString() {
- StringBuffer sb = new StringBuffer("[\n");
- for (StackTraceElement e : stack) {
+ final StringBuffer sb = new StringBuffer("[\n");
+ for (final StackTraceElement e : stack) {
sb.append(e.toString() + "\n");
}
sb.append("]\n");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java
index 8a59299..f98b8c0 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java
@@ -28,7 +28,7 @@ public final class Subplan<T> extends InjectionPlan<T> {
final int selectedIndex;
@SafeVarargs
- public Subplan(Node node, int selectedIndex, InjectionPlan<T>... alternatives) {
+ public Subplan(final Node node, final int selectedIndex, final InjectionPlan<T>... alternatives) {
super(node);
this.alternatives = alternatives;
if (selectedIndex < -1 || selectedIndex >= alternatives.length) {
@@ -39,7 +39,7 @@ public final class Subplan<T> extends InjectionPlan<T> {
this.numAlternatives = alternatives[selectedIndex].getNumAlternatives();
} else {
int numAlternativesSum = 0;
- for (InjectionPlan<? extends T> a : alternatives) {
+ for (final InjectionPlan<? extends T> a : alternatives) {
numAlternativesSum += a.getNumAlternatives();
}
this.numAlternatives = numAlternativesSum;
@@ -47,7 +47,7 @@ public final class Subplan<T> extends InjectionPlan<T> {
}
@SafeVarargs
- public Subplan(Node node, InjectionPlan<T>... alternatives) {
+ public Subplan(final Node node, final InjectionPlan<T>... alternatives) {
this(node, -1, alternatives);
}
@@ -96,7 +96,7 @@ public final class Subplan<T> extends InjectionPlan<T> {
} else if (alternatives.length == 0) {
return getNode().getName() + ": no injectable constructors";
}
- StringBuilder sb = new StringBuilder("[");
+ final StringBuilder sb = new StringBuilder("[");
sb.append(getNode().getName() + " = " + alternatives[0]);
for (int i = 1; i < alternatives.length; i++) {
sb.append(" | " + alternatives[i]);
@@ -112,7 +112,7 @@ public final class Subplan<T> extends InjectionPlan<T> {
} else if (alternatives.length == 0) {
return getNode().getName() + ": no injectable constructors";
}
- StringBuilder sb = new StringBuilder("[");
+ final StringBuilder sb = new StringBuilder("[");
sb.append(getNode().getName() + " = " + alternatives[0].toShallowString());
for (int i = 1; i < alternatives.length; i++) {
sb.append(" | " + alternatives[i].toShallowString());
@@ -140,9 +140,9 @@ public final class Subplan<T> extends InjectionPlan<T> {
} else if (selectedIndex != -1) {
return alternatives[selectedIndex].toAmbiguousInjectString();
} else {
- List<InjectionPlan<?>> alts = new ArrayList<>();
- List<InjectionPlan<?>> ambig = new ArrayList<>();
- for (InjectionPlan<?> alt : alternatives) {
+ final List<InjectionPlan<?>> alts = new ArrayList<>();
+ final List<InjectionPlan<?>> ambig = new ArrayList<>();
+ for (final InjectionPlan<?> alt : alternatives) {
if (alt.isFeasible()) {
alts.add(alt);
}
@@ -150,11 +150,11 @@ public final class Subplan<T> extends InjectionPlan<T> {
ambig.add(alt);
}
}
- StringBuffer sb = new StringBuffer("Ambiguous subplan " + getNode().getFullName());
- for (InjectionPlan<?> alt : alts) {
+ final StringBuffer sb = new StringBuffer("Ambiguous subplan " + getNode().getFullName());
+ for (final InjectionPlan<?> alt : alts) {
sb.append("\n " + alt.toShallowString() + " ");
}
- for (InjectionPlan<?> alt : ambig) {
+ for (final InjectionPlan<?> alt : ambig) {
sb.append("\n " + alt.toShallowString() + " ");
}
sb.append("\n]");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
index 7df15e0..a4125b2 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
@@ -40,7 +40,7 @@ public class TangImpl implements Tang {
}
@Override
- public Injector newInjector(Configuration... confs) throws BindException {
+ public Injector newInjector(final Configuration... confs) throws BindException {
return new InjectorImpl(new JavaConfigurationBuilderImpl(confs).build());
}
@@ -49,23 +49,23 @@ public class TangImpl implements Tang {
public JavaConfigurationBuilder newConfigurationBuilder() {
try {
return newConfigurationBuilder(new URL[0], new Configuration[0], new Class[0]);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException(
"Caught unexpeceted bind exception! Implementation bug.", e);
}
}
@Override
- public ConfigurationBuilder newConfigurationBuilder(ClassHierarchy ch) {
+ public ConfigurationBuilder newConfigurationBuilder(final ClassHierarchy ch) {
return new ConfigurationBuilderImpl(ch);
}
@SuppressWarnings("unchecked")
@Override
- public JavaConfigurationBuilder newConfigurationBuilder(URL... jars) {
+ public JavaConfigurationBuilder newConfigurationBuilder(final URL... jars) {
try {
return newConfigurationBuilder(jars, new Configuration[0], new Class[0]);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException(
"Caught unexpeceted bind exception! Implementation bug.", e);
}
@@ -74,22 +74,21 @@ public class TangImpl implements Tang {
@SuppressWarnings("unchecked")
@Override
public JavaConfigurationBuilder newConfigurationBuilder(
- Configuration... confs) throws BindException {
+ final Configuration... confs) throws BindException {
return newConfigurationBuilder(new URL[0], confs, new Class[0]);
}
@Override
public final JavaConfigurationBuilder newConfigurationBuilder(
- @SuppressWarnings("unchecked") Class<? extends ExternalConstructor<?>>... parsers) throws BindException {
+ @SuppressWarnings("unchecked") final Class<? extends ExternalConstructor<?>>... parsers) throws BindException {
return newConfigurationBuilder(new URL[0], new Configuration[0], parsers);
}
@Override
- public JavaConfigurationBuilder newConfigurationBuilder(URL[] jars,
- Configuration[] confs,
- Class<? extends ExternalConstructor<?>>[] parameterParsers)
+ public JavaConfigurationBuilder newConfigurationBuilder(final URL[] jars, final Configuration[] confs,
+ final Class<? extends ExternalConstructor<?>>[] parameterParsers)
throws BindException {
- JavaConfigurationBuilder cb = new JavaConfigurationBuilderImpl(jars, confs, parameterParsers);
+ final JavaConfigurationBuilder cb = new JavaConfigurationBuilderImpl(jars, confs, parameterParsers);
// for (Configuration c : confs) {
// cb.addConfiguration(c);
// }
@@ -103,9 +102,9 @@ public class TangImpl implements Tang {
}
@Override
- public JavaClassHierarchy getDefaultClassHierarchy(URL[] jars,
- Class<? extends ExternalConstructor<?>>[] parameterParsers) {
- SetValuedKey key = new SetValuedKey(jars, parameterParsers);
+ public JavaClassHierarchy getDefaultClassHierarchy(final URL[] jars,
+ final Class<? extends ExternalConstructor<?>>[] parameterParsers) {
+ final SetValuedKey key = new SetValuedKey(jars, parameterParsers);
JavaClassHierarchy ret = defaultClassHierarchy.get(key);
if (ret == null) {
@@ -116,10 +115,10 @@ public class TangImpl implements Tang {
}
@Override
- public Injector newInjector(Configuration confs) {
+ public Injector newInjector(final Configuration confs) {
try {
return newInjector(new Configuration[]{confs});
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException("Unexpected error cloning configuration", e);
}
}
@@ -128,7 +127,7 @@ public class TangImpl implements Tang {
public Injector newInjector() {
try {
return newInjector(new Configuration[]{});
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException("Unexpected error from empty configuration", e);
}
}
@@ -136,7 +135,7 @@ public class TangImpl implements Tang {
private class SetValuedKey {
public final Set<Object> key;
- public SetValuedKey(Object[] ts, Object[] us) {
+ public SetValuedKey(final Object[] ts, final Object[] us) {
key = new HashSet<Object>(Arrays.asList(ts));
key.addAll(Arrays.asList(us));
}
@@ -144,15 +143,15 @@ public class TangImpl implements Tang {
@Override
public int hashCode() {
int i = 0;
- for (Object t : key) {
+ for (final Object t : key) {
i += t.hashCode();
}
return i;
}
@Override
- public boolean equals(Object o) {
- SetValuedKey other = (SetValuedKey) o;
+ public boolean equals(final Object o) {
+ final SetValuedKey other = (SetValuedKey) o;
if (other.key.size() != this.key.size()) {
return false;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
index 9e1ea57..74c8d3c 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
@@ -129,7 +129,7 @@ final class AvroClassHierarchy implements ClassHierarchy {
final ClassNode iface;
try {
iface = (ClassNode) getNode(getString(n.getFullName()));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
final String errorMessage = new StringBuilder()
.append("When reading avro node ").append(n.getFullName())
.append(" does not exist. Full record is ").append(n).toString();
@@ -138,18 +138,18 @@ final class AvroClassHierarchy implements ClassHierarchy {
for (final CharSequence impl : cn.getImplFullNames()) {
try {
iface.putImpl((ClassNode) getNode(getString(impl)));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
final String errorMessage = new StringBuilder()
.append("When reading avro node ").append(n)
.append(" refers to non-existent implementation:").append(impl).toString();
throw new IllegalStateException(errorMessage, e);
- } catch (ClassCastException e) {
+ } catch (final ClassCastException e) {
try {
final String errorMessage = new StringBuilder()
.append("When reading avro node ").append(n).append(" found implementation")
.append(getNode(getString(impl))).append(" which is not a ClassNode!").toString();
throw new IllegalStateException(errorMessage, e);
- } catch (NameResolutionException e2) {
+ } catch (final NameResolutionException e2) {
final String errorMessage = new StringBuilder()
.append("Got 'cant happen' exception when producing error message for ")
.append(e).toString();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java
index d0026ac..886b1d5 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java
@@ -218,7 +218,7 @@ public final class AvroClassHierarchySerializer implements ClassHierarchySeriali
}
@Override
- public void toTextFile(ClassHierarchy classHierarchy, File file) throws IOException {
+ public void toTextFile(final ClassHierarchy classHierarchy, final File file) throws IOException {
try (final Writer w = new FileWriter(file)) {
w.write(this.toString(classHierarchy));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/ClassHierarchyImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/ClassHierarchyImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/ClassHierarchyImpl.java
index 3011a0f..5d5f953 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/ClassHierarchyImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/ClassHierarchyImpl.java
@@ -79,18 +79,18 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
}
@SuppressWarnings("unchecked")
- public ClassHierarchyImpl(URL... jars) {
+ public ClassHierarchyImpl(final URL... jars) {
this(jars, new Class[0]);
}
- public ClassHierarchyImpl(URL[] jars, Class<? extends ExternalConstructor<?>>[] parameterParsers) {
+ public ClassHierarchyImpl(final URL[] jars, final Class<? extends ExternalConstructor<?>>[] parameterParsers) {
this.namespace = JavaNodeFactory.createRootPackageNode();
this.jars = new ArrayList<>(Arrays.asList(jars));
this.loader = new URLClassLoader(jars, this.getClass().getClassLoader());
- for (Class<? extends ExternalConstructor<?>> p : parameterParsers) {
+ for (final Class<? extends ExternalConstructor<?>> p : parameterParsers) {
try {
parameterParser.addParser(p);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalArgumentException("Could not register parameter parsers", e);
}
}
@@ -106,14 +106,14 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
*/
@SuppressWarnings("unchecked")
@Override
- public <T> T parseDefaultValue(NamedParameterNode<T> name) {
- String[] vals = name.getDefaultInstanceAsStrings();
- T[] ret = (T[]) new Object[vals.length];
+ public <T> T parseDefaultValue(final NamedParameterNode<T> name) {
+ final String[] vals = name.getDefaultInstanceAsStrings();
+ final T[] ret = (T[]) new Object[vals.length];
for (int i = 0; i < vals.length; i++) {
- String val = vals[i];
+ final String val = vals[i];
try {
ret[i] = parse(name, val);
- } catch (ParseException e) {
+ } catch (final ParseException e) {
throw new ClassHierarchyException("Could not parse default value", e);
}
}
@@ -143,11 +143,11 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
*/
@Override
@SuppressWarnings("unchecked")
- public <T> T parse(NamedParameterNode<T> np, String value) throws ParseException {
+ public <T> T parse(final NamedParameterNode<T> np, final String value) throws ParseException {
final ClassNode<T> iface;
try {
iface = (ClassNode<T>) getNode(np.getFullArgName());
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException("Could not parse validated named parameter argument type. NamedParameter is " +
np.getFullName() + " argument type is " + np.getFullArgName());
}
@@ -156,7 +156,7 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
try {
clazz = (Class<?>) classForName(iface.getFullName());
fullName = null;
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
clazz = null;
fullName = iface.getFullName();
}
@@ -166,7 +166,7 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
} else {
return parameterParser.parse(fullName, value);
}
- } catch (UnsupportedOperationException e) {
+ } catch (final UnsupportedOperationException e) {
try {
final Node impl = getNode(value);
if (impl instanceof ClassNode) {
@@ -176,7 +176,7 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
}
throw new ParseException("Name<" + iface.getFullName() + "> " + np.getFullName() +
" cannot take non-subclass " + impl.getFullName(), e);
- } catch (NameResolutionException e2) {
+ } catch (final NameResolutionException e2) {
throw new ParseException("Name<" + iface.getFullName() + "> " + np.getFullName() +
" cannot take non-class " + value, e);
}
@@ -188,13 +188,13 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
* ClassHierarchy's classloader.
*/
@Override
- public Class<?> classForName(String name) throws ClassNotFoundException {
+ public Class<?> classForName(final String name) throws ClassNotFoundException {
return ReflectionUtilities.classForName(name, loader);
}
- private <T, U> Node buildPathToNode(Class<U> clazz)
+ private <T, U> Node buildPathToNode(final Class<U> clazz)
throws ClassHierarchyException {
- String[] path = clazz.getName().split("\\$");
+ final String[] path = clazz.getName().split("\\$");
Node root = namespace;
for (int i = 0; i < path.length - 1; i++) {
@@ -204,17 +204,16 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
if (root == null) {
throw new NullPointerException();
}
- Node parent = root;
+ final Node parent = root;
- Type argType = ReflectionUtilities.getNamedParameterTargetOrNull(clazz);
+ final Type argType = ReflectionUtilities.getNamedParameterTargetOrNull(clazz);
if (argType == null) {
return JavaNodeFactory.createClassNode(parent, clazz);
} else {
- @SuppressWarnings("unchecked")
// checked inside of NamedParameterNode, using reflection.
- NamedParameterNode<T> np = JavaNodeFactory.createNamedParameterNode(
+ @SuppressWarnings("unchecked") final NamedParameterNode<T> np = JavaNodeFactory.createNamedParameterNode(
parent, (Class<? extends Name<T>>) clazz, argType);
if (parameterParser.canParse(ReflectionUtilities.getFullName(argType))) {
@@ -224,9 +223,9 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
}
}
- String shortName = np.getShortName();
+ final String shortName = np.getShortName();
if (shortName != null) {
- NamedParameterNode<?> oldNode = shortNames.get(shortName);
+ final NamedParameterNode<?> oldNode = shortNames.get(shortName);
if (oldNode != null) {
if (oldNode.getFullName().equals(np.getFullName())) {
throw new IllegalStateException("Tried to double bind "
@@ -242,23 +241,23 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
}
}
- private Node getAlreadyBoundNode(Class<?> clazz) throws NameResolutionException {
+ private Node getAlreadyBoundNode(final Class<?> clazz) throws NameResolutionException {
return getAlreadyBoundNode(ReflectionUtilities.getFullName(clazz));
}
@Override
- public Node getNode(Class<?> clazz) {
+ public Node getNode(final Class<?> clazz) {
try {
return getNode(ReflectionUtilities.getFullName(clazz));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new ClassHierarchyException("JavaClassHierarchy could not resolve " + clazz
+ " which is definitely avalable at runtime", e);
}
}
@Override
- public synchronized Node getNode(String name) throws NameResolutionException {
- Node n = register(name);
+ public synchronized Node getNode(final String name) throws NameResolutionException {
+ final Node n = register(name);
if (n == null) {
// This will never succeed; it just generates a nice exception.
getAlreadyBoundNode(name);
@@ -268,10 +267,10 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
return n;
}
- private Node getAlreadyBoundNode(String name) throws NameResolutionException {
+ private Node getAlreadyBoundNode(final String name) throws NameResolutionException {
Node root = namespace;
- String[] toks = name.split("\\$");
- String outerClassName = toks[0];
+ final String[] toks = name.split("\\$");
+ final String outerClassName = toks[0];
root = root.get(outerClassName);
if (root == null) {
throw new NameResolutionException(name, outerClassName);
@@ -279,7 +278,7 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
for (int i = 1; i < toks.length; i++) {
root = root.get(toks[i]);
if (root == null) {
- StringBuilder sb = new StringBuilder(outerClassName);
+ final StringBuilder sb = new StringBuilder(outerClassName);
for (int j = 0; j < i; j++) {
sb.append(toks[j]);
if (j != i - 1) {
@@ -292,17 +291,17 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
return root;
}
- private Node register(String s) {
+ private Node register(final String s) {
final Class<?> c;
try {
c = classForName(s);
- } catch (ClassNotFoundException e1) {
+ } catch (final ClassNotFoundException e1) {
return null;
}
try {
- Node n = getAlreadyBoundNode(c);
+ final Node n = getAlreadyBoundNode(c);
return n;
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
// node not bound yet
}
// First, walk up the class hierarchy, registering all out parents. This
@@ -310,7 +309,7 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
if (c.getSuperclass() != null) {
register(ReflectionUtilities.getFullName(c.getSuperclass()));
}
- for (Class<?> i : c.getInterfaces()) {
+ for (final Class<?> i : c.getInterfaces()) {
register(ReflectionUtilities.getFullName(i));
}
// Now, we'd like to register our enclosing classes. This turns out to be
@@ -325,28 +324,28 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
// So, even though grafting arbitrary DAGs together can give us cycles, Java
// seems
// to have our back on this one.
- Class<?> enclosing = c.getEnclosingClass();
+ final Class<?> enclosing = c.getEnclosingClass();
if (enclosing != null) {
register(ReflectionUtilities.getFullName(enclosing));
}
// Now register the class. This has to be after the above so we know our
// parents (superclasses and enclosing packages) are already registered.
- Node n = registerClass(c);
+ final Node n = registerClass(c);
// Finally, do things that might introduce cycles that invlove c.
// This has to be below registerClass, which ensures that any cycles
// this stuff introduces are broken.
- for (Class<?> innerClass : c.getDeclaredClasses()) {
+ for (final Class<?> innerClass : c.getDeclaredClasses()) {
register(ReflectionUtilities.getFullName(innerClass));
}
if (n instanceof ClassNode) {
- ClassNode<?> cls = (ClassNode<?>) n;
- for (ConstructorDef<?> def : cls.getInjectableConstructors()) {
- for (ConstructorArg arg : def.getArgs()) {
+ final ClassNode<?> cls = (ClassNode<?>) n;
+ for (final ConstructorDef<?> def : cls.getInjectableConstructors()) {
+ for (final ConstructorArg arg : def.getArgs()) {
register(arg.getType());
if (arg.getNamedParameterName() != null) {
- NamedParameterNode<?> np = (NamedParameterNode<?>) register(arg
+ final NamedParameterNode<?> np = (NamedParameterNode<?>) register(arg
.getNamedParameterName());
try {
// TODO: When handling sets, need to track target of generic parameter, and check the type here!
@@ -359,7 +358,7 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
+ np.getFullArgName());
}
}
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
throw new ClassHierarchyException("Constructor refers to unknown class "
+ arg.getType(), e);
}
@@ -367,7 +366,7 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
}
}
} else if (n instanceof NamedParameterNode) {
- NamedParameterNode<?> np = (NamedParameterNode<?>) n;
+ final NamedParameterNode<?> np = (NamedParameterNode<?>) n;
register(np.getFullArgName());
}
return n;
@@ -386,26 +385,26 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
}
try {
return getAlreadyBoundNode(c);
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
// node not bound yet
}
final Node n = buildPathToNode(c);
if (n instanceof ClassNode) {
- ClassNode<T> cn = (ClassNode<T>) n;
- Class<T> superclass = (Class<T>) c.getSuperclass();
+ final ClassNode<T> cn = (ClassNode<T>) n;
+ final Class<T> superclass = (Class<T>) c.getSuperclass();
if (superclass != null) {
try {
((ClassNode<T>) getAlreadyBoundNode(superclass)).putImpl(cn);
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException(e);
}
}
- for (Class<?> interf : c.getInterfaces()) {
+ for (final Class<?> interf : c.getInterfaces()) {
try {
((ClassNode<T>) getAlreadyBoundNode(interf)).putImpl(cn);
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException(e);
}
}
@@ -419,12 +418,12 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
}
@Override
- public synchronized boolean isImplementation(ClassNode<?> inter, ClassNode<?> impl) {
+ public synchronized boolean isImplementation(final ClassNode<?> inter, final ClassNode<?> impl) {
return impl.isImplementationOf(inter);
}
@Override
- public synchronized ClassHierarchy merge(ClassHierarchy ch) {
+ public synchronized ClassHierarchy merge(final ClassHierarchy ch) {
if (this == ch) {
return this;
}
@@ -434,10 +433,10 @@ public class ClassHierarchyImpl implements JavaClassHierarchy {
if (this.jars.size() == 0) {
return ch;
}
- ClassHierarchyImpl chi = (ClassHierarchyImpl) ch;
- HashSet<URL> otherJars = new HashSet<>();
+ final ClassHierarchyImpl chi = (ClassHierarchyImpl) ch;
+ final HashSet<URL> otherJars = new HashSet<>();
otherJars.addAll(chi.jars);
- HashSet<URL> myJars = new HashSet<>();
+ final HashSet<URL> myJars = new HashSet<>();
myJars.addAll(this.jars);
if (myJars.containsAll(otherJars)) {
return this;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/InjectorImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/InjectorImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/InjectorImpl.java
index 32d15a0..08787ab 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/InjectorImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/InjectorImpl.java
@@ -83,46 +83,46 @@ public class InjectorImpl implements Injector {
private boolean concurrentModificationGuard = false;
private Aspect aspect;
- public InjectorImpl(Configuration c) throws BindException {
+ public InjectorImpl(final Configuration c) throws BindException {
this.c = c;
this.namespace = c.getClassHierarchy();
this.javaNamespace = (ClassHierarchyImpl) this.namespace;
}
- private static InjectorImpl copy(InjectorImpl old,
- Configuration... configurations) throws BindException {
+ private static InjectorImpl copy(final InjectorImpl old,
+ final Configuration... configurations) throws BindException {
final InjectorImpl i;
try {
final ConfigurationBuilder cb = old.c.newBuilder();
- for (Configuration c : configurations) {
+ for (final Configuration c : configurations) {
cb.addConfiguration(c);
}
i = new InjectorImpl(cb.build());
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException(
"Unexpected error copying configuration!", e);
}
- for (ClassNode<?> cn : old.instances.keySet()) {
+ for (final ClassNode<?> cn : old.instances.keySet()) {
if (cn.getFullName().equals(ReflectionUtilities.getFullName(Injector.class))
|| cn.getFullName().equals(ReflectionUtilities.getFullName(InjectorImpl.class))) {
// This would imply that we're treating injector as a singleton somewhere. It should be copied fresh each time.
throw new IllegalStateException();
}
try {
- ClassNode<?> newCn = (ClassNode<?>) i.namespace.getNode(cn
+ final ClassNode<?> newCn = (ClassNode<?>) i.namespace.getNode(cn
.getFullName());
i.instances.put(newCn, old.instances.get(cn));
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException("Could not resolve name "
+ cn.getFullName() + " when copying injector");
}
}
// Copy references to the remaining (which must have been set with
// bindVolatileParameter())
- for (NamedParameterNode<?> np : old.namedParameterInstances.keySet()) {
+ for (final NamedParameterNode<?> np : old.namedParameterInstances.keySet()) {
// if (!builder.namedParameters.containsKey(np)) {
- Object o = old.namedParameterInstances.get(np);
- NamedParameterNode<?> newNp = (NamedParameterNode<?>) i.namespace
+ final Object o = old.namedParameterInstances.get(np);
+ final NamedParameterNode<?> newNp = (NamedParameterNode<?>) i.namespace
.getNode(np.getFullName());
i.namedParameterInstances.put(newNp, o);
}
@@ -141,11 +141,11 @@ public class InjectorImpl implements Injector {
}
@SuppressWarnings("unchecked")
- private <T> T getCachedInstance(ClassNode<T> cn) {
+ private <T> T getCachedInstance(final ClassNode<T> cn) {
if (cn.getFullName().equals("org.apache.reef.tang.Injector")) {
return (T) this; // TODO: We should be insisting on injection futures here! .forkInjector();
} else {
- T t = (T) instances.get(cn);
+ final T t = (T) instances.get(cn);
if (t instanceof InjectionFuture) {
throw new IllegalStateException("Found an injection future in getCachedInstance: " + cn);
}
@@ -182,7 +182,7 @@ public class InjectorImpl implements Injector {
constructorList
.addAll(Arrays.asList(thisCN.getInjectableConstructors()));
- for (ConstructorDef<T> def : constructorList) {
+ for (final ConstructorDef<T> def : constructorList) {
final List<InjectionPlan<?>> args = new ArrayList<InjectionPlan<?>>();
final ConstructorArg[] defArgs = def.getArgs();
@@ -192,7 +192,7 @@ public class InjectorImpl implements Injector {
final Node argNode = namespace.getNode(arg.getName());
buildInjectionPlan(argNode, memo);
args.add(memo.get(argNode));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException("Detected unresolvable "
+ "constructor arg while building injection plan. "
+ "This should have been caught earlier!", e);
@@ -201,7 +201,7 @@ public class InjectorImpl implements Injector {
try {
args.add(new InjectionFuturePlan<>(namespace.getNode(arg
.getName())));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException("Detected unresolvable "
+ "constructor arg while building injection plan. "
+ "This should have been caught earlier!", e);
@@ -252,12 +252,12 @@ public class InjectorImpl implements Injector {
}
@SuppressWarnings("unchecked")
- private <T> InjectionPlan<T> buildClassNodeInjectionPlan(ClassNode<T> cn,
- T cachedInstance,
- ClassNode<ExternalConstructor<T>> externalConstructor,
- ClassNode<T> boundImpl,
- ClassNode<T> defaultImpl,
- Map<Node, InjectionPlan<?>> memo) {
+ private <T> InjectionPlan<T> buildClassNodeInjectionPlan(final ClassNode<T> cn,
+ final T cachedInstance,
+ final ClassNode<ExternalConstructor<T>> externalConstructor,
+ final ClassNode<T> boundImpl,
+ final ClassNode<T> defaultImpl,
+ final Map<Node, InjectionPlan<?>> memo) {
if (cachedInstance != null) {
return new JavaInstance<T>(cn, cachedInstance);
@@ -287,10 +287,10 @@ public class InjectorImpl implements Injector {
}
@SuppressWarnings("unchecked")
- private <T> InjectionPlan<T> wrapInjectionPlans(ClassNode<T> infeasibleNode,
- List<? extends InjectionPlan<T>> list,
- boolean forceAmbiguous,
- int selectedIndex) {
+ private <T> InjectionPlan<T> wrapInjectionPlans(final ClassNode<T> infeasibleNode,
+ final List<? extends InjectionPlan<T>> list,
+ final boolean forceAmbiguous,
+ final int selectedIndex) {
if (list.size() == 0) {
return new Subplan<>(infeasibleNode);
} else if ((!forceAmbiguous) && list.size() == 1) {
@@ -307,18 +307,18 @@ public class InjectorImpl implements Injector {
* @throws ParseException
*/
@SuppressWarnings("unchecked")
- private <T> T parseBoundNamedParameter(NamedParameterNode<T> np) {
+ private <T> T parseBoundNamedParameter(final NamedParameterNode<T> np) {
final T ret;
@SuppressWarnings("rawtypes")
final Set<Object> boundSet = c.getBoundSet((NamedParameterNode) np);
if (!boundSet.isEmpty()) {
- Set<T> ret2 = new MonotonicSet<>();
- for (Object o : boundSet) {
+ final Set<T> ret2 = new MonotonicSet<>();
+ for (final Object o : boundSet) {
if (o instanceof String) {
try {
ret2.add(javaNamespace.parse(np, (String) o));
- } catch (ParseException e) {
+ } catch (final ParseException e) {
// Parsability is now pre-checked in bindSet, so it should not be reached!
throw new IllegalStateException("Could not parse " + o + " which was passed into " + np +
" FIXME: Parsability is not currently checked by bindSetEntry(Node,String)");
@@ -334,12 +334,12 @@ public class InjectorImpl implements Injector {
}
final List<Object> boundList = c.getBoundList((NamedParameterNode) np);
if (boundList != null) {
- List<T> ret2 = new ArrayList<>();
- for (Object o : boundList) {
+ final List<T> ret2 = new ArrayList<>();
+ for (final Object o : boundList) {
if (o instanceof String) {
try {
ret2.add(javaNamespace.parse(np, (String) o));
- } catch (ParseException e) {
+ } catch (final ParseException e) {
// Parsability is now pre-checked in bindList, so it should not be reached!
throw new IllegalStateException("Could not parse " + o + " which was passed into " + np + " FIXME: " +
"Parsability is not currently checked by bindList(Node,List)");
@@ -362,7 +362,7 @@ public class InjectorImpl implements Injector {
try {
ret = javaNamespace.parse(np, value);
namedParameterInstances.put(np, ret);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException(
"Could not parse pre-validated value", e);
}
@@ -372,7 +372,7 @@ public class InjectorImpl implements Injector {
}
@SuppressWarnings("unchecked")
- private <T> ClassNode<T> parseDefaultImplementation(ClassNode<T> cn) {
+ private <T> ClassNode<T> parseDefaultImplementation(final ClassNode<T> cn) {
if (cn.getDefaultImplementation() != null) {
try {
return (ClassNode<T>) javaNamespace.getNode(cn.getDefaultImplementation());
@@ -387,11 +387,11 @@ public class InjectorImpl implements Injector {
@SuppressWarnings({"unchecked"})
private <T> void buildInjectionPlan(final Node n,
- Map<Node, InjectionPlan<?>> memo) {
+ final Map<Node, InjectionPlan<?>> memo) {
if (memo.containsKey(n)) {
if (BUILDING == memo.get(n)) {
- StringBuilder loopyList = new StringBuilder("[");
- for (Node node : memo.keySet()) {
+ final StringBuilder loopyList = new StringBuilder("[");
+ for (final Node node : memo.keySet()) {
if (memo.get(node) == BUILDING) {
loopyList.append(" " + node.getFullName());
}
@@ -416,9 +416,9 @@ public class InjectorImpl implements Injector {
buildInjectionPlan((Node) instance, memo);
ip = new Subplan<T>(n, 0, (InjectionPlan<T>) memo.get(instance));
} else if (instance instanceof Set) {
- Set<T> entries = (Set<T>) instance;
- Set<InjectionPlan<T>> plans = new MonotonicHashSet<>();
- for (T entry : entries) {
+ final Set<T> entries = (Set<T>) instance;
+ final Set<InjectionPlan<T>> plans = new MonotonicHashSet<>();
+ for (final T entry : entries) {
if (entry instanceof ClassNode) {
buildInjectionPlan((ClassNode<?>) entry, memo);
plans.add((InjectionPlan<T>) memo.get(entry));
@@ -429,9 +429,9 @@ public class InjectorImpl implements Injector {
}
ip = new SetInjectionPlan<T>(n, plans);
} else if (instance instanceof List) {
- List<T> entries = (List<T>) instance;
- List<InjectionPlan<T>> plans = new ArrayList<>();
- for (T entry : entries) {
+ final List<T> entries = (List<T>) instance;
+ final List<InjectionPlan<T>> plans = new ArrayList<>();
+ for (final T entry : entries) {
if (entry instanceof ClassNode) {
buildInjectionPlan((ClassNode<?>) entry, memo);
plans.add((InjectionPlan<T>) memo.get(entry));
@@ -471,56 +471,55 @@ public class InjectorImpl implements Injector {
* @throws NameResolutionException
*/
public InjectionPlan<?> getInjectionPlan(final Node n) {
- Map<Node, InjectionPlan<?>> memo = new HashMap<>();
+ final Map<Node, InjectionPlan<?>> memo = new HashMap<>();
buildInjectionPlan(n, memo);
return memo.get(n);
}
@Override
- public InjectionPlan<?> getInjectionPlan(String name) throws NameResolutionException {
+ public InjectionPlan<?> getInjectionPlan(final String name) throws NameResolutionException {
return getInjectionPlan(namespace.getNode(name));
}
@SuppressWarnings("unchecked")
- public <T> InjectionPlan<T> getInjectionPlan(Class<T> name) {
+ public <T> InjectionPlan<T> getInjectionPlan(final Class<T> name) {
return (InjectionPlan<T>) getInjectionPlan(javaNamespace.getNode(name));
}
@Override
- public boolean isInjectable(String name) throws NameResolutionException {
+ public boolean isInjectable(final String name) throws NameResolutionException {
return getInjectionPlan(namespace.getNode(name)).isInjectable();
}
@Override
- public boolean isInjectable(Class<?> clazz) {
+ public boolean isInjectable(final Class<?> clazz) {
try {
return isInjectable(ReflectionUtilities.getFullName(clazz));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException("Could not round trip " + clazz + " through ClassHierarchy", e);
}
}
@Override
- public boolean isParameterSet(String name) throws NameResolutionException {
- InjectionPlan<?> p = getInjectionPlan(namespace.getNode(name));
+ public boolean isParameterSet(final String name) throws NameResolutionException {
+ final InjectionPlan<?> p = getInjectionPlan(namespace.getNode(name));
return p.isInjectable();
}
@Override
- public boolean isParameterSet(Class<? extends Name<?>> name)
+ public boolean isParameterSet(final Class<? extends Name<?>> name)
throws BindException {
return isParameterSet(name.getName());
}
- private <U> U getInstance(Node n) throws InjectionException {
+ private <U> U getInstance(final Node n) throws InjectionException {
assertNotConcurrent();
- @SuppressWarnings("unchecked")
- InjectionPlan<U> plan = (InjectionPlan<U>) getInjectionPlan(n);
- U u = (U) injectFromPlan(plan);
+ @SuppressWarnings("unchecked") final InjectionPlan<U> plan = (InjectionPlan<U>) getInjectionPlan(n);
+ final U u = (U) injectFromPlan(plan);
while (!pendingFutures.isEmpty()) {
- Iterator<InjectionFuture<?>> i = pendingFutures.iterator();
- InjectionFuture<?> f = i.next();
+ final Iterator<InjectionFuture<?>> i = pendingFutures.iterator();
+ final InjectionFuture<?> f = i.next();
pendingFutures.remove(f);
f.get();
}
@@ -528,7 +527,7 @@ public class InjectorImpl implements Injector {
}
@Override
- public <U> U getInstance(Class<U> clazz) throws InjectionException {
+ public <U> U getInstance(final Class<U> clazz) throws InjectionException {
if (Name.class.isAssignableFrom(clazz)) {
throw new InjectionException("getInstance() called on Name "
+ ReflectionUtilities.getFullName(clazz)
@@ -539,30 +538,29 @@ public class InjectorImpl implements Injector {
@SuppressWarnings("unchecked")
@Override
- public <U> U getInstance(String clazz) throws InjectionException, NameResolutionException {
+ public <U> U getInstance(final String clazz) throws InjectionException, NameResolutionException {
return (U) getInstance(namespace.getNode(clazz));
}
@Override
@SuppressWarnings("unchecked")
- public <T> T getNamedInstance(Class<? extends Name<T>> clazz)
+ public <T> T getNamedInstance(final Class<? extends Name<T>> clazz)
throws InjectionException {
return (T) getInstance(javaNamespace.getNode(clazz));
}
- public <T> T getNamedParameter(Class<? extends Name<T>> clazz)
+ public <T> T getNamedParameter(final Class<? extends Name<T>> clazz)
throws InjectionException {
return getNamedInstance(clazz);
}
private <T> java.lang.reflect.Constructor<T> getConstructor(
- ConstructorDef<T> constructor) throws ClassNotFoundException,
+ final ConstructorDef<T> constructor) throws ClassNotFoundException,
NoSuchMethodException, SecurityException {
- @SuppressWarnings("unchecked")
- Class<T> clazz = (Class<T>) javaNamespace.classForName(constructor
- .getClassName());
- ConstructorArg[] args = constructor.getArgs();
- Class<?>[] parameterTypes = new Class[args.length];
+ @SuppressWarnings("unchecked") final Class<T> clazz =
+ (Class<T>) javaNamespace.classForName(constructor.getClassName());
+ final ConstructorArg[] args = constructor.getArgs();
+ final Class<?>[] parameterTypes = new Class[args.length];
for (int i = 0; i < args.length; i++) {
if (args[i].isInjectionFuture()) {
parameterTypes[i] = InjectionFuture.class;
@@ -570,7 +568,7 @@ public class InjectorImpl implements Injector {
parameterTypes[i] = javaNamespace.classForName(args[i].getType());
}
}
- java.lang.reflect.Constructor<T> cons = clazz
+ final java.lang.reflect.Constructor<T> cons = clazz
.getDeclaredConstructor(parameterTypes);
cons.setAccessible(true);
return cons;
@@ -594,7 +592,7 @@ public class InjectorImpl implements Injector {
* @throws InjectionException
*/
@SuppressWarnings("unchecked")
- private <T> T injectFromPlan(InjectionPlan<T> plan) throws InjectionException {
+ private <T> T injectFromPlan(final InjectionPlan<T> plan) throws InjectionException {
if (!plan.isFeasible()) {
throw new InjectionException("Cannot inject " + plan.getNode().getFullName() + ": "
@@ -605,13 +603,14 @@ public class InjectorImpl implements Injector {
+ plan.toCantInjectString());
}
if (plan instanceof InjectionFuturePlan) {
- InjectionFuturePlan<T> fut = (InjectionFuturePlan<T>) plan;
+ final InjectionFuturePlan<T> fut = (InjectionFuturePlan<T>) plan;
final String key = fut.getNode().getFullName();
try {
- InjectionFuture<?> ret = new InjectionFuture<>(this, javaNamespace.classForName(fut.getNode().getFullName()));
+ final InjectionFuture<?> ret = new InjectionFuture<>(
+ this, javaNamespace.classForName(fut.getNode().getFullName()));
pendingFutures.add(ret);
return (T) ret;
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
throw new InjectionException("Could not get class for " + key);
}
} else if (plan.getNode() instanceof ClassNode && null != getCachedInstance((ClassNode<T>) plan.getNode())) {
@@ -632,18 +631,18 @@ public class InjectorImpl implements Injector {
concurrentModificationGuard = true;
T ret;
try {
- ConstructorDef<T> def = (ConstructorDef<T>) constructor.getConstructorDef();
- java.lang.reflect.Constructor<T> construct = getConstructor(def);
+ final ConstructorDef<T> def = (ConstructorDef<T>) constructor.getConstructorDef();
+ final java.lang.reflect.Constructor<T> construct = getConstructor(def);
if (aspect != null) {
ret = aspect.inject(def, construct, args);
} else {
ret = construct.newInstance(args);
}
- } catch (IllegalArgumentException e) {
- StringBuilder sb = new StringBuilder("Internal Tang error? Could not call constructor " +
+ } catch (final IllegalArgumentException e) {
+ final StringBuilder sb = new StringBuilder("Internal Tang error? Could not call constructor " +
constructor.getConstructorDef() + " with arguments [");
- for (Object o : args) {
+ for (final Object o : args) {
sb.append("\n\t" + o);
}
sb.append("]");
@@ -654,26 +653,26 @@ public class InjectorImpl implements Injector {
}
instances.put(constructor.getNode(), ret);
return ret;
- } catch (ReflectiveOperationException e) {
+ } catch (final ReflectiveOperationException e) {
throw new InjectionException("Could not invoke constructor: " + plan,
e instanceof InvocationTargetException ? e.getCause() : e);
} finally {
concurrentModificationGuard = false;
}
} else if (plan instanceof Subplan) {
- Subplan<T> ambiguous = (Subplan<T>) plan;
+ final Subplan<T> ambiguous = (Subplan<T>) plan;
return injectFromPlan(ambiguous.getDelegatedPlan());
} else if (plan instanceof SetInjectionPlan) {
- SetInjectionPlan<T> setPlan = (SetInjectionPlan<T>) plan;
- Set<T> ret = new MonotonicHashSet<>();
- for (InjectionPlan<T> subplan : setPlan.getEntryPlans()) {
+ final SetInjectionPlan<T> setPlan = (SetInjectionPlan<T>) plan;
+ final Set<T> ret = new MonotonicHashSet<>();
+ for (final InjectionPlan<T> subplan : setPlan.getEntryPlans()) {
ret.add(injectFromPlan(subplan));
}
return (T) ret;
} else if (plan instanceof ListInjectionPlan) {
- ListInjectionPlan<T> listPlan = (ListInjectionPlan<T>) plan;
- List<T> ret = new ArrayList<>();
- for (InjectionPlan<T> subplan : listPlan.getEntryPlans()) {
+ final ListInjectionPlan<T> listPlan = (ListInjectionPlan<T>) plan;
+ final List<T> ret = new ArrayList<>();
+ for (final InjectionPlan<T> subplan : listPlan.getEntryPlans()) {
ret.add(injectFromPlan(subplan));
}
return (T) ret;
@@ -683,22 +682,22 @@ public class InjectorImpl implements Injector {
}
@Override
- public <T> void bindVolatileInstance(Class<T> cl, T o) throws BindException {
+ public <T> void bindVolatileInstance(final Class<T> cl, final T o) throws BindException {
bindVolatileInstanceNoCopy(cl, o);
}
@Override
- public <T> void bindVolatileParameter(Class<? extends Name<T>> cl, T o)
+ public <T> void bindVolatileParameter(final Class<? extends Name<T>> cl, final T o)
throws BindException {
bindVolatileParameterNoCopy(cl, o);
}
- <T> void bindVolatileInstanceNoCopy(Class<T> cl, T o) throws BindException {
+ <T> void bindVolatileInstanceNoCopy(final Class<T> cl, final T o) throws BindException {
assertNotConcurrent();
- Node n = javaNamespace.getNode(cl);
+ final Node n = javaNamespace.getNode(cl);
if (n instanceof ClassNode) {
- ClassNode<?> cn = (ClassNode<?>) n;
- Object old = getCachedInstance(cn);
+ final ClassNode<?> cn = (ClassNode<?>) n;
+ final Object old = getCachedInstance(cn);
if (old != null) {
throw new BindException("Attempt to re-bind instance. Old value was "
+ old + " new value is " + o);
@@ -710,12 +709,12 @@ public class InjectorImpl implements Injector {
}
}
- <T> void bindVolatileParameterNoCopy(Class<? extends Name<T>> cl, T o)
+ <T> void bindVolatileParameterNoCopy(final Class<? extends Name<T>> cl, final T o)
throws BindException {
- Node n = javaNamespace.getNode(cl);
+ final Node n = javaNamespace.getNode(cl);
if (n instanceof NamedParameterNode) {
- NamedParameterNode<?> np = (NamedParameterNode<?>) n;
- Object old = this.c.getNamedParameter(np);
+ final NamedParameterNode<?> np = (NamedParameterNode<?>) n;
+ final Object old = this.c.getNamedParameter(np);
if (old != null) {
// XXX need to get the binding site here!
throw new BindException(
@@ -724,7 +723,7 @@ public class InjectorImpl implements Injector {
}
try {
namedParameterInstances.put(np, o);
- } catch (IllegalArgumentException e) {
+ } catch (final IllegalArgumentException e) {
throw new BindException(
"Attempt to re-bind named parameter " + ReflectionUtilities.getFullName(cl) + ". Old value was [" + old
+ "] new value is [" + o + "]");
@@ -740,21 +739,21 @@ public class InjectorImpl implements Injector {
public Injector forkInjector() {
try {
return forkInjector(new Configuration[0]);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new IllegalStateException(e);
}
}
@Override
- public Injector forkInjector(Configuration... configurations)
+ public Injector forkInjector(final Configuration... configurations)
throws BindException {
- InjectorImpl ret;
+ final InjectorImpl ret;
ret = copy(this, configurations);
return ret;
}
@Override
- public <T> void bindAspect(Aspect a) throws BindException {
+ public <T> void bindAspect(final Aspect a) throws BindException {
if (aspect != null) {
throw new BindException("Attempt to re-bind aspect! old=" + aspect + " new=" + a);
}
[03/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
index 902722d..00a38e6 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
@@ -53,21 +53,21 @@ public final class LegacyLocalAddressProvider implements LocalAddressProvider {
public String getLocalAddress() {
// This method is surprisingly slow: It was causing unit test timeouts, so we memoize the result.
if (cached.get() == null) {
- Enumeration<NetworkInterface> ifaces;
+ final Enumeration<NetworkInterface> ifaces;
try {
ifaces = NetworkInterface.getNetworkInterfaces();
- TreeSet<Inet4Address> sortedAddrs = new TreeSet<>(new AddressComparator());
+ final TreeSet<Inet4Address> sortedAddrs = new TreeSet<>(new AddressComparator());
// There is an idea of virtual / subinterfaces exposed by java here.
// We're not walking around looking for those because the javadoc says:
// "NOTE: can use getNetworkInterfaces()+getInetAddresses() to obtain all IP addresses for this node"
while (ifaces.hasMoreElements()) {
- NetworkInterface iface = ifaces.nextElement();
+ final NetworkInterface iface = ifaces.nextElement();
// if(iface.isUp()) { // leads to slowness and non-deterministic return values, so don't call isUp().
- Enumeration<InetAddress> addrs = iface.getInetAddresses();
+ final Enumeration<InetAddress> addrs = iface.getInetAddresses();
while (addrs.hasMoreElements()) {
- InetAddress a = addrs.nextElement();
+ final InetAddress a = addrs.nextElement();
if (a instanceof Inet4Address) {
sortedAddrs.add((Inet4Address) a);
}
@@ -80,7 +80,7 @@ public final class LegacyLocalAddressProvider implements LocalAddressProvider {
}
cached.set(sortedAddrs.pollFirst().getHostAddress());
LOG.log(Level.FINE, "Local address is {0}", cached.get());
- } catch (SocketException e) {
+ } catch (final SocketException e) {
throw new WakeRuntimeException("Unable to get local host address",
e.getCause());
}
@@ -98,14 +98,14 @@ public final class LegacyLocalAddressProvider implements LocalAddressProvider {
private static class AddressComparator implements Comparator<Inet4Address> {
// get unsigned byte.
- private static int u(byte b) {
+ private static int u(final byte b) {
return ((int) b); // & 0xff;
}
@Override
- public int compare(Inet4Address aa, Inet4Address ba) {
- byte[] a = aa.getAddress();
- byte[] b = ba.getAddress();
+ public int compare(final Inet4Address aa, final Inet4Address ba) {
+ final byte[] a = aa.getAddress();
+ final byte[] b = ba.getAddress();
// local subnet comes after all else.
if (a[0] == 127 && b[0] != 127) {
return 1;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LocalAddressProviderFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LocalAddressProviderFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LocalAddressProviderFactory.java
index e6f4a3c..b6d558a 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LocalAddressProviderFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LocalAddressProviderFactory.java
@@ -61,7 +61,7 @@ public final class LocalAddressProviderFactory {
LOGGER.log(Level.FINER, "Instantiating default LocalAddressProvider for legacy users.");
instance = Tang.Factory.getTang().newInjector().getInstance(LocalAddressProvider.class);
LOGGER.log(Level.FINER, "Instantiated default LocalAddressProvider for legacy users.");
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException("Unable to instantiate default LocalAddressProvider for legacy users.", e);
}
assert (null != instance);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/exception/RemoteRuntimeException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/exception/RemoteRuntimeException.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/exception/RemoteRuntimeException.java
index e23ee3e..1516d8e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/exception/RemoteRuntimeException.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/exception/RemoteRuntimeException.java
@@ -30,7 +30,7 @@ public class RemoteRuntimeException extends RuntimeException {
* @param s the detailed message
* @param e the cause
*/
- public RemoteRuntimeException(String s, Throwable e) {
+ public RemoteRuntimeException(final String s, final Throwable e) {
super(s, e);
}
@@ -39,7 +39,7 @@ public class RemoteRuntimeException extends RuntimeException {
*
* @param s the detailed message
*/
- public RemoteRuntimeException(String s) {
+ public RemoteRuntimeException(final String s) {
super(s);
}
@@ -48,7 +48,7 @@ public class RemoteRuntimeException extends RuntimeException {
*
* @param e the cause
*/
- public RemoteRuntimeException(Throwable e) {
+ public RemoteRuntimeException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ByteCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ByteCodec.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ByteCodec.java
index 5c24dd3..ec107ad 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ByteCodec.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ByteCodec.java
@@ -32,7 +32,7 @@ public class ByteCodec implements Codec<byte[]> {
* @return the same bytes
*/
@Override
- public byte[] encode(byte[] obj) {
+ public byte[] encode(final byte[] obj) {
return obj;
}
@@ -43,7 +43,7 @@ public class ByteCodec implements Codec<byte[]> {
* @return the same bytes
*/
@Override
- public byte[] decode(byte[] buf) {
+ public byte[] decode(final byte[] buf) {
return buf;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ConnectFutureTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ConnectFutureTask.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ConnectFutureTask.java
index fc6d73c..5e664af 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ConnectFutureTask.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ConnectFutureTask.java
@@ -27,7 +27,7 @@ public class ConnectFutureTask<T> extends FutureTask<T> {
private final EventHandler<ConnectFutureTask<T>> handler;
- public ConnectFutureTask(Callable<T> callable, EventHandler<ConnectFutureTask<T>> handler) {
+ public ConnectFutureTask(final Callable<T> callable, final EventHandler<ConnectFutureTask<T>> handler) {
super(callable);
this.handler = handler;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteIdentifierFactoryImplementation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteIdentifierFactoryImplementation.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteIdentifierFactoryImplementation.java
index b403891..ba8f638 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteIdentifierFactoryImplementation.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteIdentifierFactoryImplementation.java
@@ -35,12 +35,13 @@ public class DefaultRemoteIdentifierFactoryImplementation extends DefaultIdentif
}
@SuppressWarnings({"unchecked", "rawtypes"})
- public DefaultRemoteIdentifierFactoryImplementation(Map<String, Class<? extends RemoteIdentifier>> typeToClazzMap) {
+ public DefaultRemoteIdentifierFactoryImplementation(
+ final Map<String, Class<? extends RemoteIdentifier>> typeToClazzMap) {
super((Map<String, Class<? extends Identifier>>) (Map) typeToClazzMap);
}
@Override
- public RemoteIdentifier getNewInstance(String str) {
+ public RemoteIdentifier getNewInstance(final String str) {
return (RemoteIdentifier) super.getNewInstance(str);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java
index 2d63b34..0aa78c4 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java
@@ -125,7 +125,8 @@ public final class DefaultRemoteManagerFactory implements RemoteManagerFactory {
@Override
@SuppressWarnings("checkstyle:hiddenfield")
- public <T> RemoteManager getInstance(String name, Codec<T> codec, EventHandler<Throwable> errorHandler) {
+ public <T> RemoteManager getInstance(
+ final String name, final Codec<T> codec, final EventHandler<Throwable> errorHandler) {
return new DefaultRemoteManagerImplementation(name,
DefaultRemoteManagerImplementation.UNKNOWN_HOST_NAME, // Indicate to use the localAddressProvider
0, // Indicate to use the tcpPortProvider,
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteMessage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteMessage.java
index 3929415..de2f23b 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteMessage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteMessage.java
@@ -37,7 +37,7 @@ class DefaultRemoteMessage<T> implements RemoteMessage<T> {
* @param id the remote identifier
* @param message the message
*/
- DefaultRemoteMessage(RemoteIdentifier id, T message) {
+ DefaultRemoteMessage(final RemoteIdentifier id, final T message) {
this.id = id;
this.message = message;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultTransportEStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultTransportEStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultTransportEStage.java
index 7f33847..49b0bac 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultTransportEStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultTransportEStage.java
@@ -29,7 +29,7 @@ public class DefaultTransportEStage implements EStage<TransportEvent> {
}
@Override
- public void onNext(TransportEvent value) {
+ public void onNext(final TransportEvent value) {
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiCodec.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiCodec.java
index 1fad3cd..440b241 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiCodec.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiCodec.java
@@ -41,12 +41,12 @@ public class MultiCodec<T> implements Codec<T> {
*
* @param clazzToDecoderMap
*/
- public MultiCodec(Map<Class<? extends T>, Codec<? extends T>> clazzToCodecMap) {
- Map<Class<? extends T>, Encoder<? extends T>> clazzToEncoderMap =
+ public MultiCodec(final Map<Class<? extends T>, Codec<? extends T>> clazzToCodecMap) {
+ final Map<Class<? extends T>, Encoder<? extends T>> clazzToEncoderMap =
new HashMap<Class<? extends T>, Encoder<? extends T>>();
- Map<Class<? extends T>, Decoder<? extends T>> clazzToDecoderMap =
+ final Map<Class<? extends T>, Decoder<? extends T>> clazzToDecoderMap =
new HashMap<Class<? extends T>, Decoder<? extends T>>();
- for (Class<? extends T> clazz : clazzToCodecMap.keySet()) {
+ for (final Class<? extends T> clazz : clazzToCodecMap.keySet()) {
clazzToEncoderMap.put(clazz, clazzToCodecMap.get(clazz));
clazzToDecoderMap.put(clazz, clazzToCodecMap.get(clazz));
}
@@ -60,7 +60,7 @@ public class MultiCodec<T> implements Codec<T> {
* @param obj
*/
@Override
- public byte[] encode(T obj) {
+ public byte[] encode(final T obj) {
return encoder.encode(obj);
}
@@ -70,7 +70,7 @@ public class MultiCodec<T> implements Codec<T> {
* @param data class name and byte payload
*/
@Override
- public T decode(byte[] data) {
+ public T decode(final byte[] data) {
return decoder.decode(data);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiDecoder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiDecoder.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiDecoder.java
index d757d6a..1df9517 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiDecoder.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiDecoder.java
@@ -39,7 +39,7 @@ public class MultiDecoder<T> implements Decoder<T> {
*
* @param clazzToDecoderMap
*/
- public MultiDecoder(Map<Class<? extends T>, Decoder<? extends T>> clazzToDecoderMap) {
+ public MultiDecoder(final Map<Class<? extends T>, Decoder<? extends T>> clazzToDecoderMap) {
this.clazzToDecoderMap = clazzToDecoderMap;
}
@@ -49,21 +49,21 @@ public class MultiDecoder<T> implements Decoder<T> {
* @param data class name and byte payload
*/
@Override
- public T decode(byte[] data) {
- WakeTuplePBuf tuple;
+ public T decode(final byte[] data) {
+ final WakeTuplePBuf tuple;
try {
tuple = WakeTuplePBuf.parseFrom(data);
- } catch (InvalidProtocolBufferException e) {
+ } catch (final InvalidProtocolBufferException e) {
e.printStackTrace();
throw new RemoteRuntimeException(e);
}
- String className = tuple.getClassName();
- byte[] message = tuple.getData().toByteArray();
- Class<?> clazz;
+ final String className = tuple.getClassName();
+ final byte[] message = tuple.getData().toByteArray();
+ final Class<?> clazz;
try {
clazz = Class.forName(className);
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
e.printStackTrace();
throw new RemoteRuntimeException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiEncoder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiEncoder.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiEncoder.java
index 4e3489e..e3e3c46 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiEncoder.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/MultiEncoder.java
@@ -40,7 +40,7 @@ public class MultiEncoder<T> implements Encoder<T> {
*
* @param clazzToEncoderMap
*/
- public MultiEncoder(Map<Class<? extends T>, Encoder<? extends T>> clazzToEncoderMap) {
+ public MultiEncoder(final Map<Class<? extends T>, Encoder<? extends T>> clazzToEncoderMap) {
this.clazzToEncoderMap = clazzToEncoderMap;
}
@@ -50,13 +50,13 @@ public class MultiEncoder<T> implements Encoder<T> {
* @param obj
*/
@Override
- public byte[] encode(T obj) {
- Encoder<T> encoder = (Encoder<T>) clazzToEncoderMap.get(obj.getClass());
+ public byte[] encode(final T obj) {
+ final Encoder<T> encoder = (Encoder<T>) clazzToEncoderMap.get(obj.getClass());
if (encoder == null) {
throw new RemoteRuntimeException("Encoder for " + obj.getClass() + " not known.");
}
- WakeTuplePBuf.Builder tupleBuilder = WakeTuplePBuf.newBuilder();
+ final WakeTuplePBuf.Builder tupleBuilder = WakeTuplePBuf.newBuilder();
tupleBuilder.setClassName(obj.getClass().getName());
tupleBuilder.setData(ByteString.copyFrom(encoder.encode(obj)));
return tupleBuilder.build().toByteArray();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/OrderedRemoteReceiverStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/OrderedRemoteReceiverStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/OrderedRemoteReceiverStage.java
index d5302f7..d695867 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/OrderedRemoteReceiverStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/OrderedRemoteReceiverStage.java
@@ -52,7 +52,8 @@ public class OrderedRemoteReceiverStage implements EStage<TransportEvent> {
* @param handler the handler of remote events
* @param errorHandler the exception handler
*/
- public OrderedRemoteReceiverStage(EventHandler<RemoteEvent<byte[]>> handler, EventHandler<Throwable> errorHandler) {
+ public OrderedRemoteReceiverStage(
+ final EventHandler<RemoteEvent<byte[]>> handler, final EventHandler<Throwable> errorHandler) {
this.streamMap = new ConcurrentHashMap<SocketAddress, OrderedEventStream>();
this.pushExecutor = Executors.newCachedThreadPool(
@@ -67,7 +68,7 @@ public class OrderedRemoteReceiverStage implements EStage<TransportEvent> {
}
@Override
- public void onNext(TransportEvent value) {
+ public void onNext(final TransportEvent value) {
LOG.log(Level.FINEST, "{0}", value);
pushStage.onNext(value);
}
@@ -82,10 +83,10 @@ public class OrderedRemoteReceiverStage implements EStage<TransportEvent> {
// wait for threads to finish for timeout
if (!pushExecutor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = pushExecutor.shutdownNow();
+ final List<Runnable> droppedRunnables = pushExecutor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
LOG.log(Level.WARNING, "Close interrupted");
throw new RemoteRuntimeException(e);
}
@@ -97,10 +98,10 @@ public class OrderedRemoteReceiverStage implements EStage<TransportEvent> {
// wait for threads to finish for timeout
if (!pullExecutor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = pullExecutor.shutdownNow();
+ final List<Runnable> droppedRunnables = pullExecutor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
LOG.log(Level.WARNING, "Close interrupted");
throw new RemoteRuntimeException(e);
}
@@ -116,16 +117,16 @@ class OrderedPushEventHandler implements EventHandler<TransportEvent> {
private final ConcurrentMap<SocketAddress, OrderedEventStream> streamMap; // per remote address
private final ThreadPoolStage<OrderedEventStream> pullStage;
- OrderedPushEventHandler(ConcurrentMap<SocketAddress, OrderedEventStream> streamMap,
- ThreadPoolStage<OrderedEventStream> pullStage) {
+ OrderedPushEventHandler(final ConcurrentMap<SocketAddress, OrderedEventStream> streamMap,
+ final ThreadPoolStage<OrderedEventStream> pullStage) {
this.codec = new RemoteEventCodec<byte[]>(new ByteCodec());
this.streamMap = streamMap;
this.pullStage = pullStage;
}
@Override
- public void onNext(TransportEvent value) {
- RemoteEvent<byte[]> re = codec.decode(value.getData());
+ public void onNext(final TransportEvent value) {
+ final RemoteEvent<byte[]> re = codec.decode(value.getData());
re.setLocalAddress(value.getLocalAddress());
re.setRemoteAddress(value.getRemoteAddress());
@@ -135,7 +136,7 @@ class OrderedPushEventHandler implements EventHandler<TransportEvent> {
LOG.log(Level.FINER, "Value length is {0}", value.getData().length);
- SocketAddress addr = re.remoteAddress();
+ final SocketAddress addr = re.remoteAddress();
OrderedEventStream stream = streamMap.get(re.remoteAddress());
if (stream == null) {
stream = new OrderedEventStream();
@@ -154,12 +155,12 @@ class OrderedPullEventHandler implements EventHandler<OrderedEventStream> {
private final EventHandler<RemoteEvent<byte[]>> handler;
- OrderedPullEventHandler(EventHandler<RemoteEvent<byte[]>> handler) {
+ OrderedPullEventHandler(final EventHandler<RemoteEvent<byte[]>> handler) {
this.handler = handler;
}
@Override
- public void onNext(OrderedEventStream stream) {
+ public void onNext(final OrderedEventStream stream) {
if (LOG.isLoggable(Level.FINER)) {
LOG.log(Level.FINER, "{0}", stream);
}
@@ -183,7 +184,7 @@ class OrderedEventStream {
nextSeq = 0;
}
- synchronized void add(RemoteEvent<byte[]> event) {
+ synchronized void add(final RemoteEvent<byte[]> event) {
queue.add(event);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ProxyEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ProxyEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ProxyEventHandler.java
index 8f763ae..72ba6d7 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ProxyEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ProxyEventHandler.java
@@ -48,8 +48,8 @@ public class ProxyEventHandler<T> implements EventHandler<T> {
* @param reStage the sender stage
* @throws RemoteRuntimeException
*/
- public ProxyEventHandler(RemoteIdentifier myId, RemoteIdentifier remoteId, String remoteSinkName,
- EventHandler<RemoteEvent<T>> handler, RemoteSeqNumGenerator seqGen) {
+ public ProxyEventHandler(final RemoteIdentifier myId, final RemoteIdentifier remoteId, final String remoteSinkName,
+ final EventHandler<RemoteEvent<T>> handler, final RemoteSeqNumGenerator seqGen) {
LOG.log(Level.FINE, "ProxyEventHandler myId: {0} remoteId: {1} remoteSink: {2} handler: {3}",
new Object[]{myId, remoteId, remoteSinkName, handler});
if (!(myId instanceof SocketRemoteIdentifier && remoteId instanceof SocketRemoteIdentifier)) {
@@ -69,7 +69,7 @@ public class ProxyEventHandler<T> implements EventHandler<T> {
* @param event the event
*/
@Override
- public void onNext(T event) {
+ public void onNext(final T event) {
if (LOG.isLoggable(Level.FINE)) {
LOG.log(Level.FINE, "remoteid: {0}\n{1}", new Object[]{remoteId.getSocketAddress(), event.toString()});
}
@@ -83,7 +83,7 @@ public class ProxyEventHandler<T> implements EventHandler<T> {
* @return a string representation of the object
*/
public String toString() {
- StringBuilder builder = new StringBuilder();
+ final StringBuilder builder = new StringBuilder();
builder.append(this.getClass().getName());
builder.append(" remote_id=");
builder.append(remoteId.toString());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEvent.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEvent.java
index 51b35cd..b7e6dc3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEvent.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEvent.java
@@ -45,7 +45,8 @@ public class RemoteEvent<T> {
* @param seq the sequence number
* @param event the event
*/
- public RemoteEvent(SocketAddress localAddr, SocketAddress remoteAddr, String src, String sink, long seq, T event) {
+ public RemoteEvent(final SocketAddress localAddr, final SocketAddress remoteAddr, final String src,
+ final String sink, final long seq, final T event) {
this.localAddr = localAddr;
this.remoteAddr = remoteAddr;
this.src = src;
@@ -86,7 +87,7 @@ public class RemoteEvent<T> {
*
* @param name the source name
*/
- public void setSource(String name) {
+ public void setSource(final String name) {
src = name;
}
@@ -104,7 +105,7 @@ public class RemoteEvent<T> {
*
* @param name the sink name
*/
- public void setSink(String name) {
+ public void setSink(final String name) {
sink = name;
}
@@ -131,7 +132,7 @@ public class RemoteEvent<T> {
*
* @param addr the local socket address
*/
- public void setLocalAddress(SocketAddress addr) {
+ public void setLocalAddress(final SocketAddress addr) {
localAddr = addr;
}
@@ -140,7 +141,7 @@ public class RemoteEvent<T> {
*
* @param addr the remote socket address
*/
- public void setRemoteAddress(SocketAddress addr) {
+ public void setRemoteAddress(final SocketAddress addr) {
remoteAddr = addr;
}
@@ -150,7 +151,7 @@ public class RemoteEvent<T> {
* @return a string representation of this object
*/
public String toString() {
- StringBuilder builder = new StringBuilder();
+ final StringBuilder builder = new StringBuilder();
builder.append("RemoteEvent");
builder.append(" localAddr=");
builder.append(localAddr);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventCodec.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventCodec.java
index b2ca25f..b3e2023 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventCodec.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventCodec.java
@@ -35,7 +35,7 @@ public class RemoteEventCodec<T> implements Codec<RemoteEvent<T>> {
*
* @param codec the codec for the event
*/
- public RemoteEventCodec(Codec<T> codec) {
+ public RemoteEventCodec(final Codec<T> codec) {
encoder = new RemoteEventEncoder<T>(codec);
decoder = new RemoteEventDecoder<T>(codec);
}
@@ -47,7 +47,7 @@ public class RemoteEventCodec<T> implements Codec<RemoteEvent<T>> {
* @returns bytes
*/
@Override
- public byte[] encode(RemoteEvent<T> obj) {
+ public byte[] encode(final RemoteEvent<T> obj) {
return encoder.encode(obj);
}
@@ -58,7 +58,7 @@ public class RemoteEventCodec<T> implements Codec<RemoteEvent<T>> {
* @return a remote event object
*/
@Override
- public RemoteEvent<T> decode(byte[] data) {
+ public RemoteEvent<T> decode(final byte[] data) {
return decoder.decode(data);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventComparator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventComparator.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventComparator.java
index 83eb6ce..049b4d6 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventComparator.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventComparator.java
@@ -26,7 +26,7 @@ import java.util.Comparator;
public class RemoteEventComparator<T> implements Comparator<RemoteEvent<T>> {
@Override
- public int compare(RemoteEvent<T> o1, RemoteEvent<T> o2) {
+ public int compare(final RemoteEvent<T> o1, final RemoteEvent<T> o2) {
if (o1.getSeq() < o2.getSeq()) {
return -1;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventDecoder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventDecoder.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventDecoder.java
index 7abf64e..3ef0a27 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventDecoder.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventDecoder.java
@@ -37,7 +37,7 @@ public class RemoteEventDecoder<T> implements Decoder<RemoteEvent<T>> {
*
* @param decoder the decoder of the event
*/
- public RemoteEventDecoder(Decoder<T> decoder) {
+ public RemoteEventDecoder(final Decoder<T> decoder) {
this.decoder = decoder;
}
@@ -49,13 +49,13 @@ public class RemoteEventDecoder<T> implements Decoder<RemoteEvent<T>> {
* @throws RemoteRuntimeException
*/
@Override
- public RemoteEvent<T> decode(byte[] data) {
- WakeMessagePBuf pbuf;
+ public RemoteEvent<T> decode(final byte[] data) {
+ final WakeMessagePBuf pbuf;
try {
pbuf = WakeMessagePBuf.parseFrom(data);
return new RemoteEvent<T>(null, null, pbuf.getSource(), pbuf.getSink(), pbuf.getSeq(),
decoder.decode(pbuf.getData().toByteArray()));
- } catch (InvalidProtocolBufferException e) {
+ } catch (final InvalidProtocolBufferException e) {
throw new RemoteRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventEncoder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventEncoder.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventEncoder.java
index d5a777b..db0c78a 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventEncoder.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteEventEncoder.java
@@ -37,7 +37,7 @@ public class RemoteEventEncoder<T> implements Encoder<RemoteEvent<T>> {
*
* @param encoder the encoder of the event
*/
- public RemoteEventEncoder(Encoder<T> encoder) {
+ public RemoteEventEncoder(final Encoder<T> encoder) {
this.encoder = encoder;
}
@@ -49,7 +49,7 @@ public class RemoteEventEncoder<T> implements Encoder<RemoteEvent<T>> {
* @throws RemoteRuntimeException
*/
@Override
- public byte[] encode(RemoteEvent<T> obj) {
+ public byte[] encode(final RemoteEvent<T> obj) {
if (obj.getSink() == null) {
throw new RemoteRuntimeException("Sink stage is null");
}
@@ -57,8 +57,8 @@ public class RemoteEventEncoder<T> implements Encoder<RemoteEvent<T>> {
throw new RemoteRuntimeException("Event is null");
}
- WakeMessagePBuf.Builder builder = WakeMessagePBuf.newBuilder();
- String source = obj.getSource() == null ? "" : obj.getSource();
+ final WakeMessagePBuf.Builder builder = WakeMessagePBuf.newBuilder();
+ final String source = obj.getSource() == null ? "" : obj.getSource();
builder.setSource(source);
builder.setSink(obj.getSink());
builder.setSeq(obj.getSeq());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverEventHandler.java
index c75b30f..bbb1217 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverEventHandler.java
@@ -38,7 +38,7 @@ class RemoteReceiverEventHandler implements EventHandler<TransportEvent> {
*
* @param handler the upstream handler
*/
- RemoteReceiverEventHandler(EventHandler<RemoteEvent<byte[]>> handler) {
+ RemoteReceiverEventHandler(final EventHandler<RemoteEvent<byte[]>> handler) {
this.codec = new RemoteEventCodec<byte[]>(new ByteCodec());
this.handler = handler;
}
@@ -49,8 +49,8 @@ class RemoteReceiverEventHandler implements EventHandler<TransportEvent> {
* @param e the event
*/
@Override
- public void onNext(TransportEvent e) {
- RemoteEvent<byte[]> re = codec.decode(e.getData());
+ public void onNext(final TransportEvent e) {
+ final RemoteEvent<byte[]> re = codec.decode(e.getData());
re.setLocalAddress(e.getLocalAddress());
re.setRemoteAddress(e.getRemoteAddress());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverStage.java
index 1f19f3d..4ea47ce 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteReceiverStage.java
@@ -69,7 +69,7 @@ public class RemoteReceiverStage implements EStage<TransportEvent> {
* @param value the event
*/
@Override
- public void onNext(TransportEvent value) {
+ public void onNext(final TransportEvent value) {
LOG.log(Level.FINEST, "{0}", value);
stage.onNext(value);
}
@@ -87,7 +87,7 @@ public class RemoteReceiverStage implements EStage<TransportEvent> {
// wait for threads to finish for timeout
if (!executor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in {0} ms.", shutdownTimeout);
- List<Runnable> droppedRunnables = executor.shutdownNow();
+ final List<Runnable> droppedRunnables = executor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped {0} tasks.", droppedRunnables.size());
}
} catch (final InterruptedException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java
index 65b9461..057caac 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java
@@ -53,7 +53,7 @@ class RemoteSenderEventHandler<T> implements EventHandler<RemoteEvent<T>> {
* @param transport the transport to send events
* @param executor the executor service used for creating channels
*/
- RemoteSenderEventHandler(Encoder<T> encoder, Transport transport, ExecutorService executor) {
+ RemoteSenderEventHandler(final Encoder<T> encoder, final Transport transport, final ExecutorService executor) {
this.encoder = new RemoteEventEncoder<T>(encoder);
this.transport = transport;
this.executor = executor;
@@ -61,7 +61,7 @@ class RemoteSenderEventHandler<T> implements EventHandler<RemoteEvent<T>> {
this.queue = new LinkedBlockingQueue<RemoteEvent<T>>();
}
- void setLink(Link<byte[]> link) {
+ void setLink(final Link<byte[]> link) {
LOG.log(Level.FINEST, "thread {0} link {1}", new Object[]{Thread.currentThread(), link});
linkRef.compareAndSet(null, link);
consumeQueue();
@@ -74,7 +74,7 @@ class RemoteSenderEventHandler<T> implements EventHandler<RemoteEvent<T>> {
LOG.log(Level.FINEST, "{0}", event);
linkRef.get().write(encoder.encode(event));
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
throw new RemoteRuntimeException(e);
}
@@ -87,19 +87,19 @@ class RemoteSenderEventHandler<T> implements EventHandler<RemoteEvent<T>> {
* @throws RemoteRuntimeException
*/
@Override
- public void onNext(RemoteEvent<T> value) {
+ public void onNext(final RemoteEvent<T> value) {
try {
if (linkRef.get() == null) {
queue.add(value);
- Link<byte[]> link = transport.get(value.remoteAddress());
+ final Link<byte[]> link = transport.get(value.remoteAddress());
if (link != null) {
LOG.log(Level.FINEST, "transport get link: {0}", link);
setLink(link);
return;
}
- ConnectFutureTask<Link<byte[]>> cf = new ConnectFutureTask<Link<byte[]>>(
+ final ConnectFutureTask<Link<byte[]>> cf = new ConnectFutureTask<Link<byte[]>>(
new ConnectCallable(transport, value.localAddress(), value.remoteAddress()),
new ConnectEventHandler<T>(this));
executor.submit(cf);
@@ -113,7 +113,7 @@ class RemoteSenderEventHandler<T> implements EventHandler<RemoteEvent<T>> {
}
linkRef.get().write(encoder.encode(value));
}
- } catch (RemoteRuntimeException ex2) {
+ } catch (final RemoteRuntimeException ex2) {
ex2.printStackTrace();
throw ex2;
}
@@ -128,7 +128,7 @@ class ConnectCallable implements Callable<Link<byte[]>> {
private final SocketAddress localAddress;
private final SocketAddress remoteAddress;
- ConnectCallable(Transport transport, SocketAddress localAddress, SocketAddress remoteAddress) {
+ ConnectCallable(final Transport transport, final SocketAddress localAddress, final SocketAddress remoteAddress) {
this.transport = transport;
this.localAddress = localAddress;
this.remoteAddress = remoteAddress;
@@ -146,12 +146,12 @@ class ConnectEventHandler<T> implements EventHandler<ConnectFutureTask<Link<byte
private final RemoteSenderEventHandler<T> handler;
- ConnectEventHandler(RemoteSenderEventHandler<T> handler) {
+ ConnectEventHandler(final RemoteSenderEventHandler<T> handler) {
this.handler = handler;
}
@Override
- public void onNext(ConnectFutureTask<Link<byte[]>> value) {
+ public void onNext(final ConnectFutureTask<Link<byte[]>> value) {
try {
handler.setLink(value.get());
} catch (InterruptedException | ExecutionException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSeqNumGenerator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSeqNumGenerator.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSeqNumGenerator.java
index 5c38471..d30c8ee 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSeqNumGenerator.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSeqNumGenerator.java
@@ -35,7 +35,7 @@ public class RemoteSeqNumGenerator {
seqMap = new ConcurrentHashMap<SocketAddress, AtomicLong>();
}
- public long getNextSeq(SocketAddress addr) {
+ public long getNextSeq(final SocketAddress addr) {
AtomicLong seq = seqMap.get(addr);
if (seq == null) {
seq = new AtomicLong(0);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SocketRemoteIdentifier.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SocketRemoteIdentifier.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SocketRemoteIdentifier.java
index 1ae7478..0914813 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SocketRemoteIdentifier.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SocketRemoteIdentifier.java
@@ -35,7 +35,7 @@ public class SocketRemoteIdentifier implements RemoteIdentifier {
*
* @param addr the socket address
*/
- public SocketRemoteIdentifier(InetSocketAddress addr) {
+ public SocketRemoteIdentifier(final InetSocketAddress addr) {
this.addr = addr;
}
@@ -45,20 +45,20 @@ public class SocketRemoteIdentifier implements RemoteIdentifier {
* @param str the string representation
* @throws RemoteRuntimeException
*/
- public SocketRemoteIdentifier(String str) {
+ public SocketRemoteIdentifier(final String str) {
int index = str.indexOf("0:0:0:0:0:0:0:0:");
if (index >= 0) {
- String host = str.substring(0, 15);
- int port = Integer.parseInt(str.substring(index + 16));
+ final String host = str.substring(0, 15);
+ final int port = Integer.parseInt(str.substring(index + 16));
this.addr = new InetSocketAddress(host, port);
} else {
index = str.indexOf(":");
if (index <= 0) {
throw new RemoteRuntimeException("Invalid name " + str);
}
- String host = str.substring(0, index);
- int port = Integer.parseInt(str.substring(index + 1));
+ final String host = str.substring(0, index);
+ final int port = Integer.parseInt(str.substring(index + 1));
this.addr = new InetSocketAddress(host, port);
}
}
@@ -89,7 +89,7 @@ public class SocketRemoteIdentifier implements RemoteIdentifier {
* @return true if the object is the same as the object argument; false, otherwise
*/
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
return addr.equals(((SocketRemoteIdentifier) o).getSocketAddress());
}
@@ -100,7 +100,7 @@ public class SocketRemoteIdentifier implements RemoteIdentifier {
*/
@Override
public String toString() {
- StringBuilder builder = new StringBuilder();
+ final StringBuilder builder = new StringBuilder();
builder.append("socket://");
builder.append(addr.getHostString());
builder.append(":");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/StringCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/StringCodec.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/StringCodec.java
index 70f8403..d972a33 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/StringCodec.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/StringCodec.java
@@ -32,7 +32,7 @@ public class StringCodec implements Codec<String> {
* @return a byte array representation of the string
*/
@Override
- public byte[] encode(String obj) {
+ public byte[] encode(final String obj) {
return obj.getBytes();
}
@@ -43,7 +43,7 @@ public class StringCodec implements Codec<String> {
* @return a string
*/
@Override
- public String decode(byte[] buf) {
+ public String decode(final byte[] buf) {
return new String(buf);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Subscription.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Subscription.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Subscription.java
index b3e06e6..5ae498a 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Subscription.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Subscription.java
@@ -34,7 +34,7 @@ public class Subscription<T> implements AutoCloseable {
* @param token the token for finding the subscription
* @param handlerContainer the container managing handlers
*/
- public Subscription(T token, HandlerContainer<T> handlerContainer) {
+ public Subscription(final T token, final HandlerContainer<T> handlerContainer) {
this.token = token;
this.container = handlerContainer;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/TransportEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/TransportEvent.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/TransportEvent.java
index 3736017..5f6b15e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/TransportEvent.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/TransportEvent.java
@@ -39,7 +39,7 @@ public class TransportEvent {
* @param localAddr the local socket address
* @param remoteAddr the remote socket address
*/
- public TransportEvent(byte[] data, SocketAddress localAddr, SocketAddress remoteAddr) {
+ public TransportEvent(final byte[] data, final SocketAddress localAddr, final SocketAddress remoteAddr) {
this.data = data;
this.localAddr = localAddr;
this.remoteAddr = remoteAddr;
@@ -53,7 +53,7 @@ public class TransportEvent {
* @param data
* @param link
*/
- public TransportEvent(byte[] data, Link<byte[]> link) {
+ public TransportEvent(final byte[] data, final Link<byte[]> link) {
this.data = data;
this.link = link;
if (this.link != null) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Tuple2.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Tuple2.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Tuple2.java
index 334f319..13f1d71 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Tuple2.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/Tuple2.java
@@ -29,7 +29,7 @@ public class Tuple2<T1, T2> {
private final T1 t1;
private final T2 t2;
- public Tuple2(T1 t1, T2 t2) {
+ public Tuple2(final T1 t1, final T2 t2) {
this.t1 = t1;
this.t2 = t2;
}
@@ -48,8 +48,8 @@ public class Tuple2<T1, T2> {
}
@Override
- public boolean equals(Object o) {
- Tuple2<T1, T2> tuple = (Tuple2<T1, T2>) o;
+ public boolean equals(final Object o) {
+ final Tuple2<T1, T2> tuple = (Tuple2<T1, T2>) o;
return t1.equals((Object) tuple.getT1()) && t2.equals((Object) tuple.getT2());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RandomRangeIterator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RandomRangeIterator.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RandomRangeIterator.java
index 2cf4a7a..635b8c1 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RandomRangeIterator.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RandomRangeIterator.java
@@ -35,7 +35,7 @@ final class RandomRangeIterator implements Iterator<Integer> {
private int currentRetryCount;
private final Random random = new Random(System.currentTimeMillis());
- RandomRangeIterator(final int tcpPortRangeBegin, final int tcpPortRangeCount, int tryCount) {
+ RandomRangeIterator(final int tcpPortRangeBegin, final int tcpPortRangeCount, final int tryCount) {
this.tcpPortRangeBegin = tcpPortRangeBegin;
this.tcpPortRangeCount = tcpPortRangeCount;
this.tryCount = tryCount;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/exception/TransportRuntimeException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/exception/TransportRuntimeException.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/exception/TransportRuntimeException.java
index bddc167..d8c329b 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/exception/TransportRuntimeException.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/exception/TransportRuntimeException.java
@@ -30,7 +30,7 @@ public class TransportRuntimeException extends RuntimeException {
* @param s the detailed message
* @param e the cause
*/
- public TransportRuntimeException(String s, Throwable e) {
+ public TransportRuntimeException(final String s, final Throwable e) {
super(s, e);
}
@@ -39,7 +39,7 @@ public class TransportRuntimeException extends RuntimeException {
*
* @param s the detailed message
*/
- public TransportRuntimeException(String s) {
+ public TransportRuntimeException(final String s) {
super(s);
}
@@ -48,7 +48,7 @@ public class TransportRuntimeException extends RuntimeException {
*
* @param e the cause
*/
- public TransportRuntimeException(Throwable e) {
+ public TransportRuntimeException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
index 7d77b76..8dea218 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
@@ -54,7 +54,7 @@ abstract class AbstractNettyEventListener implements NettyEventListener {
}
@Override
- public void channelRead(ChannelHandlerContext ctx, Object msg) {
+ public void channelRead(final ChannelHandlerContext ctx, final Object msg) {
final Channel channel = ctx.channel();
final byte[] message = (byte[]) msg;
@@ -70,7 +70,7 @@ abstract class AbstractNettyEventListener implements NettyEventListener {
}
@Override
- public void exceptionCaught(final ChannelHandlerContext ctx, Throwable cause) {
+ public void exceptionCaught(final ChannelHandlerContext ctx, final Throwable cause) {
final Channel channel = ctx.channel();
LOG.log(Level.WARNING, "ExceptionEvent: local: {0} remote: {1} :: {2}", new Object[]{
channel.localAddress(), channel.remoteAddress(), cause});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ByteEncoder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ByteEncoder.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ByteEncoder.java
index 2536ea5..0cca5e1 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ByteEncoder.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ByteEncoder.java
@@ -29,7 +29,7 @@ public class ByteEncoder implements Encoder<byte[]> {
* @see org.apache.reef.wake.remote.Encoder#encode(java.lang.Object)
*/
@Override
- public byte[] encode(byte[] obj) {
+ public byte[] encode(final byte[] obj) {
return obj;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
index df15f87..f55bbeb 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
@@ -64,11 +64,11 @@ public class ChunkedReadWriteHandler extends ChunkedWriteHandler {
* org.jboss.netty.channel.ChannelHandlerContext, org.jboss.netty.channel.ChannelEvent)
*/
@Override
- public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
+ public void channelRead(final ChannelHandlerContext ctx, final Object msg) throws Exception {
if (msg instanceof byte[]) {
- byte[] data = (byte[]) msg;
+ final byte[] data = (byte[]) msg;
if (start) {
//LOG.log(Level.FINEST, "{0} Starting dechunking of a chunked write", curThrName);
@@ -93,7 +93,7 @@ public class ChunkedReadWriteHandler extends ChunkedWriteHandler {
// "Creating upstream msg event with the dechunked byte[{1}]", new Object[]{curThrName, expectedSize});
//if (LOG.isLoggable(Level.FINEST)) LOG.log(Level.FINEST, "Resetting state to begin another dechunking",
// curThrName);
- byte[] temp = retArr;
+ final byte[] temp = retArr;
start = true;
expectedSize = 0;
readBuffer.release();
@@ -117,7 +117,7 @@ public class ChunkedReadWriteHandler extends ChunkedWriteHandler {
* the second begins.
*/
@Override
- public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) throws Exception {
+ public void write(final ChannelHandlerContext ctx, final Object msg, final ChannelPromise promise) throws Exception {
if (msg instanceof ByteBuf) {
@@ -183,7 +183,7 @@ public class ChunkedReadWriteHandler extends ChunkedWriteHandler {
private class ByteBufCloseableStream extends ByteBufInputStream {
private final ByteBuf buffer;
- public ByteBufCloseableStream(ByteBuf buffer) {
+ public ByteBufCloseableStream(final ByteBuf buffer) {
super(buffer);
this.buffer = buffer;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
index a9634a6..4c6626c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
@@ -37,7 +37,7 @@ public class LoggingLinkListener<T> implements LinkListener<T> {
* Called when the sent message is transferred successfully.
*/
@Override
- public void onSuccess(T message) {
+ public void onSuccess(final T message) {
if (LOG.isLoggable(Level.FINEST)) {
LOG.log(Level.FINEST, "The message is successfully sent : {0}", new Object[]{message});
}
@@ -47,7 +47,7 @@ public class LoggingLinkListener<T> implements LinkListener<T> {
* Called when the sent message to remoteAddress is failed to be transferred.
*/
@Override
- public void onException(Throwable cause, SocketAddress remoteAddress, T message) {
+ public void onException(final Throwable cause, final SocketAddress remoteAddress, final T message) {
if (LOG.isLoggable(Level.FINEST)) {
LOG.log(Level.FINEST, "The message to {0} is failed to be sent. message : {1}, cause : {2}"
, new Object[]{remoteAddress, message, cause});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
index 8921486..5b8191c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
@@ -73,7 +73,7 @@ public class MessagingTransportFactory implements TransportFactory {
final EventHandler<TransportEvent> serverHandler,
final EventHandler<Exception> exHandler) {
- Injector injector = Tang.Factory.getTang().newInjector();
+ final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(RemoteConfiguration.HostAddress.class, this.localAddress);
injector.bindVolatileParameter(RemoteConfiguration.Port.class, port);
injector.bindVolatileParameter(RemoteConfiguration.RemoteClientStage.class, new SyncStage<>(clientHandler));
@@ -84,13 +84,13 @@ public class MessagingTransportFactory implements TransportFactory {
transport = injector.getInstance(NettyMessagingTransport.class);
transport.registerErrorHandler(exHandler);
return transport;
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
}
@Override
- public Transport newInstance(final String hostAddress, int port,
+ public Transport newInstance(final String hostAddress, final int port,
final EStage<TransportEvent> clientStage,
final EStage<TransportEvent> serverStage,
final int numberOfTries,
@@ -100,14 +100,14 @@ public class MessagingTransportFactory implements TransportFactory {
}
@Override
- public Transport newInstance(final String hostAddress, int port,
+ public Transport newInstance(final String hostAddress, final int port,
final EStage<TransportEvent> clientStage,
final EStage<TransportEvent> serverStage,
final int numberOfTries,
final int retryTimeout,
final TcpPortProvider tcpPortProvider) {
- Injector injector = Tang.Factory.getTang().newInjector();
+ final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(RemoteConfiguration.HostAddress.class, hostAddress);
injector.bindVolatileParameter(RemoteConfiguration.Port.class, port);
injector.bindVolatileParameter(RemoteConfiguration.RemoteClientStage.class, clientStage);
@@ -117,7 +117,7 @@ public class MessagingTransportFactory implements TransportFactory {
injector.bindVolatileInstance(TcpPortProvider.class, tcpPortProvider);
try {
return injector.getInstance(NettyMessagingTransport.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
index 0f00ea7..011b9c2 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
@@ -40,7 +40,7 @@ class NettyChannelInitializer extends ChannelInitializer<SocketChannel> {
}
@Override
- protected void initChannel(SocketChannel ch) throws Exception {
+ protected void initChannel(final SocketChannel ch) throws Exception {
ch.pipeline()
.addLast("frameDecoder", new LengthFieldBasedFrameDecoder(MAXFRAMELENGTH, 0, 4, 0, 4))
.addLast("bytesDecoder", new ByteArrayDecoder())
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyLink.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyLink.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyLink.java
index cb80c7f..833ad3c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyLink.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyLink.java
@@ -77,7 +77,7 @@ public class NettyLink<T> implements Link<T> {
@Override
public void write(final T message) {
LOG.log(Level.FINEST, "write {0} {1}", new Object[]{channel, message});
- byte[] allData = encoder.encode(message);
+ final byte[] allData = encoder.encode(message);
// byte[] -> ByteBuf
if (listener != null) {
channel.writeAndFlush(Unpooled.wrappedBuffer(allData))
@@ -124,7 +124,7 @@ class NettyChannelFutureListener<T> implements ChannelFutureListener {
}
@Override
- public void operationComplete(ChannelFuture channelFuture) throws Exception {
+ public void operationComplete(final ChannelFuture channelFuture) throws Exception {
if (channelFuture.isSuccess()) {
listener.onSuccess(message);
} else {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyMessagingTransport.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyMessagingTransport.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyMessagingTransport.java
index 33d7137..828a10b 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyMessagingTransport.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyMessagingTransport.java
@@ -114,7 +114,7 @@ public class NettyMessagingTransport implements Transport {
@Deprecated
public NettyMessagingTransport(
final String hostAddress,
- int port,
+ final int port,
final EStage<TransportEvent> clientStage,
final EStage<TransportEvent> serverStage,
final int numberOfTries,
@@ -138,7 +138,7 @@ public class NettyMessagingTransport implements Transport {
@Inject
NettyMessagingTransport(
@Parameter(RemoteConfiguration.HostAddress.class) final String hostAddress,
- @Parameter(RemoteConfiguration.Port.class) int port,
+ @Parameter(RemoteConfiguration.Port.class) final int port,
@Parameter(RemoteConfiguration.RemoteClientStage.class) final EStage<TransportEvent> clientStage,
@Parameter(RemoteConfiguration.RemoteServerStage.class) final EStage<TransportEvent> serverStage,
@Parameter(RemoteConfiguration.NumberOfTries.class) final int numberOfTries,
@@ -146,8 +146,9 @@ public class NettyMessagingTransport implements Transport {
final TcpPortProvider tcpPortProvider,
final LocalAddressProvider localAddressProvider) {
- if (port < 0) {
- throw new RemoteRuntimeException("Invalid server port: " + port);
+ int p = port;
+ if (p < 0) {
+ throw new RemoteRuntimeException("Invalid server port: " + p);
}
final String host = UNKNOWN_HOST_NAME.equals(hostAddress) ? localAddressProvider.getLocalAddress() : hostAddress;
@@ -181,25 +182,25 @@ public class NettyMessagingTransport implements Transport {
.option(ChannelOption.SO_REUSEADDR, true)
.childOption(ChannelOption.SO_KEEPALIVE, true);
- LOG.log(Level.FINE, "Binding to {0}", port);
+ LOG.log(Level.FINE, "Binding to {0}", p);
Channel acceptorFound = null;
try {
- if (port > 0) {
- acceptorFound = this.serverBootstrap.bind(new InetSocketAddress(host, port)).sync().channel();
+ if (p > 0) {
+ acceptorFound = this.serverBootstrap.bind(new InetSocketAddress(host, p)).sync().channel();
} else {
- Iterator<Integer> ports = tcpPortProvider.iterator();
+ final Iterator<Integer> ports = tcpPortProvider.iterator();
while (acceptorFound == null) {
if (!ports.hasNext()) {
break;
}
- port = ports.next();
- LOG.log(Level.FINEST, "Try port {0}", port);
+ p = ports.next();
+ LOG.log(Level.FINEST, "Try port {0}", p);
try {
- acceptorFound = this.serverBootstrap.bind(new InetSocketAddress(host, port)).sync().channel();
+ acceptorFound = this.serverBootstrap.bind(new InetSocketAddress(host, p)).sync().channel();
} catch (final Exception ex) {
if (ex instanceof BindException) {
- LOG.log(Level.FINEST, "The port {0} is already bound. Try again", port);
+ LOG.log(Level.FINEST, "The port {0} is already bound. Try again", p);
} else {
throw ex;
}
@@ -208,8 +209,8 @@ public class NettyMessagingTransport implements Transport {
}
} catch (final Exception ex) {
final RuntimeException transportException =
- new TransportRuntimeException("Cannot bind to port " + port);
- LOG.log(Level.SEVERE, "Cannot bind to port " + port, ex);
+ new TransportRuntimeException("Cannot bind to port " + p);
+ LOG.log(Level.SEVERE, "Cannot bind to port " + p, ex);
this.clientWorkerGroup.shutdownGracefully();
this.serverBossGroup.shutdownGracefully();
@@ -218,7 +219,7 @@ public class NettyMessagingTransport implements Transport {
}
this.acceptor = acceptorFound;
- this.serverPort = port;
+ this.serverPort = p;
this.localAddress = new InetSocketAddress(host, this.serverPort);
LOG.log(Level.FINE, "Starting netty transport socket address: {0}", this.localAddress);
@@ -236,7 +237,7 @@ public class NettyMessagingTransport implements Transport {
* @deprecated use the constructor that takes a TcpProvider and LocalAddressProvider instead.
*/
@Deprecated
- public NettyMessagingTransport(final String hostAddress, int port,
+ public NettyMessagingTransport(final String hostAddress, final int port,
final EStage<TransportEvent> clientStage,
final EStage<TransportEvent> serverStage,
final int numberOfTries,
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/AbstractRxStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/AbstractRxStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/AbstractRxStage.java
index a03a9a4..e076552 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/AbstractRxStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/AbstractRxStage.java
@@ -39,7 +39,7 @@ public abstract class AbstractRxStage<T> implements RxStage<T> {
*
* @param stageName the stage name
*/
- public AbstractRxStage(String stageName) {
+ public AbstractRxStage(final String stageName) {
this.closed = new AtomicBoolean(false);
this.name = stageName;
this.inMeter = new Meter(stageName + "_in");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxSyncStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxSyncStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxSyncStage.java
index e287e27..d3ecd8a 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxSyncStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxSyncStage.java
@@ -53,8 +53,8 @@ public final class RxSyncStage<T> extends AbstractRxStage<T> {
* @param observer the observer
*/
@Inject
- public RxSyncStage(@Parameter(StageName.class) String name,
- @Parameter(StageObserver.class) Observer<T> observer) {
+ public RxSyncStage(@Parameter(StageName.class) final String name,
+ @Parameter(StageObserver.class) final Observer<T> observer) {
super(name);
this.observer = observer;
StageManager.instance().register(this);
@@ -66,7 +66,7 @@ public final class RxSyncStage<T> extends AbstractRxStage<T> {
* @param value the new value
*/
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
beforeOnNext();
observer.onNext(value);
afterOnNext();
@@ -79,7 +79,7 @@ public final class RxSyncStage<T> extends AbstractRxStage<T> {
* @param error the error
*/
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
observer.onError(error);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxThreadPoolStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxThreadPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxThreadPoolStage.java
index 82d1208..01142b3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxThreadPoolStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/RxThreadPoolStage.java
@@ -156,7 +156,7 @@ public final class RxThreadPoolStage<T> extends AbstractRxStage<T> {
LOG.log(Level.SEVERE, "Executor terminated due to unrequired timeout");
observer.onError(new TimeoutException());
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
observer.onError(e);
}
@@ -177,12 +177,12 @@ public final class RxThreadPoolStage<T> extends AbstractRxStage<T> {
completionExecutor.shutdown();
if (!executor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = executor.shutdownNow();
+ final List<Runnable> droppedRunnables = executor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
if (!completionExecutor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = completionExecutor.shutdownNow();
+ final List<Runnable> droppedRunnables = completionExecutor.shutdownNow();
LOG.log(Level.WARNING, "Completion executor dropped " + droppedRunnables.size() + " tasks.");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/SimpleSubject.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/SimpleSubject.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/SimpleSubject.java
index 62e2259..c83850c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/SimpleSubject.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/SimpleSubject.java
@@ -38,7 +38,7 @@ public class SimpleSubject<T> implements Subject<T, T> {
* @param observer the observer
*/
@Inject
- public SimpleSubject(Observer<T> observer) {
+ public SimpleSubject(final Observer<T> observer) {
this.observer = observer;
}
@@ -48,7 +48,7 @@ public class SimpleSubject<T> implements Subject<T, T> {
* @param value the new value
*/
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
this.observer.onNext(value);
}
@@ -58,7 +58,7 @@ public class SimpleSubject<T> implements Subject<T, T> {
* @param error the error
*/
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
this.observer.onError(error);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/TimeoutSubject.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/TimeoutSubject.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/TimeoutSubject.java
index 5d2d3c9..e43b681 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/TimeoutSubject.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/impl/TimeoutSubject.java
@@ -35,12 +35,12 @@ public class TimeoutSubject<T> implements Subject<T, T> {
this.timeBomb = new Thread(new Runnable() {
@Override
public void run() {
- boolean finishedCopy;
+ final boolean finishedCopy;
synchronized (outer) {
if (!finished) {
try {
outer.wait(timeout);
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
return;
}
}
@@ -56,8 +56,8 @@ public class TimeoutSubject<T> implements Subject<T, T> {
}
@Override
- public void onNext(T value) {
- boolean wasFinished;
+ public void onNext(final T value) {
+ final boolean wasFinished;
synchronized (this) {
wasFinished = finished;
if (!finished) {
@@ -73,7 +73,7 @@ public class TimeoutSubject<T> implements Subject<T, T> {
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
this.timeBomb.interrupt();
destination.onError(error);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileHandlePool.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileHandlePool.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileHandlePool.java
index c28c22a..a0779ae 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileHandlePool.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileHandlePool.java
@@ -21,11 +21,11 @@ package org.apache.reef.wake.storage;
import java.io.FileInputStream;
public class FileHandlePool {
- public FileInputStream get(StorageIdentifier f) {
+ public FileInputStream get(final StorageIdentifier f) {
return null;
}
- public void release(StorageIdentifier f, FileInputStream is) {
+ public void release(final StorageIdentifier f, final FileInputStream is) {
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileIdentifier.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileIdentifier.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileIdentifier.java
index 5071196..ac980c3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileIdentifier.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/FileIdentifier.java
@@ -25,7 +25,7 @@ import java.net.URISyntaxException;
public class FileIdentifier implements StorageIdentifier {
private final File f;
- public FileIdentifier(String s) throws URISyntaxException {
+ public FileIdentifier(final String s) throws URISyntaxException {
f = new File(new URI(s));
}
@@ -35,7 +35,7 @@ public class FileIdentifier implements StorageIdentifier {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (!(o instanceof FileIdentifier)) {
return false;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/ReadRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/ReadRequest.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/ReadRequest.java
index e84e483..2221f74 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/ReadRequest.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/ReadRequest.java
@@ -27,7 +27,7 @@ public class ReadRequest implements Identifiable {
final byte[] buf;
final Identifier id;
- public ReadRequest(StorageIdentifier f, long offset, byte[] buf, Identifier id) {
+ public ReadRequest(final StorageIdentifier f, final long offset, final byte[] buf, final Identifier id) {
this.f = f;
this.offset = offset;
this.buf = buf;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/SequentialFileReader.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/SequentialFileReader.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/SequentialFileReader.java
index e52f562..a864f53 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/SequentialFileReader.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/storage/SequentialFileReader.java
@@ -29,22 +29,22 @@ public class SequentialFileReader implements EStage<ReadRequest> {
final FileHandlePool fdPool = new FileHandlePool();
@Override
- public void onNext(ReadRequest value) {
- FileInputStream fin = fdPool.get(value.f);
+ public void onNext(final ReadRequest value) {
+ final FileInputStream fin = fdPool.get(value.f);
int readSoFar = 0;
try {
synchronized (fin) {
fin.reset();
fin.skip(value.offset);
while (readSoFar != value.buf.length) {
- int ret = fin.read(value.buf, readSoFar, value.buf.length);
+ final int ret = fin.read(value.buf, readSoFar, value.buf.length);
if (ret == -1) {
break;
}
readSoFar += ret;
}
}
- } catch (IOException e) {
+ } catch (final IOException e) {
fdPool.release(value.f, fin);
// err.onNext(null); //new ReadError(e));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Time.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Time.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Time.java
index a174461..44e90b5 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Time.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Time.java
@@ -39,7 +39,7 @@ public abstract class Time implements Comparable<Time> {
}
@Override
- public final int compareTo(Time o) {
+ public final int compareTo(final Time o) {
if (this.timestamp < o.timestamp) {
return -1;
}
@@ -56,7 +56,7 @@ public abstract class Time implements Comparable<Time> {
}
@Override
- public final boolean equals(Object o) {
+ public final boolean equals(final Object o) {
if (o instanceof Time) {
return compareTo((Time) o) == 0;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/LogicalTimer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/LogicalTimer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/LogicalTimer.java
index cc6bee9..6ffbce8 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/LogicalTimer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/LogicalTimer.java
@@ -34,13 +34,13 @@ public final class LogicalTimer implements Timer {
}
@Override
- public long getDuration(long time) {
+ public long getDuration(final long time) {
isReady(time);
return 0;
}
@Override
- public boolean isReady(long time) {
+ public boolean isReady(final long time) {
if (this.current < time) {
this.current = time;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
index 6b162bc..65c75ac 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java
@@ -136,7 +136,7 @@ public final class RuntimeClock implements Clock {
*/
private long findAcceptableStopTime() {
long time = timer.getCurrent();
- for (Time t : this.schedule) {
+ for (final Time t : this.schedule) {
if (t instanceof ClientAlarm) {
assert (time <= t.getTimeStamp());
time = t.getTimeStamp();
@@ -149,7 +149,7 @@ public final class RuntimeClock implements Clock {
@Override
public boolean isIdle() {
synchronized (this.schedule) {
- for (Time t : this.schedule) {
+ for (final Time t : this.schedule) {
if (t instanceof ClientAlarm) {
return false;
}
@@ -237,12 +237,12 @@ public final class RuntimeClock implements Clock {
break; // we're done.
}
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
// waiting interrupted - return to loop
}
}
this.handlers.onNext(new RuntimeStop(this.timer.getCurrent()));
- } catch (Exception e) {
+ } catch (final Exception e) {
e.printStackTrace();
this.handlers.onNext(new RuntimeStop(this.timer.getCurrent(), e));
} finally {
[10/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java
index 1cc685a..a0a80f2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/MergingIterator.java
@@ -28,12 +28,12 @@ import java.util.PriorityQueue;
public class MergingIterator<T> implements Iterator<T> {
private final PriorityQueue<Tuple<T, Iterator<T>>> heap;
- public MergingIterator(final Comparator<T> c, Iterator<T>[] its) {
+ public MergingIterator(final Comparator<T> c, final Iterator<T>[] its) {
this.heap = new PriorityQueue<Tuple<T, Iterator<T>>>(11,
new TupleKeyComparator<T, Iterator<T>>(c));
- for (Iterator<T> it : its) {
- T b = it.hasNext() ? it.next() : null;
+ for (final Iterator<T> it : its) {
+ final T b = it.hasNext() ? it.next() : null;
if (b != null) {
heap.add(new Tuple<>(b, it));
}
@@ -47,7 +47,7 @@ public class MergingIterator<T> implements Iterator<T> {
@Override
public T next() {
- Tuple<T, Iterator<T>> ret = heap.remove();
+ final Tuple<T, Iterator<T>> ret = heap.remove();
if (ret.getValue().hasNext()) {
heap.add(new Tuple<>(ret.getValue().next(), ret.getValue()));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java
index feee1e9..a3ea45f 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalScratchSpace.java
@@ -35,13 +35,13 @@ public class LocalScratchSpace implements ScratchSpace {
*/
private long quota;
- public LocalScratchSpace(String jobName, String evaluatorName) {
+ public LocalScratchSpace(final String jobName, final String evaluatorName) {
this.jobName = jobName;
this.evaluatorName = evaluatorName;
this.quota = 0;
}
- public LocalScratchSpace(String jobName, String evaluatorName, long quota) {
+ public LocalScratchSpace(final String jobName, final String evaluatorName, final long quota) {
this.jobName = jobName;
this.evaluatorName = evaluatorName;
this.quota = quota;
@@ -52,7 +52,7 @@ public class LocalScratchSpace implements ScratchSpace {
try {
ret = File.createTempFile("reef-" + jobName + "-" + evaluatorName,
"tmp");
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
tempFiles.add(ret);
@@ -67,7 +67,7 @@ public class LocalScratchSpace implements ScratchSpace {
@Override
public long usedSpace() {
long ret = 0;
- for (File f : tempFiles) {
+ for (final File f : tempFiles) {
// TODO: Error handling...
ret += f.length();
}
@@ -78,7 +78,7 @@ public class LocalScratchSpace implements ScratchSpace {
public void delete() {
// TODO: Error handling. Files.delete() would give us an exception. We
// should pass a set of Exceptions into a ReefRuntimeException.
- for (File f : tempFiles) {
+ for (final File f : tempFiles) {
f.delete();
}
tempFiles.clear();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java
index 3dc55c3..f51b657 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/LocalStorageService.java
@@ -29,7 +29,7 @@ public class LocalStorageService implements StorageService {
private final LocalScratchSpace scratchSpace;
- public LocalStorageService(String jobName, String evaluatorName) {
+ public LocalStorageService(final String jobName, final String evaluatorName) {
this.jobName = jobName;
this.evaluatorName = evaluatorName;
this.scratchSpace = new LocalScratchSpace(jobName, evaluatorName);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java
index aa46aa7..fd77c36 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/SerializerFileSpool.java
@@ -47,7 +47,7 @@ public final class SerializerFileSpool<T> implements Spool<T> {
final Serializer<T, OutputStream> out, final Deserializer<T, InputStream> in)
throws ServiceException {
this.file = service.getScratchSpace().newFile();
- Accumulable<T> accumulable;
+ final Accumulable<T> accumulable;
try {
accumulable = out.create(new BufferedOutputStream(new FileOutputStream(
file)));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java
index d93750e..b4885a5 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java
@@ -36,7 +36,7 @@ public class CodecRamMap<T> implements ExternalMap<T> {
private final ConcurrentSkipListMap<CharSequence, byte[]> map;
@Inject
- public CodecRamMap(RamStorageService ramStore,
+ public CodecRamMap(final RamStorageService ramStore,
@Parameter(RamMapCodec.class) final Codec<T> c) {
this.c = c;
this.map = new ConcurrentSkipListMap<CharSequence, byte[]>();
@@ -54,7 +54,7 @@ public class CodecRamMap<T> implements ExternalMap<T> {
}
@Override
- public T put(final CharSequence key, T value) {
+ public T put(final CharSequence key, final T value) {
final byte[] ret = map.put(key, c.encode(value));
return ret != null ? c.decode(ret) : null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java
index 5c3e14c..5636c9e 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamMap.java
@@ -37,36 +37,36 @@ public class RamMap<T> implements ExternalMap<T> {
private final ConcurrentSkipListMap<CharSequence, T> map = new ConcurrentSkipListMap<CharSequence, T>();
@Inject
- public RamMap(RamStorageService ramStore) {
+ public RamMap(final RamStorageService ramStore) {
}
@Override
- public boolean containsKey(CharSequence key) {
+ public boolean containsKey(final CharSequence key) {
return map.containsKey(key);
}
@Override
- public T get(CharSequence key) {
+ public T get(final CharSequence key) {
return map.get(key);
}
@Override
- public T put(CharSequence key, T value) {
+ public T put(final CharSequence key, final T value) {
return map.put(key, value);
}
@Override
- public T remove(CharSequence key) {
+ public T remove(final CharSequence key) {
return map.remove(key);
}
@Override
- public void putAll(Map<? extends CharSequence, ? extends T> m) {
+ public void putAll(final Map<? extends CharSequence, ? extends T> m) {
map.putAll(m);
}
@Override
- public Iterable<Entry<CharSequence, T>> getAll(Set<? extends CharSequence> keys) {
+ public Iterable<Entry<CharSequence, T>> getAll(final Set<? extends CharSequence> keys) {
return new GetAllIterable<>(keys, this);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java
index 8b7f9eb..1b82739 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/RamSpool.java
@@ -39,7 +39,7 @@ public final class RamSpool<T> implements Spool<T> {
private boolean canGetAccumulator = true;
@Inject
- public RamSpool(RamStorageService ramStore) {
+ public RamSpool(final RamStorageService ramStore) {
}
@Override
@@ -56,7 +56,7 @@ public final class RamSpool<T> implements Spool<T> {
canGetAccumulator = false;
return new Accumulator<T>() {
@Override
- public void add(T datum) {
+ public void add(final T datum) {
if (!canAppend) {
throw new ConcurrentModificationException("Attempt to append after creating iterator!");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java
index 1ba55f4..b8c4711 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/SortingRamSpool.java
@@ -31,7 +31,7 @@ public class SortingRamSpool<T> implements Spool<T> {
private boolean ready = false;
private Accumulator<T> acc = new Accumulator<T>() {
@Override
- public void add(T datum) throws StorageException {
+ public void add(final T datum) throws StorageException {
if (ready) {
throw new IllegalStateException("add called after close!");
}
@@ -67,7 +67,7 @@ public class SortingRamSpool<T> implements Spool<T> {
heap = new PriorityQueue<>();
}
- public SortingRamSpool(Comparator<T> c) {
+ public SortingRamSpool(final Comparator<T> c) {
heap = new PriorityQueue<>(11, c);
}
@@ -76,14 +76,14 @@ public class SortingRamSpool<T> implements Spool<T> {
if (!ready) {
throw new IllegalStateException("Cannot call iterator() while accumulator is still open!");
}
- Iterator<T> ret = it;
+ final Iterator<T> ret = it;
it = null;
return ret;
}
@Override
public Accumulator<T> accumulator() throws StorageException {
- Accumulator<T> ret = acc;
+ final Accumulator<T> ret = acc;
acc = null;
return ret;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java
index 8be1b37..a8d1665 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/GetAllIterable.java
@@ -30,7 +30,7 @@ public class GetAllIterable<T> implements
private final Set<? extends CharSequence> keys;
private final ExternalMap<T> map;
- public GetAllIterable(Set<? extends CharSequence> keys, ExternalMap<T> map) {
+ public GetAllIterable(final Set<? extends CharSequence> keys, final ExternalMap<T> map) {
this.keys = keys;
this.map = map;
}
@@ -44,7 +44,7 @@ public class GetAllIterable<T> implements
private CharSequence findNextKey() {
while (k.hasNext()) {
- CharSequence next = k.next();
+ final CharSequence next = k.next();
if (map.containsKey(next)) {
return next;
}
@@ -80,7 +80,7 @@ public class GetAllIterable<T> implements
}
@Override
- public T setValue(T v) {
+ public T setValue(final T v) {
throw new UnsupportedOperationException(
"No support for mutating values via iterator");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java
index 65d760d..94b496a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerCodec.java
@@ -23,12 +23,12 @@ import org.apache.reef.io.serialization.Codec;
public class IntegerCodec implements Codec<Integer> {
@Override
- public byte[] encode(Integer obj) {
+ public byte[] encode(final Integer obj) {
return Integer.toString(obj).getBytes();
}
@Override
- public Integer decode(byte[] buf) {
+ public Integer decode(final byte[] buf) {
return Integer.decode(new String(buf));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java
index 1d81111..a404bed 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerDeserializer.java
@@ -29,7 +29,7 @@ import java.util.Iterator;
public class IntegerDeserializer implements
Deserializer<Integer, InputStream> {
@Override
- public Iterable<Integer> create(InputStream arg) {
+ public Iterable<Integer> create(final InputStream arg) {
final DataInputStream dis = new DataInputStream(arg);
return new Iterable<Integer>() {
@@ -46,7 +46,7 @@ public class IntegerDeserializer implements
public Integer next() {
try {
return dis.readInt();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java
index 4b27f7c..44b4eff 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/IntegerSerializer.java
@@ -30,7 +30,7 @@ import java.io.OutputStream;
public class IntegerSerializer implements
Serializer<Integer, OutputStream> {
@Override
- public Accumulable<Integer> create(OutputStream arg) {
+ public Accumulable<Integer> create(final OutputStream arg) {
final DataOutputStream dos = new DataOutputStream(arg);
return new Accumulable<Integer>() {
@@ -38,10 +38,10 @@ public class IntegerSerializer implements
public Accumulator<Integer> accumulator() throws ServiceException {
return new Accumulator<Integer>() {
@Override
- public void add(Integer datum) throws ServiceException {
+ public void add(final Integer datum) throws ServiceException {
try {
dos.writeInt(datum);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
}
@@ -50,7 +50,7 @@ public class IntegerSerializer implements
public void close() throws ServiceException {
try {
dos.close();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java
index 5f0c31a..1016016 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringDeserializer.java
@@ -29,7 +29,7 @@ import java.util.Iterator;
public class StringDeserializer implements
Deserializer<String, InputStream> {
@Override
- public Iterable<String> create(InputStream arg) {
+ public Iterable<String> create(final InputStream arg) {
final DataInputStream dis = new DataInputStream(arg);
return new Iterable<String>() {
@@ -47,10 +47,10 @@ public class StringDeserializer implements
int len = 0;
try {
len = dis.readInt();
- byte[] b = new byte[len];
+ final byte[] b = new byte[len];
dis.readFully(b);
return new String(b);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java
index da06486..cc61ea6 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/StringSerializer.java
@@ -30,7 +30,7 @@ import java.io.OutputStream;
public class StringSerializer implements
Serializer<String, OutputStream> {
@Override
- public Accumulable<String> create(OutputStream arg) {
+ public Accumulable<String> create(final OutputStream arg) {
final DataOutputStream dos = new DataOutputStream(arg);
return new Accumulable<String>() {
@@ -39,12 +39,12 @@ public class StringSerializer implements
return new Accumulator<String>() {
@Override
- public void add(String datum) throws ServiceException {
- byte[] b = datum.getBytes();
+ public void add(final String datum) throws ServiceException {
+ final byte[] b = datum.getBytes();
try {
dos.writeInt(b.length);
dos.write(b);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
@@ -54,7 +54,7 @@ public class StringSerializer implements
public void close() throws ServiceException {
try {
dos.close();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java
index 8951e4a..13c2b15 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/util/TupleKeyComparator.java
@@ -26,12 +26,12 @@ public final class TupleKeyComparator<K, V> implements
Comparator<Tuple<K, V>> {
private final Comparator<K> c;
- public TupleKeyComparator(Comparator<K> c) {
+ public TupleKeyComparator(final Comparator<K> c) {
this.c = c;
}
@Override
- public int compare(Tuple<K, V> o1, Tuple<K, V> o2) {
+ public int compare(final Tuple<K, V> o1, final Tuple<K, V> o2) {
return c.compare(o1.getKey(), o2.getKey());
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java
index d4afd3e..a0b7997 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NameClientTest.java
@@ -50,11 +50,11 @@ public class NameClientTest {
static int retryCount, retryTimeout;
static {
- Tang tang = Tang.Factory.getTang();
+ final Tang tang = Tang.Factory.getTang();
try {
retryCount = tang.newInjector().getNamedInstance(NameResolverRetryCount.class);
retryTimeout = tang.newInjector().getNamedInstance(NameResolverRetryTimeout.class);
- } catch (InjectionException e1) {
+ } catch (final InjectionException e1) {
throw new RuntimeException("Exception while trying to find default values for retryCount & Timeout", e1);
}
}
@@ -87,7 +87,7 @@ public class NameClientTest {
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
try (final NameServer server = injector.getInstance(NameServer.class)) {
- int serverPort = server.getPort();
+ final int serverPort = server.getPort();
final Configuration nameResolverConf = NameResolverConfiguration.CONF
.set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress)
.set(NameResolverConfiguration.NAME_SERVICE_PORT, serverPort)
@@ -122,7 +122,7 @@ public class NameClientTest {
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
try (final NameServer server = injector.getInstance(NameServer.class)) {
- int serverPort = server.getPort();
+ final int serverPort = server.getPort();
final Configuration nameResolverConf = NameResolverConfiguration.CONF
.set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress)
.set(NameResolverConfiguration.NAME_SERVICE_PORT, serverPort)
@@ -147,7 +147,7 @@ public class NameClientTest {
//resulting in NamingException and the test passes
addr = client.lookup(id);
Assert.assertNull("client.lookup(id)", addr);
- } catch (Exception e) {
+ } catch (final Exception e) {
if (e instanceof ExecutionException) {
Assert.assertTrue("Execution Exception cause is instanceof NamingException",
e.getCause() instanceof NamingException);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java
index 6137155..472dde3 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NamingTest.java
@@ -110,9 +110,9 @@ public class NamingTest {
final Identifier id2 = this.factory.getNewInstance("task2");
final Map<Identifier, InetSocketAddress> respMap = new HashMap<Identifier, InetSocketAddress>();
- InetSocketAddress addr1 = client.lookup(id1);
+ final InetSocketAddress addr1 = client.lookup(id1);
respMap.put(id1, addr1);
- InetSocketAddress addr2 = client.lookup(id2);
+ final InetSocketAddress addr2 = client.lookup(id2);
respMap.put(id2, addr2);
for (final Identifier id : respMap.keySet()) {
@@ -311,7 +311,7 @@ public class NamingTest {
// registration
// invoke registration from the client side
- Configuration nameResolverConf = NameResolverConfiguration.CONF
+ final Configuration nameResolverConf = NameResolverConfiguration.CONF
.set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress)
.set(NameResolverConfiguration.NAME_SERVICE_PORT, this.port)
.set(NameResolverConfiguration.CACHE_TIMEOUT, this.TTL)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java
index e9c903c..6bc0ac9 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkConnectionServiceTest.java
@@ -61,7 +61,7 @@ public class NetworkConnectionServiceTest {
@Rule
public TestName name = new TestName();
- private void runMessagingNetworkConnectionService(Codec<String> codec) throws Exception {
+ private void runMessagingNetworkConnectionService(final Codec<String> codec) throws Exception {
final int numMessages = 2000;
final Monitor monitor = new Monitor();
try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
@@ -75,7 +75,7 @@ public class NetworkConnectionServiceTest {
conn.write("hello" + count);
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
@@ -101,7 +101,8 @@ public class NetworkConnectionServiceTest {
runMessagingNetworkConnectionService(new StreamingStringCodec());
}
- public void runNetworkConnServiceWithMultipleConnFactories(Codec<String> stringCodec, Codec<Integer> integerCodec)
+ public void runNetworkConnServiceWithMultipleConnFactories(final Codec<String> stringCodec,
+ final Codec<Integer> integerCodec)
throws Exception {
final ExecutorService executor = Executors.newFixedThreadPool(5);
@@ -126,7 +127,7 @@ public class NetworkConnectionServiceTest {
conn.write("hello" + count);
}
monitor.mwait();
- } catch (Exception e) {
+ } catch (final Exception e) {
e.printStackTrace();
throw new RuntimeException(e);
}
@@ -144,7 +145,7 @@ public class NetworkConnectionServiceTest {
conn.write(count);
}
monitor2.mwait();
- } catch (Exception e) {
+ } catch (final Exception e) {
e.printStackTrace();
throw new RuntimeException(e);
}
@@ -183,7 +184,7 @@ public class NetworkConnectionServiceTest {
LOG.log(Level.FINEST, name.getMethodName());
final int[] messageSizes = {1, 16, 32, 64, 512, 64 * 1024, 1024 * 1024};
- for (int size : messageSizes) {
+ for (final int size : messageSizes) {
final int numMessages = 300000 / (Math.max(1, size / 512));
final Monitor monitor = new Monitor();
final Codec<String> codec = new StringCodec();
@@ -200,7 +201,7 @@ public class NetworkConnectionServiceTest {
try (final Connection<String> conn =
messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
- long start = System.currentTimeMillis();
+ final long start = System.currentTimeMillis();
try {
conn.open();
for (int count = 0; count < numMessages; ++count) {
@@ -208,7 +209,7 @@ public class NetworkConnectionServiceTest {
conn.write(message);
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
@@ -263,12 +264,12 @@ public class NetworkConnectionServiceTest {
conn.write(message);
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
}
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new RuntimeException(e);
}
}
@@ -294,7 +295,7 @@ public class NetworkConnectionServiceTest {
LOG.log(Level.FINEST, name.getMethodName());
final int[] messageSizes = {2000}; // {1,16,32,64,512,64*1024,1024*1024};
- for (int size : messageSizes) {
+ for (final int size : messageSizes) {
final int numMessages = 300000 / (Math.max(1, size / 512));
final int numThreads = 2;
final int totalNumMessages = numMessages * numThreads;
@@ -326,7 +327,7 @@ public class NetworkConnectionServiceTest {
// send messages to the receiver.
conn.write(message);
}
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new RuntimeException(e);
}
}
@@ -355,7 +356,7 @@ public class NetworkConnectionServiceTest {
final int batchSize = 1024 * 1024;
final int[] messageSizes = {32, 64, 512};
- for (int size : messageSizes) {
+ for (final int size : messageSizes) {
final int numMessages = 300 / (Math.max(1, size / 512));
final Monitor monitor = new Monitor();
final Codec<String> codec = new StringCodec();
@@ -382,7 +383,7 @@ public class NetworkConnectionServiceTest {
conn.write(sb.toString());
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java
index 85b2860..6045be2 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/NetworkServiceTest.java
@@ -70,14 +70,14 @@ public class NetworkServiceTest {
public void testMessagingNetworkService() throws Exception {
LOG.log(Level.FINEST, name.getMethodName());
- IdentifierFactory factory = new StringIdentifierFactory();
+ final IdentifierFactory factory = new StringIdentifierFactory();
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
try (final NameServer server = injector.getInstance(NameServer.class)) {
- int nameServerPort = server.getPort();
+ final int nameServerPort = server.getPort();
final int numMessages = 10;
final Monitor monitor = new Monitor();
@@ -121,7 +121,7 @@ public class NetworkServiceTest {
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
@@ -136,18 +136,18 @@ public class NetworkServiceTest {
public void testMessagingNetworkServiceRate() throws Exception {
LOG.log(Level.FINEST, name.getMethodName());
- IdentifierFactory factory = new StringIdentifierFactory();
+ final IdentifierFactory factory = new StringIdentifierFactory();
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
try (final NameServer server = injector.getInstance(NameServer.class)) {
- int nameServerPort = server.getPort();
+ final int nameServerPort = server.getPort();
final int[] messageSizes = {1, 16, 32, 64, 512, 64 * 1024, 1024 * 1024};
- for (int size : messageSizes) {
+ for (final int size : messageSizes) {
final int numMessages = 300000 / (Math.max(1, size / 512));
final Monitor monitor = new Monitor();
@@ -181,28 +181,28 @@ public class NetworkServiceTest {
final int port1 = ns1.getTransport().getListeningPort();
server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1));
- Identifier destId = factory.getNewInstance(name2);
+ final Identifier destId = factory.getNewInstance(name2);
// build the message
- StringBuilder msb = new StringBuilder();
+ final StringBuilder msb = new StringBuilder();
for (int i = 0; i < size; i++) {
msb.append("1");
}
- String message = msb.toString();
+ final String message = msb.toString();
- long start = System.currentTimeMillis();
+ final long start = System.currentTimeMillis();
try (Connection<String> conn = ns1.newConnection(destId)) {
for (int i = 0; i < numMessages; i++) {
conn.open();
conn.write(message);
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
- long end = System.currentTimeMillis();
- double runtime = ((double) end - start) / 1000;
+ final long end = System.currentTimeMillis();
+ final double runtime = ((double) end - start) / 1000;
LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + numMessages / runtime +
" bandwidth(bytes/s): " + ((double) numMessages * 2 * size) / runtime); // x2 for unicode chars
}
@@ -226,14 +226,14 @@ public class NetworkServiceTest {
try (final NameServer server = injector.getInstance(NameServer.class)) {
final int nameServerPort = server.getPort();
- BlockingQueue<Object> barrier = new LinkedBlockingQueue<Object>();
+ final BlockingQueue<Object> barrier = new LinkedBlockingQueue<Object>();
- int numThreads = 4;
+ final int numThreads = 4;
final int size = 2000;
final int numMessages = 300000 / (Math.max(1, size / 512));
final int totalNumMessages = numMessages * numThreads;
- ExecutorService e = Executors.newCachedThreadPool();
+ final ExecutorService e = Executors.newCachedThreadPool();
for (int t = 0; t < numThreads; t++) {
final int tt = t;
@@ -241,7 +241,7 @@ public class NetworkServiceTest {
@Override
public void run() {
try {
- Monitor monitor = new Monitor();
+ final Monitor monitor = new Monitor();
// network service
final String name2 = "task2-" + tt;
@@ -274,14 +274,14 @@ public class NetworkServiceTest {
final int port1 = ns1.getTransport().getListeningPort();
server.register(factory.getNewInstance(name1), new InetSocketAddress(localAddress, port1));
- Identifier destId = factory.getNewInstance(name2);
+ final Identifier destId = factory.getNewInstance(name2);
// build the message
- StringBuilder msb = new StringBuilder();
+ final StringBuilder msb = new StringBuilder();
for (int i = 0; i < size; i++) {
msb.append("1");
}
- String message = msb.toString();
+ final String message = msb.toString();
try (Connection<String> conn = ns1.newConnection(destId)) {
for (int i = 0; i < numMessages; i++) {
@@ -289,12 +289,12 @@ public class NetworkServiceTest {
conn.write(message);
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
}
- } catch (Exception e) {
+ } catch (final Exception e) {
e.printStackTrace();
throw new RuntimeException(e);
}
@@ -303,16 +303,16 @@ public class NetworkServiceTest {
}
// start and time
- long start = System.currentTimeMillis();
- Object ignore = new Object();
+ final long start = System.currentTimeMillis();
+ final Object ignore = new Object();
for (int i = 0; i < numThreads; i++) {
barrier.add(ignore);
}
e.shutdown();
e.awaitTermination(100, TimeUnit.SECONDS);
- long end = System.currentTimeMillis();
+ final long end = System.currentTimeMillis();
- double runtime = ((double) end - start) / 1000;
+ final double runtime = ((double) end - start) / 1000;
LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + totalNumMessages / runtime +
" bandwidth(bytes/s): " + ((double) totalNumMessages * 2 * size) / runtime); // x2 for unicode chars
}
@@ -322,20 +322,20 @@ public class NetworkServiceTest {
public void testMultithreadedSharedConnMessagingNetworkServiceRate() throws Exception {
LOG.log(Level.FINEST, name.getMethodName());
- IdentifierFactory factory = new StringIdentifierFactory();
+ final IdentifierFactory factory = new StringIdentifierFactory();
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
try (final NameServer server = injector.getInstance(NameServer.class)) {
- int nameServerPort = server.getPort();
+ final int nameServerPort = server.getPort();
final int[] messageSizes = {2000}; // {1,16,32,64,512,64*1024,1024*1024};
- for (int size : messageSizes) {
+ for (final int size : messageSizes) {
final int numMessages = 300000 / (Math.max(1, size / 512));
- int numThreads = 2;
- int totalNumMessages = numMessages * numThreads;
+ final int numThreads = 2;
+ final int totalNumMessages = numMessages * numThreads;
final Monitor monitor = new Monitor();
@@ -370,21 +370,21 @@ public class NetworkServiceTest {
final int port1 = ns1.getTransport().getListeningPort();
server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1));
- Identifier destId = factory.getNewInstance(name2);
+ final Identifier destId = factory.getNewInstance(name2);
try (final Connection<String> conn = ns1.newConnection(destId)) {
conn.open();
// build the message
- StringBuilder msb = new StringBuilder();
+ final StringBuilder msb = new StringBuilder();
for (int i = 0; i < size; i++) {
msb.append("1");
}
final String message = msb.toString();
- ExecutorService e = Executors.newCachedThreadPool();
+ final ExecutorService e = Executors.newCachedThreadPool();
- long start = System.currentTimeMillis();
+ final long start = System.currentTimeMillis();
for (int i = 0; i < numThreads; i++) {
e.submit(new Runnable() {
@@ -402,8 +402,8 @@ public class NetworkServiceTest {
e.awaitTermination(30, TimeUnit.SECONDS);
monitor.mwait();
- long end = System.currentTimeMillis();
- double runtime = ((double) end - start) / 1000;
+ final long end = System.currentTimeMillis();
+ final double runtime = ((double) end - start) / 1000;
LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + totalNumMessages / runtime +
" bandwidth(bytes/s): " + ((double) totalNumMessages * 2 * size) / runtime); // x2 for unicode chars
@@ -420,19 +420,19 @@ public class NetworkServiceTest {
public void testMessagingNetworkServiceBatchingRate() throws Exception {
LOG.log(Level.FINEST, name.getMethodName());
- IdentifierFactory factory = new StringIdentifierFactory();
+ final IdentifierFactory factory = new StringIdentifierFactory();
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
try (final NameServer server = injector.getInstance(NameServer.class)) {
- int nameServerPort = server.getPort();
+ final int nameServerPort = server.getPort();
final int batchSize = 1024 * 1024;
final int[] messageSizes = {32, 64, 512};
- for (int size : messageSizes) {
+ for (final int size : messageSizes) {
final int numMessages = 300 / (Math.max(1, size / 512));
final Monitor monitor = new Monitor();
@@ -466,19 +466,19 @@ public class NetworkServiceTest {
final int port1 = ns1.getTransport().getListeningPort();
server.register(factory.getNewInstance("task1"), new InetSocketAddress(this.localAddress, port1));
- Identifier destId = factory.getNewInstance(name2);
+ final Identifier destId = factory.getNewInstance(name2);
// build the message
- StringBuilder msb = new StringBuilder();
+ final StringBuilder msb = new StringBuilder();
for (int i = 0; i < size; i++) {
msb.append("1");
}
- String message = msb.toString();
+ final String message = msb.toString();
- long start = System.currentTimeMillis();
+ final long start = System.currentTimeMillis();
try (Connection<String> conn = ns1.newConnection(destId)) {
for (int i = 0; i < numMessages; i++) {
- StringBuilder sb = new StringBuilder();
+ final StringBuilder sb = new StringBuilder();
for (int j = 0; j < batchSize / size; j++) {
sb.append(message);
}
@@ -486,13 +486,13 @@ public class NetworkServiceTest {
conn.write(sb.toString());
}
monitor.mwait();
- } catch (NetworkException e) {
+ } catch (final NetworkException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
- long end = System.currentTimeMillis();
- double runtime = ((double) end - start) / 1000;
- long numAppMessages = numMessages * batchSize / size;
+ final long end = System.currentTimeMillis();
+ final double runtime = ((double) end - start) / 1000;
+ final long numAppMessages = numMessages * batchSize / size;
LOG.log(Level.FINEST, "size: " + size + "; messages/s: " + numAppMessages / runtime +
" bandwidth(bytes/s): " + ((double) numAppMessages * 2 * size) / runtime); // x2 for unicode chars
}
@@ -510,14 +510,14 @@ public class NetworkServiceTest {
private final Monitor monitor;
private AtomicInteger count = new AtomicInteger(0);
- MessageHandler(String name, Monitor monitor, int expected) {
+ MessageHandler(final String name, final Monitor monitor, final int expected) {
this.name = name;
this.monitor = monitor;
this.expected = expected;
}
@Override
- public void onNext(Message<T> value) {
+ public void onNext(final Message<T> value) {
count.incrementAndGet();
@@ -540,7 +540,7 @@ public class NetworkServiceTest {
*/
class ExceptionHandler implements EventHandler<Exception> {
@Override
- public void onNext(Exception error) {
+ public void onNext(final Exception error) {
System.err.println(error);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java
index 494f2e0..92ba655 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/TestEvent.java
@@ -28,7 +28,7 @@ public class TestEvent implements Serializable {
private static final long serialVersionUID = 1L;
private String message;
- public TestEvent(String message) {
+ public TestEvent(final String message) {
this.message = message;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java
index d27f4cf..b10d876 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/LoggingUtils.java
@@ -24,10 +24,10 @@ import java.util.logging.Level;
import java.util.logging.Logger;
public final class LoggingUtils {
- public static void setLoggingLevel(Level level) {
- Handler[] handlers = Logger.getLogger("").getHandlers();
+ public static void setLoggingLevel(final Level level) {
+ final Handler[] handlers = Logger.getLogger("").getHandlers();
ConsoleHandler ch = null;
- for (Handler h : handlers) {
+ for (final Handler h : handlers) {
if (h instanceof ConsoleHandler) {
ch = (ConsoleHandler) h;
break;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java
index ccc2e4b..ebc8608 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/NetworkMessagingTestService.java
@@ -117,7 +117,7 @@ public final class NetworkMessagingTestService implements AutoCloseable {
}
@Override
- public void onNext(Message<T> value) {
+ public void onNext(final Message<T> value) {
count.incrementAndGet();
LOG.log(Level.FINE, "Count: {0}", count.get());
LOG.log(Level.FINE,
@@ -136,11 +136,11 @@ public final class NetworkMessagingTestService implements AutoCloseable {
public static final class TestListener<T> implements LinkListener<Message<T>> {
@Override
- public void onSuccess(Message<T> message) {
+ public void onSuccess(final Message<T> message) {
LOG.log(Level.FINE, "success: " + message);
}
@Override
- public void onException(Throwable cause, SocketAddress remoteAddress, Message<T> message) {
+ public void onException(final Throwable cause, final SocketAddress remoteAddress, final Message<T> message) {
LOG.log(Level.WARNING, "exception: " + cause + message);
throw new RuntimeException(cause);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java
index eaec90f..757a803 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingIntegerCodec.java
@@ -28,30 +28,30 @@ import java.io.IOException;
public class StreamingIntegerCodec implements StreamingCodec<Integer> {
@Override
- public void encodeToStream(Integer obj, DataOutputStream stream) {
+ public void encodeToStream(final Integer obj, final DataOutputStream stream) {
try {
stream.writeInt(obj);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
}
@Override
- public Integer decodeFromStream(DataInputStream stream) {
+ public Integer decodeFromStream(final DataInputStream stream) {
try {
return stream.readInt();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
}
@Override
- public Integer decode(byte[] data) {
+ public Integer decode(final byte[] data) {
return null;
}
@Override
- public byte[] encode(Integer obj) {
+ public byte[] encode(final Integer obj) {
return new byte[0];
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java
index 497c7fa..43efaf6 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StreamingStringCodec.java
@@ -27,29 +27,29 @@ import java.io.IOException;
public class StreamingStringCodec implements StreamingCodec<String> {
@Override
- public byte[] encode(String obj) {
+ public byte[] encode(final String obj) {
return obj.getBytes();
}
@Override
- public String decode(byte[] buf) {
+ public String decode(final byte[] buf) {
return new String(buf);
}
@Override
- public void encodeToStream(String obj, DataOutputStream stream) {
+ public void encodeToStream(final String obj, final DataOutputStream stream) {
try {
stream.writeUTF(obj);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
}
@Override
- public String decodeFromStream(DataInputStream stream) {
+ public String decodeFromStream(final DataInputStream stream) {
try {
return stream.readUTF();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java
index cee8421..d939b8e 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/StringCodec.java
@@ -23,12 +23,12 @@ import org.apache.reef.wake.remote.Codec;
public class StringCodec implements Codec<String> {
@Override
- public byte[] encode(String obj) {
+ public byte[] encode(final String obj) {
return obj.getBytes();
}
@Override
- public String decode(byte[] buf) {
+ public String decode(final byte[] buf) {
return new String(buf);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java
index 5f13deb..146a6db 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/network/util/TimeoutHandler.java
@@ -25,12 +25,12 @@ public class TimeoutHandler implements EventHandler<PeriodicEvent> {
private final Monitor monitor;
- public TimeoutHandler(Monitor monitor) {
+ public TimeoutHandler(final Monitor monitor) {
this.monitor = monitor;
}
@Override
- public void onNext(PeriodicEvent event) {
+ public void onNext(final PeriodicEvent event) {
monitor.mnotify();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java
index 27f4e5c..38655c0 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/ExternalMapTest.java
@@ -33,23 +33,23 @@ import java.util.*;
public class ExternalMapTest {
@Test
public void testCodecRamMap() {
- RamStorageService ramStore = new RamStorageService();
- Codec<Integer> c = new IntegerCodec();
- ExternalMap<Integer> m = new CodecRamMap<>(ramStore, c);
+ final RamStorageService ramStore = new RamStorageService();
+ final Codec<Integer> c = new IntegerCodec();
+ final ExternalMap<Integer> m = new CodecRamMap<>(ramStore, c);
genericTest(m);
}
@Test
public void testRamMap() {
- RamStorageService ramStore = new RamStorageService();
- ExternalMap<Integer> m = new RamMap<>(ramStore);
+ final RamStorageService ramStore = new RamStorageService();
+ final ExternalMap<Integer> m = new RamMap<>(ramStore);
genericTest(m);
}
- void genericTest(ExternalMap<Integer> m) {
+ void genericTest(final ExternalMap<Integer> m) {
m.put("foo", 42);
- Map<String, Integer> smallMap = new HashMap<>();
+ final Map<String, Integer> smallMap = new HashMap<>();
smallMap.put("bar", 43);
smallMap.put("baz", 44);
@@ -63,19 +63,19 @@ public class ExternalMapTest {
Assert.assertTrue(m.containsKey("bar"));
Assert.assertFalse(m.containsKey("quuz"));
- Set<String> barBaz = new HashSet<>();
+ final Set<String> barBaz = new HashSet<>();
barBaz.add("bar");
barBaz.add("baz");
barBaz.add("quuz");
- Iterable<Map.Entry<CharSequence, Integer>> it = m.getAll(barBaz);
+ final Iterable<Map.Entry<CharSequence, Integer>> it = m.getAll(barBaz);
- Map<CharSequence, Integer> found = new TreeMap<>();
+ final Map<CharSequence, Integer> found = new TreeMap<>();
- for (Map.Entry<CharSequence, Integer> e : it) {
+ for (final Map.Entry<CharSequence, Integer> e : it) {
found.put(e.getKey(), e.getValue());
}
- Iterator<CharSequence> it2 = found.keySet().iterator();
+ final Iterator<CharSequence> it2 = found.keySet().iterator();
Assert.assertTrue(it2.hasNext());
CharSequence s = it2.next();
Assert.assertEquals(s, "bar");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java
index cf6199e..e8722de 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/FramingTest.java
@@ -34,14 +34,14 @@ public class FramingTest {
@Test
public void frameRoundTripTest() throws IOException, ServiceException {
- ByteArrayOutputStream baos = new ByteArrayOutputStream();
- ByteArrayOutputStream baos2 = new ByteArrayOutputStream();
- FramingOutputStream o = new FramingOutputStream(baos);
- FramingOutputStream o2 = new FramingOutputStream(baos2);
- Accumulator<byte[]> a = o2.accumulator();
+ final ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ final ByteArrayOutputStream baos2 = new ByteArrayOutputStream();
+ final FramingOutputStream o = new FramingOutputStream(baos);
+ final FramingOutputStream o2 = new FramingOutputStream(baos2);
+ final Accumulator<byte[]> a = o2.accumulator();
int offset = 0;
for (int i = 0; i < 256; i++) {
- byte[] b = new byte[i];
+ final byte[] b = new byte[i];
Arrays.fill(b, (byte) i);
o.write(b);
if (i == 255) {
@@ -56,16 +56,16 @@ public class FramingTest {
}
a.close();
o2.close();
- byte[] b1 = baos.toByteArray();
- byte[] b2 = baos2.toByteArray();
+ final byte[] b1 = baos.toByteArray();
+ final byte[] b2 = baos2.toByteArray();
Assert.assertArrayEquals(b1, b2);
- FramingInputStream inA1 = new FramingInputStream(new ByteArrayInputStream(b1));
- FramingInputStream inA2 = new FramingInputStream(new ByteArrayInputStream(b2));
+ final FramingInputStream inA1 = new FramingInputStream(new ByteArrayInputStream(b1));
+ final FramingInputStream inA2 = new FramingInputStream(new ByteArrayInputStream(b2));
for (int i = 0; i <= 256; i++) {
- byte[] b = new byte[i];
+ final byte[] b = new byte[i];
Arrays.fill(b, (byte) i);
- byte[] f = inA1.readFrame();
- byte[] g = inA2.readFrame();
+ final byte[] f = inA1.readFrame();
+ final byte[] g = inA2.readFrame();
if (i == 256) {
Assert.assertNull(f);
Assert.assertNull(g);
@@ -77,10 +77,10 @@ public class FramingTest {
inA2.close();
inA1.close();
- FramingInputStream inB1 = new FramingInputStream(new ByteArrayInputStream(b1));
+ final FramingInputStream inB1 = new FramingInputStream(new ByteArrayInputStream(b1));
int i = 0;
- for (byte[] bin : inB1) {
- byte[] b = new byte[i];
+ for (final byte[] bin : inB1) {
+ final byte[] b = new byte[i];
Arrays.fill(b, (byte) i);
Assert.assertArrayEquals(b, bin);
i++;
@@ -88,10 +88,10 @@ public class FramingTest {
Assert.assertEquals(256, i);
inB1.close();
- FramingInputStream inB2 = new FramingInputStream(new ByteArrayInputStream(b2));
+ final FramingInputStream inB2 = new FramingInputStream(new ByteArrayInputStream(b2));
i = 0;
- for (byte[] bin : inB2) {
- byte[] b = new byte[i];
+ for (final byte[] bin : inB2) {
+ final byte[] b = new byte[i];
Arrays.fill(b, (byte) i);
Assert.assertArrayEquals(b, bin);
i++;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java
index f859921..bfab073 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/MergingIteratorTest.java
@@ -33,7 +33,7 @@ public class MergingIteratorTest {
Comparator<Integer> cmp = new Comparator<Integer>() {
@Override
- public int compare(Integer o1, Integer o2) {
+ public int compare(final Integer o1, final Integer o2) {
return Integer.compare(o1, o2);
}
};
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java
index b7c0e09..6e43683 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SortingSpoolTest.java
@@ -34,7 +34,7 @@ public class SortingSpoolTest {
genericTest(new SortingRamSpool<Integer>(), new Comparator<Integer>() {
@Override
- public int compare(Integer o1, Integer o2) {
+ public int compare(final Integer o1, final Integer o2) {
return Integer.compare(o1, o2);
}
@@ -43,10 +43,10 @@ public class SortingSpoolTest {
@Test
public void testRamSpoolComparator() throws ServiceException {
- Comparator<Integer> backwards = new Comparator<Integer>() {
+ final Comparator<Integer> backwards = new Comparator<Integer>() {
@Override
- public int compare(Integer o1, Integer o2) {
+ public int compare(final Integer o1, final Integer o2) {
return -1 * o1.compareTo(o2);
}
@@ -56,60 +56,60 @@ public class SortingSpoolTest {
@Test(expected = IllegalStateException.class)
public void testRamSpoolAddAfterClose() throws ServiceException {
- Spool<Integer> s = new SortingRamSpool<>();
+ final Spool<Integer> s = new SortingRamSpool<>();
genericAddAfterCloseTest(s);
}
@Test(expected = UnsupportedOperationException.class)
public void testRamSpoolCantRemove() throws ServiceException {
- Spool<Integer> s = new SortingRamSpool<>();
+ final Spool<Integer> s = new SortingRamSpool<>();
genericCantRemove(s);
}
@Test(expected = IllegalStateException.class)
public void testIteratorBeforeClose() throws ServiceException {
- Spool<Integer> s = new SortingRamSpool<>();
+ final Spool<Integer> s = new SortingRamSpool<>();
genericIteratorBeforeClose(s);
}
- void genericTest(Spool<Integer> s, Comparator<Integer> comparator)
+ void genericTest(final Spool<Integer> s, final Comparator<Integer> comparator)
throws ServiceException {
- List<Integer> l = new ArrayList<Integer>();
- Random r = new Random(42);
+ final List<Integer> l = new ArrayList<Integer>();
+ final Random r = new Random(42);
while (l.size() < 100) {
l.add(r.nextInt(75));
}
- Accumulator<Integer> a = s.accumulator();
+ final Accumulator<Integer> a = s.accumulator();
for (int i = 0; i < 100; i++) {
a.add(l.get(i));
}
a.close();
- List<Integer> m = new ArrayList<Integer>();
- for (int i : s) {
+ final List<Integer> m = new ArrayList<Integer>();
+ for (final int i : s) {
m.add(i);
}
- Integer[] sorted = l.toArray(new Integer[0]);
+ final Integer[] sorted = l.toArray(new Integer[0]);
Arrays.sort(sorted, 0, sorted.length, comparator);
- Integer[] shouldBeSorted = m.toArray(new Integer[0]);
+ final Integer[] shouldBeSorted = m.toArray(new Integer[0]);
Assert.assertArrayEquals(sorted, shouldBeSorted);
}
- void genericAddAfterCloseTest(Spool<?> s) throws ServiceException {
- Accumulator<?> a = s.accumulator();
+ void genericAddAfterCloseTest(final Spool<?> s) throws ServiceException {
+ final Accumulator<?> a = s.accumulator();
a.close();
a.add(null);
}
- void genericCantRemove(Spool<Integer> s) throws ServiceException {
- Accumulator<Integer> a = s.accumulator();
+ void genericCantRemove(final Spool<Integer> s) throws ServiceException {
+ final Accumulator<Integer> a = s.accumulator();
a.add(10);
a.close();
- Iterator<?> it = s.iterator();
+ final Iterator<?> it = s.iterator();
it.remove();
}
- void genericIteratorBeforeClose(Spool<Integer> s) throws ServiceException {
- Accumulator<Integer> a = s.accumulator();
+ void genericIteratorBeforeClose(final Spool<Integer> s) throws ServiceException {
+ final Accumulator<Integer> a = s.accumulator();
a.add(10);
s.iterator();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java
index 9a76b27..2ff6744 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/SpoolFileTest.java
@@ -59,12 +59,12 @@ public class SpoolFileTest {
return new Accumulator<Integer>() {
@Override
- public void add(Integer datum) {
+ public void add(final Integer datum) {
try {
- int d = datum;
+ final int d = datum;
out.write(new byte[]{(byte) (d >>> 24), (byte) (d >>> 16),
(byte) (d >>> 8), (byte) d});
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new IllegalStateException(e);
}
}
@@ -73,7 +73,7 @@ public class SpoolFileTest {
public void close() {
try {
out.flush();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new IllegalStateException(e);
}
}
@@ -88,7 +88,7 @@ public class SpoolFileTest {
return new Iterable<Integer>() {
@Override
public Iterator<Integer> iterator() {
- Iterator<Integer> it = new Iterator<Integer>() {
+ final Iterator<Integer> it = new Iterator<Integer>() {
final byte[] inb = new byte[4];
Integer nextInt;
@@ -98,10 +98,10 @@ public class SpoolFileTest {
}
private void prime() {
- int read;
+ final int read;
try {
read = in.read(inb);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new IllegalStateException(e);
}
if (read != 4) {
@@ -115,7 +115,7 @@ public class SpoolFileTest {
@Override
public Integer next() {
- Integer ret = nextInt;
+ final Integer ret = nextInt;
prime();
return ret;
}
@@ -150,8 +150,8 @@ public class SpoolFileTest {
@Test
public void testFile() throws ServiceException {
- LocalStorageService service = new LocalStorageService("spoolTest", "file");
- Spool<Integer> f = new SerializerFileSpool<Integer>(service, serializer,
+ final LocalStorageService service = new LocalStorageService("spoolTest", "file");
+ final Spool<Integer> f = new SerializerFileSpool<Integer>(service, serializer,
deserializer);
test(f);
service.getScratchSpace().delete();
@@ -159,23 +159,23 @@ public class SpoolFileTest {
@Test
public void testInterop() throws ServiceException {
- LocalStorageService service = new LocalStorageService("spoolTest", "file");
- Codec<Integer> c = new IntegerCodec();
+ final LocalStorageService service = new LocalStorageService("spoolTest", "file");
+ final Codec<Integer> c = new IntegerCodec();
- CodecFileAccumulable<Integer, Codec<Integer>> f = new CodecFileAccumulable<Integer, Codec<Integer>>(
+ final CodecFileAccumulable<Integer, Codec<Integer>> f = new CodecFileAccumulable<Integer, Codec<Integer>>(
service, c);
- CodecFileIterable<Integer, Codec<Integer>> g = new CodecFileIterable<Integer, Codec<Integer>>(
+ final CodecFileIterable<Integer, Codec<Integer>> g = new CodecFileIterable<Integer, Codec<Integer>>(
new File(f.getName()), c);
test(f, g);
service.getScratchSpace().delete();
}
- protected void test(Spool<Integer> f) throws ServiceException {
+ protected void test(final Spool<Integer> f) throws ServiceException {
test(f, f);
}
- protected void test(Accumulable<Integer> f, Iterable<Integer> g) throws ServiceException {
+ protected void test(final Accumulable<Integer> f, final Iterable<Integer> g) throws ServiceException {
try (Accumulator<Integer> acc = f.accumulator()) {
for (int i = 0; i < 1000; i++) {
@@ -183,12 +183,12 @@ public class SpoolFileTest {
}
}
int i = 0;
- for (int j : g) {
+ for (final int j : g) {
Assert.assertEquals(i, j);
i++;
}
- Iterator<Integer> itA = g.iterator();
- Iterator<Integer> itB = g.iterator();
+ final Iterator<Integer> itA = g.iterator();
+ final Iterator<Integer> itB = g.iterator();
for (i = 0; i < 1000; i++) {
Assert.assertEquals((int) itA.next(), i);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java
index 9fab5af..1c4e48a 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/services/storage/TupleSerializerTest.java
@@ -60,7 +60,7 @@ public class TupleSerializerTest {
keySerializer, valSerializer);
baos = new ByteArrayOutputStream();
- Accumulator<Tuple<Integer, String>> acc = fts.create(baos).accumulator();
+ final Accumulator<Tuple<Integer, String>> acc = fts.create(baos).accumulator();
for (int i = 0; i < 100; i++) {
acc.add(new Tuple<>(i, i + ""));
}
@@ -74,8 +74,8 @@ public class TupleSerializerTest {
@Test
public void testFramingSerializer() throws ServiceException, IOException {
int i = 0;
- for (Tuple<Integer, String> t : iterable) {
- Tuple<Integer, String> u = new Tuple<>(i, i + "");
+ for (final Tuple<Integer, String> t : iterable) {
+ final Tuple<Integer, String> u = new Tuple<>(i, i + "");
Assert.assertEquals(u, t);
i++;
}
@@ -84,13 +84,13 @@ public class TupleSerializerTest {
@Test(expected = NoSuchElementException.class)
public void testReadOffEnd() {
- Iterator<Tuple<Integer, String>> it = iterable.iterator();
+ final Iterator<Tuple<Integer, String>> it = iterable.iterator();
try {
while (it.hasNext()) {
it.next();
it.hasNext();
}
- } catch (NoSuchElementException e) {
+ } catch (final NoSuchElementException e) {
throw new IllegalStateException("Errored out too early!", e);
}
it.next();
@@ -98,7 +98,7 @@ public class TupleSerializerTest {
@Test(expected = UnsupportedOperationException.class)
public void testCantRemove() {
- Iterator<Tuple<Integer, String>> it = iterable.iterator();
+ final Iterator<Tuple<Integer, String>> it = iterable.iterator();
it.next();
it.remove();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java
index f20fa9a..e706d64 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/sslhacks/UnsafeHostNameVerifier.java
@@ -29,22 +29,22 @@ import java.security.cert.X509Certificate;
final class UnsafeHostNameVerifier implements X509HostnameVerifier {
@Override
- public void verify(String host, SSLSocket ssl) throws IOException {
+ public void verify(final String host, final SSLSocket ssl) throws IOException {
}
@Override
- public void verify(String host, X509Certificate cert) throws SSLException {
+ public void verify(final String host, final X509Certificate cert) throws SSLException {
}
@Override
- public void verify(String host, String[] cns, String[] subjectAlts) throws SSLException {
+ public void verify(final String host, final String[] cns, final String[] subjectAlts) throws SSLException {
}
@Override
- public boolean verify(String s, SSLSession sslSession) {
+ public boolean verify(final String s, final SSLSession sslSession) {
return true;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java
index 5249f69..9c743dc 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/AmContainerSpec.java
@@ -161,12 +161,12 @@ public final class AmContainerSpec {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java
index 6c9a18e..a14c7ee 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationID.java
@@ -59,12 +59,12 @@ public final class ApplicationID {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java
index 25041fd..bde2aab 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationResponse.java
@@ -54,12 +54,12 @@ public final class ApplicationResponse {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java
index 92bea8e..7e9e1db 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationState.java
@@ -66,7 +66,7 @@ public final class ApplicationState {
return finishedTime;
}
- public void setFinishedTime(long finishedTime) {
+ public void setFinishedTime(final long finishedTime) {
this.finishedTime = finishedTime;
}
@@ -75,7 +75,7 @@ public final class ApplicationState {
return amContainerLogs;
}
- public void setAmContainerLogs(String amContainerLogs) {
+ public void setAmContainerLogs(final String amContainerLogs) {
this.amContainerLogs = amContainerLogs;
}
@@ -84,7 +84,7 @@ public final class ApplicationState {
return trackingUI;
}
- public void setTrackingUI(String trackingUI) {
+ public void setTrackingUI(final String trackingUI) {
this.trackingUI = trackingUI;
}
@@ -93,7 +93,7 @@ public final class ApplicationState {
return state;
}
- public void setState(String state) {
+ public void setState(final String state) {
this.state = state;
}
@@ -102,7 +102,7 @@ public final class ApplicationState {
return user;
}
- public void setUser(String user) {
+ public void setUser(final String user) {
this.user = user;
}
@@ -111,7 +111,7 @@ public final class ApplicationState {
return id;
}
- public void setId(String id) {
+ public void setId(final String id) {
this.id = id;
}
@@ -120,7 +120,7 @@ public final class ApplicationState {
return clusterId;
}
- public void setClusterId(String clusterId) {
+ public void setClusterId(final String clusterId) {
this.clusterId = clusterId;
}
@@ -129,7 +129,7 @@ public final class ApplicationState {
return finalStatus;
}
- public void setFinalStatus(String finalStatus) {
+ public void setFinalStatus(final String finalStatus) {
this.finalStatus = finalStatus;
}
@@ -138,7 +138,7 @@ public final class ApplicationState {
return amHostHttpAddress;
}
- public void setAmHostHttpAddress(String amHostHttpAddress) {
+ public void setAmHostHttpAddress(final String amHostHttpAddress) {
this.amHostHttpAddress = amHostHttpAddress;
}
@@ -147,7 +147,7 @@ public final class ApplicationState {
return progress;
}
- public void setProgress(String progress) {
+ public void setProgress(final String progress) {
this.progress = progress;
}
@@ -156,7 +156,7 @@ public final class ApplicationState {
return name;
}
- public void setName(String name) {
+ public void setName(final String name) {
this.name = name;
}
@@ -165,7 +165,7 @@ public final class ApplicationState {
return applicationType;
}
- public void setApplicationType(String applicationType) {
+ public void setApplicationType(final String applicationType) {
this.applicationType = applicationType;
}
@@ -174,7 +174,7 @@ public final class ApplicationState {
return startedTime;
}
- public void setStartedTime(long startedTime) {
+ public void setStartedTime(final long startedTime) {
this.startedTime = startedTime;
}
@@ -183,7 +183,7 @@ public final class ApplicationState {
return elapsedTime;
}
- public void setElapsedTime(long elapsedTime) {
+ public void setElapsedTime(final long elapsedTime) {
this.elapsedTime = elapsedTime;
}
@@ -192,7 +192,7 @@ public final class ApplicationState {
return diagnostics;
}
- public void setDiagnostics(String diagnostics) {
+ public void setDiagnostics(final String diagnostics) {
this.diagnostics = diagnostics;
}
@@ -201,7 +201,7 @@ public final class ApplicationState {
return trackingUrl;
}
- public void setTrackingUrl(String trackingUrl) {
+ public void setTrackingUrl(final String trackingUrl) {
this.trackingUrl = trackingUrl;
}
@@ -210,7 +210,7 @@ public final class ApplicationState {
return queue;
}
- public void setQueue(String queue) {
+ public void setQueue(final String queue) {
this.queue = queue;
}
@@ -219,7 +219,7 @@ public final class ApplicationState {
return allocatedMB;
}
- public void setAllocatedMB(int allocatedMB) {
+ public void setAllocatedMB(final int allocatedMB) {
this.allocatedMB = allocatedMB;
}
@@ -228,7 +228,7 @@ public final class ApplicationState {
return allocatedVCores;
}
- public void setAllocatedVCores(int allocatedVCores) {
+ public void setAllocatedVCores(final int allocatedVCores) {
this.allocatedVCores = allocatedVCores;
}
@@ -237,7 +237,7 @@ public final class ApplicationState {
return runningContainers;
}
- public void setRunningContainers(int runningContainers) {
+ public void setRunningContainers(final int runningContainers) {
this.runningContainers = runningContainers;
}
@@ -246,7 +246,7 @@ public final class ApplicationState {
return memorySeconds;
}
- public void setMemorySeconds(long memorySeconds) {
+ public void setMemorySeconds(final long memorySeconds) {
this.memorySeconds = memorySeconds;
}
@@ -256,18 +256,18 @@ public final class ApplicationState {
}
@SuppressWarnings("checkstyle:hiddenfield")
- public void setVCoreSeconds(long vCoreSeconds) {
+ public void setVCoreSeconds(final long vCoreSeconds) {
this.vCoreSeconds = vCoreSeconds;
}
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
[07/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaConfigurationBuilderImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaConfigurationBuilderImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaConfigurationBuilderImpl.java
index 507481e..0113da1 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaConfigurationBuilderImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaConfigurationBuilderImpl.java
@@ -40,9 +40,9 @@ import java.util.Set;
public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
implements JavaConfigurationBuilder {
- public JavaConfigurationBuilderImpl(URL[] jars,
- Configuration[] confs,
- Class<? extends ExternalConstructor<?>>[] parsers)
+ public JavaConfigurationBuilderImpl(final URL[] jars,
+ final Configuration[] confs,
+ final Class<? extends ExternalConstructor<?>>[] parsers)
throws BindException {
super(jars, confs, parsers);
}
@@ -51,15 +51,15 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
super();
}
- public JavaConfigurationBuilderImpl(URL[] jars) throws BindException {
+ public JavaConfigurationBuilderImpl(final URL[] jars) throws BindException {
super(jars);
}
- JavaConfigurationBuilderImpl(JavaConfigurationBuilderImpl impl) {
+ JavaConfigurationBuilderImpl(final JavaConfigurationBuilderImpl impl) {
super(impl);
}
- public JavaConfigurationBuilderImpl(Configuration[] confs)
+ public JavaConfigurationBuilderImpl(final Configuration[] confs)
throws BindException {
super(confs);
}
@@ -69,19 +69,19 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
return new JavaConfigurationImpl(new JavaConfigurationBuilderImpl(this));
}
- private Node getNode(Class<?> c) {
+ private Node getNode(final Class<?> c) {
return ((JavaClassHierarchy) namespace).getNode(c);
}
@Override
- public <T> JavaConfigurationBuilder bind(Class<T> c, Class<?> val) throws BindException {
+ public <T> JavaConfigurationBuilder bind(final Class<T> c, final Class<?> val) throws BindException {
super.bind(getNode(c), getNode(val));
return this;
}
@Override
@SuppressWarnings("unchecked")
- public <T> JavaConfigurationBuilder bindImplementation(Class<T> c, Class<? extends T> d)
+ public <T> JavaConfigurationBuilder bindImplementation(final Class<T> c, final Class<? extends T> d)
throws BindException {
final Node cn = getNode(c);
final Node dn = getNode(d);
@@ -117,10 +117,10 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
}
@Override
- public <T> JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<T>> iface,
- Class<? extends T> impl) throws BindException {
- Node ifaceN = getNode(iface);
- Node implN = getNode(impl);
+ public <T> JavaConfigurationBuilder bindNamedParameter(final Class<? extends Name<T>> iface,
+ final Class<? extends T> impl) throws BindException {
+ final Node ifaceN = getNode(iface);
+ final Node implN = getNode(impl);
if (!(ifaceN instanceof NamedParameterNode)) {
throw new BindException("Type mismatch when setting named parameter " + ifaceN
+ " Expected NamedParameterNode");
@@ -130,8 +130,8 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
}
@SuppressWarnings({"unchecked"})
- public <T> JavaConfigurationBuilder bindConstructor(Class<T> c,
- Class<? extends ExternalConstructor<? extends T>> v)
+ public <T> JavaConfigurationBuilder bindConstructor(final Class<T> c,
+ final Class<? extends ExternalConstructor<? extends T>> v)
throws BindException {
final Node n = getNode(c);
final Node m = getNode(v);
@@ -147,7 +147,7 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
@SuppressWarnings("unchecked")
@Override
- public <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, String value)
+ public <T> JavaConfigurationBuilder bindSetEntry(final Class<? extends Name<Set<T>>> iface, final String value)
throws BindException {
final Node n = getNode(iface);
@@ -165,8 +165,8 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
@SuppressWarnings("unchecked")
@Override
- public <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, Class<? extends T> impl)
- throws BindException {
+ public <T> JavaConfigurationBuilder bindSetEntry(
+ final Class<? extends Name<Set<T>>> iface, final Class<? extends T> impl) throws BindException {
final Node n = getNode(iface);
final Node m = getNode(impl);
@@ -202,10 +202,10 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
*/
@SuppressWarnings("unchecked")
@Override
- public <T> JavaConfigurationBuilder bindList(Class<? extends Name<List<T>>> iface, List implList)
+ public <T> JavaConfigurationBuilder bindList(final Class<? extends Name<List<T>>> iface, final List implList)
throws BindException {
final Node n = getNode(iface);
- List<Object> result = new ArrayList<>();
+ final List<Object> result = new ArrayList<>();
if (!(n instanceof NamedParameterNode)) {
throw new BindException("BindList got an interface that resolved to " + n + "; expected a NamedParameter");
@@ -216,7 +216,7 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
}
if (!implList.isEmpty()) {
final Type valType = ReflectionUtilities.getInterfaceTarget(List.class, listType);
- for (Object item : implList) {
+ for (final Object item : implList) {
if (item instanceof Class) {
if (!ReflectionUtilities.getRawClass(valType).isAssignableFrom((Class) item)) {
throw new BindException("BindList got a list element which is not assignable to the given Type; " +
@@ -237,7 +237,7 @@ public class JavaConfigurationBuilderImpl extends ConfigurationBuilderImpl
}
private class JavaConfigurationImpl extends ConfigurationImpl {
- JavaConfigurationImpl(JavaConfigurationBuilderImpl builder) {
+ JavaConfigurationImpl(final JavaConfigurationBuilderImpl builder) {
super(builder);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java
index 9bac12d..d47ce83 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java
@@ -24,7 +24,7 @@ import org.apache.reef.tang.types.Node;
public final class JavaInstance<T> extends InjectionPlan<T> {
final T instance;
- public JavaInstance(Node name, T instance) {
+ public JavaInstance(final Node name, final T instance) {
super(name);
this.instance = instance;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java
index b7a2964..01a1766 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java
@@ -41,7 +41,7 @@ import java.util.Set;
public final class JavaNodeFactory {
@SuppressWarnings("unchecked")
- static <T> ClassNodeImpl<T> createClassNode(Node parent, Class<T> clazz) throws ClassHierarchyException {
+ static <T> ClassNodeImpl<T> createClassNode(final Node parent, final Class<T> clazz) throws ClassHierarchyException {
final boolean injectable;
final boolean unit = clazz.isAnnotationPresent(Unit.class);
final String simpleName = ReflectionUtilities.getSimpleName(clazz);
@@ -65,7 +65,7 @@ public final class JavaNodeFactory {
}
boolean foundNonStaticInnerClass = false;
- for (Class<?> c : clazz.getDeclaredClasses()) {
+ for (final Class<?> c : clazz.getDeclaredClasses()) {
if (!Modifier.isStatic(c.getModifiers())) {
foundNonStaticInnerClass = true;
}
@@ -77,12 +77,12 @@ public final class JavaNodeFactory {
" Such @Unit annotations would have no effect, and are therefore disallowed.");
}
- Constructor<T>[] constructors = (Constructor<T>[]) clazz
+ final Constructor<T>[] constructors = (Constructor<T>[]) clazz
.getDeclaredConstructors();
- MonotonicSet<ConstructorDef<T>> injectableConstructors = new MonotonicSet<>();
- ArrayList<ConstructorDef<T>> allConstructors = new ArrayList<>();
+ final MonotonicSet<ConstructorDef<T>> injectableConstructors = new MonotonicSet<>();
+ final ArrayList<ConstructorDef<T>> allConstructors = new ArrayList<>();
for (int k = 0; k < constructors.length; k++) {
- boolean constructorAnnotatedInjectable = (constructors[k]
+ final boolean constructorAnnotatedInjectable = (constructors[k]
.getAnnotation(Inject.class) != null);
if (constructorAnnotatedInjectable && constructors[k].isSynthetic()) {
// Not sure if we *can* unit test this one.
@@ -94,12 +94,12 @@ public final class JavaNodeFactory {
"Detected explicit constructor in class enclosed in @Unit " + fullName +
" Such constructors are disallowed.");
}
- boolean constructorInjectable = constructorAnnotatedInjectable || parentIsUnit;
+ final boolean constructorInjectable = constructorAnnotatedInjectable || parentIsUnit;
// ConstructorDef's constructor checks for duplicate
// parameters
// The injectableConstructors set checks for ambiguous
// boundConstructors.
- ConstructorDef<T> def = JavaNodeFactory.createConstructorDef(injectable,
+ final ConstructorDef<T> def = JavaNodeFactory.createConstructorDef(injectable,
constructors[k], constructorAnnotatedInjectable);
if (constructorInjectable) {
if (injectableConstructors.contains(def)) {
@@ -115,9 +115,9 @@ public final class JavaNodeFactory {
}
final String defaultImplementation;
if (clazz.isAnnotationPresent(DefaultImplementation.class)) {
- DefaultImplementation defaultImpl
+ final DefaultImplementation defaultImpl
= clazz.getAnnotation(DefaultImplementation.class);
- Class<?> defaultImplementationClazz = defaultImpl.value();
+ final Class<?> defaultImplementationClazz = defaultImpl.value();
if (defaultImplementationClazz.equals(Void.class)) {
defaultImplementation = defaultImpl.name();
// XXX check isAssignableFrom, other type problems here.
@@ -142,8 +142,9 @@ public final class JavaNodeFactory {
/**
* XXX: This method assumes that all generic types have exactly one type parameter.
*/
- public static <T> NamedParameterNode<T> createNamedParameterNode(Node parent,
- Class<? extends Name<T>> clazz, Type argClass)
+ public static <T> NamedParameterNode<T> createNamedParameterNode(final Node parent,
+ final Class<? extends Name<T>> clazz,
+ final Type argClass)
throws ClassHierarchyException {
Class<?> argRawClass = ReflectionUtilities.getRawClass(argClass);
@@ -151,16 +152,18 @@ public final class JavaNodeFactory {
final boolean isSet = argRawClass.equals(Set.class);
final boolean isList = argRawClass.equals(List.class);
+ final Type argClazz;
if (isSet || isList) {
- argClass = ReflectionUtilities.getInterfaceTarget(Collection.class, argClass);
- argRawClass = ReflectionUtilities.getRawClass(argClass);
+ argClazz = ReflectionUtilities.getInterfaceTarget(Collection.class, argClass);
+ } else {
+ argClazz = argClass;
}
final String simpleName = ReflectionUtilities.getSimpleName(clazz);
final String fullName = ReflectionUtilities.getFullName(clazz);
- final String fullArgName = ReflectionUtilities.getFullName(argClass);
- final String simpleArgName = ReflectionUtilities.getSimpleName(argClass);
+ final String fullArgName = ReflectionUtilities.getFullName(argClazz);
+ final String simpleArgName = ReflectionUtilities.getSimpleName(argClazz);
final NamedParameter namedParameter = clazz.getAnnotation(NamedParameter.class);
@@ -206,16 +209,16 @@ public final class JavaNodeFactory {
defaultInstanceAsStrings = new String[]{};
} else if (hasClassDefault) {
final Class<?> defaultClass = namedParameter.default_class();
- assertIsSubclassOf(clazz, defaultClass, argClass);
+ assertIsSubclassOf(clazz, defaultClass, argClazz);
defaultInstanceAsStrings = new String[]{ReflectionUtilities.getFullName(defaultClass)};
} else if (hasStringDefault) {
// Don't know if the string is a class or literal here, so don't bother validating.
defaultInstanceAsStrings = new String[]{namedParameter.default_value()};
} else if (hasClassSetDefault) {
- Class<?>[] clzs = namedParameter.default_classes();
+ final Class<?>[] clzs = namedParameter.default_classes();
defaultInstanceAsStrings = new String[clzs.length];
for (int i = 0; i < clzs.length; i++) {
- assertIsSubclassOf(clazz, clzs[i], argClass);
+ assertIsSubclassOf(clazz, clzs[i], argClazz);
defaultInstanceAsStrings[i] = ReflectionUtilities.getFullName(clzs[i]);
}
} else if (hasStringSetDefault) {
@@ -233,11 +236,11 @@ public final class JavaNodeFactory {
fullArgName, simpleArgName, isSet, isList, documentation, shortName, defaultInstanceAsStrings);
}
- private static void assertIsSubclassOf(Class<?> namedParameter, Class<?> defaultClass,
- Type argClass) {
+ private static void assertIsSubclassOf(final Class<?> namedParameter, final Class<?> defaultClass,
+ final Type argClass) {
boolean isSubclass = false;
boolean isGenericSubclass = false;
- Class<?> argRawClass = ReflectionUtilities.getRawClass(argClass);
+ final Class<?> argRawClass = ReflectionUtilities.getRawClass(argClass);
// Note: We intentionally strip the raw type information here. The reason is to handle
// EventHandler-style patterns and collections.
@@ -249,11 +252,11 @@ public final class JavaNodeFactory {
isSubclass = true;
if (argClass instanceof ParameterizedType &&
c instanceof ParameterizedType) {
- ParameterizedType argPt = (ParameterizedType) argClass;
- ParameterizedType defaultPt = (ParameterizedType) c;
+ final ParameterizedType argPt = (ParameterizedType) argClass;
+ final ParameterizedType defaultPt = (ParameterizedType) c;
- Class<?> rawDefaultParameter = ReflectionUtilities.getRawClass(defaultPt.getActualTypeArguments()[0]);
- Class<?> rawArgParameter = ReflectionUtilities.getRawClass(argPt.getActualTypeArguments()[0]);
+ final Class<?> rawDefaultParameter = ReflectionUtilities.getRawClass(defaultPt.getActualTypeArguments()[0]);
+ final Class<?> rawArgParameter = ReflectionUtilities.getRawClass(argPt.getActualTypeArguments()[0]);
for (final Type d : ReflectionUtilities.classAndAncestors(argPt.getActualTypeArguments()[0])) {
if (ReflectionUtilities.getRawClass(d).equals(rawDefaultParameter)) {
@@ -288,8 +291,8 @@ public final class JavaNodeFactory {
}
private static <T> ConstructorDef<T> createConstructorDef(
- boolean isClassInjectionCandidate, Constructor<T> constructor,
- boolean injectable) throws ClassHierarchyException {
+ final boolean isClassInjectionCandidate, final Constructor<T> constructor,
+ final boolean injectable) throws ClassHierarchyException {
// We don't support injection of non-static member classes with @Inject
// annotations.
if (injectable && !isClassInjectionCandidate) {
@@ -298,13 +301,13 @@ public final class JavaNodeFactory {
+ ReflectionUtilities.getFullName(constructor.getDeclaringClass()));
}
// TODO: When we use paramTypes below, we strip generic parameters. Is that OK?
- Class<?>[] paramTypes = constructor.getParameterTypes();
- Type[] genericParamTypes = constructor.getGenericParameterTypes();
- Annotation[][] paramAnnotations = constructor.getParameterAnnotations();
+ final Class<?>[] paramTypes = constructor.getParameterTypes();
+ final Type[] genericParamTypes = constructor.getGenericParameterTypes();
+ final Annotation[][] paramAnnotations = constructor.getParameterAnnotations();
if (paramTypes.length != paramAnnotations.length) {
throw new IllegalStateException();
}
- ConstructorArg[] args = new ConstructorArg[genericParamTypes.length];
+ final ConstructorArg[] args = new ConstructorArg[genericParamTypes.length];
for (int i = 0; i < genericParamTypes.length; i++) {
// If this parameter is an injection future, unwrap the target class,
// and remember by setting isFuture to true.
@@ -320,7 +323,7 @@ public final class JavaNodeFactory {
// Make node of the named parameter annotation (if any).
Parameter named = null;
for (int j = 0; j < paramAnnotations[i].length; j++) {
- Annotation annotation = paramAnnotations[i][j];
+ final Annotation annotation = paramAnnotations[i][j];
if (annotation instanceof Parameter) {
if ((!isClassInjectionCandidate) || !injectable) {
throw new ClassHierarchyException(constructor + " is not injectable, but it has an @Parameter annotation.");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java
index 4b0328f..83c7608 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java
@@ -52,30 +52,29 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
* as snapshots of Java class hierarchies.
* @deprecated in 0.12. Use AvroClassHierarchy instead
*/
- public ProtocolBufferClassHierarchy(ClassHierarchyProto.Node root) {
+ public ProtocolBufferClassHierarchy(final ClassHierarchyProto.Node root) {
namespace = new PackageNodeImpl();
if (!root.hasPackageNode()) {
throw new IllegalArgumentException("Expected a package node. Got: "
+ root);
}
// Register all the classes.
- for (ClassHierarchyProto.Node child : root.getChildrenList()) {
+ for (final ClassHierarchyProto.Node child : root.getChildrenList()) {
parseSubHierarchy(namespace, child);
}
buildLookupTable(namespace);
// Now, register the implementations
- for (ClassHierarchyProto.Node child : root.getChildrenList()) {
+ for (final ClassHierarchyProto.Node child : root.getChildrenList()) {
wireUpInheritanceRelationships(child);
}
}
- private static ClassHierarchyProto.Node newClassNode(String name,
- String fullName, boolean isInjectionCandidate,
- boolean isExternalConstructor, boolean isUnit,
- List<ClassHierarchyProto.ConstructorDef> injectableConstructors,
- List<ClassHierarchyProto.ConstructorDef> otherConstructors,
- List<String> implFullNames,
- Iterable<ClassHierarchyProto.Node> children) {
+ private static ClassHierarchyProto.Node newClassNode(
+ final String name, final String fullName, final boolean isInjectionCandidate,
+ final boolean isExternalConstructor, final boolean isUnit,
+ final List<ClassHierarchyProto.ConstructorDef> injectableConstructors,
+ final List<ClassHierarchyProto.ConstructorDef> otherConstructors, final List<String> implFullNames,
+ final Iterable<ClassHierarchyProto.Node> children) {
return ClassHierarchyProto.Node
.newBuilder()
.setName(name)
@@ -91,17 +90,17 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
.addAllChildren(children).build();
}
- private static ClassHierarchyProto.Node newNamedParameterNode(String name,
- String fullName,
- String simpleArgClassName,
- String fullArgClassName,
- boolean isSet,
- boolean isList,
- String documentation, // can be null
- String shortName, // can be null
- String[] instanceDefault, // can be null
- Iterable<ClassHierarchyProto.Node> children) {
- ClassHierarchyProto.NamedParameterNode.Builder namedParameterNodeBuilder
+ private static ClassHierarchyProto.Node newNamedParameterNode(final String name,
+ final String fullName,
+ final String simpleArgClassName,
+ final String fullArgClassName,
+ final boolean isSet,
+ final boolean isList,
+ final String documentation, // can be null
+ final String shortName, // can be null
+ final String[] instanceDefault, // can be null
+ final Iterable<ClassHierarchyProto.Node> children) {
+ final ClassHierarchyProto.NamedParameterNode.Builder namedParameterNodeBuilder
= ClassHierarchyProto.NamedParameterNode.newBuilder()
.setSimpleArgClassName(simpleArgClassName)
.setFullArgClassName(fullArgClassName)
@@ -123,16 +122,16 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
.addAllChildren(children).build();
}
- private static ClassHierarchyProto.Node newPackageNode(String name,
- String fullName,
- Iterable<ClassHierarchyProto.Node> children) {
+ private static ClassHierarchyProto.Node newPackageNode(final String name,
+ final String fullName,
+ final Iterable<ClassHierarchyProto.Node> children) {
return ClassHierarchyProto.Node.newBuilder()
.setPackageNode(ClassHierarchyProto.PackageNode.newBuilder().build())
.setName(name).setFullName(fullName).addAllChildren(children).build();
}
private static ClassHierarchyProto.ConstructorDef newConstructorDef(
- String fullClassName, List<ClassHierarchyProto.ConstructorArg> args) {
+ final String fullClassName, final List<ClassHierarchyProto.ConstructorArg> args) {
return ClassHierarchyProto.ConstructorDef.newBuilder()
.setFullClassName(fullClassName).addAllArgs(args).build();
}
@@ -141,8 +140,8 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
// protobufs
private static ClassHierarchyProto.ConstructorArg newConstructorArg(
- String fullArgClassName, String namedParameterName, boolean isFuture) {
- ClassHierarchyProto.ConstructorArg.Builder builder =
+ final String fullArgClassName, final String namedParameterName, final boolean isFuture) {
+ final ClassHierarchyProto.ConstructorArg.Builder builder =
ClassHierarchyProto.ConstructorArg.newBuilder()
.setFullArgClassName(fullArgClassName)
.setIsInjectionFuture(isFuture);
@@ -153,43 +152,43 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
}
private static ClassHierarchyProto.ConstructorDef serializeConstructorDef(
- ConstructorDef<?> def) {
- List<ClassHierarchyProto.ConstructorArg> args = new ArrayList<>();
- for (ConstructorArg arg : def.getArgs()) {
+ final ConstructorDef<?> def) {
+ final List<ClassHierarchyProto.ConstructorArg> args = new ArrayList<>();
+ for (final ConstructorArg arg : def.getArgs()) {
args.add(newConstructorArg(arg.getType(), arg.getNamedParameterName(), arg.isInjectionFuture()));
}
return newConstructorDef(def.getClassName(), args);
}
- private static ClassHierarchyProto.Node serializeNode(Node n) {
- List<ClassHierarchyProto.Node> children = new ArrayList<>();
- for (Node child : n.getChildren()) {
+ private static ClassHierarchyProto.Node serializeNode(final Node n) {
+ final List<ClassHierarchyProto.Node> children = new ArrayList<>();
+ for (final Node child : n.getChildren()) {
children.add(serializeNode(child));
}
if (n instanceof ClassNode) {
- ClassNode<?> cn = (ClassNode<?>) n;
- ConstructorDef<?>[] injectable = cn.getInjectableConstructors();
- ConstructorDef<?>[] all = cn.getAllConstructors();
- List<ConstructorDef<?>> others = new ArrayList<>(Arrays.asList(all));
+ final ClassNode<?> cn = (ClassNode<?>) n;
+ final ConstructorDef<?>[] injectable = cn.getInjectableConstructors();
+ final ConstructorDef<?>[] all = cn.getAllConstructors();
+ final List<ConstructorDef<?>> others = new ArrayList<>(Arrays.asList(all));
others.removeAll(Arrays.asList(injectable));
- List<ClassHierarchyProto.ConstructorDef> injectableConstructors = new ArrayList<>();
- for (ConstructorDef<?> inj : injectable) {
+ final List<ClassHierarchyProto.ConstructorDef> injectableConstructors = new ArrayList<>();
+ for (final ConstructorDef<?> inj : injectable) {
injectableConstructors.add(serializeConstructorDef(inj));
}
- List<ClassHierarchyProto.ConstructorDef> otherConstructors = new ArrayList<>();
- for (ConstructorDef<?> other : others) {
+ final List<ClassHierarchyProto.ConstructorDef> otherConstructors = new ArrayList<>();
+ for (final ConstructorDef<?> other : others) {
otherConstructors.add(serializeConstructorDef(other));
}
- List<String> implFullNames = new ArrayList<>();
- for (ClassNode<?> impl : cn.getKnownImplementations()) {
+ final List<String> implFullNames = new ArrayList<>();
+ for (final ClassNode<?> impl : cn.getKnownImplementations()) {
implFullNames.add(impl.getFullName());
}
return newClassNode(cn.getName(), cn.getFullName(),
cn.isInjectionCandidate(), cn.isExternalConstructor(), cn.isUnit(),
injectableConstructors, otherConstructors, implFullNames, children);
} else if (n instanceof NamedParameterNode) {
- NamedParameterNode<?> np = (NamedParameterNode<?>) n;
+ final NamedParameterNode<?> np = (NamedParameterNode<?>) n;
return newNamedParameterNode(np.getName(), np.getFullName(),
np.getSimpleArgName(), np.getFullArgName(), np.isSet(), np.isList(), np.getDocumentation(),
np.getShortName(), np.getDefaultInstanceAsStrings(), children);
@@ -207,7 +206,7 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
* @return
* @deprecated in 0.12. Use AvroClassHierarchySerializer instead
*/
- public static ClassHierarchyProto.Node serialize(ClassHierarchy classHierarchy) {
+ public static ClassHierarchyProto.Node serialize(final ClassHierarchy classHierarchy) {
return serializeNode(classHierarchy.getNamespace());
}
@@ -243,35 +242,34 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
}
}
- private static void parseSubHierarchy(Node parent, ClassHierarchyProto.Node n) {
+ private static void parseSubHierarchy(final Node parent, final ClassHierarchyProto.Node n) {
final Node parsed;
if (n.hasPackageNode()) {
parsed = new PackageNodeImpl(parent, n.getName(), n.getFullName());
} else if (n.hasNamedParameterNode()) {
- ClassHierarchyProto.NamedParameterNode np = n.getNamedParameterNode();
+ final ClassHierarchyProto.NamedParameterNode np = n.getNamedParameterNode();
parsed = new NamedParameterNodeImpl<Object>(parent, n.getName(),
n.getFullName(), np.getFullArgClassName(), np.getSimpleArgClassName(),
np.getIsSet(), np.getIsList(), np.getDocumentation(), np.getShortName(),
np.getInstanceDefaultList().toArray(new String[0]));
} else if (n.hasClassNode()) {
- ClassHierarchyProto.ClassNode cn = n.getClassNode();
- List<ConstructorDef<?>> injectableConstructors = new ArrayList<>();
- List<ConstructorDef<?>> allConstructors = new ArrayList<>();
+ final ClassHierarchyProto.ClassNode cn = n.getClassNode();
+ final List<ConstructorDef<?>> injectableConstructors = new ArrayList<>();
+ final List<ConstructorDef<?>> allConstructors = new ArrayList<>();
- for (ClassHierarchyProto.ConstructorDef injectable : cn
+ for (final ClassHierarchyProto.ConstructorDef injectable : cn
.getInjectableConstructorsList()) {
- ConstructorDef<?> def = parseConstructorDef(injectable, true);
+ final ConstructorDef<?> def = parseConstructorDef(injectable, true);
injectableConstructors.add(def);
allConstructors.add(def);
}
- for (ClassHierarchyProto.ConstructorDef other : cn
+ for (final ClassHierarchyProto.ConstructorDef other : cn
.getOtherConstructorsList()) {
- ConstructorDef<?> def = parseConstructorDef(other, false);
+ final ConstructorDef<?> def = parseConstructorDef(other, false);
allConstructors.add(def);
}
- @SuppressWarnings("unchecked")
- ConstructorDef<Object>[] dummy = new ConstructorDef[0];
+ @SuppressWarnings("unchecked") final ConstructorDef<Object>[] dummy = new ConstructorDef[0];
parsed = new ClassNodeImpl<>(parent, n.getName(), n.getFullName(),
cn.getIsUnit(), cn.getIsInjectionCandidate(),
cn.getIsExternalConstructor(), injectableConstructors.toArray(dummy),
@@ -280,16 +278,16 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
throw new IllegalStateException("Bad protocol buffer: got abstract node"
+ n);
}
- for (ClassHierarchyProto.Node child : n.getChildrenList()) {
+ for (final ClassHierarchyProto.Node child : n.getChildrenList()) {
parseSubHierarchy(parsed, child);
}
}
private static ConstructorDef<?> parseConstructorDef(
- org.apache.reef.tang.proto.ClassHierarchyProto.ConstructorDef def,
- boolean isInjectable) {
- List<ConstructorArg> args = new ArrayList<>();
- for (ClassHierarchyProto.ConstructorArg arg : def.getArgsList()) {
+ final org.apache.reef.tang.proto.ClassHierarchyProto.ConstructorDef def,
+ final boolean isInjectable) {
+ final List<ConstructorArg> args = new ArrayList<>();
+ for (final ClassHierarchyProto.ConstructorArg arg : def.getArgsList()) {
args.add(new ConstructorArgImpl(arg.getFullArgClassName(), arg
.getNamedParameterName(), arg.getIsInjectionFuture()));
}
@@ -297,26 +295,27 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
args.toArray(new ConstructorArg[0]), isInjectable);
}
- private static String getNthPrefix(String str, int n) {
- n++; // want this function to be zero indexed...
+ private static String getNthPrefix(final String str, final int n) {
+ int j = n;
+ j++; // want this function to be zero indexed...
for (int i = 0; i < str.length(); i++) {
- char c = str.charAt(i);
+ final char c = str.charAt(i);
if (c == '.' || c == '$' || c == '+') {
- n--;
+ j--;
}
- if (n == 0) {
+ if (j == 0) {
return str.substring(0, i);
}
}
- if (n == 1) {
+ if (j == 1) {
return str;
} else {
throw new ArrayIndexOutOfBoundsException();
}
}
- private void buildLookupTable(Node n) {
- for (Node child : n.getChildren()) {
+ private void buildLookupTable(final Node n) {
+ for (final Node child : n.getChildren()) {
lookupTable.put(child.getFullName(), child);
buildLookupTable(child);
}
@@ -329,23 +328,23 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
final ClassNode iface;
try {
iface = (ClassNode) getNode(n.getFullName());
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException("When reading protocol buffer node "
+ n.getFullName() + " does not exist. Full record is " + n, e);
}
- for (String impl : cn.getImplFullNamesList()) {
+ for (final String impl : cn.getImplFullNamesList()) {
try {
iface.putImpl((ClassNode) getNode(impl));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException("When reading protocol buffer node "
+ n + " refers to non-existent implementation:" + impl);
- } catch (ClassCastException e) {
+ } catch (final ClassCastException e) {
try {
throw new IllegalStateException(
"When reading protocol buffer node " + n
+ " found implementation" + getNode(impl)
+ " which is not a ClassNode!");
- } catch (NameResolutionException e2) {
+ } catch (final NameResolutionException e2) {
throw new IllegalStateException(
"Got 'cant happen' exception when producing error message for "
+ e);
@@ -354,15 +353,15 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
}
}
- for (ClassHierarchyProto.Node child : n.getChildrenList()) {
+ for (final ClassHierarchyProto.Node child : n.getChildrenList()) {
wireUpInheritanceRelationships(child);
}
}
@Override
- public Node getNode(String fullName) throws NameResolutionException {
+ public Node getNode(final String fullName) throws NameResolutionException {
- Node ret = lookupTable.get(fullName);
+ final Node ret = lookupTable.get(fullName);
if (ret != null) {
return ret;
} else {
@@ -371,12 +370,12 @@ public class ProtocolBufferClassHierarchy implements ClassHierarchy {
}
@Override
- public boolean isImplementation(ClassNode<?> inter, ClassNode<?> impl) {
+ public boolean isImplementation(final ClassNode<?> inter, final ClassNode<?> impl) {
return impl.isImplementationOf(inter);
}
@Override
- public ClassHierarchy merge(ClassHierarchy ch) {
+ public ClassHierarchy merge(final ClassHierarchy ch) {
if (this == ch) {
return this;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferInjectionPlan.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferInjectionPlan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferInjectionPlan.java
index 4caf3f5..0a6132c 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferInjectionPlan.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferInjectionPlan.java
@@ -36,7 +36,7 @@ import java.util.List;
public class ProtocolBufferInjectionPlan {
<T> InjectionPlanProto.InjectionPlan newConstructor(final String fullName,
- List<InjectionPlanProto.InjectionPlan> plans) {
+ final List<InjectionPlanProto.InjectionPlan> plans) {
return InjectionPlanProto.InjectionPlan
.newBuilder()
.setName(fullName)
@@ -46,7 +46,8 @@ public class ProtocolBufferInjectionPlan {
}
<T> InjectionPlanProto.InjectionPlan newSubplan(final String fullName,
- int selectedPlan, List<InjectionPlanProto.InjectionPlan> plans) {
+ final int selectedPlan,
+ final List<InjectionPlanProto.InjectionPlan> plans) {
return InjectionPlanProto.InjectionPlan
.newBuilder()
.setName(fullName)
@@ -63,27 +64,27 @@ public class ProtocolBufferInjectionPlan {
.build();
}
- public <T> InjectionPlanProto.InjectionPlan serialize(InjectionPlan<T> ip) {
+ public <T> InjectionPlanProto.InjectionPlan serialize(final InjectionPlan<T> ip) {
if (ip instanceof Constructor) {
- Constructor<T> cons = (Constructor<T>) ip;
- InjectionPlan<?>[] args = cons.getArgs();
- InjectionPlanProto.InjectionPlan[] protoArgs = new InjectionPlanProto.InjectionPlan[args.length];
+ final Constructor<T> cons = (Constructor<T>) ip;
+ final InjectionPlan<?>[] args = cons.getArgs();
+ final InjectionPlanProto.InjectionPlan[] protoArgs = new InjectionPlanProto.InjectionPlan[args.length];
for (int i = 0; i < args.length; i++) {
protoArgs[i] = serialize(args[i]);
}
return newConstructor(ip.getNode().getFullName(),
Arrays.asList(protoArgs));
} else if (ip instanceof Subplan) {
- Subplan<T> sp = (Subplan<T>) ip;
- InjectionPlan<?>[] args = sp.getPlans();
- InjectionPlanProto.InjectionPlan[] subPlans = new InjectionPlanProto.InjectionPlan[args.length];
+ final Subplan<T> sp = (Subplan<T>) ip;
+ final InjectionPlan<?>[] args = sp.getPlans();
+ final InjectionPlanProto.InjectionPlan[] subPlans = new InjectionPlanProto.InjectionPlan[args.length];
for (int i = 0; i < args.length; i++) {
subPlans[i] = serialize(args[i]);
}
return newSubplan(ip.getNode().getFullName(), sp.getSelectedIndex(),
Arrays.asList(subPlans));
} else if (ip instanceof JavaInstance) {
- JavaInstance<T> ji = (JavaInstance<T>) ip;
+ final JavaInstance<T> ji = (JavaInstance<T>) ip;
return newInstance(ip.getNode().getFullName(), ji.getInstanceAsString());
} else {
throw new IllegalStateException(
@@ -91,7 +92,7 @@ public class ProtocolBufferInjectionPlan {
}
}
- private Object parse(String type, String value) {
+ private Object parse(final String type, final String value) {
// XXX this is a placeholder for now. We need a parser API that will
// either produce a live java object or (partially) validate stuff to
// see if it looks like the target language will be able to handle this
@@ -100,8 +101,8 @@ public class ProtocolBufferInjectionPlan {
}
@SuppressWarnings("unchecked")
- public <T> InjectionPlan<T> deserialize(ClassHierarchy ch,
- InjectionPlanProto.InjectionPlan ip) throws NameResolutionException,
+ public <T> InjectionPlan<T> deserialize(final ClassHierarchy ch,
+ final InjectionPlanProto.InjectionPlan ip) throws NameResolutionException,
BindException {
final String fullName = ip.getName();
if (ip.hasConstructor()) {
@@ -126,8 +127,8 @@ public class ProtocolBufferInjectionPlan {
final ConstructorDef<T> constructor = cn.getConstructorDef(cnArgs);
return new Constructor<T>(cn, constructor, ipArgs);
} else if (ip.hasInstance()) {
- InjectionPlanProto.Instance ins = ip.getInstance();
- T instance = (T) parse(ip.getName(), ins.getValue());
+ final InjectionPlanProto.Instance ins = ip.getInstance();
+ final T instance = (T) parse(ip.getName(), ins.getValue());
return new JavaInstance<T>(ch.getNode(ip.getName()), instance);
} else if (ip.hasSubplan()) {
final InjectionPlanProto.Subplan subplan = ip.getSubplan();
@@ -138,7 +139,7 @@ public class ProtocolBufferInjectionPlan {
for (int i = 0; i < protoBufPlans.length; i++) {
subPlans[i] = (InjectionPlan<T>) deserialize(ch, protoBufPlans[i]);
}
- Node n = ch.getNode(fullName);
+ final Node n = ch.getNode(fullName);
return new Subplan<T>(n, subPlans);
} else {
throw new IllegalStateException(
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/AbstractNode.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/AbstractNode.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/AbstractNode.java
index e706491..9262bea 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/AbstractNode.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/AbstractNode.java
@@ -30,7 +30,7 @@ public abstract class AbstractNode implements Node {
private final String name;
private final String fullName;
- public AbstractNode(Node parent, String name, String fullName) {
+ public AbstractNode(final Node parent, final String name, final String fullName) {
this.parent = parent;
this.name = name;
this.fullName = fullName;
@@ -54,7 +54,7 @@ public abstract class AbstractNode implements Node {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (o == null) {
return false;
}
@@ -62,7 +62,7 @@ public abstract class AbstractNode implements Node {
return true;
}
- AbstractNode n = (AbstractNode) o;
+ final AbstractNode n = (AbstractNode) o;
final boolean parentsEqual;
if (n.parent == this.parent) {
parentsEqual = true;
@@ -90,29 +90,29 @@ public abstract class AbstractNode implements Node {
}
@Override
- public boolean contains(String key) {
+ public boolean contains(final String key) {
return children.containsKey(key);
}
@Override
- public Node get(String key) {
+ public Node get(final String key) {
return children.get(key);
}
@Override
- public void put(Node n) {
+ public void put(final Node n) {
children.put(n.getName(), n);
}
@SuppressWarnings("unused")
- private String toIndentedString(int level) {
- StringBuilder sb = new StringBuilder();
+ private String toIndentedString(final int level) {
+ final StringBuilder sb = new StringBuilder();
for (int i = 0; i < level; i++) {
sb.append("\t");
}
sb.append(toString() + "\n");
if (children != null) {
- for (Node n : children.values()) {
+ for (final Node n : children.values()) {
sb.append(((AbstractNode) n).toIndentedString(level + 1));
}
}
@@ -130,7 +130,7 @@ public abstract class AbstractNode implements Node {
}
@Override
- public int compareTo(Node n) {
+ public int compareTo(final Node n) {
return getFullName().compareTo(n.getFullName());
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ClassNodeImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ClassNodeImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ClassNodeImpl.java
index 75ca7fc..0e8a1d8 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ClassNodeImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ClassNodeImpl.java
@@ -37,11 +37,11 @@ public class ClassNodeImpl<T> extends AbstractNode implements ClassNode<T> {
private final MonotonicSet<ClassNode<T>> knownImpls;
private final String defaultImpl;
- public ClassNodeImpl(Node parent, String simpleName, String fullName,
- boolean unit, boolean injectable, boolean externalConstructor,
- ConstructorDef<T>[] injectableConstructors,
- ConstructorDef<T>[] allConstructors,
- String defaultImplementation) {
+ public ClassNodeImpl(final Node parent, final String simpleName, final String fullName,
+ final boolean unit, final boolean injectable, final boolean externalConstructor,
+ final ConstructorDef<T>[] injectableConstructors,
+ final ConstructorDef<T>[] allConstructors,
+ final String defaultImplementation) {
super(parent, simpleName, fullName);
this.unit = unit;
this.injectable = injectable;
@@ -74,9 +74,9 @@ public class ClassNodeImpl<T> extends AbstractNode implements ClassNode<T> {
@Override
public String toString() {
- StringBuilder sb = new StringBuilder(super.toString() + ": ");
+ final StringBuilder sb = new StringBuilder(super.toString() + ": ");
if (getInjectableConstructors() != null) {
- for (ConstructorDef<T> c : getInjectableConstructors()) {
+ for (final ConstructorDef<T> c : getInjectableConstructors()) {
sb.append(c.toString() + ", ");
}
} else {
@@ -85,13 +85,13 @@ public class ClassNodeImpl<T> extends AbstractNode implements ClassNode<T> {
return sb.toString();
}
- public ConstructorDef<T> getConstructorDef(ClassNode<?>... paramTypes)
+ public ConstructorDef<T> getConstructorDef(final ClassNode<?>... paramTypes)
throws BindException {
if (!isInjectionCandidate()) {
throw new BindException("Cannot @Inject non-static member/local class: "
+ getFullName());
}
- for (ConstructorDef<T> c : getAllConstructors()) {
+ for (final ConstructorDef<T> c : getAllConstructors()) {
if (c.takesParameters(paramTypes)) {
return c;
}
@@ -101,7 +101,7 @@ public class ClassNodeImpl<T> extends AbstractNode implements ClassNode<T> {
}
@Override
- public void putImpl(ClassNode<T> impl) {
+ public void putImpl(final ClassNode<T> impl) {
knownImpls.add(impl);
}
@@ -116,15 +116,15 @@ public class ClassNodeImpl<T> extends AbstractNode implements ClassNode<T> {
}
@Override
- public boolean isImplementationOf(ClassNode<?> inter) {
- List<ClassNode<?>> worklist = new ArrayList<>();
+ public boolean isImplementationOf(final ClassNode<?> inter) {
+ final List<ClassNode<?>> worklist = new ArrayList<>();
if (this.equals(inter)) {
return true;
}
worklist.add(inter);
while (!worklist.isEmpty()) {
- ClassNode<?> cn = worklist.remove(worklist.size() - 1);
- @SuppressWarnings({"rawtypes", "unchecked"})
+ final ClassNode<?> cn = worklist.remove(worklist.size() - 1);
+ @SuppressWarnings({"rawtypes", "unchecked"}) final
Set<ClassNode<?>> impls = (Set) cn.getKnownImplementations();
if (impls.contains(this)) {
return true;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorArgImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorArgImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorArgImpl.java
index 7297817..803875f 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorArgImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorArgImpl.java
@@ -25,7 +25,7 @@ public class ConstructorArgImpl implements ConstructorArg {
private final String name;
private final boolean isInjectionFuture;
- public ConstructorArgImpl(String type, String namedParameterName, boolean isInjectionFuture) {
+ public ConstructorArgImpl(final String type, final String namedParameterName, final boolean isInjectionFuture) {
this.type = type;
this.name = namedParameterName;
this.isInjectionFuture = isInjectionFuture;
@@ -52,8 +52,8 @@ public class ConstructorArgImpl implements ConstructorArg {
}
@Override
- public boolean equals(Object o) {
- ConstructorArgImpl arg = (ConstructorArgImpl) o;
+ public boolean equals(final Object o) {
+ final ConstructorArgImpl arg = (ConstructorArgImpl) o;
if (!type.equals(arg.type)) {
return false;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorDefImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorDefImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorDefImpl.java
index ef3ff9e..c2ac2fd 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorDefImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/ConstructorDefImpl.java
@@ -29,8 +29,8 @@ public class ConstructorDefImpl<T> implements ConstructorDef<T> {
private final ConstructorArg[] args;
private final String className;
- public ConstructorDefImpl(String className, ConstructorArg[] args,
- boolean injectable) throws ClassHierarchyException {
+ public ConstructorDefImpl(final String className, final ConstructorArg[] args,
+ final boolean injectable) throws ClassHierarchyException {
this.className = className;
this.args = args;
if (injectable) {
@@ -56,9 +56,9 @@ public class ConstructorDefImpl<T> implements ConstructorDef<T> {
return className;
}
- private String join(String sep, Object[] vals) {
+ private String join(final String sep, final Object[] vals) {
if (vals.length != 0) {
- StringBuilder sb = new StringBuilder(vals[0].toString());
+ final StringBuilder sb = new StringBuilder(vals[0].toString());
for (int i = 1; i < vals.length; i++) {
sb.append(sep + vals[i]);
}
@@ -70,7 +70,7 @@ public class ConstructorDefImpl<T> implements ConstructorDef<T> {
@Override
public String toString() {
- StringBuilder sb = new StringBuilder(className);
+ final StringBuilder sb = new StringBuilder(className);
sb.append("(");
sb.append(join(",", args));
sb.append(")");
@@ -78,7 +78,7 @@ public class ConstructorDefImpl<T> implements ConstructorDef<T> {
}
@Override
- public boolean takesParameters(ClassNode<?>[] paramTypes) {
+ public boolean takesParameters(final ClassNode<?>[] paramTypes) {
if (paramTypes.length != args.length) {
return false;
}
@@ -100,7 +100,7 @@ public class ConstructorDefImpl<T> implements ConstructorDef<T> {
* @param def
* @return
*/
- private boolean equalsIgnoreOrder(ConstructorDef<?> def) {
+ private boolean equalsIgnoreOrder(final ConstructorDef<?> def) {
if (getArgs().length != def.getArgs().length) {
return false;
}
@@ -119,12 +119,12 @@ public class ConstructorDefImpl<T> implements ConstructorDef<T> {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
return equalsIgnoreOrder((ConstructorDef<?>) o);
}
@Override
- public boolean isMoreSpecificThan(ConstructorDef<?> def) {
+ public boolean isMoreSpecificThan(final ConstructorDef<?> def) {
// Return true if our list of args is a superset of those in def.
// Is everything in def also in this?
@@ -147,13 +147,13 @@ public class ConstructorDefImpl<T> implements ConstructorDef<T> {
}
@Override
- public int compareTo(ConstructorDef<?> o) {
+ public int compareTo(final ConstructorDef<?> o) {
return toString().compareTo(o.toString());
}
@Override
public int hashCode() {
- ConstructorArg[] argsSort = getArgs().clone();
+ final ConstructorArg[] argsSort = getArgs().clone();
Arrays.sort(argsSort);
return Arrays.hashCode(argsSort);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/NamedParameterNodeImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/NamedParameterNodeImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/NamedParameterNodeImpl.java
index f25781e..fea5dd2 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/NamedParameterNodeImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/NamedParameterNodeImpl.java
@@ -31,10 +31,11 @@ public class NamedParameterNodeImpl<T> extends AbstractNode implements
private final boolean isSet;
private final boolean isList;
- public NamedParameterNodeImpl(Node parent, String simpleName,
- String fullName, String fullArgName, String simpleArgName,
- boolean isSet, boolean isList,
- String documentation, String shortName, String[] defaultInstanceAsStrings) {
+ public NamedParameterNodeImpl(final Node parent, final String simpleName,
+ final String fullName, final String fullArgName, final String simpleArgName,
+ final boolean isSet, final boolean isList,
+ final String documentation, final String shortName,
+ final String[] defaultInstanceAsStrings) {
super(parent, simpleName, fullName);
this.fullArgName = fullArgName;
this.simpleArgName = simpleArgName;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/PackageNodeImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/PackageNodeImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/PackageNodeImpl.java
index 4ed8ffb..ef2194f 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/PackageNodeImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/types/PackageNodeImpl.java
@@ -22,7 +22,7 @@ import org.apache.reef.tang.types.Node;
import org.apache.reef.tang.types.PackageNode;
public class PackageNodeImpl extends AbstractNode implements PackageNode {
- public PackageNodeImpl(Node parent, String name, String fullName) {
+ public PackageNodeImpl(final Node parent, final String name, final String fullName) {
super(parent, name, fullName);
}
@@ -36,7 +36,7 @@ public class PackageNodeImpl extends AbstractNode implements PackageNode {
* we insert nodes into the root.
*/
@Override
- public void put(Node n) {
+ public void put(final Node n) {
super.children.put(n.getFullName(), n);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/AbstractMonotonicMultiMap.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/AbstractMonotonicMultiMap.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/AbstractMonotonicMultiMap.java
index 884ccd6..c044654 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/AbstractMonotonicMultiMap.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/AbstractMonotonicMultiMap.java
@@ -25,11 +25,11 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
protected Map<K, Set<V>> map;
private int size = 0;
- public AbstractMonotonicMultiMap(Map<K, Set<V>> map) {
+ public AbstractMonotonicMultiMap(final Map<K, Set<V>> map) {
this.map = map;
}
- public void put(K key, V v) {
+ public void put(final K key, final V v) {
Set<V> vals = map.get(key);
if (vals == null) {
vals = new MonotonicHashSet<V>();
@@ -43,8 +43,8 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
return map.keySet();
}
- public Set<V> getValuesForKey(K key) {
- Set<V> ret = map.get(key);
+ public Set<V> getValuesForKey(final K key) {
+ final Set<V> ret = map.get(key);
if (ret == null) {
return new MonotonicHashSet<V>();
} else {
@@ -52,8 +52,8 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
}
}
- public boolean contains(K key, V v) {
- Set<V> vals = map.get(key);
+ public boolean contains(final K key, final V v) {
+ final Set<V> vals = map.get(key);
if (vals != null) {
return vals.contains(v);
}
@@ -61,15 +61,15 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
}
@Override
- public boolean add(Entry<K, V> e) {
+ public boolean add(final Entry<K, V> e) {
put(e.getKey(), e.getValue());
return true;
}
@Override
- public boolean addAll(Collection<? extends Entry<K, V>> c) {
+ public boolean addAll(final Collection<? extends Entry<K, V>> c) {
boolean ret = false;
- for (Entry<K, V> e : c) {
+ for (final Entry<K, V> e : c) {
add(e);
ret = true;
}
@@ -83,14 +83,14 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
@SuppressWarnings("unchecked")
@Override
- public boolean contains(Object o) {
- Entry<?, ?> e = (Entry<?, ?>) o;
+ public boolean contains(final Object o) {
+ final Entry<?, ?> e = (Entry<?, ?>) o;
return contains((K) e.getKey(), (V) e.getValue());
}
@Override
- public boolean containsAll(Collection<?> c) {
- for (Object o : c) {
+ public boolean containsAll(final Collection<?> c) {
+ for (final Object o : c) {
if (!contains(o)) {
return false;
}
@@ -119,7 +119,7 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
public Entry<K, V> next() {
if (cur == null) {
if (it.hasNext()) {
- Entry<K, Set<V>> e = it.next();
+ final Entry<K, Set<V>> e = it.next();
curKey = e.getKey();
cur = e.getValue().iterator();
}
@@ -143,7 +143,7 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
}
@Override
- public V setValue(V value) {
+ public V setValue(final V value) {
throw new UnsupportedOperationException();
}
@@ -159,25 +159,25 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
}
public Set<V> values() {
- Set<V> s = new HashSet<>();
- for (Entry<K, V> e : this) {
+ final Set<V> s = new HashSet<>();
+ for (final Entry<K, V> e : this) {
s.add(e.getValue());
}
return s;
}
@Override
- public boolean remove(Object o) {
+ public boolean remove(final Object o) {
throw new UnsupportedOperationException("MonotonicMultiMap does not support non-monotonic method remove!");
}
@Override
- public boolean removeAll(Collection<?> c) {
+ public boolean removeAll(final Collection<?> c) {
throw new UnsupportedOperationException("MonotonicMultiMap does not support non-monotonic method removeAll!");
}
@Override
- public boolean retainAll(Collection<?> c) {
+ public boolean retainAll(final Collection<?> c) {
throw new UnsupportedOperationException("MonotonicMultiMap does not support non-monotonic method retainAll!");
}
@@ -192,11 +192,11 @@ public abstract class AbstractMonotonicMultiMap<K, V> implements Collection<Entr
}
@Override
- public <T> T[] toArray(T[] a) {
+ public <T> T[] toArray(final T[] a) {
throw new UnsupportedOperationException("No toArray() for MonotonicMulitMap (yet)");
}
- public boolean containsKey(K k) {
+ public boolean containsKey(final K k) {
if (map.containsKey(k)) {
return !getValuesForKey(k).isEmpty();
} else {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashMap.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashMap.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashMap.java
index 5e99a28..f6fb1ab 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashMap.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashMap.java
@@ -25,8 +25,8 @@ public class MonotonicHashMap<T, U> extends HashMap<T, U> {
private static final long serialVersionUID = 1L;
@Override
- public U put(T key, U value) {
- U old = super.get(key);
+ public U put(final T key, final U value) {
+ final U old = super.get(key);
if (old != null) {
throw new IllegalArgumentException("Attempt to re-add: [" + key
+ "] old value: " + old + " new value " + value);
@@ -35,13 +35,13 @@ public class MonotonicHashMap<T, U> extends HashMap<T, U> {
}
@Override
- public void putAll(Map<? extends T, ? extends U> m) {
- for (T t : m.keySet()) {
+ public void putAll(final Map<? extends T, ? extends U> m) {
+ for (final T t : m.keySet()) {
if (containsKey(t)) {
put(t, m.get(t)); // guaranteed to throw.
}
}
- for (T t : m.keySet()) {
+ for (final T t : m.keySet()) {
put(t, m.get(t));
}
}
@@ -52,7 +52,7 @@ public class MonotonicHashMap<T, U> extends HashMap<T, U> {
}
@Override
- public U remove(Object o) {
+ public U remove(final Object o) {
throw new UnsupportedOperationException();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashSet.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashSet.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashSet.java
index 8c746ab..6a322c1 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashSet.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicHashSet.java
@@ -29,17 +29,17 @@ public class MonotonicHashSet<T> extends HashSet<T> {
super();
}
- public MonotonicHashSet(Collection<T> c) {
+ public MonotonicHashSet(final Collection<T> c) {
super(c);
}
@SafeVarargs
- public MonotonicHashSet(T... c) {
+ public MonotonicHashSet(final T... c) {
super(Arrays.asList(c));
}
@Override
- public boolean add(T e) {
+ public boolean add(final T e) {
if (super.contains(e)) {
throw new IllegalArgumentException("Attempt to re-add " + e
+ " to MonotonicSet!");
@@ -53,34 +53,34 @@ public class MonotonicHashSet<T> extends HashSet<T> {
}
@Override
- public boolean remove(Object o) {
+ public boolean remove(final Object o) {
throw new UnsupportedOperationException("Attempt to remove " + o
+ " from MonotonicSet!");
}
@Override
- public boolean removeAll(Collection<?> c) {
+ public boolean removeAll(final Collection<?> c) {
throw new UnsupportedOperationException(
"removeAll() doesn't make sense for MonotonicSet!");
}
@Override
- public boolean retainAll(Collection<?> c) {
+ public boolean retainAll(final Collection<?> c) {
throw new UnsupportedOperationException(
"retainAll() doesn't make sense for MonotonicSet!");
}
@Override
- public boolean addAll(Collection<? extends T> c) {
- for (T t : c) {
+ public boolean addAll(final Collection<? extends T> c) {
+ for (final T t : c) {
add(t);
}
return c.size() != 0;
}
- public boolean addAllIgnoreDuplicates(Collection<? extends T> c) {
+ public boolean addAllIgnoreDuplicates(final Collection<? extends T> c) {
boolean ret = false;
- for (T t : c) {
+ for (final T t : c) {
if (!contains(t)) {
add(t);
ret = true;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicSet.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicSet.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicSet.java
index 6d96186..59360a0 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicSet.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicSet.java
@@ -29,17 +29,17 @@ public class MonotonicSet<T> extends TreeSet<T> {
super();
}
- public MonotonicSet(TreeSet<T> c) {
+ public MonotonicSet(final TreeSet<T> c) {
super(c.comparator());
addAll(c);
}
- public MonotonicSet(Comparator<T> c) {
+ public MonotonicSet(final Comparator<T> c) {
super(c);
}
@Override
- public boolean add(T e) {
+ public boolean add(final T e) {
if (super.contains(e)) {
throw new IllegalArgumentException("Attempt to re-add " + e
+ " to MonotonicSet!");
@@ -53,34 +53,34 @@ public class MonotonicSet<T> extends TreeSet<T> {
}
@Override
- public boolean remove(Object o) {
+ public boolean remove(final Object o) {
throw new UnsupportedOperationException("Attempt to remove " + o
+ " from MonotonicSet!");
}
@Override
- public boolean removeAll(Collection<?> c) {
+ public boolean removeAll(final Collection<?> c) {
throw new UnsupportedOperationException(
"removeAll() doesn't make sense for MonotonicSet!");
}
@Override
- public boolean retainAll(Collection<?> c) {
+ public boolean retainAll(final Collection<?> c) {
throw new UnsupportedOperationException(
"retainAll() doesn't make sense for MonotonicSet!");
}
@Override
- public boolean addAll(Collection<? extends T> c) {
- for (T t : c) {
+ public boolean addAll(final Collection<? extends T> c) {
+ for (final T t : c) {
add(t);
}
return c.size() != 0;
}
- public boolean addAllIgnoreDuplicates(Collection<? extends T> c) {
+ public boolean addAllIgnoreDuplicates(final Collection<? extends T> c) {
boolean ret = false;
- for (T t : c) {
+ for (final T t : c) {
if (!contains(t)) {
add(t);
ret = true;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicTreeMap.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicTreeMap.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicTreeMap.java
index 3a353f0..52d4622 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicTreeMap.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/MonotonicTreeMap.java
@@ -55,8 +55,8 @@ public final class MonotonicTreeMap<T, U> implements Map<T, U> {
}
@Override
- public U put(T key, U value) {
- U old = innerMap.get(key);
+ public U put(final T key, final U value) {
+ final U old = innerMap.get(key);
if (old != null) {
throw new IllegalArgumentException("Attempt to re-add: [" + key
+ "]\n old value: " + old + " new value " + value);
@@ -65,7 +65,7 @@ public final class MonotonicTreeMap<T, U> implements Map<T, U> {
}
@Override
- public void putAll(Map<? extends T, ? extends U> m) {
+ public void putAll(final Map<? extends T, ? extends U> m) {
throw new UnsupportedOperationException();
}
@@ -90,12 +90,12 @@ public final class MonotonicTreeMap<T, U> implements Map<T, U> {
}
@Override
- public U remove(Object o) {
+ public U remove(final Object o) {
throw new UnsupportedOperationException();
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java
index 5275627..a91e18e 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java
@@ -64,7 +64,7 @@ public final class ReflectionUtilities {
* @param c The class to be boxed.
* @return The boxed version of c, or c if it is not a primitive type.
*/
- public static Class<?> boxClass(Class<?> c) {
+ public static Class<?> boxClass(final Class<?> c) {
if (c.isPrimitive() && c != Class.class) {
if (c == boolean.class) {
return Boolean.class;
@@ -103,26 +103,27 @@ public final class ReflectionUtilities {
* HashSet<T> -> {HashSet<T>, Set<T>, Collection<T>, Object}
* FooEventHandler -> {FooEventHandler, EventHandler<Foo>, Object}
*/
- public static Iterable<Type> classAndAncestors(Type c) {
- List<Type> workQueue = new ArrayList<>();
+ public static Iterable<Type> classAndAncestors(final Type c) {
+ final List<Type> workQueue = new ArrayList<>();
- workQueue.add(c);
- if (getRawClass(c).isInterface()) {
+ Type clazz = c;
+ workQueue.add(clazz);
+ if (getRawClass(clazz).isInterface()) {
workQueue.add(Object.class);
}
for (int i = 0; i < workQueue.size(); i++) {
- c = workQueue.get(i);
+ clazz = workQueue.get(i);
- if (c instanceof Class) {
- Class<?> clz = (Class<?>) c;
+ if (clazz instanceof Class) {
+ final Class<?> clz = (Class<?>) clazz;
final Type sc = clz.getSuperclass();
if (sc != null) {
workQueue.add(sc); //c.getSuperclass());
}
workQueue.addAll(Arrays.asList(clz.getGenericInterfaces()));
- } else if (c instanceof ParameterizedType) {
- ParameterizedType pt = (ParameterizedType) c;
- Class<?> rawPt = (Class<?>) pt.getRawType();
+ } else if (clazz instanceof ParameterizedType) {
+ final ParameterizedType pt = (ParameterizedType) clazz;
+ final Class<?> rawPt = (Class<?>) pt.getRawType();
final Type sc = rawPt.getSuperclass();
// workQueue.add(pt);
// workQueue.add(rawPt);
@@ -130,12 +131,12 @@ public final class ReflectionUtilities {
workQueue.add(sc);
}
workQueue.addAll(Arrays.asList(rawPt.getGenericInterfaces()));
- } else if (c instanceof WildcardType) {
+ } else if (clazz instanceof WildcardType) {
workQueue.add(Object.class); // XXX not really correct, but close enough?
- } else if (c instanceof TypeVariable) {
+ } else if (clazz instanceof TypeVariable) {
workQueue.add(Object.class); // XXX not really correct, but close enough?
} else {
- throw new RuntimeException(c.getClass() + " " + c + " is of unknown type!");
+ throw new RuntimeException(clazz.getClass() + " " + clazz + " is of unknown type!");
}
}
return workQueue;
@@ -151,14 +152,14 @@ public final class ReflectionUtilities {
* <p/>
* TODO: Float and double are currently coercible to int and long. This is a bug.
*/
- public static boolean isCoercable(Class<?> to, Class<?> from) {
- to = boxClass(to);
- from = boxClass(from);
- if (Number.class.isAssignableFrom(to)
- && Number.class.isAssignableFrom(from)) {
- return SIZEOF.get(from) <= SIZEOF.get(to);
+ public static boolean isCoercable(final Class<?> to, final Class<?> from) {
+ final Class<?> boxedTo = boxClass(to);
+ final Class<?> boxedFrom = boxClass(from);
+ if (Number.class.isAssignableFrom(boxedTo)
+ && Number.class.isAssignableFrom(boxedFrom)) {
+ return SIZEOF.get(boxedFrom) <= SIZEOF.get(boxedTo);
}
- return to.isAssignableFrom(from);
+ return boxedTo.isAssignableFrom(boxedFrom);
}
/**
@@ -168,7 +169,7 @@ public final class ReflectionUtilities {
*
* @throws ClassNotFoundException
*/
- public static Class<?> classForName(String name, ClassLoader loader)
+ public static Class<?> classForName(final String name, final ClassLoader loader)
throws ClassNotFoundException {
if (name.startsWith("[")) {
throw new UnsupportedOperationException("No support for arrays, etc. Name was: " + name);
@@ -204,7 +205,7 @@ public final class ReflectionUtilities {
* @param name
* @return
*/
- public static String getSimpleName(Type name) {
+ public static String getSimpleName(final Type name) {
final Class<?> clazz = getRawClass(name);
final String[] nameArray = clazz.getName().split(REGEXP);
final String ret = nameArray[nameArray.length - 1];
@@ -225,7 +226,7 @@ public final class ReflectionUtilities {
* @param name
* @return
*/
- public static String getFullName(Type name) {
+ public static String getFullName(final Type name) {
return getRawClass(name).getName();
}
@@ -238,7 +239,7 @@ public final class ReflectionUtilities {
* <p/>
* Set<X> { int size; } -> java.util.Set.size
*/
- public static String getFullName(Field f) {
+ public static String getFullName(final Field f) {
return getFullName(f.getDeclaringClass()) + "." + f.getName();
}
@@ -259,7 +260,7 @@ public final class ReflectionUtilities {
if (type instanceof ParameterizedType) {
final ParameterizedType pt = (ParameterizedType) type;
if (iface.isAssignableFrom((Class<?>) pt.getRawType())) {
- Type t = pt.getActualTypeArguments()[0];
+ final Type t = pt.getActualTypeArguments()[0];
return t;
} else {
throw new IllegalArgumentException("Parameterized type " + type + " does not extend " + iface);
@@ -271,20 +272,20 @@ public final class ReflectionUtilities {
throw new IllegalArgumentException();
}
- ArrayList<Type> al = new ArrayList<>();
+ final ArrayList<Type> al = new ArrayList<>();
al.addAll(Arrays.asList(clazz.getGenericInterfaces()));
- Type sc = clazz.getGenericSuperclass();
+ final Type sc = clazz.getGenericSuperclass();
if (sc != null) {
al.add(sc);
}
final Type[] interfaces = al.toArray(new Type[0]);
- for (Type genericNameType : interfaces) {
+ for (final Type genericNameType : interfaces) {
if (genericNameType instanceof ParameterizedType) {
- ParameterizedType ptype = (ParameterizedType) genericNameType;
+ final ParameterizedType ptype = (ParameterizedType) genericNameType;
if (ptype.getRawType().equals(iface)) {
- Type t = ptype.getActualTypeArguments()[0];
+ final Type t = ptype.getActualTypeArguments()[0];
return t;
}
}
@@ -301,22 +302,22 @@ public final class ReflectionUtilities {
* @throws org.apache.reef.tang.exceptions.BindException
* If clazz's definition incorrectly uses Name or @NamedParameter
*/
- public static Type getNamedParameterTargetOrNull(Class<?> clazz)
+ public static Type getNamedParameterTargetOrNull(final Class<?> clazz)
throws ClassHierarchyException {
- Annotation npAnnotation = clazz.getAnnotation(NamedParameter.class);
- boolean hasSuperClass = (clazz.getSuperclass() != Object.class);
+ final Annotation npAnnotation = clazz.getAnnotation(NamedParameter.class);
+ final boolean hasSuperClass = (clazz.getSuperclass() != Object.class);
boolean isInjectable = false;
boolean hasConstructor = false;
// TODO Figure out how to properly differentiate between default and
// non-default zero-arg constructors?
- Constructor<?>[] constructors = clazz.getDeclaredConstructors();
+ final Constructor<?>[] constructors = clazz.getDeclaredConstructors();
if (constructors.length > 1) {
hasConstructor = true;
}
if (constructors.length == 1) {
- Constructor<?> c = constructors[0];
- Class<?>[] p = c.getParameterTypes();
+ final Constructor<?> c = constructors[0];
+ final Class<?>[] p = c.getParameterTypes();
if (p.length > 1) {
// Multiple args. Definitely not implicit.
hasConstructor = true;
@@ -329,23 +330,23 @@ public final class ReflectionUtilities {
}
}
}
- for (Constructor<?> c : constructors) {
- for (Annotation a : c.getDeclaredAnnotations()) {
+ for (final Constructor<?> c : constructors) {
+ for (final Annotation a : c.getDeclaredAnnotations()) {
if (a instanceof Inject) {
isInjectable = true;
}
}
}
- Class<?>[] allInterfaces = clazz.getInterfaces();
+ final Class<?>[] allInterfaces = clazz.getInterfaces();
- boolean hasMultipleInterfaces = (allInterfaces.length > 1);
+ final boolean hasMultipleInterfaces = (allInterfaces.length > 1);
boolean implementsName;
Type parameterClass = null;
try {
parameterClass = getInterfaceTarget(Name.class, clazz);
implementsName = true;
- } catch (IllegalArgumentException e) {
+ } catch (final IllegalArgumentException e) {
implementsName = false;
}
@@ -394,7 +395,7 @@ public final class ReflectionUtilities {
* T -> Object
* ? -> Object
*/
- public static Class<?> getRawClass(Type clazz) {
+ public static Class<?> getRawClass(final Type clazz) {
if (clazz instanceof Class) {
return (Class<?>) clazz;
} else if (clazz instanceof ParameterizedType) {
[06/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
index 1eba8a1..e1e489e 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java
@@ -73,13 +73,13 @@ public class Tint {
this(new URL[0]);
}
- public Tint(URL[] jars) {
+ public Tint(final URL[] jars) {
this(jars, false);
}
@SuppressWarnings("unchecked")
- public Tint(URL[] jars, boolean checkTang) {
- Object[] args = new Object[jars.length + 6];
+ public Tint(final URL[] jars, final boolean checkTang) {
+ final Object[] args = new Object[jars.length + 6];
for (int i = 0; i < jars.length; i++) {
args[i] = jars[i];
}
@@ -89,31 +89,31 @@ public class Tint {
args[args.length - 4] = new MethodParameterScanner();
args[args.length - 5] = "com.microsoft";
args[args.length - 6] = "org.apache";
- Reflections r = new Reflections(args);
+ final Reflections r = new Reflections(args);
// Set<Class<?>> classes = new MonotonicSet<>();
- Set<String> strings = new TreeSet<>();
- Set<String> moduleBuilders = new MonotonicSet<>();
+ final Set<String> strings = new TreeSet<>();
+ final Set<String> moduleBuilders = new MonotonicSet<>();
// Workaround bug in Reflections by keeping things stringly typed, and using Tang to parse them.
// Set<Constructor<?>> injectConstructors = (Set<Constructor<?>>)(Set)r.getMethodsAnnotatedWith(Inject.class);
// for(Constructor<?> c : injectConstructors) {
// classes.add(c.getDeclaringClass());
// }
- Set<String> injectConstructors =
+ final Set<String> injectConstructors =
r.getStore().getConstructorsAnnotatedWith(ReflectionUtilities.getFullName(Inject.class));
- for (String s : injectConstructors) {
+ for (final String s : injectConstructors) {
strings.add(s.replaceAll("\\.<.+$", ""));
}
- Set<String> parameterConstructors =
+ final Set<String> parameterConstructors =
r.getStore().get(MethodParameterScanner.class, ReflectionUtilities.getFullName(Parameter.class));
- for (String s : parameterConstructors) {
+ for (final String s : parameterConstructors) {
strings.add(s.replaceAll("\\.<.+$", ""));
}
// Set<Class> r.getConstructorsWithAnyParamAnnotated(Parameter.class);
// for(Constructor<?> c : parameterConstructors) {
// classes.add(c.getDeclaringClass());
// }
- Set<String> defaultStrings =
+ final Set<String> defaultStrings =
r.getStore().get(TypeAnnotationsScanner.class, ReflectionUtilities.getFullName(DefaultImplementation.class));
strings.addAll(defaultStrings);
strings.addAll(r.getStore().get(TypeAnnotationsScanner.class,
@@ -141,7 +141,7 @@ public class Tint {
// }
// }
- for (String s : strings) {
+ for (final String s : strings) {
if (classFilter(checkTang, s)) {
try {
ch.getNode(s);
@@ -150,7 +150,7 @@ public class Tint {
}
}
}
- for (String s : moduleBuilders) {
+ for (final String s : moduleBuilders) {
if (classFilter(checkTang, s)) {
try {
ch.getNode(s);
@@ -160,12 +160,12 @@ public class Tint {
}
}
- NodeVisitor<Node> v = new AbstractClassHierarchyNodeVisitor() {
+ final NodeVisitor<Node> v = new AbstractClassHierarchyNodeVisitor() {
@Override
- public boolean visit(NamedParameterNode<?> node) {
- String nodeS = node.getFullName();
- for (String s : node.getDefaultInstanceAsStrings()) {
+ public boolean visit(final NamedParameterNode<?> node) {
+ final String nodeS = node.getFullName();
+ for (final String s : node.getDefaultInstanceAsStrings()) {
if (!usages.contains(s, nodeS)) {
usages.put(s, nodeS);
}
@@ -174,15 +174,15 @@ public class Tint {
}
@Override
- public boolean visit(PackageNode node) {
+ public boolean visit(final PackageNode node) {
return true;
}
@Override
- public boolean visit(ClassNode<?> node) {
- String nodeS = node.getFullName();
- for (ConstructorDef<?> d : node.getInjectableConstructors()) {
- for (ConstructorArg a : d.getArgs()) {
+ public boolean visit(final ClassNode<?> node) {
+ final String nodeS = node.getFullName();
+ for (final ConstructorDef<?> d : node.getInjectableConstructors()) {
+ for (final ConstructorArg a : d.getArgs()) {
if (a.getNamedParameterName() != null &&
!usages.contains(a.getNamedParameterName(), nodeS)) {
usages.put(a.getNamedParameterName(), nodeS);
@@ -201,25 +201,25 @@ public class Tint {
Walk.preorder(v, null, ch.getNamespace());
- for (ClassNode<?> cn : knownClasses) {
+ for (final ClassNode<?> cn : knownClasses) {
try {
- String s = cn.getFullName();
+ final String s = cn.getFullName();
if (classFilter(checkTang, s)) {
- Class<?> c = ch.classForName(s);
+ final Class<?> c = ch.classForName(s);
processDefaultAnnotation(c);
processConfigurationModules(c);
}
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
e.printStackTrace();
}
}
- for (Field f : modules.keySet()) {
- ConfigurationModule m = modules.get(f);
- String fS = ReflectionUtilities.getFullName(f);
- Set<NamedParameterNode<?>> nps = m.getBoundNamedParameters();
- for (NamedParameterNode<?> np : nps) {
- String npS = np.getFullName();
+ for (final Field f : modules.keySet()) {
+ final ConfigurationModule m = modules.get(f);
+ final String fS = ReflectionUtilities.getFullName(f);
+ final Set<NamedParameterNode<?>> nps = m.getBoundNamedParameters();
+ for (final NamedParameterNode<?> np : nps) {
+ final String npS = np.getFullName();
if (!setters.contains(npS, fS)) {
setters.put(npS, fS);
}
@@ -229,17 +229,17 @@ public class Tint {
}
- public static String stripCommonPrefixes(String s) {
+ public static String stripCommonPrefixes(final String s) {
return
stripPrefixHelper2(
stripPrefixHelper2(s, "java.lang"),
"java.util");
}
- public static String stripPrefixHelper2(String s, String prefix) {
- String[] pretok = prefix.split("\\.");
- String[] stok = s.split("\\.");
- StringBuffer sb = new StringBuffer();
+ public static String stripPrefixHelper2(final String s, final String prefix) {
+ final String[] pretok = prefix.split("\\.");
+ final String[] stok = s.split("\\.");
+ final StringBuffer sb = new StringBuffer();
int i;
for (i = 0; i < pretok.length && i < stok.length; i++) {
if (pretok[i].equals(stok[i])) {
@@ -272,7 +272,7 @@ public class Tint {
return s;
}
}*/
- public static String stripPrefix(String s, String prefix) {
+ public static String stripPrefix(final String s, final String prefix) {
return stripPrefixHelper2(stripPrefixHelper2(stripPrefixHelper2(
stripCommonPrefixes(stripPrefixHelper2(s, prefix)),
"org.apache.reef"), "org.apache.reef"), "org.apache.reef.wake");
@@ -283,7 +283,7 @@ public class Tint {
* @throws FileNotFoundException
* @throws MalformedURLException
*/
- public static void main(String[] args) throws FileNotFoundException, MalformedURLException {
+ public static void main(final String[] args) throws FileNotFoundException, MalformedURLException {
int i = 0;
String doc = null;
String jar = null;
@@ -338,9 +338,9 @@ public class Tint {
String currentPackage = "";
for (final Node n : t.getNamesUsedAndSet()) {
- String fullName = n.getFullName();
- String[] tok = fullName.split("\\.");
- StringBuffer sb = new StringBuffer(tok[0]);
+ final String fullName = n.getFullName();
+ final String[] tok = fullName.split("\\.");
+ final StringBuffer sb = new StringBuffer(tok[0]);
for (int j = 1; j < tok.length; j++) {
if (tok[j].matches("^[A-Z].*") || j > 4) {
break;
@@ -348,7 +348,7 @@ public class Tint {
sb.append("." + tok[j]);
}
}
- String pack = sb.toString();
+ final String pack = sb.toString();
if (!currentPackage.equals(pack)) {
currentPackage = pack;
out.println(t.endPackage());
@@ -366,13 +366,13 @@ public class Tint {
out.println(t.endPackage());
out.println("<div class='package'>Module definitions</div>");
for (final Field f : t.modules.keySet()) {
- String moduleName = ReflectionUtilities.getFullName(f);
+ final String moduleName = ReflectionUtilities.getFullName(f);
// String declaringClassName = ReflectionUtilities.getFullName(f.getDeclaringClass());
out.println("<div class='module-margin' id='" + moduleName + "'><div class='decl'><span class='fullName'>" +
moduleName + "</span>");
out.println("<pre>");
- String conf = t.modules.get(f).toPrettyString();
- String[] tok = conf.split("\n");
+ final String conf = t.modules.get(f).toPrettyString();
+ final String[] tok = conf.split("\n");
for (final String line : tok) {
out.println(stripPrefix(line, "no.such.prefix")); //t.modules.get(f).toPrettyString());
}
@@ -392,16 +392,16 @@ public class Tint {
Class<?> clz = null;
try {
clz = t.ch.classForName(c.getFullName());
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
- String typ = clz.isInterface() ? "interface" : "class";
+ final String typ = clz.isInterface() ? "interface" : "class";
out.println("<div class='module-margin' id='" + c.getFullName() + "'><div class='decl'>" +
"<span class='fullName'>" + typ + " " + c.getFullName() + "</span>");
- for (ConstructorDef<?> d : c.getInjectableConstructors()) {
+ for (final ConstructorDef<?> d : c.getInjectableConstructors()) {
out.println("<div class='uses'>" + c.getFullName() + "(");
- for (ConstructorArg a : d.getArgs()) {
+ for (final ConstructorArg a : d.getArgs()) {
if (a.getNamedParameterName() != null) {
out.print("<div class='constructorArg'><a href='#" + a.getType() + "'>" +
stripPrefix(a.getType(), "xxx") + "</a> <a href='#" + a.getNamedParameterName() + "'>" +
@@ -429,17 +429,17 @@ public class Tint {
}
}
- private boolean classFilter(boolean checkTang, String s) {
+ private boolean classFilter(final boolean checkTang, final String s) {
return (checkTang || !s.startsWith("org.apache.reef.tang"));
}
- private void processDefaultAnnotation(Class<?> cmb) {
- DefaultImplementation di = cmb.getAnnotation(DefaultImplementation.class);
+ private void processDefaultAnnotation(final Class<?> cmb) {
+ final DefaultImplementation di = cmb.getAnnotation(DefaultImplementation.class);
// XXX hack: move to helper method + unify with rest of Tang!
if (di != null) {
- String diName = di.value() == Void.class ? di.name() : ReflectionUtilities.getFullName(di.value());
- ClassNode<?> cn = (ClassNode<?>) ch.getNode(cmb);
- String cnS = cn.getFullName();
+ final String diName = di.value() == Void.class ? di.name() : ReflectionUtilities.getFullName(di.value());
+ final ClassNode<?> cn = (ClassNode<?>) ch.getNode(cmb);
+ final String cnS = cn.getFullName();
if (!usages.contains(diName, cnS)) {
usages.put(diName, cnS);
if (!knownClasses.contains(cn)) {
@@ -449,10 +449,10 @@ public class Tint {
}
}
- private void processConfigurationModules(Class<?> cmb) {
- for (Field f : cmb.getFields()) {
+ private void processConfigurationModules(final Class<?> cmb) {
+ for (final Field f : cmb.getFields()) {
if (ReflectionUtilities.isCoercable(ConfigurationModule.class, f.getType())) {
- int mod = f.getModifiers();
+ final int mod = f.getModifiers();
boolean ok = true;
if (Modifier.isPrivate(mod)) {
System.err.println("Found private ConfigurationModule " + f);
@@ -470,52 +470,52 @@ public class Tint {
// System.err.println("OK: " + f);
try {
f.setAccessible(true);
- String fS = ReflectionUtilities.getFullName(f);
+ final String fS = ReflectionUtilities.getFullName(f);
if (!modules.containsKey(f)) {
modules.put(f, (ConfigurationModule) (f.get(null)));
try {
modules.get(f).assertStaticClean();
- } catch (ClassHierarchyException e) {
+ } catch (final ClassHierarchyException e) {
System.err.println(fS + ": " + e.getMessage());
}
- for (Entry<String, String> e : modules.get(f).toStringPairs()) {
+ for (final Entry<String, String> e : modules.get(f).toStringPairs()) {
//System.err.println("e: " + e.getKey() + "=" + e.getValue());
try {
- Node n = ch.getNode(e.getKey());
+ final Node n = ch.getNode(e.getKey());
if (!setters.contains(e.getKey(), fS)) {
setters.put(e.getKey(), fS);
}
if (n instanceof ClassNode) {
- ClassNode<?> cn = (ClassNode<?>) n;
+ final ClassNode<?> cn = (ClassNode<?>) n;
if (!knownClasses.contains(cn)) {
knownClasses.add(cn);
}
}
- } catch (NameResolutionException ex) {
+ } catch (final NameResolutionException ex) {
//
}
try {
- String s = e.getValue();
- Node n = ch.getNode(s);
+ final String s = e.getValue();
+ final Node n = ch.getNode(s);
if (!usages.contains(ReflectionUtilities.getFullName(f), s)) {
// System.err.println("Added usage: " + ReflectionUtilities.getFullName(f) + "=" + s);
usages.put(s, ReflectionUtilities.getFullName(f));
}
if (n instanceof ClassNode) {
- ClassNode<?> cn = (ClassNode<?>) n;
+ final ClassNode<?> cn = (ClassNode<?>) n;
if (!knownClasses.contains(cn)) {
System.err.println("Added " + cn + " to known classes");
knownClasses.add(cn);
}
}
- } catch (NameResolutionException ex) {
+ } catch (final NameResolutionException ex) {
//
}
}
}
- } catch (ExceptionInInitializerError e) {
+ } catch (final ExceptionInInitializerError e) {
System.err.println("Field " + ReflectionUtilities.getFullName(f) + ": " + e.getCause().getMessage());
- } catch (IllegalAccessException e) {
+ } catch (final IllegalAccessException e) {
throw new RuntimeException(e);
}
}
@@ -525,21 +525,21 @@ public class Tint {
public Set<NamedParameterNode<?>> getNames() {
final Set<NamedParameterNode<?>> names = new MonotonicSet<>();
- NodeVisitor<Node> v = new AbstractClassHierarchyNodeVisitor() {
+ final NodeVisitor<Node> v = new AbstractClassHierarchyNodeVisitor() {
@Override
- public boolean visit(NamedParameterNode<?> node) {
+ public boolean visit(final NamedParameterNode<?> node) {
names.add(node);
return true;
}
@Override
- public boolean visit(PackageNode node) {
+ public boolean visit(final PackageNode node) {
return true;
}
@Override
- public boolean visit(ClassNode<?> node) {
+ public boolean visit(final ClassNode<?> node) {
return true;
}
};
@@ -552,22 +552,22 @@ public class Tint {
final Set<String> userKeys = usages.keySet();
final Set<String> usedKeys = usages.values();
final Set<String> setterKeys = setters.keySet();
- NodeVisitor<Node> v = new AbstractClassHierarchyNodeVisitor() {
+ final NodeVisitor<Node> v = new AbstractClassHierarchyNodeVisitor() {
@Override
- public boolean visit(NamedParameterNode<?> node) {
+ public boolean visit(final NamedParameterNode<?> node) {
names.add(node);
return true;
}
@Override
- public boolean visit(PackageNode node) {
+ public boolean visit(final PackageNode node) {
return true;
}
@Override
- public boolean visit(ClassNode<?> node) {
- String nodeS = node.getFullName();
+ public boolean visit(final ClassNode<?> node) {
+ final String nodeS = node.getFullName();
if (userKeys.contains(nodeS)) {
names.add(node);
}
@@ -596,9 +596,9 @@ public class Tint {
return setters.getValuesForKey(name.getFullName());
}
- public String toString(NamedParameterNode<?> n) {
- StringBuilder sb = new StringBuilder("Name: " + n.getSimpleArgName() + " " + n.getFullName());
- String[] instances = n.getDefaultInstanceAsStrings();
+ public String toString(final NamedParameterNode<?> n) {
+ final StringBuilder sb = new StringBuilder("Name: " + n.getSimpleArgName() + " " + n.getFullName());
+ final String[] instances = n.getDefaultInstanceAsStrings();
if (instances.length != 0) {
sb.append(" = ");
sb.append(join(",", instances));
@@ -609,9 +609,9 @@ public class Tint {
return sb.toString();
}
- private String join(String sep, String[] s) {
+ private String join(final String sep, final String[] s) {
if (s.length > 0) {
- StringBuffer sb = new StringBuffer(s[0]);
+ final StringBuffer sb = new StringBuffer(s[0]);
for (int i = 1; i < s.length; i++) {
sb.append(sep);
sb.append(s[i]);
@@ -622,34 +622,35 @@ public class Tint {
}
}
- public String cell(String s, String clazz) {
- if (clazz.equals(USES) && s.length() > 0) {
- s = "<em>Used by:</em><br>" + s;
+ public String cell(final String s, final String clazz) {
+ String str = s;
+ if (clazz.equals(USES) && str.length() > 0) {
+ str = "<em>Used by:</em><br>" + str;
}
- if (clazz.equals(SETTERS) && s.length() > 0) {
- s = "<em>Set by:</em><br>" + s;
+ if (clazz.equals(SETTERS) && str.length() > 0) {
+ str = "<em>Set by:</em><br>" + str;
}
if (clazz.equals(FULLNAME)) {
- s = " " + s;
+ str = " " + str;
}
if (divs.contains(clazz)) {
- return "<div class=\"" + clazz + "\">" + s + "</div>";
+ return "<div class=\"" + clazz + "\">" + str + "</div>";
} else {
- return "<span class=\"" + clazz + "\">" + s + "</span>";
+ return "<span class=\"" + clazz + "\">" + str + "</span>";
}
}
- public String cell(StringBuffer sb, String clazz) {
+ public String cell(final StringBuffer sb, final String clazz) {
return cell(sb.toString(), clazz);
}
- public String row(StringBuffer sb) {
+ public String row(final StringBuffer sb) {
return sb.toString();
}
- public String toHtmlString(NamedParameterNode<?> n, String pack) {
- String fullName = stripPrefix(n.getFullName(), pack);
- StringBuffer sb = new StringBuffer();
+ public String toHtmlString(final NamedParameterNode<?> n, final String pack) {
+ final String fullName = stripPrefix(n.getFullName(), pack);
+ final StringBuffer sb = new StringBuffer();
sb.append("<div id='" + n.getFullName() + "' class='decl-margin'>");
sb.append("<div class='decl'>");
@@ -658,7 +659,7 @@ public class Tint {
final String instance;
final String[] instances = n.getDefaultInstanceAsStrings();
if (instances.length != 0) {
- StringBuffer sb2 = new StringBuffer(" = " + stripPrefix(instances[0], pack));
+ final StringBuffer sb2 = new StringBuffer(" = " + stripPrefix(instances[0], pack));
for (int i = 1; i < instances.length; i++) {
sb2.append("," + stripPrefix(instances[i], pack));
}
@@ -667,18 +668,18 @@ public class Tint {
instance = "";
}
sb.append(cell(instance, "instance"));
- StringBuffer doc = new StringBuffer();
+ final StringBuffer doc = new StringBuffer();
if (!n.getDocumentation().equals("")) {
doc.append(n.getDocumentation());
}
sb.append(cell(doc, "doc"));
- StringBuffer uses = new StringBuffer();
- for (String u : getUsesOf(n)) {
+ final StringBuffer uses = new StringBuffer();
+ for (final String u : getUsesOf(n)) {
uses.append("<a href='#" + u + "'>" + stripPrefix(u, pack) + "</a> ");
}
sb.append(cell(uses, USES));
- StringBuffer settersStr = new StringBuffer();
- for (String f : getSettersOf(n)) {
+ final StringBuffer settersStr = new StringBuffer();
+ for (final String f : getSettersOf(n)) {
settersStr.append("<a href='#" + f + "'>" + stripPrefix(f, pack) + "</a> ");
}
sb.append(cell(settersStr, SETTERS));
@@ -687,8 +688,8 @@ public class Tint {
return row(sb);
}
- public String toHtmlString(ClassNode<?> n, String pack) {
- String fullName = stripPrefix(n.getFullName(), pack);
+ public String toHtmlString(final ClassNode<?> n, final String pack) {
+ final String fullName = stripPrefix(n.getFullName(), pack);
final String type;
try {
@@ -697,10 +698,10 @@ public class Tint {
} else {
type = "class";
}
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
throw new RuntimeException(e);
}
- StringBuffer sb = new StringBuffer();
+ final StringBuffer sb = new StringBuffer();
sb.append("<div class='decl-margin' id='" + n.getFullName() + "'>");
sb.append("<div class='decl'>");
@@ -713,13 +714,13 @@ public class Tint {
}
sb.append(cell(instance, "simpleName"));
sb.append(cell("", "fullName")); // TODO: Documentation string?
- StringBuffer uses = new StringBuffer();
- for (String u : getUsesOf(n)) {
+ final StringBuffer uses = new StringBuffer();
+ for (final String u : getUsesOf(n)) {
uses.append("<a href='#" + u + "'>" + stripPrefix(u, pack) + "</a> ");
}
sb.append(cell(uses, USES));
- StringBuffer settersStr = new StringBuffer();
- for (String f : getSettersOf(n)) {
+ final StringBuffer settersStr = new StringBuffer();
+ for (final String f : getSettersOf(n)) {
settersStr.append("<a href='#" + f + "'>" + stripPrefix(f, pack) + "</a> ");
}
sb.append(cell(settersStr, SETTERS));
@@ -728,7 +729,7 @@ public class Tint {
return row(sb);
}
- public String startPackage(String pack) {
+ public String startPackage(final String pack) {
return "<div class=\"package\">" + pack + "</div>";
// return "<tr><td colspan='6'><br><b>" + pack + "</b></td></tr>";
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/TracingMonotonicTreeMap.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/TracingMonotonicTreeMap.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/TracingMonotonicTreeMap.java
index 1fb87e3..e46808d 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/TracingMonotonicTreeMap.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/TracingMonotonicTreeMap.java
@@ -34,12 +34,12 @@ public final class TracingMonotonicTreeMap<K, V> implements TracingMonotonicMap<
}
@Override
- public boolean containsKey(Object key) {
+ public boolean containsKey(final Object key) {
return innerMap.containsKey(key);
}
@Override
- public boolean containsValue(Object value) {
+ public boolean containsValue(final Object value) {
throw new UnsupportedOperationException();
}
@@ -49,8 +49,8 @@ public final class TracingMonotonicTreeMap<K, V> implements TracingMonotonicMap<
}
@Override
- public V get(Object key) {
- EntryImpl ret = innerMap.get(key);
+ public V get(final Object key) {
+ final EntryImpl ret = innerMap.get(key);
return ret != null ? ret.getKey() : null;
}
@@ -65,18 +65,18 @@ public final class TracingMonotonicTreeMap<K, V> implements TracingMonotonicMap<
}
@Override
- public V put(K key, V value) {
- EntryImpl ret = innerMap.put(key, new EntryImpl(value, new StackBindLocation()));
+ public V put(final K key, final V value) {
+ final EntryImpl ret = innerMap.put(key, new EntryImpl(value, new StackBindLocation()));
return ret != null ? ret.getKey() : null;
}
@Override
- public void putAll(Map<? extends K, ? extends V> m) {
+ public void putAll(final Map<? extends K, ? extends V> m) {
throw new UnsupportedOperationException();
}
@Override
- public V remove(Object key) {
+ public V remove(final Object key) {
throw new UnsupportedOperationException();
}
@@ -91,7 +91,7 @@ public final class TracingMonotonicTreeMap<K, V> implements TracingMonotonicMap<
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -117,7 +117,7 @@ public final class TracingMonotonicTreeMap<K, V> implements TracingMonotonicMap<
private final V key;
private final BindLocation value;
- EntryImpl(V key, BindLocation value) {
+ EntryImpl(final V key, final BindLocation value) {
this.key = key;
this.value = value;
}
@@ -134,7 +134,7 @@ public final class TracingMonotonicTreeMap<K, V> implements TracingMonotonicMap<
@Override
@SuppressWarnings("checkstyle:hiddenfield")
- public BindLocation setValue(BindLocation value) {
+ public BindLocation setValue(final BindLocation value) {
throw new UnsupportedOperationException();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java
index a50a9eb..331f384 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java
@@ -47,9 +47,9 @@ public class ValidateConfiguration {
@Inject
public ValidateConfiguration(
- @Parameter(ClassHierarchyIn.class) File ch,
- @Parameter(ConfigurationIn.class) File inConfig,
- @Parameter(ConfigurationOut.class) File outConfig) {
+ @Parameter(ClassHierarchyIn.class) final File ch,
+ @Parameter(ConfigurationIn.class) final File inConfig,
+ @Parameter(ConfigurationOut.class) final File outConfig) {
this.target = null;
this.ch = ch;
this.inConfig = inConfig;
@@ -59,27 +59,27 @@ public class ValidateConfiguration {
@Inject
public ValidateConfiguration(
- @Parameter(Target.class) String injectedClass,
- @Parameter(ClassHierarchyIn.class) File ch,
- @Parameter(ConfigurationIn.class) File inConfig,
- @Parameter(ConfigurationOut.class) File outConfig) {
+ @Parameter(Target.class) final String injectedClass,
+ @Parameter(ClassHierarchyIn.class) final File ch,
+ @Parameter(ConfigurationIn.class) final File inConfig,
+ @Parameter(ConfigurationOut.class) final File outConfig) {
this.target = injectedClass;
this.ch = ch;
this.inConfig = inConfig;
this.outConfig = outConfig;
}
- public static void main(String[] argv) throws IOException, BindException, InjectionException {
- @SuppressWarnings("unchecked")
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder(
+ public static void main(final String[] argv) throws IOException, BindException, InjectionException {
+ @SuppressWarnings("unchecked") final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder(
(Class<? extends ExternalConstructor<?>>[]) new Class[]{FileParser.class});
- CommandLine cl = new CommandLine(cb);
+ final CommandLine cl = new CommandLine(cb);
cl.processCommandLine(argv,
Target.class,
ClassHierarchyIn.class,
ConfigurationIn.class,
ConfigurationOut.class);
- ValidateConfiguration bip = Tang.Factory.getTang().newInjector(cb.build()).getInstance(ValidateConfiguration.class);
+ final ValidateConfiguration bip =
+ Tang.Factory.getTang().newInjector(cb.build()).getInstance(ValidateConfiguration.class);
bip.validatePlan();
}
@@ -123,7 +123,7 @@ public class ValidateConfiguration {
private final File f;
@Inject
- FileParser(String name) {
+ FileParser(final String name) {
f = new File(name);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/walk/graphviz/GraphvizConfigVisitor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/walk/graphviz/GraphvizConfigVisitor.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/walk/graphviz/GraphvizConfigVisitor.java
index 835fa92..f6655f2 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/walk/graphviz/GraphvizConfigVisitor.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/walk/graphviz/GraphvizConfigVisitor.java
@@ -206,13 +206,13 @@ public final class GraphvizConfigVisitor
return true;
}
- private String instancesToString(String[] s) {
+ private String instancesToString(final String[] s) {
if (s.length == 0) {
return "null";
} else if (s.length == 1) {
return s[0];
} else {
- StringBuffer sb = new StringBuffer("[" + s[0]);
+ final StringBuffer sb = new StringBuffer("[" + s[0]);
for (int i = 1; i < s.length; i++) {
sb.append(",");
sb.append(s[i]);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java
index de9522d..2a39b3d 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java
@@ -52,12 +52,12 @@ public class ClassHierarchyDeserializationTest {
// TODO: Use AvroClassHierarchySerializer instead (REEF-400)
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(chin);
final ClassHierarchy ch = new ProtocolBufferClassHierarchy(root);
- Node n1 = ch.getNode("Org.Apache.REEF.Examples.Tasks.StreamingTasks.StreamTask1, " +
+ final Node n1 = ch.getNode("Org.Apache.REEF.Examples.Tasks.StreamingTasks.StreamTask1, " +
"Org.Apache.REEF.Examples.Tasks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null");
Assert.assertTrue(n1.getFullName().equals("Org.Apache.REEF.Examples.Tasks.StreamingTasks.StreamTask1, " +
"Org.Apache.REEF.Examples.Tasks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"));
- Node n2 = ch.getNode("Org.Apache.REEF.Examples.Tasks.HelloTask.HelloTask, " +
+ final Node n2 = ch.getNode("Org.Apache.REEF.Examples.Tasks.HelloTask.HelloTask, " +
"Org.Apache.REEF.Examples.Tasks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null");
Assert.assertTrue(n2.getFullName().equals("Org.Apache.REEF.Examples.Tasks.HelloTask.HelloTask, " +
"Org.Apache.REEF.Examples.Tasks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
index 23e6b5b..e1e611b 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
@@ -85,8 +85,8 @@ public class TestBindSingleton {
@Test
public void testLateBoundVolatileInstanceWithSingletonX()
throws BindException, InjectionException {
- Tang tang = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final Tang tang = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.bindImplementation(LateBoundVolatile.A.class,
LateBoundVolatile.B.class);
final Injector i = tang.newInjector(cb.build());
@@ -117,9 +117,9 @@ public class TestBindSingleton {
@Test
public void testLateBoundVolatileInstanceWithSingletonY()
throws BindException, InjectionException {
- Tang tang = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
- Injector i = tang.newInjector(cb.build());
+ final Tang tang = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final Injector i = tang.newInjector(cb.build());
i.bindVolatileInstance(LateBoundVolatile.C.class, new LateBoundVolatile.C());
i.getInstance(LateBoundVolatile.C.class);
}
@@ -127,79 +127,79 @@ public class TestBindSingleton {
@Test
public void testLateBoundVolatileInstanceWithSingletonZ()
throws BindException, InjectionException {
- Tang tang = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final Tang tang = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
cb.bindImplementation(LateBoundVolatile.B.class,
LateBoundVolatile.B.class);
- Injector i = tang.newInjector(cb.build());
+ final Injector i = tang.newInjector(cb.build());
i.bindVolatileInstance(LateBoundVolatile.C.class, new LateBoundVolatile.C());
i.getInstance(LateBoundVolatile.B.class);
}
@Test
public void testInbredSingletons() throws BindException, InjectionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bindImplementation(InbredSingletons.A.class,
InbredSingletons.A.class);
b.bindImplementation(InbredSingletons.B.class,
InbredSingletons.B.class);
b.bindImplementation(InbredSingletons.C.class,
InbredSingletons.C.class);
- Injector i = t.newInjector(b.build());
+ final Injector i = t.newInjector(b.build());
i.getInstance(InbredSingletons.A.class);
}
@Test
public void testIncestuousSingletons() throws BindException,
InjectionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bindImplementation(IncestuousSingletons.A.class,
IncestuousSingletons.A.class);
b.bindImplementation(IncestuousSingletons.B.class,
IncestuousSingletons.B.class);
b.bindImplementation(IncestuousSingletons.C.class,
IncestuousSingletons.C.class);
- Injector i = t.newInjector(b.build());
+ final Injector i = t.newInjector(b.build());
i.getInstance(IncestuousSingletons.A.class);
}
@Test
public void testIncestuousSingletons2() throws BindException,
InjectionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bindImplementation(IncestuousSingletons.A.class,
IncestuousSingletons.A.class);
b.bindImplementation(IncestuousSingletons.B.class,
IncestuousSingletons.BN.class);
b.bindImplementation(IncestuousSingletons.C.class,
IncestuousSingletons.C.class);
- Injector i = t.newInjector(b.build());
+ final Injector i = t.newInjector(b.build());
i.getInstance(IncestuousSingletons.A.class);
}
@Test
public void testIncestuousInterfaceSingletons() throws BindException,
InjectionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bindImplementation(IncestuousInterfaceSingletons.AI.class,
IncestuousInterfaceSingletons.A.class);
b.bindImplementation(IncestuousInterfaceSingletons.BI.class,
IncestuousInterfaceSingletons.BN.class);
b.bindImplementation(IncestuousInterfaceSingletons.CI.class,
IncestuousInterfaceSingletons.C.class);
- Injector i = t.newInjector(b.build());
+ final Injector i = t.newInjector(b.build());
i.getInstance(IncestuousInterfaceSingletons.AI.class);
}
@Test
public void testIncestuousInterfaceSingletons2() throws BindException,
InjectionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bindImplementation(IncestuousInterfaceSingletons.AI.class,
IncestuousInterfaceSingletons.A.class);
b.bindImplementation(IncestuousInterfaceSingletons.BI.class,
@@ -209,14 +209,14 @@ public class TestBindSingleton {
IncestuousInterfaceSingletons.B.class);
b.bindImplementation(IncestuousInterfaceSingletons.CI.class,
IncestuousInterfaceSingletons.C.class);
- Injector i = t.newInjector(b.build());
+ final Injector i = t.newInjector(b.build());
i.getInstance(IncestuousInterfaceSingletons.AI.class);
}
@Test
public void testIsBrokenClassInjectable() throws BindException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bind(IsBrokenClassInjectable.class, IsBrokenClassInjectable.class);
Assert.assertTrue(t.newInjector(b.build()).isInjectable(
IsBrokenClassInjectable.class));
@@ -224,8 +224,8 @@ public class TestBindSingleton {
@Test
public void testIsBrokenSingletonClassInjectable() throws BindException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bindImplementation(IsBrokenClassInjectable.class,
IsBrokenClassInjectable.class);
Assert.assertTrue(t.newInjector(b.build()).isInjectable(
@@ -234,8 +234,8 @@ public class TestBindSingleton {
@Test(expected = InjectionException.class)
public void testBrokenSingletonClassCantInject() throws BindException, InjectionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder b = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder b = t.newConfigurationBuilder();
b.bindImplementation(IsBrokenClassInjectable.class,
IsBrokenClassInjectable.class);
Assert.assertTrue(t.newInjector(b.build()).isInjectable(
@@ -273,7 +273,7 @@ class LateBoundVolatile {
static class B extends A {
@Inject
- B(C c) {
+ B(final C c) {
}
}
@@ -286,7 +286,7 @@ class InbredSingletons {
static int count = 0;
@Inject
- A(B b) {
+ A(final B b) {
Assert.assertEquals(0, count);
count++;
}
@@ -296,7 +296,7 @@ class InbredSingletons {
static int count = 0;
@Inject
- B(C c) {
+ B(final C c) {
Assert.assertEquals(0, count);
count++;
}
@@ -318,7 +318,7 @@ class IncestuousSingletons {
static int count = 0;
@Inject
- A(C c, B b) {
+ A(final C c, final B b) {
Assert.assertEquals(0, count);
count++;
}
@@ -331,7 +331,7 @@ class IncestuousSingletons {
}
@Inject
- B(C c) {
+ B(final C c) {
Assert.assertEquals(0, count);
count++;
}
@@ -341,7 +341,7 @@ class IncestuousSingletons {
static int count = 0;
@Inject
- BN(C c) {
+ BN(final C c) {
super();
Assert.assertEquals(0, count);
count++;
@@ -373,7 +373,7 @@ class IncestuousInterfaceSingletons {
static int count = 0;
@Inject
- A(CI c, BI b) {
+ A(final CI c, final BI b) {
Assert.assertEquals(0, count);
count++;
}
@@ -386,7 +386,7 @@ class IncestuousInterfaceSingletons {
}
@Inject
- B(CI c) {
+ B(final CI c) {
Assert.assertEquals(0, count);
count++;
}
@@ -396,7 +396,7 @@ class IncestuousInterfaceSingletons {
static int count = 0;
@Inject
- BN(CI c) {
+ BN(final CI c) {
super();
Assert.assertEquals(0, count);
count++;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestClassLoaders.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestClassLoaders.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestClassLoaders.java
index f352853..1df1efc 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestClassLoaders.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestClassLoaders.java
@@ -43,12 +43,12 @@ public class TestClassLoaders {
// @Test
public void testTwoJars() throws MalformedURLException,
ClassNotFoundException, BindException, InjectionException, NameResolutionException {
- Tang t = Tang.Factory.getTang();
+ final Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cbA = t.newConfigurationBuilder(new File(
+ final JavaConfigurationBuilder cbA = t.newConfigurationBuilder(new File(
"../tang-test-jarA/target/tang-test-jarA-1.0-SNAPSHOT.jar").toURI()
.toURL());
- JavaConfigurationBuilder cbB = t.newConfigurationBuilder(new File(
+ final JavaConfigurationBuilder cbB = t.newConfigurationBuilder(new File(
"../tang-test-jarB/target/tang-test-jarB-1.0-SNAPSHOT.jar").toURI()
.toURL());
cbA.addConfiguration(cbB.build());
@@ -62,11 +62,11 @@ public class TestClassLoaders {
// @Test
public void testTwoClasses() throws MalformedURLException,
ClassNotFoundException, BindException, InjectionException, NameResolutionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cbA = t.newConfigurationBuilder(new File(
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cbA = t.newConfigurationBuilder(new File(
"../tang-test-jarAB/target/tang-test-jarAB-1.0-SNAPSHOT.jar").toURI()
.toURL());
- JavaConfigurationBuilder cbB = t.newConfigurationBuilder(new File(
+ final JavaConfigurationBuilder cbB = t.newConfigurationBuilder(new File(
"../tang-test-jarAB/target/tang-test-jarAB-1.0-SNAPSHOT.jar").toURI()
.toURL());
cbA.addConfiguration(cbB.build());
@@ -81,20 +81,20 @@ public class TestClassLoaders {
public void aliasingNameSameDifferentTypes()
throws MalformedURLException, InjectionException, BindException,
ClassNotFoundException, NameResolutionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cbA1 = t.newConfigurationBuilder(new File(
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cbA1 = t.newConfigurationBuilder(new File(
"../tang-test-jarAB/target/tang-test-jarAB-1.0-SNAPSHOT.jar").toURI()
.toURL());
- JavaConfigurationBuilder cbA2 = t.newConfigurationBuilder(new File(
+ final JavaConfigurationBuilder cbA2 = t.newConfigurationBuilder(new File(
"../tang-test-jarAB/target/tang-test-jarAB-1.0-SNAPSHOT.jar").toURI()
.toURL());
cbA1.getClassHierarchy().getNode("org.apache.reef.tang.examples.A");
cbA1.bind("org.apache.reef.tang.examples.A", "org.apache.reef.tang.examples.B");
cbA2.bind("org.apache.reef.tang.examples.A", "org.apache.reef.tang.examples.B");
- Object o = t.newInjector(cbA1.build()).getInstance("org.apache.reef.tang.examples.A");
- Object p = t.newInjector(cbA2.build()).getInstance("org.apache.reef.tang.examples.A");
+ final Object o = t.newInjector(cbA1.build()).getInstance("org.apache.reef.tang.examples.A");
+ final Object p = t.newInjector(cbA2.build()).getInstance("org.apache.reef.tang.examples.A");
Assert.assertSame(o.getClass(), p.getClass());
- JavaConfigurationBuilder cbAother = t.newConfigurationBuilder(new File(
+ final JavaConfigurationBuilder cbAother = t.newConfigurationBuilder(new File(
"../tang-test-jarA/target/tang-test-jarA-1.0-SNAPSHOT.jar").toURI()
.toURL());
@@ -109,8 +109,8 @@ public class TestClassLoaders {
public void testOneClassOneJar()
throws MalformedURLException, InjectionException, BindException,
ClassNotFoundException, NameResolutionException {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cbA1 = t.newConfigurationBuilder(new File(
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cbA1 = t.newConfigurationBuilder(new File(
"../tang-test-jarAB/target/tang-test-jarAB-1.0-SNAPSHOT.jar").toURI()
.toURL());
cbA1.bind("org.apache.reef.tang.examples.A", "org.apache.reef.tang.examples.B");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestConfFileParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestConfFileParser.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestConfFileParser.java
index cf648f7..d11a98e 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestConfFileParser.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestConfFileParser.java
@@ -46,11 +46,11 @@ public class TestConfFileParser {
// TODO: This likely only passes on windows, as it relies on newlines
// being \r\n, and on java.lang.Object having a lower hash code than
// org.apache.reef.tang.TestConfFileParser
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = t.newConfigurationBuilder();
- String in = "org.apache.reef.tang.TestConfFileParser=org.apache.reef.tang.TestConfFileParser\n";
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = t.newConfigurationBuilder();
+ final String in = "org.apache.reef.tang.TestConfFileParser=org.apache.reef.tang.TestConfFileParser\n";
ConfigurationFile.addConfiguration(cb, in);
- String out = ConfigurationFile.toConfigurationString(cb.build());
+ final String out = ConfigurationFile.toConfigurationString(cb.build());
Assert.assertEquals(in, out);
}
@@ -59,20 +59,20 @@ public class TestConfFileParser {
// TODO: This likely only passes on windows, as it relies on newlines
// being \r\n, and on java.lang.Object having a lower hash code than
// org.apache.reef.tang.TestConfFileParser
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = t.newConfigurationBuilder();
cb.bindImplementation(SingleTest.A.class, SingleTest.B.class);
- String out = ConfigurationFile.toConfigurationString(cb.build());
- String in = "org.apache.reef.tang.SingleTest$A=org.apache.reef.tang.SingleTest$B\n";
+ final String out = ConfigurationFile.toConfigurationString(cb.build());
+ final String in = "org.apache.reef.tang.SingleTest$A=org.apache.reef.tang.SingleTest$B\n";
Assert.assertEquals(in, out);
}
@Test
public void testNamedParameter() throws BindException {
- Tang t = Tang.Factory.getTang();
- String conf = "org.apache.reef.tang.TestConfFileParser$Foo=woot";
- ConfigurationBuilder cb = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final String conf = "org.apache.reef.tang.TestConfFileParser$Foo=woot";
+ final ConfigurationBuilder cb = t.newConfigurationBuilder();
ConfigurationFile.addConfiguration(cb, conf);
Assert.assertTrue(t.newInjector(cb.build()).isParameterSet(Foo.class));
}
@@ -88,7 +88,7 @@ public class TestConfFileParser {
fout.write(line.getBytes());
}
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
ConfigurationFile.addConfiguration(cb, tmp);
final Injector i = Tang.Factory.getTang().newInjector(cb.build());
Assert.assertEquals(value, i.getNamedInstance(RemoteIdentifier.class));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
index b62570d..f39a1cb 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
@@ -34,19 +34,19 @@ public class TestImplicitConversions {
@SuppressWarnings("unchecked")
@Test
public void testBindFromString() throws BindException, InjectionException {
- JavaConfigurationBuilder b = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
+ final JavaConfigurationBuilder b = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
b.bindNamedParameter(IdName.class, "b://b");
- Configuration c = b.build();
- String s = ConfigurationFile.toConfigurationString(c);
+ final Configuration c = b.build();
+ final String s = ConfigurationFile.toConfigurationString(c);
- JavaConfigurationBuilder b2 = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
+ final JavaConfigurationBuilder b2 = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
ConfigurationFile.addConfiguration(b2, s);
- Configuration c2 = b2.build();
+ final Configuration c2 = b2.build();
Assert.assertEquals("b://b", c2.getNamedParameter(
(NamedParameterNode<?>) c2.getClassHierarchy().getNode(ReflectionUtilities.getFullName(IdName.class))));
- Injector i = Tang.Factory.getTang().newInjector(c2);
+ final Injector i = Tang.Factory.getTang().newInjector(c2);
Assert.assertEquals("b://b", i.getNamedInstance(IdName.class).toString());
Assert.assertTrue(i.getNamedInstance(IdName.class) instanceof BIdentifier);
@@ -56,20 +56,20 @@ public class TestImplicitConversions {
@SuppressWarnings("unchecked")
@Test
public void testBindSubclassFromString() throws BindException, InjectionException {
- JavaConfigurationBuilder b = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
+ final JavaConfigurationBuilder b = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
b.bindNamedParameter(AIdName.class, "a://a");
b.bindNamedParameter(BIdName.class, "b://b");
- Configuration c = b.build();
- String s = ConfigurationFile.toConfigurationString(c);
+ final Configuration c = b.build();
+ final String s = ConfigurationFile.toConfigurationString(c);
- JavaConfigurationBuilder b2 = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
+ final JavaConfigurationBuilder b2 = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
ConfigurationFile.addConfiguration(b2, s);
- Configuration c2 = b2.build();
+ final Configuration c2 = b2.build();
Assert.assertEquals("b://b", c2.getNamedParameter(
(NamedParameterNode<?>) c2.getClassHierarchy().getNode(ReflectionUtilities.getFullName(BIdName.class))));
- Injector i = Tang.Factory.getTang().newInjector(c2);
+ final Injector i = Tang.Factory.getTang().newInjector(c2);
Assert.assertEquals("b://b", i.getNamedInstance(BIdName.class).toString());
Assert.assertTrue(i.getNamedInstance(BIdName.class) instanceof BIdentifier);
@@ -80,14 +80,14 @@ public class TestImplicitConversions {
@SuppressWarnings("unchecked")
@Test(expected = ClassCastException.class)
public void testBindWrongSubclassFromString() throws BindException, InjectionException {
- JavaConfigurationBuilder b = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
+ final JavaConfigurationBuilder b = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
b.bindNamedParameter(AIdName.class, "b://b");
}
@Test(expected = InjectionException.class)
public void testInjectUnboundParsable() throws BindException, InjectionException {
- @SuppressWarnings("unchecked")
- JavaConfigurationBuilder b = Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
+ @SuppressWarnings("unchecked") final JavaConfigurationBuilder b =
+ Tang.Factory.getTang().newConfigurationBuilder(IdentifierParser.class);
Tang.Factory.getTang().newInjector(b.build()).getNamedInstance(IdName.class);
}
@@ -107,7 +107,7 @@ public class TestImplicitConversions {
private final String aString;
@Inject
- AIdentifierImpl(String aString) {
+ AIdentifierImpl(final String aString) {
this.aString = aString;
}
@@ -121,7 +121,7 @@ public class TestImplicitConversions {
private final String bString;
@Inject
- BIdentifierImpl(String bString) {
+ BIdentifierImpl(final String bString) {
this.bString = bString;
}
@@ -135,7 +135,7 @@ public class TestImplicitConversions {
private final Identifier id;
@Inject
- public IdentifierParser(String id) {
+ public IdentifierParser(final String id) {
this.id = id.startsWith("a://") ? new AIdentifierImpl(id) :
id.startsWith("b://") ? new BIdentifierImpl(id) :
null;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestInjectionFuture.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestInjectionFuture.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestInjectionFuture.java
index eb2a50b..c423a1b 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestInjectionFuture.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestInjectionFuture.java
@@ -39,15 +39,15 @@ interface B extends A {
public class TestInjectionFuture {
@Test
public void testFutures() throws InjectionException, BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- Injector i2 = Tang.Factory.getTang().newInjector(cb.build());
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final Injector i2 = Tang.Factory.getTang().newInjector(cb.build());
- Futurist f = i.getInstance(Futurist.class);
+ final Futurist f = i.getInstance(Futurist.class);
Assert.assertTrue(f == f.getMyCar().getDriver());
Assert.assertTrue(f.getMyCar() == f.getMyCar().getDriver().getMyCar());
- Futurist f2 = i2.getInstance(Futurist.class);
+ final Futurist f2 = i2.getInstance(Futurist.class);
Assert.assertTrue(f2 == f2.getMyCar().getDriver());
Assert.assertTrue(f2.getMyCar() == f2.getMyCar().getDriver().getMyCar());
@@ -58,15 +58,15 @@ public class TestInjectionFuture {
@Test
public void testFutures2() throws InjectionException, BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- Injector i2 = i.forkInjector();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final Injector i2 = i.forkInjector();
- FlyingCar c = i.getInstance(FlyingCar.class);
+ final FlyingCar c = i.getInstance(FlyingCar.class);
Assert.assertTrue(c == c.getDriver().getMyCar());
Assert.assertTrue(c.getDriver() == c.getDriver().getMyCar().getDriver());
- FlyingCar c2 = i2.getInstance(FlyingCar.class);
+ final FlyingCar c2 = i2.getInstance(FlyingCar.class);
Assert.assertTrue(c2 == c2.getDriver().getMyCar());
Assert.assertTrue(c2.getDriver() == c2.getDriver().getMyCar().getDriver());
@@ -77,43 +77,41 @@ public class TestInjectionFuture {
@Test
public void testNamedParameterInjectionFuture() throws InjectionException, BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindImplementation(FlyingCar.class, FlyingCar.class);
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- PickyFuturist f = i.getInstance(PickyFuturist.class);
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final PickyFuturist f = i.getInstance(PickyFuturist.class);
Assert.assertNotNull(f.getMyCar());
}
@Test
public void testNamedParameterInjectionFutureDefaultImpl() throws InjectionException, BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- PickyFuturist f = i.getInstance(PickyFuturist.class);
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final PickyFuturist f = i.getInstance(PickyFuturist.class);
Assert.assertNotNull(f.getMyCar());
}
@Test
public void testNamedParameterInjectionFutureBindImpl() throws InjectionException, BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindImplementation(Futurist.class, PickyFuturist.class);
cb.bindNamedParameter(MyFlyingCar.class, BigFlyingCar.class);
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
- PickyFuturist f = i.getInstance(PickyFuturist.class);
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final PickyFuturist f = i.getInstance(PickyFuturist.class);
Assert.assertNotNull((BigFlyingCar) f.getMyCar());
}
@Test
public void testNamedParameterBoundToDelegatingInterface() throws InjectionException, BindException {
- Injector i = Tang.Factory.getTang().newInjector();
- @SuppressWarnings("unused")
- C c = (C) i.getNamedInstance(AName.class);
+ final Injector i = Tang.Factory.getTang().newInjector();
+ @SuppressWarnings("unused") final C c = (C) i.getNamedInstance(AName.class);
}
@Test
public void testBoundToDelegatingInterface() throws InjectionException, BindException {
- Injector i = Tang.Factory.getTang().newInjector();
- @SuppressWarnings("unused")
- C c = (C) i.getInstance(B.class);
+ final Injector i = Tang.Factory.getTang().newInjector();
+ @SuppressWarnings("unused") final C c = (C) i.getInstance(B.class);
}
@@ -122,12 +120,12 @@ public class TestInjectionFuture {
private final InjectionFuture<FlyingCar> fCar;
@Inject
- public Futurist(InjectionFuture<FlyingCar> car) {
+ public Futurist(final InjectionFuture<FlyingCar> car) {
this.fCar = car;
}
public FlyingCar getMyCar() {
- FlyingCar c = fCar.get();
+ final FlyingCar c = fCar.get();
return c;
}
}
@@ -136,13 +134,13 @@ public class TestInjectionFuture {
private final InjectionFuture<FlyingCar> fCar;
@Inject
- public PickyFuturist(@Parameter(MyFlyingCar.class) InjectionFuture<FlyingCar> myFlyingCar) {
+ public PickyFuturist(@Parameter(MyFlyingCar.class) final InjectionFuture<FlyingCar> myFlyingCar) {
super(myFlyingCar);
fCar = myFlyingCar;
}
public FlyingCar getMyCar() {
- FlyingCar c = fCar.get();
+ final FlyingCar c = fCar.get();
return c;
}
}
@@ -153,7 +151,7 @@ public class TestInjectionFuture {
private final Futurist driver;
@Inject
- FlyingCar(@Parameter(Color.class) String color, Futurist driver) {
+ FlyingCar(@Parameter(Color.class) final String color, final Futurist driver) {
this.color = color;
this.driver = driver;
}
@@ -173,7 +171,7 @@ public class TestInjectionFuture {
public static class BigFlyingCar extends FlyingCar {
@Inject
- BigFlyingCar(@Parameter(Color.class) String color, Futurist driver) {
+ BigFlyingCar(@Parameter(Color.class) final String color, final Futurist driver) {
super(color, driver);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestListInjection.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestListInjection.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestListInjection.java
index 81fbdfb..8594005 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestListInjection.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestListInjection.java
@@ -46,8 +46,8 @@ public class TestListInjection {
*/
@Test
public void testStringInjectDefault() throws InjectionException {
- List<String> actual = Tang.Factory.getTang().newInjector().getInstance(StringClass.class).stringList;
- List<String> expected = new ArrayList<>();
+ final List<String> actual = Tang.Factory.getTang().newInjector().getInstance(StringClass.class).stringList;
+ final List<String> expected = new ArrayList<>();
expected.add("bye");
expected.add("hello");
expected.add("hi");
@@ -61,8 +61,8 @@ public class TestListInjection {
*/
@Test
public void testIntegerInjectDefault() throws InjectionException {
- List<Integer> actual = Tang.Factory.getTang().newInjector().getInstance(IntegerClass.class).integerList;
- List<Integer> expected = new ArrayList<>();
+ final List<Integer> actual = Tang.Factory.getTang().newInjector().getInstance(IntegerClass.class).integerList;
+ final List<Integer> expected = new ArrayList<>();
expected.add(1);
expected.add(2);
expected.add(3);
@@ -76,14 +76,14 @@ public class TestListInjection {
*/
@Test
public void testObjectInjectDefault() throws InjectionException {
- Integer integer = 1;
- Float ffloat = 1.001f;
+ final Integer integer = 1;
+ final Float ffloat = 1.001f;
- Injector injector = Tang.Factory.getTang().newInjector();
+ final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileInstance(Integer.class, integer);
injector.bindVolatileInstance(Float.class, ffloat);
- List<Number> actual = injector.getInstance(NumberClass.class).numberList;
- List<Number> expected = new ArrayList<>();
+ final List<Number> actual = injector.getInstance(NumberClass.class).numberList;
+ final List<Number> expected = new ArrayList<>();
expected.add(integer);
expected.add(ffloat);
Assert.assertEquals(expected, actual);
@@ -96,14 +96,15 @@ public class TestListInjection {
*/
@Test
public void testStringInjectBound() throws InjectionException {
- List<String> injected = new ArrayList<>();
+ final List<String> injected = new ArrayList<>();
injected.add("hi");
injected.add("hello");
injected.add("bye");
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindList(StringList.class, injected);
- List<String> actual = Tang.Factory.getTang().newInjector(cb.build()).getInstance(StringClass.class).stringList;
- List<String> expected = new ArrayList<>();
+ final List<String> actual =
+ Tang.Factory.getTang().newInjector(cb.build()).getInstance(StringClass.class).stringList;
+ final List<String> expected = new ArrayList<>();
expected.add("hi");
expected.add("hello");
expected.add("bye");
@@ -117,15 +118,16 @@ public class TestListInjection {
*/
@Test
public void testIntegerInjectBound() throws InjectionException {
- List<String> injected = new ArrayList<>();
+ final List<String> injected = new ArrayList<>();
injected.add("1");
injected.add("2");
injected.add("3");
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindList(IntegerList.class, injected);
- List<Integer> actual = Tang.Factory.getTang().newInjector(cb.build()).getInstance(IntegerClass.class).integerList;
- List<Integer> expected = new ArrayList<>();
+ final List<Integer> actual =
+ Tang.Factory.getTang().newInjector(cb.build()).getInstance(IntegerClass.class).integerList;
+ final List<Integer> expected = new ArrayList<>();
expected.add(1);
expected.add(2);
expected.add(3);
@@ -139,32 +141,32 @@ public class TestListInjection {
*/
@Test
public void testObjectInjectBound() throws InjectionException {
- Integer integer = 1;
- Float ffloat = 1.001f;
+ final Integer integer = 1;
+ final Float ffloat = 1.001f;
// Inject implementations via class object
- List<Class> injected1 = new ArrayList<>();
+ final List<Class> injected1 = new ArrayList<>();
injected1.add(Integer.class);
injected1.add(Float.class);
- JavaConfigurationBuilder cb1 = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb1 = Tang.Factory.getTang().newConfigurationBuilder();
cb1.bindList(NumberList.class, injected1);
- Injector injector1 = Tang.Factory.getTang().newInjector(cb1.build());
+ final Injector injector1 = Tang.Factory.getTang().newInjector(cb1.build());
injector1.bindVolatileInstance(Integer.class, integer);
injector1.bindVolatileInstance(Float.class, ffloat);
- List<Number> actual1 = injector1.getInstance(NumberClass.class).numberList;
+ final List<Number> actual1 = injector1.getInstance(NumberClass.class).numberList;
// Inject implementations via class name
- List<String> injected2 = new ArrayList<>();
+ final List<String> injected2 = new ArrayList<>();
injected2.add("java.lang.Integer");
injected2.add("java.lang.Float");
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindList(NumberList.class, injected2);
- Injector injector2 = Tang.Factory.getTang().newInjector(cb.build());
+ final Injector injector2 = Tang.Factory.getTang().newInjector(cb.build());
injector2.bindVolatileInstance(Integer.class, integer);
injector2.bindVolatileInstance(Float.class, ffloat);
- List<Number> actual2 = injector2.getInstance(NumberClass.class).numberList;
+ final List<Number> actual2 = injector2.getInstance(NumberClass.class).numberList;
- List<Number> expected = new ArrayList<>();
+ final List<Number> expected = new ArrayList<>();
expected.add(integer);
expected.add(ffloat);
Assert.assertEquals(expected, actual1);
@@ -181,19 +183,19 @@ public class TestListInjection {
@Test
public void testInjectSelectiveConstructor() throws InjectionException {
// Test injection without list binding
- List<String> actual1 = Tang.Factory.getTang().newInjector().getInstance(SelectiveConsructorClass.class).list;
- List<String> expected1 = new ArrayList<>();
+ final List<String> actual1 = Tang.Factory.getTang().newInjector().getInstance(SelectiveConsructorClass.class).list;
+ final List<String> expected1 = new ArrayList<>();
Assert.assertEquals(expected1, actual1);
// Test injection with list binding
- List<String> injected = new ArrayList<>();
+ final List<String> injected = new ArrayList<>();
injected.add("hi");
injected.add("hello");
injected.add("bye");
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindList(SelectiveInjectTestList.class, injected);
- List<String> actual2 = Tang.Factory.getTang().newInjector(cb.build()).getInstance(SelectiveConsructorClass.class)
- .list;
- List<String> expected2 = new ArrayList<>();
+ final List<String> actual2 =
+ Tang.Factory.getTang().newInjector(cb.build()).getInstance(SelectiveConsructorClass.class).list;
+ final List<String> expected2 = new ArrayList<>();
expected2.add("hi");
expected2.add("hello");
expected2.add("bye");
@@ -207,17 +209,18 @@ public class TestListInjection {
*/
@Test
public void testStringInjectConfigurationBuilder() throws InjectionException {
- JavaClassHierarchy namespace = Tang.Factory.getTang().getDefaultClassHierarchy();
- NamedParameterNode<List<String>> np = (NamedParameterNode) namespace.getNode(StringList.class);
- List<String> injected = new ArrayList<>();
+ final JavaClassHierarchy namespace = Tang.Factory.getTang().getDefaultClassHierarchy();
+ final NamedParameterNode<List<String>> np = (NamedParameterNode) namespace.getNode(StringList.class);
+ final List<String> injected = new ArrayList<>();
injected.add("hi");
injected.add("hello");
injected.add("bye");
- ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindList(np, injected);
- List<String> actual = Tang.Factory.getTang().newInjector(cb.build()).getInstance(StringClass.class).stringList;
- List<String> expected = new ArrayList<>();
+ final List<String> actual =
+ Tang.Factory.getTang().newInjector(cb.build()).getInstance(StringClass.class).stringList;
+ final List<String> expected = new ArrayList<>();
expected.add("hi");
expected.add("hello");
expected.add("bye");
@@ -231,23 +234,23 @@ public class TestListInjection {
*/
@Test
public void testObjectInjectConfigurationBuilder() throws InjectionException {
- Integer integer = 1;
- Float ffloat = 1.001f;
+ final Integer integer = 1;
+ final Float ffloat = 1.001f;
- JavaClassHierarchy namespace = Tang.Factory.getTang().getDefaultClassHierarchy();
- NamedParameterNode<List<Class>> np = (NamedParameterNode) namespace.getNode(NumberList.class);
- List<ClassNode> injected = new ArrayList<>();
+ final JavaClassHierarchy namespace = Tang.Factory.getTang().getDefaultClassHierarchy();
+ final NamedParameterNode<List<Class>> np = (NamedParameterNode) namespace.getNode(NumberList.class);
+ final List<ClassNode> injected = new ArrayList<>();
injected.add((ClassNode) namespace.getNode(Integer.class));
injected.add((ClassNode) namespace.getNode(Float.class));
- ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final ConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindList(np, injected);
- Injector injector = Tang.Factory.getTang().newInjector(cb.build());
+ final Injector injector = Tang.Factory.getTang().newInjector(cb.build());
injector.bindVolatileInstance(Integer.class, integer);
injector.bindVolatileInstance(Float.class, ffloat);
- List<Number> actual = injector.getInstance(NumberClass.class).numberList;
- List<Number> expected = new ArrayList<>();
+ final List<Number> actual = injector.getInstance(NumberClass.class).numberList;
+ final List<Number> expected = new ArrayList<>();
expected.add(integer);
expected.add(ffloat);
Assert.assertEquals(expected, actual);
@@ -260,15 +263,15 @@ public class TestListInjection {
*/
@Test
public void testInjectConfigurationModule() throws InjectionException {
- List<String> injected = new ArrayList<>();
+ final List<String> injected = new ArrayList<>();
injected.add("hi");
injected.add("hello");
injected.add("bye");
- Configuration conf = StringClassConfiguration.CONF
+ final Configuration conf = StringClassConfiguration.CONF
.set(StringClassConfiguration.STRING_LIST, injected)
.build();
- List<String> actual = Tang.Factory.getTang().newInjector(conf).getInstance(StringClass.class).stringList;
- List<String> expected = new ArrayList<>();
+ final List<String> actual = Tang.Factory.getTang().newInjector(conf).getInstance(StringClass.class).stringList;
+ final List<String> expected = new ArrayList<>();
expected.add("hi");
expected.add("hello");
expected.add("bye");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestNamedParameterRoundTrip.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestNamedParameterRoundTrip.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestNamedParameterRoundTrip.java
index e6f62e9..f3706ec 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestNamedParameterRoundTrip.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestNamedParameterRoundTrip.java
@@ -47,7 +47,7 @@ public class TestNamedParameterRoundTrip {
assertEquals(d, readD1);
- JavaConfigurationBuilder roundTrip2 = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder roundTrip2 = Tang.Factory.getTang().newConfigurationBuilder();
ConfigurationFile.addConfiguration(roundTrip2, ConfigurationFile.toConfigurationString(conf));
final Injector i2 = Tang.Factory.getTang().newInjector(roundTrip2.build());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestSetInjection.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestSetInjection.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestSetInjection.java
index f221447..5c02c41 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestSetInjection.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestSetInjection.java
@@ -36,9 +36,9 @@ import java.util.Set;
public class TestSetInjection {
@Test
public void testStringInjectDefault() throws InjectionException {
- Set<String> actual = Tang.Factory.getTang().newInjector().getInstance(Box.class).strings;
+ final Set<String> actual = Tang.Factory.getTang().newInjector().getInstance(Box.class).strings;
- Set<String> expected = new HashSet<>();
+ final Set<String> expected = new HashSet<>();
expected.add("one");
expected.add("two");
expected.add("three");
@@ -48,11 +48,11 @@ public class TestSetInjection {
@Test
public void testObjectInjectDefault() throws InjectionException, BindException {
- Injector i = Tang.Factory.getTang().newInjector();
+ final Injector i = Tang.Factory.getTang().newInjector();
i.bindVolatileInstance(Integer.class, 42);
i.bindVolatileInstance(Float.class, 42.0001f);
- Set<Number> actual = i.getInstance(Pool.class).numbers;
- Set<Number> expected = new HashSet<>();
+ final Set<Number> actual = i.getInstance(Pool.class).numbers;
+ final Set<Number> expected = new HashSet<>();
expected.add(42);
expected.add(42.0001f);
Assert.assertEquals(expected, actual);
@@ -60,13 +60,13 @@ public class TestSetInjection {
@Test
public void testStringInjectBound() throws InjectionException, BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindSetEntry(SetOfStrings.class, "four");
cb.bindSetEntry(SetOfStrings.class, "five");
cb.bindSetEntry(SetOfStrings.class, "six");
- Set<String> actual = Tang.Factory.getTang().newInjector(cb.build()).getInstance(Box.class).strings;
+ final Set<String> actual = Tang.Factory.getTang().newInjector(cb.build()).getInstance(Box.class).strings;
- Set<String> expected = new HashSet<>();
+ final Set<String> expected = new HashSet<>();
expected.add("four");
expected.add("five");
expected.add("six");
@@ -76,15 +76,15 @@ public class TestSetInjection {
@Test
public void testObjectInjectBound() throws InjectionException, BindException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindSetEntry(SetOfClasses.class, Short.class);
cb.bindSetEntry(SetOfClasses.class, Float.class);
- Injector i = Tang.Factory.getTang().newInjector(cb.build());
+ final Injector i = Tang.Factory.getTang().newInjector(cb.build());
i.bindVolatileInstance(Short.class, (short) 4);
i.bindVolatileInstance(Float.class, 42.0001f);
- Set<Number> actual = i.getInstance(Pool.class).numbers;
- Set<Number> expected = new HashSet<>();
+ final Set<Number> actual = i.getInstance(Pool.class).numbers;
+ final Set<Number> expected = new HashSet<>();
expected.add((short) 4);
expected.add(42.0001f);
Assert.assertEquals(expected, actual);
@@ -92,21 +92,21 @@ public class TestSetInjection {
@Test
public void testStringInjectRoundTrip() throws InjectionException, BindException, IOException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindSetEntry(SetOfStrings.class, "four");
cb.bindSetEntry(SetOfStrings.class, "five");
cb.bindSetEntry(SetOfStrings.class, "six");
- ConfigurationSerializer serializer = new AvroConfigurationSerializer();
+ final ConfigurationSerializer serializer = new AvroConfigurationSerializer();
- String s = serializer.toString(cb.build());
- JavaConfigurationBuilder cb2 = Tang.Factory.getTang().newConfigurationBuilder();
- Configuration conf = serializer.fromString(s);
+ final String s = serializer.toString(cb.build());
+ final JavaConfigurationBuilder cb2 = Tang.Factory.getTang().newConfigurationBuilder();
+ final Configuration conf = serializer.fromString(s);
cb2.addConfiguration(conf);
- Set<String> actual = Tang.Factory.getTang().newInjector(cb2.build()).getInstance(Box.class).strings;
+ final Set<String> actual = Tang.Factory.getTang().newInjector(cb2.build()).getInstance(Box.class).strings;
- Set<String> expected = new HashSet<>();
+ final Set<String> expected = new HashSet<>();
expected.add("four");
expected.add("five");
expected.add("six");
@@ -116,22 +116,22 @@ public class TestSetInjection {
@Test
public void testObjectInjectRoundTrip() throws InjectionException, BindException, IOException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindSetEntry(SetOfClasses.class, Short.class);
cb.bindSetEntry(SetOfClasses.class, Float.class);
- ConfigurationSerializer serializer = new AvroConfigurationSerializer();
+ final ConfigurationSerializer serializer = new AvroConfigurationSerializer();
- String s = serializer.toString(cb.build());
- JavaConfigurationBuilder cb2 = Tang.Factory.getTang().newConfigurationBuilder();
- Configuration conf = serializer.fromString(s);
+ final String s = serializer.toString(cb.build());
+ final JavaConfigurationBuilder cb2 = Tang.Factory.getTang().newConfigurationBuilder();
+ final Configuration conf = serializer.fromString(s);
cb2.addConfiguration(conf);
- Injector i = Tang.Factory.getTang().newInjector(cb2.build());
+ final Injector i = Tang.Factory.getTang().newInjector(cb2.build());
i.bindVolatileInstance(Short.class, (short) 4);
i.bindVolatileInstance(Float.class, 42.0001f);
- Set<Number> actual = i.getInstance(Pool.class).numbers;
- Set<Number> expected = new HashSet<>();
+ final Set<Number> actual = i.getInstance(Pool.class).numbers;
+ final Set<Number> expected = new HashSet<>();
expected.add((short) 4);
expected.add(42.0001f);
Assert.assertEquals(expected, actual);
@@ -139,11 +139,11 @@ public class TestSetInjection {
@Test
public void testDefaultAsClass() throws InjectionException, BindException {
- Injector i = Tang.Factory.getTang().newInjector();
+ final Injector i = Tang.Factory.getTang().newInjector();
i.bindVolatileInstance(Integer.class, 1);
i.bindVolatileInstance(Float.class, 2f);
- Set<Number> actual = i.getNamedInstance(SetOfClassesDefaultClass.class);
- Set<Number> expected = new HashSet<>();
+ final Set<Number> actual = i.getNamedInstance(SetOfClassesDefaultClass.class);
+ final Set<Number> expected = new HashSet<>();
expected.add(1);
Assert.assertEquals(expected, actual);
}
@@ -158,7 +158,7 @@ class Box {
public final Set<String> strings;
@Inject
- Box(@Parameter(SetOfStrings.class) Set<String> strings) {
+ Box(@Parameter(SetOfStrings.class) final Set<String> strings) {
this.strings = strings;
}
}
@@ -171,7 +171,7 @@ class Pool {
public final Set<Number> numbers;
@Inject
- Pool(@Parameter(SetOfClasses.class) Set<Number> numbers) {
+ Pool(@Parameter(SetOfClasses.class) final Set<Number> numbers) {
this.numbers = numbers;
}
}
[09/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationSubmission.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationSubmission.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationSubmission.java
index 4a2cf18..0ea4a06 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationSubmission.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ApplicationSubmission.java
@@ -67,7 +67,7 @@ public final class ApplicationSubmission {
return applicationId;
}
- public ApplicationSubmission setApplicationId(String applicationId) {
+ public ApplicationSubmission setApplicationId(final String applicationId) {
this.applicationId = applicationId;
return this;
}
@@ -77,7 +77,7 @@ public final class ApplicationSubmission {
return applicationName;
}
- public ApplicationSubmission setApplicationName(String applicationName) {
+ public ApplicationSubmission setApplicationName(final String applicationName) {
this.applicationName = applicationName;
return this;
}
@@ -87,7 +87,7 @@ public final class ApplicationSubmission {
return applicationType;
}
- public ApplicationSubmission setApplicationType(String applicationType) {
+ public ApplicationSubmission setApplicationType(final String applicationType) {
this.applicationType = applicationType;
return this;
}
@@ -97,7 +97,7 @@ public final class ApplicationSubmission {
return amContainerSpec;
}
- public ApplicationSubmission setAmContainerSpec(AmContainerSpec amContainerSpec) {
+ public ApplicationSubmission setAmContainerSpec(final AmContainerSpec amContainerSpec) {
this.amContainerSpec = amContainerSpec;
return this;
}
@@ -108,7 +108,7 @@ public final class ApplicationSubmission {
}
@SuppressWarnings("checkstyle:hiddenfield")
- public ApplicationSubmission setUnmanagedAM(boolean isUnmanagedAM) {
+ public ApplicationSubmission setUnmanagedAM(final boolean isUnmanagedAM) {
this.isUnmanagedAM = isUnmanagedAM;
return this;
}
@@ -118,7 +118,7 @@ public final class ApplicationSubmission {
return keepContainers;
}
- public ApplicationSubmission setKeepContainers(boolean keepContainers) {
+ public ApplicationSubmission setKeepContainers(final boolean keepContainers) {
this.keepContainers = keepContainers;
return this;
}
@@ -128,7 +128,7 @@ public final class ApplicationSubmission {
return maxAppAttempts;
}
- public ApplicationSubmission setMaxAppAttempts(int maxAppAttempts) {
+ public ApplicationSubmission setMaxAppAttempts(final int maxAppAttempts) {
this.maxAppAttempts = maxAppAttempts;
return this;
}
@@ -138,7 +138,7 @@ public final class ApplicationSubmission {
return priority;
}
- public ApplicationSubmission setPriority(int priority) {
+ public ApplicationSubmission setPriority(final int priority) {
this.priority = priority;
return this;
}
@@ -148,7 +148,7 @@ public final class ApplicationSubmission {
return queue;
}
- public ApplicationSubmission setQueue(String queue) {
+ public ApplicationSubmission setQueue(final String queue) {
this.queue = queue;
return this;
}
@@ -158,12 +158,12 @@ public final class ApplicationSubmission {
return resource;
}
- public ApplicationSubmission setResource(Resource resource) {
+ public ApplicationSubmission setResource(final Resource resource) {
this.resource = resource;
return this;
}
- public ApplicationSubmission addApplicationTag(String tag) {
+ public ApplicationSubmission addApplicationTag(final String tag) {
this.applicationTags.add(tag);
return this;
}
@@ -181,12 +181,12 @@ public final class ApplicationSubmission {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Commands.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Commands.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Commands.java
index 0dec2b4..e250ba7 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Commands.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Commands.java
@@ -52,12 +52,12 @@ public final class Commands {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Credentials.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Credentials.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Credentials.java
index 32d4bcd..3962670 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Credentials.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Credentials.java
@@ -47,7 +47,7 @@ public class Credentials {
this.secrets.put(Constants.ENTRY, new ArrayList<StringEntry>());
}
- public Credentials addSecret(String key, String value) {
+ public Credentials addSecret(final String key, final String value) {
if (!this.secrets.containsKey(Constants.ENTRY)) {
this.secrets.put(Constants.ENTRY, new ArrayList<StringEntry>());
}
@@ -55,7 +55,7 @@ public class Credentials {
return this;
}
- public Credentials addToken(String key, String value) {
+ public Credentials addToken(final String key, final String value) {
if (!this.tokens.containsKey(Constants.ENTRY)) {
this.tokens.put(Constants.ENTRY, new ArrayList<StringEntry>());
}
@@ -87,12 +87,12 @@ public class Credentials {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ListApplicationResponse.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ListApplicationResponse.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ListApplicationResponse.java
index bd9f722..2e853f0 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ListApplicationResponse.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/ListApplicationResponse.java
@@ -59,12 +59,12 @@ public final class ListApplicationResponse {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResource.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResource.java
index 5b19c7c..30ca19f 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResource.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResource.java
@@ -99,12 +99,12 @@ public final class LocalResource {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResourcesEntry.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResourcesEntry.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResourcesEntry.java
index 1564bd1..c980a9d 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResourcesEntry.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/LocalResourcesEntry.java
@@ -66,12 +66,12 @@ public final class LocalResourcesEntry {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Resource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Resource.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Resource.java
index 7ab98be..92c7dc2 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Resource.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/Resource.java
@@ -58,12 +58,12 @@ public final class Resource {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/StringEntry.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/StringEntry.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/StringEntry.java
index 994496b..2fa7b91 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/StringEntry.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/StringEntry.java
@@ -62,12 +62,12 @@ public final class StringEntry {
@Override
public String toString() {
- StringWriter writer = new StringWriter();
- String objectString;
+ final StringWriter writer = new StringWriter();
+ final String objectString;
try {
OBJECT_MAPPER.writeValue(writer, this);
objectString = writer.toString();
- } catch (IOException e) {
+ } catch (final IOException e) {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-hdinsight/src/test/java/org/apache/reef/runtime/hdinsight/TestHDInsightRESTJsonSerialization.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/test/java/org/apache/reef/runtime/hdinsight/TestHDInsightRESTJsonSerialization.java b/lang/java/reef-runtime-hdinsight/src/test/java/org/apache/reef/runtime/hdinsight/TestHDInsightRESTJsonSerialization.java
index 8dc37c4..3bd776d 100644
--- a/lang/java/reef-runtime-hdinsight/src/test/java/org/apache/reef/runtime/hdinsight/TestHDInsightRESTJsonSerialization.java
+++ b/lang/java/reef-runtime-hdinsight/src/test/java/org/apache/reef/runtime/hdinsight/TestHDInsightRESTJsonSerialization.java
@@ -45,18 +45,18 @@ public final class TestHDInsightRESTJsonSerialization {
final String fileKey = "file";
// Create submission object
- LocalResource archiveResource = new LocalResource()
+ final LocalResource archiveResource = new LocalResource()
.setResource("archiveResourceLocation").setSize(100).setTimestamp(200)
.setType(LocalResource.TYPE_ARCHIVE).setVisibility(LocalResource.VISIBILITY_PRIVATE);
localResourceMap.put(archiveKey, archiveResource);
- LocalResource fileResource = new LocalResource()
+ final LocalResource fileResource = new LocalResource()
.setResource("fileResourceLocation").setSize(300).setTimestamp(400)
.setType(LocalResource.TYPE_FILE).setVisibility(LocalResource.VISIBILITY_APPLICATION);
localResourceMap.put(fileKey, fileResource);
- Credentials creds = new Credentials().addSecret("secretKey", "secretVal").addToken("tokKey", "tokVal");
- AmContainerSpec containerSpec = new AmContainerSpec()
+ final Credentials creds = new Credentials().addSecret("secretKey", "secretVal").addToken("tokKey", "tokVal");
+ final AmContainerSpec containerSpec = new AmContainerSpec()
.setCommand("submission command")
.addLocalResource(archiveKey, archiveResource)
.addLocalResource(fileKey, fileResource)
@@ -64,8 +64,8 @@ public final class TestHDInsightRESTJsonSerialization {
.addApplicationAcl("aclKey", "aclVal")
.addServiceData("sdKey", "sdVal")
.setCredentials(creds);
- Resource resource = new Resource().setMemory(500).setvCores(600);
- ApplicationSubmission submission = new ApplicationSubmission()
+ final Resource resource = new Resource().setMemory(500).setvCores(600);
+ final ApplicationSubmission submission = new ApplicationSubmission()
.setApplicationType(ApplicationSubmission.DEFAULT_APPLICATION_TYPE)
.setMaxAppAttempts(ApplicationSubmission.DEFAULT_MAX_APP_ATTEMPTS)
.setKeepContainers(ApplicationSubmission.DEFAULT_KEEP_CONTAINERS_ACROSS_APPLICATION_ATTEMPTS)
@@ -76,11 +76,11 @@ public final class TestHDInsightRESTJsonSerialization {
.setResource(resource);
// Json validation
- ObjectMapper mapper = new ObjectMapper();
- StringWriter writer = new StringWriter();
+ final ObjectMapper mapper = new ObjectMapper();
+ final StringWriter writer = new StringWriter();
mapper.writeValue(writer, submission);
- String jsonStr = writer.toString();
- JsonNode rootJsonNode = mapper.readTree(jsonStr);
+ final String jsonStr = writer.toString();
+ final JsonNode rootJsonNode = mapper.readTree(jsonStr);
Assert.assertEquals(rootJsonNode.get(Constants.APPLICATION_ID).asText(), submission.getApplicationId());
Assert.assertEquals(rootJsonNode.get(Constants.APPLICATION_NAME).asText(), submission.getApplicationName());
Assert.assertEquals(rootJsonNode.get(Constants.MAX_APP_ATTEMPTS).asInt(), submission.getMaxAppAttempts());
@@ -90,22 +90,22 @@ public final class TestHDInsightRESTJsonSerialization {
Assert.assertEquals(rootJsonNode.get(Constants.PRIORITY).asInt(), submission.getPriority());
Assert.assertEquals(rootJsonNode.get(Constants.UNMANAGED_AM).asBoolean(), submission.isUnmanagedAM());
- JsonNode resourceNode = rootJsonNode.get(Constants.RESOURCE);
+ final JsonNode resourceNode = rootJsonNode.get(Constants.RESOURCE);
Assert.assertNotNull(resourceNode);
Assert.assertEquals(resourceNode.get(Constants.MEMORY).asInt(), resource.getMemory());
Assert.assertEquals(resourceNode.get(Constants.VCORES).asInt(), resource.getvCores());
- JsonNode amSpecNode = rootJsonNode.get(Constants.AM_CONTAINER_SPEC);
+ final JsonNode amSpecNode = rootJsonNode.get(Constants.AM_CONTAINER_SPEC);
Assert.assertNotNull(amSpecNode);
Assert.assertEquals(amSpecNode.get(Constants.COMMANDS).get(Constants.COMMAND).asText(),
containerSpec.getCommands().getCommand());
- JsonNode locResourcesNode = amSpecNode.get(Constants.LOCAL_RESOURCES).get(Constants.ENTRY);
+ final JsonNode locResourcesNode = amSpecNode.get(Constants.LOCAL_RESOURCES).get(Constants.ENTRY);
Assert.assertTrue(locResourcesNode.isArray());
for (final JsonNode localResourceKVNode : locResourcesNode) {
- String localResourceKey = localResourceKVNode.get(Constants.KEY).asText();
+ final String localResourceKey = localResourceKVNode.get(Constants.KEY).asText();
Assert.assertTrue(localResourceMap.containsKey(localResourceKey));
- LocalResource localResourceFromMap = localResourceMap.get(localResourceKey);
- JsonNode localResourceNode = localResourceKVNode.get(Constants.VALUE);
+ final LocalResource localResourceFromMap = localResourceMap.get(localResourceKey);
+ final JsonNode localResourceNode = localResourceKVNode.get(Constants.VALUE);
Assert.assertEquals(localResourceNode.get(Constants.RESOURCE).asText(), localResourceFromMap.getResource());
Assert.assertEquals(localResourceNode.get(Constants.SIZE).asLong(), localResourceFromMap.getSize());
Assert.assertEquals(localResourceNode.get(Constants.TIMESTAMP).asLong(), localResourceFromMap.getTimestamp());
@@ -116,48 +116,48 @@ public final class TestHDInsightRESTJsonSerialization {
Assert.assertTrue(localResourceMap.isEmpty());
- JsonNode credsNode = amSpecNode.get(Constants.CREDENTIALS);
+ final JsonNode credsNode = amSpecNode.get(Constants.CREDENTIALS);
Assert.assertNotNull(credsNode);
- JsonNode toksNode = credsNode.get(Constants.TOKENS).get(Constants.ENTRY);
+ final JsonNode toksNode = credsNode.get(Constants.TOKENS).get(Constants.ENTRY);
Assert.assertNotNull(toksNode);
Assert.assertTrue(toksNode.isArray());
for (final JsonNode tokKVNode : toksNode) {
- StringEntry tokenEntry = containerSpec.getCredentials().getTokens().get(Constants.ENTRY).get(0);
+ final StringEntry tokenEntry = containerSpec.getCredentials().getTokens().get(Constants.ENTRY).get(0);
Assert.assertEquals(tokKVNode.get(Constants.KEY).asText(), tokenEntry.getKey());
Assert.assertEquals(tokKVNode.get(Constants.VALUE).asText(), tokenEntry.getValue());
}
- JsonNode secretsNode = credsNode.get(Constants.SECRETS).get(Constants.ENTRY);
+ final JsonNode secretsNode = credsNode.get(Constants.SECRETS).get(Constants.ENTRY);
Assert.assertNotNull(secretsNode);
Assert.assertTrue(secretsNode.isArray());
for (final JsonNode secretsKVNode : secretsNode) {
- StringEntry secretsEntry = containerSpec.getCredentials().getSecrets().get(Constants.ENTRY).get(0);
+ final StringEntry secretsEntry = containerSpec.getCredentials().getSecrets().get(Constants.ENTRY).get(0);
Assert.assertEquals(secretsKVNode.get(Constants.KEY).asText(), secretsEntry.getKey());
Assert.assertEquals(secretsKVNode.get(Constants.VALUE).asText(), secretsEntry.getValue());
}
- JsonNode envsNode = amSpecNode.get(Constants.ENVIRONMENT).get(Constants.ENTRY);
+ final JsonNode envsNode = amSpecNode.get(Constants.ENVIRONMENT).get(Constants.ENTRY);
Assert.assertNotNull(envsNode);
Assert.assertTrue(envsNode.isArray());
for (final JsonNode envsKVNode : envsNode) {
- StringEntry envEntry = containerSpec.getEnvironment().get(Constants.ENTRY).get(0);
+ final StringEntry envEntry = containerSpec.getEnvironment().get(Constants.ENTRY).get(0);
Assert.assertEquals(envsKVNode.get(Constants.KEY).asText(), envEntry.getKey());
Assert.assertEquals(envsKVNode.get(Constants.VALUE).asText(), envEntry.getValue());
}
- JsonNode aclsNode = amSpecNode.get(Constants.APPLICATION_ACLS).get(Constants.ENTRY);
+ final JsonNode aclsNode = amSpecNode.get(Constants.APPLICATION_ACLS).get(Constants.ENTRY);
Assert.assertNotNull(aclsNode);
Assert.assertTrue(aclsNode.isArray());
for (final JsonNode aclsKVNode : aclsNode) {
- StringEntry aclsEntry = containerSpec.getApplicationAcls().get(Constants.ENTRY).get(0);
+ final StringEntry aclsEntry = containerSpec.getApplicationAcls().get(Constants.ENTRY).get(0);
Assert.assertEquals(aclsKVNode.get(Constants.KEY).asText(), aclsEntry.getKey());
Assert.assertEquals(aclsKVNode.get(Constants.VALUE).asText(), aclsEntry.getValue());
}
- JsonNode sdatasNode = amSpecNode.get(Constants.SERVICE_DATA).get(Constants.ENTRY);
+ final JsonNode sdatasNode = amSpecNode.get(Constants.SERVICE_DATA).get(Constants.ENTRY);
Assert.assertNotNull(sdatasNode);
Assert.assertTrue(sdatasNode.isArray());
for (final JsonNode sdataKVNode : sdatasNode) {
- StringEntry sdataEntry = containerSpec.getServiceData().get(Constants.ENTRY).get(0);
+ final StringEntry sdataEntry = containerSpec.getServiceData().get(Constants.ENTRY).get(0);
Assert.assertEquals(sdataKVNode.get(Constants.KEY).asText(), sdataEntry.getKey());
Assert.assertEquals(sdataKVNode.get(Constants.VALUE).asText(), sdataEntry.getValue());
}
@@ -178,7 +178,7 @@ public final class TestHDInsightRESTJsonSerialization {
" }\n" +
"}";
- ApplicationID appId = new ObjectMapper().readValue(getAppIdBody, ApplicationID.class);
+ final ApplicationID appId = new ObjectMapper().readValue(getAppIdBody, ApplicationID.class);
Assert.assertEquals(appId.getApplicationId(), appIdStr);
Assert.assertEquals(appId.getResource().getMemory(), memory);
Assert.assertEquals(appId.getResource().getvCores(), vCores);
@@ -232,8 +232,8 @@ public final class TestHDInsightRESTJsonSerialization {
" }" +
"}";
- ApplicationResponse appResponse = new ObjectMapper().readValue(getAppBody, ApplicationResponse.class);
- ApplicationState appState = appResponse.getApplicationState();
+ final ApplicationResponse appResponse = new ObjectMapper().readValue(getAppBody, ApplicationResponse.class);
+ final ApplicationState appState = appResponse.getApplicationState();
Assert.assertEquals(appState.getFinishedTime(), finishedTime);
Assert.assertEquals(appState.getAmContainerLogs(), amContainerLogs);
Assert.assertEquals(appState.getTrackingUI(), trackingUI);
@@ -316,11 +316,11 @@ public final class TestHDInsightRESTJsonSerialization {
" }\n" +
"}";
- ListApplicationResponse listAppsResponse =
+ final ListApplicationResponse listAppsResponse =
new ObjectMapper().readValue(listAppsBody, ListApplicationResponse.class);
Assert.assertTrue(listAppsResponse.getApps().containsKey(Constants.APP));
Assert.assertEquals(listAppsResponse.getApplicationStates().size(), 2);
- for (ApplicationState state : listAppsResponse.getApplicationStates()) {
+ for (final ApplicationState state : listAppsResponse.getApplicationStates()) {
Assert.assertNotNull(state);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/PreparedDriverFolderLauncher.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/PreparedDriverFolderLauncher.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/PreparedDriverFolderLauncher.java
index 9cc6523..2f0c691 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/PreparedDriverFolderLauncher.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/PreparedDriverFolderLauncher.java
@@ -53,7 +53,8 @@ public class PreparedDriverFolderLauncher {
private static final Logger LOG = Logger.getLogger(PreparedDriverFolderLauncher.class.getName());
@Inject
- PreparedDriverFolderLauncher(final ExecutorService executor, REEFFileNames fileNames, ClasspathProvider classpath) {
+ PreparedDriverFolderLauncher(final ExecutorService executor, final REEFFileNames fileNames,
+ final ClasspathProvider classpath) {
this.executor = executor;
this.fileNames = fileNames;
this.classpath = classpath;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-local/src/test/java/org/apache/reef/runtime/local/driver/ResourceManagerTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/test/java/org/apache/reef/runtime/local/driver/ResourceManagerTest.java b/lang/java/reef-runtime-local/src/test/java/org/apache/reef/runtime/local/driver/ResourceManagerTest.java
index e32b18f..614582a 100644
--- a/lang/java/reef-runtime-local/src/test/java/org/apache/reef/runtime/local/driver/ResourceManagerTest.java
+++ b/lang/java/reef-runtime-local/src/test/java/org/apache/reef/runtime/local/driver/ResourceManagerTest.java
@@ -74,7 +74,7 @@ public class ResourceManagerTest {
@SuppressWarnings("unchecked")
@Before
public void setUp() throws InjectionException {
- JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
+ final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder();
cb.bindNamedParameter(RootFolder.class, "target/REEF_LOCAL_RUNTIME");
injector = Tang.Factory.getTang().newInjector(cb.build());
remoteManager = injector.getInstance(RemoteManager.class);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java
index 15fbc06..7401f90 100644
--- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java
@@ -133,7 +133,7 @@ final class MesosJobSubmissionHandler implements JobSubmissionHandler {
.redirectError(errFile)
.redirectOutput(outFile)
.start();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java
index 3a13a65..0ddba98 100644
--- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java
+++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java
@@ -105,7 +105,7 @@ final class MesosResourceLaunchHandler implements ResourceLaunchHandler {
this.executors.launchEvaluator(
new EvaluatorLaunch(resourceLaunchEvent.getIdentifier(), StringUtils.join(command, ' ')));
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java
index 4874468..a363e6a 100644
--- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java
+++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java
@@ -282,7 +282,7 @@ final class REEFScheduler implements Scheduler {
this.mesosMaster.stop();
try {
this.schedulerDriverEStage.close();
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new RuntimeException(e);
}
}
@@ -413,7 +413,7 @@ final class REEFScheduler implements Scheduler {
this.mesosMaster.stop();
try {
this.schedulerDriverEStage.close();
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new RuntimeException(e);
}
@@ -503,7 +503,7 @@ final class REEFScheduler implements Scheduler {
fileSystem.copyFromLocalFile(src, dst);
return reefTarUriValue;
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
index a4e3412..eda421f 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
@@ -70,7 +70,7 @@ final class YarnJobSubmissionHandler implements JobSubmissionHandler {
final ClasspathProvider classpath,
final JobUploader uploader,
@Parameter(JVMHeapSlack.class) final double jvmSlack,
- @Parameter(JobQueue.class) String defaultQueueName) throws IOException {
+ @Parameter(JobQueue.class) final String defaultQueueName) throws IOException {
this.yarnConfiguration = yarnConfiguration;
this.jobJarMaker = jobJarMaker;
@@ -162,7 +162,7 @@ final class YarnJobSubmissionHandler implements JobSubmissionHandler {
try {
return Optional.ofNullable(Tang.Factory.getTang().newInjector(configuration)
.getNamedInstance(DriverJobSubmissionDirectory.class));
- } catch (InjectionException ex) {
+ } catch (final InjectionException ex) {
return Optional.empty();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/uploader/JobUploader.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/uploader/JobUploader.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/uploader/JobUploader.java
index 98edbf5..299be70 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/uploader/JobUploader.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/uploader/JobUploader.java
@@ -39,7 +39,7 @@ public final class JobUploader {
@Inject
JobUploader(final YarnConfiguration yarnConfiguration,
- JobSubmissionDirectoryProvider jobSubmissionDirectoryProvider) throws IOException {
+ final JobSubmissionDirectoryProvider jobSubmissionDirectoryProvider) throws IOException {
this.jobSubmissionDirectoryProvider = jobSubmissionDirectoryProvider;
this.fileSystem = FileSystem.get(yarnConfiguration);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
index 435ee2b..00f26b6 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
@@ -79,7 +79,7 @@ final class EvaluatorSetupHelper {
Map<String, LocalResource> getGlobalResources() {
try {
return this.globalJarUploader.call();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException("Unable to upload the global JAR file to the job folder.", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/GlobalJarUploader.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/GlobalJarUploader.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/GlobalJarUploader.java
index 2c522e0..58be664 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/GlobalJarUploader.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/GlobalJarUploader.java
@@ -89,7 +89,7 @@ final class GlobalJarUploader implements Callable<Map<String, LocalResource>> {
this.isUploaded = true;
}
- LocalResource updatedGlobalJarResource = this.uploader.makeLocalResourceForJarFile(this.pathToGlobalJar);
+ final LocalResource updatedGlobalJarResource = this.uploader.makeLocalResourceForJarFile(this.pathToGlobalJar);
if (this.globalJarResource != null
&& this.globalJarResource.getTimestamp() != updatedGlobalJarResource.getTimestamp()) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/JobSubmissionDirectoryProviderImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/JobSubmissionDirectoryProviderImpl.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/JobSubmissionDirectoryProviderImpl.java
index e2391c6..056bccb 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/JobSubmissionDirectoryProviderImpl.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/JobSubmissionDirectoryProviderImpl.java
@@ -44,7 +44,7 @@ public final class JobSubmissionDirectoryProviderImpl implements JobSubmissionDi
}
@Override
- public Path getJobSubmissionDirectoryPath(String applicationId) {
+ public Path getJobSubmissionDirectoryPath(final String applicationId) {
return new Path(this.jobSubmissionDirectory +
"/" +
new SimpleDateFormat("yyyy_MM_dd_HH_mm_ss_").format(Calendar.getInstance().getTime()) +
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
index 6034086..5a8eac1 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
@@ -490,7 +490,7 @@ final class YarnContainerManager
}
}
- private boolean isSameKindOfRequest(AMRMClient.ContainerRequest r1, AMRMClient.ContainerRequest r2) {
+ private boolean isSameKindOfRequest(final AMRMClient.ContainerRequest r1, final AMRMClient.ContainerRequest r2) {
return r1.getPriority().compareTo(r2.getPriority()) == 0
&& r1.getCapability().compareTo(r2.getCapability()) == 0
&& r1.getRelaxLocality() == r2.getRelaxLocality()
@@ -503,7 +503,7 @@ final class YarnContainerManager
* We take into consideration that RM has some freedom in rounding
* up the allocation and in placing containers on other machines.
*/
- private boolean matchContainerWithPendingRequest(Container container) {
+ private boolean matchContainerWithPendingRequest(final Container container) {
if (this.requestsAfterSentToRM.isEmpty()) {
return false;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
index f576791..4f72170 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
@@ -78,20 +78,20 @@ public final class InjectionFuture<T> implements Future<T> {
instance = null;
}
- public InjectionFuture(final Injector injector, Class<? extends T> iface) {
+ public InjectionFuture(final Injector injector, final Class<? extends T> iface) {
this.injector = (InjectorImpl) injector;
this.iface = iface;
this.instance = null;
}
- public InjectionFuture(T instance) {
+ public InjectionFuture(final T instance) {
this.injector = null;
this.iface = null;
this.instance = instance;
}
@Override
- public boolean cancel(boolean mayInterruptIfRunning) {
+ public boolean cancel(final boolean mayInterruptIfRunning) {
return false;
}
@@ -119,19 +119,19 @@ public final class InjectionFuture<T> implements Future<T> {
} else {
t = injector.getInstance(iface);
}
- Aspect a = injector.getAspect();
+ final Aspect a = injector.getAspect();
if (a != null) {
a.injectionFutureInstantiated(this, t);
}
return t;
}
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
}
@Override
- public T get(long timeout, TimeUnit unit) {
+ public T get(final long timeout, final TimeUnit unit) {
throw new UnsupportedOperationException();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/Timer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/Timer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/Timer.java
index b4103fc..7cfcc4b 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/Timer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/Timer.java
@@ -35,28 +35,28 @@ public class Timer {
private final int seconds;
@Inject
- public Timer(@Parameter(Seconds.class) int seconds) {
+ public Timer(@Parameter(Seconds.class) final int seconds) {
if (seconds < 0) {
throw new IllegalArgumentException("Cannot sleep for negative time!");
}
this.seconds = seconds;
}
- public static void main(String[] args) throws Exception {
- Tang tang = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
- CommandLine cl = new CommandLine(cb);
+ public static void main(final String[] args) throws Exception {
+ final Tang tang = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = tang.newConfigurationBuilder();
+ final CommandLine cl = new CommandLine(cb);
cl.registerShortNameOfClass(Timer.Seconds.class);
cl.processCommandLine(args);
- Configuration conf = cb.build();
+ final Configuration conf = cb.build();
System.out.println("start conf");
System.out.println(ConfigurationFile.toConfigurationString(conf));
System.out.println("end conf");
- InjectorImpl injector = (InjectorImpl) tang.newInjector(conf);
- InjectionPlan<Timer> ip = injector.getInjectionPlan(Timer.class);
+ final InjectorImpl injector = (InjectorImpl) tang.newInjector(conf);
+ final InjectionPlan<Timer> ip = injector.getInjectionPlan(Timer.class);
System.out.println(ip.toPrettyString());
System.out.println("Number of plans:" + ip.getNumAlternatives());
- Timer timer = injector.getInstance(Timer.class);
+ final Timer timer = injector.getInstance(Timer.class);
System.out.println("Tick...");
timer.sleep();
System.out.println("Tock.");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/TimerV1.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/TimerV1.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/TimerV1.java
index d5f428b..ff671a6 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/TimerV1.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/TimerV1.java
@@ -35,22 +35,22 @@ public class TimerV1 {
private final int seconds;
@Inject
- public TimerV1(@Parameter(Seconds.class) int seconds) {
+ public TimerV1(@Parameter(Seconds.class) final int seconds) {
this.seconds = seconds;
}
- public static void main(String[] args) throws BindException, InjectionException {
- Tang tang = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = (JavaConfigurationBuilder) tang.newConfigurationBuilder();
- Configuration conf = cb.build();
- Injector injector = tang.newInjector(conf);
- TimerV1 timer = injector.getInstance(TimerV1.class);
+ public static void main(final String[] args) throws BindException, InjectionException {
+ final Tang tang = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = (JavaConfigurationBuilder) tang.newConfigurationBuilder();
+ final Configuration conf = cb.build();
+ final Injector injector = tang.newInjector(conf);
+ final TimerV1 timer = injector.getInstance(TimerV1.class);
try {
System.out.println("Tick...");
timer.sleep();
System.out.println("Tock.");
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerImpl.java
index 5b5c973..875412b 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerImpl.java
@@ -27,7 +27,7 @@ public class TimerImpl implements Timer {
private final int seconds;
@Inject
- public TimerImpl(@Parameter(Timer.Seconds.class) int seconds) {
+ public TimerImpl(@Parameter(Timer.Seconds.class) final int seconds) {
if (seconds < 0) {
throw new IllegalArgumentException("Cannot sleep for negative time!");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerMock.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerMock.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerMock.java
index 5e22d8c..a92ea4f 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerMock.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/TimerMock.java
@@ -38,18 +38,18 @@ public class TimerMock implements Timer {
private final int seconds;
@Inject
- TimerMock(@Parameter(Timer.Seconds.class) int seconds) {
+ TimerMock(@Parameter(Timer.Seconds.class) final int seconds) {
if (seconds < 0) {
throw new IllegalArgumentException("Cannot sleep for negative time!");
}
this.seconds = seconds;
}
- public static void main(String[] args) throws BindException, InjectionException, Exception {
- Configuration c = TimerMock.CONF
+ public static void main(final String[] args) throws BindException, InjectionException, Exception {
+ final Configuration c = TimerMock.CONF
.set(TimerMockConf.MOCK_SLEEP_TIME, 1)
.build();
- Timer t = Tang.Factory.getTang().newInjector(c).getInstance(Timer.class);
+ final Timer t = Tang.Factory.getTang().newInjector(c).getInstance(Timer.class);
System.out.println("Tick...");
t.sleep();
System.out.println("...tock.");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/BindException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/BindException.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/BindException.java
index 4b9e421..266d555 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/BindException.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/BindException.java
@@ -33,11 +33,11 @@ package org.apache.reef.tang.exceptions;
public class BindException extends RuntimeException {
private static final long serialVersionUID = 1L;
- public BindException(String msg, Throwable cause) {
+ public BindException(final String msg, final Throwable cause) {
super(msg, cause);
}
- public BindException(String msg) {
+ public BindException(final String msg) {
super(msg);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ClassHierarchyException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ClassHierarchyException.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ClassHierarchyException.java
index 52ac6ad..5f0d09b 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ClassHierarchyException.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ClassHierarchyException.java
@@ -26,15 +26,15 @@ package org.apache.reef.tang.exceptions;
public class ClassHierarchyException extends RuntimeException {
private static final long serialVersionUID = 1L;
- public ClassHierarchyException(Throwable cause) {
+ public ClassHierarchyException(final Throwable cause) {
super(cause);
}
- public ClassHierarchyException(String msg) {
+ public ClassHierarchyException(final String msg) {
super(msg);
}
- public ClassHierarchyException(String msg, Throwable cause) {
+ public ClassHierarchyException(final String msg, final Throwable cause) {
super(msg, cause);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/InjectionException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/InjectionException.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/InjectionException.java
index 2ba642c..9b0f83f 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/InjectionException.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/InjectionException.java
@@ -34,11 +34,11 @@ package org.apache.reef.tang.exceptions;
public class InjectionException extends Exception {
private static final long serialVersionUID = 1L;
- public InjectionException(String msg, Throwable cause) {
+ public InjectionException(final String msg, final Throwable cause) {
super(msg, cause);
}
- public InjectionException(String msg) {
+ public InjectionException(final String msg) {
super(msg);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/NameResolutionException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/NameResolutionException.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/NameResolutionException.java
index a97fa89..2a0e9bb 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/NameResolutionException.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/NameResolutionException.java
@@ -34,7 +34,7 @@ package org.apache.reef.tang.exceptions;
public class NameResolutionException extends BindException {
private static final long serialVersionUID = 1L;
- public NameResolutionException(String name, String longestPrefix) {
+ public NameResolutionException(final String name, final String longestPrefix) {
super("Could not resolve " + name + ". Search ended at prefix " + longestPrefix +
" This can happen due to typos in class names that are passed as strings, or because Tang is configured " +
"to use a classloader other than the one that generated the class reference " +
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ParseException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ParseException.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ParseException.java
index 55ed991..aae8007 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ParseException.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/exceptions/ParseException.java
@@ -26,11 +26,11 @@ package org.apache.reef.tang.exceptions;
public class ParseException extends BindException {
private static final long serialVersionUID = 1L;
- public ParseException(String msg, Throwable cause) {
+ public ParseException(final String msg, final Throwable cause) {
super(msg, cause);
}
- public ParseException(String msg) {
+ public ParseException(final String msg) {
super(msg);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java
index 8d6d1ff..8351efe 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java
@@ -84,7 +84,7 @@ public final class AvroConfigurationSerializer implements ConfigurationSerialize
try {
// TODO: Implement list deserialization
// rawValue is String.
- String value = rawValue.toString();
+ final String value = rawValue.toString();
if (key.equals(ConfigurationBuilderImpl.IMPORT)) {
configurationBuilder.getClassHierarchy().getNode(value);
final String[] tok = value.split(ReflectionUtilities.REGEXP);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
index 07e35cc..f879d16 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
@@ -122,7 +122,7 @@ public final class CommandLine {
@SafeVarargs
@SuppressWarnings("checkstyle:redundantmodifier")
public final <T> CommandLine processCommandLine(
- final String[] args, Class<? extends Name<?>>... argClasses)
+ final String[] args, final Class<? extends Name<?>>... argClasses)
throws IOException, BindException {
for (final Class<? extends Name<?>> c : argClasses) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java
index ae636c6..615df69 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java
@@ -100,21 +100,21 @@ public final class ConfigurationFile {
}
}
- private static void processConfigFile(ConfigurationBuilder conf,
- PropertiesConfiguration confFile) throws IOException, BindException {
- ConfigurationBuilderImpl ci = (ConfigurationBuilderImpl) conf;
- Iterator<String> it = confFile.getKeys();
- Map<String, String> importedNames = new HashMap<>();
+ private static void processConfigFile(final ConfigurationBuilder conf,
+ final PropertiesConfiguration confFile) throws IOException, BindException {
+ final ConfigurationBuilderImpl ci = (ConfigurationBuilderImpl) conf;
+ final Iterator<String> it = confFile.getKeys();
+ final Map<String, String> importedNames = new HashMap<>();
while (it.hasNext()) {
String key = it.next();
- String longName = importedNames.get(key);
- String[] values = confFile.getStringArray(key);
+ final String longName = importedNames.get(key);
+ final String[] values = confFile.getStringArray(key);
if (longName != null) {
// System.err.println("Mapped " + key + " to " + longName);
key = longName;
}
- for (String value : values) {
+ for (final String value : values) {
try {
if (key.equals(ConfigurationBuilderImpl.IMPORT)) {
ci.getClassHierarchy().getNode(value);
@@ -124,8 +124,8 @@ public final class ConfigurationFile {
// ci.namespace.getNode(lastTok);
ci.getClassHierarchy().getNode(lastTok);
throw new IllegalArgumentException("Conflict on short name: " + lastTok);
- } catch (BindException e) {
- String oldValue = importedNames.put(lastTok, value);
+ } catch (final BindException e) {
+ final String oldValue = importedNames.put(lastTok, value);
if (oldValue != null) {
throw new IllegalArgumentException("Name conflict: "
+ lastTok + " maps to " + oldValue + " and " + value);
@@ -136,14 +136,14 @@ public final class ConfigurationFile {
ConfigurationBuilderImpl.INIT.length(), value.length());
parseValue = parseValue.replaceAll("^[\\s\\(]+", "");
parseValue = parseValue.replaceAll("[\\s\\)]+$", "");
- String[] classes = parseValue.split("[\\s\\-]+");
+ final String[] classes = parseValue.split("[\\s\\-]+");
ci.registerLegacyConstructor(key, classes);
} else {
ci.bind(key, value);
}
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new BindException("Failed to process configuration tuple: [" + key + "=" + value + "]", e);
- } catch (ClassHierarchyException e) {
+ } catch (final ClassHierarchyException e) {
throw new ClassHierarchyException("Failed to process configuration tuple: [" + key + "=" + value + "]", e);
}
}
@@ -156,7 +156,7 @@ public final class ConfigurationFile {
* @param in
* @return
*/
- private static String escape(String in) {
+ private static String escape(final String in) {
// After regexp escaping \\\\ = 1 slash, \\\\\\\\ = 2 slashes.
// Also, the second args of replaceAll are neither strings nor regexps, and
@@ -183,8 +183,8 @@ public final class ConfigurationFile {
*/
@Deprecated
public static String toConfigurationString(final Configuration c) {
- StringBuilder sb = new StringBuilder();
- for (String s : toConfigurationStringList(c)) {
+ final StringBuilder sb = new StringBuilder();
+ for (final String s : toConfigurationStringList(c)) {
sb.append(s);
sb.append('\n');
}
@@ -196,25 +196,25 @@ public final class ConfigurationFile {
*/
@Deprecated
static List<String> toConfigurationStringList(final Configuration c) {
- ConfigurationImpl conf = (ConfigurationImpl) c;
- List<String> l = new ArrayList<>();
- for (ClassNode<?> opt : conf.getBoundImplementations()) {
+ final ConfigurationImpl conf = (ConfigurationImpl) c;
+ final List<String> l = new ArrayList<>();
+ for (final ClassNode<?> opt : conf.getBoundImplementations()) {
l.add(opt.getFullName()
+ '='
+ escape(conf.getBoundImplementation(opt).getFullName()));
}
- for (ClassNode<?> opt : conf.getBoundConstructors()) {
+ for (final ClassNode<?> opt : conf.getBoundConstructors()) {
l.add(opt.getFullName()
+ '='
+ escape(conf.getBoundConstructor(opt).getFullName()));
}
- for (NamedParameterNode<?> opt : conf.getNamedParameters()) {
+ for (final NamedParameterNode<?> opt : conf.getNamedParameters()) {
l.add(opt.getFullName()
+ '='
+ escape(conf.getNamedParameter(opt)));
}
- for (ClassNode<?> cn : conf.getLegacyConstructors()) {
- StringBuilder sb = new StringBuilder();
+ for (final ClassNode<?> cn : conf.getLegacyConstructors()) {
+ final StringBuilder sb = new StringBuilder();
join(sb, "-", conf.getLegacyConstructor(cn).getArgs());
l.add(cn.getFullName()
+ escape('='
@@ -226,7 +226,7 @@ public final class ConfigurationFile {
//s.append(cn.getFullName()).append('=').append(ConfigurationBuilderImpl.INIT).append('(');
// .append(")\n");
}
- for (Entry<NamedParameterNode<Set<?>>, Object> e : conf.getBoundSets()) {
+ for (final Entry<NamedParameterNode<Set<?>>, Object> e : conf.getBoundSets()) {
final String val;
if (e.getValue() instanceof String) {
val = (String) e.getValue();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
index 56abdef..c85bda1 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
@@ -54,12 +54,12 @@ public class ConfigurationModule {
private final Map<Impl<List>, List<?>> setImplLists = new MonotonicHashMap<>();
private final Map<Param<List>, List<?>> setParamLists = new MonotonicHashMap<>();
- protected ConfigurationModule(ConfigurationModuleBuilder builder) {
+ protected ConfigurationModule(final ConfigurationModuleBuilder builder) {
this.builder = builder.deepCopy();
}
private ConfigurationModule deepCopy() {
- ConfigurationModule cm = new ConfigurationModule(builder.deepCopy());
+ final ConfigurationModule cm = new ConfigurationModule(builder.deepCopy());
cm.setImpls.putAll(setImpls);
cm.setImplSets.addAll(setImplSets);
cm.setLateImplSets.addAll(setLateImplSets);
@@ -72,8 +72,8 @@ public class ConfigurationModule {
return cm;
}
- private <T> void processSet(Object impl) {
- Field f = builder.map.get(impl);
+ private <T> void processSet(final Object impl) {
+ final Field f = builder.map.get(impl);
if (f == null) { /* throw */
throw new ClassHierarchyException("Unknown Impl/Param when setting " +
ReflectionUtilities.getSimpleName(impl.getClass()) + ". Did you pass in a field from some other module?");
@@ -83,8 +83,8 @@ public class ConfigurationModule {
}
}
- public final <T> ConfigurationModule set(Impl<T> opt, Class<? extends T> impl) {
- ConfigurationModule c = deepCopy();
+ public final <T> ConfigurationModule set(final Impl<T> opt, final Class<? extends T> impl) {
+ final ConfigurationModule c = deepCopy();
c.processSet(opt);
if (c.builder.setOpts.contains(opt)) {
c.setImplSets.put(opt, impl);
@@ -94,8 +94,8 @@ public class ConfigurationModule {
return c;
}
- public final <T> ConfigurationModule set(Impl<T> opt, String impl) {
- ConfigurationModule c = deepCopy();
+ public final <T> ConfigurationModule set(final Impl<T> opt, final String impl) {
+ final ConfigurationModule c = deepCopy();
c.processSet(opt);
if (c.builder.setOpts.contains(opt)) {
c.setLateImplSets.put(opt, impl);
@@ -113,27 +113,27 @@ public class ConfigurationModule {
* @param <T>
* @return
*/
- public final <T> ConfigurationModule set(Impl<List> opt, List implList) {
- ConfigurationModule c = deepCopy();
+ public final <T> ConfigurationModule set(final Impl<List> opt, final List implList) {
+ final ConfigurationModule c = deepCopy();
c.processSet(opt);
c.setImplLists.put(opt, implList);
return c;
}
- public final <T> ConfigurationModule set(Param<T> opt, Class<? extends T> val) {
+ public final <T> ConfigurationModule set(final Param<T> opt, final Class<? extends T> val) {
return set(opt, ReflectionUtilities.getFullName(val));
}
- public final ConfigurationModule set(Param<Boolean> opt, boolean val) {
+ public final ConfigurationModule set(final Param<Boolean> opt, final boolean val) {
return set(opt, "" + val);
}
- public final ConfigurationModule set(Param<? extends Number> opt, Number val) {
+ public final ConfigurationModule set(final Param<? extends Number> opt, final Number val) {
return set(opt, "" + val);
}
- public final <T> ConfigurationModule set(Param<T> opt, String val) {
- ConfigurationModule c = deepCopy();
+ public final <T> ConfigurationModule set(final Param<T> opt, final String val) {
+ final ConfigurationModule c = deepCopy();
c.processSet(opt);
if (c.builder.setOpts.contains(opt)) {
c.setParamSets.put(opt, val);
@@ -151,8 +151,8 @@ public class ConfigurationModule {
* @param <T>
* @return
*/
- public final <T> ConfigurationModule set(Param<List> opt, List implList) {
- ConfigurationModule c = deepCopy();
+ public final <T> ConfigurationModule set(final Param<List> opt, final List implList) {
+ final ConfigurationModule c = deepCopy();
c.processSet(opt);
c.setParamLists.put(opt, implList);
return c;
@@ -160,11 +160,11 @@ public class ConfigurationModule {
@SuppressWarnings({"unchecked", "rawtypes"})
public Configuration build() throws BindException {
- ConfigurationModule c = deepCopy();
+ final ConfigurationModule c = deepCopy();
if (!c.reqSet.containsAll(c.builder.reqDecl)) {
- Set<Field> missingSet = new MonotonicHashSet<>();
- for (Field f : c.builder.reqDecl) {
+ final Set<Field> missingSet = new MonotonicHashSet<>();
+ for (final Field f : c.builder.reqDecl) {
if (!c.reqSet.contains(f)) {
missingSet.add(f);
}
@@ -174,38 +174,38 @@ public class ConfigurationModule {
+ builder.toString(missingSet));
}
- for (Class<?> clazz : c.builder.freeImpls.keySet()) {
- Impl<?> i = c.builder.freeImpls.get(clazz);
+ for (final Class<?> clazz : c.builder.freeImpls.keySet()) {
+ final Impl<?> i = c.builder.freeImpls.get(clazz);
if (c.setImpls.containsKey(i)) {
c.builder.b.bind(clazz, c.setImpls.get(i));
} else if (c.setLateImpls.containsKey(i)) {
c.builder.b.bind(ReflectionUtilities.getFullName(clazz), c.setLateImpls.get(i));
} else if (c.setImplSets.containsKey(i) || c.setLateImplSets.containsKey(i)) {
- for (Class<?> clz : c.setImplSets.getValuesForKey(i)) {
+ for (final Class<?> clz : c.setImplSets.getValuesForKey(i)) {
c.builder.b.bindSetEntry((Class) clazz, (Class) clz);
}
- for (String s : c.setLateImplSets.getValuesForKey(i)) {
+ for (final String s : c.setLateImplSets.getValuesForKey(i)) {
c.builder.b.bindSetEntry((Class) clazz, s);
}
} else if (c.setImplLists.containsKey(i)) {
c.builder.b.bindList((Class) clazz, c.setImplLists.get(i));
}
}
- for (Class<? extends Name<?>> clazz : c.builder.freeParams.keySet()) {
- Param<?> p = c.builder.freeParams.get(clazz);
- String s = c.setParams.get(p);
+ for (final Class<? extends Name<?>> clazz : c.builder.freeParams.keySet()) {
+ final Param<?> p = c.builder.freeParams.get(clazz);
+ final String s = c.setParams.get(p);
boolean foundOne = false;
if (s != null) {
c.builder.b.bindNamedParameter(clazz, s);
foundOne = true;
}
// Find the bound list for the NamedParameter
- List list = c.setParamLists.get(p);
+ final List list = c.setParamLists.get(p);
if (list != null) {
c.builder.b.bindList((Class) clazz, list);
foundOne = true;
}
- for (String paramStr : c.setParamSets.getValuesForKey(p)) {
+ for (final String paramStr : c.setParamSets.getValuesForKey(p)) {
c.builder.b.bindSetEntry((Class) clazz, paramStr);
foundOne = true;
}
@@ -220,13 +220,13 @@ public class ConfigurationModule {
}
public Set<NamedParameterNode<?>> getBoundNamedParameters() {
- Configuration c = this.builder.b.build();
- Set<NamedParameterNode<?>> nps = new MonotonicSet<>();
+ final Configuration c = this.builder.b.build();
+ final Set<NamedParameterNode<?>> nps = new MonotonicSet<>();
nps.addAll(c.getNamedParameters());
- for (Class<?> np : this.builder.freeParams.keySet()) {
+ for (final Class<?> np : this.builder.freeParams.keySet()) {
try {
nps.add((NamedParameterNode<?>) builder.b.getClassHierarchy().getNode(ReflectionUtilities.getFullName(np)));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new IllegalStateException(e);
}
}
@@ -234,12 +234,12 @@ public class ConfigurationModule {
}
public List<Entry<String, String>> toStringPairs() {
- List<Entry<String, String>> ret = new ArrayList<>();
+ final List<Entry<String, String>> ret = new ArrayList<>();
class MyEntry implements Entry<String, String> {
final String k;
final String v;
- public MyEntry(String k, String v) {
+ public MyEntry(final String k, final String v) {
this.k = k;
this.v = v;
}
@@ -255,21 +255,21 @@ public class ConfigurationModule {
}
@Override
- public String setValue(String value) {
+ public String setValue(final String value) {
throw new UnsupportedOperationException();
}
}
- for (Class<?> c : this.builder.freeParams.keySet()) {
+ for (final Class<?> c : this.builder.freeParams.keySet()) {
ret.add(new MyEntry(ReflectionUtilities.getFullName(c),
this.builder.map.get(this.builder.freeParams.get(c)).getName()));
}
- for (Class<?> c : this.builder.freeImpls.keySet()) {
+ for (final Class<?> c : this.builder.freeImpls.keySet()) {
ret.add(new MyEntry(ReflectionUtilities.getFullName(c),
this.builder.map.get(this.builder.freeImpls.get(c)).getName()));
}
- for (String s : ConfigurationFile.toConfigurationStringList(builder.b.build())) {
- String[] tok = s.split("=", 2);
+ for (final String s : ConfigurationFile.toConfigurationStringList(builder.b.build())) {
+ final String[] tok = s.split("=", 2);
ret.add(new MyEntry(tok[0], tok[1]));
}
@@ -277,9 +277,9 @@ public class ConfigurationModule {
}
public String toPrettyString() {
- StringBuilder sb = new StringBuilder();
+ final StringBuilder sb = new StringBuilder();
- for (Entry<String, String> l : toStringPairs()) {
+ for (final Entry<String, String> l : toStringPairs()) {
sb.append(l.getKey() + "=" + l.getValue() + "\n");
}
return sb.toString();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
index be0bfdf..a8da150 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java
@@ -60,8 +60,8 @@ public abstract class ConfigurationModuleBuilder {
private final Map<Class<?>, String> lateBindClazz = new MonotonicHashMap<>();
protected ConfigurationModuleBuilder() {
- for (Field f : getClass().getDeclaredFields()) {
- Class<?> t = f.getType();
+ for (final Field f : getClass().getDeclaredFields()) {
+ final Class<?> t = f.getType();
if (PARAM_BLACKLIST.contains(t)) {
throw new ClassHierarchyException(
"Found a field of type " + t + " which should be a Required/Optional Parameter/Implementation instead"
@@ -106,10 +106,10 @@ public abstract class ConfigurationModuleBuilder {
}
}
- private ConfigurationModuleBuilder(ConfigurationModuleBuilder c) {
+ private ConfigurationModuleBuilder(final ConfigurationModuleBuilder c) {
try {
b.addConfiguration(c.b.build());
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
reqDecl.addAll(c.reqDecl);
@@ -128,21 +128,21 @@ public abstract class ConfigurationModuleBuilder {
* TODO: It would be nice if this incorporated d by reference so that static analysis / documentation tools
* could document the dependency between c and d.
*/
- public final ConfigurationModuleBuilder merge(ConfigurationModule d) {
+ public final ConfigurationModuleBuilder merge(final ConfigurationModule d) {
if (d == null) {
throw new NullPointerException("If merge() was passed a static final field that is initialized to non-null, " +
"then this is almost certainly caused by a circular class dependency.");
}
try {
d.assertStaticClean();
- } catch (ClassHierarchyException e) {
+ } catch (final ClassHierarchyException e) {
throw new ClassHierarchyException(ReflectionUtilities.getFullName(getClass()) +
": detected attempt to merge with ConfigurationModule that has had set() called on it", e);
}
- ConfigurationModuleBuilder c = deepCopy();
+ final ConfigurationModuleBuilder c = deepCopy();
try {
c.b.addConfiguration(d.builder.b.build());
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
c.reqDecl.addAll(d.builder.reqDecl);
@@ -158,37 +158,38 @@ public abstract class ConfigurationModuleBuilder {
return c;
}
- public final <T> ConfigurationModuleBuilder bind(Class<?> iface, Impl<?> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bind(final Class<?> iface, final Impl<?> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeImpls.put(iface, opt);
return c;
}
- public final <T> ConfigurationModuleBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, String impl) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindSetEntry(
+ final Class<? extends Name<Set<T>>> iface, final String impl) {
+ final ConfigurationModuleBuilder c = deepCopy();
try {
c.b.bindSetEntry(iface, impl);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
return c;
}
- public final <T> ConfigurationModuleBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface,
- Class<? extends T> impl) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindSetEntry(final Class<? extends Name<Set<T>>> iface,
+ final Class<? extends T> impl) {
+ final ConfigurationModuleBuilder c = deepCopy();
try {
c.b.bindSetEntry(iface, impl);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
return c;
}
- public final <T> ConfigurationModuleBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface,
- Impl<? extends T> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindSetEntry(final Class<? extends Name<Set<T>>> iface,
+ final Impl<? extends T> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeImpls.put(iface, opt);
if (!setOpts.contains(opt)) {
@@ -197,9 +198,9 @@ public abstract class ConfigurationModuleBuilder {
return c;
}
- public final <T> ConfigurationModuleBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface,
- Param<? extends T> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindSetEntry(final Class<? extends Name<Set<T>>> iface,
+ final Param<? extends T> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeParams.put(iface, opt);
if (!setOpts.contains(opt)) {
@@ -209,114 +210,114 @@ public abstract class ConfigurationModuleBuilder {
}
- public final <T> ConfigurationModuleBuilder bindImplementation(Class<T> iface,
- Class<? extends T> impl) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindImplementation(final Class<T> iface,
+ final Class<? extends T> impl) {
+ final ConfigurationModuleBuilder c = deepCopy();
try {
c.b.bindImplementation(iface, impl);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
return c;
}
- public final <T> ConfigurationModuleBuilder bindImplementation(Class<T> iface,
- String impl) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindImplementation(final Class<T> iface,
+ final String impl) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.lateBindClazz.put(iface, impl);
return c;
}
- public final <T> ConfigurationModuleBuilder bindImplementation(Class<T> iface,
- Impl<? extends T> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindImplementation(final Class<T> iface,
+ final Impl<? extends T> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeImpls.put(iface, opt);
return c;
}
public final <T> ConfigurationModuleBuilder bindNamedParameter(
- Class<? extends Name<T>> name, String value) {
- ConfigurationModuleBuilder c = deepCopy();
+ final Class<? extends Name<T>> name, final String value) {
+ final ConfigurationModuleBuilder c = deepCopy();
try {
c.b.bindNamedParameter(name, value);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
return c;
}
public final <T> ConfigurationModuleBuilder bindNamedParameter(
- Class<? extends Name<T>> name, Param<T> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ final Class<? extends Name<T>> name, final Param<T> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeParams.put(name, opt);
return c;
}
public final <T> ConfigurationModuleBuilder bindNamedParameter(
- Class<? extends Name<T>> iface, Class<? extends T> impl) {
- ConfigurationModuleBuilder c = deepCopy();
+ final Class<? extends Name<T>> iface, final Class<? extends T> impl) {
+ final ConfigurationModuleBuilder c = deepCopy();
try {
c.b.bindNamedParameter(iface, impl);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
return c;
}
public final <T> ConfigurationModuleBuilder bindNamedParameter(
- Class<? extends Name<T>> iface, Impl<? extends T> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ final Class<? extends Name<T>> iface, final Impl<? extends T> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeImpls.put(iface, opt);
return c;
}
- public final <T> ConfigurationModuleBuilder bindConstructor(Class<T> clazz,
- Class<? extends ExternalConstructor<? extends T>>
+ public final <T> ConfigurationModuleBuilder bindConstructor(final Class<T> clazz,
+ final Class<? extends ExternalConstructor<? extends T>>
constructor) {
- ConfigurationModuleBuilder c = deepCopy();
+ final ConfigurationModuleBuilder c = deepCopy();
try {
c.b.bindConstructor(clazz, constructor);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException(e);
}
return c;
}
- public final <T> ConfigurationModuleBuilder bindConstructor(Class<T> cons,
- Impl<? extends ExternalConstructor<? extends T>> v) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindConstructor(
+ final Class<T> cons, final Impl<? extends ExternalConstructor<? extends T>> v) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(v);
c.freeImpls.put(cons, v);
return c;
}
- public final <T> ConfigurationModuleBuilder bindList(Class<? extends Name<List<T>>> iface,
- Impl<List> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindList(final Class<? extends Name<List<T>>> iface,
+ final Impl<List> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeImpls.put(iface, opt);
return c;
}
- public final <T> ConfigurationModuleBuilder bindList(Class<? extends Name<List<T>>> iface,
- Param<List> opt) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindList(final Class<? extends Name<List<T>>> iface,
+ final Param<List> opt) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.processUse(opt);
c.freeParams.put(iface, opt);
return c;
}
- public final <T> ConfigurationModuleBuilder bindList(Class<? extends Name<List<T>>> iface, List list) {
- ConfigurationModuleBuilder c = deepCopy();
+ public final <T> ConfigurationModuleBuilder bindList(final Class<? extends Name<List<T>>> iface, final List list) {
+ final ConfigurationModuleBuilder c = deepCopy();
c.b.bindList(iface, list);
return c;
}
- private <T> void processUse(Object impl) {
- Field f = map.get(impl);
+ private <T> void processUse(final Object impl) {
+ final Field f = map.get(impl);
if (f == null) { /* throw */
throw new ClassHierarchyException("Unknown Impl/Param when binding " +
ReflectionUtilities.getSimpleName(impl.getClass()) + ". Did you pass in a field from some other module?");
@@ -330,16 +331,16 @@ public abstract class ConfigurationModuleBuilder {
}
public final ConfigurationModule build() throws ClassHierarchyException {
- ConfigurationModuleBuilder c = deepCopy();
+ final ConfigurationModuleBuilder c = deepCopy();
if (!(c.reqUsed.containsAll(c.reqDecl) && c.optUsed.containsAll(c.optDecl))) {
- Set<Field> fset = new MonotonicHashSet<>();
- for (Field f : c.reqDecl) {
+ final Set<Field> fset = new MonotonicHashSet<>();
+ for (final Field f : c.reqDecl) {
if (!c.reqUsed.contains(f)) {
fset.add(f);
}
}
- for (Field f : c.optDecl) {
+ for (final Field f : c.optDecl) {
if (!c.optUsed.contains(f)) {
fset.add(f);
}
@@ -348,13 +349,13 @@ public abstract class ConfigurationModuleBuilder {
"Found declared options that were not used in binds: "
+ toString(fset));
}
- for (Class<?> clz : c.lateBindClazz.keySet()) {
+ for (final Class<?> clz : c.lateBindClazz.keySet()) {
try {
c.b.bind(ReflectionUtilities.getFullName(clz), c.lateBindClazz.get(clz));
- } catch (NameResolutionException e) {
+ } catch (final NameResolutionException e) {
throw new ClassHierarchyException("ConfigurationModule refers to unknown class: " +
c.lateBindClazz.get(clz), e);
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new ClassHierarchyException("bind failed while initializing ConfigurationModuleBuilder", e);
}
}
@@ -380,10 +381,10 @@ public abstract class ConfigurationModuleBuilder {
};
}
- final String toString(Set<Field> s) {
- StringBuilder sb = new StringBuilder("{");
+ final String toString(final Set<Field> s) {
+ final StringBuilder sb = new StringBuilder("{");
boolean first = true;
- for (Field f : s) {
+ for (final Field f : s) {
sb.append((first ? " " : ", ") + f.getName());
first = false;
}
[11/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java b/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
index dc017ed..d3b77e9 100644
--- a/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
+++ b/lang/java/reef-common/src/test/java/org/apache/reef/util/DeadlockInfoTest.java
@@ -131,13 +131,13 @@ public final class DeadlockInfoTest {
private static void barrierAwait(final CyclicBarrier barrier) {
try {
barrier.await(TIMEOUT_MILLIS, TimeUnit.MILLISECONDS);
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
fail("Unexpected exception");
- } catch (BrokenBarrierException e) {
+ } catch (final BrokenBarrierException e) {
e.printStackTrace();
fail("Unexpected exception");
- } catch (TimeoutException e) {
+ } catch (final TimeoutException e) {
e.printStackTrace();
fail("Unexpected exception");
}
@@ -152,7 +152,7 @@ public final class DeadlockInfoTest {
private static void threadSleep(final long millis) {
try {
Thread.sleep(millis);
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
e.printStackTrace();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
index 953ae53..d97b44a 100644
--- a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
+++ b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java
@@ -66,7 +66,7 @@ public final class HelloCLR {
public static LauncherStatus runHelloCLR(final Configuration runtimeConf, final int timeOut, final File clrFolder)
throws BindException, InjectionException {
- ConfigurationModule driverConf =
+ final ConfigurationModule driverConf =
addAll(DriverConfiguration.CONF, DriverConfiguration.GLOBAL_FILES, clrFolder)
.set(DriverConfiguration.GLOBAL_LIBRARIES, EnvironmentUtils.getClassLocation(HelloDriver.class))
.set(DriverConfiguration.DRIVER_IDENTIFIER, "HelloCLR")
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
index 05f601b..443b71e 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/SquaredErrorLossFunction.java
@@ -33,12 +33,12 @@ public class SquaredErrorLossFunction implements LossFunction {
}
@Override
- public double computeLoss(double y, double f) {
+ public double computeLoss(final double y, final double f) {
return Math.pow(y - f, 2.0);
}
@Override
- public double computeGradient(double y, double f) {
+ public double computeGradient(final double y, final double f) {
return (f - y) * 0.5;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
index 1766441..5cb65f4 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/WeightedLogisticLossFunction.java
@@ -38,7 +38,7 @@ public final class WeightedLogisticLossFunction implements LossFunction {
}
@Override
- public double computeLoss(double y, double f) {
+ public double computeLoss(final double y, final double f) {
final double predictedTimesLabel = y * f;
final double weight = y == -1 ? this.negWeight : this.posWeight;
@@ -51,7 +51,7 @@ public final class WeightedLogisticLossFunction implements LossFunction {
}
@Override
- public double computeGradient(double y, double f) {
+ public double computeGradient(final double y, final double f) {
final double predictedTimesLabel = y * f;
final double weight = y == -1 ? this.negWeight : this.posWeight;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
index 92ec713..b44ed75 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/VectorCodec.java
@@ -38,31 +38,31 @@ public class VectorCodec implements Codec<Vector> {
}
@Override
- public Vector decode(byte[] data) {
- ByteArrayInputStream bais = new ByteArrayInputStream(data);
- Vector result;
+ public Vector decode(final byte[] data) {
+ final ByteArrayInputStream bais = new ByteArrayInputStream(data);
+ final Vector result;
try (DataInputStream dais = new DataInputStream(bais)) {
- int size = dais.readInt();
+ final int size = dais.readInt();
result = new DenseVector(size);
for (int i = 0; i < size; i++) {
result.set(i, dais.readDouble());
}
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e.getCause());
}
return result;
}
@Override
- public byte[] encode(Vector vec) {
- ByteArrayOutputStream baos = new ByteArrayOutputStream(vec.size()
+ public byte[] encode(final Vector vec) {
+ final ByteArrayOutputStream baos = new ByteArrayOutputStream(vec.size()
* (Double.SIZE / Byte.SIZE));
try (DataOutputStream daos = new DataOutputStream(baos)) {
daos.writeInt(vec.size());
for (int i = 0; i < vec.size(); i++) {
daos.writeDouble(vec.get(i));
}
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e.getCause());
}
return baos.toByteArray();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
index bd02439..e170ada 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Window.java
@@ -29,12 +29,12 @@ public class Window {
private final int maxSize;
private final List<Double> list;
- public Window(int size) {
+ public Window(final int size) {
this.maxSize = size;
list = new ArrayList<>(size);
}
- public void add(double d) {
+ public void add(final double d) {
if (list.size() < maxSize) {
list.add(d);
return;
@@ -48,25 +48,26 @@ public class Window {
return 0;
}
double retVal = 0;
- for (double d : list) {
+ for (final double d : list) {
retVal += d;
}
return retVal / list.size();
}
- public double avgIfAdded(double d) {
+ public double avgIfAdded(final double in) {
+ double d = in;
if (list.isEmpty()) {
return d;
}
- int start = (list.size() < maxSize) ? 0 : 1;
- int numElems = (list.size() < maxSize) ? list.size() + 1 : maxSize;
+ final int start = (list.size() < maxSize) ? 0 : 1;
+ final int numElems = (list.size() < maxSize) ? list.size() + 1 : maxSize;
for (int i = start; i < list.size(); i++) {
d += list.get(i);
}
return d / numElems;
}
- public static void main(String[] args) {
+ public static void main(final String[] args) {
final Logger log = Logger.getLogger(Window.class.getName());
final Window w = new Window(3);
for (int i = 1; i < 10; i++) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
index 1fa9d2e..2003131 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarnTcp.java
@@ -61,9 +61,9 @@ public final class HelloReefYarnTcp {
}
private static Configuration getRuntimeConfiguration(
- int tcpBeginPort,
- int tcpRangeCount,
- int tcpTryCount) {
+ final int tcpBeginPort,
+ final int tcpRangeCount,
+ final int tcpTryCount) {
return Tang.Factory.getTang().newConfigurationBuilder(YarnClientConfiguration.CONF.build())
.bindSetEntry(DriverConfigurationProviders.class, TcpPortConfigurationProvider.class)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
index 041b447..891aa66 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdtHandler.java
@@ -139,7 +139,7 @@ class HttpServerShellCmdtHandler implements HttpHandler {
*
* @param message
*/
- public final synchronized void onHttpCallback(byte[] message) {
+ public final synchronized void onHttpCallback(final byte[] message) {
final long endTime = System.currentTimeMillis() + WAIT_TIMEOUT;
while (cmdOutput != null) {
final long waitTime = endTime - System.currentTimeMillis();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
index 74fba56..77fa5ca 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java
@@ -66,7 +66,7 @@ public final class ShellTask implements Task {
*/
@Override
public byte[] call(final byte[] memento) {
- String result = CommandUtils.runCommand(this.command);
+ final String result = CommandUtils.runCommand(this.command);
LOG.log(Level.INFO, result);
return CODEC.encode(result);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
index 6d86af6..4677c08 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java
@@ -187,7 +187,7 @@ final class Scheduler {
/**
* Add a task to the queue.
*/
- public synchronized void addTask(TaskEntity task) {
+ public synchronized void addTask(final TaskEntity task) {
taskQueue.add(task);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
index 23b091b..0b956de 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java
@@ -77,7 +77,7 @@ public final class SchedulerDriver {
@Inject
public SchedulerDriver(final EvaluatorRequestor requestor,
- @Parameter(SchedulerREEF.Retain.class) boolean retainable,
+ @Parameter(SchedulerREEF.Retain.class) final boolean retainable,
final Scheduler scheduler) {
this.requestor = requestor;
this.scheduler = scheduler;
@@ -127,7 +127,7 @@ public final class SchedulerDriver {
*/
final class ActiveContextHandler implements EventHandler<ActiveContext> {
@Override
- public void onNext(ActiveContext context) {
+ public void onNext(final ActiveContext context) {
synchronized (SchedulerDriver.this) {
LOG.log(Level.INFO, "Context available : {0}", context.getId());
@@ -187,7 +187,7 @@ public final class SchedulerDriver {
/**
* Get the status of a task.
*/
- public SchedulerResponse getTaskStatus(List<String> args) {
+ public SchedulerResponse getTaskStatus(final List<String> args) {
if (args.size() != 1) {
return SchedulerResponse.badRequest("Usage : only one ID at a time");
}
@@ -295,7 +295,7 @@ public final class SchedulerDriver {
// Wait until any command enters in the queue
try {
SchedulerDriver.this.wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
LOG.log(Level.WARNING, "InterruptedException occurred in SchedulerDriver", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
index c127b55..1a92861 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java
@@ -48,7 +48,7 @@ final class SchedulerHttpHandler implements HttpHandler {
}
@Override
- public void setUriSpecification(String s) {
+ public void setUriSpecification(final String s) {
uriSpecification = s;
}
@@ -65,7 +65,7 @@ final class SchedulerHttpHandler implements HttpHandler {
* /clear to clear the waiting queue
*/
@Override
- public void onHttpRequest(ParsedHttpRequest request, HttpServletResponse response)
+ public void onHttpRequest(final ParsedHttpRequest request, final HttpServletResponse response)
throws IOException, ServletException {
final String target = request.getTargetEntity().toLowerCase();
final Map<String, List<String>> queryMap = request.getQueryMap();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
index c0197f3..33bb388 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
@@ -104,7 +104,7 @@ public final class SchedulerREEF {
* @param args
* @throws InjectionException
*/
- public static void main(String[] args) throws InjectionException, IOException, ParseException {
+ public static void main(final String[] args) throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration = LocalRuntimeConfiguration.CONF
.set(LocalRuntimeConfiguration.MAX_NUMBER_OF_EVALUATORS, MAX_NUMBER_OF_EVALUATORS)
.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
index b14ad56..7911f45 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
@@ -37,7 +37,7 @@ public final class SchedulerREEFYarn {
* @throws InjectionException
* @throws java.io.IOException
*/
- public static void main(String[] args)
+ public static void main(final String[] args)
throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration =
YarnClientConfiguration.CONF.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
index 42456f4..a31cdeb 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/TaskEntity.java
@@ -44,7 +44,7 @@ final class TaskEntity {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -52,7 +52,7 @@ final class TaskEntity {
return false;
}
- TaskEntity that = (TaskEntity) o;
+ final TaskEntity that = (TaskEntity) o;
if (taskId != that.taskId) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
index 534ca06..0c5f657 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
@@ -60,7 +60,7 @@ public class ObjectWritableCodec<T extends Writable> implements Codec<T> {
* @throws RemoteRuntimeException if serialization fails.
*/
@Override
- public byte[] encode(T writable) {
+ public byte[] encode(final T writable) {
try (final ByteArrayOutputStream bos = new ByteArrayOutputStream();
final DataOutputStream dos = new DataOutputStream(bos)) {
writable.write(dos);
@@ -79,7 +79,7 @@ public class ObjectWritableCodec<T extends Writable> implements Codec<T> {
* @throws RemoteRuntimeException if deserialization fails.
*/
@Override
- public T decode(byte[] buffer) {
+ public T decode(final byte[] buffer) {
try (final ByteArrayInputStream bis = new ByteArrayInputStream(buffer);
final DataInputStream dis = new DataInputStream(bis)) {
final T writable = this.writableClass.newInstance();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
index 408c171..61120c4 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
@@ -167,7 +167,7 @@ public class SuspendTestTask implements Task, TaskMessageSource {
public class SuspendHandler implements EventHandler<SuspendEvent> {
@Override
- public void onNext(SuspendEvent suspendEvent) {
+ public void onNext(final SuspendEvent suspendEvent) {
final byte[] message = suspendEvent.get().get();
LOG.log(Level.INFO, "Suspend: {0} with: {1} bytes; counter: {2}",
new Object[]{this, message.length, SuspendTestTask.this.counter});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
index 690dfb2..6cb52ca 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/LoggingEventHandler.java
@@ -40,7 +40,7 @@ public class LoggingEventHandler<T> implements EventHandler<T> {
* @param downstreamEventHandler the event handler to hand the event to
* @param format Format string to log the event, e.g. "Event {0} received".
*/
- public LoggingEventHandler(EventHandler<T> downstreamEventHandler, final String format) {
+ public LoggingEventHandler(final EventHandler<T> downstreamEventHandler, final String format) {
this.downstreamEventHandler = downstreamEventHandler;
this.format = format;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
index 9c58d56..aa1af48 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InMemoryInputFormatDataSet.java
@@ -35,7 +35,7 @@ public class InMemoryInputFormatDataSet<K extends WritableComparable<K>, V exten
private List<Pair<K, V>> recordsList = null;
@Inject
- public InMemoryInputFormatDataSet(InputFormatDataSet<K, V> inputFormatDataSet) {
+ public InMemoryInputFormatDataSet(final InputFormatDataSet<K, V> inputFormatDataSet) {
this.inputFormatDataSet = inputFormatDataSet;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
index 31bda53..9a17626 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/MultiDataCenterEvaluatorToPartitionStrategy.java
@@ -134,19 +134,20 @@ public final class MultiDataCenterEvaluatorToPartitionStrategy extends AbstractE
concurrentMap.get(location).add(numberedSplit);
}
- private String normalize(String location) {
+ private String normalize(final String location) {
+ String loc = location;
// should start with a separator
- if (!location.startsWith(PATH_SEPARATOR)) {
- location = PATH_SEPARATOR + location;
+ if (!loc.startsWith(PATH_SEPARATOR)) {
+ loc = PATH_SEPARATOR + loc;
}
// if it is just /*, return /
- if (location.equals(PATH_SEPARATOR + ANY)) {
+ if (loc.equals(PATH_SEPARATOR + ANY)) {
return PATH_SEPARATOR;
}
// remove the ending ANY or path separator
- while (location.endsWith(ANY) || location.endsWith(PATH_SEPARATOR)) {
- location = location.substring(0, location.length() - 1);
+ while (loc.endsWith(ANY) || loc.endsWith(PATH_SEPARATOR)) {
+ loc = loc.substring(0, loc.length() - 1);
}
- return location;
+ return loc;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
index d50fbf3..6021d45 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
@@ -36,17 +36,17 @@ import java.io.*;
* to passed in while de-serialization
*/
public final class WritableSerializer {
- public static <E extends Writable> String serialize(E writable) {
+ public static <E extends Writable> String serialize(final E writable) {
final WritableCodec<E> writableCodec = new WritableCodec<>();
return Base64.encodeBase64String(writableCodec.encode(writable));
}
- public static <E extends Writable> E deserialize(String serializedWritable) {
+ public static <E extends Writable> E deserialize(final String serializedWritable) {
final WritableCodec<E> writableCodec = new WritableCodec<>();
return writableCodec.decode(Base64.decodeBase64(serializedWritable));
}
- public static <E extends Writable> E deserialize(String serializedWritable, JobConf jobConf) {
+ public static <E extends Writable> E deserialize(final String serializedWritable, final JobConf jobConf) {
final WritableCodec<E> writableCodec = new WritableCodec<>(jobConf);
return writableCodec.decode(Base64.decodeBase64(serializedWritable));
}
@@ -54,7 +54,7 @@ public final class WritableSerializer {
static class WritableCodec<E extends Writable> implements Codec<E> {
private final JobConf jobConf;
- public WritableCodec(JobConf jobConf) {
+ public WritableCodec(final JobConf jobConf) {
this.jobConf = jobConf;
}
@@ -63,28 +63,28 @@ public final class WritableSerializer {
}
@Override
- public E decode(byte[] bytes) {
+ public E decode(final byte[] bytes) {
final ByteArrayInputStream bais = new ByteArrayInputStream(bytes);
try (DataInputStream dais = new DataInputStream(bais)) {
final String className = dais.readUTF();
- E writable = (E) ReflectionUtils.newInstance(Class.forName(className), jobConf);
+ final E writable = (E) ReflectionUtils.newInstance(Class.forName(className), jobConf);
writable.readFields(dais);
return writable;
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException("Could not de-serialize JobConf", e);
- } catch (ClassNotFoundException e) {
+ } catch (final ClassNotFoundException e) {
throw new RuntimeException("Could not instantiate specific writable class", e);
}
}
@Override
- public byte[] encode(E writable) {
+ public byte[] encode(final E writable) {
final ByteArrayOutputStream baos = new ByteArrayOutputStream();
try (final DataOutputStream daos = new DataOutputStream(baos)) {
daos.writeUTF(writable.getClass().getName());
writable.write(daos);
return baos.toByteArray();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException("Could not serialize JobConf", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
index 472e619..a7b6c10 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
@@ -47,7 +47,8 @@ import org.apache.reef.wake.remote.transport.LinkListener;
* to the corresponding EventHandler registered in the ConnectionFactory.
*/
@DefaultImplementation(NetworkConnectionServiceImpl.class)
-public interface NetworkConnectionService extends AutoCloseable {
+public interface
+ NetworkConnectionService extends AutoCloseable {
/**
* Registers an instance of ConnectionFactory corresponding to the connectionFactoryId.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
index 8ebc7af..c52d088 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/exception/NetworkRuntimeException.java
@@ -30,7 +30,7 @@ public class NetworkRuntimeException extends RuntimeException {
* @param s the detailed message
* @param e the cause
*/
- public NetworkRuntimeException(String s, Throwable e) {
+ public NetworkRuntimeException(final String s, final Throwable e) {
super(s, e);
}
@@ -39,7 +39,7 @@ public class NetworkRuntimeException extends RuntimeException {
*
* @param s the detailed message
*/
- public NetworkRuntimeException(String s) {
+ public NetworkRuntimeException(final String s) {
super(s);
}
@@ -48,7 +48,7 @@ public class NetworkRuntimeException extends RuntimeException {
*
* @param e the cause
*/
- public NetworkRuntimeException(Throwable e) {
+ public NetworkRuntimeException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
index 3e08b07..f87b96ee 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java
@@ -186,7 +186,7 @@ public class GroupCommDriverImpl implements GroupCommServiceDriver {
NameResolver nameResolver = null;
try {
nameResolver = injector.getInstance(NameResolver.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
index a8f2237..74e9a83 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/BroadcastReceiver.java
@@ -133,7 +133,7 @@ public class BroadcastReceiver<T> implements Broadcast.Receiver<T>, EventHandler
final T retVal;
// Wait for parent to send
LOG.fine(this + " Waiting to receive broadcast");
- byte[] data;
+ final byte[] data;
try {
data = topology.recvFromParent();
// TODO: Should receive the identity element instead of null
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
index 87ea9c5..7be3165 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
@@ -66,7 +66,7 @@ public abstract class NodeStructImpl implements NodeStruct {
@Override
public byte[] getData() {
LOG.entering("NodeStructImpl", "getData");
- GroupCommunicationMessage gcm;
+ final GroupCommunicationMessage gcm;
try {
gcm = dataQue.take();
} catch (final InterruptedException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
index fb8abac..2ef12b2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/OperatorTopologyStructImpl.java
@@ -295,7 +295,7 @@ public class OperatorTopologyStructImpl implements OperatorTopologyStruct {
while (!childrenToRcvFrom.isEmpty()) {
LOG.finest(getQualifiedName() + "Waiting for some child to send data");
- NodeStruct child;
+ final NodeStruct child;
try {
child = nodesWithData.take();
} catch (final InterruptedException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
index 4bfd0b7..efe5f0c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java
@@ -106,7 +106,7 @@ class NSConnection<T> implements Connection<T> {
}
@Override
- public void write(List<T> messages) {
+ public void write(final List<T> messages) {
this.link.write(new NSMessage<T>(this.srcId, this.destId, messages));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
index 5a9c43e..fe3aa99 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSMessageCodec.java
@@ -115,7 +115,7 @@ public class NSMessageCodec<T> implements Codec<NSMessage<T>> {
throw new RuntimeException("IOException", e);
}
} else {
- NSMessagePBuf pbuf;
+ final NSMessagePBuf pbuf;
try {
pbuf = NSMessagePBuf.parseFrom(buf);
} catch (final InvalidProtocolBufferException e) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
index d2175e7..1dd775d 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnection.java
@@ -80,7 +80,7 @@ final class NetworkConnection<T> implements Connection<T> {
@Override
public String toString() {
- StringBuilder sb = new StringBuilder();
+ final StringBuilder sb = new StringBuilder();
sb.append("Connection from")
.append(connFactory.getSrcId())
.append(":")
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
index f5e1f83..f24177a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
@@ -143,7 +143,7 @@ public final class NetworkConnectionServiceImpl implements NetworkConnectionServ
final Codec<T> codec,
final EventHandler<Message<T>> eventHandler,
final LinkListener<Message<T>> linkListener) throws NetworkException {
- String id = connFactoryId.toString();
+ final String id = connFactoryId.toString();
if (connFactoryMap.get(id) != null) {
throw new NetworkException("ConnectionFactory " + connFactoryId + " was already registered.");
}
@@ -197,7 +197,7 @@ public final class NetworkConnectionServiceImpl implements NetworkConnectionServ
throw new NetworkException("Lookup " + destId + " is null");
}
return transport.open(address, nsCodec, nsLinkListener);
- } catch(Exception e) {
+ } catch(final Exception e) {
e.printStackTrace();
throw new NetworkException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
index 9ce10c1..910c1e0 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
@@ -101,12 +101,12 @@ final class NetworkConnectionServiceMessage<T> implements Message<T> {
* @return a string representation of this object
*/
public String toString() {
- StringBuilder builder = new StringBuilder();
+ final StringBuilder builder = new StringBuilder();
builder.append("NSMessage");
builder.append(" remoteID=");
builder.append(destId);
builder.append(" message=[| ");
- for (T message : messages) {
+ for (final T message : messages) {
builder.append(message + " |");
}
builder.append("]");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
index 9b91aa8..c2ff93c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
@@ -225,7 +225,7 @@ public final class NetworkService<T> implements Stage, ConnectionFactory<T> {
this.nameServiceRegisteringStage.onNext(tuple);
}
- public void unregisterId(Identifier id) {
+ public void unregisterId(final Identifier id) {
this.myId = null;
LOG.log(Level.FINEST, "Unbinding {0} to NetworkService@({1})",
new Object[]{id, this.transport.getLocalAddress()});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
index e73ec3b..01bacd5 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkServiceClosingHandler.java
@@ -32,10 +32,10 @@ public class NetworkServiceClosingHandler implements EventHandler<ContextStop> {
}
@Override
- public void onNext(ContextStop arg0) {
+ public void onNext(final ContextStop arg0) {
try {
networkService.close();
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new RuntimeException("Exception while closing NetworkService", e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
index d08e72a..83b3724 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameAssignmentTuple.java
@@ -37,7 +37,7 @@ public class NameAssignmentTuple implements NameAssignment {
* @param id an identifier
* @param addr an Internet socket address
*/
- public NameAssignmentTuple(Identifier id, InetSocketAddress addr) {
+ public NameAssignmentTuple(final Identifier id, final InetSocketAddress addr) {
this.id = id;
this.addr = addr;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
index 52e7015..d6fbb3c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameCache.java
@@ -39,7 +39,7 @@ public class NameCache implements Cache<Identifier, InetSocketAddress> {
*
* @param timeout a cache entry timeout after write
*/
- public NameCache(long timeout) {
+ public NameCache(final long timeout) {
cache = new CacheImpl<>(new SystemTime(), timeout);
}
@@ -52,8 +52,8 @@ public class NameCache implements Cache<Identifier, InetSocketAddress> {
* @throws ExecutionException
*/
@Override
- public InetSocketAddress get(Identifier key,
- Callable<InetSocketAddress> valueFetcher) throws ExecutionException {
+ public InetSocketAddress get(final Identifier key,
+ final Callable<InetSocketAddress> valueFetcher) throws ExecutionException {
return cache.get(key, valueFetcher);
}
@@ -63,7 +63,7 @@ public class NameCache implements Cache<Identifier, InetSocketAddress> {
* @param key an identifier
*/
@Override
- public void invalidate(Identifier key) {
+ public void invalidate(final Identifier key) {
cache.invalidate(key);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
index ecfba79..6cc8581 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
@@ -173,7 +173,7 @@ public final class NameClient implements NameResolver {
final LocalAddressProvider localAddressProvider,
final TransportFactory tpFactory) {
- NameCache cache = new NameCache(timeout);
+ final NameCache cache = new NameCache(timeout);
final BlockingQueue<NamingLookupResponse> replyLookupQueue = new LinkedBlockingQueue<NamingLookupResponse>();
final BlockingQueue<NamingRegisterResponse> replyRegisterQueue = new LinkedBlockingQueue<NamingRegisterResponse>();
final Codec<NamingMessage> codec = NamingCodecFactory.createFullCodec(factory);
@@ -286,14 +286,14 @@ class NamingResponseHandler implements EventHandler<NamingMessage> {
private final BlockingQueue<NamingLookupResponse> replyLookupQueue;
private final BlockingQueue<NamingRegisterResponse> replyRegisterQueue;
- NamingResponseHandler(BlockingQueue<NamingLookupResponse> replyLookupQueue,
- BlockingQueue<NamingRegisterResponse> replyRegisterQueue) {
+ NamingResponseHandler(final BlockingQueue<NamingLookupResponse> replyLookupQueue,
+ final BlockingQueue<NamingRegisterResponse> replyRegisterQueue) {
this.replyLookupQueue = replyLookupQueue;
this.replyRegisterQueue = replyRegisterQueue;
}
@Override
- public void onNext(NamingMessage value) {
+ public void onNext(final NamingMessage value) {
if (value instanceof NamingLookupResponse) {
replyLookupQueue.offer((NamingLookupResponse) value);
} else if (value instanceof NamingRegisterResponse) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
index 6270722..766a06c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameRegistryClient.java
@@ -96,14 +96,14 @@ public class NameRegistryClient implements Stage, NamingRegistry {
this.codec = NamingCodecFactory.createRegistryCodec(factory);
this.replyQueue = new LinkedBlockingQueue<>();
- Injector injector = Tang.Factory.getTang().newInjector();
+ final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(RemoteConfiguration.HostAddress.class, localAddressProvider.getLocalAddress());
injector.bindVolatileParameter(RemoteConfiguration.RemoteClientStage.class,
new SyncStage<>(new NamingRegistryClientHandler(new NamingRegistryResponseHandler(replyQueue), codec)));
try {
this.transport = injector.getInstance(NettyMessagingTransport.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
}
@@ -170,8 +170,8 @@ public class NameRegistryClient implements Stage, NamingRegistry {
* @param id an identifier
*/
@Override
- public void unregister(Identifier id) throws IOException {
- Link<NamingMessage> link = transport.open(serverSocketAddr, codec,
+ public void unregister(final Identifier id) throws IOException {
+ final Link<NamingMessage> link = transport.open(serverSocketAddr, codec,
new LoggingLinkListener<NamingMessage>());
link.write(new NamingUnregisterRequest(id));
}
@@ -195,13 +195,13 @@ class NamingRegistryClientHandler implements EventHandler<TransportEvent> {
private final EventHandler<NamingRegisterResponse> handler;
private final Codec<NamingMessage> codec;
- NamingRegistryClientHandler(EventHandler<NamingRegisterResponse> handler, Codec<NamingMessage> codec) {
+ NamingRegistryClientHandler(final EventHandler<NamingRegisterResponse> handler, final Codec<NamingMessage> codec) {
this.handler = handler;
this.codec = codec;
}
@Override
- public void onNext(TransportEvent value) {
+ public void onNext(final TransportEvent value) {
LOG.log(Level.FINE, value.toString());
handler.onNext((NamingRegisterResponse) codec.decode(value.getData()));
}
@@ -214,12 +214,12 @@ class NamingRegistryResponseHandler implements EventHandler<NamingRegisterRespon
private final BlockingQueue<NamingRegisterResponse> replyQueue;
- NamingRegistryResponseHandler(BlockingQueue<NamingRegisterResponse> replyQueue) {
+ NamingRegistryResponseHandler(final BlockingQueue<NamingRegisterResponse> replyQueue) {
this.replyQueue = replyQueue;
}
@Override
- public void onNext(NamingRegisterResponse value) {
+ public void onNext(final NamingRegisterResponse value) {
replyQueue.offer(value);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
index 8fc7cae..f283de2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
@@ -74,7 +74,7 @@ public final class NameServerImpl implements NameServer {
@Parameter(NameServerParameters.NameServerIdentifierFactory.class) final IdentifierFactory factory,
final LocalAddressProvider localAddressProvider) {
- Injector injector = Tang.Factory.getTang().newInjector();
+ final Injector injector = Tang.Factory.getTang().newInjector();
this.localAddressProvider = localAddressProvider;
this.reefEventStateManager = null;
@@ -88,7 +88,7 @@ public final class NameServerImpl implements NameServer {
try {
this.transport = injector.getInstance(NettyMessagingTransport.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw new RuntimeException(e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
index 2fa0cc2..631b692 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java
@@ -37,12 +37,12 @@ final class NamingCodecFactory {
* @param factory an identifier factory
* @return a codec
*/
- static Codec<NamingMessage> createLookupCodec(IdentifierFactory factory) {
- Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
+ static Codec<NamingMessage> createLookupCodec(final IdentifierFactory factory) {
+ final Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
= new HashMap<Class<? extends NamingMessage>, Codec<? extends NamingMessage>>();
clazzToCodecMap.put(NamingLookupRequest.class, new NamingLookupRequestCodec(factory));
clazzToCodecMap.put(NamingLookupResponse.class, new NamingLookupResponseCodec(factory));
- Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
+ final Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
return codec;
}
@@ -52,14 +52,14 @@ final class NamingCodecFactory {
* @param factory an identifier factory
* @return a codec
*/
- static Codec<NamingMessage> createRegistryCodec(IdentifierFactory factory) {
- Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
+ static Codec<NamingMessage> createRegistryCodec(final IdentifierFactory factory) {
+ final Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
= new HashMap<Class<? extends NamingMessage>, Codec<? extends NamingMessage>>();
clazzToCodecMap.put(NamingRegisterRequest.class, new NamingRegisterRequestCodec(factory));
clazzToCodecMap.put(NamingRegisterResponse.class,
new NamingRegisterResponseCodec(new NamingRegisterRequestCodec(factory)));
clazzToCodecMap.put(NamingUnregisterRequest.class, new NamingUnregisterRequestCodec(factory));
- Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
+ final Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
return codec;
}
@@ -69,8 +69,8 @@ final class NamingCodecFactory {
* @param factory an identifier factory
* @return a codec
*/
- static Codec<NamingMessage> createFullCodec(IdentifierFactory factory) {
- Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
+ static Codec<NamingMessage> createFullCodec(final IdentifierFactory factory) {
+ final Map<Class<? extends NamingMessage>, Codec<? extends NamingMessage>> clazzToCodecMap
= new HashMap<Class<? extends NamingMessage>, Codec<? extends NamingMessage>>();
clazzToCodecMap.put(NamingLookupRequest.class, new NamingLookupRequestCodec(factory));
clazzToCodecMap.put(NamingLookupResponse.class, new NamingLookupResponseCodec(factory));
@@ -78,7 +78,7 @@ final class NamingCodecFactory {
clazzToCodecMap.put(NamingRegisterResponse.class,
new NamingRegisterResponseCodec(new NamingRegisterRequestCodec(factory)));
clazzToCodecMap.put(NamingUnregisterRequest.class, new NamingUnregisterRequestCodec(factory));
- Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
+ final Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap);
return codec;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
index a64dbc0..f58f1d0 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingException.java
@@ -32,7 +32,7 @@ public class NamingException extends NetworkException {
* @param s the detailed message
* @param e the cause
*/
- public NamingException(String s, Throwable e) {
+ public NamingException(final String s, final Throwable e) {
super(s, e);
}
@@ -41,7 +41,7 @@ public class NamingException extends NetworkException {
*
* @param s the detailed message
*/
- public NamingException(String s) {
+ public NamingException(final String s) {
super(s);
}
@@ -50,7 +50,7 @@ public class NamingException extends NetworkException {
*
* @param e the cause
*/
- public NamingException(Throwable e) {
+ public NamingException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
index 840df5f..383d05a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/exception/NamingRuntimeException.java
@@ -32,7 +32,7 @@ public class NamingRuntimeException extends NetworkRuntimeException {
* @param s the detailed message
* @param e the cause
*/
- public NamingRuntimeException(String s, Throwable e) {
+ public NamingRuntimeException(final String s, final Throwable e) {
super(s, e);
}
@@ -41,7 +41,7 @@ public class NamingRuntimeException extends NetworkRuntimeException {
*
* @param s the detailed message
*/
- public NamingRuntimeException(String s) {
+ public NamingRuntimeException(final String s) {
super(s);
}
@@ -50,7 +50,7 @@ public class NamingRuntimeException extends NetworkRuntimeException {
*
* @param e the cause
*/
- public NamingRuntimeException(Throwable e) {
+ public NamingRuntimeException(final Throwable e) {
super(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
index ce9bcc5..4664057 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
@@ -41,7 +41,7 @@ final class AvroUtils {
* @param <T>
* @return
*/
- static <T> byte[] toBytes(T avroObject, Class<T> theClass) {
+ static <T> byte[] toBytes(final T avroObject, final Class<T> theClass) {
final DatumWriter<T> datumWriter = new SpecificDatumWriter<>(theClass);
final byte[] theBytes;
try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
index d826a1b..ee80eb1 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupRequest.java
@@ -31,7 +31,7 @@ public class NamingLookupRequest extends NamingMessage {
*
* @param ids the iterable of identifiers
*/
- public NamingLookupRequest(Iterable<Identifier> ids) {
+ public NamingLookupRequest(final Iterable<Identifier> ids) {
this.ids = ids;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
index 6855299..0d27a3d 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponse.java
@@ -33,7 +33,7 @@ public class NamingLookupResponse extends NamingMessage {
*
* @param nas the list of name assignments
*/
- public NamingLookupResponse(List<NameAssignment> nas) {
+ public NamingLookupResponse(final List<NameAssignment> nas) {
this.nas = nas;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
index a9787af..aa40d3a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java
@@ -54,7 +54,7 @@ public final class NamingLookupResponseCodec implements Codec<NamingLookupRespon
* @return a byte array
*/
@Override
- public byte[] encode(NamingLookupResponse obj) {
+ public byte[] encode(final NamingLookupResponse obj) {
final List<AvroNamingAssignment> assignments = new ArrayList<>(obj.getNameAssignments().size());
for (final NameAssignment nameAssignment : obj.getNameAssignments()) {
assignments.add(AvroNamingAssignment.newBuilder()
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
index 2eb4425..e4afb4e 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingMessage.java
@@ -40,7 +40,7 @@ public abstract class NamingMessage {
*
* @param link the link
*/
- public void setLink(Link<byte[]> link) {
+ public void setLink(final Link<byte[]> link) {
this.link = link;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
index 443b349..a032536 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequest.java
@@ -31,7 +31,7 @@ public class NamingRegisterRequest extends NamingMessage {
*
* @param na the name assignment
*/
- public NamingRegisterRequest(NameAssignment na) {
+ public NamingRegisterRequest(final NameAssignment na) {
this.na = na;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
index 18a979f..011c16d 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java
@@ -37,7 +37,7 @@ public class NamingRegisterRequestCodec implements Codec<NamingRegisterRequest>
*
* @param factory the identifier factory
*/
- public NamingRegisterRequestCodec(IdentifierFactory factory) {
+ public NamingRegisterRequestCodec(final IdentifierFactory factory) {
this.factory = factory;
}
@@ -48,7 +48,7 @@ public class NamingRegisterRequestCodec implements Codec<NamingRegisterRequest>
* @return a byte array
*/
@Override
- public byte[] encode(NamingRegisterRequest obj) {
+ public byte[] encode(final NamingRegisterRequest obj) {
final AvroNamingRegisterRequest result = AvroNamingRegisterRequest.newBuilder()
.setId(obj.getNameAssignment().getIdentifier().toString())
.setHost(obj.getNameAssignment().getAddress().getHostName())
@@ -65,7 +65,7 @@ public class NamingRegisterRequestCodec implements Codec<NamingRegisterRequest>
* @throws org.apache.reef.io.network.naming.exception.NamingRuntimeException
*/
@Override
- public NamingRegisterRequest decode(byte[] buf) {
+ public NamingRegisterRequest decode(final byte[] buf) {
final AvroNamingRegisterRequest avroNamingRegisterRequest =
AvroUtils.fromBytes(buf, AvroNamingRegisterRequest.class);
return new NamingRegisterRequest(
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
index 4737d4d..e1c07ce 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponse.java
@@ -29,7 +29,7 @@ public class NamingRegisterResponse extends NamingMessage {
*
* @param request the naming register request
*/
- public NamingRegisterResponse(NamingRegisterRequest request) {
+ public NamingRegisterResponse(final NamingRegisterRequest request) {
this.request = request;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
index f71c75b..228a748 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterResponseCodec.java
@@ -31,7 +31,7 @@ public class NamingRegisterResponseCodec implements Codec<NamingRegisterResponse
*
* @param codec the naming register request codec
*/
- public NamingRegisterResponseCodec(NamingRegisterRequestCodec codec) {
+ public NamingRegisterResponseCodec(final NamingRegisterRequestCodec codec) {
this.codec = codec;
}
@@ -42,7 +42,7 @@ public class NamingRegisterResponseCodec implements Codec<NamingRegisterResponse
* @return bytes a byte array
*/
@Override
- public byte[] encode(NamingRegisterResponse obj) {
+ public byte[] encode(final NamingRegisterResponse obj) {
return codec.encode(obj.getRequest());
}
@@ -53,7 +53,7 @@ public class NamingRegisterResponseCodec implements Codec<NamingRegisterResponse
* @return a naming register response
*/
@Override
- public NamingRegisterResponse decode(byte[] buf) {
+ public NamingRegisterResponse decode(final byte[] buf) {
return new NamingRegisterResponse(codec.decode(buf));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
index 6e3ff44..8a238d9 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequest.java
@@ -31,7 +31,7 @@ public class NamingUnregisterRequest extends NamingMessage {
*
* @param id the identifier
*/
- public NamingUnregisterRequest(Identifier id) {
+ public NamingUnregisterRequest(final Identifier id) {
this.id = id;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
index cf0858a..f220cd2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java
@@ -48,7 +48,7 @@ public final class NamingUnregisterRequestCodec implements Codec<NamingUnregiste
* @return a byte array
*/
@Override
- public byte[] encode(NamingUnregisterRequest obj) {
+ public byte[] encode(final NamingUnregisterRequest obj) {
final AvroNamingUnRegisterRequest result = AvroNamingUnRegisterRequest.newBuilder()
.setId(obj.getIdentifier().toString())
.build();
@@ -63,7 +63,7 @@ public final class NamingUnregisterRequestCodec implements Codec<NamingUnregiste
* @throws org.apache.reef.io.network.naming.exception.NamingRuntimeException
*/
@Override
- public NamingUnregisterRequest decode(byte[] buf) {
+ public NamingUnregisterRequest decode(final byte[] buf) {
final AvroNamingUnRegisterRequest result = AvroUtils.fromBytes(buf, AvroNamingUnRegisterRequest.class);
return new NamingUnregisterRequest(factory.getNewInstance(result.getId().toString()));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
index 70d6a41..5bf4685 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringCodec.java
@@ -31,12 +31,12 @@ public class StringCodec implements Codec<String> {
}
@Override
- public byte[] encode(String obj) {
+ public byte[] encode(final String obj) {
return obj.getBytes();
}
@Override
- public String decode(byte[] buf) {
+ public String decode(final byte[] buf) {
return new String(buf);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
index f8da208..c2de9d0 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifier.java
@@ -33,7 +33,7 @@ public class StringIdentifier implements ComparableIdentifier {
*
* @param str a string
*/
- StringIdentifier(String str) {
+ StringIdentifier(final String str) {
this.str = str;
}
@@ -52,7 +52,7 @@ public class StringIdentifier implements ComparableIdentifier {
* @param o another object
* @return true if the object is the same as the object argument; false, otherwise
*/
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
return str.equals(((StringIdentifier) o).toString());
}
@@ -66,7 +66,7 @@ public class StringIdentifier implements ComparableIdentifier {
}
@Override
- public int compareTo(Identifier o) {
+ public int compareTo(final Identifier o) {
if (o == null) {
if (str == null) {
return 0;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
index cc51d21..708a309 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/StringIdentifierFactory.java
@@ -39,7 +39,7 @@ public class StringIdentifierFactory implements IdentifierFactory {
* @return a string identifier
*/
@Override
- public Identifier getNewInstance(String s) {
+ public Identifier getNewInstance(final String s) {
return new StringIdentifier(s);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
index 2a96662..664e5a5 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingInputStream.java
@@ -27,16 +27,16 @@ import java.util.Iterator;
public class FramingInputStream extends DataInputStream implements Iterable<byte[]> {
- public FramingInputStream(InputStream in) {
+ public FramingInputStream(final InputStream in) {
super(in);
}
public byte[] readFrame() throws IOException {
- int i = readInt();
+ final int i = readInt();
if (i == -1) {
return null;
}
- byte[] b = new byte[i];
+ final byte[] b = new byte[i];
readFully(b);
return b;
}
@@ -54,10 +54,10 @@ public class FramingInputStream extends DataInputStream implements Iterable<byte
@Override
public byte[] next() {
- byte[] ret = cur;
+ final byte[] ret = cur;
try {
cur = readFrame();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
return ret;
@@ -68,7 +68,7 @@ public class FramingInputStream extends DataInputStream implements Iterable<byte
throw new UnsupportedOperationException();
}
};
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
index 26013fa..28f6916 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingOutputStream.java
@@ -35,7 +35,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
private long offset;
private boolean closed;
- public FramingOutputStream(OutputStream o) {
+ public FramingOutputStream(final OutputStream o) {
if (!(o instanceof DataOutputStream)) {
this.o = new DataOutputStream(o);
} else {
@@ -50,7 +50,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
offset += 4;
baos.writeTo(o);
baos.reset();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new StorageException(e);
}
}
@@ -60,19 +60,19 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
}
@Override
- public void write(int b) throws IOException {
+ public void write(final int b) throws IOException {
baos.write(b);
offset++;
}
@Override
- public void write(byte[] b) throws IOException {
+ public void write(final byte[] b) throws IOException {
baos.write(b);
this.offset += b.length;
}
@Override
- public void write(byte[] b, int offsetToWrite, int length) throws IOException {
+ public void write(final byte[] b, final int offsetToWrite, final int length) throws IOException {
baos.write(b, offsetToWrite, length);
this.offset += length;
}
@@ -89,7 +89,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
if (this.offset > 0) {
nextFrame();
}
- } catch (StorageException e) {
+ } catch (final StorageException e) {
throw (IOException) e.getCause();
}
o.writeInt(-1);
@@ -105,13 +105,13 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
return new Accumulator<byte[]>() {
@Override
- public void add(byte[] datum) throws ServiceException {
+ public void add(final byte[] datum) throws ServiceException {
try {
o.writeInt(datum.length);
offset += 4;
o.write(datum);
offset += datum.length;
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
@@ -124,7 +124,7 @@ public class FramingOutputStream extends OutputStream implements Accumulable<byt
offset += 4;
o.close();
fos.closed = true;
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
index f138024..eeb28ec 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleDeserializer.java
@@ -35,14 +35,14 @@ public class FramingTupleDeserializer<K, V> implements
private final Deserializer<K, InputStream> keyDeserializer;
private final Deserializer<V, InputStream> valDeserializer;
- public FramingTupleDeserializer(Deserializer<K, InputStream> keyDeserializer,
- Deserializer<V, InputStream> valDeserializer) {
+ public FramingTupleDeserializer(final Deserializer<K, InputStream> keyDeserializer,
+ final Deserializer<V, InputStream> valDeserializer) {
this.keyDeserializer = keyDeserializer;
this.valDeserializer = valDeserializer;
}
@Override
- public Iterable<Tuple<K, V>> create(InputStream ins) {
+ public Iterable<Tuple<K, V>> create(final InputStream ins) {
final DataInputStream in = new DataInputStream(ins);
final Iterable<K> keyItbl = keyDeserializer.create(in);
final Iterable<V> valItbl = valDeserializer.create(in);
@@ -57,7 +57,7 @@ public class FramingTupleDeserializer<K, V> implements
private int readFrameLength() throws ServiceException {
try {
return in.readInt();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new ServiceRuntimeException(e);
}
}
@@ -75,12 +75,12 @@ public class FramingTupleDeserializer<K, V> implements
if (nextFrameLength == -1) {
throw new NoSuchElementException();
}
- K k = keyIt.next();
+ final K k = keyIt.next();
readFrameLength();
- V v = valIt.next();
+ final V v = valIt.next();
nextFrameLength = readFrameLength();
return new Tuple<>(k, v);
- } catch (ServiceException e) {
+ } catch (final ServiceException e) {
throw new ServiceRuntimeException(e);
}
}
@@ -90,7 +90,7 @@ public class FramingTupleDeserializer<K, V> implements
throw new UnsupportedOperationException();
}
};
- } catch (ServiceException e) {
+ } catch (final ServiceException e) {
throw new ServiceRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
index a494463..a6cd0ad 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/FramingTupleSerializer.java
@@ -58,7 +58,7 @@ public class FramingTupleSerializer<K, V> implements
boolean first = true;
@Override
- public void add(Tuple<K, V> datum) throws ServiceException {
+ public void add(final Tuple<K, V> datum) throws ServiceException {
if (!first) {
faos.nextFrame();
}
@@ -74,7 +74,7 @@ public class FramingTupleSerializer<K, V> implements
keyAccumulator.close();
valAccumulator.close();
faos.close();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new StorageException(e);
}
}
[02/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingEventHandlerTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingEventHandlerTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingEventHandlerTest.java
index 4ff123b..0117e76 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingEventHandlerTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingEventHandlerTest.java
@@ -34,10 +34,10 @@ public class BlockingEventHandlerTest {
final AtomicInteger i = new AtomicInteger(0);
final AtomicInteger cnt = new AtomicInteger(0);
- BlockingEventHandler<Integer> h = new BlockingEventHandler<>(1, new EventHandler<Iterable<Integer>>() {
+ final BlockingEventHandler<Integer> h = new BlockingEventHandler<>(1, new EventHandler<Iterable<Integer>>() {
@Override
- public void onNext(Iterable<Integer> value) {
- for (int x : value) {
+ public void onNext(final Iterable<Integer> value) {
+ for (final int x : value) {
i.getAndAdd(x);
cnt.incrementAndGet();
}
@@ -53,10 +53,10 @@ public class BlockingEventHandlerTest {
final AtomicInteger i = new AtomicInteger(0);
final AtomicInteger cnt = new AtomicInteger(0);
- BlockingEventHandler<Integer> h = new BlockingEventHandler<>(1, new EventHandler<Iterable<Integer>>() {
+ final BlockingEventHandler<Integer> h = new BlockingEventHandler<>(1, new EventHandler<Iterable<Integer>>() {
@Override
- public void onNext(Iterable<Integer> value) {
- for (int x : value) {
+ public void onNext(final Iterable<Integer> value) {
+ for (final int x : value) {
i.getAndAdd(x);
cnt.incrementAndGet();
}
@@ -77,15 +77,15 @@ public class BlockingEventHandlerTest {
final int num = 1000;
final BlockingEventHandler<Integer> h = new BlockingEventHandler<>(2 * num, new EventHandler<Iterable<Integer>>() {
@Override
- public void onNext(Iterable<Integer> value) {
- for (int x : value) {
+ public void onNext(final Iterable<Integer> value) {
+ for (final int x : value) {
i.getAndAdd(x);
cnt.incrementAndGet();
}
}
});
- Runnable r = new Runnable() {
+ final Runnable r = new Runnable() {
@Override
public void run() {
for (int i = 0; i < num; i++) {
@@ -93,14 +93,14 @@ public class BlockingEventHandlerTest {
}
}
};
- Thread a = new Thread(r);
- Thread b = new Thread(r);
+ final Thread a = new Thread(r);
+ final Thread b = new Thread(r);
a.start();
b.start();
try {
a.join();
b.join();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
fail(e.toString());
}
@@ -118,8 +118,8 @@ public class BlockingEventHandlerTest {
final int events = 10;
final BlockingEventHandler<Integer> h = new BlockingEventHandler<>(2 * num, new EventHandler<Iterable<Integer>>() {
@Override
- public void onNext(Iterable<Integer> value) {
- for (int x : value) {
+ public void onNext(final Iterable<Integer> value) {
+ for (final int x : value) {
i.getAndAdd(x);
cnt.incrementAndGet();
}
@@ -127,7 +127,7 @@ public class BlockingEventHandlerTest {
}
});
- Runnable r = new Runnable() {
+ final Runnable r = new Runnable() {
@Override
public void run() {
for (int i = 0; i < num * events; i++) {
@@ -135,14 +135,14 @@ public class BlockingEventHandlerTest {
}
}
};
- Thread a = new Thread(r);
- Thread b = new Thread(r);
+ final Thread a = new Thread(r);
+ final Thread b = new Thread(r);
a.start();
b.start();
try {
a.join();
b.join();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
fail(e.toString());
}
@@ -160,8 +160,8 @@ public class BlockingEventHandlerTest {
final int num = 1000;
final BlockingEventHandler<Integer> h = new BlockingEventHandler<>(num, new EventHandler<Iterable<Integer>>() {
@Override
- public void onNext(Iterable<Integer> value) {
- for (int x : value) {
+ public void onNext(final Iterable<Integer> value) {
+ for (final int x : value) {
i.getAndAdd(x);
cnt.incrementAndGet();
}
@@ -169,25 +169,25 @@ public class BlockingEventHandlerTest {
});
final int val = 7;
- Runnable r = new Runnable() {
+ final Runnable r = new Runnable() {
@Override
public void run() {
h.onNext(val);
}
};
- Thread[] workers = new Thread[num];
+ final Thread[] workers = new Thread[num];
for (int ii = 0; ii < workers.length; ii++) {
workers[ii] = new Thread(r);
}
- for (Thread w : workers) {
+ for (final Thread w : workers) {
w.start();
}
try {
- for (Thread w : workers) {
+ for (final Thread w : workers) {
w.join();
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
fail(e.toString());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingSignalEventHandlerTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingSignalEventHandlerTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingSignalEventHandlerTest.java
index 99f0276..506cef2 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingSignalEventHandlerTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/BlockingSignalEventHandlerTest.java
@@ -33,9 +33,9 @@ public class BlockingSignalEventHandlerTest {
public void testSingle() {
final AtomicInteger cnt = new AtomicInteger(0);
- BlockingSignalEventHandler<Integer> h = new BlockingSignalEventHandler<>(1, new EventHandler<Integer>() {
+ final BlockingSignalEventHandler<Integer> h = new BlockingSignalEventHandler<>(1, new EventHandler<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
cnt.incrementAndGet();
}
});
@@ -47,9 +47,9 @@ public class BlockingSignalEventHandlerTest {
public void testMultiple() {
final AtomicInteger cnt = new AtomicInteger(0);
- BlockingSignalEventHandler<Integer> h = new BlockingSignalEventHandler<>(2, new EventHandler<Integer>() {
+ final BlockingSignalEventHandler<Integer> h = new BlockingSignalEventHandler<>(2, new EventHandler<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
cnt.incrementAndGet();
}
});
@@ -66,12 +66,12 @@ public class BlockingSignalEventHandlerTest {
final BlockingSignalEventHandler<Integer> h =
new BlockingSignalEventHandler<>(2 * num, new EventHandler<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
cnt.incrementAndGet();
}
});
- Runnable r = new Runnable() {
+ final Runnable r = new Runnable() {
@Override
public void run() {
for (int i = 0; i < num; i++) {
@@ -79,14 +79,14 @@ public class BlockingSignalEventHandlerTest {
}
}
};
- Thread a = new Thread(r);
- Thread b = new Thread(r);
+ final Thread a = new Thread(r);
+ final Thread b = new Thread(r);
a.start();
b.start();
try {
a.join();
b.join();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
fail(e.toString());
}
@@ -102,12 +102,12 @@ public class BlockingSignalEventHandlerTest {
final BlockingSignalEventHandler<Integer> h = new BlockingSignalEventHandler<>(2 * num,
new EventHandler<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
cnt.incrementAndGet();
}
});
- Runnable r = new Runnable() {
+ final Runnable r = new Runnable() {
@Override
public void run() {
for (int i = 0; i < num * events; i++) {
@@ -115,14 +115,14 @@ public class BlockingSignalEventHandlerTest {
}
}
};
- Thread a = new Thread(r);
- Thread b = new Thread(r);
+ final Thread a = new Thread(r);
+ final Thread b = new Thread(r);
a.start();
b.start();
try {
a.join();
b.join();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
fail(e.toString());
}
@@ -136,31 +136,31 @@ public class BlockingSignalEventHandlerTest {
final int num = 1000;
final BlockingSignalEventHandler<Integer> h = new BlockingSignalEventHandler<>(num, new EventHandler<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
cnt.incrementAndGet();
}
});
final int val = 7;
- Runnable r = new Runnable() {
+ final Runnable r = new Runnable() {
@Override
public void run() {
h.onNext(val);
}
};
- Thread[] workers = new Thread[num];
+ final Thread[] workers = new Thread[num];
for (int ii = 0; ii < workers.length; ii++) {
workers[ii] = new Thread(r);
}
- for (Thread w : workers) {
+ for (final Thread w : workers) {
w.start();
}
try {
- for (Thread w : workers) {
+ for (final Thread w : workers) {
w.join();
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
fail(e.toString());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ForkPoolStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ForkPoolStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ForkPoolStageTest.java
index 74b8cec..e2e7fe3 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ForkPoolStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ForkPoolStageTest.java
@@ -41,17 +41,17 @@ public class ForkPoolStageTest {
public void testPoolStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
+ final EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
- WakeSharedPool p = new WakeSharedPool(10);
+ final WakeSharedPool p = new WakeSharedPool(10);
- EStage<TestEventA> stage = new ForkPoolStage<TestEventA>(eventHandler, p);
+ final EStage<TestEventA> stage = new ForkPoolStage<TestEventA>(eventHandler, p);
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
+ final TestEventA a = new TestEventA();
orgSet.add(a);
stage.onNext(a);
@@ -71,24 +71,24 @@ public class ForkPoolStageTest {
public void testSharedPoolStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
+ final EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
- WakeSharedPool p = new WakeSharedPool(10);
+ final WakeSharedPool p = new WakeSharedPool(10);
- EStage<TestEventA> stage1 = new ForkPoolStage<TestEventA>(eventHandler, p);
- EStage<TestEventA> stage2 = new ForkPoolStage<TestEventA>(eventHandler, p);
+ final EStage<TestEventA> stage1 = new ForkPoolStage<TestEventA>(eventHandler, p);
+ final EStage<TestEventA> stage2 = new ForkPoolStage<TestEventA>(eventHandler, p);
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
+ final TestEventA a = new TestEventA();
orgSet.add(a);
stage1.onNext(a);
}
for (int i = 10; i < 20; ++i) {
- TestEventA a = new TestEventA();
+ final TestEventA a = new TestEventA();
orgSet.add(a);
stage2.onNext(a);
@@ -109,21 +109,21 @@ public class ForkPoolStageTest {
public void testMultiSharedPoolStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Map<Class<? extends TestEvent>, EventHandler<? extends TestEvent>> map
+ final Map<Class<? extends TestEvent>, EventHandler<? extends TestEvent>> map
= new HashMap<Class<? extends TestEvent>, EventHandler<? extends TestEvent>>();
map.put(TestEventA.class, new TestEventHandlerA(procSet));
map.put(TestEventB.class, new TestEventHandlerB(procSet));
- EventHandler<TestEvent> eventHandler = new MultiEventHandler<TestEvent>(map);
+ final EventHandler<TestEvent> eventHandler = new MultiEventHandler<TestEvent>(map);
- WakeSharedPool p = new WakeSharedPool(10);
- EStage<TestEvent> stage = new ForkPoolStage<TestEvent>(eventHandler, p);
+ final WakeSharedPool p = new WakeSharedPool(10);
+ final EStage<TestEvent> stage = new ForkPoolStage<TestEvent>(eventHandler, p);
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
- TestEventB b = new TestEventB();
+ final TestEventA a = new TestEventA();
+ final TestEventB b = new TestEventB();
orgSet.add(a);
orgSet.add(b);
@@ -144,11 +144,11 @@ public class ForkPoolStageTest {
@Test
public void testMeter() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- WakeSharedPool p = new WakeSharedPool(10);
- EventHandler<TestEvent> eventHandler = new TestEventHandler();
- ForkPoolStage<TestEvent> stage = new ForkPoolStage<TestEvent>(eventHandler, p);
+ final WakeSharedPool p = new WakeSharedPool(10);
+ final EventHandler<TestEvent> eventHandler = new TestEventHandler();
+ final ForkPoolStage<TestEvent> stage = new ForkPoolStage<TestEvent>(eventHandler, p);
- TestEvent e = new TestEvent();
+ final TestEvent e = new TestEvent();
for (int i = 0; i < 1000000; ++i) {
stage.onNext(e);
}
@@ -161,12 +161,12 @@ public class ForkPoolStageTest {
@Test
public void testMeterTwoStages() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- WakeSharedPool p = new WakeSharedPool(10);
- EventHandler<TestEvent> eventHandler = new TestEventHandler();
- ForkPoolStage<TestEvent> stage2 = new ForkPoolStage<TestEvent>(eventHandler, p);
- ForkPoolStage<TestEvent> stage1 = new ForkPoolStage<TestEvent>(stage2, p);
+ final WakeSharedPool p = new WakeSharedPool(10);
+ final EventHandler<TestEvent> eventHandler = new TestEventHandler();
+ final ForkPoolStage<TestEvent> stage2 = new ForkPoolStage<TestEvent>(eventHandler, p);
+ final ForkPoolStage<TestEvent> stage1 = new ForkPoolStage<TestEvent>(stage2, p);
- TestEvent e = new TestEvent();
+ final TestEvent e = new TestEvent();
for (int i = 0; i < 1000000; ++i) {
stage1.onNext(e);
}
@@ -195,7 +195,7 @@ public class ForkPoolStageTest {
TestEventHandler() {
}
- public void onNext(TestEvent e) {
+ public void onNext(final TestEvent e) {
// no op
}
}
@@ -203,11 +203,11 @@ public class ForkPoolStageTest {
class TestEventHandlerA implements EventHandler<TestEventA> {
private final Set<TestEvent> set;
- TestEventHandlerA(Set<TestEvent> set) {
+ TestEventHandlerA(final Set<TestEvent> set) {
this.set = set;
}
- public void onNext(TestEventA e) {
+ public void onNext(final TestEventA e) {
set.add(e);
System.out.println("TestEventHandlerA " + e);
}
@@ -216,11 +216,11 @@ public class ForkPoolStageTest {
class TestEventHandlerB implements EventHandler<TestEventB> {
private final Set<TestEvent> set;
- TestEventHandlerB(Set<TestEvent> set) {
+ TestEventHandlerB(final Set<TestEvent> set) {
this.set = set;
}
- public void onNext(TestEventB e) {
+ public void onNext(final TestEventB e) {
set.add(e);
System.out.println("TestEventHandlerB " + e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/IndependentIterationsThreadPoolStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/IndependentIterationsThreadPoolStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/IndependentIterationsThreadPoolStageTest.java
index 2d4d8bd..77c44f6 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/IndependentIterationsThreadPoolStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/IndependentIterationsThreadPoolStageTest.java
@@ -36,19 +36,19 @@ public class IndependentIterationsThreadPoolStageTest {
public void testOneIteration() {
final AtomicInteger x = new AtomicInteger(0);
final int val = 101;
- IndependentIterationsThreadPoolStage<Integer> dut = new IndependentIterationsThreadPoolStage<>(
+ final IndependentIterationsThreadPoolStage<Integer> dut = new IndependentIterationsThreadPoolStage<>(
new EventHandler<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
x.addAndGet(value);
}
}, 1, 1);
- List<Integer> ll = new ArrayList<>();
+ final List<Integer> ll = new ArrayList<>();
ll.add(val);
dut.onNext(ll);
try {
dut.close();
- } catch (Exception e) {
+ } catch (final Exception e) {
fail(e.toString());
}
assertEquals(val, x.get());
@@ -63,10 +63,10 @@ public class IndependentIterationsThreadPoolStageTest {
ll.add(i);
}
- IndependentIterationsThreadPoolStage<Integer> dut = new IndependentIterationsThreadPoolStage<>(
+ final IndependentIterationsThreadPoolStage<Integer> dut = new IndependentIterationsThreadPoolStage<>(
new EventHandler<Integer>() {
@Override
- public void onNext(Integer value) {
+ public void onNext(final Integer value) {
Logger.getAnonymousLogger().info("Yow" + value);
x.addAndGet(value);
}
@@ -76,7 +76,7 @@ public class IndependentIterationsThreadPoolStageTest {
try {
dut.close();
- } catch (Exception e) {
+ } catch (final Exception e) {
fail(e.toString());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/MetricsTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/MetricsTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/MetricsTest.java
index f996192..e23703d 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/MetricsTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/MetricsTest.java
@@ -37,8 +37,8 @@ public class MetricsTest {
public void testHistogram() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Histogram histogram = new UniformHistogram(10, 100);
- Random rand = new Random(1);
+ final Histogram histogram = new UniformHistogram(10, 100);
+ final Random rand = new Random(1);
for (int i = 0; i < 1000000; ++i) {
long value = rand.nextLong() % 1000;
value = value >= 0 ? value : (-1) * value;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
index 2836811..b401989 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
@@ -45,21 +45,21 @@ public class PubSubThreadPoolStageTest {
public void testPubSubThreadPoolStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 5000, 5000);
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- int expected = 10;
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final int expected = 10;
- PubSubEventHandler<TestEvent> handler = new PubSubEventHandler<TestEvent>();
+ final PubSubEventHandler<TestEvent> handler = new PubSubEventHandler<TestEvent>();
handler.subscribe(TestEvent.class, new TestEventHandler("Handler1", monitor, procSet, expected));
handler.subscribe(TestEvent.class, new TestEventHandler("Handler2", monitor, procSet, expected));
- EStage<TestEvent> stage = new ThreadPoolStage<TestEvent>(handler, 10);
+ final EStage<TestEvent> stage = new ThreadPoolStage<TestEvent>(handler, 10);
for (int i = 0; i < expected; ++i) {
- TestEvent a = new TestEvent("aaa");
+ final TestEvent a = new TestEvent("aaa");
orgSet.add(a);
stage.onNext(a);
@@ -80,7 +80,7 @@ public class PubSubThreadPoolStageTest {
class TestEvent {
private final String msg;
- public TestEvent(String msg) {
+ public TestEvent(final String msg) {
this.msg = msg;
}
@@ -96,7 +96,7 @@ public class PubSubThreadPoolStageTest {
private final Set<TestEvent> set;
private final int expected;
- TestEventHandler(String name, Monitor monitor, Set<TestEvent> set, int expected) {
+ TestEventHandler(final String name, final Monitor monitor, final Set<TestEvent> set, final int expected) {
this.name = name;
this.monitor = monitor;
this.set = set;
@@ -104,7 +104,7 @@ public class PubSubThreadPoolStageTest {
}
@Override
- public void onNext(TestEvent e) {
+ public void onNext(final TestEvent e) {
set.add(e);
System.out.println(name + " " + e + " " + e.getMsg());
if (set.size() == expected) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/StageManagerTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/StageManagerTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/StageManagerTest.java
index dc2a000..4094a1c 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/StageManagerTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/StageManagerTest.java
@@ -40,7 +40,7 @@ public class StageManagerTest {
class TestEventHandler implements EventHandler<Void> {
@Override
- public void onNext(Void value) {
+ public void onNext(final Void value) {
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/SyncStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/SyncStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/SyncStageTest.java
index 552b0ab..a46f6a6 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/SyncStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/SyncStageTest.java
@@ -40,13 +40,13 @@ public class SyncStageTest {
public void testSyncStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- EStage<TestEventA> stage = new SyncStage<TestEventA>(new TestEventHandlerA(procSet));
+ final EStage<TestEventA> stage = new SyncStage<TestEventA>(new TestEventHandlerA(procSet));
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
+ final TestEventA a = new TestEventA();
orgSet.add(a);
stage.onNext(a);
@@ -61,21 +61,21 @@ public class SyncStageTest {
public void testMultiSyncStage() throws Exception {
System.out.println(name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Map<Class<? extends TestEvent>, EventHandler<? extends TestEvent>> map
+ final Map<Class<? extends TestEvent>, EventHandler<? extends TestEvent>> map
= new HashMap<Class<? extends TestEvent>, EventHandler<? extends TestEvent>>();
map.put(TestEventA.class, new TestEventHandlerA(procSet));
map.put(TestEventB.class, new TestEventHandlerB(procSet));
- EventHandler<TestEvent> eventHandler = new MultiEventHandler<TestEvent>(map);
+ final EventHandler<TestEvent> eventHandler = new MultiEventHandler<TestEvent>(map);
- EStage<TestEvent> stage = new SyncStage<TestEvent>(eventHandler);
+ final EStage<TestEvent> stage = new SyncStage<TestEvent>(eventHandler);
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
- TestEventB b = new TestEventB();
+ final TestEventA a = new TestEventA();
+ final TestEventB b = new TestEventB();
orgSet.add(a);
orgSet.add(b);
@@ -103,11 +103,11 @@ public class SyncStageTest {
private final Set<TestEvent> set;
- TestEventHandlerA(Set<TestEvent> set) {
+ TestEventHandlerA(final Set<TestEvent> set) {
this.set = set;
}
- public void onNext(TestEventA e) {
+ public void onNext(final TestEventA e) {
set.add(e);
System.out.println("TestEventHandlerA " + e);
}
@@ -117,11 +117,11 @@ public class SyncStageTest {
private final Set<TestEvent> set;
- TestEventHandlerB(Set<TestEvent> set) {
+ TestEventHandlerB(final Set<TestEvent> set) {
this.set = set;
}
- public void onNext(TestEventB e) {
+ public void onNext(final TestEventB e) {
set.add(e);
System.out.println("TestEventHandlerB " + e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ThreadPoolStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ThreadPoolStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ThreadPoolStageTest.java
index d4a5048..59730ff 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ThreadPoolStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/ThreadPoolStageTest.java
@@ -41,14 +41,14 @@ public class ThreadPoolStageTest {
public void testSingleThreadStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
- EStage<TestEventA> stage = new SingleThreadStage<TestEventA>(eventHandler, 20);
+ final EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
+ final EStage<TestEventA> stage = new SingleThreadStage<TestEventA>(eventHandler, 20);
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
+ final TestEventA a = new TestEventA();
orgSet.add(a);
stage.onNext(a);
@@ -67,12 +67,12 @@ public class ThreadPoolStageTest {
public void testSingleThreadStageQueueFull() {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
final EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
final EStage<TestEventA> stage = new SingleThreadStage<TestEventA>(eventHandler, 1);
for (int i = 0; i < 10000; ++i) {
- TestEventA a = new TestEventA();
+ final TestEventA a = new TestEventA();
stage.onNext(a);
}
@@ -83,15 +83,15 @@ public class ThreadPoolStageTest {
public void testThreadPoolStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
+ final EventHandler<TestEventA> eventHandler = new TestEventHandlerA(procSet);
- EStage<TestEventA> stage = new ThreadPoolStage<TestEventA>(eventHandler, 10);
+ final EStage<TestEventA> stage = new ThreadPoolStage<TestEventA>(eventHandler, 10);
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
+ final TestEventA a = new TestEventA();
orgSet.add(a);
stage.onNext(a);
@@ -110,20 +110,20 @@ public class ThreadPoolStageTest {
public void testMultiThreadPoolStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> procSet = Collections.synchronizedSet(new HashSet<TestEvent>());
+ final Set<TestEvent> orgSet = Collections.synchronizedSet(new HashSet<TestEvent>());
- Map<Class<? extends TestEvent>, EventHandler<? extends TestEvent>> map
+ final Map<Class<? extends TestEvent>, EventHandler<? extends TestEvent>> map
= new HashMap<Class<? extends TestEvent>, EventHandler<? extends TestEvent>>();
map.put(TestEventA.class, new TestEventHandlerA(procSet));
map.put(TestEventB.class, new TestEventHandlerB(procSet));
- EventHandler<TestEvent> eventHandler = new MultiEventHandler<TestEvent>(map);
+ final EventHandler<TestEvent> eventHandler = new MultiEventHandler<TestEvent>(map);
- EStage<TestEvent> stage = new ThreadPoolStage<TestEvent>(eventHandler, 10);
+ final EStage<TestEvent> stage = new ThreadPoolStage<TestEvent>(eventHandler, 10);
for (int i = 0; i < 10; ++i) {
- TestEventA a = new TestEventA();
- TestEventB b = new TestEventB();
+ final TestEventA a = new TestEventA();
+ final TestEventB b = new TestEventB();
orgSet.add(a);
orgSet.add(b);
@@ -143,10 +143,10 @@ public class ThreadPoolStageTest {
@Test
public void testMeter() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- EventHandler<TestEvent> eventHandler = new TestEventHandler();
- ThreadPoolStage<TestEvent> stage = new ThreadPoolStage<TestEvent>(eventHandler, 10);
+ final EventHandler<TestEvent> eventHandler = new TestEventHandler();
+ final ThreadPoolStage<TestEvent> stage = new ThreadPoolStage<TestEvent>(eventHandler, 10);
- TestEvent e = new TestEvent();
+ final TestEvent e = new TestEvent();
for (int i = 0; i < 1000000; ++i) {
stage.onNext(e);
}
@@ -159,11 +159,11 @@ public class ThreadPoolStageTest {
@Test
public void testMeterTwoStages() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- EventHandler<TestEvent> eventHandler = new TestEventHandler();
- ThreadPoolStage<TestEvent> stage2 = new ThreadPoolStage<TestEvent>(eventHandler, 5);
- ThreadPoolStage<TestEvent> stage1 = new ThreadPoolStage<TestEvent>(stage2, 5);
+ final EventHandler<TestEvent> eventHandler = new TestEventHandler();
+ final ThreadPoolStage<TestEvent> stage2 = new ThreadPoolStage<TestEvent>(eventHandler, 5);
+ final ThreadPoolStage<TestEvent> stage1 = new ThreadPoolStage<TestEvent>(stage2, 5);
- TestEvent e = new TestEvent();
+ final TestEvent e = new TestEvent();
for (int i = 0; i < 1000000; ++i) {
stage1.onNext(e);
}
@@ -190,7 +190,7 @@ public class ThreadPoolStageTest {
TestEventHandler() {
}
- public void onNext(TestEvent e) {
+ public void onNext(final TestEvent e) {
// no op
}
}
@@ -198,11 +198,11 @@ public class ThreadPoolStageTest {
class TestEventHandlerA implements EventHandler<TestEventA> {
private final Set<TestEvent> set;
- TestEventHandlerA(Set<TestEvent> set) {
+ TestEventHandlerA(final Set<TestEvent> set) {
this.set = set;
}
- public void onNext(TestEventA e) {
+ public void onNext(final TestEventA e) {
set.add(e);
System.out.println("TestEventHandlerA " + e);
}
@@ -211,11 +211,11 @@ public class ThreadPoolStageTest {
class TestEventHandlerB implements EventHandler<TestEventB> {
private final Set<TestEvent> set;
- TestEventHandlerB(Set<TestEvent> set) {
+ TestEventHandlerB(final Set<TestEvent> set) {
this.set = set;
}
- public void onNext(TestEventB e) {
+ public void onNext(final TestEventB e) {
set.add(e);
System.out.println("TestEventHandlerB " + e);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/TimerStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/TimerStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/TimerStageTest.java
index c25f6e8..5cb73b0 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/TimerStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/TimerStageTest.java
@@ -42,11 +42,11 @@ public class TimerStageTest {
public void testTimerStage() throws Exception {
System.out.println(LOG_PREFIX + name.getMethodName());
- Monitor monitor = new Monitor();
- int expected = 10;
+ final Monitor monitor = new Monitor();
+ final int expected = 10;
- TestEventHandler handler = new TestEventHandler(monitor, expected);
- Stage stage = new TimerStage(handler, 100, SHUTDOWN_TIMEOUT);
+ final TestEventHandler handler = new TestEventHandler(monitor, expected);
+ final Stage stage = new TimerStage(handler, 100, SHUTDOWN_TIMEOUT);
monitor.mwait();
@@ -61,12 +61,12 @@ public class TimerStageTest {
private final int expected;
private AtomicInteger count = new AtomicInteger(0);
- TestEventHandler(Monitor monitor, int expected) {
+ TestEventHandler(final Monitor monitor, final int expected) {
this.monitor = monitor;
this.expected = expected;
}
- public void onNext(PeriodicEvent e) {
+ public void onNext(final PeriodicEvent e) {
count.incrementAndGet();
System.out.println(count.get() + " " + e + " scheduled event at " + System.currentTimeMillis());
if (count.get() == expected) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
index c7b41c1..c21fed6 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
@@ -25,8 +25,8 @@ import java.util.concurrent.atomic.AtomicInteger;
public class SkipListTest {
- public static void main(String[] arg) {
- SkipListTest t = new SkipListTest();
+ public static void main(final String[] arg) {
+ final SkipListTest t = new SkipListTest();
t.testPoll();
t.testHigher();
@@ -43,22 +43,22 @@ public class SkipListTest {
public void testPoll() {
System.out.println("poll");
final int unique = 2000000;
- ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
while (x.pollFirstEntry() != null) {
//
}
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
@@ -69,40 +69,40 @@ public class SkipListTest {
public void testHigher() {
System.out.println("higher");
final int unique = 2000000;
- ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
Integer k = x.pollFirstEntry().getKey();
while ((k = x.higherKey(k)) != null) {
//
}
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
+ " seconds (" + ((double) unique) / (outelapsed * 1000.0 * 1000.0) + " million events/sec)");
}
- public boolean nThreads(int n, Runnable r, long timeout, TimeUnit t) {
- ExecutorService e = Executors.newCachedThreadPool();
+ public boolean nThreads(final int n, final Runnable r, final long timeout, final TimeUnit t) {
+ final ExecutorService e = Executors.newCachedThreadPool();
for (int i = 0; i < n; i++) {
e.submit(r);
}
e.shutdown();
try {
return e.awaitTermination(timeout, t);
- } catch (InterruptedException e1) {
+ } catch (final InterruptedException e1) {
e1.printStackTrace();
return false;
}
@@ -112,26 +112,26 @@ public class SkipListTest {
public void testHigherRemove() {
System.out.println("higher/remove");
final int unique = 2000000;
- ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
Integer k = x.pollFirstEntry().getKey();
x.remove(k);
while ((k = x.higherKey(k)) != null) {
x.remove(k);
}
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
@@ -144,15 +144,15 @@ public class SkipListTest {
System.out.println("higher/remove " + numOutW);
final int unique = 2000000;
final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
Assert.assertTrue(nThreads(numOutW, new Runnable() {
@Override
@@ -164,11 +164,11 @@ public class SkipListTest {
}
}
}, 30, TimeUnit.SECONDS));
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
@@ -181,22 +181,22 @@ public class SkipListTest {
System.out.println("higher/remove seek " + numOutW);
final int unique = 2000000;
final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
final AtomicInteger uid = new AtomicInteger(0);
final int blockSize = unique / numOutW;
Assert.assertTrue(nThreads(numOutW, new Runnable() {
@Override
public void run() {
- int id = uid.getAndIncrement();
+ final int id = uid.getAndIncrement();
final Integer startK = x.ceilingKey(blockSize * id);
Integer k = startK;
x.remove(k);
@@ -205,11 +205,11 @@ public class SkipListTest {
}
}
}, 30, TimeUnit.SECONDS));
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
@@ -223,22 +223,22 @@ public class SkipListTest {
System.out.println("higher/remove seek " + numOutW);
final int unique = 2000000;
final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
final AtomicInteger uid = new AtomicInteger(0);
final int blockSize = unique / numOutW;
Assert.assertTrue(nThreads(numOutW, new Runnable() {
@Override
public void run() {
- int id = uid.getAndIncrement();
+ final int id = uid.getAndIncrement();
final Integer startK = x.ceilingKey(blockSize * id);
final Integer endK = x.ceilingKey(blockSize * (id + 1));
Integer k = startK;
@@ -248,11 +248,11 @@ public class SkipListTest {
} while (k != null && k < endK);
}
}, 30, TimeUnit.SECONDS));
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
@@ -266,23 +266,23 @@ public class SkipListTest {
System.out.println("higher/remove view " + numOutW);
final int unique = 2000000;
final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
final AtomicInteger uid = new AtomicInteger(0);
final int blockSize = unique / numOutW;
Assert.assertTrue(nThreads(numOutW, new Runnable() {
@Override
public void run() {
- int id = uid.getAndIncrement();
- ConcurrentNavigableMap<Integer, Integer> myView = x.tailMap(blockSize * id);
+ final int id = uid.getAndIncrement();
+ final ConcurrentNavigableMap<Integer, Integer> myView = x.tailMap(blockSize * id);
final Integer endK = x.ceilingKey(blockSize * (id + 1));
Integer k = myView.pollFirstEntry().getKey();
do {
@@ -294,11 +294,11 @@ public class SkipListTest {
} while (true);
}
}, 30, TimeUnit.SECONDS));
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
@@ -313,7 +313,7 @@ public class SkipListTest {
System.out.println("separate maps " + numOutW);
final int unique = 2000000 / numOutW;
final ConcurrentSkipListMap<Integer, Integer>[] x = new ConcurrentSkipListMap[numOutW];
- long instart = System.currentTimeMillis();
+ final long instart = System.currentTimeMillis();
{
final AtomicInteger uid = new AtomicInteger(0);
nThreads(numOutW, new Runnable() {
@@ -330,18 +330,18 @@ public class SkipListTest {
}
, 10, TimeUnit.SECONDS);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
final AtomicInteger uid = new AtomicInteger(0);
Assert.assertTrue(nThreads(numOutW, new Runnable() {
@Override
public void run() {
- int id = uid.getAndIncrement();
- ConcurrentSkipListMap<Integer, Integer> mm = x[id];
+ final int id = uid.getAndIncrement();
+ final ConcurrentSkipListMap<Integer, Integer> mm = x[id];
final Integer startK = mm.pollFirstEntry().getKey();
Integer k = startK;
mm.remove(k);
@@ -350,11 +350,11 @@ public class SkipListTest {
}
}
}, 30, TimeUnit.SECONDS));
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
final int total = unique * numOutW;
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + total + " events in " + inelapsed
+ " seconds (" + ((double) total) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + total + " events in " + outelapsed
@@ -368,15 +368,15 @@ public class SkipListTest {
System.out.println("poll " + numOutW);
final int unique = 2000000;
final ConcurrentSkipListMap<Integer, Integer> x = new ConcurrentSkipListMap<>();
- long instart = System.currentTimeMillis();
+ final long instart = System.currentTimeMillis();
for (int i = 0; i < unique; i++) {
x.put(i, i);
}
- long inend = System.currentTimeMillis();
+ final long inend = System.currentTimeMillis();
System.gc();
- long outstart = System.currentTimeMillis();
+ final long outstart = System.currentTimeMillis();
Assert.assertTrue(nThreads(numOutW, new Runnable() {
@Override
@@ -388,11 +388,11 @@ public class SkipListTest {
}
}
}, 30, TimeUnit.SECONDS));
- long outend = System.currentTimeMillis();
+ final long outend = System.currentTimeMillis();
- double inelapsed = ((double) (inend - instart)) / 1000.0;
- double outelapsed = ((double) (outend - outstart)) / 1000.0;
+ final double inelapsed = ((double) (inend - instart)) / 1000.0;
+ final double outelapsed = ((double) (outend - outstart)) / 1000.0;
System.out.println("insert " + unique + " events in " + inelapsed
+ " seconds (" + ((double) unique) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("output " + unique + " events in " + outelapsed
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestBlockingJoin.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestBlockingJoin.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestBlockingJoin.java
index 47b4487..dce77c8 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestBlockingJoin.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestBlockingJoin.java
@@ -28,10 +28,10 @@ import org.junit.Test;
public class TestBlockingJoin {
@Test
public void testJoin() throws Exception {
- EventPrinter<TupleEvent> printer = new EventPrinter<>();
- BlockingJoin join = new BlockingJoin(printer);
- TupleSource left = new TupleSource(join.wireLeft(), 256, 8, true);
- TupleSource right = new TupleSource(join.wireRight(), 256, 8, false);
+ final EventPrinter<TupleEvent> printer = new EventPrinter<>();
+ final BlockingJoin join = new BlockingJoin(printer);
+ final TupleSource left = new TupleSource(join.wireLeft(), 256, 8, true);
+ final TupleSource right = new TupleSource(join.wireRight(), 256, 8, false);
left.close();
right.close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
index 1717521..dc82307 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
@@ -40,11 +40,11 @@ public class TestCombiner {
@Test
public void test() throws Exception {
- CombinerStage<Integer, Integer> stage = new CombinerStage<Integer, Integer>(
+ final CombinerStage<Integer, Integer> stage = new CombinerStage<Integer, Integer>(
new Combiner<Integer, Integer>() {
@Override
- public Integer combine(Integer key, Integer old, Integer cur) {
+ public Integer combine(final Integer key, final Integer old, final Integer cur) {
if (old != null) {
return old.intValue() + cur.intValue();
} else {
@@ -56,20 +56,20 @@ public class TestCombiner {
private AtomicInteger x = new AtomicInteger(0);
@Override
- public void onNext(Entry<Integer, Integer> value) {
+ public void onNext(final Entry<Integer, Integer> value) {
System.out.println(value.getKey() + "=" + value.getValue());
x.incrementAndGet();
try {
if (!done) {
Thread.sleep(10);
}
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
throw new IllegalStateException(e);
}
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
System.err.println("onError called!");
error.printStackTrace();
}
@@ -83,12 +83,12 @@ public class TestCombiner {
o = stage.wireIn();
- WorkerThread[] workers = new WorkerThread[THREAD_COUNT];
+ final WorkerThread[] workers = new WorkerThread[THREAD_COUNT];
for (int i = 0; i < THREAD_COUNT; i++) {
workers[i] = new WorkerThread();
}
- long start = System.currentTimeMillis();
+ final long start = System.currentTimeMillis();
for (int i = 0; i < THREAD_COUNT; i++) {
workers[i].start();
}
@@ -97,15 +97,15 @@ public class TestCombiner {
}
o.onCompleted();
- long inStop = System.currentTimeMillis();
+ final long inStop = System.currentTimeMillis();
done = true;
stage.close();
- long outStop = System.currentTimeMillis();
+ final long outStop = System.currentTimeMillis();
- long eventCount = THREAD_COUNT * EVENTS_PER_THREAD;
- double inelapsed = ((double) (inStop - start)) / 1000.0;
- double inoutelapsed = ((double) (outStop - start)) / 1000.0;
+ final long eventCount = THREAD_COUNT * EVENTS_PER_THREAD;
+ final double inelapsed = ((double) (inStop - start)) / 1000.0;
+ final double inoutelapsed = ((double) (outStop - start)) / 1000.0;
System.out.println("Emitted " + eventCount + " events in " + inelapsed
+ " seconds (" + ((double) eventCount) / (inelapsed * 1000.0 * 1000.0) + " million events/sec)");
System.out.println("Emitted/output " + eventCount + " events in " + inoutelapsed
@@ -116,9 +116,9 @@ public class TestCombiner {
private class WorkerThread extends Thread {
@Override
public void run() {
- Random rand = new Random();
+ final Random rand = new Random();
for (int i = 0; i < EVENTS_PER_THREAD; i++) {
- int r = rand.nextInt(BUCKET_COUNT);
+ final int r = rand.nextInt(BUCKET_COUNT);
o.onNext(new CombinerStage.Pair<Integer, Integer>(r, 1));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestJoin.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestJoin.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestJoin.java
index 29288c1..78a64a2 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestJoin.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestJoin.java
@@ -28,10 +28,10 @@ import org.junit.Test;
public class TestJoin {
@Test
public void testJoin() throws Exception {
- EventPrinter<TupleEvent> printer = new EventPrinter<>();
- NonBlockingJoin join = new NonBlockingJoin(printer);
- TupleSource left = new TupleSource(join.wireLeft(), 256, 8, true);
- TupleSource right = new TupleSource(join.wireRight(), 256, 8, false);
+ final EventPrinter<TupleEvent> printer = new EventPrinter<>();
+ final NonBlockingJoin join = new NonBlockingJoin(printer);
+ final TupleSource left = new TupleSource(join.wireLeft(), 256, 8, true);
+ final TupleSource right = new TupleSource(join.wireRight(), 256, 8, false);
left.close();
right.close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestTupleSource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestTupleSource.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestTupleSource.java
index ecd069c..2193cd2 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestTupleSource.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestTupleSource.java
@@ -27,8 +27,8 @@ import org.junit.Test;
public class TestTupleSource {
@Test
public void testOneThread() throws Exception {
- EventPrinter<TupleEvent> printer = new EventPrinter<>();
- TupleSource source = new TupleSource(printer, 256, 8, true);
+ final EventPrinter<TupleEvent> printer = new EventPrinter<>();
+ final TupleSource source = new TupleSource(printer, 256, 8, true);
source.close();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/LargeMsgTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/LargeMsgTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/LargeMsgTest.java
index 2fc962d..a78e964 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/LargeMsgTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/LargeMsgTest.java
@@ -79,24 +79,24 @@ public class LargeMsgTest {
@Test
public void testLargeWrite() throws Exception {
LoggingUtils.setLoggingLevel(Level.FINE);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 20000, 20000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 20000, 20000);
- long dataSize = VALUES[0].length + VALUES[1].length + VALUES[2].length;
+ final long dataSize = VALUES[0].length + VALUES[1].length + VALUES[2].length;
- EStage<TransportEvent> clientStage = new ThreadPoolStage<>("client1",
+ final EStage<TransportEvent> clientStage = new ThreadPoolStage<>("client1",
new LoggingEventHandler<TransportEvent>(), 1, new LoggingEventHandler<Throwable>());
- EStage<TransportEvent> serverStage = new ThreadPoolStage<>("server@7001",
+ final EStage<TransportEvent> serverStage = new ThreadPoolStage<>("server@7001",
new ServerHandler(monitor, dataSize), 1, new LoggingEventHandler<Throwable>());
final String hostAddress = this.localAddressProvider.getLocalAddress();
- int port = 7001;
- Transport transport = tpFactory.newInstance(hostAddress, port, clientStage, serverStage, 1, 10000);
+ final int port = 7001;
+ final Transport transport = tpFactory.newInstance(hostAddress, port, clientStage, serverStage, 1, 10000);
final Link<byte[]> link = transport.open(new InetSocketAddress(hostAddress, port), new PassThroughEncoder(), null);
- EStage<byte[]> writeSubmitter = new ThreadPoolStage<>("Submitter", new EventHandler<byte[]>() {
+ final EStage<byte[]> writeSubmitter = new ThreadPoolStage<>("Submitter", new EventHandler<byte[]>() {
@Override
- public void onNext(byte[] value) {
+ public void onNext(final byte[] value) {
link.write(value);
}
}, 3, new LoggingEventHandler<Throwable>());
@@ -118,15 +118,15 @@ public class LargeMsgTest {
private final long expectedSize;
private long accSize;
- ServerHandler(Monitor monitor, long expectedSize) {
+ ServerHandler(final Monitor monitor, final long expectedSize) {
this.monitor = monitor;
this.expectedSize = expectedSize;
this.accSize = 0;
}
@Override
- public void onNext(TransportEvent value) {
- byte[] data = value.getData();
+ public void onNext(final TransportEvent value) {
+ final byte[] data = value.getData();
switch (data.length) {
case L_0:
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java
index 0b52ae8..7a004fe 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java
@@ -46,12 +46,12 @@ public class RemoteIdentifierFactoryTest {
public void testRemoteIdentifierFactory() {
System.out.println(LOG_PREFIX + name.getMethodName());
- Map<String, Class<? extends Identifier>> typeToIdMap = new HashMap<String, Class<? extends Identifier>>();
+ final Map<String, Class<? extends Identifier>> typeToIdMap = new HashMap<String, Class<? extends Identifier>>();
typeToIdMap.put("test", TestRemoteIdentifier.class);
- IdentifierFactory factory = new DefaultIdentifierFactory(typeToIdMap);
+ final IdentifierFactory factory = new DefaultIdentifierFactory(typeToIdMap);
- String idName = "test://name";
- Identifier id = factory.getNewInstance(idName);
+ final String idName = "test://name";
+ final Identifier id = factory.getNewInstance(idName);
System.out.println(id.toString());
Assert.assertTrue(id instanceof TestRemoteIdentifier);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
index e81b211..768fccc 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
@@ -71,15 +71,15 @@ public class RemoteManagerTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.INFO);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
- Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
+ final Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
clazzToCodecMap.put(StartEvent.class, new ObjectSerializableCodec<StartEvent>());
clazzToCodecMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>());
clazzToCodecMap.put(TestEvent1.class, new ObjectSerializableCodec<TestEvent1>());
clazzToCodecMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>());
- Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
+ final Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
final String hostAddress = localAddressProvider.getLocalAddress();
@@ -87,16 +87,16 @@ public class RemoteManagerTest {
"name", hostAddress, PORT, codec, new LoggingEventHandler<Throwable>(), false, 3, 10000,
localAddressProvider, RangeTcpPortProvider.Default);
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
Assert.assertTrue(rm.getMyIdentifier().equals(remoteId));
- EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
- EventHandler<TestEvent1> proxyHandler1 = rm.getHandler(remoteId, TestEvent1.class);
- EventHandler<TestEvent2> proxyHandler2 = rm.getHandler(remoteId, TestEvent2.class);
+ final EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
+ final EventHandler<TestEvent1> proxyHandler1 = rm.getHandler(remoteId, TestEvent1.class);
+ final EventHandler<TestEvent2> proxyHandler2 = rm.getHandler(remoteId, TestEvent2.class);
- AtomicInteger counter = new AtomicInteger(0);
- int finalSize = 2;
+ final AtomicInteger counter = new AtomicInteger(0);
+ final int finalSize = 2;
rm.registerHandler(StartEvent.class, new MessageTypeEventHandler<StartEvent>(rm, monitor, counter, finalSize));
proxyConnection.onNext(new StartEvent());
@@ -115,19 +115,19 @@ public class RemoteManagerTest {
@Test
public void testRemoteManagerConnectionRetryTest() throws Exception {
- ExecutorService smExecutor = Executors.newFixedThreadPool(1);
- ExecutorService rmExecutor = Executors.newFixedThreadPool(1);
+ final ExecutorService smExecutor = Executors.newFixedThreadPool(1);
+ final ExecutorService rmExecutor = Executors.newFixedThreadPool(1);
- RemoteManager sendingManager = getTestRemoteManager("sender", 9020, 3, 2000);
+ final RemoteManager sendingManager = getTestRemoteManager("sender", 9020, 3, 2000);
- Future<Integer> smFuture = smExecutor.submit(new SendingRemoteManagerThread(sendingManager, 9010, 20000));
+ final Future<Integer> smFuture = smExecutor.submit(new SendingRemoteManagerThread(sendingManager, 9010, 20000));
Thread.sleep(1000);
- RemoteManager receivingManager = getTestRemoteManager("receiver", 9010, 1, 2000);
- Future<Integer> rmFuture = rmExecutor.submit(new ReceivingRemoteManagerThread(receivingManager, 20000, 1, 2));
+ final RemoteManager receivingManager = getTestRemoteManager("receiver", 9010, 1, 2000);
+ final Future<Integer> rmFuture = rmExecutor.submit(new ReceivingRemoteManagerThread(receivingManager, 20000, 1, 2));
- int smCnt = smFuture.get();
- int rmCnt = rmFuture.get();
+ final int smCnt = smFuture.get();
+ final int rmCnt = rmFuture.get();
receivingManager.close();
sendingManager.close();
@@ -138,12 +138,12 @@ public class RemoteManagerTest {
@Test
public void testRemoteManagerConnectionRetryWithMultipleSenderTest() throws Exception {
- int numOfSenderThreads = 5;
- ExecutorService smExecutor = Executors.newFixedThreadPool(numOfSenderThreads);
- ExecutorService rmExecutor = Executors.newFixedThreadPool(1);
- ArrayList<Future<Integer>> smFutures = new ArrayList<Future<Integer>>(numOfSenderThreads);
+ final int numOfSenderThreads = 5;
+ final ExecutorService smExecutor = Executors.newFixedThreadPool(numOfSenderThreads);
+ final ExecutorService rmExecutor = Executors.newFixedThreadPool(1);
+ final ArrayList<Future<Integer>> smFutures = new ArrayList<Future<Integer>>(numOfSenderThreads);
- RemoteManager sendingManager = getTestRemoteManager("sender", 9030, 3, 5000);
+ final RemoteManager sendingManager = getTestRemoteManager("sender", 9030, 3, 5000);
for (int i = 0; i < numOfSenderThreads; i++) {
smFutures.add(smExecutor.submit(new SendingRemoteManagerThread(sendingManager, 9010, 20000)));
@@ -151,17 +151,17 @@ public class RemoteManagerTest {
Thread.sleep(2000);
- RemoteManager receivingManager = getTestRemoteManager("receiver", 9010, 1, 2000);
- Future<Integer> receivingFuture =
+ final RemoteManager receivingManager = getTestRemoteManager("receiver", 9010, 1, 2000);
+ final Future<Integer> receivingFuture =
rmExecutor.submit(new ReceivingRemoteManagerThread(receivingManager, 20000, numOfSenderThreads, 2));
// waiting sending remote manager.
- for (Future<Integer> future : smFutures) {
+ for (final Future<Integer> future : smFutures) {
future.get();
}
// waiting receiving remote manager
- int rmCnt = receivingFuture.get();
+ final int rmCnt = receivingFuture.get();
sendingManager.close();
receivingManager.close();
@@ -175,15 +175,15 @@ public class RemoteManagerTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.INFO);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
- Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
+ final Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
clazzToCodecMap.put(StartEvent.class, new ObjectSerializableCodec<StartEvent>());
clazzToCodecMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>());
clazzToCodecMap.put(TestEvent1.class, new ObjectSerializableCodec<TestEvent1>());
clazzToCodecMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent2>());
- Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
+ final Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
final String hostAddress = localAddressProvider.getLocalAddress();
@@ -191,15 +191,15 @@ public class RemoteManagerTest {
"name", hostAddress, PORT, codec, new LoggingEventHandler<Throwable>(), true, 3, 10000,
localAddressProvider, RangeTcpPortProvider.Default);
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
- EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
- EventHandler<TestEvent1> proxyHandler1 = rm.getHandler(remoteId, TestEvent1.class);
- EventHandler<TestEvent2> proxyHandler2 = rm.getHandler(remoteId, TestEvent2.class);
+ final EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
+ final EventHandler<TestEvent1> proxyHandler1 = rm.getHandler(remoteId, TestEvent1.class);
+ final EventHandler<TestEvent2> proxyHandler2 = rm.getHandler(remoteId, TestEvent2.class);
- AtomicInteger counter = new AtomicInteger(0);
- int finalSize = 2;
+ final AtomicInteger counter = new AtomicInteger(0);
+ final int finalSize = 2;
rm.registerHandler(StartEvent.class, new MessageTypeEventHandler<StartEvent>(rm, monitor, counter, finalSize));
proxyConnection.onNext(new StartEvent());
@@ -222,26 +222,26 @@ public class RemoteManagerTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.INFO);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
- Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
+ final Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
clazzToCodecMap.put(TestEvent.class, new TestEventCodec());
- Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
+ final Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
- String hostAddress = localAddressProvider.getLocalAddress();
+ final String hostAddress = localAddressProvider.getLocalAddress();
final RemoteManager rm = this.remoteManagerFactory.getInstance(
"name", hostAddress, PORT, codec, new LoggingEventHandler<Throwable>(), false, 3, 10000,
localAddressProvider, RangeTcpPortProvider.Default);
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
- EventHandler<TestEvent> proxyHandler = rm.getHandler(remoteId, TestEvent.class);
+ final EventHandler<TestEvent> proxyHandler = rm.getHandler(remoteId, TestEvent.class);
- AtomicInteger counter = new AtomicInteger(0);
- int finalSize = 0;
+ final AtomicInteger counter = new AtomicInteger(0);
+ final int finalSize = 0;
rm.registerHandler(TestEvent.class, new MessageTypeEventHandler<TestEvent>(rm, monitor, counter, finalSize));
proxyHandler.onNext(new TestEvent("hello", 0.0));
@@ -259,44 +259,45 @@ public class RemoteManagerTest {
System.out.println(LOG_PREFIX + name.getMethodName());
LoggingUtils.setLoggingLevel(Level.INFO);
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), 2000, 2000);
- Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
+ final Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
clazzToCodecMap.put(StartEvent.class, new ObjectSerializableCodec<StartEvent>());
clazzToCodecMap.put(TestEvent.class, new ObjectSerializableCodec<TestEvent>());
- Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
+ final Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
final String hostAddress = localAddressProvider.getLocalAddress();
- ExceptionHandler errorHandler = new ExceptionHandler(monitor);
+ final ExceptionHandler errorHandler = new ExceptionHandler(monitor);
try (final RemoteManager rm = remoteManagerFactory.getInstance("name", PORT, codec, errorHandler)) {
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT);
- EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
+ final EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
rm.registerHandler(StartEvent.class, new ExceptionGenEventHandler<StartEvent>("recvExceptionGen"));
proxyConnection.onNext(new StartEvent());
monitor.mwait();
timer.close();
- } catch (UnknownHostException e) {
+ } catch (final UnknownHostException e) {
e.printStackTrace();
- } catch (Exception e) {
+ } catch (final Exception e) {
e.printStackTrace();
}
}
- private RemoteManager getTestRemoteManager(String rmName, int localPort, int retry, int retryTimeout) {
- Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
+ private RemoteManager getTestRemoteManager(final String rmName, final int localPort,
+ final int retry, final int retryTimeout) {
+ final Map<Class<?>, Codec<?>> clazzToCodecMap = new HashMap<Class<?>, Codec<?>>();
clazzToCodecMap.put(StartEvent.class, new ObjectSerializableCodec<StartEvent>());
clazzToCodecMap.put(TestEvent1.class, new ObjectSerializableCodec<TestEvent1>());
clazzToCodecMap.put(TestEvent2.class, new ObjectSerializableCodec<TestEvent1>());
- Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
+ final Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
- String hostAddress = localAddressProvider.getLocalAddress();
+ final String hostAddress = localAddressProvider.getLocalAddress();
return remoteManagerFactory.getInstance(rmName, hostAddress, localPort,
codec, new LoggingEventHandler<Throwable>(), false, retry, retryTimeout,
localAddressProvider, RangeTcpPortProvider.Default);
@@ -308,7 +309,7 @@ public class RemoteManagerTest {
private final int timeout;
private RemoteManager rm;
- public SendingRemoteManagerThread(RemoteManager rm, int remotePort, int timeout) {
+ public SendingRemoteManagerThread(final RemoteManager rm, final int remotePort, final int timeout) {
this.remotePort = remotePort;
this.timeout = timeout;
this.rm = rm;
@@ -317,19 +318,19 @@ public class RemoteManagerTest {
@Override
public Integer call() throws Exception {
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), timeout, timeout);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), timeout, timeout);
final String hostAddress = localAddressProvider.getLocalAddress();
- RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
- RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + remotePort);
+ final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation();
+ final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + remotePort);
- EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
- EventHandler<TestEvent1> proxyHandler1 = rm.getHandler(remoteId, TestEvent1.class);
- EventHandler<TestEvent2> proxyHandler2 = rm.getHandler(remoteId, TestEvent2.class);
+ final EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
+ final EventHandler<TestEvent1> proxyHandler1 = rm.getHandler(remoteId, TestEvent1.class);
+ final EventHandler<TestEvent2> proxyHandler2 = rm.getHandler(remoteId, TestEvent2.class);
- AtomicInteger counter = new AtomicInteger(0);
- int finalSize = 0;
+ final AtomicInteger counter = new AtomicInteger(0);
+ final int finalSize = 0;
rm.registerHandler(StartEvent.class, new MessageTypeEventHandler<StartEvent>(rm, monitor, counter, finalSize));
proxyConnection.onNext(new StartEvent());
@@ -351,7 +352,8 @@ public class RemoteManagerTest {
private final int numOfEvent;
private RemoteManager rm;
- public ReceivingRemoteManagerThread(RemoteManager rm, int timeout, int numOfConnection, int numOfEvent) {
+ public ReceivingRemoteManagerThread(final RemoteManager rm, final int timeout,
+ final int numOfConnection, final int numOfEvent) {
this.rm = rm;
this.timeout = timeout;
this.numOfConnection = numOfConnection;
@@ -361,11 +363,11 @@ public class RemoteManagerTest {
@Override
public Integer call() throws Exception {
- Monitor monitor = new Monitor();
- TimerStage timer = new TimerStage(new TimeoutHandler(monitor), timeout, timeout);
+ final Monitor monitor = new Monitor();
+ final TimerStage timer = new TimerStage(new TimeoutHandler(monitor), timeout, timeout);
- AtomicInteger counter = new AtomicInteger(0);
- int finalSize = numOfConnection * numOfEvent;
+ final AtomicInteger counter = new AtomicInteger(0);
+ final int finalSize = numOfConnection * numOfEvent;
rm.registerHandler(StartEvent.class, new MessageTypeEventHandler<StartEvent>(rm, monitor, counter, finalSize));
for (int i = 0; i < numOfConnection; i++) {
@@ -384,7 +386,8 @@ public class RemoteManagerTest {
private final AtomicInteger counter;
private final int finalSize;
- MessageTypeEventHandler(RemoteManager rm, Monitor monitor, AtomicInteger counter, int finalSize) {
+ MessageTypeEventHandler(final RemoteManager rm, final Monitor monitor,
+ final AtomicInteger counter, final int finalSize) {
this.rm = rm;
this.monitor = monitor;
this.counter = counter;
@@ -392,10 +395,10 @@ public class RemoteManagerTest {
}
@Override
- public void onNext(RemoteMessage<T> value) {
+ public void onNext(final RemoteMessage<T> value) {
- RemoteIdentifier id = value.getIdentifier();
- T message = value.getMessage();
+ final RemoteIdentifier id = value.getIdentifier();
+ final T message = value.getMessage();
System.out.println(this.getClass() + " " + value + " " + id.toString() + " " + message.toString());
@@ -423,7 +426,7 @@ public class RemoteManagerTest {
private final AtomicInteger counter;
private final int finalSize;
- ConsoleEventHandler(String name, Monitor monitor, AtomicInteger counter, int finalSize) {
+ ConsoleEventHandler(final String name, final Monitor monitor, final AtomicInteger counter, final int finalSize) {
this.name = name;
this.monitor = monitor;
this.counter = counter;
@@ -431,7 +434,7 @@ public class RemoteManagerTest {
}
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
System.out.println(this.getClass() + " " + name + " " + value);
if (counter.incrementAndGet() == finalSize) {
System.out.println(this.getClass() + " notify counter: " + counter.get());
@@ -449,7 +452,7 @@ public class RemoteManagerTest {
}
@Override
- public void onNext(RemoteMessage<T> value) {
+ public void onNext(final RemoteMessage<T> value) {
System.out.println(name + " " + value);
throw new TestRuntimeException("Test exception");
}
@@ -464,7 +467,7 @@ public class RemoteManagerTest {
}
@Override
- public void onNext(Throwable value) {
+ public void onNext(final Throwable value) {
System.out.println("!!! ExceptionHandler called : " + value);
monitor.mnotify();
}
[12/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
Posted by ch...@apache.org.
[REEF-513] Add FinalParameters to checkstyle
This addressed the issue by
* Adding FinalParameters to checkstyle.xml.
* Fixing checkstyle violations.
JIRA:
[REEF-513](https://issues.apache.org/jira/browse/REEF-513)
Pull Request:
This closes #317
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/141c7fa0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/141c7fa0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/141c7fa0
Branch: refs/heads/master
Commit: 141c7fa08cbcaf4930f6456d13297ef89ebd7b94
Parents: e5aef16
Author: Andrew Chung <af...@gmail.com>
Authored: Mon Jul 27 16:07:19 2015 -0700
Committer: Brian Cho <ch...@apache.org>
Committed: Tue Jul 28 13:56:39 2015 +0900
----------------------------------------------------------------------
.../apache/reef/bridge/client/LocalClient.java | 12 +-
.../bridge/client/YarnJobSubmissionClient.java | 8 +-
.../javabridge/AllocatedEvaluatorBridge.java | 19 +-
.../reef/javabridge/ClosedContextBridge.java | 2 +-
.../javabridge/CompletedEvaluatorBridge.java | 2 +-
.../reef/javabridge/ContextMessageBridge.java | 2 +-
.../reef/javabridge/FailedContextBridge.java | 2 +-
.../reef/javabridge/FailedEvaluatorBridge.java | 6 +-
.../apache/reef/javabridge/InteropLogger.java | 4 +-
.../reef/javabridge/InteropReturnInfo.java | 4 +-
.../org/apache/reef/javabridge/JavaBridge.java | 2 +-
.../org/apache/reef/javabridge/LibLoader.java | 2 +-
.../apache/reef/javabridge/NativeBridge.java | 2 +-
.../apache/reef/javabridge/NativeInterop.java | 90 +++----
.../reef/javabridge/TaskMessageBridge.java | 2 +-
.../org/apache/reef/javabridge/Utilities.java | 6 +-
.../reef/javabridge/generic/JobClient.java | 14 +-
.../reef/javabridge/generic/JobDriver.java | 40 +--
.../apache/reef/javabridge/generic/Launch.java | 2 +-
.../reef/javabridge/generic/LaunchHeadless.java | 2 +-
.../util/logging/CLRBufferedLogHandler.java | 4 +-
.../reef/io/checkpoint/fs/FSCheckpointID.java | 8 +-
.../io/checkpoint/fs/FSCheckpointService.java | 8 +-
.../io/WorkingDirectoryTempFileCreator.java | 2 +-
.../reef/runtime/common/REEFLauncher.java | 8 +-
.../common/client/JobStatusMessageHandler.java | 2 +-
.../runtime/common/client/RunningJobsImpl.java | 3 +-
.../resourcemanager/NodeDescriptorHandler.java | 2 +-
.../resourcemanager/ResourceManagerStatus.java | 2 +-
.../resourcemanager/ResourceStatusHandler.java | 2 +-
.../common/evaluator/EvaluatorRuntime.java | 2 +-
.../common/launch/CLRLaunchCommandBuilder.java | 2 +-
.../org/apache/reef/util/EnvironmentUtils.java | 7 +-
.../java/org/apache/reef/util/REEFVersion.java | 2 +-
.../org/apache/reef/util/logging/LogParser.java | 12 +-
.../src/main/resources/checkstyle.xml | 1 +
.../org/apache/reef/util/DeadlockInfoTest.java | 8 +-
.../apache/reef/examples/helloCLR/HelloCLR.java | 2 +-
.../bgd/loss/SquaredErrorLossFunction.java | 4 +-
.../bgd/loss/WeightedLogisticLossFunction.java | 4 +-
.../examples/group/utils/math/VectorCodec.java | 16 +-
.../reef/examples/group/utils/math/Window.java | 15 +-
.../reef/examples/hello/HelloReefYarnTcp.java | 6 +-
.../hellohttp/HttpServerShellCmdtHandler.java | 2 +-
.../apache/reef/examples/library/ShellTask.java | 2 +-
.../reef/examples/scheduler/Scheduler.java | 2 +-
.../examples/scheduler/SchedulerDriver.java | 8 +-
.../scheduler/SchedulerHttpHandler.java | 4 +-
.../reef/examples/scheduler/SchedulerREEF.java | 2 +-
.../examples/scheduler/SchedulerREEFYarn.java | 2 +-
.../reef/examples/scheduler/TaskEntity.java | 4 +-
.../examples/suspend/ObjectWritableCodec.java | 4 +-
.../reef/examples/suspend/SuspendTestTask.java | 2 +-
.../utils/wake/LoggingEventHandler.java | 2 +-
.../impl/InMemoryInputFormatDataSet.java | 2 +-
...iDataCenterEvaluatorToPartitionStrategy.java | 15 +-
.../data/loading/impl/WritableSerializer.java | 20 +-
.../io/network/NetworkConnectionService.java | 3 +-
.../exception/NetworkRuntimeException.java | 6 +-
.../group/impl/driver/GroupCommDriverImpl.java | 2 +-
.../group/impl/operators/BroadcastReceiver.java | 2 +-
.../network/group/impl/task/NodeStructImpl.java | 2 +-
.../impl/task/OperatorTopologyStructImpl.java | 2 +-
.../reef/io/network/impl/NSConnection.java | 2 +-
.../reef/io/network/impl/NSMessageCodec.java | 2 +-
.../reef/io/network/impl/NetworkConnection.java | 2 +-
.../impl/NetworkConnectionServiceImpl.java | 4 +-
.../impl/NetworkConnectionServiceMessage.java | 4 +-
.../reef/io/network/impl/NetworkService.java | 2 +-
.../impl/NetworkServiceClosingHandler.java | 4 +-
.../io/network/naming/NameAssignmentTuple.java | 2 +-
.../reef/io/network/naming/NameCache.java | 8 +-
.../reef/io/network/naming/NameClient.java | 8 +-
.../io/network/naming/NameRegistryClient.java | 16 +-
.../reef/io/network/naming/NameServerImpl.java | 4 +-
.../io/network/naming/NamingCodecFactory.java | 18 +-
.../naming/exception/NamingException.java | 6 +-
.../exception/NamingRuntimeException.java | 6 +-
.../network/naming/serialization/AvroUtils.java | 2 +-
.../serialization/NamingLookupRequest.java | 2 +-
.../serialization/NamingLookupResponse.java | 2 +-
.../NamingLookupResponseCodec.java | 2 +-
.../naming/serialization/NamingMessage.java | 2 +-
.../serialization/NamingRegisterRequest.java | 2 +-
.../NamingRegisterRequestCodec.java | 6 +-
.../serialization/NamingRegisterResponse.java | 2 +-
.../NamingRegisterResponseCodec.java | 6 +-
.../serialization/NamingUnregisterRequest.java | 2 +-
.../NamingUnregisterRequestCodec.java | 4 +-
.../reef/io/network/util/StringCodec.java | 4 +-
.../reef/io/network/util/StringIdentifier.java | 6 +-
.../network/util/StringIdentifierFactory.java | 2 +-
.../reef/io/storage/FramingInputStream.java | 12 +-
.../reef/io/storage/FramingOutputStream.java | 18 +-
.../io/storage/FramingTupleDeserializer.java | 16 +-
.../reef/io/storage/FramingTupleSerializer.java | 4 +-
.../apache/reef/io/storage/MergingIterator.java | 8 +-
.../io/storage/local/LocalScratchSpace.java | 10 +-
.../io/storage/local/LocalStorageService.java | 2 +-
.../io/storage/local/SerializerFileSpool.java | 2 +-
.../apache/reef/io/storage/ram/CodecRamMap.java | 4 +-
.../org/apache/reef/io/storage/ram/RamMap.java | 14 +-
.../apache/reef/io/storage/ram/RamSpool.java | 4 +-
.../reef/io/storage/ram/SortingRamSpool.java | 8 +-
.../reef/io/storage/util/GetAllIterable.java | 6 +-
.../reef/io/storage/util/IntegerCodec.java | 4 +-
.../io/storage/util/IntegerDeserializer.java | 4 +-
.../reef/io/storage/util/IntegerSerializer.java | 8 +-
.../io/storage/util/StringDeserializer.java | 6 +-
.../reef/io/storage/util/StringSerializer.java | 10 +-
.../io/storage/util/TupleKeyComparator.java | 4 +-
.../reef/services/network/NameClientTest.java | 10 +-
.../reef/services/network/NamingTest.java | 6 +-
.../network/NetworkConnectionServiceTest.java | 29 +--
.../services/network/NetworkServiceTest.java | 104 ++++----
.../apache/reef/services/network/TestEvent.java | 2 +-
.../services/network/util/LoggingUtils.java | 6 +-
.../util/NetworkMessagingTestService.java | 6 +-
.../network/util/StreamingIntegerCodec.java | 12 +-
.../network/util/StreamingStringCodec.java | 12 +-
.../reef/services/network/util/StringCodec.java | 4 +-
.../services/network/util/TimeoutHandler.java | 4 +-
.../reef/services/storage/ExternalMapTest.java | 24 +-
.../reef/services/storage/FramingTest.java | 38 +--
.../services/storage/MergingIteratorTest.java | 2 +-
.../reef/services/storage/SortingSpoolTest.java | 42 ++--
.../reef/services/storage/SpoolFileTest.java | 38 +--
.../services/storage/TupleSerializerTest.java | 12 +-
.../client/sslhacks/UnsafeHostNameVerifier.java | 8 +-
.../client/yarnrest/AmContainerSpec.java | 6 +-
.../client/yarnrest/ApplicationID.java | 6 +-
.../client/yarnrest/ApplicationResponse.java | 6 +-
.../client/yarnrest/ApplicationState.java | 50 ++--
.../client/yarnrest/ApplicationSubmission.java | 28 +--
.../hdinsight/client/yarnrest/Commands.java | 6 +-
.../hdinsight/client/yarnrest/Credentials.java | 10 +-
.../yarnrest/ListApplicationResponse.java | 6 +-
.../client/yarnrest/LocalResource.java | 6 +-
.../client/yarnrest/LocalResourcesEntry.java | 6 +-
.../hdinsight/client/yarnrest/Resource.java | 6 +-
.../hdinsight/client/yarnrest/StringEntry.java | 6 +-
.../TestHDInsightRESTJsonSerialization.java | 64 ++---
.../client/PreparedDriverFolderLauncher.java | 3 +-
.../local/driver/ResourceManagerTest.java | 2 +-
.../mesos/client/MesosJobSubmissionHandler.java | 2 +-
.../driver/MesosResourceLaunchHandler.java | 2 +-
.../runtime/mesos/driver/REEFScheduler.java | 6 +-
.../yarn/client/YarnJobSubmissionHandler.java | 4 +-
.../yarn/client/uploader/JobUploader.java | 2 +-
.../yarn/driver/EvaluatorSetupHelper.java | 2 +-
.../runtime/yarn/driver/GlobalJarUploader.java | 2 +-
.../JobSubmissionDirectoryProviderImpl.java | 2 +-
.../yarn/driver/YarnContainerManager.java | 4 +-
.../org/apache/reef/tang/InjectionFuture.java | 12 +-
.../org/apache/reef/tang/examples/Timer.java | 18 +-
.../org/apache/reef/tang/examples/TimerV1.java | 16 +-
.../reef/tang/examples/timer/TimerImpl.java | 2 +-
.../reef/tang/examples/timer/TimerMock.java | 8 +-
.../reef/tang/exceptions/BindException.java | 4 +-
.../exceptions/ClassHierarchyException.java | 6 +-
.../tang/exceptions/InjectionException.java | 4 +-
.../exceptions/NameResolutionException.java | 2 +-
.../reef/tang/exceptions/ParseException.java | 4 +-
.../formats/AvroConfigurationSerializer.java | 2 +-
.../apache/reef/tang/formats/CommandLine.java | 2 +-
.../reef/tang/formats/ConfigurationFile.java | 48 ++--
.../reef/tang/formats/ConfigurationModule.java | 84 +++----
.../formats/ConfigurationModuleBuilder.java | 141 +++++------
.../reef/tang/formats/ParameterParser.java | 30 +--
.../ConfigurationBuilderImpl.java | 108 ++++----
.../tang/implementation/ConfigurationImpl.java | 6 +-
.../implementation/InjectionFuturePlan.java | 2 +-
.../reef/tang/implementation/InjectionPlan.java | 10 +-
.../tang/implementation/ListInjectionPlan.java | 16 +-
.../tang/implementation/SetInjectionPlan.java | 16 +-
.../tang/implementation/StackBindLocation.java | 6 +-
.../reef/tang/implementation/Subplan.java | 22 +-
.../reef/tang/implementation/TangImpl.java | 41 ++--
.../implementation/avro/AvroClassHierarchy.java | 8 +-
.../avro/AvroClassHierarchySerializer.java | 2 +-
.../implementation/java/ClassHierarchyImpl.java | 113 +++++----
.../tang/implementation/java/InjectorImpl.java | 203 ++++++++-------
.../java/JavaConfigurationBuilderImpl.java | 44 ++--
.../tang/implementation/java/JavaInstance.java | 2 +-
.../implementation/java/JavaNodeFactory.java | 69 +++---
.../protobuf/ProtocolBufferClassHierarchy.java | 157 ++++++------
.../protobuf/ProtocolBufferInjectionPlan.java | 33 +--
.../tang/implementation/types/AbstractNode.java | 20 +-
.../implementation/types/ClassNodeImpl.java | 28 +--
.../types/ConstructorArgImpl.java | 6 +-
.../types/ConstructorDefImpl.java | 22 +-
.../types/NamedParameterNodeImpl.java | 9 +-
.../implementation/types/PackageNodeImpl.java | 4 +-
.../tang/util/AbstractMonotonicMultiMap.java | 44 ++--
.../apache/reef/tang/util/MonotonicHashMap.java | 12 +-
.../apache/reef/tang/util/MonotonicHashSet.java | 20 +-
.../org/apache/reef/tang/util/MonotonicSet.java | 20 +-
.../apache/reef/tang/util/MonotonicTreeMap.java | 10 +-
.../reef/tang/util/ReflectionUtilities.java | 87 +++----
.../java/org/apache/reef/tang/util/Tint.java | 227 ++++++++---------
.../reef/tang/util/TracingMonotonicTreeMap.java | 22 +-
.../reef/tang/util/ValidateConfiguration.java | 26 +-
.../walk/graphviz/GraphvizConfigVisitor.java | 4 +-
.../tang/ClassHierarchyDeserializationTest.java | 4 +-
.../org/apache/reef/tang/TestBindSingleton.java | 76 +++---
.../org/apache/reef/tang/TestClassLoaders.java | 28 +--
.../apache/reef/tang/TestConfFileParser.java | 24 +-
.../reef/tang/TestImplicitConversions.java | 36 +--
.../apache/reef/tang/TestInjectionFuture.java | 60 +++--
.../org/apache/reef/tang/TestListInjection.java | 111 +++++----
.../reef/tang/TestNamedParameterRoundTrip.java | 2 +-
.../org/apache/reef/tang/TestSetInjection.java | 64 ++---
.../java/org/apache/reef/tang/TestTang.java | 246 +++++++++----------
.../org/apache/reef/tang/TestTweetExample.java | 8 +-
...urationSerializerByteArrayRoundtripTest.java | 5 +-
...onfigurationSerializerFileRoundtripTest.java | 5 +-
...gurationSerializerTextFileRoundtripTest.java | 5 +-
.../tang/formats/TestConfigurationModule.java | 67 +++--
.../tang/implementation/TestClassHierarchy.java | 54 ++--
.../avro/TestClassHierarchyRoundTrip.java | 8 +-
.../java/TestConfigurationBuilder.java | 2 +-
.../java/TestParameterParser.java | 54 ++--
.../tang/test/AnInterfaceImplementation.java | 4 +-
.../apache/reef/tang/test/CyclicDependency.java | 4 +-
.../tang/test/CyclicDependencyClassOne.java | 4 +-
.../tang/test/CyclicDependencyClassTwo.java | 4 +-
.../apache/reef/tang/test/InjectableClass.java | 4 +-
.../reef/tang/test/ListInterfaceImplOne.java | 4 +-
.../reef/tang/test/ListInterfaceImplTwo.java | 6 +-
.../apache/reef/tang/test/ListOfBaseTypes.java | 4 +-
.../reef/tang/test/ListOfImplementations.java | 4 +-
.../reef/tang/test/RootImplementation.java | 10 +-
.../test/RootImplementationWithoutList.java | 10 +-
.../reef/tang/test/SetInterfaceImplOne.java | 4 +-
.../reef/tang/test/SetInterfaceImplTwo.java | 6 +-
.../apache/reef/tang/test/SetOfBaseTypes.java | 4 +-
.../reef/tang/test/SetOfImplementations.java | 4 +-
.../org/apache/reef/tang/test/UnitClass.java | 12 +-
.../EvaluatorReuseTestDriver.java | 2 +-
.../apache/reef/tests/fail/driver/NoopTask.java | 2 +-
.../driver/OnDriverStartedAllocateOne.java | 2 +-
.../exceptions/ExpectedTaskException.java | 8 +-
.../reef/tests/library/tasks/EchoTask.java | 2 +-
.../reef/tests/library/tasks/NoopTask.java | 2 +-
.../tests/messaging/task/TaskMessagingTask.java | 2 +-
.../tests/statepassing/StatePassingTask.java | 2 +-
.../java/org/apache/reef/tests/TestUtils.java | 7 +-
.../ConfigurationProviderTestDriver.java | 2 +-
.../EvaluatorFailureDuringAlarmDriver.java | 2 +-
.../FailureSchedulingContextStartHandler.java | 2 +-
.../reef/tests/files/FileResourceTestTask.java | 2 +-
.../ActiveContextHandler.java | 6 +-
.../ClosedContextHandler.java | 2 +-
.../CompletedEvaluatorHandler.java | 2 +-
.../CompletedTaskHandler.java | 2 +-
.../EmptyTask.java | 2 +-
.../RunningTaskHandler.java | 2 +-
.../StartHandler.java | 2 +-
.../apache/reef/util/cache/WrappedValue.java | 4 +-
.../util/cache/CacheImplConcurrentTest.java | 12 +-
.../org/apache/reef/wake/AbstractEStage.java | 2 +-
.../org/apache/reef/wake/IdentifierParser.java | 4 +-
.../org/apache/reef/wake/WakeConfiguration.java | 8 +-
.../wake/examples/accumulate/CombinerStage.java | 18 +-
.../reef/wake/examples/join/BlockingJoin.java | 12 +-
.../reef/wake/examples/join/EventPrinter.java | 4 +-
.../wake/examples/join/NonBlockingJoin.java | 10 +-
.../reef/wake/examples/join/TupleEvent.java | 6 +-
.../reef/wake/examples/join/TupleSource.java | 2 +-
.../reef/wake/impl/BlockingEventHandler.java | 4 +-
.../wake/impl/BlockingSignalEventHandler.java | 2 +-
.../wake/impl/DefaultIdentifierFactory.java | 16 +-
.../reef/wake/impl/DefaultThreadFactory.java | 14 +-
.../apache/reef/wake/impl/ForkPoolStage.java | 12 +-
.../IndependentIterationsThreadPoolStage.java | 5 +-
.../reef/wake/impl/LoggingEventHandler.java | 2 +-
.../org/apache/reef/wake/impl/LoggingUtils.java | 6 +-
.../reef/wake/impl/LoggingVoidEventHandler.java | 2 +-
.../reef/wake/impl/MergingEventHandler.java | 2 +-
.../reef/wake/impl/MultiEventHandler.java | 6 +-
.../reef/wake/impl/PubSubEventHandler.java | 8 +-
.../reef/wake/impl/SingleThreadStage.java | 11 +-
.../org/apache/reef/wake/impl/SyncStage.java | 2 +-
.../apache/reef/wake/impl/ThreadPoolStage.java | 4 +-
.../org/apache/reef/wake/impl/TimerStage.java | 2 +-
.../apache/reef/wake/impl/WakeSharedPool.java | 8 +-
.../wake/impl/WakeUncaughtExceptionHandler.java | 4 +-
.../java/org/apache/reef/wake/metrics/EWMA.java | 6 +-
.../org/apache/reef/wake/metrics/Meter.java | 4 +-
.../reef/wake/metrics/UniformHistogram.java | 6 +-
.../org/apache/reef/wake/profiler/Vertex.java | 11 +-
.../apache/reef/wake/profiler/WakeProfiler.java | 92 +++----
.../reef/wake/remote/DefaultErrorHandler.java | 2 +-
.../address/LegacyLocalAddressProvider.java | 20 +-
.../address/LocalAddressProviderFactory.java | 2 +-
.../exception/RemoteRuntimeException.java | 6 +-
.../apache/reef/wake/remote/impl/ByteCodec.java | 4 +-
.../wake/remote/impl/ConnectFutureTask.java | 2 +-
...ltRemoteIdentifierFactoryImplementation.java | 5 +-
.../impl/DefaultRemoteManagerFactory.java | 3 +-
.../wake/remote/impl/DefaultRemoteMessage.java | 2 +-
.../remote/impl/DefaultTransportEStage.java | 2 +-
.../reef/wake/remote/impl/MultiCodec.java | 12 +-
.../reef/wake/remote/impl/MultiDecoder.java | 16 +-
.../reef/wake/remote/impl/MultiEncoder.java | 8 +-
.../remote/impl/OrderedRemoteReceiverStage.java | 29 +--
.../wake/remote/impl/ProxyEventHandler.java | 8 +-
.../reef/wake/remote/impl/RemoteEvent.java | 13 +-
.../reef/wake/remote/impl/RemoteEventCodec.java | 6 +-
.../wake/remote/impl/RemoteEventComparator.java | 2 +-
.../wake/remote/impl/RemoteEventDecoder.java | 8 +-
.../wake/remote/impl/RemoteEventEncoder.java | 8 +-
.../remote/impl/RemoteReceiverEventHandler.java | 6 +-
.../wake/remote/impl/RemoteReceiverStage.java | 4 +-
.../remote/impl/RemoteSenderEventHandler.java | 20 +-
.../wake/remote/impl/RemoteSeqNumGenerator.java | 2 +-
.../remote/impl/SocketRemoteIdentifier.java | 16 +-
.../reef/wake/remote/impl/StringCodec.java | 4 +-
.../reef/wake/remote/impl/Subscription.java | 2 +-
.../reef/wake/remote/impl/TransportEvent.java | 4 +-
.../apache/reef/wake/remote/impl/Tuple2.java | 6 +-
.../wake/remote/ports/RandomRangeIterator.java | 2 +-
.../exception/TransportRuntimeException.java | 6 +-
.../netty/AbstractNettyEventListener.java | 4 +-
.../remote/transport/netty/ByteEncoder.java | 2 +-
.../netty/ChunkedReadWriteHandler.java | 10 +-
.../transport/netty/LoggingLinkListener.java | 4 +-
.../netty/MessagingTransportFactory.java | 12 +-
.../netty/NettyChannelInitializer.java | 2 +-
.../wake/remote/transport/netty/NettyLink.java | 4 +-
.../netty/NettyMessagingTransport.java | 33 +--
.../apache/reef/wake/rx/AbstractRxStage.java | 2 +-
.../apache/reef/wake/rx/impl/RxSyncStage.java | 8 +-
.../reef/wake/rx/impl/RxThreadPoolStage.java | 6 +-
.../apache/reef/wake/rx/impl/SimpleSubject.java | 6 +-
.../reef/wake/rx/impl/TimeoutSubject.java | 10 +-
.../reef/wake/storage/FileHandlePool.java | 4 +-
.../reef/wake/storage/FileIdentifier.java | 4 +-
.../apache/reef/wake/storage/ReadRequest.java | 2 +-
.../reef/wake/storage/SequentialFileReader.java | 8 +-
.../java/org/apache/reef/wake/time/Time.java | 4 +-
.../reef/wake/time/runtime/LogicalTimer.java | 4 +-
.../reef/wake/time/runtime/RuntimeClock.java | 8 +-
.../wake/test/BlockingEventHandlerTest.java | 50 ++--
.../test/BlockingSignalEventHandlerTest.java | 40 +--
.../reef/wake/test/ForkPoolStageTest.java | 72 +++---
...ndependentIterationsThreadPoolStageTest.java | 14 +-
.../org/apache/reef/wake/test/MetricsTest.java | 4 +-
.../wake/test/PubSubThreadPoolStageTest.java | 22 +-
.../apache/reef/wake/test/StageManagerTest.java | 2 +-
.../apache/reef/wake/test/SyncStageTest.java | 30 +--
.../reef/wake/test/ThreadPoolStageTest.java | 62 ++---
.../apache/reef/wake/test/TimerStageTest.java | 12 +-
.../reef/wake/test/examples/SkipListTest.java | 136 +++++-----
.../wake/test/examples/TestBlockingJoin.java | 8 +-
.../reef/wake/test/examples/TestCombiner.java | 28 +--
.../reef/wake/test/examples/TestJoin.java | 8 +-
.../wake/test/examples/TestTupleSource.java | 4 +-
.../reef/wake/test/remote/LargeMsgTest.java | 24 +-
.../remote/RemoteIdentifierFactoryTest.java | 8 +-
.../wake/test/remote/RemoteManagerTest.java | 175 ++++++-------
.../reef/wake/test/remote/RemoteTest.java | 68 ++---
.../wake/test/remote/SmallMessagesTest.java | 48 ++--
.../apache/reef/wake/test/remote/TestEvent.java | 2 +-
.../reef/wake/test/remote/TestEvent1.java | 2 +-
.../reef/wake/test/remote/TestEvent2.java | 2 +-
.../reef/wake/test/remote/TestEventCodec.java | 10 +-
.../reef/wake/test/remote/TestRemote.java | 22 +-
.../wake/test/remote/TestRemoteIdentifier.java | 6 +-
.../wake/test/remote/TransportRaceTest.java | 22 +-
.../reef/wake/test/remote/TransportTest.java | 25 +-
.../org/apache/reef/wake/test/rx/RxTest.java | 12 +-
.../wake/test/rx/RxThreadPoolStageTest.java | 30 +--
.../reef/wake/test/rx/TimeoutSubjectTest.java | 22 +-
.../apache/reef/wake/test/time/ClockTest.java | 12 +-
.../reef/wake/test/util/PassThroughEncoder.java | 2 +-
.../reef/wake/test/util/TimeoutHandler.java | 4 +-
.../webserver/HttpServerReefEventHandler.java | 2 +-
.../reef/webserver/ReefEventStateManager.java | 2 +-
.../reef/webserver/TestAvroHttpSerializer.java | 4 +-
380 files changed, 2907 insertions(+), 2876 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java
index 2d72965..0a508b4 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalClient.java
@@ -117,11 +117,11 @@ public class LocalClient {
}
private static Configuration getRuntimeConfiguration(
- int numberOfEvaluators,
- String runtimeRootFolder,
- int tcpBeginPort,
- int tcpRangeCount,
- int tcpTryCount) {
+ final int numberOfEvaluators,
+ final String runtimeRootFolder,
+ final int tcpBeginPort,
+ final int tcpRangeCount,
+ final int tcpTryCount) {
final Configuration runtimeConfiguration = getRuntimeConfiguration(numberOfEvaluators, runtimeRootFolder);
final Configuration userproviderConfiguration = Tang.Factory.getTang().newConfigurationBuilder()
.bindSetEntry(DriverConfigurationProviders.class, TcpPortConfigurationProvider.class)
@@ -132,7 +132,7 @@ public class LocalClient {
return Configurations.merge(runtimeConfiguration, userproviderConfiguration);
}
- private static Configuration getRuntimeConfiguration(int numberOfEvaluators, String runtimeRootFolder) {
+ private static Configuration getRuntimeConfiguration(final int numberOfEvaluators, final String runtimeRootFolder) {
return LocalRuntimeConfiguration.CONF
.set(LocalRuntimeConfiguration.MAX_NUMBER_OF_EVALUATORS, Integer.toString(numberOfEvaluators))
.set(LocalRuntimeConfiguration.RUNTIME_ROOT_FOLDER, runtimeRootFolder)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java
index 7ab512d..bb47834 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java
@@ -156,11 +156,13 @@ public final class YarnJobSubmissionClient {
}
}
- private static Configuration getRuntimeConfiguration(int tcpBeginPort, int tcpRangeCount, int tcpTryCount) {
- Configuration yarnClientConfig = YarnClientConfiguration.CONF
+ private static Configuration getRuntimeConfiguration(final int tcpBeginPort,
+ final int tcpRangeCount,
+ final int tcpTryCount) {
+ final Configuration yarnClientConfig = YarnClientConfiguration.CONF
.build();
- Configuration providerConfig = Tang.Factory.getTang().newConfigurationBuilder()
+ final Configuration providerConfig = Tang.Factory.getTang().newConfigurationBuilder()
.bindSetEntry(DriverConfigurationProviders.class, TcpPortConfigurationProvider.class)
.bindNamedParameter(TcpPortRangeBegin.class, Integer.toString(tcpBeginPort))
.bindNamedParameter(TcpPortRangeCount.class, Integer.toString(tcpRangeCount))
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java
index 8417d10..4a89e87 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/AllocatedEvaluatorBridge.java
@@ -52,8 +52,8 @@ public class AllocatedEvaluatorBridge extends NativeBridge {
if (taskConfigurationString.isEmpty()) {
throw new RuntimeException("empty taskConfigurationString provided.");
}
- Configuration contextConfiguration;
- Configuration taskConfiguration;
+ final Configuration contextConfiguration;
+ final Configuration taskConfiguration;
try {
contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy);
taskConfiguration = serializer.fromString(taskConfigurationString, clrClassHierarchy);
@@ -69,7 +69,7 @@ public class AllocatedEvaluatorBridge extends NativeBridge {
if (contextConfigurationString.isEmpty()) {
throw new RuntimeException("empty contextConfigurationString provided.");
}
- Configuration contextConfiguration;
+ final Configuration contextConfiguration;
try {
contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy);
} catch (final Exception e) {
@@ -89,8 +89,8 @@ public class AllocatedEvaluatorBridge extends NativeBridge {
throw new RuntimeException("empty serviceConfigurationString provided.");
}
- Configuration contextConfiguration;
- Configuration servicetConfiguration;
+ final Configuration contextConfiguration;
+ final Configuration servicetConfiguration;
try {
contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy);
servicetConfiguration = serializer.fromString(serviceConfigurationString, clrClassHierarchy);
@@ -115,9 +115,9 @@ public class AllocatedEvaluatorBridge extends NativeBridge {
if (taskConfigurationString.isEmpty()) {
throw new RuntimeException("empty taskConfigurationString provided.");
}
- Configuration contextConfiguration;
- Configuration servicetConfiguration;
- Configuration taskConfiguration;
+ final Configuration contextConfiguration;
+ final Configuration servicetConfiguration;
+ final Configuration taskConfiguration;
try {
contextConfiguration = serializer.fromString(contextConfigurationString, clrClassHierarchy);
servicetConfiguration = serializer.fromString(serviceConfigurationString, clrClassHierarchy);
@@ -132,7 +132,8 @@ public class AllocatedEvaluatorBridge extends NativeBridge {
}
public String getEvaluatorDescriptorSring() {
- String descriptorString = Utilities.getEvaluatorDescriptorString(jallocatedEvaluator.getEvaluatorDescriptor());
+ final String descriptorString =
+ Utilities.getEvaluatorDescriptorString(jallocatedEvaluator.getEvaluatorDescriptor());
LOG.log(Level.INFO, "allocated evaluator - serialized evaluator descriptor: " + descriptorString);
return descriptorString;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java
index 6aeaf53..5cd2b6d 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ClosedContextBridge.java
@@ -70,7 +70,7 @@ public class ClosedContextBridge extends NativeBridge implements ClosedContext {
}
public String getEvaluatorDescriptorSring() {
- String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor);
+ final String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor);
LOG.log(Level.INFO, "Closed Context - serialized evaluator descriptor: " + descriptorString);
return descriptorString;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java
index c13a213..79143f6 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/CompletedEvaluatorBridge.java
@@ -27,7 +27,7 @@ public class CompletedEvaluatorBridge extends NativeBridge implements Identifiab
private final String evaluatorId;
- public CompletedEvaluatorBridge(CompletedEvaluator completedEvaluator) {
+ public CompletedEvaluatorBridge(final CompletedEvaluator completedEvaluator) {
jcompletedEvaluator = completedEvaluator;
evaluatorId = completedEvaluator.getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java
index 61e2e9e..3ba9f2d 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/ContextMessageBridge.java
@@ -27,7 +27,7 @@ public class ContextMessageBridge extends NativeBridge implements ContextMessage
private String messageSourceId;
private byte[] message;
- public ContextMessageBridge(ContextMessage contextMessage) {
+ public ContextMessageBridge(final ContextMessage contextMessage) {
jcontextMessage = contextMessage;
contextMessageId = contextMessage.getId();
messageSourceId = contextMessage.getMessageSourceID();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java
index 331040a..3f0bfce 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedContextBridge.java
@@ -79,7 +79,7 @@ public final class FailedContextBridge extends NativeBridge implements ContextBa
}
public String getEvaluatorDescriptorSring() {
- String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor);
+ final String descriptorString = Utilities.getEvaluatorDescriptorString(evaluatorDescriptor);
LOG.log(Level.INFO, "Failed Context - serialized evaluator descriptor: " + descriptorString);
return descriptorString;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java
index 898f670..9447185 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedEvaluatorBridge.java
@@ -30,8 +30,10 @@ public class FailedEvaluatorBridge extends NativeBridge {
private EvaluatorRequestorBridge evaluatorRequestorBridge;
private String evaluatorId;
- public FailedEvaluatorBridge(FailedEvaluator failedEvaluator, EvaluatorRequestor evaluatorRequestor,
- boolean blockedForAdditionalEvaluator, final LoggingScopeFactory loggingScopeFactory) {
+ public FailedEvaluatorBridge(final FailedEvaluator failedEvaluator,
+ final EvaluatorRequestor evaluatorRequestor,
+ final boolean blockedForAdditionalEvaluator,
+ final LoggingScopeFactory loggingScopeFactory) {
jfailedEvaluator = failedEvaluator;
evaluatorId = failedEvaluator.getId();
evaluatorRequestorBridge =
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java
index 9f6a813..76df191 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropLogger.java
@@ -41,9 +41,9 @@ public class InteropLogger {
levelHashMap.put(Level.ALL.intValue(), Level.ALL);
}
- public void log(int intLevel, String message) {
+ public void log(final int intLevel, final String message) {
if (levelHashMap.containsKey(intLevel)) {
- Level level = levelHashMap.get(intLevel);
+ final Level level = levelHashMap.get(intLevel);
LOG.log(level, message);
} else {
LOG.log(Level.WARNING, "Level " + intLevel + " is not a valid Log level");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java
index a257473..3a27f3a 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/InteropReturnInfo.java
@@ -25,7 +25,7 @@ public class InteropReturnInfo {
int returnCode;
ArrayList<String> exceptionList = new ArrayList<String>();
- public void addExceptionString(String exceptionString) {
+ public void addExceptionString(final String exceptionString) {
exceptionList.add(exceptionString);
}
@@ -41,7 +41,7 @@ public class InteropReturnInfo {
return returnCode;
}
- public void setReturnCode(int rc) {
+ public void setReturnCode(final int rc) {
returnCode = rc;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java
index c047475..6957608 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/JavaBridge.java
@@ -24,7 +24,7 @@ public class JavaBridge {
static {
try {
System.loadLibrary(CPP_BRIDGE);
- } catch (UnsatisfiedLinkError e) {
+ } catch (final UnsatisfiedLinkError e) {
// TODO[JIRA REEF-383] Document/Refactor JavaBridge
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java
index 8ea50ad..5ec69c4 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/LibLoader.java
@@ -116,7 +116,7 @@ public final class LibLoader {
private static void loadAllManagedDLLs(final File folder) {
LOG.log(Level.INFO, "Loading all managed DLLs from {0}", folder.getAbsolutePath());
final File[] files = folder.listFiles(new FilenameFilter() {
- public boolean accept(File dir, String name) {
+ public boolean accept(final File dir, final String name) {
return name.toLowerCase().endsWith(DLL_EXTENSION);
}
});
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java
index f448707..beb2f74 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeBridge.java
@@ -25,7 +25,7 @@ public abstract class NativeBridge implements AutoCloseable {
private static final Logger LOG = Logger.getLogger(ActiveContextBridge.class.getName());
- public void onError(String errorMessage) {
+ public void onError(final String errorMessage) {
LOG.log(Level.SEVERE, "Bridge received error from CLR: " + errorMessage);
throw new RuntimeException("Bridge received error from CLR: " + errorMessage);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java
index 2c11b7d..56306d7 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java
@@ -62,101 +62,101 @@ public final class NativeInterop {
public static final int N_HANDLERS = 17;
- public static native void loadClrAssembly(String filePath);
+ public static native void loadClrAssembly(final String filePath);
- public static native void clrBufferedLog(int level, String message);
+ public static native void clrBufferedLog(final int level, final String message);
public static native long[] callClrSystemOnStartHandler(
- String dateTime,
- String httpServerPortNumber,
- EvaluatorRequestorBridge javaEvaluatorRequestorBridge);
+ final String dateTime,
+ final String httpServerPortNumber,
+ final EvaluatorRequestorBridge javaEvaluatorRequestorBridge);
public static native void clrSystemAllocatedEvaluatorHandlerOnNext(
- long handle,
- AllocatedEvaluatorBridge javaEvaluatorBridge,
- InteropLogger interopLogger
+ final long handle,
+ final AllocatedEvaluatorBridge javaEvaluatorBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemActiveContextHandlerOnNext(
- long handle,
- ActiveContextBridge javaActiveContextBridge,
- InteropLogger interopLogger
+ final long handle,
+ final ActiveContextBridge javaActiveContextBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemTaskMessageHandlerOnNext(
- long handle,
- byte[] mesage,
- TaskMessageBridge javaTaskMessageBridge,
- InteropLogger interopLogger
+ final long handle,
+ final byte[] mesage,
+ final TaskMessageBridge javaTaskMessageBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemFailedTaskHandlerOnNext(
- long handle,
- FailedTaskBridge failedTaskBridge,
- InteropLogger interopLogger
+ final long handle,
+ final FailedTaskBridge failedTaskBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemHttpServerHandlerOnNext(
- long handle,
- HttpServerEventBridge httpServerEventBridge,
- InteropLogger interopLogger
+ final long handle,
+ final HttpServerEventBridge httpServerEventBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemFailedEvaluatorHandlerOnNext(
- long handle,
- FailedEvaluatorBridge failedEvaluatorBridge,
- InteropLogger interopLogger
+ final long handle,
+ final FailedEvaluatorBridge failedEvaluatorBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemCompletedTaskHandlerOnNext(
- long handle,
- CompletedTaskBridge completedTaskBridge,
- InteropLogger interopLogger
+ final long handle,
+ final CompletedTaskBridge completedTaskBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemRunningTaskHandlerOnNext(
- long handle,
- RunningTaskBridge runningTaskBridge,
- InteropLogger interopLogger
+ final long handle,
+ final RunningTaskBridge runningTaskBridge,
+ final InteropLogger interopLogger
);
public static native void clrSystemSuspendedTaskHandlerOnNext(
- long handle,
- SuspendedTaskBridge suspendedTaskBridge
+ final long handle,
+ final SuspendedTaskBridge suspendedTaskBridge
);
public static native void clrSystemCompletedEvaluatorHandlerOnNext(
- long handle,
- CompletedEvaluatorBridge completedEvaluatorBridge
+ final long handle,
+ final CompletedEvaluatorBridge completedEvaluatorBridge
);
public static native void clrSystemClosedContextHandlerOnNext(
- long handle,
- ClosedContextBridge closedContextBridge
+ final long handle,
+ final ClosedContextBridge closedContextBridge
);
public static native void clrSystemFailedContextHandlerOnNext(
- long handle,
- FailedContextBridge failedContextBridge
+ final long handle,
+ final FailedContextBridge failedContextBridge
);
public static native void clrSystemContextMessageHandlerOnNext(
- long handle,
- ContextMessageBridge contextMessageBridge
+ final long handle,
+ final ContextMessageBridge contextMessageBridge
);
public static native void clrSystemDriverRestartHandlerOnNext(
- long handle
+ final long handle
);
public static native void clrSystemDriverRestartActiveContextHandlerOnNext(
- long handle,
- ActiveContextBridge activeContextBridge
+ final long handle,
+ final ActiveContextBridge activeContextBridge
);
public static native void clrSystemDriverRestartRunningTaskHandlerOnNext(
- long handle,
- RunningTaskBridge runningTaskBridge
+ final long handle,
+ final RunningTaskBridge runningTaskBridge
);
/**
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java
index 256acf8..2c92e96 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/TaskMessageBridge.java
@@ -25,7 +25,7 @@ public class TaskMessageBridge extends NativeBridge {
private String taskId;
// we don't really need to pass this around, just have this as place holder for future.
- public TaskMessageBridge(TaskMessage taskMessage) {
+ public TaskMessageBridge(final TaskMessage taskMessage) {
jtaskMessage = taskMessage;
taskId = taskMessage.getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java
index 2578cf2..1dd3802 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java
@@ -32,7 +32,7 @@ import java.nio.file.Path;
import java.nio.file.Paths;
public final class Utilities {
- public static ClassHierarchy loadClassHierarchy(String classHierarchyFile) {
+ public static ClassHierarchy loadClassHierarchy(final String classHierarchyFile) {
// TODO The file should be created via AvroClassHierarchySerializer
Path p = Paths.get(classHierarchyFile);
if (!Files.exists(p)) {
@@ -52,8 +52,8 @@ public final class Utilities {
}
}
- public static String getEvaluatorDescriptorString(EvaluatorDescriptor evaluatorDescriptor) {
- InetSocketAddress socketAddress = evaluatorDescriptor.getNodeDescriptor().getInetSocketAddress();
+ public static String getEvaluatorDescriptorString(final EvaluatorDescriptor evaluatorDescriptor) {
+ final InetSocketAddress socketAddress = evaluatorDescriptor.getNodeDescriptor().getInetSocketAddress();
return "IP=" + socketAddress.getAddress() + ", Port=" + socketAddress.getPort() + ", HostName=" +
socketAddress.getHostName() + ", Memory=" + evaluatorDescriptor.getMemory() + ", Core=" +
evaluatorDescriptor.getNumberOfCores();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java
index da80dff..ba0d46a 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java
@@ -131,11 +131,11 @@ public class JobClient {
* @return the driver-side configuration to be merged into the DriverConfiguration to enable the HTTP server.
*/
public static Configuration getHTTPConfiguration() {
- Configuration httpHandlerConfiguration = HttpHandlerConfiguration.CONF
+ final Configuration httpHandlerConfiguration = HttpHandlerConfiguration.CONF
.set(HttpHandlerConfiguration.HTTP_HANDLERS, HttpServerReefEventHandler.class)
.build();
- Configuration driverConfigurationForHttpServer = DriverServiceConfiguration.CONF
+ final Configuration driverConfigurationForHttpServer = DriverServiceConfiguration.CONF
.set(DriverServiceConfiguration.ON_EVALUATOR_ALLOCATED,
ReefEventStateManager.AllocatedEvaluatorStateHandler.class)
.set(DriverServiceConfiguration.ON_CONTEXT_ACTIVE, ReefEventStateManager.ActiveContextStateHandler.class)
@@ -166,7 +166,7 @@ public class JobClient {
.set(DriverConfiguration.DRIVER_JOB_SUBMISSION_DIRECTORY, this.jobSubmissionDirectory);
- Path globalLibFile = Paths.get(NativeInterop.GLOBAL_LIBRARIES_FILENAME);
+ final Path globalLibFile = Paths.get(NativeInterop.GLOBAL_LIBRARIES_FILENAME);
if (!Files.exists(globalLibFile)) {
LOG.log(Level.FINE, "Cannot find global classpath file at: {0}, assume there is none.",
globalLibFile.toAbsolutePath());
@@ -179,7 +179,7 @@ public class JobClient {
}
for (final String s : globalLibString.split(",")) {
- File f = new File(s);
+ final File f = new File(s);
this.driverConfigModule = this.driverConfigModule.set(DriverConfiguration.GLOBAL_LIBRARIES, f.getPath());
}
}
@@ -204,7 +204,7 @@ public class JobClient {
if (submitDriver) {
this.reef.submit(this.driverConfiguration);
} else {
- File driverConfig = new File(System.getProperty("user.dir") + "/driver.config");
+ final File driverConfig = new File(System.getProperty("user.dir") + "/driver.config");
try {
new AvroConfigurationSerializer().toFile(Configurations.merge(this.driverConfiguration, clientConfig),
driverConfig);
@@ -256,7 +256,7 @@ public class JobClient {
} else if (waitTime < 0) {
waitTillDone();
}
- long endTime = System.currentTimeMillis() + waitTime * 1000;
+ final long endTime = System.currentTimeMillis() + waitTime * 1000;
close(endTime);
}
@@ -321,7 +321,7 @@ public class JobClient {
final class WakeErrorHandler implements EventHandler<Throwable> {
@Override
- public void onNext(Throwable error) {
+ public void onNext(final Throwable error) {
LOG.log(Level.SEVERE, "Error communicating with job driver, exiting... ", error);
stopAndNotify();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
index 35dab6d..e4c6860 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
@@ -178,7 +178,7 @@ public final class JobDriver {
try {
libLoader.loadLib();
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException("Fail to load CLR libraries");
}
@@ -191,10 +191,10 @@ public final class JobDriver {
}
LOG.log(Level.INFO, "StartTime: {0}", new Object[]{startTime});
- String portNumber = httpServer == null ? null : Integer.toString((httpServer.getPort()));
- EvaluatorRequestorBridge evaluatorRequestorBridge =
+ final String portNumber = httpServer == null ? null : Integer.toString((httpServer.getPort()));
+ final EvaluatorRequestorBridge evaluatorRequestorBridge =
new EvaluatorRequestorBridge(JobDriver.this.evaluatorRequestor, false, loggingScopeFactory);
- long[] handlers =
+ final long[] handlers =
NativeInterop.callClrSystemOnStartHandler(startTime.toString(), portNumber, evaluatorRequestorBridge);
if (handlers != null) {
if (handlers.length != NativeInterop.N_HANDLERS) {
@@ -245,7 +245,7 @@ public final class JobDriver {
}
private CLRBufferedLogHandler getCLRBufferedLogHandler() {
- for (Handler handler : Logger.getLogger("").getHandlers()) {
+ for (final Handler handler : Logger.getLogger("").getHandlers()) {
if (handler instanceof CLRBufferedLogHandler) {
return (CLRBufferedLogHandler) handler;
}
@@ -261,7 +261,7 @@ public final class JobDriver {
if (JobDriver.this.allocatedEvaluatorHandler == 0) {
throw new RuntimeException("Allocated Evaluator Handler not initialized by CLR.");
}
- AllocatedEvaluatorBridge allocatedEvaluatorBridge =
+ final AllocatedEvaluatorBridge allocatedEvaluatorBridge =
new AllocatedEvaluatorBridge(eval, JobDriver.this.nameServerInfo);
NativeInterop.clrSystemAllocatedEvaluatorHandlerOnNext(JobDriver.this.allocatedEvaluatorHandler,
allocatedEvaluatorBridge, this.interopLogger);
@@ -277,7 +277,7 @@ public final class JobDriver {
if (JobDriver.this.activeContextHandler == 0) {
throw new RuntimeException("Active Context Handler not initialized by CLR.");
}
- ActiveContextBridge activeContextBridge = activeContextBridgeFactory.getActiveContextBridge(context);
+ final ActiveContextBridge activeContextBridge = activeContextBridgeFactory.getActiveContextBridge(context);
NativeInterop.clrSystemActiveContextHandlerOnNext(JobDriver.this.activeContextHandler, activeContextBridge,
JobDriver.this.interopLogger);
} catch (final Exception ex) {
@@ -340,7 +340,7 @@ public final class JobDriver {
LOG.log(Level.INFO, "No CLR handler bound to handle completed task.");
} else {
LOG.log(Level.INFO, "CLR CompletedTaskHandler handler set, handling things with CLR handler.");
- CompletedTaskBridge completedTaskBridge = new CompletedTaskBridge(task, activeContextBridgeFactory);
+ final CompletedTaskBridge completedTaskBridge = new CompletedTaskBridge(task, activeContextBridgeFactory);
NativeInterop.clrSystemCompletedTaskHandlerOnNext(JobDriver.this.completedTaskHandler, completedTaskBridge,
JobDriver.this.interopLogger);
}
@@ -358,7 +358,7 @@ public final class JobDriver {
synchronized (JobDriver.this) {
LOG.log(Level.SEVERE, "FailedEvaluator", eval);
for (final FailedContext failedContext : eval.getFailedContextList()) {
- String failedContextId = failedContext.getId();
+ final String failedContextId = failedContext.getId();
LOG.log(Level.INFO, "removing context " + failedContextId + " from job driver contexts.");
JobDriver.this.contexts.remove(failedContextId);
}
@@ -399,7 +399,7 @@ public final class JobDriver {
JobDriver.this.isRestarted, loggingScopeFactory);
NativeInterop.clrSystemFailedEvaluatorHandlerOnNext(JobDriver.this.failedEvaluatorHandler, failedEvaluatorBridge,
JobDriver.this.interopLogger);
- int additionalRequestedEvaluatorNumber = failedEvaluatorBridge.getNewlyRequestedEvaluatorNumber();
+ final int additionalRequestedEvaluatorNumber = failedEvaluatorBridge.getNewlyRequestedEvaluatorNumber();
if (additionalRequestedEvaluatorNumber > 0) {
LOG.log(Level.INFO, "number of additional evaluators requested after evaluator failure: " +
additionalRequestedEvaluatorNumber);
@@ -419,7 +419,7 @@ public final class JobDriver {
return uriSpecification;
}
- public void setUriSpecification(String s) {
+ public void setUriSpecification(final String s) {
uriSpecification = s;
}
@@ -465,7 +465,7 @@ public final class JobDriver {
throw new RuntimeException("Failed Task Handler not initialized by CLR.");
}
try {
- FailedTaskBridge failedTaskBridge = new FailedTaskBridge(task, activeContextBridgeFactory);
+ final FailedTaskBridge failedTaskBridge = new FailedTaskBridge(task, activeContextBridgeFactory);
NativeInterop.clrSystemFailedTaskHandlerOnNext(JobDriver.this.failedTaskHandler, failedTaskBridge,
JobDriver.this.interopLogger);
} catch (final Exception ex) {
@@ -637,11 +637,11 @@ public final class JobDriver {
public final class TaskMessageHandler implements EventHandler<TaskMessage> {
@Override
public void onNext(final TaskMessage taskMessage) {
- String msg = new String(taskMessage.get());
+ final String msg = new String(taskMessage.get());
LOG.log(Level.INFO, "Received TaskMessage: {0} from CLR", msg);
//try (LoggingScope ls = loggingScopeFactory.taskMessageReceived(new String(msg))) {
if (JobDriver.this.taskMessageHandler != 0) {
- TaskMessageBridge taskMessageBridge = new TaskMessageBridge(taskMessage);
+ final TaskMessageBridge taskMessageBridge = new TaskMessageBridge(taskMessage);
// if CLR implements the task message handler, handle the bytes in CLR handler
NativeInterop.clrSystemTaskMessageHandlerOnNext(JobDriver.this.taskMessageHandler, taskMessage.get(),
taskMessageBridge, JobDriver.this.interopLogger);
@@ -660,7 +660,7 @@ public final class JobDriver {
LOG.log(Level.INFO, message);
try (final LoggingScope ls = loggingScopeFactory.taskSuspended(task.getId())) {
if (JobDriver.this.suspendedTaskHandler != 0) {
- SuspendedTaskBridge suspendedTaskBridge = new SuspendedTaskBridge(task, activeContextBridgeFactory);
+ final SuspendedTaskBridge suspendedTaskBridge = new SuspendedTaskBridge(task, activeContextBridgeFactory);
// if CLR implements the suspended task handler, handle it in CLR
LOG.log(Level.INFO, "Handling the event of suspended task in CLR bridge.");
NativeInterop.clrSystemSuspendedTaskHandlerOnNext(JobDriver.this.suspendedTaskHandler, suspendedTaskBridge);
@@ -679,7 +679,7 @@ public final class JobDriver {
LOG.log(Level.INFO, " Completed Evaluator {0}", evaluator.getId());
try (final LoggingScope ls = loggingScopeFactory.evaluatorCompleted(evaluator.getId())) {
if (JobDriver.this.completedEvaluatorHandler != 0) {
- CompletedEvaluatorBridge completedEvaluatorBridge = new CompletedEvaluatorBridge(evaluator);
+ final CompletedEvaluatorBridge completedEvaluatorBridge = new CompletedEvaluatorBridge(evaluator);
// if CLR implements the completed evaluator handler, handle it in CLR
LOG.log(Level.INFO, "Handling the event of completed evaluator in CLR bridge.");
NativeInterop.clrSystemCompletedEvaluatorHandlerOnNext(completedEvaluatorHandler, completedEvaluatorBridge);
@@ -699,7 +699,7 @@ public final class JobDriver {
LOG.log(Level.INFO, "Completed Context: {0}", context.getId());
try (final LoggingScope ls = loggingScopeFactory.closedContext(context.getId())) {
if (JobDriver.this.closedContextHandler != 0) {
- ClosedContextBridge closedContextBridge = new ClosedContextBridge(context, activeContextBridgeFactory);
+ final ClosedContextBridge closedContextBridge = new ClosedContextBridge(context, activeContextBridgeFactory);
// if CLR implements the closed context handler, handle it in CLR
LOG.log(Level.INFO, "Handling the event of closed context in CLR bridge.");
NativeInterop.clrSystemClosedContextHandlerOnNext(JobDriver.this.closedContextHandler, closedContextBridge);
@@ -722,7 +722,7 @@ public final class JobDriver {
LOG.log(Level.SEVERE, "FailedContext", context);
try (final LoggingScope ls = loggingScopeFactory.evaluatorFailed(context.getId())) {
if (JobDriver.this.failedContextHandler != 0) {
- FailedContextBridge failedContextBridge = new FailedContextBridge(context, activeContextBridgeFactory);
+ final FailedContextBridge failedContextBridge = new FailedContextBridge(context, activeContextBridgeFactory);
// if CLR implements the failed context handler, handle it in CLR
LOG.log(Level.INFO, "Handling the event of failed context in CLR bridge.");
NativeInterop.clrSystemFailedContextHandlerOnNext(JobDriver.this.failedContextHandler, failedContextBridge);
@@ -730,7 +730,7 @@ public final class JobDriver {
synchronized (JobDriver.this) {
JobDriver.this.contexts.remove(context.getId());
}
- Optional<byte[]> err = context.getData();
+ final Optional<byte[]> err = context.getData();
if (err.isPresent()) {
JobDriver.this.jobMessageObserver.sendMessageToClient(err.get());
}
@@ -747,7 +747,7 @@ public final class JobDriver {
LOG.log(Level.SEVERE, "Received ContextMessage:", message.get());
try (final LoggingScope ls = loggingScopeFactory.contextMessageReceived(message.get().toString())) {
if (JobDriver.this.contextMessageHandler != 0) {
- ContextMessageBridge contextMessageBridge = new ContextMessageBridge(message);
+ final ContextMessageBridge contextMessageBridge = new ContextMessageBridge(message);
// if CLR implements the context message handler, handle it in CLR
LOG.log(Level.INFO, "Handling the event of context message in CLR bridge.");
NativeInterop.clrSystemContextMessageHandlerOnNext(JobDriver.this.contextMessageHandler,
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java
index 8cc3c84..4392758 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java
@@ -147,7 +147,7 @@ public final class Launch {
throw new IllegalArgumentException("No arguments provided, at least a clrFolder should be supplied.");
}
final File dotNetFolder = new File(args[0]).getAbsoluteFile();
- String[] removedArgs = Arrays.copyOfRange(args, 1, args.length);
+ final String[] removedArgs = Arrays.copyOfRange(args, 1, args.length);
final Configuration config = getClientConfiguration(removedArgs);
final Injector commandLineInjector = Tang.Factory.getTang().newInjector(parseCommandLine(removedArgs));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java
index ef3fc15..18abc1a 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/LaunchHeadless.java
@@ -83,7 +83,7 @@ public final class LaunchHeadless {
}
driverConfigModule = result;
- Configuration driverConfiguration =
+ final Configuration driverConfiguration =
Configurations.merge(driverConfigModule.build(), JobClient.getHTTPConfiguration());
LOG.log(Level.INFO, "Running on YARN");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java
index 26e91d2..abbb8ec 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/util/logging/CLRBufferedLogHandler.java
@@ -73,7 +73,7 @@ public class CLRBufferedLogHandler extends Handler {
* the driver has already been initialized, flush the buffer of the logs.
*/
@Override
- public void publish(LogRecord record) {
+ public void publish(final LogRecord record) {
if (record == null) {
return;
}
@@ -154,7 +154,7 @@ public class CLRBufferedLogHandler extends Handler {
* Returns the integer value of the log record's level to be used
* by the CLR Bridge log function.
*/
- private int getLevel(Level recordLevel) {
+ private int getLevel(final Level recordLevel) {
if (recordLevel.equals(Level.OFF)) {
return 0;
} else if (recordLevel.equals(Level.SEVERE)) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java
index a5a018d..f43cc67 100644
--- a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java
+++ b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointID.java
@@ -37,7 +37,7 @@ public class FSCheckpointID implements CheckpointID {
public FSCheckpointID() {
}
- public FSCheckpointID(Path path) {
+ public FSCheckpointID(final Path path) {
this.path = path;
}
@@ -51,17 +51,17 @@ public class FSCheckpointID implements CheckpointID {
}
@Override
- public void write(DataOutput out) throws IOException {
+ public void write(final DataOutput out) throws IOException {
Text.writeString(out, path.toString());
}
@Override
- public void readFields(DataInput in) throws IOException {
+ public void readFields(final DataInput in) throws IOException {
this.path = new Path(Text.readString(in));
}
@Override
- public boolean equals(Object other) {
+ public boolean equals(final Object other) {
return other instanceof FSCheckpointID
&& path.equals(((FSCheckpointID) other).path);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java
index 15e2ee5..369fb16 100644
--- a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java
+++ b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/fs/FSCheckpointService.java
@@ -84,7 +84,7 @@ public class FSCheckpointService implements CheckpointService {
return createInternal(new Path(base, p));
}
- CheckpointWriteChannel createInternal(Path name) throws IOException {
+ CheckpointWriteChannel createInternal(final Path name) throws IOException {
//create a temp file, fail if file exists
return new FSCheckpointWriteChannel(name, fs.create(tmpfile(name), replication));
@@ -129,7 +129,7 @@ public class FSCheckpointService implements CheckpointService {
if (!fs.delete(tmp, false)) {
throw new IOException("Failed to delete checkpoint during abort");
}
- } catch (FileNotFoundException e) {
+ } catch (final FileNotFoundException e) {
// IGNORE
}
}
@@ -141,10 +141,10 @@ public class FSCheckpointService implements CheckpointService {
throw new IllegalArgumentException(
"Mismatched checkpoint type: " + id.getClass());
}
- Path tmp = ((FSCheckpointID) id).getPath();
+ final Path tmp = ((FSCheckpointID) id).getPath();
try {
return fs.delete(tmp, false);
- } catch (FileNotFoundException e) {
+ } catch (final FileNotFoundException e) {
// IGNORE
}
return true;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java
index c51dfc6..9367a39 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/WorkingDirectoryTempFileCreator.java
@@ -67,7 +67,7 @@ public final class WorkingDirectoryTempFileCreator implements TempFileCreator {
}
@Override
- public File createTempDirectory(String prefix) throws IOException {
+ public File createTempDirectory(final String prefix) throws IOException {
final File result = Files.createTempDirectory(this.tempFolderAsPath, prefix).toFile();
if (LOG.isLoggable(Level.FINEST)) {
LOG.log(Level.FINEST, "Created temporary folder: {0}", result.getAbsolutePath());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java
index d818513..41214b4 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java
@@ -92,7 +92,7 @@ public final class REEFLauncher {
private static REEFLauncher getREEFLauncher(final String clockConfigPath) {
final Injector injector;
try {
- Configuration clockArgConfig = Tang.Factory.getTang().newConfigurationBuilder()
+ final Configuration clockArgConfig = Tang.Factory.getTang().newConfigurationBuilder()
.bindNamedParameter(ClockConfigurationPath.class, clockConfigPath).build();
injector = Tang.Factory.getTang().newInjector(clockArgConfig);
} catch (final BindException e) {
@@ -101,7 +101,7 @@ public final class REEFLauncher {
try {
return injector.getInstance(REEFLauncher.class);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw fatal("Unable to run REEFLauncher.", e);
}
}
@@ -171,7 +171,7 @@ public final class REEFLauncher {
} catch (final Throwable ex) {
try (final REEFErrorHandler errorHandler = launcher.getErrorHandlerFromConfig()) {
throw fatal(errorHandler, "Unable to instantiate the clock", ex);
- } catch (InjectionException e) {
+ } catch (final InjectionException e) {
throw fatal("Unable to instantiate the clock and the ErrorHandler", e);
}
}
@@ -239,7 +239,7 @@ public final class REEFLauncher {
private Clock getClockFromConfig() throws InjectionException {
final Injector clockInjector = Tang.Factory.getTang().newInjector(this.clockConfig);
if (this.isProfilingEnabled) {
- WakeProfiler profiler = new WakeProfiler();
+ final WakeProfiler profiler = new WakeProfiler();
ProfilingStopHandler.setProfiler(profiler);
clockInjector.bindAspect(profiler);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java
index 3496812..47a5baa 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobStatusMessageHandler.java
@@ -44,7 +44,7 @@ final class JobStatusMessageHandler implements EventHandler<RemoteMessage<ReefSe
}
@Override
- public void onNext(RemoteMessage<ReefServiceProtos.JobStatusProto> jobStatusProtoRemoteMessage) {
+ public void onNext(final RemoteMessage<ReefServiceProtos.JobStatusProto> jobStatusProtoRemoteMessage) {
this.runningJobs.onJobStatusMessage(jobStatusProtoRemoteMessage);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java
index 0fea008..fd89e98 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobsImpl.java
@@ -89,7 +89,8 @@ final class RunningJobsImpl implements RunningJobs {
}
@Override
- public synchronized void onRuntimeErrorMessage(RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure) {
+ public synchronized void onRuntimeErrorMessage(
+ final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure) {
try {
this.remove(runtimeFailure.getMessage().getIdentifier());
} finally {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java
index 42b0ff6..2435806 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/NodeDescriptorHandler.java
@@ -34,7 +34,7 @@ public final class NodeDescriptorHandler implements EventHandler<NodeDescriptorE
private final ResourceCatalogImpl resourceCatalog;
@Inject
- public NodeDescriptorHandler(ResourceCatalogImpl resourceCatalog) {
+ public NodeDescriptorHandler(final ResourceCatalogImpl resourceCatalog) {
this.resourceCatalog = resourceCatalog;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java
index a04ade5..500509a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java
@@ -145,7 +145,7 @@ public final class ResourceManagerStatus implements EventHandler<RuntimeStatusEv
}
- private synchronized void setState(ReefServiceProtos.State state) {
+ private synchronized void setState(final ReefServiceProtos.State state) {
// TODO: Add state transition check
this.state = state;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java
index c661d7b..70a3cce 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/resourcemanager/ResourceStatusHandler.java
@@ -57,7 +57,7 @@ public final class ResourceStatusHandler implements EventHandler<ResourceStatusE
evaluatorManager.get().onResourceStatusMessage(resourceStatusEvent);
} else {
if (resourceStatusEvent.getIsFromPreviousDriver().get()) {
- EvaluatorManager previousEvaluatorManager =
+ final EvaluatorManager previousEvaluatorManager =
this.evaluatorManagerFactory.createForEvaluatorFailedDuringDriverRestart(resourceStatusEvent);
previousEvaluatorManager.onResourceStatusMessage(resourceStatusEvent);
} else {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
index 1f6974f..ec4b6db 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java
@@ -159,7 +159,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> {
}
@Override
- public void onNext(EvaluatorControlProto evaluatorControlProto) {
+ public void onNext(final EvaluatorControlProto evaluatorControlProto) {
this.onEvaluatorControlMessage(evaluatorControlProto);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java
index 0b7899d..0ffc559 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/CLRLaunchCommandBuilder.java
@@ -42,7 +42,7 @@ public class CLRLaunchCommandBuilder implements LaunchCommandBuilder {
@Override
public List<String> build() {
final List<String> result = new LinkedList<>();
- File f = new File(EVALUATOR_PATH);
+ final File f = new File(EVALUATOR_PATH);
if (!f.exists()) {
LOG.log(Level.WARNING, "file can NOT be found: {0}", f.getAbsolutePath());
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java
index 2ff1c5e..e496a19 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java
@@ -107,11 +107,12 @@ public final class EnvironmentUtils {
*/
@Deprecated
public static <P extends Param> ConfigurationModule addAll(
- ConfigurationModule config, final P param, final Iterable<String> values) {
+ final ConfigurationModule config, final P param, final Iterable<String> values) {
+ ConfigurationModule conf = config;
for (final String val : values) {
- config = config.set(param, val);
+ conf = conf.set(param, val);
}
- return config;
+ return conf;
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java
index 817eda8..46942fd 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java
@@ -75,7 +75,7 @@ public final class REEFVersion {
final Properties properties = new Properties();
properties.load(is);
version = properties.getProperty(VERSION_KEY, VERSION_DEFAULT);
- } catch (IOException e) {
+ } catch (final IOException e) {
LOG.log(Level.WARNING, "Could not find REEF version");
version = VERSION_DEFAULT;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java
index 8192a10..b49922b 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java
@@ -122,7 +122,7 @@ public final class LogParser {
*/
public static ArrayList<String> filter(final ArrayList<String> original, final String filter, final String token) {
final ArrayList<String> result = new ArrayList<String>();
- for (String line : original) {
+ for (final String line : original) {
if (line.contains(filter)) {
final String[] p = line.split(token);
if (p.length > 1) {
@@ -140,10 +140,10 @@ public final class LogParser {
* @return
*/
public static ArrayList<String> findStages(final ArrayList<String> lines, final String[] stageIndicators) {
- ArrayList<String> stages = new ArrayList<String>();
+ final ArrayList<String> stages = new ArrayList<String>();
int i = 0;
- for (String line: lines) {
+ for (final String line: lines) {
if (line.contains(stageIndicators[i])){
stages.add(stageIndicators[i]);
if (i < stageIndicators.length - 1) {
@@ -154,10 +154,10 @@ public final class LogParser {
return stages;
}
- public static ArrayList<String> mergeStages(ArrayList<String> startStages, ArrayList<String> endStages) {
- ArrayList<String> mergeStage = new ArrayList<String>();
+ public static ArrayList<String> mergeStages(final ArrayList<String> startStages, final ArrayList<String> endStages) {
+ final ArrayList<String> mergeStage = new ArrayList<String>();
for (int i = 0; i < startStages.size(); i++) {
- String end = startStages.get(i).replace(LoggingScopeImpl.START_PREFIX, LoggingScopeImpl.EXIT_PREFIX);
+ final String end = startStages.get(i).replace(LoggingScopeImpl.START_PREFIX, LoggingScopeImpl.EXIT_PREFIX);
if (endStages.contains(end)) {
mergeStage.add(startStages.get(i) + " " + end);
} else {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-common/src/main/resources/checkstyle.xml
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/resources/checkstyle.xml b/lang/java/reef-common/src/main/resources/checkstyle.xml
index 17f4534..1ab4b3e 100644
--- a/lang/java/reef-common/src/main/resources/checkstyle.xml
+++ b/lang/java/reef-common/src/main/resources/checkstyle.xml
@@ -184,6 +184,7 @@
<module name="MissingSwitchDefault"/>
<module name="SimplifyBooleanExpression"/>
<module name="SimplifyBooleanReturn"/>
+ <module name="FinalParameters"/>
<!-- Checks for class design -->
<!-- See http://checkstyle.sf.net/config_design.html -->