You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/27 17:35:38 UTC
[GitHub] [tvm] areusch commented on a diff in pull request #13627: [docs] Add "Open with Colab" button to documentation
areusch commented on code in PR #13627:
URL: https://github.com/apache/tvm/pull/13627#discussion_r1057808388
##########
docs/conf.py:
##########
@@ -84,6 +86,148 @@ def git_describe_version(original_version):
version = git_describe_version(tvm.__version__)
release = version
+
+def monkey_patch(module_name, func_name):
Review Comment:
you might consider using `unittest.mock.patch` here since it's in the stdlib
##########
docs/conf.py:
##########
@@ -506,6 +650,12 @@ def process_docstring(app, what, name, obj, options, lines):
from legacy_redirect import build_legacy_redirect
+def strip_ipython_magic(app, docname, source):
Review Comment:
add a docstring comment just to clarify the function. should this be removing the whole line?
##########
gallery/how_to/work_with_microtvm/micro_tflite.py:
##########
@@ -26,109 +26,36 @@
"""
######################################################################
-# .. note::
-# If you want to run this tutorial on the microTVM Reference VM, download the Jupyter
-# notebook using the link at the bottom of this page and save it into the TVM directory. Then:
#
-# #. Login to the reference VM with a modified ``vagrant ssh`` command:
+# .. include:: ../../../../gallery/how_to/work_with_microtvm/install_dependencies.rst
#
-# ``$ vagrant ssh -- -L8888:localhost:8888``
-#
-# #. Install jupyter: ``pip install jupyterlab``
-# #. ``cd`` to the TVM directory.
-# #. Install tflite: poetry install -E importer-tflite
-# #. Launch Jupyter Notebook: ``jupyter notebook``
-# #. Copy the localhost URL displayed, and paste it into your browser.
-# #. Navigate to saved Jupyter Notebook (``.ipynb`` file).
-#
-#
-# Setup
-# -----
-#
-# Install TFLite
-# ^^^^^^^^^^^^^^
-#
-# To get started, TFLite package needs to be installed as prerequisite. You can do this in two ways:
-#
-# 1. Install tflite with ``pip``
-#
-# .. code-block:: bash
-#
-# pip install tflite=2.1.0 --user
-#
-# 2. Generate the TFLite package yourself. The steps are the following:
-#
-# Get the flatc compiler.
-# Please refer to https://github.com/google/flatbuffers for details
-# and make sure it is properly installed.
-#
-# .. code-block:: bash
-#
-# flatc --version
-#
-# Get the TFLite schema.
-#
-# .. code-block:: bash
-#
-# wget https://raw.githubusercontent.com/tensorflow/tensorflow/r1.13/tensorflow/lite/schema/schema.fbs
-#
-# Generate TFLite package.
-#
-# .. code-block:: bash
-#
-# flatc --python schema.fbs
-#
-# Add the current folder (which contains generated tflite module) to PYTHONPATH.
-#
-# .. code-block:: bash
-#
-# export PYTHONPATH=${PYTHONPATH:+$PYTHONPATH:}$(pwd)
-#
-# To validate that the TFLite package was installed successfully, ``python -c "import tflite"``
-#
-# Install Zephyr (physical hardware only)
-# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-#
-# When running this tutorial with a host simulation (the default), you can use the host ``gcc`` to
-# build a firmware image that simulates the device. When compiling to run on physical hardware, you
-# need to install a *toolchain* plus some target-specific dependencies. microTVM allows you to
-# supply any compiler and runtime that can launch the TVM RPC server, but to get started, this
-# tutorial relies on the Zephyr RTOS to provide these pieces.
-#
-# You can install Zephyr by following the
-# `Installation Instructions <https://docs.zephyrproject.org/latest/getting_started/index.html>`_.
-#
-# Aside: Recreating your own Pre-Trained TFLite model
-# The tutorial downloads a pretrained TFLite model. When working with microcontrollers
-# you need to be mindful these are highly resource constrained devices as such standard
-# models like MobileNet may not fit into their modest memory.
-#
-# For this tutorial, we'll make use of one of the TF Micro example models.
-#
-# If you wish to replicate the training steps see:
-# https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/micro/examples/hello_world/train
-#
-# .. note::
-#
-# If you accidentally download the example pretrained model from:
-#
-# ``wget https://storage.googleapis.com/download.tensorflow.org/models/tflite/micro/hello_world_2020_04_13.zip``
-#
-# this will fail due to an unimplemented opcode (114)
-#
-# Load and prepare the Pre-Trained Model
-# --------------------------------------
-#
-# Load the pretrained TFLite model from a file in your current
-# directory into a buffer
# sphinx_gallery_start_ignore
from tvm import testing
testing.utils.install_request_hook(depth=3)
# sphinx_gallery_end_ignore
+# You can skip the following two sections (installing Zephyr and CMSIS-NN) if the following flag is False.
Review Comment:
could you explain why maybe?
##########
docs/conf.py:
##########
@@ -84,6 +86,148 @@ def git_describe_version(original_version):
version = git_describe_version(tvm.__version__)
release = version
+
+def monkey_patch(module_name, func_name):
+ """Helper function for monkey-patching library functions.
+
+ Used to modify a few sphinx-gallery behaviors to make the "Open in Colab"
+ button work correctly. Should be used as a decorator with arguments.
+ """
+ module = import_module(module_name)
+ original_func = getattr(module, func_name)
+
+ def decorator(function):
+ updated_func = partial(function, real_func=original_func)
+ setattr(module, func_name, updated_func)
+ return updated_func
+
+ return decorator
+
+
+# This header replaces the default sphinx-gallery one in sphinx_gallery/gen_rst.py.
+COLAB_HTML_HEADER = """
+.. DO NOT EDIT. THIS FILE WAS AUTOMATICALLY GENERATED BY
+.. TVM'S MONKEY-PATCHED VERSION OF SPHINX-GALLERY. TO MAKE
+.. CHANGES, EDIT THE SOURCE PYTHON FILE:
+.. "{0}"
+
+.. only:: html
+
+ .. note::
+ :class: sphx-glr-download-link-note
+
+ This tutorial can be used interactively with Google Colab! You can also click
+ :ref:`here <sphx_glr_download_{1}>` to run the Jupyter notebook locally.
+
+ .. image:: https://raw.githubusercontent.com/apache/web-data/main/images/utilities/colab_button.svg
+ :align: center
+ :target: {2}
+ :width: 300px
+
+.. rst-class:: sphx-glr-example-title
+
+.. _sphx_glr_{1}:
+
+"""
+
+# Google Colab allows opening .ipynb files on GitHub by appending the GitHub path to its own url.
+COLAB_URL_BASE = "https://colab.research.google.com/github"
+IPYTHON_GITHUB_BASE = "apache/tvm-site/blob/asf-site/docs/_downloads/"
+
+
+@monkey_patch("sphinx_gallery.gen_rst", "save_rst_example")
+def save_rst_example(example_rst, example_file, time_elapsed, memory_used, gallery_conf, real_func):
+ """Monkey-patch save_rst_example to include the "Open in Colab" button."""
+
+ # The url is the md5 hash of the notebook path.
+ example_fname = os.path.relpath(example_file, gallery_conf["src_dir"])
+ ref_fname = example_fname.replace(os.path.sep, "_")
+ notebook_path = example_fname[:-2] + "ipynb"
+ digest = md5(notebook_path.encode()).hexdigest()
+
+ # Fixed documentation versions must link to different (earlier) .ipynb notebooks.
+ colab_url = f"{COLAB_URL_BASE}/{IPYTHON_GITHUB_BASE}"
+ if "dev" not in version:
+ colab_url += version + "/"
+ colab_url += digest + "/" + os.path.basename(notebook_path)
+
+ new_header = COLAB_HTML_HEADER.format(example_fname, ref_fname, colab_url)
+ with patch("sphinx_gallery.gen_rst.EXAMPLE_HEADER", new_header):
+ real_func(example_rst, example_file, time_elapsed, memory_used, gallery_conf)
+
+
+@monkey_patch("sphinx_gallery.notebook", "rst2md")
+def rst2md(text, gallery_conf, target_dir, heading_levels, real_func):
+ """Monkey-patch rst2md to add limited include directive support to sphinx-gallery."""
+
+ include_re = re.compile(r"^([ \t]*)\.\. include::\s*(.+)\n", flags=re.M)
+
+ def load_include(match):
+ full_path = os.path.join(target_dir, match.group(2))
+ with open(full_path) as f:
+ lines = f.read()
+ indented = textwrap.indent(lines, match.group(1)) + "\n"
+ return indented
+
+ text = re.sub(include_re, load_include, text)
+
+ return real_func(text, gallery_conf, target_dir, heading_levels)
+
+
+INSTALL_TVM_DEV = f"""%%shell
+# Installs the latest dev build of TVM from PyPI. If you wish to build
+# from source, see https://tvm.apache.org/docs/install/from_source.html
+pip install apache-tvm --pre"""
+
+INSTALL_TVM_FIXED = f"""%%shell
+# Installs TVM version {version} from PyPI. If you wish to build
+# from source, see https://tvm.apache.org/docs/install/from_source.html
+pip install apache-tvm=={version}"""
+
+INSTALL_TVM_CUDA_DEV = f"""%%shell
+# Installs the latest dev build of TVM from PyPI, with CUDA enabled. To use this,
+# you must request a Google Colab instance with a GPU by going to Runtime ->
+# Change runtime type -> Hardware accelerator -> GPU. If you wish to build from
+# source, see see https://tvm.apache.org/docs/install/from_source.html
+pip install tlcpack-nightly-cu113 --pre -f https://tlcpack.ai/wheels"""
+
+INSTALL_TVM_CUDA_FIXED = f"""%%shell
+# Installs TVM version {version} from PyPI, with CUDA enabled. To use this,
+# you must request a Google Colab instance with a GPU by going to Runtime ->
+# Change runtime type -> Hardware accelerator -> GPU. If you wish to build from
+# source, see see https://tvm.apache.org/docs/install/from_source.html
+pip install apache-tvm-cu113=={version} -f https://tlcpack.ai/wheels"""
Review Comment:
i wonder if `version == "*"` if this could work for CUDA_DEV too
##########
apps/microtvm/pyproject.toml:
##########
@@ -98,22 +95,23 @@ onnxoptimizer = { version = "==0.2.6", optional = true }
onnxruntime = { version = "==1.9.0", optional = true }
# Pytorch (also used by ONNX)
-torch = { version = "==1.11.0", optional = true }
-torchvision = { version = "==0.12.0", optional = true }
+torch = { version = "==1.11.0" }
Review Comment:
how come you removed `optional = true` here? we use this so that you don't have to install these packages, but may opt to do so with e.g. `poetry install -E importer-torch`
##########
docs/conf.py:
##########
@@ -84,6 +86,148 @@ def git_describe_version(original_version):
version = git_describe_version(tvm.__version__)
release = version
+
+def monkey_patch(module_name, func_name):
+ """Helper function for monkey-patching library functions.
+
+ Used to modify a few sphinx-gallery behaviors to make the "Open in Colab"
+ button work correctly. Should be used as a decorator with arguments.
+ """
+ module = import_module(module_name)
+ original_func = getattr(module, func_name)
+
+ def decorator(function):
+ updated_func = partial(function, real_func=original_func)
+ setattr(module, func_name, updated_func)
+ return updated_func
+
+ return decorator
+
+
+# This header replaces the default sphinx-gallery one in sphinx_gallery/gen_rst.py.
+COLAB_HTML_HEADER = """
+.. DO NOT EDIT. THIS FILE WAS AUTOMATICALLY GENERATED BY
+.. TVM'S MONKEY-PATCHED VERSION OF SPHINX-GALLERY. TO MAKE
+.. CHANGES, EDIT THE SOURCE PYTHON FILE:
+.. "{0}"
Review Comment:
suggest using a named reference e.g. {SOURCE_FILE} instead of {0}
since this comment string is so long. here and below
##########
docs/conf.py:
##########
@@ -84,6 +86,148 @@ def git_describe_version(original_version):
version = git_describe_version(tvm.__version__)
release = version
+
+def monkey_patch(module_name, func_name):
+ """Helper function for monkey-patching library functions.
+
+ Used to modify a few sphinx-gallery behaviors to make the "Open in Colab"
+ button work correctly. Should be used as a decorator with arguments.
+ """
+ module = import_module(module_name)
+ original_func = getattr(module, func_name)
+
+ def decorator(function):
+ updated_func = partial(function, real_func=original_func)
+ setattr(module, func_name, updated_func)
+ return updated_func
+
+ return decorator
+
+
+# This header replaces the default sphinx-gallery one in sphinx_gallery/gen_rst.py.
+COLAB_HTML_HEADER = """
+.. DO NOT EDIT. THIS FILE WAS AUTOMATICALLY GENERATED BY
+.. TVM'S MONKEY-PATCHED VERSION OF SPHINX-GALLERY. TO MAKE
+.. CHANGES, EDIT THE SOURCE PYTHON FILE:
+.. "{0}"
+
+.. only:: html
+
+ .. note::
+ :class: sphx-glr-download-link-note
+
+ This tutorial can be used interactively with Google Colab! You can also click
+ :ref:`here <sphx_glr_download_{1}>` to run the Jupyter notebook locally.
+
+ .. image:: https://raw.githubusercontent.com/apache/web-data/main/images/utilities/colab_button.svg
+ :align: center
+ :target: {2}
+ :width: 300px
+
+.. rst-class:: sphx-glr-example-title
+
+.. _sphx_glr_{1}:
+
+"""
+
+# Google Colab allows opening .ipynb files on GitHub by appending the GitHub path to its own url.
+COLAB_URL_BASE = "https://colab.research.google.com/github"
+IPYTHON_GITHUB_BASE = "apache/tvm-site/blob/asf-site/docs/_downloads/"
+
+
+@monkey_patch("sphinx_gallery.gen_rst", "save_rst_example")
+def save_rst_example(example_rst, example_file, time_elapsed, memory_used, gallery_conf, real_func):
+ """Monkey-patch save_rst_example to include the "Open in Colab" button."""
+
+ # The url is the md5 hash of the notebook path.
+ example_fname = os.path.relpath(example_file, gallery_conf["src_dir"])
+ ref_fname = example_fname.replace(os.path.sep, "_")
+ notebook_path = example_fname[:-2] + "ipynb"
+ digest = md5(notebook_path.encode()).hexdigest()
+
+ # Fixed documentation versions must link to different (earlier) .ipynb notebooks.
+ colab_url = f"{COLAB_URL_BASE}/{IPYTHON_GITHUB_BASE}"
+ if "dev" not in version:
+ colab_url += version + "/"
+ colab_url += digest + "/" + os.path.basename(notebook_path)
+
+ new_header = COLAB_HTML_HEADER.format(example_fname, ref_fname, colab_url)
+ with patch("sphinx_gallery.gen_rst.EXAMPLE_HEADER", new_header):
+ real_func(example_rst, example_file, time_elapsed, memory_used, gallery_conf)
+
+
+@monkey_patch("sphinx_gallery.notebook", "rst2md")
+def rst2md(text, gallery_conf, target_dir, heading_levels, real_func):
+ """Monkey-patch rst2md to add limited include directive support to sphinx-gallery."""
+
+ include_re = re.compile(r"^([ \t]*)\.\. include::\s*(.+)\n", flags=re.M)
+
+ def load_include(match):
+ full_path = os.path.join(target_dir, match.group(2))
+ with open(full_path) as f:
+ lines = f.read()
+ indented = textwrap.indent(lines, match.group(1)) + "\n"
+ return indented
+
+ text = re.sub(include_re, load_include, text)
+
+ return real_func(text, gallery_conf, target_dir, heading_levels)
+
+
+INSTALL_TVM_DEV = f"""%%shell
+# Installs the latest dev build of TVM from PyPI. If you wish to build
+# from source, see https://tvm.apache.org/docs/install/from_source.html
+pip install apache-tvm --pre"""
+
+INSTALL_TVM_FIXED = f"""%%shell
+# Installs TVM version {version} from PyPI. If you wish to build
+# from source, see https://tvm.apache.org/docs/install/from_source.html
+pip install apache-tvm=={version}"""
+
+INSTALL_TVM_CUDA_DEV = f"""%%shell
+# Installs the latest dev build of TVM from PyPI, with CUDA enabled. To use this,
+# you must request a Google Colab instance with a GPU by going to Runtime ->
+# Change runtime type -> Hardware accelerator -> GPU. If you wish to build from
+# source, see see https://tvm.apache.org/docs/install/from_source.html
+pip install tlcpack-nightly-cu113 --pre -f https://tlcpack.ai/wheels"""
+
+INSTALL_TVM_CUDA_FIXED = f"""%%shell
+# Installs TVM version {version} from PyPI, with CUDA enabled. To use this,
+# you must request a Google Colab instance with a GPU by going to Runtime ->
+# Change runtime type -> Hardware accelerator -> GPU. If you wish to build from
+# source, see see https://tvm.apache.org/docs/install/from_source.html
+pip install apache-tvm-cu113=={version} -f https://tlcpack.ai/wheels"""
+
+
+@monkey_patch("sphinx_gallery.gen_rst", "jupyter_notebook")
+def jupyter_notebook(script_blocks, gallery_conf, target_dir, real_func):
+ """Monkey-patch sphinx-gallery to add a TVM import block to each IPython notebook.
+
+ If we had only one import block, we could skip the patching and just set first_notebook_cell.
+ However, how we import TVM depends on if we are using a fixed or dev version, and whether we
+ will use the GPU.
+
+ We install a CUDA version of TVM if and only if the tutorial calls "cuda" as a function. It
+ would be cleaner specify this with a config flag, but sphinx-gallery does not support this.
+ """
+
+ call_cuda_re = re.compile(r"cuda\([0-9]*\)", re.IGNORECASE)
Review Comment:
could you make this a constant with a comment describing the expected line it's looking for? Also, I'm wondering if we should look for something more explicit, like a tag at the top saying:
```
# Requires: cuda115
```
or something
##########
docs/conf.py:
##########
@@ -84,6 +86,148 @@ def git_describe_version(original_version):
version = git_describe_version(tvm.__version__)
release = version
+
+def monkey_patch(module_name, func_name):
+ """Helper function for monkey-patching library functions.
+
+ Used to modify a few sphinx-gallery behaviors to make the "Open in Colab"
+ button work correctly. Should be used as a decorator with arguments.
+ """
+ module = import_module(module_name)
+ original_func = getattr(module, func_name)
+
+ def decorator(function):
+ updated_func = partial(function, real_func=original_func)
+ setattr(module, func_name, updated_func)
+ return updated_func
+
+ return decorator
+
+
+# This header replaces the default sphinx-gallery one in sphinx_gallery/gen_rst.py.
+COLAB_HTML_HEADER = """
+.. DO NOT EDIT. THIS FILE WAS AUTOMATICALLY GENERATED BY
+.. TVM'S MONKEY-PATCHED VERSION OF SPHINX-GALLERY. TO MAKE
+.. CHANGES, EDIT THE SOURCE PYTHON FILE:
+.. "{0}"
+
+.. only:: html
+
+ .. note::
+ :class: sphx-glr-download-link-note
+
+ This tutorial can be used interactively with Google Colab! You can also click
+ :ref:`here <sphx_glr_download_{1}>` to run the Jupyter notebook locally.
+
+ .. image:: https://raw.githubusercontent.com/apache/web-data/main/images/utilities/colab_button.svg
+ :align: center
+ :target: {2}
+ :width: 300px
+
+.. rst-class:: sphx-glr-example-title
+
+.. _sphx_glr_{1}:
+
+"""
+
+# Google Colab allows opening .ipynb files on GitHub by appending the GitHub path to its own url.
+COLAB_URL_BASE = "https://colab.research.google.com/github"
+IPYTHON_GITHUB_BASE = "apache/tvm-site/blob/asf-site/docs/_downloads/"
Review Comment:
can you comment this one?
##########
docs/conf.py:
##########
@@ -84,6 +86,148 @@ def git_describe_version(original_version):
version = git_describe_version(tvm.__version__)
release = version
+
+def monkey_patch(module_name, func_name):
+ """Helper function for monkey-patching library functions.
+
+ Used to modify a few sphinx-gallery behaviors to make the "Open in Colab"
+ button work correctly. Should be used as a decorator with arguments.
+ """
+ module = import_module(module_name)
+ original_func = getattr(module, func_name)
+
+ def decorator(function):
+ updated_func = partial(function, real_func=original_func)
+ setattr(module, func_name, updated_func)
+ return updated_func
+
+ return decorator
+
+
+# This header replaces the default sphinx-gallery one in sphinx_gallery/gen_rst.py.
+COLAB_HTML_HEADER = """
+.. DO NOT EDIT. THIS FILE WAS AUTOMATICALLY GENERATED BY
+.. TVM'S MONKEY-PATCHED VERSION OF SPHINX-GALLERY. TO MAKE
+.. CHANGES, EDIT THE SOURCE PYTHON FILE:
+.. "{0}"
+
+.. only:: html
+
+ .. note::
+ :class: sphx-glr-download-link-note
+
+ This tutorial can be used interactively with Google Colab! You can also click
+ :ref:`here <sphx_glr_download_{1}>` to run the Jupyter notebook locally.
+
+ .. image:: https://raw.githubusercontent.com/apache/web-data/main/images/utilities/colab_button.svg
+ :align: center
+ :target: {2}
+ :width: 300px
+
+.. rst-class:: sphx-glr-example-title
+
+.. _sphx_glr_{1}:
+
+"""
+
+# Google Colab allows opening .ipynb files on GitHub by appending the GitHub path to its own url.
+COLAB_URL_BASE = "https://colab.research.google.com/github"
+IPYTHON_GITHUB_BASE = "apache/tvm-site/blob/asf-site/docs/_downloads/"
+
+
+@monkey_patch("sphinx_gallery.gen_rst", "save_rst_example")
+def save_rst_example(example_rst, example_file, time_elapsed, memory_used, gallery_conf, real_func):
+ """Monkey-patch save_rst_example to include the "Open in Colab" button."""
+
+ # The url is the md5 hash of the notebook path.
+ example_fname = os.path.relpath(example_file, gallery_conf["src_dir"])
+ ref_fname = example_fname.replace(os.path.sep, "_")
+ notebook_path = example_fname[:-2] + "ipynb"
+ digest = md5(notebook_path.encode()).hexdigest()
+
+ # Fixed documentation versions must link to different (earlier) .ipynb notebooks.
+ colab_url = f"{COLAB_URL_BASE}/{IPYTHON_GITHUB_BASE}"
+ if "dev" not in version:
+ colab_url += version + "/"
+ colab_url += digest + "/" + os.path.basename(notebook_path)
+
+ new_header = COLAB_HTML_HEADER.format(example_fname, ref_fname, colab_url)
+ with patch("sphinx_gallery.gen_rst.EXAMPLE_HEADER", new_header):
+ real_func(example_rst, example_file, time_elapsed, memory_used, gallery_conf)
+
+
+@monkey_patch("sphinx_gallery.notebook", "rst2md")
+def rst2md(text, gallery_conf, target_dir, heading_levels, real_func):
+ """Monkey-patch rst2md to add limited include directive support to sphinx-gallery."""
+
+ include_re = re.compile(r"^([ \t]*)\.\. include::\s*(.+)\n", flags=re.M)
+
+ def load_include(match):
+ full_path = os.path.join(target_dir, match.group(2))
+ with open(full_path) as f:
+ lines = f.read()
+ indented = textwrap.indent(lines, match.group(1)) + "\n"
+ return indented
+
+ text = re.sub(include_re, load_include, text)
+
+ return real_func(text, gallery_conf, target_dir, heading_levels)
+
+
+INSTALL_TVM_DEV = f"""%%shell
Review Comment:
one thing i kind of like to do is
```
"""\
%%shell
```
then it's a bit harder to forget to see the "%%shell" part
##########
gallery/how_to/compile_models/from_coreml.py:
##########
@@ -23,13 +23,12 @@
This article is an introductory tutorial to deploy CoreML models with Relay.
-For us to begin with, coremltools module is required to be installed.
-
-A quick solution is to install via pip
+To begin, we must install coremltools:
.. code-block:: bash
- pip install -U coremltools --user
Review Comment:
i'm curious, does `--user` not work with colab? It's not the worst thing to tell folks new to managing python venvs.
##########
gallery/how_to/work_with_microtvm/micro_tflite.py:
##########
@@ -292,7 +217,18 @@
if use_physical_hw:
template_project_path = pathlib.Path(tvm.micro.get_microtvm_template_projects("zephyr"))
- project_options = {"project_type": "host_driven", "board": BOARD, "serial_number": SERIAL}
+ project_options = {
+ "project_type": "host_driven",
+ "board": BOARD,
+ "serial_number": SERIAL,
+ "config_main_stack_size": 4096,
+ "cmsis_path": "/content/cmsis"
Review Comment:
add parens around the ternary, here and below
##########
gallery/how_to/work_with_microtvm/micro_aot.py:
##########
@@ -139,6 +162,12 @@
"board": BOARD,
"serial_number": SERIAL,
"config_main_stack_size": 4096,
+ "cmsis_path": "/content/cmsis"
Review Comment:
add parens around the ternary, here and below
##########
gallery/how_to/work_with_microtvm/install_cmsis.rst:
##########
@@ -0,0 +1,30 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+Install CMSIS-NN
Review Comment:
should we add some clarifying text that this is for CoLab only, in case folks run across it as a standalone doc? or is it not linked from the tutorial index and won't be found through auto-indexing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org