You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 03:29:19 UTC
[GitHub] [airflow] uranusjr commented on a change in pull request #20692: fix deprecation messages for SFTPHook
uranusjr commented on a change in pull request #20692:
URL: https://github.com/apache/airflow/pull/20692#discussion_r779277322
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -102,14 +102,14 @@ def __init__(
extra_options = conn.extra_dejson
# For backward compatibility
- # TODO: remove in Airflow 2.1
+ # TODO: remove in next major provider release
Review comment:
```suggestion
# TODO: remove in the next major provider release.
```
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -121,7 +121,7 @@ def __init__(
warnings.warn(
'Extra option `ignore_hostkey_verification` is deprecated.'
'Please use `no_host_key_check` instead.'
- 'This option will be removed in Airflow 2.1',
+ 'This option will be removed in future release',
Review comment:
```suggestion
'This option will be removed in a future release.',
```
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -102,14 +102,14 @@ def __init__(
extra_options = conn.extra_dejson
# For backward compatibility
- # TODO: remove in Airflow 2.1
+ # TODO: remove in next major provider release
if 'private_key_pass' in extra_options:
warnings.warn(
'Extra option `private_key_pass` is deprecated.'
'Please use `private_key_passphrase` instead.'
'`private_key_passphrase` will precede if both options are specified.'
- 'The old option `private_key_pass` will be removed in Airflow 2.1',
+ 'The old option `private_key_pass` will be removed in future release',
Review comment:
```suggestion
'The old option `private_key_pass` will be removed in a future release.',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org