You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Kočí (Created JIRA)" <de...@myfaces.apache.org> on 2012/03/10 16:12:57 UTC
[jira] [Created] (MYFACES-3497) [perf] Improve EventHandler
[perf] Improve EventHandler
---------------------------
Key: MYFACES-3497
URL: https://issues.apache.org/jira/browse/MYFACES-3497
Project: MyFaces Core
Issue Type: Improvement
Reporter: Martin Kočí
Priority: Minor
org.apache.myfaces.view.facelets.tag.jsf.core.EventHandler
* cache created MethodExpressions (same as in MYFACES-3160)
* if f:event type="" is literal, cache resulting class
* review implementation of EventHandler.Listener.processEvent(ComponentSystemEvent): uses "void" El method invocation to detect if method exists - spec requires this but maybe better solution exists
* ....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3497) [perf] Improve EventHandler
Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228577#comment-13228577 ]
Leonardo Uribe commented on MYFACES-3497:
-----------------------------------------
* created methodExpressions are already cached at TagAttributeImpl. No need to do something additional in this part
* it is reasonable to cache that result, because once calculated it will not change.
* Suggestions are welcome. Note the same trick is used in other places like javax.faces.event.MethodExpressionActionListener. Checking this one, I notice in EL 2.2 there exists a new method called boolean isParmetersProvided() (the spell bug is intentional).
> [perf] Improve EventHandler
> ---------------------------
>
> Key: MYFACES-3497
> URL: https://issues.apache.org/jira/browse/MYFACES-3497
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Martin Kočí
> Priority: Minor
>
> org.apache.myfaces.view.facelets.tag.jsf.core.EventHandler
> * cache created MethodExpressions (same as in MYFACES-3160)
> * if f:event type="" is literal, cache resulting class
> * review implementation of EventHandler.Listener.processEvent(ComponentSystemEvent): uses "void" El method invocation to detect if method exists - spec requires this but maybe better solution exists
> * ....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira