You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org> on 2007/06/12 13:08:26 UTC

[jira] Created: (CXF-723) The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information

The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information
-------------------------------------------------------------------------------------------------------------------------

                 Key: CXF-723
                 URL: https://issues.apache.org/jira/browse/CXF-723
             Project: CXF
          Issue Type: Bug
          Components: WS-* Components
            Reporter: Colm O hEigeartaigh
            Priority: Minor


Both WSS4JInInterceptor and WSS4JOutInterceptor give the user the ability to see
how much system time is spent in each phase of processing the message. However,
there are some flaws with the way this is implemented:

WSS4JOutInterceptor:

1) The "t3" variable is superfluous, as is the log message '"request to CXF= " + (t3 - t2)'
(which will always be ~0).

WSS4JInInterceptor:

1) The "t3" variable is defined as 0, which means that the log message 
'" request to CXF= " + (t3 - t2)' gives a (wildly) incorrect result, eg;

FINE: Receive request: total= 47 request preparation= 0 request processing= 47 
request to CXF= -1181643784031 header, cert verify, timestamp= 1181643784031

The same applies for the log message '" header, cert verify, timestamp= " + (t4 - t3)'

Please see the attached patch for a fix for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-723) The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-723.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

Patch applied.   Thanks.


> The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-723
>                 URL: https://issues.apache.org/jira/browse/CXF-723
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>            Reporter: Colm O hEigeartaigh
>            Assignee: Daniel Kulp
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: logging.patch
>
>
> Both WSS4JInInterceptor and WSS4JOutInterceptor give the user the ability to see
> how much system time is spent in each phase of processing the message. However,
> there are some flaws with the way this is implemented:
> WSS4JOutInterceptor:
> 1) The "t3" variable is superfluous, as is the log message '"request to CXF= " + (t3 - t2)'
> (which will always be ~0).
> WSS4JInInterceptor:
> 1) The "t3" variable is defined as 0, which means that the log message 
> '" request to CXF= " + (t3 - t2)' gives a (wildly) incorrect result, eg;
> FINE: Receive request: total= 47 request preparation= 0 request processing= 47 
> request to CXF= -1181643784031 header, cert verify, timestamp= 1181643784031
> The same applies for the log message '" header, cert verify, timestamp= " + (t4 - t3)'
> Please see the attached patch for a fix for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CXF-723) The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp reassigned CXF-723:
-------------------------------

    Assignee: Daniel Kulp

> The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-723
>                 URL: https://issues.apache.org/jira/browse/CXF-723
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>            Reporter: Colm O hEigeartaigh
>            Assignee: Daniel Kulp
>            Priority: Minor
>         Attachments: logging.patch
>
>
> Both WSS4JInInterceptor and WSS4JOutInterceptor give the user the ability to see
> how much system time is spent in each phase of processing the message. However,
> there are some flaws with the way this is implemented:
> WSS4JOutInterceptor:
> 1) The "t3" variable is superfluous, as is the log message '"request to CXF= " + (t3 - t2)'
> (which will always be ~0).
> WSS4JInInterceptor:
> 1) The "t3" variable is defined as 0, which means that the log message 
> '" request to CXF= " + (t3 - t2)' gives a (wildly) incorrect result, eg;
> FINE: Receive request: total= 47 request preparation= 0 request processing= 47 
> request to CXF= -1181643784031 header, cert verify, timestamp= 1181643784031
> The same applies for the log message '" header, cert verify, timestamp= " + (t4 - t3)'
> Please see the attached patch for a fix for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-723) The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information

Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm O hEigeartaigh updated CXF-723:
------------------------------------

    Attachment: logging.patch

> The "time" logging in both the WSS4JInInterceptor and the WSS4JOutInterceptor contains incorrect or redundant information
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-723
>                 URL: https://issues.apache.org/jira/browse/CXF-723
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>            Reporter: Colm O hEigeartaigh
>            Priority: Minor
>         Attachments: logging.patch
>
>
> Both WSS4JInInterceptor and WSS4JOutInterceptor give the user the ability to see
> how much system time is spent in each phase of processing the message. However,
> there are some flaws with the way this is implemented:
> WSS4JOutInterceptor:
> 1) The "t3" variable is superfluous, as is the log message '"request to CXF= " + (t3 - t2)'
> (which will always be ~0).
> WSS4JInInterceptor:
> 1) The "t3" variable is defined as 0, which means that the log message 
> '" request to CXF= " + (t3 - t2)' gives a (wildly) incorrect result, eg;
> FINE: Receive request: total= 47 request preparation= 0 request processing= 47 
> request to CXF= -1181643784031 header, cert verify, timestamp= 1181643784031
> The same applies for the log message '" header, cert verify, timestamp= " + (t4 - t3)'
> Please see the attached patch for a fix for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.