You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2014/02/06 04:46:10 UTC

[jira] [Commented] (SOLR-5682) Make the admin InfoHandler more pluggable / derivable

    [ https://issues.apache.org/jira/browse/SOLR-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892995#comment-13892995 ] 

Mark Miller commented on SOLR-5682:
-----------------------------------

Kind of an interesting interaction here...SolrInfoMBeanTest fails because of the private static classes in InfoHandlerTest.

I've made those classes public to get that test passing.

> Make the admin InfoHandler more pluggable / derivable
> -----------------------------------------------------
>
>                 Key: SOLR-5682
>                 URL: https://issues.apache.org/jira/browse/SOLR-5682
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gregory Chanan
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 5.0, 4.7
>
>         Attachments: SOLR-5682.patch, SOLR-5682v2.patch
>
>
> As of SOLR-5556 a user can specify the class of the admin InfoHandler, but can't easily override the individual handlers that it provides (the PropertiesRequestHandler, LoggingHandler, ThreadDumpHandler, SystemInfoHandler).
> Contrast this with say, the AdminHandlers, where a user can provide his/her own implementations of the underlying request handlers easily.
> I've run into this limitation in the following setup: I use derived versions of the various AdminHandlers, and would like to use the same implementations for the InfoHandler.  I can do this by deriving from InfoHandler, but then I'd need to duplicate the handleRequestBody dispatching code.  That's doable, but not as nice as what the AdminHandlers provides.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org