[GitHub] [iceberg] prodeezy commented on a change in pull request #1288: Update scan planning with DeleteFiles in each task

[GitBox <gi...@apache.org>]

prodeezy commented on a change in pull request #1288:
URL: https://github.com/apache/iceberg/pull/1288#discussion_r465096971



##########
File path: core/src/main/java/org/apache/iceberg/BaseFileScanTask.java
##########
@@ -31,14 +31,17 @@
 
 class BaseFileScanTask implements FileScanTask {
   private final DataFile file;
+  private final DeleteFile[] deletes;
   private final String schemaString;
   private final String specString;
   private final ResidualEvaluator residuals;
 
   private transient PartitionSpec spec = null;
 
-  BaseFileScanTask(DataFile file, String schemaString, String specString, ResidualEvaluator residuals) {
+  BaseFileScanTask(DataFile file, DeleteFile[] deletes, String schemaString, String specString,

Review comment:
       This is mostly for my understanding: is `DeleteFile[] deletes`  a mandatory builder param now for file scan tasks? If not, from a v1 / v2 compatibility standpoint would it make sense to add an overloaded constructor?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org