You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Xinyu Liu (JIRA)" <ji...@apache.org> on 2017/11/21 19:35:00 UTC

[jira] [Commented] (SAMZA-1354) Pass in typed control message into EndOfStreamManager.update() and WatermarkManager.update()

    [ https://issues.apache.org/jira/browse/SAMZA-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261361#comment-16261361 ] 

Xinyu Liu commented on SAMZA-1354:
----------------------------------

This is addressed in SAMZA-1386. Close the ticket.

> Pass in typed control message into EndOfStreamManager.update() and WatermarkManager.update()
> --------------------------------------------------------------------------------------------
>
>                 Key: SAMZA-1354
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1354
>             Project: Samza
>          Issue Type: Task
>    Affects Versions: 0.14.0
>            Reporter: Xinyu Liu
>            Assignee: Xinyu Liu
>             Fix For: 0.14.0
>
>
> From Yi's review feedback: Right now EndOfStreamManager.update() and WatermarkManager.update() takes in IncomingMessageEnvelope. It's better to pass in typed control message and ssp to it to avoid type cast.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)