[jira] [Commented] (THRIFT-2491) unable to import generated ThriftTest service

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976720#comment-13976720 ] 

ASF GitHub Bot commented on THRIFT-2491:
----------------------------------------

GitHub user apesternikov opened a pull request:

    https://github.com/apache/thrift/pull/105

    add _ to generated filename if it ends with _test.go

    THRIFT-2491
    add _ to file names matching *_test.go so
    thrift_test.go -> thrift_test_.go


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apesternikov/thrift go_test_service_name

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
    
----
commit f2e7186ca8d63f407dba0c56ee51afd6405926ba
Author: Aleksey Pesternikov <ap...@alekseys-mbp.att.net>
Date:   2014-04-22T12:48:14Z

    add _ to generated filename if it ends with _test.go

----


> unable to import generated ThriftTest service
> ---------------------------------------------
>
>                 Key: THRIFT-2491
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2491
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Compiler
>            Reporter: Aleksey Pesternikov
>            Priority: Minor
>
> IDL compiler uses service name converted from camel case to underscores as a file name. service ThriftTest {} goes into thrift_test.go, which is not being compiled since the file match *_test.go mask.



--
This message was sent by Atlassian JIRA
(v6.2#6252)