You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/08/26 03:13:06 UTC

Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.


Bugs: AMBARI-12872
    https://issues.apache.org/jira/browse/AMBARI-12872


Repository: ambari


Description
-------

Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS


Diffs
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
  ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 

Diff: https://reviews.apache.org/r/37782/diff/


Testing
-------

Tested on centos6 cluster with SQLAnywhere as database

----------------------------------------------------------------------
Ran 231 tests in 6.493s

OK
----------------------------------------------------------------------
Total run:784
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.

> On Aug. 26, 2015, 8:17 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml, line 40
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052829#file1052829line40>
> >
> >     We dont need to make this a configurable property and can decide where to place the native libraries like we do for Oozie
> >     
> >     /usr/hdp/current/oozie-server/libext/sajdbc4.jar
> >     /usr/hdp/current/oozie-server/libext/native/lib64/dblgen17.res
> >     /usr/hdp/current/oozie-server/libext/native/lib64/libdbicu17_r.so.1
> >     /usr/hdp/current/oozie-server/libext/native/lib64/libdbicudt17.so.1
> >     /usr/hdp/current/oozie-server/libext/native/lib64/libdbjdbc17.so.1
> >     /usr/hdp/current/oozie-server/libext/native/lib64/libdbtasks17_r.so.1
> >     /usr/hdp/current/oozie-server/libext/native/lib64/libdbicu17_r.so
> >     /usr/hdp/current/oozie-server/libext/native/lib64/libdbicudt17.so /usr/hdp/current/oozie-server/libext/native/lib64/libdbjdbc17.so

In latest patch we are copying native libraries at this path /usr/hdp/current/{component}/native/lib64


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96514
-----------------------------------------------------------


On Aug. 27, 2015, 2 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96514
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml (line 40)
<https://reviews.apache.org/r/37782/#comment151941>

    We dont need to make this a configurable property and can decide where to place the native libraries like we do for Oozie
    
    /usr/hdp/current/oozie-server/libext/sajdbc4.jar
    /usr/hdp/current/oozie-server/libext/native/lib64/dblgen17.res
    /usr/hdp/current/oozie-server/libext/native/lib64/libdbicu17_r.so.1
    /usr/hdp/current/oozie-server/libext/native/lib64/libdbicudt17.so.1
    /usr/hdp/current/oozie-server/libext/native/lib64/libdbjdbc17.so.1
    /usr/hdp/current/oozie-server/libext/native/lib64/libdbtasks17_r.so.1
    /usr/hdp/current/oozie-server/libext/native/lib64/libdbicu17_r.so
    /usr/hdp/current/oozie-server/libext/native/lib64/libdbicudt17.so /usr/hdp/current/oozie-server/libext/native/lib64/libdbjdbc17.so


- Jayush Luniya


On Aug. 26, 2015, 5:54 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
>   ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.

> On Aug. 26, 2015, 7:42 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml, line 42
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052829#file1052829line42>
> >
> >     Does this need a default value?

In latest patch removing this property


> On Aug. 26, 2015, 7:42 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml, line 51
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052821#file1052821line51>
> >
> >     Does this need a default value?

In latest patch removing this property


> On Aug. 26, 2015, 7:42 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py, line 59
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052823#file1052823line59>
> >
> >     Why is this not checking the pid file?

Current implemenation of RANGER_KMS does not create a PID file.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96583
-----------------------------------------------------------


On Aug. 27, 2015, 2 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96583
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml (line 51)
<https://reviews.apache.org/r/37782/#comment152139>

    Does this need a default value?



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py (line 59)
<https://reviews.apache.org/r/37782/#comment152140>

    Why is this not checking the pid file?



ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml (line 42)
<https://reviews.apache.org/r/37782/#comment152142>

    Does this need a default value?


- Alejandro Fernandez


On Aug. 26, 2015, 5:54 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
>   ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96516
-----------------------------------------------------------


You should also validate that everything works when SQLA server is installed on a different host (i.e. SQLA bits are not installed on the host so you dont have /opt/sqlanywhere17/lib64 folder).

- Jayush Luniya


On Aug. 26, 2015, 5:54 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
>   ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.

> On Aug. 26, 2015, 8:07 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, line 164
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052818#file1052818line164>
> >
> >     There is an inherent assumption here that there is a directory on the host where the native libraries for SQLA reside. How are the native libraries going to be placed at this location?

Ok, we will remove 'ld_library_path' config property and use this path format("{tmp_dir}/sqla-client-jdbc/native/lib64")


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96511
-----------------------------------------------------------


On Aug. 26, 2015, 5:54 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
>   ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On Aug. 26, 2015, 8:07 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, line 164
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052818#file1052818line164>
> >
> >     There is an inherent assumption here that there is a directory on the host where the native libraries for SQLA reside. How are the native libraries going to be placed at this location?
> 
> Gautam Borad wrote:
>     Ok, we will remove 'ld_library_path' config property and use this path format("{tmp_dir}/sqla-client-jdbc/native/lib64")

It would be better to copy over the native libs to a path in the ranger service folder as the tmp_dir is ambari-agent temp directory and might be cleaned up.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96511
-----------------------------------------------------------


On Aug. 26, 2015, 5:54 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
>   ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.

> On Aug. 26, 2015, 8:07 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, line 164
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052818#file1052818line164>
> >
> >     There is an inherent assumption here that there is a directory on the host where the native libraries for SQLA reside. How are the native libraries going to be placed at this location?
> 
> Gautam Borad wrote:
>     Ok, we will remove 'ld_library_path' config property and use this path format("{tmp_dir}/sqla-client-jdbc/native/lib64")
> 
> Jayush Luniya wrote:
>     It would be better to copy over the native libs to a path in the ranger service folder as the tmp_dir is ambari-agent temp directory and might be cleaned up.

In latest patch we are copying native libraries at this path /usr/hdp/current/{component}/native/lib64 and removing property ld_library_path from Ranger/Ranger_kms


> On Aug. 26, 2015, 8:07 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, line 532
> > <https://reviews.apache.org/r/37782/diff/2/?file=1052815#file1052815line532>
> >
> >     This solution deviates from how this works for Hive/Oozie. 
> >     
> >     For SQLA, the user will be running the following 
> >     ambari-server setup --jdbc-db=sqlanywhere --jdbc-driver=/usr/share/sqla-client-jdbc.tar.gz
> >     
> >     sqla-client-jdbc.tar.gz tarball contains the JDBC driver, JARs and native library files. 
> >     
> >     When the ambari-server setup command is executed above, ambari-agents can download the tarballs from the ambari-server and then the service package scripts can lay down the JDBC JAR and native libraries to appropriate location and configure the service accordingly. 
> >     
> >     For reference, please take a look at:
> >     
> >     https://reviews.apache.org/r/37576

In latest patch, for Ranger and Ranger KMS using sqla-client-jdbc.tar.gz tarball implementation same as Hive.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96511
-----------------------------------------------------------


On Aug. 27, 2015, 2 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96511
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 532)
<https://reviews.apache.org/r/37782/#comment151939>

    This solution deviates from how this works for Hive/Oozie. 
    
    For SQLA, the user will be running the following 
    ambari-server setup --jdbc-db=sqlanywhere --jdbc-driver=/usr/share/sqla-client-jdbc.tar.gz
    
    sqla-client-jdbc.tar.gz tarball contains the JDBC driver, JARs and native library files. 
    
    When the ambari-server setup command is executed above, ambari-agents can download the tarballs from the ambari-server and then the service package scripts can lay down the JDBC JAR and native libraries to appropriate location and configure the service accordingly. 
    
    For reference, please take a look at:
    
    https://reviews.apache.org/r/37576



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line 164)
<https://reviews.apache.org/r/37782/#comment151938>

    There is an inherent assumption here that there is a directory on the host where the native libraries for SQLA reside. How are the native libraries going to be placed at this location?


- Jayush Luniya


On Aug. 26, 2015, 5:54 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
>   ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.

> On Aug. 27, 2015, 7:21 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py, line 200
> > <https://reviews.apache.org/r/37782/diff/3/?file=1055851#file1055851line200>
> >
> >     The JDBC symlink on the server would be http://<ambari-servername>:8080/resources/sqlanywhere-jdbc-driver.tar.gz. The file http://<ambari-servername>:8080/resources/sqlanywhere-jdbc-driver.jar should not exist. If you have this file on ambari server from the old install, please delete this symbolic link and try the patch again. Based on what I see in the patch I suspect that there would be more failures.

Fixed the file name. Also please note, have disabled audit-to-db from code, if DB Flavor is SQLA.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96737
-----------------------------------------------------------


On Aug. 27, 2015, 2 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96737
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py (line 200)
<https://reviews.apache.org/r/37782/#comment152378>

    The JDBC symlink on the server would be http://<ambari-servername>:8080/resources/sqlanywhere-jdbc-driver.tar.gz. The file http://<ambari-servername>:8080/resources/sqlanywhere-jdbc-driver.jar should not exist. If you have this file on ambari server from the old install, please delete this symbolic link and try the patch again. Based on what I see in the patch I suspect that there would be more failures.


- Jayush Luniya


On Aug. 27, 2015, 2 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96704
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 165)
<https://reviews.apache.org/r/37782/#comment152335>

    Why not just use cp -f?


- Alejandro Fernandez


On Aug. 27, 2015, 2 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 2 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96804
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Aug. 28, 2015, midnight, Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, midnight)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96803
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Aug. 28, 2015, midnight, Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, midnight)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/#review96807
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Aug. 28, 2015, midnight, Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37782/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, midnight)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12872
>     https://issues.apache.org/jira/browse/AMBARI-12872
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 
> 
> Diff: https://reviews.apache.org/r/37782/diff/
> 
> 
> Testing
> -------
> 
> Tested on centos6 cluster with SQLAnywhere as database
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.493s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/
-----------------------------------------------------------

(Updated Aug. 28, 2015, midnight)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.


Changes
-------

Address review request comment and ignore connector jar if db flavor is SQLA.


Bugs: AMBARI-12872
    https://issues.apache.org/jira/browse/AMBARI-12872


Repository: ambari


Description
-------

Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 

Diff: https://reviews.apache.org/r/37782/diff/


Testing
-------

Tested on centos6 cluster with SQLAnywhere as database

----------------------------------------------------------------------
Ran 231 tests in 6.493s

OK
----------------------------------------------------------------------
Total run:784
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 2 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Vitalyi Brodetskyi, Velmurugan Periasamy, and Yusaku Sako.


Changes
-------

Updated patch to take care of Jayush comments

----------------------------------------------------------------------
Ran 261 tests in 6.354s

OK
----------------------------------------------------------------------
Total run:814
Total errors:0
Total failures:0
OK


Bugs: AMBARI-12872
    https://issues.apache.org/jira/browse/AMBARI-12872


Repository: ambari


Description
-------

Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py cf40a75 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dad 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd00 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf1 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790e 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e7 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b1 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4 

Diff: https://reviews.apache.org/r/37782/diff/


Testing
-------

Tested on centos6 cluster with SQLAnywhere as database

----------------------------------------------------------------------
Ran 231 tests in 6.493s

OK
----------------------------------------------------------------------
Total run:784
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 5:54 a.m.)


Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.


Bugs: AMBARI-12872
    https://issues.apache.org/jira/browse/AMBARI-12872


Repository: ambari


Description
-------

Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS


Diffs
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
  ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 

Diff: https://reviews.apache.org/r/37782/diff/


Testing
-------

Tested on centos6 cluster with SQLAnywhere as database

----------------------------------------------------------------------
Ran 231 tests in 6.493s

OK
----------------------------------------------------------------------
Total run:784
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


Re: Review Request 37782: AMBARI-12872 : Add SQL Anywhere database support for Ranger and Ranger KMS

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37782/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 1:14 a.m.)


Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.


Bugs: AMBARI-12872
    https://issues.apache.org/jira/browse/AMBARI-12872


Repository: ambari


Description
-------

Add support for SQL Anywhere in BE ( ambari-server ) for Ranger and Ranger KMS


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d515dadc6b187bc57a6fbb90d9f38d217e1663f4 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4d8ac0b353e8e27abc13f0434f5297880b0a8b45 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5787e6a9767dafeaf12f5e9901c97d82b8 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py 455bd0041cc29f10587127cab2d61ed71b34acd8 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 733caf10b7b83a38231216dbe91be7ac542450f6 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 8e84587d37241b82cdea582c271b7a8f9bee851e 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 8ad2627dc8b4cf3dfd4625010ce022607427962d 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py de7726a2bccb3299ffe39c5b2b1e797b7935c33c 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml b12f549061bf2e2c39f8097923745d8764471b20 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 1ed28c4b743ea6860903daa419510fbe36a84b84 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 5c3790ebf5c06c9f5494f3463724f1d21026ace1 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py 5c4d7e75fd00ac0232946a1d8afe7f515e9d42b6 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 1dbf3b189c058f7428575dc1e62661f6c6adadd4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py e7d524d3cdf967bcdc92814a62b1696931ae9243 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 9857d03e48a60c1733a8cde77b2ab2f1cdfa0c9f 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 6878db4aede54194dc9078d8d053f77fdfd51970 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml dd6270c11b794d1c45e13b3c5592f231265b88d1 
  ambari-web/app/data/HDP2.3/site_properties.js 2d6227047280126d4e81728542a46d0b2bf32216 

Diff: https://reviews.apache.org/r/37782/diff/


Testing
-------

Tested on centos6 cluster with SQLAnywhere as database

----------------------------------------------------------------------
Ran 231 tests in 6.493s

OK
----------------------------------------------------------------------
Total run:784
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad