[jira] [Commented] (SOLR-4458) accespt uppercase ASC and DESC as sort orders

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584815#comment-13584815 ] 

Hoss Man commented on SOLR-4458:
--------------------------------

Shawn: thanks for the patch, but if you try running "ant precommit" you should see the build fail because your patch uses a "forbidden api" (it depends on the default locale and will behave differnetly on differnet systems -- it needs to use the ROOT Locale)

mind tweaking that and then updating a few tests so they use both the upercase nad lowercase versions?

bq. ... the original input will be in the echoParams output. I did not attempt to address that.

i don't think it would make any sense to try and change the actual params, i'm not even sure that that would mean.

                
> accespt uppercase ASC and DESC as sort orders
> ---------------------------------------------
>
>                 Key: SOLR-4458
>                 URL: https://issues.apache.org/jira/browse/SOLR-4458
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Priority: Minor
>         Attachments: SOLR-4458.patch
>
>
> at least one user has gotten confused by doing a serach like this...
> http://localhost:8983/solr/shop/select/?indent=on&facet=true&sort=prijs%20ASC&start=0&rows=18&fl=id,prijs,prijseenhe
> id,artikelgroep&q=*:*&facet.field=artikelgroep&facet.mincount=1
> and getting this error...
> {noformat}
> Can't determine Sort Order: 'prijs ASC', pos=5
> {noformat}
> ... i can't think of any reason why it would be bad to accept both uppercase and lowercase versions of "asc" and "desc"
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201302.mbox/%3C0A03B892A1F8E14C8D9E8DCB8320052804F30FDC@EX2010-MAIL1.WIZARD.PVT%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org