You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by sandeshh <gi...@git.apache.org> on 2016/06/07 23:32:28 UTC
[GitHub] apex-core pull request #349: APEXCORE-470
GitHub user sandeshh opened a pull request:
https://github.com/apache/apex-core/pull/349
APEXCORE-470
1. Added the new API - setOperatorAttribute
2. updated the unit tests,
3. marked "setAttribute(Operator..." as deprecated
@PramodSSImmaneni please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandeshh/apex-core APEXCORE-470
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-core/pull/349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #349
----
commit bcd3426ba65f5291925dedb1e4fdfef4c80096ed
Author: sandeshh <sa...@gmail.com>
Date: 2016-06-07T23:27:26Z
APEXCORE-470 - Added the new api setOperatorAttribute and updated the tests, also marked setAttribute(Operator... as deprecated
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #349: APEXCORE-470 New API in DAG - setOperatorAttrib...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67067785
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract <T> void setAttribute(Attribute<T> key, T value);
/**
- * <p>setAttribute.</p>
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
+ @Deprecated
public abstract <T> void setAttribute(Operator operator, Attribute<T> key, T value);
/**
+ * Set an attribute on the operator.
--- End diff --
for an operator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #349: APEXCORE-470 New API in DAG - setOperatorAttrib...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67068235
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract <T> void setAttribute(Attribute<T> key, T value);
/**
- * <p>setAttribute.</p>
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
--- End diff --
How about using javadoc deprecation as well
https://docs.oracle.com/javase/tutorial/java/annotations/predefined.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #349: APEXCORE-470 New API in DAG - setOperatorAttrib...
Posted by sandeshh <gi...@git.apache.org>.
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67238893
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract <T> void setAttribute(Attribute<T> key, T value);
/**
- * <p>setAttribute.</p>
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
--- End diff --
Addressed all the review comments. Travis builds fails randomly. I just updated JavaDoc, so it shouldn't have updated the Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #349: APEXCORE-470 New API in DAG - setOperatorAttrib...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/apex-core/pull/349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #349: APEXCORE-470 New API in DAG - setOperatorAttrib...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r67067938
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -236,11 +236,22 @@
public abstract <T> void setAttribute(Attribute<T> key, T value);
/**
- * <p>setAttribute.</p>
+ *
+ * Use {@link #setOperatorAttribute} instead
*/
+ @Deprecated
public abstract <T> void setAttribute(Operator operator, Attribute<T> key, T value);
/**
+ * Set an attribute on the operator.
+ * @param <T> Object type of the attribute.
--- End diff --
The value type
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #349: APEXCORE-470 New API in DAG - setOperatorAttrib...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/349#discussion_r66172343
--- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
@@ -238,9 +238,15 @@
/**
* <p>setAttribute.</p>
*/
+ @Deprecated
public abstract <T> void setAttribute(Operator operator, Attribute<T> key, T value);
/**
+ * <p>setOperatorAttribute.</p>
--- End diff --
javadoc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---