You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2016/07/24 22:59:52 UTC

[GitHub] spark pull request #13620: [SPARK-15590] [WEBUI] Paginate Job Table in Jobs ...

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13620#discussion_r71997400
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
    @@ -210,64 +214,69 @@ private[ui] class AllJobsPage(parent: JobsTab) extends WebUIPage("") {
         </script>
       }
     
    -  private def jobsTable(jobs: Seq[JobUIData]): Seq[Node] = {
    +  private def jobsTable(
    +      request: HttpServletRequest,
    +      jobTag: String,
    +      jobs: Seq[JobUIData]): Seq[Node] = {
    +    val allParameters = request.getParameterMap.asScala.toMap
    +    val parameterOtherTable = allParameters.filterNot(_._1.startsWith(jobTag))
    +      .map(para => para._1 + "=" + para._2(0))
    --- End diff --
    
    What does `parameterOtherTable` do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org