You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by EddyVerbruggen <gi...@git.apache.org> on 2016/02/29 13:15:08 UTC
[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...
GitHub user EddyVerbruggen opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66
CB-10727 Dialogs plugin has warnings on iOS
Should fix https://issues.apache.org/jira/browse/CB-10727
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EddyVerbruggen/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit f9252d63430dc6c18b6421d45139d672124c21bf
Author: EddyVerbruggen <ed...@gmail.com>
Date: 2016-02-29T12:14:19Z
CB-10727 Dialogs plugin has warnings on iOS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...
Posted by EddyVerbruggen <gi...@git.apache.org>.
Github user EddyVerbruggen commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190339317
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190240106
Changes look good to me, but how did you get those error messages? If I open CDVNotification.m on Xcode 7.2.1 I don't get them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...
Posted by EddyVerbruggen <gi...@git.apache.org>.
Github user EddyVerbruggen commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190249697
Thanks for checking it so quickly.
What gets reported as warnings depends on how strict your Xcode project is set up. In this case fi. that count warning pops up when you enable 'Sign Comparison' (look for it in the Build Settings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-10727 Dialogs plugin has w...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190252239
Thanks
That shows the NSUIInteger to int conversion warning
To show the 'action' is shadowing an already declared variable I had to change the Hidden Local Variables to YES.
I'll try to merge it latter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org