You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/20 09:14:02 UTC

[GitHub] [flink] sunhaibotb commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking

sunhaibotb commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking
URL: https://github.com/apache/flink/pull/8467#discussion_r285495322
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
 ##########
 @@ -68,7 +69,7 @@
  * will have an input gate attached to it. This will provide its input, which will consist of one
  * subpartition from each partition of the intermediate result.
  */
-public abstract class InputGate implements AutoCloseable {
+public abstract class InputGate implements AsyncDataInput<Optional<BufferOrEvent>>, AutoCloseable {
 
 	public static final CompletableFuture<?> AVAILABLE = CompletableFuture.completedFuture(null);
 
 Review comment:
   The `InputGate#AVAILABLE`  should be removed because the new `AsyncDataInput` interface already has `AVAILABLE`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services