[GitHub] [incubator-superset] suddjian opened a new issue #8655: [SIP] Remove Tabs in SQL Lab

[GitBox <gi...@apache.org>]

suddjian opened a new issue #8655: [SIP] Remove Tabs in SQL Lab
URL: https://github.com/apache/incubator-superset/issues/8655
 
 
   ## [SIP] Remove Tabs in SQL Lab
   
   ### Motivation
   
   We are devoting screen space to a custom tab UI that is less effective than that offered natively by the browser. Other upcoming features such as more powerful edit history/undo, and better navigation/discovery make tabs less important. The new design directions coming from the superset design group specify a tabless UI.
   
   ### Proposed Change
   
   - Remove the tab bar in SQL Lab
   - Include the id of the current query in the SQL Lab url: `myapp.com/superset/sqllab/42`
   - Migration page to avoid deleting users' work
   
   I expect some of the discussion around this SIP to center on timing: which new features should be in place before tabs are removed? Much of the reason for removing tabs is because of features that will be added or changed, such as changes to the query history panel.
   
   Just for reference, here's the design we're working towards. This SIP is not about implementing everything on this screen, only removing the tabs.
   
   <img width="1360" alt="Screen Shot 2019-11-25 at 7 04 12 PM" src="https://user-images.githubusercontent.com/1858430/69596121-60293800-0fb6-11ea-9a8c-e231544eee78.png">
   
   ### New or Changed Public Interfaces
   
   - "Run query in a new tab" button in the query history will open a new browser tab.
   - "Share query" should use the new url format, and should save the query if it hasn't been saved.
   - Links in the saved queries screen and query search should use the new url format.
   - Remove the ctrl-t keyboard shortcut?
   
   ### Migration Plan and Compatibility
   
   Many users will have some unsaved queries from before this change. We can offer them a temporary "manual migration page" of links to open the unsaved work in the new tabless UI, where they can save it. Alternatively we could save any unsaved queries from the tab layout, but I personally prefer the manual migration strategy as it is clearer about what's going on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org