You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/19 18:49:00 UTC
[jira] [Commented] (FLINK-7232) Update checkstyle docs regarding
test inclusion
[ https://issues.apache.org/jira/browse/FLINK-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093599#comment-16093599 ]
ASF GitHub Bot commented on FLINK-7232:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4371
[FLINK-7232] [docs] Update checkstyle docs regarding test inclusion
This PR modifies the checkstyle IDE setup guide to also cover tests, as they are also covered by checkstyle.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7232
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4371
----
commit 4e1c2de4fcab0e342efefda69d09f530ab9c84b6
Author: zentol <ch...@apache.org>
Date: 2017-07-19T18:46:53Z
[FLINK-7232] [docs] Update checkstyle docs regarding test inclusion
----
> Update checkstyle docs regarding test inclusion
> -----------------------------------------------
>
> Key: FLINK-7232
> URL: https://issues.apache.org/jira/browse/FLINK-7232
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle, Documentation
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The checkstyle setup guide says to restrict checkstyle to sources and exclude tests.
> We do however also apply checkstyle to tests, and the documentation should reflect that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)