You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/03/08 10:41:58 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #8127: [HUDI-4911] Following the first patch, fix the inefficient code
danny0405 opened a new pull request, #8127:
URL: https://github.com/apache/hudi/pull/8127
### Change Logs
While I review the HUDI-4911 patch, found 2 code snippet to improve.
### Impact
No impact
### Risk level (write none, low medium or high below)
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8127:
URL: https://github.com/apache/hudi/pull/8127#issuecomment-1461160944
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618",
"triggerID" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"triggerType" : "PUSH"
}, {
"hash" : "f696aa9f8680bcc7a892776133ba78562504ea41",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f696aa9f8680bcc7a892776133ba78562504ea41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7544e6900e877706f0875db52cc10f75a94e6dbb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618)
* f696aa9f8680bcc7a892776133ba78562504ea41 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8127:
URL: https://github.com/apache/hudi/pull/8127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8127:
URL: https://github.com/apache/hudi/pull/8127#issuecomment-1461285182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618",
"triggerID" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"triggerType" : "PUSH"
}, {
"hash" : "f696aa9f8680bcc7a892776133ba78562504ea41",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15627",
"triggerID" : "f696aa9f8680bcc7a892776133ba78562504ea41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f696aa9f8680bcc7a892776133ba78562504ea41 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15627)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8127:
URL: https://github.com/apache/hudi/pull/8127#issuecomment-1461169042
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618",
"triggerID" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"triggerType" : "PUSH"
}, {
"hash" : "f696aa9f8680bcc7a892776133ba78562504ea41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15627",
"triggerID" : "f696aa9f8680bcc7a892776133ba78562504ea41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7544e6900e877706f0875db52cc10f75a94e6dbb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618)
* f696aa9f8680bcc7a892776133ba78562504ea41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15627)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8127:
URL: https://github.com/apache/hudi/pull/8127#issuecomment-1459994023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7544e6900e877706f0875db52cc10f75a94e6dbb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8127:
URL: https://github.com/apache/hudi/pull/8127#discussion_r1129246272
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -287,13 +287,6 @@ private Map<String, Option<HoodieRecord<HoodieMetadataPayload>>> readLogRecords(
.map(record -> Pair.of(record.getRecordKey(), Option.of(record)))
.collect(Collectors.toList());
- // Second, back-fill keys not present in the log-blocks (such that map holds
- // a record for every key being looked up)
- List<String> missingKeys = CollectionUtils.diff(keys, logRecords.keySet());
- for (String key : missingKeys) {
Review Comment:
This is a totally useless code because the invoker already handles this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8127:
URL: https://github.com/apache/hudi/pull/8127#issuecomment-1460124816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618",
"triggerID" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7544e6900e877706f0875db52cc10f75a94e6dbb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8127:
URL: https://github.com/apache/hudi/pull/8127#issuecomment-1461272454
The tests already passed: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=15627&view=results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8127: [HUDI-4911] Following the first patch, fix the inefficient code
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8127:
URL: https://github.com/apache/hudi/pull/8127#issuecomment-1460003289
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618",
"triggerID" : "7544e6900e877706f0875db52cc10f75a94e6dbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7544e6900e877706f0875db52cc10f75a94e6dbb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15618)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org