You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beehive.apache.org by ek...@apache.org on 2006/03/02 19:34:39 UTC
svn commit: r382463 -
/beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/ProcessPopulate.java
Author: ekoneil
Date: Thu Mar 2 10:34:38 2006
New Revision: 382463
URL: http://svn.apache.org/viewcvs?rev=382463&view=rev
Log:
Remove two errant System.err messages that are also printed to the logger.
BB: self
Test: NetUI DRT pass
Modified:
beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/ProcessPopulate.java
Modified: beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/ProcessPopulate.java
URL: http://svn.apache.org/viewcvs/beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/ProcessPopulate.java?rev=382463&r1=382462&r2=382463&view=diff
==============================================================================
--- beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/ProcessPopulate.java (original)
+++ beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/ProcessPopulate.java Thu Mar 2 10:34:38 2006
@@ -41,7 +41,7 @@
/**
* Implement the processPopulate stage of the Struts / PageFlow request
- * processing lifecycle. The {@link #populate(HttpServletRequest, HttpServletResponse, ActionForm, boolean)} method is
+ * processing lifecycle. The {@link #populate(HttpServletRequest, HttpServletResponse, ActionForm, boolean)} method is
* invoked in order to take request parameters from the {@link HttpServletRequest}
* use the key / value pairs from the request to perform an update to the underlying
* JavaBean objects.
@@ -49,7 +49,7 @@
* <br/>
* Updates are performed on a key / value pair if the key is an expression; otherwise,
* the updates are delegated to the Struts processPopulate infrastructure.
- *
+ *
*/
public class ProcessPopulate
{
@@ -70,7 +70,7 @@
private static final Map handlerMap = new HashMap();
/**
- * An inner class that represnts the data that will be used to
+ * An inner class that represnts the data that will be used to
* perform an update. If a key has a prefix handler, this
* node is constructed and passed to the prefix handler
* so that the prefix handler can change the expression or
@@ -79,7 +79,7 @@
public final static class ExpressionUpdateNode
{
public String expression = null;
- public String[] values = null;
+ public String[] values = null;
// can't be constructed outside of this class
private ExpressionUpdateNode() {}
@@ -98,16 +98,16 @@
}
/**
- * Register a {@link org.apache.beehive.netui.pageflow.RequestParameterHandler} that is added to handle a
+ * Register a {@link org.apache.beehive.netui.pageflow.RequestParameterHandler} that is added to handle a
* particular prefix which be present as a prefix to a request parameter
* key. For keys that match the prefix, the key / value from the request
- * are put in an {@link ExpressionUpdateNode} struct and handed to the
+ * are put in an {@link ExpressionUpdateNode} struct and handed to the
* {@link org.apache.beehive.netui.pageflow.RequestParameterHandler} for processing. The returned {@link ExpressionUpdateNode}
* is used to perform an expression update.
*
- * @param prefix the String prefix that will be appended to request paramters that
+ * @param prefix the String prefix that will be appended to request paramters that
* should pass through the {@link RequestParameterHandler} before being updated.
- * @param handler the handler that should handle all request paramters with
+ * @param handler the handler that should handle all request paramters with
* the given <code>prefix</code>
*/
public static void registerPrefixHandler(String prefix, RequestParameterHandler handler)
@@ -145,12 +145,12 @@
}
/**
- * Use the request parameters to populate all properties that have expression keys into
+ * Use the request parameters to populate all properties that have expression keys into
* the underlying JavaBeans.
- * Creates a <code>java.util.Map</code> of objects that will be consumed by
+ * Creates a <code>java.util.Map</code> of objects that will be consumed by
* Struts processPopulate. This includes all request attributes that
* were not expressions
- *
+ *
* @param request the current <code>HttpServletRequest</code>
* @param form if this request references an action and it has an <code>ActionForm</code>
* associated with it, then the <code>form</code> parameter is non-null.
@@ -253,7 +253,6 @@
String s = Bundle.getString("ExprUpdateError", new Object[]{expr, e});
// this is the hairy NetUI Warning that gets printed to the console
- System.err.println(s);
if (_logger.isErrorEnabled()) _logger.error(s);
// add binding errors via PageFlowUtils
@@ -276,8 +275,6 @@
String s = Bundle.getString("ProcessPopulate_exprUpdateError", new Object[]{expr, e});
//e.printStackTrace();
- System.err.println(s);
-
if (_logger.isWarnEnabled()) _logger.warn(s, e);
// add binding errors via PageFlowUtils
@@ -303,17 +300,17 @@
String expr = expression;
if(_logger.isDebugEnabled()) _logger.debug("Found prefixed tag; handlerName: " + key.substring(WLW_TAG_HANDLER_PREFIX.length(), key.indexOf(WLW_TAG_HANDLER_SUFFIX)));
-
+
String handlerName = expression.substring(WLW_TAG_HANDLER_PREFIX.length(), expression.indexOf(WLW_TAG_HANDLER_SUFFIX));
-
+
// execute callback to parameter handler. Generally, these are tags.
RequestParameterHandler handler = (RequestParameterHandler)handlerMap.get(handlerName);
-
+
if(handler != null)
{
expr = expression.substring(expression.indexOf(WLW_TAG_HANDLER_SUFFIX)+1);
-
- if(_logger.isDebugEnabled()) _logger.debug("found handler for prefix \"" + handlerName + "\" type: " +
+
+ if(_logger.isDebugEnabled()) _logger.debug("found handler for prefix \"" + handlerName + "\" type: " +
(handler != null ? handler.getClass().getName() : null) + "\n\t" +
"key: \"" + key + "\" expr: \"" + expr + "\"");