You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/07/26 01:30:27 UTC

[GitHub] [libcloud] gvengel opened a new pull request #1324: Fix proxy url

gvengel opened a new pull request #1324: Fix proxy url
URL: https://github.com/apache/libcloud/pull/1324
 
 
   ## Fix proxy_url support in CloudFiles
   
   ### Description
   
   I ran into a couple issues when trying to use the cloudfiles driver behind an HTTP proxy. 
   
   * libcloud was not configuring the requests library proxy settings correctly.
   * The cloudfiles driver was not passing the proxy into the identity connection.
   * The proxy documentation was referencing the wrong argument name.
   
   This PR closes these issues, but there may be other related issues in other drivers.
   
   ### Status
   
   Done, ready for review. This could probably use some additional tests, and a review of other code for similar bugs. It looks like 2.5.1 has other proxy changes, so I wanted to get the PR in sooner rather than later and kept it simple.
   
   ### Checklist
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [x] Documentation
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services