You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2016/04/14 22:13:12 UTC
Review Request 46221: RU/EU: Unable to start upgrade with host in MM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46221/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-15896
https://issues.apache.org/jira/browse/AMBARI-15896
Repository: ambari
Description
-------
STR:
# Install cluster (e.g HDP 2.3.0.0-2557). One of the hosts should consists from only slaves and clients components (including Phoenix query server)
# Register and install new stack version (e.g 2.4.2.0-195)
# Stop ambari-agent on host without masters
# Turn on Maintenance Mode for this host
# Try to start upgrade.
Result: PHOENIX_QUERY_SERVER is in UNKNOWN state on Maintenance Mode host is preventing upgrade.
The problem here is that the ServicesUpCheck does not take MM into account.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 09ad55d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2153113
ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java c79ec8a
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java caab7df
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 88826a0
Diff: https://reviews.apache.org/r/46221/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 46221: RU/EU: Unable to start upgrade with host in
MM
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46221/#review129080
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On April 14, 2016, 11:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46221/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 11:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-15896
> https://issues.apache.org/jira/browse/AMBARI-15896
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> # Install cluster (e.g HDP 2.3.0.0-2557). One of the hosts should consists from only slaves and clients components (including Phoenix query server)
> # Register and install new stack version (e.g 2.4.2.0-195)
> # Stop ambari-agent on host without masters
> # Turn on Maintenance Mode for this host
> # Try to start upgrade.
> Result: PHOENIX_QUERY_SERVER is in UNKNOWN state on Maintenance Mode host is preventing upgrade.
>
> The problem here is that the ServicesUpCheck does not take MM into account.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 09ad55d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2153113
> ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java c79ec8a
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java caab7df
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 88826a0
>
> Diff: https://reviews.apache.org/r/46221/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 46221: RU/EU: Unable to start upgrade with host in
MM
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46221/#review128986
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 14, 2016, 8:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46221/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 8:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-15896
> https://issues.apache.org/jira/browse/AMBARI-15896
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> # Install cluster (e.g HDP 2.3.0.0-2557). One of the hosts should consists from only slaves and clients components (including Phoenix query server)
> # Register and install new stack version (e.g 2.4.2.0-195)
> # Stop ambari-agent on host without masters
> # Turn on Maintenance Mode for this host
> # Try to start upgrade.
> Result: PHOENIX_QUERY_SERVER is in UNKNOWN state on Maintenance Mode host is preventing upgrade.
>
> The problem here is that the ServicesUpCheck does not take MM into account.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 09ad55d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2153113
> ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java c79ec8a
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java caab7df
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 88826a0
>
> Diff: https://reviews.apache.org/r/46221/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 46221: RU/EU: Unable to start upgrade with host in
MM
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46221/#review129107
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java (line 158)
<https://reviews.apache.org/r/46221/#comment192582>
I think SLAVE_THRESHOLD should be configurable in the UP.
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java (line 206)
<https://reviews.apache.org/r/46221/#comment192583>
isConsideredDown?
- Nate Cole
On April 14, 2016, 4:13 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46221/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 4:13 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-15896
> https://issues.apache.org/jira/browse/AMBARI-15896
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> # Install cluster (e.g HDP 2.3.0.0-2557). One of the hosts should consists from only slaves and clients components (including Phoenix query server)
> # Register and install new stack version (e.g 2.4.2.0-195)
> # Stop ambari-agent on host without masters
> # Turn on Maintenance Mode for this host
> # Try to start upgrade.
> Result: PHOENIX_QUERY_SERVER is in UNKNOWN state on Maintenance Mode host is preventing upgrade.
>
> The problem here is that the ServicesUpCheck does not take MM into account.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 09ad55d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 2153113
> ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java c79ec8a
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java caab7df
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 88826a0
>
> Diff: https://reviews.apache.org/r/46221/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>