You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/12 02:48:46 UTC

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #14931: Re-enable static cached_op optimization

ZhennanQin commented on a change in pull request #14931: Re-enable static cached_op optimization
URL: https://github.com/apache/incubator-mxnet/pull/14931#discussion_r283117269
 
 

 ##########
 File path: src/imperative/cached_op.cc
 ##########
 @@ -705,8 +705,10 @@ void CachedOp::StaticRunOps(
           arg_shapes.emplace_back(ndinput->shape());
           arg_dtypes.emplace_back(ndinput->dtype());
         }
-        state.op_states[i] = createop[node.source->op()](
-            node.source->attrs, default_ctx, arg_shapes, arg_dtypes);
+        if (!config_.static_shape) {
 
 Review comment:
   This is the only changed line to fix this PR. We should re-create op state if `static_shape` is false.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services