[GitHub] [superset] kasiazjc commented on pull request #21244: fix: dataset exists error in save Dataset modal

[GitBox <gi...@apache.org>]

kasiazjc commented on PR #21244:
URL: https://github.com/apache/superset/pull/21244#issuecomment-1231573018

   > @AAfghahi from the video it appears that the modals close and reopen when the error occurs. It does not look ideal for the end user. How hard would it be to wait for the response and then only close the modal when successful and leave it open when unsuccessful? This would avoid the quick close-reopen behaviour currently shown in the video.
   > 
   > Also, I am not sure if it makes more sense to show this error inline in the form? @kasiazjc what you think?
   
   Definitely agree with @geido. Errors should be shown in context, so it would be better to use inline info type. Toast can be easily missed by the user and this pattern is not intuitive. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org