You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/02/26 11:39:32 UTC
Review Request 70058: RANGER-2339: UI changes for User role users
should also have access to Security Zone
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70058/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2339
https://issues.apache.org/jira/browse/RANGER-2339
Repository: ranger
Description
-------
User role user should be able to view the "Security Zone" tab and should get access to security zones.
Expected Result: "Security Zone" tab should be visible to user role user also. Operations on zones (create/update/delete) should be restricted to admin users only (system-wide admin)
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java db3d3d6
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java baded45
security-admin/src/main/webapp/scripts/models/RangerZone.js 4b667d5
security-admin/src/main/webapp/scripts/views/common/TopNav.js e08d4a2
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 50d2237
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 2f5b8bb
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js f9818d6
security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 9630db8
security-admin/src/main/webapp/styles/xa.css 7fb868d
security-admin/src/main/webapp/templates/common/TopNav_tmpl.html b63ae90
security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 75c0b90
Diff: https://reviews.apache.org/r/70058/diff/1/
Testing
-------
Verified:
1. All roles user is able to view Security Zone tab except 'Keyadmin' & 'KMSAuditor' role users
2. Only Admin role users is able to perform operations on zones.
Thanks,
Nitin Galave
Re: Review Request 70058: RANGER-2339: UI changes for User role users
should also have access to Security Zone
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70058/#review213330
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Feb. 26, 2019, 11:39 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70058/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2019, 11:39 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2339
> https://issues.apache.org/jira/browse/RANGER-2339
>
>
> Repository: ranger
>
>
> Description
> -------
>
> User role user should be able to view the "Security Zone" tab and should get access to security zones.
> Expected Result: "Security Zone" tab should be visible to user role user also. Operations on zones (create/update/delete) should be restricted to admin users only (system-wide admin)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java db3d3d6
> security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java baded45
> security-admin/src/main/webapp/scripts/models/RangerZone.js 4b667d5
> security-admin/src/main/webapp/scripts/views/common/TopNav.js e08d4a2
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 50d2237
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 2f5b8bb
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js f9818d6
> security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 9630db8
> security-admin/src/main/webapp/styles/xa.css 7fb868d
> security-admin/src/main/webapp/templates/common/TopNav_tmpl.html b63ae90
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 75c0b90
>
>
> Diff: https://reviews.apache.org/r/70058/diff/1/
>
>
> Testing
> -------
>
> Verified:
> 1. All roles user is able to view Security Zone tab except 'Keyadmin' & 'KMSAuditor' role users
> 2. Only Admin role users is able to perform operations on zones.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 70058: RANGER-2339: UI changes for User role users
should also have access to Security Zone
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70058/#review213382
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On Feb. 26, 2019, 11:39 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70058/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2019, 11:39 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2339
> https://issues.apache.org/jira/browse/RANGER-2339
>
>
> Repository: ranger
>
>
> Description
> -------
>
> User role user should be able to view the "Security Zone" tab and should get access to security zones.
> Expected Result: "Security Zone" tab should be visible to user role user also. Operations on zones (create/update/delete) should be restricted to admin users only (system-wide admin)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java db3d3d6
> security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java baded45
> security-admin/src/main/webapp/scripts/models/RangerZone.js 4b667d5
> security-admin/src/main/webapp/scripts/views/common/TopNav.js e08d4a2
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 50d2237
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 2f5b8bb
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js f9818d6
> security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 9630db8
> security-admin/src/main/webapp/styles/xa.css 7fb868d
> security-admin/src/main/webapp/templates/common/TopNav_tmpl.html b63ae90
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 75c0b90
>
>
> Diff: https://reviews.apache.org/r/70058/diff/1/
>
>
> Testing
> -------
>
> Verified:
> 1. All roles user is able to view Security Zone tab except 'Keyadmin' & 'KMSAuditor' role users
> 2. Only Admin role users is able to perform operations on zones.
>
>
> Thanks,
>
> Nitin Galave
>
>