[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10396: Ignite-17793 : Historical rebalance must use HWM instead of LWM, v2: store pending counter instead

[GitBox <gi...@apache.org>]

timoninmaxim commented on code in PR #10396:
URL: https://github.com/apache/ignite/pull/10396#discussion_r1038436438


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManager.java:
##########
@@ -670,7 +670,12 @@ interface CacheDataStore {
         long updateCounter();
 
         /**
-         * @return Reserved counter (HWM).
+         * @return Highest applied update counter (HWM).

Review Comment:
   Let's discuss terms again. From my understanding, `highestAppliedCounter != HWM` but `reservedCounter == HWM`. My understanding is based on the Ignite design doc about data consistency [1]. 
   
   Occasionally, we can say that a backup is aware of only `highestAppliedCounter` and then it can think about it as HWM. But backups don't send them to other nodes, then it just a useless info. From the other side primary nodes are aware of `reservedCounter` as the highest known counter value, and use it to send to other nodes. 
   
   [1] https://cwiki.apache.org/confluence/display/IGNITE/Data+consistency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org